Commit Graph

975 Commits

Author SHA1 Message Date
Johann Hofmann
d3d2546bda Bug 1645234 - Add more warnings to document.requestStorageAccess(). r=annevk,englehardt,baku
The only common failure case that's not being warned about now is when the user
rejected the prompt, which I think is expected behavior.

Differential Revision: https://phabricator.services.mozilla.com/D79597
2020-07-15 18:52:12 +00:00
Csoregi Natalia
55e9fe527f Backed out 3 changesets (bug 1645234) for causing leaks. CLOSED TREE
Backed out changeset 6097753dbefa (bug 1645234)
Backed out changeset f74844ba692a (bug 1645234)
Backed out changeset a90a3c1efdc5 (bug 1645234)
2020-07-10 01:54:09 +03:00
Johann Hofmann
b415f7652c Bug 1645234 - Add more warnings to document.requestStorageAccess(). r=annevk,englehardt,baku
The only common failure case that's not being warned about now is when the user
rejected the prompt, which I think is expected behavior.

Differential Revision: https://phabricator.services.mozilla.com/D79597
2020-07-09 20:12:49 +00:00
Andreea Pavel
4d223b739e Backed out 3 changesets (bug 1645234) for failing browser_webconsole_requestStorageAccess_errors.js on a CLOSED TREE
Backed out changeset ad1f8a4d64cf (bug 1645234)
Backed out changeset 6de9007aa306 (bug 1645234)
Backed out changeset 87d5d468c7f2 (bug 1645234)
2020-07-09 13:05:14 +03:00
Johann Hofmann
c33110dbf2 Bug 1645234 - Add more warnings to document.requestStorageAccess(). r=annevk,englehardt,baku
The only common failure case that's not being warned about now is when the user
rejected the prompt, which I think is expected behavior.

Differential Revision: https://phabricator.services.mozilla.com/D79597
2020-07-09 08:54:50 +00:00
Sebastian Streich
8ccf28a8ba Bug 1614969 - Check download with MixedContentBlocker r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D73302
2020-07-08 15:25:43 +00:00
Razvan Maries
8e16712a62 Backed out 3 changesets (bug 1645234) for build bustages and Lint failure. CLOSED TREE
Backed out changeset 75276e64701b (bug 1645234)
Backed out changeset 16212aa46253 (bug 1645234)
Backed out changeset e66593529bc3 (bug 1645234)
2020-07-04 18:44:49 +03:00
Johann Hofmann
1b47c026a0 Bug 1645234 - Add more warnings to document.requestStorageAccess(). r=annevk,englehardt,baku
The only common failure case that's not being warned about now is when the user
rejected the prompt, which I think is expected behavior.

Differential Revision: https://phabricator.services.mozilla.com/D79597
2020-07-04 14:58:50 +00:00
sefeng
c284f742fe Bug 1648877 - Deny the fullscreen request if the element is dialog r=smaug
Per fullscreen api spec,
https://fullscreen.spec.whatwg.org/#dom-element-requestfullscreen,
fullscreen request should be denied if the requesting element is
<dialog>

Differential Revision: https://phabricator.services.mozilla.com/D81615
2020-07-02 15:47:39 +00:00
Butkovits Atila
e6f3141f9a Backed out changeset 2df0c2a2f866 (bug 1614969) for asertion failure on base/LoadInfo.cpp. 2020-06-30 21:47:17 +03:00
Sebastian Streich
5bb89780fa Bug 1614969 - Check download with MixedContentBlocker r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D73302
2020-06-30 16:29:22 +00:00
Cosmin Sabou
7ece4fe886 Backed out 1 changesets (bug 1648877) for mochitest failures on test_bug1648877_dialog_fullscreen_denied.html. CLOSED TREE
Backed out changeset bfd857646de4 (bug 1648877)
2020-06-30 20:00:28 +03:00
sefeng
6d945fa759 Bug 1648877 - Deny the fullscreen request if the element is dialog r=smaug
Per fullscreen api spec,
https://fullscreen.spec.whatwg.org/#dom-element-requestfullscreen,
fullscreen request should be denied if the requesting element is
<dialog>

Differential Revision: https://phabricator.services.mozilla.com/D81615
2020-06-30 10:03:04 +00:00
Delan Azabani
5dc229e516 Bug 1630935 - Add use counter and deprecation warning for STIXGeneral fonts. r=emilio
This patch adds the boolean pref mathml.stixgeneral_operator_stretching.disabled, which defaults to true iff nightly.

When the pref is true, stretched operators won’t be rendered with STIXGeneral, because we only use OpenType MATH tables (in fonts that have them) or the generic Unicode table.

When the pref is false, we continue to support STIXGeneral for stretched operators, but warn the author in devtools and bump the use counter (up to once per page). This only happens when a stretched operator actually uses STIXGeneral: not when we successfully render the operator with some other font earlier in the font-family stack, and not when STIXGeneral isn’t installed.

Differential Revision: https://phabricator.services.mozilla.com/D73833
2020-06-25 04:20:57 +00:00
Razvan Maries
c54f50f342 Backed out changeset a10fc7b299ff (bug 1614969) for build bustages on nsContentSecurityUtils.cpp. CLOSED TREE 2020-06-24 13:23:02 +03:00
Sebastian Streich
a9516ee4f5 Bug 1614969 - Check download with MixedContentBlocker r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D73302
2020-06-24 09:54:50 +00:00
Honza Bambas
3f23870623 Bug 1603542 - Log a warning in the web console when a preloaded resource is not used, r=Harald
Differential Revision: https://phabricator.services.mozilla.com/D76527
2020-06-23 17:18:20 +00:00
Butkovits Atila
c112069ef0 Backed out changeset 3685f83e0dc0 (bug 1614969) as requested by dev. 2020-06-23 15:22:21 +03:00
Sebastian Streich
d8ff61ded5 Bug 1614969 - Check download with MixedContentBlocker r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D73302
2020-06-23 11:30:28 +00:00
Eitan Isaacson
3267d4f31f Bug 1639048 - Don't traverse into labels. r=Jamie
Labels are often used as primary click targets for related inputs. If
they are styled to certain bounds, but contain overflowing text for a11y
with a color of "transparent", the synthesized click will happen outside
the bounds of the label.

If we skip text leafs with "color: transparent", we will skip labels
altogether. Instead, lets land on labels when traversing, and ignore
its subtree.

Differential Revision: https://phabricator.services.mozilla.com/D77898
2020-06-22 22:03:58 +00:00
Narcis Beleuzu
aaf25b6782 Backed out changeset b408bd393d95 (bug 1639048) for gv-junit failures on test.AccessibilityTest.testCheckbox . CLOSED TREE 2020-06-22 23:41:28 +03:00
Eitan Isaacson
06217d0c54 Bug 1639048 - Don't traverse into labels. r=Jamie
Labels are often used as primary click targets for related inputs. If
they are styled to certain bounds, but contain overflowing text for a11y
with a color of "transparent", the synthesized click will happen outside
the bounds of the label.

If we skip text leafs with "color: transparent", we will skip labels
altogether. Instead, lets land on labels when traversing, and ignore
its subtree.

Differential Revision: https://phabricator.services.mozilla.com/D77898
2020-06-22 18:16:30 +00:00
Gijs Kruitbosch
19220a3149 Bug 1644863 - fix trailing whitespace and windows line endings in locale files, r=fluent-reviewers,flod,Pike
Differential Revision: https://phabricator.services.mozilla.com/D79203
2020-06-17 22:46:22 +00:00
Noemi Erli
22b81ffefa Backed out 2 changesets (bug 1603542) for causing assertion failures in Loader.cpp CLOSED TREE
Backed out changeset cc70c96b63e0 (bug 1603542)
Backed out changeset c3dcacdd97c4 (bug 1603542)
2020-06-17 18:37:45 +03:00
Honza Bambas
4570854a4c Bug 1603542 - Log a warning in the web console when a preloaded resource is not used, r=Harald
Differential Revision: https://phabricator.services.mozilla.com/D76527
2020-06-17 14:06:50 +00:00
Jon Coppeard
b2762155a5 Bug 1566307 - Improve the error generated when resolution of a module specifier fails r=hsivonen
This combines the two places where an error was generated for this into one and adds localiation for the message. The message is improved as requested in the bug.

Differential Revision: https://phabricator.services.mozilla.com/D79862
2020-06-16 18:40:17 +00:00
Nika Layzell
cde53b3bec Bug 1508306 - Part 1: Migate the Large-Allocation handler to DocumentLoadListener, r=mattwoodrow,necko-reviewers,geckoview-reviewers,agi,valentin
This removes the diagnostic warnings which used to be logged when the
Large-Allocation header was present, but failed to switch into a
Large-Allocation process. Due to the low adoption of the header, this shouldn't
be too large of a problem, but we can look into re-adding the diagnostics if
needed in the future.

The new codepath no longer performs multiple network requests for
Large-Allocation resources, and now relies on the battle-tested
DocumentLoadListener codepath for process switching.

Differential Revision: https://phabricator.services.mozilla.com/D78998
2020-06-15 23:24:07 +00:00
Narcis Beleuzu
a8dde16e58 Backed out 10 changesets (bug 1508306, bug 1640019) for bc failures on browser_autoOpen.js . CLOSED TREE
Backed out changeset 8844170ff408 (bug 1508306)
Backed out changeset b750f1d873cf (bug 1508306)
Backed out changeset c7170e76e676 (bug 1640019)
Backed out changeset 5905995e4815 (bug 1640019)
Backed out changeset 7bf86513348e (bug 1640019)
Backed out changeset f7d0605295f7 (bug 1640019)
Backed out changeset 521b4d5a9a89 (bug 1640019)
Backed out changeset 8542edc564bc (bug 1640019)
Backed out changeset 4f6a03152526 (bug 1640019)
Backed out changeset 30d2bf04719b (bug 1640019)
2020-06-12 22:47:50 +03:00
Nika Layzell
47c0aeb539 Bug 1508306 - Part 1: Migate the Large-Allocation handler to DocumentLoadListener, r=mattwoodrow,necko-reviewers,geckoview-reviewers,agi,valentin
This removes the diagnostic warnings which used to be logged when the
Large-Allocation header was present, but failed to switch into a
Large-Allocation process. Due to the low adoption of the header, this shouldn't
be too large of a problem, but we can look into re-adding the diagnostics if
needed in the future.

The new codepath no longer performs multiple network requests for
Large-Allocation resources, and now relies on the battle-tested
DocumentLoadListener codepath for process switching.

Differential Revision: https://phabricator.services.mozilla.com/D78998
2020-06-12 16:52:13 +00:00
Jonathan Kingston
d7420f10fd Bug 1359867 - Add support for allow-top-navigation-by-user-activation iframe sandboxing r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D77430
2020-06-01 12:46:31 +00:00
Alex Chronopoulos
3e4dc03513 Bug 1636515 - Handle cycle in media element when it is fed with the captured stream. r=padenot
Feeding a media element with the captured stream from the same media element does not make sense. Currently the spec does not mention anything about it. I'll clarify the case in the spec. In the meantime, when a cycle is detected, the setting of the `srcObject` is ignored and a warning is produced in the console.

Differential Revision: https://phabricator.services.mozilla.com/D76821
2020-05-28 13:07:53 +00:00
Tom Tung
ed2823830e Bug 1601594 - P1 - Using Origin as the key for DocGroup; r=farre,nika
Differential Revision: https://phabricator.services.mozilla.com/D70347
2020-05-25 12:51:29 +00:00
prathiksha
f247187965 Bug 1634947 - Update the TLS deprecated error message in Firefox. r=johannh,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D77021
2020-05-27 21:58:30 +00:00
Dorel Luca
cb70b659d6 Backed out changeset 0440fa5863b2 (bug 1634947) for Devtools failures in browser_webconsole_certificate_messages.js . CLOSED TREE 2020-05-27 17:52:28 +03:00
prathiksha
18ae80df9c Bug 1634947 - Update the TLS deprecated error message in Firefox. r=johannh,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D77021
2020-05-27 11:43:20 +00:00
Tom Tung
d9d34b2983 Bug 1605176 - Send a error message data and cause a message error on the receiver side when the message data contains a shared memory object in BrowsingContext::PostMessageMoz; r=baku,kmag
Differential Revision: https://phabricator.services.mozilla.com/D75035
2020-05-20 08:27:16 +00:00
Razvan Maries
481517ce87 Backed out 2 changesets (bug 1558394) for perma failures on iframe_sandbox_anchor_download_block_downloads.sub.tentative.html. CLOSED TREE
Backed out changeset 79046ff8143b (bug 1558394)
Backed out changeset e13ede3c68d4 (bug 1558394)
2020-05-15 19:18:34 +03:00
Sebastian Streich
6733f1311c Bug 1558394 - Block downloads in sandboxed iframes r=ckerschb,smaug
Differential Revision: https://phabricator.services.mozilla.com/D67351
2020-05-15 14:03:43 +00:00
Bogdan Tara
edcb53f163 Backed out 2 changesets (bug 1558394) for nsDocShellLoadState related bustage CLOSED TREE
Backed out changeset 5889105bd089 (bug 1558394)
Backed out changeset 80a0ea17c9f8 (bug 1558394)
2020-05-14 15:17:32 +03:00
Sebastian Streich
bb85ae41b1 Bug 1558394 - Block downloads in sandboxed iframes r=ckerschb,smaug
Differential Revision: https://phabricator.services.mozilla.com/D67351
2020-05-14 10:05:55 +00:00
Eitan Isaacson
c1c0b3551c Bug 1625184 - Map dialogs and alert dialogs correctly in Mac. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D74957
2020-05-13 05:59:23 +00:00
Christoph Kerschbaumer
9b6415635d Bug 1637193: Warn not only once but every time we are loading mixed object subrequest including the soon to be blocked URI. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D74824
2020-05-12 10:16:52 +00:00
Dana Keeler
e8ebc73d50 Bug 1630038 - remove HPKP entirely r=kjacobs,bbeurdouche
This removes processing of HTTP Public Key Pinning headers, remotely modifying
pinning information, and using cached pinning information, all of which was
already disabled in bug 1412438. Static pins that ship with the browser are
still enforced.

Differential Revision: https://phabricator.services.mozilla.com/D73352
2020-05-06 22:57:50 +00:00
Emilio Cobos Álvarez
00e31bd957 Bug 1634840 - Remove warning about inlines in XUL. r=dbaron
It's not like we're going to change behavior here anytime soon anymore
(other than removing XUL usage), and the helpfulness of the warning has
probably decreased with time.

But maybe I'm missing a reason why it should be kept around?

Differential Revision: https://phabricator.services.mozilla.com/D73544
2020-05-05 23:57:55 +00:00
Eitan Isaacson
d09e5861c1 Bug 1628922 - Support landmark navigation in GeckoView. r=Jamie
Added a traversal rule and piped through xml-roles as role descriptions.

Differential Revision: https://phabricator.services.mozilla.com/D70950

--HG--
extra : moz-landing-system : lando
2020-04-15 22:12:37 +00:00
Andrea Marchesini
c059e75bef Bug 631862 - Improve X-Frame-Options error report, r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D65699

--HG--
extra : moz-landing-system : lando
2020-04-14 17:43:51 +00:00
Erik Nordin
8dfda8ef7c Bug 1621849 - Add CSS Error for DisallowedImportRule r=emilio
- Add new CSS Error
- Add new test case for error
- Ensure that test cases use `replace()` and `replaceSync()`

Differential Revision: https://phabricator.services.mozilla.com/D69423

--HG--
extra : moz-landing-system : lando
2020-04-08 22:45:24 +00:00
Morgan Reschenberg
53fcf5a7d2 Bug 1617311: Add details/summary attributes and values. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D67233

--HG--
extra : moz-landing-system : lando
2020-03-27 22:08:40 +00:00
JulianWels
b9a66ff272 Bug 1622028 - Log failed upgrades for HTTPS Only Mode. r=ckerschb,dragana
Differential Revision: https://phabricator.services.mozilla.com/D68026

--HG--
extra : moz-landing-system : lando
2020-03-27 17:09:15 +00:00
Emilio Cobos Álvarez
266c1d0b6c Bug 1528305 - Don't show an error page for unknown protocols for page-triggered navigations that replace a document. r=mattwoodrow
Pages apparently do this to try to open to native apps, and that on Firefox
causes an error page to be shown if the app is not installed, which is pretty
bad.

Differential Revision: https://phabricator.services.mozilla.com/D68471

--HG--
extra : moz-landing-system : lando
2020-03-27 17:20:14 +00:00