9286 Commits

Author SHA1 Message Date
Kagami Sascha Rosylight
73ec445d30 Bug 1360715 - Part 2: Modify instanceofs in tests to non-cross-context r=edgar
Differential Revision: https://phabricator.services.mozilla.com/D106662
2021-03-04 15:05:26 +00:00
Jan-Erik Rediger
4a219f294b Bug 1695197 - Remove MOZ_GLEAN constant, introduce MOZ_GLEAN_ANDROID. r=chutten,emilio
We enable compilation of FOG/Glean on _all_ platforms.
We disable Glean initialization and metric recording on Android (GeckoView) by respecting MOZ_GLEAN_ANDROID.
This way GeckoView just works, consumers don't need to think about it (except in tests, these need to be disabled for Android builds).

Stubbing out the metric implementations will happen in the commits after
this one.

Differential Revision: https://phabricator.services.mozilla.com/D106766
2021-03-04 11:15:12 +00:00
Mike Conley
f1a82bcd16 Bug 1696286 - Make it possible for PopupNotifications to be visually unopinionated. r=Gijs
Being 'visually unopinionated' means not showing distinct styling for the main action.

Differential Revision: https://phabricator.services.mozilla.com/D107128
2021-03-04 00:54:01 +00:00
Andreea Pavel
002023eb26 Merge autoland to mozilla-central a=merge 2021-03-03 23:49:23 +02:00
Neil Deakin
2ffa311fe8 Bug 1694027, use the body's scrollHeight to compute the scroll area is it is available, r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D106044
2021-03-03 15:02:55 +00:00
Sebastian Hengst
7916a12f4f Backed out 2 changesets (bug 1528289) for breaking navigation with clicks after user scrolled by clicking with middle mouse button. a=backout
Backed out changeset 33c7b633ada2 (bug 1528289)
Backed out changeset be5cf87707f9 (bug 1528289)
2021-03-03 14:29:12 +01:00
Florian Quèze
8e0285b790 Bug 1693877 - Closing tabs should not trigger the finder lazy getter, r=mikedeboer.
Differential Revision: https://phabricator.services.mozilla.com/D105956
2021-03-03 10:50:20 +00:00
Jens Stutte
05581ddca4 Bug 1678330: Ensure nested SpinEventLoopUntil(OrShutdown) calls are traceable to the originating source in case of crash. r=nika,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D106839
2021-03-02 22:11:58 +00:00
Cosmin Sabou
b2eb620ed0 Backed out changeset 03cae7800b41 (bug 1678330) for mochitest plain failures on test_window_open_discarded_bc.html. CLOSED TREE 2021-03-02 20:18:21 +02:00
Jens Stutte
a0af9ea0a4 Bug 1678330: Ensure nested SpinEventLoopUntil(OrShutdown) calls are traceable to the originating source in case of crash. r=nika,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D106839
2021-03-02 15:15:20 +00:00
Masayuki Nakano
9b7cc9e1ca Bug 1695499 - Make browser_f7_caret_browsing.js wait async F7 key handling for toggling caret browsing r=Gijs
After fixing bug 1520263, `F7` key handling in chrome becomes async when
focused element is a remote content.  Therefore, the test should wait a
reply event from remote content in the cases.

Differential Revision: https://phabricator.services.mozilla.com/D106749
2021-03-02 00:45:32 +00:00
Masayuki Nakano
77d74d9e73 Bug 1528289 - part 2: Dispatch same events on the web contents when autoscroll is canceled with a click r=Gijs,edgar
Chrome behaves like this:

1. When user starts autoscroll with a middle click, `mousedown` and `mouseup`
   are fired, but `auxclick` nor `paste` event is not fired.
2. When user ends autoscroll with a left click, only `mouseup` event is fired.
   I.e, `mousedown` nor `click` event is not fired.
3. When user ends autoscroll with a middle click, only `mouseup` event is fired.
   I.e., `mousedown`, `auxclick` nor `paste` events is not fired.
4. When user ends autoscroll with a right click, `mouseup` and `contextmenu`
   events are fired, but `mousedown` and `auxclick` events are not fired.

This patch emulates these Chrome's behavior as far as possible.  However,
unfortunately, we cannot do exactly same behavior without some big patches
because each widget (`nsWindow` or `nsChildView`) discards a mouse event
which rolled up a widget before dispatching it into the DOM.  Therefore,
for now, this patch does not fix the following issues:

1. `mousedown` event is not fired in content when clicking outside the
   autoscroller to close it except when pressing the secondary button or on any
   buttons on Linux.
2. `mouseup` event is not fired in content when clicking outside the
   autoscroller to close it except when pressing the primary button macOS.
3. `click` event and `auxclick` events are fired when clicking outside the
   autoscroller with the secondary button.

So, the middle button `click`/`auxclick` events and `paste` event which is
reported to the bug won't be fired with this patch.  I'll file follow up bugs.

Differential Revision: https://phabricator.services.mozilla.com/D104652
2021-03-01 22:57:07 +00:00
Michelle Goossens
0dcdff469a Bug 1692339 - Add a "Redo" option underneath "Undo" in context menu for form fields r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D106565
2021-02-27 01:19:38 +00:00
Butkovits Atila
961b11bc3b Backed out changeset a2091ee84e0e (bug 1692339) for causing failures at browser_contextmenu_keyword.js. CLOSED TREE 2021-02-27 01:23:52 +02:00
Michelle Goossens
78395cc0e6 Bug 1692339 - Add a "Redo" option underneath "Undo" in context menu for form fields r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D106565
2021-02-26 20:04:29 +00:00
Neil Deakin
f66ba76299 Bug 1691499, add a link field to notification bar buttons to use a link instead, convert learn more buttons in notification bars to links, r=mstriemer,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D105750
2021-02-26 13:43:10 +00:00
Jared Wein
5810ee434c Bug 1665390 - Style bookmarks toolbar and tabs toolbar tooltips. r=NeilDeakin,ntim
Differential Revision: https://phabricator.services.mozilla.com/D104257
2021-02-25 20:47:54 +00:00
Cosmin Sabou
253c39a17a Backed out changeset 36b76c196497 (bug 1691499) for bc failures on browser_decoderDoctor.js. CLOSED TREE 2021-02-25 21:47:25 +02:00
Emilio Cobos Álvarez
c24f9921f2 Bug 1694413 - Account for panel animations in the test.
MANUAL PUSH: Avoids orange on OSX on a CLOSED TREE.
2021-02-25 16:57:42 +01:00
Emilio Cobos Álvarez
8743599d19 Bug 1676078 - Try to fix and re-enable test_datepicker_keyboard_open. r=Gijs
Now that we have a saner setup for popup hiding / showing.

Differential Revision: https://phabricator.services.mozilla.com/D106474
2021-02-25 14:30:34 +00:00
Emilio Cobos Álvarez
fe58c377b3 Bug 1694413 - Use hidePopup rather than the hidden attribute to hide datetime picker. r=Gijs
On macos re-showing it without using `hidden` can cause, apparently,
extra popuphidden events. Let's do the right thing and close the popup
properly using hidePopup().

This code wasn't being hit before bug 1339380 because we relied on the
parent side to hide it, which did correctly fire the events.

Differential Revision: https://phabricator.services.mozilla.com/D106431
2021-02-25 14:13:14 +00:00
Neil Deakin
86db2fec08 Bug 1691499, add a link field to notification bar buttons to use a link instead, convert learn more buttons in notification bars to links, r=mstriemer,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D105750
2021-02-25 12:00:39 +00:00
Michelle Goossens
46dd0460da Bug 1692670 - Remove separator between delete and "select all" in the content context menu r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D105992
2021-02-24 17:54:03 +00:00
Tim Nguyen
159428759d Bug 1590884 - Move XUL accesskey handling to DOM and remove nsXULLabelFrame. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D106233
2021-02-24 14:46:28 +00:00
Emilio Cobos Álvarez
15ff419df0 Bug 1694059 - Rename various nnt prefs. r=spohl,mstange
As per feedback in D105931.

Differential Revision: https://phabricator.services.mozilla.com/D105991
2021-02-22 20:05:35 +00:00
Stephen A Pohl
ca8b4e2c68 Bug 1693950: Ensure that chrome tests continue to use the native theme to not lose test coverage since we do not intend to enable the non-native theme in chrome at this time. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D105856
2021-02-22 13:12:17 +00:00
Itiel
127183db97 Bug 1693663 - Add dark mode support for about:serviceworkers r=ntim,asuth
Differential Revision: https://phabricator.services.mozilla.com/D105689
2021-02-19 09:08:29 +00:00
Itiel
05d88b715b Bug 1692301 - Add dark mode support for about:buildconfig r=mconley,glandium
Also make it so it'd match the style of other about: pages.

Differential Revision: https://phabricator.services.mozilla.com/D104877
2021-02-18 22:05:09 +00:00
Dorel Luca
7c23ebad3e Backed out changeset 4a3f1073b7b5 (bug 1693176) for Browser-chrome failures in extensions/test/browser/browser_ext_browserAction_contextMenu.js. CLOSED TREE 2021-02-18 20:43:58 +02:00
Emilio Cobos Álvarez
1ab6cf4876 Bug 1693176 - Destroy frames of contents inside panels. r=Gijs
Panels don't rely so much on the popup manager code to deal with
menuitems etc, so this is trivial and fixes the issue as reported.

I think it's pretty unlikely to have animated stuff in menulists /
menupopups, so this should get us most of the way.

Differential Revision: https://phabricator.services.mozilla.com/D105550
2021-02-18 16:44:12 +00:00
Gijs Kruitbosch
21285db89d Bug 1693406 - fix select dropdown styling in proton when the page customizes it, r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D105642
2021-02-18 16:33:20 +00:00
Michael Cooper
a1fa813296 Bug 1474397 - Show Normandy information in about:support r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D104910
2021-02-17 18:01:58 +00:00
Makoto Kato
c0bbdf3d86 Bug 1644737 - Remove NativeCrypto in mozglue. r=mhoye,geckoview-reviewers,agi
NativeCrypto code was used by Firefox sync in Fennec. But since Fennec code
is gone, no one seems to use this.

Differential Revision: https://phabricator.services.mozilla.com/D101458
2021-02-15 05:59:14 +00:00
Gijs Kruitbosch
23c1d25676 Bug 1685313 - fix tests to pass with either the new or old window modal dialogs, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D104703
2021-02-12 22:41:54 +00:00
Gijs Kruitbosch
b0c70ac17d Bug 1685313 - allow window modal dialogs to display inside windows, r=jaws,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D103388
2021-02-12 22:41:53 +00:00
Itiel
53756fde5b Bug 1689480 - Changes to about:telemetry checkbox and radiobuttons to accomodate for the added margin-block r=ntim
This also gets rid of the non clickable area between the checkbox/radiobuttons and their label.

Differential Revision: https://phabricator.services.mozilla.com/D103399
2021-02-12 17:05:27 +00:00
Itiel
22f701962b Bug 1689480 - Changes to about:url-classifier checkboxes to accomodate for the added margin-block r=dimi
This also makes the labels themselves clickable, and not just the checkboxes.

Differential Revision: https://phabricator.services.mozilla.com/D103401
2021-02-12 17:05:25 +00:00
Itiel
5cc0ada0fb Bug 1689480 - Changes to about:networking checkbox to accomodate for the added margin-block r=ntim
This also gets rid of the non clickable area between the checkbox and its label.

Differential Revision: https://phabricator.services.mozilla.com/D103398
2021-02-12 17:05:25 +00:00
Andreea Pavel
c9c6e3158d Backed out 3 changesets (bug 1685313) for failing test_prompt.html on a CLOSED TREE
Backed out changeset 7bdcbdc2d57f (bug 1685313)
Backed out changeset 319bc4d7bc0d (bug 1685313)
Backed out changeset 713de42fe3b4 (bug 1685313)
2021-02-12 06:50:58 +02:00
Tim Nguyen
1a337bb3b7 Bug 1691313 - Use hidden DOM property instead of attribute methods in toolkit/. r=mtigley,preferences-reviewers,jaws
Differential Revision: https://phabricator.services.mozilla.com/D104777
2021-02-12 02:05:49 +00:00
Neil Deakin
edec05a07b Bug 1690791, update the scroll tick marks when the browser window is resized. In addition, this ensures that the tick marks update when the scrollbar is made visible after resizing the content area, r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D104319
2021-02-12 00:51:19 +00:00
Gijs Kruitbosch
3a51301262 Bug 1685313 - fix tests to pass with either the new or old window modal dialogs, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D104703
2021-02-11 23:57:58 +00:00
Gijs Kruitbosch
86da8f87a3 Bug 1685313 - allow window modal dialogs to display inside windows, r=jaws,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D103388
2021-02-11 23:57:57 +00:00
Emma Malysz
1d2e60b9a5 Bug 1687703, add telemetry for browser.engagement.ctrlTab.has-used pref r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D104739
2021-02-11 22:21:16 +00:00
Mark Banner
3ef6acac59 Bug 1608272 - Remove 'this' as the second argument to 'ChromeUtils.import', use object destructuring instead (application changes). r=geckoview-reviewers,Gijs,agi
Differential Revision: https://phabricator.services.mozilla.com/D104684
2021-02-11 22:02:15 +00:00
Mark Banner
263d555274 Bug 1608272 - Remove 'this' as the second argument to 'ChromeUtils.import', use object destructuring instead (test-only changes). r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D104683
2021-02-11 22:02:15 +00:00
Tim Nguyen
5febc8eefa Bug 1692113 - Stop relying on 'true' value of getAttribute('hidden'). r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D104820
2021-02-11 15:22:18 +00:00
Neil Deakin
46a12bc6f1 Bug 1690783, move call to updateScrollMarks to occur after the highlight and match count is determined to better ensure that the found ranges have been determined, r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D104318
2021-02-11 14:12:29 +00:00
Mihai Alexandru Michis
1d92d113a2 Backed out changeset 5b31293f0b8d (bug 1690783) for causing bc failures in browser_findbar_marks.js
CLOSED TREE
2021-02-10 18:14:46 +02:00
Neil Deakin
eb7ca8878c Bug 1690783, move call to updateScrollMarks to occur after the highlight and match count is determined to better ensure that the found ranges have been determined, r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D104318
2021-02-10 14:08:44 +00:00