Commit Graph

23 Commits

Author SHA1 Message Date
Bobby Holley
44080291f9 Bug 883450 - Re-order stuff in CallSetup so that we construct the RootedObject after the Push. r=bz 2013-06-20 11:05:34 -07:00
Bobby Holley
da316c6a98 Bug 877261 - Stop taking a cx in XPCWrappedJS::GetNewOrUsed. r=Ms2ger
Some of these callers seem to be passing a ccx when they don't need to, but
let's just remove the param all together for consistency.
2013-06-04 21:11:19 -07:00
Bobby Holley
f2943090bd Bug 868130 - Remove the lion's share of JSAutoRequests in gecko. r=gabor
There are still a handful that either are used with other runtimes, or that
happen very early/late in cx the lifetime of various things where it doesn't
necessarily make sense to have a cx on the stack. This should definitely ensure
that we're not doing double-duty with the nsCxPusher change, though.
2013-05-22 10:05:28 -06:00
Bobby Holley
cdde50556c Bug 868130 - Include nsCxPusher.h everywhere we need it, and stop including it from nsContentUtils.h. r=gabor 2013-05-22 10:05:26 -06:00
Boris Zbarsky
e2a1e61323 Bug 874105. Make CallSetup hold a Rooted to the object it's constructed with so we don't have to worry about it going gray while things like argument conversion for the call are in progress. r=mccr8 2013-05-21 14:15:29 -04:00
Bobby Holley
c1533a7e3b Bug 841312 - Remove the termination function API. r=bz
\o/
2013-05-21 11:45:56 -06:00
Sankha Narayan Guria
754efdf384 Bug 867414 - Rename SafeAutoJSContext to AutoSafeJSContext. r=bholley 2013-05-06 09:04:17 -04:00
Boris Zbarsky
77fecbe508 Bug 865969 part 8. Fix rooting hazards in CallbackObject. r=ms2ger 2013-05-03 19:29:09 -04:00
Boris Zbarsky
84188ce002 Bug 835643 part 2. Store an EventListenerHolder, not an nsIDOMEventListener, in nsListenerStruct. r=smaug 2013-04-16 17:15:57 -04:00
Boris Zbarsky
52f876f3ad Bug 835643 part 1. Give CallbackObject an IID so that random things don't QI to it. r=smaug
Right now it thinks its IID is the nsISupports IID!
2013-04-16 17:14:30 -04:00
Boris Zbarsky
a2f56bac6b Bug 810644 part 2. Eliminate the now-unused CallEventHandler. r=smaug, sr=peterv 2013-01-03 14:02:42 -05:00
Jacek Szpot
a38774d086 Bug 854503 - Rename JS unwrapping functions. r=bholley 2013-04-11 11:50:18 -07:00
Boris Zbarsky
ec9c33f5eb Bug 860473 part 3. Root ErrorResult::ThrowJSException. r=evilpie,smaug 2013-04-11 14:31:06 -04:00
Ryan VanderMeulen
4df26dd5ac Backed out changeset a85d21e394c0 (bug 854503) for bustage. 2013-04-06 14:37:33 -04:00
Jacek Szpot
ab74228011 Bug 854503 - Rename JS unwrapping functions. r=bholley 2013-04-04 12:14:32 +02:00
Boris Zbarsky
d531a9c246 Bug 838686 part 1. Add a helper class that can store a WebIDL callback or an XPCOM interface. r=peterv 2013-02-26 15:10:15 -05:00
Boris Zbarsky
cde62566cf Back out changeset a4763990a983 (bug 838686) because gcc doesn't like it and we get a CLOSED TREE. 2013-02-26 15:35:13 -05:00
Boris Zbarsky
af3b8795b8 Bug 838686 part 1. Add a helper class that can store a WebIDL callback or an XPCOM interface. r=peterv 2013-02-26 15:10:15 -05:00
Bobby Holley
321002c62d Bug 834732 - Make nsCxPusher.Push(JSContext*) infallible. r=mrbkap
We leave the nsIDOMEventTarget* versions fallible for now, but this makes the
common case a lot simpler. Note that this means that pushing a null JSContext,
a bug, is no longer handled at runtime. But I think we should just assert
against it, since there are already callers that don't check the return value.
2013-02-26 11:04:11 -08:00
Bobby Holley
d2ef489c30 Bug 834732 - Remove PushBehavior. r=mrbkap
Now that we only have ALWAYS_PUSH and ASSERT_SCRIPT_CONTEXT, we have uniform
release-mode behavior everywhere. Remove the crap.
2013-02-26 11:04:11 -08:00
Bobby Holley
03f7f4b219 Bug 834732 - Get rid of footgun bool param for nsCxPusher and use an explicit enum. r=mrbkap
The goal here is to get rid of this crap entirely, and make nsCxPusher always
push. But that's a scary change, so we do it in chunks. This patch, in particular,
should have zero behavioral change. This means preserving some very wrong behavior.
For instance, currently SafeAutoJSContext never pushes a damn thing, because the
safe JSContext doesn't have an associated nsIScriptContext. We preserve this
behavior, and in fact convert various similarly-buggy consumers to
SafeAutoJSContext, so that we can hoist the behavioral change into a subsequent
patch.
2013-02-26 11:04:09 -08:00
Boris Zbarsky
624e0560d5 Bug 839088 part 2. Add way to indicate to a CallSetup that it should propagate any exceptions thrown during the call out to the ErrorResult for the call. r=peterv 2013-02-19 11:54:40 -05:00
Boris Zbarsky
4d02c18a08 Bug 822470 part 1. Factor out the code that callback functions and callback interfaces will be able to share into a CallbackObject class. r=peterv
--HG--
rename : dom/bindings/CallbackFunction.cpp => dom/bindings/CallbackObject.cpp
rename : dom/bindings/CallbackFunction.h => dom/bindings/CallbackObject.h
2013-01-28 08:34:29 -05:00