Commit Graph

5502 Commits

Author SHA1 Message Date
Narcis Beleuzu
0777e2f8f7 Backed out Bug 1428072 for mochitest-chrome leaks
Backed out changeset b39c21c2a7a4 (bug 1428072) for mochitest-chrome leaks
***
Backed out changeset 9acb3d3eb5bc (bug 1428072)
***
Backed out changeset b5a327bb02d4 (bug 1428072)

--HG--
extra : histedit_source : 9de43525a11c34bb0e48c0820857d1731d4e7a08%2Cd3f59b67cd382c41cd0b68fd0f7a521a1051d20c
2018-02-06 15:48:32 +02:00
Julien Wajsberg
ca83804232 Bug 1428072 - 3/3 - Add a mochitest to test profiling better r=mstange
MozReview-Commit-ID: 7tNEXHzFzRo

--HG--
extra : rebase_source : 3cb7fe208f6048c286c62be3216d09d5ea4eace4
2018-01-31 15:11:51 +01:00
Julien Wajsberg
163c3aa665 Bug 1428072 - 2/3 - Reorganize mochitest files for the profiler r=mstange
We extract some common framework to run profiler tests.

MozReview-Commit-ID: 7ct5RMhwmOe

--HG--
extra : rebase_source : 01165c506a4325310c23c9be6de2f5e6f958cf00
2018-01-31 10:51:19 +01:00
Julien Wajsberg
51a60aaee4 Bug 1428072 - 1/3 - Change the implementation of isChromeJSScript so that it doesn't crash for workers r=bz,sfink
In this patch we also expose a script's compartment in jsfriendapi.h

MozReview-Commit-ID: JGTLygZ6DK5

--HG--
extra : rebase_source : 585edbdbc74044f2d644f5046513786ee4f42a2f
2018-01-18 17:14:09 +01:00
Andrew Halberstadt
eb84bf741c Bug 1429457 - [mozlint] Create formal 'setup' mechanism for bootstrapping lint dependencies, r=gbrown
This allows linters to define a 'setup' method which will automatically be
called by |mach lint| before running the linter. Users can also explicitly run
these methods (without doing any actual linting) by running |mach lint --setup|.

MozReview-Commit-ID: 74aY1pfsaX1

--HG--
extra : rebase_source : e6a7d769ba14c996c7a77316928063fa46358c5a
2018-01-25 13:40:02 -05:00
Nick Alexander
9d65a9cea8 Bug 1435424 - Remove doxygen support from the build system. r=gps
This is ancient and the team that used it (gfx) is no longer using it.

MozReview-Commit-ID: HrDgmAU9QeW

--HG--
extra : rebase_source : c4a64965c4ae1a50888893e881a6e8a9688a58b6
2018-02-02 14:24:18 -08:00
Andrew Halberstadt
4a7ebcb3bb Bug 1434430 - [flake8] Upgrade version of flake8 used by |mach lint| to 3.5.0 r=rwood
MozReview-Commit-ID: BBtM4TEl4Ve

--HG--
extra : rebase_source : 94d276746401426c9adcae5c962380679ffcb083
2018-01-30 16:43:10 -05:00
Andrew Halberstadt
f354075c7a Bug 1434430 - [flake8] Fix blank 'except' statements r=rwood
This is a new issue that gets linted with flake8 3.5.0. Basically you should
never use a blank except: statement.

This will catch all exceptions, including KeyboardInterrupt and SystemExit
(which is likely not intended). If a catch all is needed, use
`except: Exception`.  If you *really* mean to also catch KeyboardInterrupt et
al, use `except: BaseException`.

Of course, being specific is often better than a catch all.

MozReview-Commit-ID: FKx80MLO4RN

--HG--
extra : rebase_source : 7c74a7d0d81f2c984b47aff3a0ee3448b791177b
2018-01-31 14:32:08 -05:00
Andrew Halberstadt
974ae38a52 Bug 1434430 - [flake8] Drop support for the FLAKE8 environment variable r=rwood
The flake8 linter requires a specific version of flake8, so that running it
locally vs in CI vs in mozreview will all produce the same results.

Allowing consumers to specify a custom flake8 binary via the FLAKE8 environment
variable, subverts that goal and can result in unexplained errors showing up in
some configurations but not others.

MozReview-Commit-ID: 1s0nC8ZO6Qi

--HG--
extra : rebase_source : f3913e2bce7770edf8deba18890f063975ca0844
2018-01-31 14:05:52 -05:00
Gurzau Raul
bb16936244 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-02-02 00:25:44 +02:00
Gurzau Raul
1315ffda06 Merge inbound to mozilla-central. a=merge 2018-02-02 00:22:39 +02:00
Florian Quèze
fcd9a3a0c8 Bug 1339461 - add an eslint rule to detect when indexOf should be replaced with includes, r=Standard8. 2018-02-01 20:47:23 +01:00
Florian Quèze
2b1c8dccb6 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Andrew McCreight
cf2f48b80d Bug 767640, part 2 - Update eslint rules to take into account the definitions of Ci, Cr, Cc and Cu. r=florian
MozReview-Commit-ID: 4PyMh0WeA4r

--HG--
extra : rebase_source : 868258ad6d98698f13faee5d6af67adcb20b63a2
2018-01-25 09:45:45 -08:00
Bogdan Tara
5c052cc871 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-01-31 12:10:31 +02:00
Bogdan Tara
1a6614b8b5 Merge inbound to mozilla-central. a=merge 2018-01-31 12:00:14 +02:00
Mark Banner
9a2172526a Bug 1434449 - Enable no-unused-vars for the global (as well as local) scope on jsm files, whitelist directories still to be fixed. r=florian.
MozReview-Commit-ID: 3vBWDR3UjGF

--HG--
extra : rebase_source : 61495d14a8d761e71b4072b02e2ca57e77f44059
2018-01-30 22:10:08 +00:00
Dorel Luca
aefaa99a3a Backed out 3 changesets (bug 1431755) for Mochitest failure on test_profile_worker_bug_1428076.html on a CLOSED TREE
Backed out changeset c1befb56cf4d (bug 1431755)
Backed out changeset 8116e9cfc3f0 (bug 1431755)
Backed out changeset 1878f143ccda (bug 1431755)
2018-01-31 00:58:04 +02:00
arthur.iakab
c4dd80eca3 Merge mozilla-central to autoland 2018-01-31 00:41:58 +02:00
Mark Banner
15e66f33ed Bug 1434332 - Add a checklist for adding new linters to the tree. r=ahal
MozReview-Commit-ID: FnYIXS5oZvW

--HG--
extra : rebase_source : 2eba61a24a4ca313f3c1d65adef454e34c57bdb5
2018-01-30 16:55:20 +00:00
Byron Campen [:bwc]
da943dc517 Bug 1431755 - Part 3: Remove a redundant dispatch that was causing us to record the duration of _two_ dispatches instead of one. r=mstange
MozReview-Commit-ID: E8lSvMbGjt6

--HG--
extra : rebase_source : b303d66dfedcaa272cd851563a1a7585c4779fac
2018-01-19 10:03:35 -06:00
Byron Campen [:bwc]
44f6431bb0 Bug 1431755 - Part 2: Teach GeckoProfiler to profile responsiveness on nsIThreads. r=mstange
MozReview-Commit-ID: AqpNf9pDzrg

--HG--
extra : rebase_source : d873d9f05115004417b4c0d98dd8dceaef263172
2018-01-19 09:42:47 -06:00
Dorel Luca
0e6d4442ff Backed out 2 changesets (bug 767640) for talos failure on scripts/MozillaFileLogger.js on a CLOSED TREE
Backed out changeset 073aecb9bee5 (bug 767640)
Backed out changeset 6bc5ccfb1bd3 (bug 767640)
2018-01-30 21:53:28 +02:00
Jim Chen
149e502c72 Bug 1428182 - 7. Include <link.h> in LUL for Android; r=jseward
Modern NDK headers all have <link.h>, so we should always include it,
and still provide shims for anything we need that's not defined in
<link.h>.

MozReview-Commit-ID: GNBDIe73RFm

--HG--
extra : rebase_source : 1246dce8a7ad201cf4f01de8e4912217636f1fc8
2018-01-30 14:08:23 -05:00
Andrew McCreight
aa6a1107ab Bug 767640, part 2 - Update eslint rules to take into account the definitions of Ci, Cr, Cc and Cu. r=florian
MozReview-Commit-ID: 4PyMh0WeA4r

--HG--
extra : rebase_source : da3db733d6c682ee137c90f8a5a9afaf85713c48
2018-01-25 09:45:45 -08:00
Kris Maglione
19a956c2c6 Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
MozReview-Commit-ID: 7bVI1iM6hor

--HG--
extra : source : 0b97a30cadb1a96d3cafae6b79ef0d3ec26770cf
extra : amend_source : 09a90b29837e339eec7bdf8504f86c28e74ca3dd
extra : intermediate-source : a1eca62826a1341ca24d4d2a93d4884d4fc7ad51
extra : histedit_source : eb26e73b531f9a34d3401d39f60b533b27b78540
2018-01-18 16:27:26 -08:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Kris Maglione
6425ff4f8d Bug 1431533: Part 4 - Add ESLint support for ChromeUtils import methods. r=florian
This adds support for detecting globals created by these helpers, as well as a
rule to enforce their use over the older XPConnect variants.

The latter rule also supports fixing code to use the newer variants, and will
be used in the next part to rewrite in-tree ESLint-enabled code that fails it.

MozReview-Commit-ID: 6Bgo6ohQA5j

--HG--
extra : source : fbef09c3e8af1653f270db589f73f2786c23ddc2
extra : intermediate-source : e2674287e57fbf6835729f42b8491359c2c4bfd5
2018-01-18 12:53:01 -08:00
Csoregi Natalia
1d557a2997 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-01-30 18:24:05 +02:00
Makoto Kato
7b895ca1a7 Bug 1433775 - Add Linux/arm support to Gecko Profiler. r=mstange
We don't support Android for Gecko Profiler extension yet.

So for investigating arm issue, I would like to add initial support of
Gecko Profiler for Linux/arm.

--HG--
extra : rebase_source : f936a97a87b7eea2ebfefe3cbc7f8791bc90d03a
2018-01-29 18:01:23 +09:00
Cosmin Sabou
c6a0d55423 Backed out 11 changesets (bug 1428182) for build bustages on pixman-inlines.h:29:10 on a CLOSED TREE
Backed out changeset 84c767de6202 (bug 1428182)
Backed out changeset 429433caa78c (bug 1428182)
Backed out changeset c576e9d1f68f (bug 1428182)
Backed out changeset 092662eab5eb (bug 1428182)
Backed out changeset 4dd7eaff3ab5 (bug 1428182)
Backed out changeset fbbb0745b139 (bug 1428182)
Backed out changeset 1d1278b289b7 (bug 1428182)
Backed out changeset 55891ffb3768 (bug 1428182)
Backed out changeset 4655e1b1b237 (bug 1428182)
Backed out changeset 377eada51b3c (bug 1428182)
Backed out changeset 17c0e373d921 (bug 1428182)

--HG--
rename : ipc/chromium/src/third_party/libevent/patches/android-api-level.patch => ipc/chromium/src/third_party/libevent/patches/android-arc4random-buf.patch
2018-01-30 01:22:33 +02:00
Jim Chen
80635d981e Bug 1428182 - 7. Include <link.h> in LUL for Android; r=jseward
Modern NDK headers all have <link.h>, so we should always include it,
and still provide shims for anything we need that's not defined in
<link.h>.

MozReview-Commit-ID: GNBDIe73RFm

--HG--
extra : rebase_source : f1f2eddc73dc1accb3a1eb8445600b015e9e7d52
2018-01-29 17:38:14 -05:00
George Dan, Ryan Neilsen, Dylan Turner
4cbac2527f Bug 1387632: Rename ProfileStorage module to FormAutofillStorage. r=MattN
--HG--
rename : browser/extensions/formautofill/ProfileStorage.jsm => browser/extensions/formautofill/FormAutofillStorage.jsm
extra : rebase_source : aa456b06046f1d995d65bec13044cde081559061
extra : histedit_source : 620bdb1c33de4b4b656066ea6432826f3631c3b4
2018-01-30 14:44:59 -08:00
Simon Fraser
5acab0f13e Bug 1432627 Add shellcheck linter to CI r=ahal
MozReview-Commit-ID: 2IYUsXunfab

--HG--
extra : rebase_source : 806ab4abfb1838a1b5eec279f5e93ce5c703685d
2018-01-29 15:27:04 +00:00
Margareta Eliza Balazs
acf50fbab3 Backed out changeset 85794e045326 (bug 1432627) for shell lint failure in /builds/worker/checkouts/gecko/taskcluster/docker/firefox-snap/runme.sh:50:95 on a CLOSED TREE 2018-01-29 19:09:55 +02:00
Simon Fraser
82f0264fa1 Bug 1432627 Add shellcheck linter to CI r=ahal
MozReview-Commit-ID: 2IYUsXunfab

--HG--
extra : rebase_source : a40376ffc66e4a35d30e7e02a6ec208b1f52b021
2018-01-29 15:27:04 +00:00
Andrew Halberstadt
a8b5fc493f Bug 1433912 - [lint] Only run codespell linter on python/mozlint and tools/lint for now, r=sylvestre
This is a bustage fix that needs to get out quickly. Once landed we can take
the time to enable it on more directories, or preferably change it to a
blacklist.

MozReview-Commit-ID: Gbf7q2L0tg3

--HG--
extra : rebase_source : a58ae64c655b24e686710a663d4538b4cfe020f7
2018-01-29 10:25:54 -05:00
Byron Campen [:bwc]
816fe1f2b6 Bug 1431755 - Part 3: Remove a redundant dispatch that was causing us to record the duration of _two_ dispatches instead of one. r=mstange
MozReview-Commit-ID: E8lSvMbGjt6

--HG--
extra : rebase_source : a56a4fa76de084d8eeb1baebf520e672ba804119
2018-01-19 10:03:35 -06:00
Byron Campen [:bwc]
8d9cde7d0d Bug 1431755 - Part 2: Teach GeckoProfiler to profile responsiveness on nsIThreads. r=mstange
MozReview-Commit-ID: AqpNf9pDzrg

--HG--
extra : rebase_source : d7c67ec8564345f6b851691f4e3dee666dd025b1
2018-01-19 09:42:47 -06:00
Tiberius Oros
a530cab0d4 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-01-27 23:56:11 +02:00
Kartikaya Gupta
99b9ae5c19 Bug 1432789 - Follow-up to list wrench as third-party. r=me
MozReview-Commit-ID: 7Df5qr1HEWF
2018-01-27 07:05:04 -05:00
Sylvestre Ledru
8238fab711 Bug 1433410 - Add codespell support for mach lint r=ahal
MozReview-Commit-ID: Ii6QjPMN0Ks

--HG--
extra : rebase_source : 854dc0994e9e204c5c5f9f25a4e956c9f51001d0
2018-01-27 10:35:31 +01:00
Kit Cambridge
2449a744b8 Bug 1305563 - Add a BufferedBookmarksEngine that can be toggled with a pref. r=markh,tcsc
This patch adds a new bookmarks engine, pref'd off, that writes to the
buffer instead of Places.

MozReview-Commit-ID: 7idBa03kOzm

--HG--
extra : rebase_source : 671ebeb3de824dc43c0ef14b2dfe065a33e2911a
2017-12-19 17:10:54 -08:00
Kit Cambridge
8d7187be91 Bug 1305563 - Add a bookmark mirror and two-way merger for synced bookmarks. r=mak,markh,rnewman,tcsc
The mirror matches the complete bookmark tree stored on the Sync
server, stores new bookmarks changed on the server since the last
sync, merges the local and remote trees, applies the resulting merged
tree back to Places, fires observer notifications for all items changed
in the merge, and stages locally changed bookmarks for upload.

MozReview-Commit-ID: MbeFQUargt

--HG--
extra : rebase_source : b635fd65ef10ab9ce3a2f9af2e527d342a790f6e
2018-01-06 07:44:33 -08:00
shindli
4615d385bd Backed out changeset e414096f1c3b (bug 1433410) for yaml lint failures in tools/lint/codespell.yml:12:81 on a CLOSED TREE 2018-01-27 01:20:16 +02:00
Sylvestre Ledru
904937e12f Bug 1433410 - Add codespell support for mach lint r=ahal
MozReview-Commit-ID: Ii6QjPMN0Ks

--HG--
extra : rebase_source : f5aec5f35d5f882132fb09fe094dc2cfc41b1392
2018-01-26 23:58:29 +01:00
Sylvestre Ledru
3a35e750f3 Bug 1433417 - Fix a bunch of typo in the doc r=ahal
MozReview-Commit-ID: LRgL0CMJdDP

--HG--
extra : rebase_source : b99364bb96c1501a674a1726a3b5fdf0664a8e4f
2018-01-26 12:50:07 +01:00
Thom Chiovoloni
6321345295 Bug 1429250 - Avoid repeated traversals of toFetch in _processIncoming. r=eoger,kitcambridge
MozReview-Commit-ID: N1Zr8iT7da

--HG--
extra : rebase_source : ddaa51704c93985219d15b31aec7ff7e19b2832f
2018-01-09 19:22:33 -05:00
Markus Stange
08c6b1b6c0 Bug 1431217 - Fix a typo that caused us to treat the parent process as shutting down when dumping the profile. r=mconley
MozReview-Commit-ID: IMk7VKMR6pE

--HG--
extra : rebase_source : 345ee1248236840a9c2d822b82f72d0b482cb8b4
2018-01-17 16:59:37 -05:00
Bas Schouten
a0d06a28fc Bug 1432570: Add support for TRACING_EVENT type markers. r=mstange 2018-01-25 18:47:00 +00:00