Commit Graph

6 Commits

Author SHA1 Message Date
Nicholas Nethercote
af6751ef10 Bug 1205533 - Fix and disallow warnings in gfx/qcms/. r=jrmuizel.
This patch fixes various warnings from MSVC.

- Several "truncation from 'double' to 'float'" warnings, easily fixed by
  appending 'f' to literals.

- Some "signed/unsigned mismatch" warnings. In read_tag_lutType(), MSVC is
  apparently promoting the multiplication of a uint8_t and a uint16_t to an
  int32_t, oddly enough. A uint32_t cast fixes the warning.

- |offset| was unused in qcms_data_create_rbg_with_gamma().

- A couple of "overflow in floating-point constant arithmetic" warnings
  involving INFINITY in transform_util.c. There is some type confusion here --
  in C99 HUGE_VAL is a double and INFINITY is a float. So the HUGE_VAL here
  should actualy be HUGE_VALF. But, strangely enough, that isn't enough to
  avoid the warning, I don't know why. However, it turns out that any
  non-positive value for |interval| will have the same effect, so I just
  removed all the INFINITY/HUGE_VAL stuff and used -1 instead.

It also fixes an ARM-only GCC warning.

- "'__force_align_arg_pointer__' attribute directive ignored". This is an
  x86-only attribute. Instead of disabling it on x86-64, instead enable it on
  i386 (which avoids enabling it uselessly on ARM).

--HG--
extra : rebase_source : 61015b7e48aebd58035fc222abf076e79a99a972
2015-09-17 17:11:27 -07:00
Benoit Girard
509337a1a0 Bug 1132467 - Adjust qcms lut inverse binary search of non monotonic TRC. r=jrmuizel
--HG--
extra : commitid : KdtckZDOAZH
2015-06-04 19:30:52 -04:00
Benoit Girard
778fa3932c Bug 679527 - Use floorf/ceilf in qcms transform function. r=jrmuizel 2012-10-19 16:35:36 -04:00
Benoit Girard
f3eedbbb1b Bug 679527 - Prefer floorf over floor in qcms. r=jrmuizel 2012-10-19 16:35:24 -04:00
Jeff Muizelaar
5885617fc0 Bug 764181. Keep the output of the TRC between 0 and 1. r=bgirard
Section 10.16: The domain and range of each function shall be [0,0 1,0].
Any function value outside the range shall be clipped to the range of the function.

--HG--
extra : rebase_source : 165927afb271980259c021fa0af25787be4a7ad3
2012-06-07 16:47:34 -04:00
Benoit Girard
e6e07e47b0 Bug 674230 - Merge from qcms github branch v4; r=jmuizelaar 2011-07-27 10:11:19 -04:00