Commit Graph

18972 Commits

Author SHA1 Message Date
Gabriele Svelto
5dc21d568c Bug 1600545 - Remove useless inclusions of header files generated from IDL files in modules/, netwerk/, parser/, security/, startupcache/, storage/, toolkit/, tools/, uriloader/, widget/, xpcom/ and xpfe/ r=Ehsan
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55444

--HG--
extra : moz-landing-system : lando
2019-12-06 09:17:57 +00:00
Gabriele Svelto
69790bc62e Bug 1600545 - Remove useless inclusions of header files generated from IDL files in accessible/, browser/, caps/, chrome/, devtools/, docshell/, editor/, extensions/, gfx/, hal/, image/, intl/, ipc/, js/, layout/, and media/ r=Ehsan
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55443

--HG--
extra : moz-landing-system : lando
2019-12-06 09:16:44 +00:00
Valentin Gosu
7f4d9c85c8 Bug 1543201 - DoH Privacy Enhancement: Do not set the User-Agent header for DoH requests r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D55934

--HG--
extra : moz-landing-system : lando
2019-12-05 19:17:28 +00:00
Mike Hommey
6a1d6c2698 Bug 1587468 - Update uuid to 0.8.1. r=webdriver-reviewers,whimboo,emilio
This leaves one out-of-tree of uuid 0.7, handled by https://github.com/mozilla/rkv/pull/184
(but we have two copies of that, we'd need to have it landed on both
branches and pulled).

Differential Revision: https://phabricator.services.mozilla.com/D55912

--HG--
extra : moz-landing-system : lando
2019-12-06 00:47:50 +00:00
Andy Grover
d51d3cc964 Bug 1601070 - update Neqo to 0.1.7 r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D55731

--HG--
extra : moz-landing-system : lando
2019-12-05 18:44:09 +00:00
ffxbld
029fc78ac3 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D55956

--HG--
extra : moz-landing-system : lando
2019-12-05 15:40:18 +00:00
Michal Novotny
6504573f1b Bug 1601620 - ThreadSanitizer: data race in mozilla::net::CacheFileUtils::CachePerfStats, r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D55972

--HG--
extra : moz-landing-system : lando
2019-12-05 14:49:24 +00:00
Boris Zbarsky
75124bdd98 Bug 1517588. Use nsIPrincipal::IsSystemPrincipal instead of nsContentUtils::IsSystemPrincipal r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D53067

--HG--
extra : moz-landing-system : lando
2019-12-05 04:44:32 +00:00
Ciure Andrei
7229b5803b Backed out 5 changesets (bug 1595154) for causing talos performance tests failures CLOSED TREE
Backed out changeset 498f750ed88a (bug 1595154)
Backed out changeset 45481561c120 (bug 1595154)
Backed out changeset 8ca3c106fc8d (bug 1595154)
Backed out changeset 7ffa8f958d0a (bug 1595154)
Backed out changeset 444505b4936b (bug 1595154)

--HG--
rename : browser/extensions/formautofill/FormAutofillChild.jsm => browser/extensions/formautofill/content/FormAutofillFrameScript.js
2019-12-04 21:07:05 +02:00
Neil Deakin
0fe11bd612 Bug 1595154, replace the frame script FormAutofillFrameScript.js with an actor and fix up setTimeout calls in places that were relying on Timer.jsm being loaded in that frame script, r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D52721

--HG--
rename : browser/extensions/formautofill/content/FormAutofillFrameScript.js => browser/extensions/formautofill/FormAutofillChild.jsm
extra : moz-landing-system : lando
2019-12-04 11:45:10 +00:00
Andreas Tolfsen
6805a19f9f bug 1600121: netwerk: error on empty path in nsIHttpServer.registerPathHandler; r=mayhemer
It should be illegal to add paths that cannot be handled/accessed
or later referenced.  Without a path, it is for example later
impossible to delete the handler.

To address this we return an NS_ERROR_INVALID_ARG when
nsIHttpServer.registerPathHandler is called with an empty string.

Differential Revision: https://phabricator.services.mozilla.com/D55160

--HG--
extra : moz-landing-system : lando
2019-11-29 18:41:44 +00:00
Tom Schuster
60bd30f45a Bug 1596701 - Do not warn about wrong JS MIME type when HTTP load failed. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D55273

--HG--
extra : moz-landing-system : lando
2019-12-02 10:02:43 +00:00
Dimi Lee
890d2ceb9d Bug 1584931 - P2. Disable flashblock when fission is enabled. r=bytesized
This patch does the following:
  1. Disable flashblock when fission is enabled.
  2. Update flashblock tests to expect "unknown" classification when fission is
     enabled.
  3. Remove skip-if=fission in flashblock mochitests.

Depends on D51098

Differential Revision: https://phabricator.services.mozilla.com/D55091

--HG--
extra : moz-landing-system : lando
2019-12-04 09:00:28 +00:00
Matt Woodrow
6f0f9e969f Bug 1600211 - Forward AllPartsStopped to HttpChannelChild to ensure that we notify the listeners correctly. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D55223

--HG--
extra : moz-landing-system : lando
2019-12-04 03:19:38 +00:00
Matt Woodrow
a2c085754a Bug 1600211 - Disable content conversion by HttpChannelChild if we have already applied it by the time we get to HttpChannelParent::OnStartRequest. r=mayhemer
We normally get HttpChannelParent::OnStartRequest directly from nsHttpChannel::OnStartRequest, where we disable content conversion and ask the child to do it instead.

When we install a multipart converter, we defer calling HttpChannelParent::OnStartRequest until we've decoded parts, at which point content conversion is already applied to the stream.

This detects that case, and stops the child trying to do it a second time (which fails, and breaks the content).

Differential Revision: https://phabricator.services.mozilla.com/D55222

--HG--
extra : moz-landing-system : lando
2019-12-04 03:19:26 +00:00
Matt Woodrow
969be7e03d Bug 1600211 - Support multipart channels in DocumentLoadListener. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D55221

--HG--
extra : moz-landing-system : lando
2019-12-04 03:19:08 +00:00
Matt Woodrow
fbc0783110 Bug 1600211 - Add nsIMultiPartChannelListener as a reliable way to detect when a multi-part channel is finished and we can break reference cycles. r=mayhemer
We can't always know when sending a part if it'll be the last one (either because the channel is later cancelled, or because the response just sends the end boundary without warning). This was initially reported in bug 339610.

Differential Revision: https://phabricator.services.mozilla.com/D55220

--HG--
extra : moz-landing-system : lando
2019-12-04 03:18:56 +00:00
Matt Woodrow
a26e9542d2 Bug 1600211 - Send OnDataAvailable and OnStopRequest on the main-thread channel when in multi-part mode to avoid complicated races across the two channels. r=mayhemer
This also removes OnStartRequestSent from PHttpBackgroundChannel, since there should never be any messages sent earlier on this channel, so we can just assume the waiting state initially.

Differential Revision: https://phabricator.services.mozilla.com/D55219

--HG--
extra : moz-landing-system : lando
2019-12-04 03:18:38 +00:00
Matt Woodrow
92e976c088 Bug 1600211 - Disable some interfaces on HttpChannelChild when we're in multipart mode since nsPartChannel didn't implement these and we don't want to support them. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D55218

--HG--
extra : moz-landing-system : lando
2019-12-04 03:18:26 +00:00
Matt Woodrow
96102b54a4 Bug 1600211 - Support passsing nsIMultiPartChannel values through PHttpChannel, and conditionally expose this interface on HttpChannelChild. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D55217

--HG--
extra : moz-landing-system : lando
2019-12-04 03:18:13 +00:00
Matt Woodrow
ae112914b6 Bug 1600211 - Create a multi-part converter in nsHttpChannel if needed. r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D55216

--HG--
extra : moz-landing-system : lando
2019-12-04 03:17:55 +00:00
Matt Woodrow
acb2b568b2 Bug 1600211 - Convert DocumentLoadListener to use a Variant for recording and replaying nsIStreamListener functions. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D55215

--HG--
extra : moz-landing-system : lando
2019-12-04 03:17:43 +00:00
Matt Woodrow
ff5771a51f Bug 1598516 - Add DocumentChannel MOZ_LOGs. r=jya
Differential Revision: https://phabricator.services.mozilla.com/D54250

--HG--
extra : moz-landing-system : lando
2019-12-03 23:55:04 +00:00
Matt Woodrow
b3c2394593 Bug 1598516 - Don't crash if NS_NewChannelInternal fails. r=mayhemer
Looks like this can sometimes fail with moz-extension URIs, so we shouldn't crash

Differential Revision: https://phabricator.services.mozilla.com/D54249

--HG--
extra : moz-landing-system : lando
2019-12-03 23:54:51 +00:00
Matt Woodrow
713f0b20e6 Bug 1598516 - Expose a RemoteWindowContext on ParentChannelListener. r=mayhemer,kmag
Without DocumentChannel, nsExtProtocolChannel::OpenURL calls into nsExternalHelperAppService::LoadURI in the content process.
We then manually forward this to the parent process over PContent, create a RemoteWindowContext around the browser parent, and then call LoadURI again.

With DocumemntChannel, the nsExtProtocolChannel already lives in the parent, so we just need to provide a RemoteWindowContext directly (that the code accesses via GetInterface on the callbacks).

Differential Revision: https://phabricator.services.mozilla.com/D54247

--HG--
extra : moz-landing-system : lando
2019-12-03 23:54:21 +00:00
Bogdan Tara
0108d839e9 Backed out 8 changesets (bug 1598516) for run startup hangs CLOSED TREE
Backed out changeset bc0035aa57fe (bug 1598516)
Backed out changeset 33603b723337 (bug 1598516)
Backed out changeset 31c11dd9146d (bug 1598516)
Backed out changeset 4e269a638350 (bug 1598516)
Backed out changeset 76b86080c868 (bug 1598516)
Backed out changeset b6f84b01cbd9 (bug 1598516)
Backed out changeset 74d136798dd3 (bug 1598516)
Backed out changeset bf370938463e (bug 1598516)
2019-12-04 00:48:17 +02:00
Matt Woodrow
9d6d1cef54 Bug 1598516 - Add DocumentChannel MOZ_LOGs. r=jya
Differential Revision: https://phabricator.services.mozilla.com/D54250

--HG--
extra : moz-landing-system : lando
2019-12-03 20:43:43 +00:00
Matt Woodrow
6fd561123e Bug 1598516 - Don't crash if NS_NewChannelInternal fails. r=mayhemer
Looks like this can sometimes fail with moz-extension URIs, so we shouldn't crash

Differential Revision: https://phabricator.services.mozilla.com/D54249

--HG--
extra : moz-landing-system : lando
2019-12-03 20:43:33 +00:00
Matt Woodrow
1f894c8f18 Bug 1598516 - Expose a RemoteWindowContext on ParentChannelListener. r=mayhemer,kmag
Without DocumentChannel, nsExtProtocolChannel::OpenURL calls into nsExternalHelperAppService::LoadURI in the content process.
We then manually forward this to the parent process over PContent, create a RemoteWindowContext around the browser parent, and then call LoadURI again.

With DocumemntChannel, the nsExtProtocolChannel already lives in the parent, so we just need to provide a RemoteWindowContext directly (that the code accesses via GetInterface on the callbacks).

Differential Revision: https://phabricator.services.mozilla.com/D54247

--HG--
extra : moz-landing-system : lando
2019-12-03 20:43:19 +00:00
Michal Novotny
a7fe3954fe Bug 1598321 - InputStreamShim::AsyncWait() and OutputStreamShim::AsyncWait() are not one-shot, r=dragana
InputStreamShim and OutputStreamShim now hold a strong reference to the callback and it's released after calling nsIInputStreamCallback::OnInputStreamReady() and nsIOutputStreamCallback::OnOutputStreamReady()

Differential Revision: https://phabricator.services.mozilla.com/D54147

--HG--
extra : moz-landing-system : lando
2019-11-26 18:31:18 +00:00
Gurzau Raul
2e8639b3b4 Backed out 8 changesets (bug 1598516) for build bustage at ParentChannelListener.cpp on a CLOSED TREE.
Backed out changeset 7ac1b091aa5f (bug 1598516)
Backed out changeset b62c5b49b91c (bug 1598516)
Backed out changeset e48c0ce38498 (bug 1598516)
Backed out changeset cc2599921b5e (bug 1598516)
Backed out changeset 0a0f80b0b278 (bug 1598516)
Backed out changeset 1dc19a039cab (bug 1598516)
Backed out changeset b664c8af6e2d (bug 1598516)
Backed out changeset 943b440179b9 (bug 1598516)
2019-12-03 21:48:14 +02:00
Michal Novotny
b508e7721e Bug 1600811 - network ID: use hardcoded IP for route checking in nsNetworkLinkService on MacOS r=JuniorHsu
The preferences network.netlink.route.check.IPv4 and network.netlink.route.check.IPv6 were removed in bug 1593693 and the values are now hardcoded because they are used by Linux/Android implementation of nsNetworkLinkService for link status detection and they are not supposed to be changed by the user.

Differential Revision: https://phabricator.services.mozilla.com/D55587

--HG--
extra : moz-landing-system : lando
2019-12-03 07:26:07 +00:00
Matt Woodrow
ab7f711e51 Bug 1598516 - Add DocumentChannel MOZ_LOGs. r=jya
Differential Revision: https://phabricator.services.mozilla.com/D54250

--HG--
extra : moz-landing-system : lando
2019-12-03 06:20:23 +00:00
Matt Woodrow
15db260efa Bug 1598516 - Don't crash if NS_NewChannelInternal fails. r=mayhemer
Looks like this can sometimes fail with moz-extension URIs, so we shouldn't crash

Differential Revision: https://phabricator.services.mozilla.com/D54249

--HG--
extra : moz-landing-system : lando
2019-12-03 06:20:11 +00:00
Matt Woodrow
9cc742b690 Bug 1598516 - Expose a RemoteWindowContext on ParentChannelListener. r=mayhemer,kmag
Without DocumentChannel, nsExtProtocolChannel::OpenURL calls into nsExternalHelperAppService::LoadURI in the content process.
We then manually forward this to the parent process over PContent, create a RemoteWindowContext around the browser parent, and then call LoadURI again.

With DocumemntChannel, the nsExtProtocolChannel already lives in the parent, so we just need to provide a RemoteWindowContext directly (that the code accesses via GetInterface on the callbacks).

Differential Revision: https://phabricator.services.mozilla.com/D54247

--HG--
extra : moz-landing-system : lando
2019-12-03 06:19:35 +00:00
Ehsan Akhgari
d94f27a8d6 Bug 1595934 - Make nsICookieManager cookie enumerators return Array<nsICookie> instead of nsISimpleEnumerator; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D52761

--HG--
extra : moz-landing-system : lando
2019-12-03 17:08:25 +00:00
Tom Ritter
4f9313ba4e Bug 1582512 - Register a ScriptValidationCallback to examine script loads in the parent process r=Gijs,ckerschb
Additionally, we disable validation on PAC scripts.

Differential Revision: https://phabricator.services.mozilla.com/D46500

--HG--
extra : moz-landing-system : lando
2019-12-02 17:27:09 +00:00
Kershaw Chang
9c48606bb3 Bug 1596409 - P6: Add a pref for using socket process for network r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D54174

--HG--
extra : moz-landing-system : lando
2019-12-03 13:46:04 +00:00
Kershaw Chang
e686a3ff31 Bug 1596409 - P5: Enable necessary XPCOM components for using nsHttpTransaction in socket process r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D54165

--HG--
extra : moz-landing-system : lando
2019-12-03 13:45:19 +00:00
Kershaw Chang
23e2261f84 Bug 1596409 - P4: Impl PHttpConnectionMgr IPC protocol r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D54164

--HG--
extra : moz-landing-system : lando
2019-12-03 13:44:39 +00:00
Kershaw Chang
1c7dbad1ac Bug 1596409 - P3: Add HttpConnectionMgrShell r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D54162

--HG--
extra : moz-landing-system : lando
2019-12-03 13:44:06 +00:00
Kershaw Chang
cb29d04cfa Bug 1596409 - P2: Seperate nsHttpConnectionMgr and AltSvcCache r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D54161

--HG--
extra : moz-landing-system : lando
2019-12-03 13:43:29 +00:00
Kershaw Chang
750f73dbb2 Bug 1596409 - P1.2: Create PHttpTransaction IPC protocol r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D54290

--HG--
extra : moz-landing-system : lando
2019-12-03 13:42:15 +00:00
Kershaw Chang
f3bddbd52b Bug 1596409 - P1.1: Make socket process support IPCStream r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D54289

--HG--
extra : moz-landing-system : lando
2019-12-03 13:41:58 +00:00
Kershaw Chang
a1a7f14884 Bug 1600678 - Use IPDL refcounted for DNSRequest r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D55475

--HG--
extra : moz-landing-system : lando
2019-12-02 18:28:49 +00:00
Valentin Gosu
2fc5985a45 Bug 1598430 - Make sure that we record the NETWORK_ID_ONLINE telemetry at the right time r=michal
We perform this check in the first OnDataAvailable, instead of doing it in
OnStopRequest in case a network down event occurs after the data has arrived
but before we fire OnStopRequest. That would cause us to report a missing
networkID, even though it was not empty while receiving data.

Differential Revision: https://phabricator.services.mozilla.com/D55574

--HG--
extra : moz-landing-system : lando
2019-12-03 07:35:11 +00:00
Ciure Andrei
e473bd5f57 Backed out 10 changesets (bug 1582512) for causing browser_preferences_usage.js to permafail CLOSED TREE
Backed out changeset a615a2c07523 (bug 1582512)
Backed out changeset 7dd0266da0a1 (bug 1582512)
Backed out changeset dfdefc6ede97 (bug 1582512)
Backed out changeset 59db30e1915f (bug 1582512)
Backed out changeset 1eb6f6b02149 (bug 1582512)
Backed out changeset 391ed11326fb (bug 1582512)
Backed out changeset 02865605c1c3 (bug 1582512)
Backed out changeset 017582048986 (bug 1582512)
Backed out changeset 1374c08302f9 (bug 1582512)
Backed out changeset 40dd63b6910a (bug 1582512)
2019-12-02 19:23:12 +02:00
Tom Ritter
40826aaf6c Bug 1582512 - Register a ScriptValidationCallback to examine script loads in the parent process r=Gijs,ckerschb
Additionally, we disable validation on PAC scripts.

Differential Revision: https://phabricator.services.mozilla.com/D46500

--HG--
extra : moz-landing-system : lando
2019-12-02 15:45:13 +00:00
Emilio Cobos Álvarez
74327c26b4 Bug 1599615 - Make some necko code less nsresult-happy. r=kershaw,valentin
Stuff that's infallible and not virtual has no reason to return an nsresult.

Differential Revision: https://phabricator.services.mozilla.com/D54831

--HG--
extra : moz-landing-system : lando
2019-12-02 13:21:06 +00:00
Valentin Gosu
0848f9ba9a Bug 1590528 - Call CheckAdaptersAddresses at startup r=kershaw
The problem is that the suffix is not always computed when Firefox starts up.
This patch adds a pref `network.notify.initial_call` that controls whether
CheckAdaptersAddresses gets called imediately after.
This call is necessary in order to compute the suffix list, VPN status, etc.

This patch also ensures that OnDnsSuffixListUpdated gets called by
NetlinkService::ComputeDNSSuffixList on Android. This notification is
necessary for the TRRService to pick up the suffix list.

Differential Revision: https://phabricator.services.mozilla.com/D55303

--HG--
extra : moz-landing-system : lando
2019-12-02 09:34:14 +00:00