Justin Wood
27f34d80f1
Bug 1223385 - use in-tree compare-locales in Makefiles, r=gps
...
Also fix that the default merge dir in the mach command creates a directory
that's the merge make target, and thus keeps that make target from actually
running.
MozReview-Commit-ID: HWZBPxWuHSy
--HG--
extra : rebase_source : a39157ad9eb99f3eef5d149d003e62a235f92fc1
2016-07-08 11:59:27 -04:00
Yoshi Huang
e24cc195d9
Bug 1274893 - remove -forbid- list from SafeBrowsing. r=francois
2016-07-11 16:11:32 +08:00
Cykesiopka
9533a3d17b
Bug 1281661 - Ensure input to NSSDialogService prompt messages are HTML escaped to avoid HTML injection. r=kats,keeler
...
As of the writing of this patch, NSSDialogService pops up a prompter on
Android as follows (assuming at least one label is requested):
1. NSSDialogService.js calls Prompt.jsm methods and eventually requests the
prompt be displayed.
2. Prompt.jsm sends a messages to the Java side.
3. The Java side receives the message and eventually calls
org.mozilla.gecko.prompts.PromptInput.LabelInput.getView().
4. LabelInput.getView() calls android.text.Html.fromHtml().
At no point is any HTML injection prevention done, so in theory NSSDialogService
could be an injection vector.
In practice, it appears that fromHtml() doesn't actually allow anything malicious
to be done. This patch introduces HTML escaping at the NSSDialogService
level just to be safe.
MozReview-Commit-ID: LhHuZKSqx01
--HG--
extra : transplant_source : l%C9%A2%95%9A.%05%1F%CF%5D%02%5E%12N%C1%B7O%7C%1B%8B
2016-06-29 18:48:49 -07:00
Grigory Kruglov
26648ad110
Bug 1277467 - Add OfflineTabStatusDelegate for displaying tab-is-offline notifiations when appropriate r=sebastian
...
- Use Content:PageShow event to inform Tabs that they were actively loaded from cache
- Move offline notification logic away from browser.js and into a delegate, which displays notifications when
tab in question is user-visible
MozReview-Commit-ID: 2qCACHyWOlp
--HG--
extra : rebase_source : 457a42ebba5cfc32ab7dabce0a8a11d6511b9c08
2016-06-24 16:56:04 -07:00
Wes Kocher
ef24c234ed
Merge inbound to central, a=merge
2016-06-24 13:37:12 -07:00
Cykesiopka
577a05865b
Bug 307081 - Make nsIClientAuthDialogs::ChooseCertificate() pass an nsIArray of nsIX509Certs, not strings. r=kats,keeler
...
This provides implementations of ChooseCertificate() with more flexibility, and
allows callers of ChooseCertificate() to be less complex.
A portion of this work involves reimplementing
nsNSSCertificate::FormatUIStrings() in JS and improving UI strings for l10n.
MozReview-Commit-ID: CE7Uc2ntwmZ
--HG--
extra : transplant_source : R%A8eC%CEO2%DC%20%F7%B4V%F3g%E6h%EB%D5%8D3
2016-06-24 00:12:16 -07:00
Cykesiopka
313db6b516
Bug 307081 - Clean up nsIClientAuthDialogs.idl and implementations. r=kats,keeler
...
This fixes the following in the IDL:
1. Misleading or unclear parameter names in the IDL. |cn| in practice is the
concatenation of the CN of the server cert and the port of the server, and
|issuer| is the Organization of the issuer cert of the server cert.
2. Use of the |wstring| type. |AString| is generally preferred, and has the
benefit of letting implementations skip null checks due to the use of
references.
3. Using an explicit |canceled| outparam instead of just setting a return type.
There is no need for the outparam if the return type can be used.
4. Using |long| (int32_t) for |selectedIndex|. |unsigned long| (uint32_t) is
more logical, and paves the way for future changes.
This fixes the following in the Android implementation:
1. Lack of checks to ensure the QueryInterface() call succeeded. In practice,
the call will always succeed, but it's good practice to check anyways.
2. Setting a variable to an nsIPrefService instance initially, then later
setting it to a pref branch instance later on. This is confusing and
unnecessary.
This fixes the following in the desktop implementation:
1. Lack of null pointer checking.
2. Trying to get a parent window ref off a context that doesn't actually support
doing so.
3. Setting a variable to an nsIPrefService instance initially, then later
setting it to a pref branch instance later on. This is confusing and
unnecessary.
4. Abusal of the CAPS bundle.
5. Unnecessary variables.
6. Variables declared far away from where they are used.
7. Variable shadowing.
8. Style issues.
9. Lack of documentation.
This also fixes the following:
1. Lack of localisation notes.
MozReview-Commit-ID: FTc6XecJd6h
--HG--
extra : transplant_source : %ABQ%8F%E6%A3%25%FE%94%E4%D6X%3D%28%2C%05%5E%FB%84.-
2016-06-24 00:12:11 -07:00
J. Ryan Stinnett
c91928a953
Bug 1253399 - Avoid crashes by checking for QR scanner app. r=sebastian
...
MozReview-Commit-ID: 6bFrYyt4pzX
2016-06-23 11:59:57 -05:00
Kevin Lam
e730d38cc4
Bug 1245952 - Corrected comment in localization note to reference the corresponding string. r=mcomella
2016-06-08 18:08:00 +02:00
Bhavin Dave
1dd6ff80f3
Bug 893836 - Update Android menu contents to sentence case. r=margaret
2016-05-23 09:20:00 -04:00
Grigory Kruglov
348655f801
Bug 1233250: Part 2 - Better copy for "loaded from cache" snackbar r=sebastian
...
MozReview-Commit-ID: 1TZnFlU6Mo7
--HG--
extra : rebase_source : ad28ba459bac7c7fd3e9f32bc6c372220a552573
2016-05-10 17:35:40 -07:00
Eugen Sawin
1cb3a78441
Bug 1243431 - [3.6] Add strings for Vibration API permission request doorhanger. r=margaret
2016-05-09 14:38:22 +02:00
Chun-Min Chang
05a818c4cd
Bug 1268767 - [Presentation WebAPI] Missing a MPL2 license header for devicePrompt.properties; r=margaret
...
MozReview-Commit-ID: JRgOGrE7Iu5
--HG--
extra : transplant_source : %BD%BC%CC%C7%DAt%F3%CA%02%8E%89%08%C0%10%1A%98%0D%99%A4P
2016-04-29 14:08:36 +08:00
Chun-Min Chang
4c28b98196
Bug 1232105 - device prompt UI for presentation api; r=margaret
...
MozReview-Commit-ID: CdSe449XdwF
--HG--
extra : transplant_source : %C9pI%C1%99%24%F2%2A%BE%A8c%B5%D9%90%BA%24%D3%D0%1CE
2016-04-25 11:34:23 +08:00
Sebastian Kaspari
d31840b1fa
Bug 1262098 - Use shorter string for "Add as search engine" to avoid UI bug. r=grisha
...
MozReview-Commit-ID: 3G4sk0H0aKM
--HG--
extra : rebase_source : 5f2a3bb5a1ec7bd9fda422abc2efab15134d5e20
2016-04-13 14:41:50 +02:00
Andrzej Hunt
03976ef545
Bug 1246232 - Remove "add to reading list" from link-long-press context menu r=liuche
...
MozReview-Commit-ID: COprGdVgKOf
--HG--
extra : rebase_source : 461d794730671dd5dbdf357d2d827e67a330d9be
extra : histedit_source : 1fba82a6fe3c86fce774ea41209de1af255ee11e
2016-03-07 15:33:23 -08:00
Cykesiopka
1a9cf03eb1
Bug 1251009 - Remove unused nsICertificateDialogs.notifyCACertExists() method. r=keeler, r=mfinkle
...
MozReview-Commit-ID: 5CFAsy5e1Cl
--HG--
extra : rebase_source : eed2fc5d3511c140dfe6046079347e9a881e2803
2016-03-16 12:48:59 -07:00
Dale Harvey
5b87f86e00
Bug 730941 - Add 'View Image' to image context menu. r=nalexander
2016-03-16 22:41:03 +00:00
Grigory Kruglov
9cc8e72cbc
Bug 1254729 - Remove about:devices from Fennec. r=nalexander
...
MozReview-Commit-ID: 2RC82OrrsnA
--HG--
extra : transplant_source : %C3%06%0B%1D%5E%15%60%C3%3BZS%28EB%8B3s%F3%B7k
2016-03-09 15:37:04 -08:00
Margaret Leibovic
fd676ca818
Bug 1253339 - Remove about:feedback code. r=sebastian
...
MozReview-Commit-ID: 3ASVVlDiJph
--HG--
extra : rebase_source : bf3a9b10cd7c695ad2266132bc3ca900f8defdad
2016-03-03 12:57:54 -05:00
Brendan Dahl
2ece6215a9
Bug 1235869 - Remove web runtime from android. r=myk
2016-02-29 10:31:00 +01:00
Joel Maher
de9f8d8859
Bug 1251373 - Remove moz payment API support. r=Margaret
...
MozReview-Commit-ID: IW63XQDyB16
--HG--
extra : rebase_source : 2038809a37a265843e6033392cbe08641dfb3a50
2016-02-25 13:08:50 -08:00
Axel Hecht
a0aba3aa15
Bug 1246000 - remove stale locales from Android on central, too, r=jbeatty
2016-02-17 16:39:43 +01:00
Francois Marier
cba834e152
Bug 1245992 - Remove unused Safe Browsing strings. r=past
...
MozReview-Commit-ID: IkyO53DJpYs
--HG--
extra : rebase_source : 44e64c0eb3610159b6d57da2f3fedddfdda54841
2016-02-25 21:34:15 -08:00
Francois Marier
53454d8416
Bug 1245992 - Update the Safe Browsing phishing interstitial page. r=flod,past
...
MozReview-Commit-ID: DLC1KDvYbUH
--HG--
extra : rebase_source : 7289c93af47827f8a8dd78285d7beecf31935f3c
2016-02-25 21:34:01 -08:00
Phil Ringnalda
c279cb263c
Back out 2 changesets (bug 1245992) for several browser-chrome failures
...
Backed out changeset 6d9614f87daf (bug 1245992)
Backed out changeset 34e6eea401e3 (bug 1245992)
2016-02-25 19:15:16 -08:00
Francois Marier
57f2a2f2d3
Bug 1245992 - Remove unused Safe Browsing strings. r=past
...
MozReview-Commit-ID: KHy6731OZJd
--HG--
extra : rebase_source : d079442b95f6f01af8b903cb23861552888d0f1f
2016-02-24 16:23:25 -08:00
Francois Marier
b5682aa996
Bug 1245992 - Update the Safe Browsing phishing interstitial page. r=flod,past
...
MozReview-Commit-ID: JnYOqtCIib7
--HG--
extra : rebase_source : 4488fa66efd6a1dd6d1b477836a772549a0424c3
2016-02-24 16:23:25 -08:00
Varun Naganathan
b3d1bd5191
Bug 1238796 - Changed message on tab close if Private Tab. r=margaret
2016-02-09 10:55:00 +01:00
Sebastian Kaspari
ed87fa4de9
Bug 1238139 - Show snackbar for completed downloads. r=ahunt,mcomella
...
--HG--
extra : commitid : HKyerFgzS3T
extra : rebase_source : f098a6835c8bec23ce93e34ba7a2e946a5839fd0
extra : amend_source : caed6768c27e739f852e9456245604b51c5af06d
2016-01-14 19:48:29 +01:00
Sebastian Kaspari
6e8b772081
Bug 1225433 - (Fennec) Update text and style of "forbidden" page. r=francois
...
--HG--
extra : commitid : Ika0t1wJq8T
extra : rebase_source : 84f22d25b4baf5c0af0709b0f0a4e97f05ae3b45
2016-01-19 10:21:10 +01:00
Carsten "Tomcat" Book
40335d0645
Backed out changeset a87a27864bb8 (bug 1223385)
2016-01-15 13:51:54 +01:00
Axel Hecht
a942827a5b
Bug 1223385 - use in-tree compare-locales in Makefiles, r=gps
...
Also fix that the default merge dir in the mach command creates a directory
that's the merge make target, and thus keeps that make target from actually
running.
--HG--
extra : transplant_source : R%FE%7Eo%CDS%D1%B4%EA%DB%D0%19q%F92%A1V%91%10%5C
2016-01-08 16:37:52 +01:00
Mohamed Hammoud
b72afd7d16
Bug 1156252 - 'Confusing UI in Cancel Download dialog box'. r=liuche
2015-12-30 12:59:00 +01:00
Mike Hommey
581d13d0d1
Bug 1235151 - Factor all the install.rdfs used for langpacks. r=mshal
...
The only difference between all of them is the application id they target.
Interestingly, the Fennec one is still targetting the XUL appid, instead
of the Android one, which doesn't seem right.
--HG--
rename : b2g/locales/generic/install.rdf => toolkit/locales/generic/install.rdf
2015-12-31 07:26:34 +09:00
Mark Finkle
e98309db11
Bug 935190 - Try to show cached pages when Fennec is offline r=sebastian
2015-12-22 14:28:49 -05:00
Nick Alexander
3e1c5ea1e5
Bug 1220892 - Part 1: Remove MOZ_ANDROID_NATIVE_ACCOUNTS_UI. r=mcomella
...
--HG--
extra : commitid : 3drJfjq0uyX
extra : rebase_source : 67a2e524b90f78e8f719e1f8efc9a84a6f9a19dd
extra : histedit_source : 68805f753e785e2d935ee221ba5243597ec24f92
2015-11-30 14:32:17 -08:00
Francois Marier
e44555648c
Bug 1227800 - Add missing XML entities on Fennec for -forbid- SB lists. r=gcp
2015-11-25 08:54:00 -08:00
Chenxia Liu
6385142b8b
Bug 1044401 - Update geolocation id. r=trivial
...
--HG--
extra : commitid : wJaryzgq4W
extra : rebase_source : 72f55924f16ea733ae5a2df7e2cbf5b464b23353
2015-11-23 11:20:42 -05:00
Chenxia Liu
c198a7441e
Bug 1044401 - Turn permissions into nouns. r=sebastian
...
--HG--
extra : commitid : Po1Ri3ATW5
extra : rebase_source : 9177ea36007f776a0a5694987e95a63fb186387f
2015-11-17 17:33:49 -08:00
Chenxia Liu
5696b4cd0e
Bug 1212606 - Prompt user (with a doorhanger) to allow to notifications from a website. r=ally
...
--HG--
extra : commitid : 5t45WaEgpTd
extra : rebase_source : 87e5eaf10e919cef73289cc3440b59a068f5ed3a
2015-11-10 15:18:20 -08:00
Sebastian Kaspari
6761261be6
Bug 1191741 - Family friendly browsing: Restrict sharing of camera and microphone with websites. r=ally
...
--HG--
extra : commitid : JHH8Rr8VrUK
extra : rebase_source : 59fe5a4508003c53446284c3bf51931a6a5b5073
2015-11-09 16:05:09 +01:00
Jonathan Almeida [:jonalmeida]
04db37c682
Bug 1211295 - When tap-to-load images are enabled, add option to load all images r=mfinkle
...
--HG--
extra : commitid : 7B2FUU4V2zt
extra : rebase_source : 3101169b567893c8c47363599f66eba2f3fe41d0
extra : amend_source : f02c9f3ab6ac43dd235c6c0efe99d7870f88f5c6
2015-11-03 00:55:22 -05:00
J. Ryan Stinnett
5d6812e289
Bug 1182722 - Move DevTools l10n files. r=ochameau,glandium,Pike,bgrins
...
Move DevTools l10n files under /devtools/client and /devtools/shared.
A script is attached to the bug for l10n repos to migrate their strings.
--HG--
rename : browser/locales/en-US/chrome/browser/devtools/VariablesView.dtd => devtools/client/locales/en-US/VariablesView.dtd
rename : browser/locales/en-US/chrome/browser/devtools/aboutdebugging.dtd => devtools/client/locales/en-US/aboutdebugging.dtd
rename : browser/locales/en-US/chrome/browser/devtools/aboutdebugging.properties => devtools/client/locales/en-US/aboutdebugging.properties
rename : browser/locales/en-US/chrome/browser/devtools/animationinspector.dtd => devtools/client/locales/en-US/animationinspector.dtd
rename : browser/locales/en-US/chrome/browser/devtools/animationinspector.properties => devtools/client/locales/en-US/animationinspector.properties
rename : browser/locales/en-US/chrome/browser/devtools/app-manager.properties => devtools/client/locales/en-US/app-manager.properties
rename : browser/locales/en-US/chrome/browser/devtools/appcacheutils.properties => devtools/client/locales/en-US/appcacheutils.properties
rename : browser/locales/en-US/chrome/browser/devtools/canvasdebugger.dtd => devtools/client/locales/en-US/canvasdebugger.dtd
rename : browser/locales/en-US/chrome/browser/devtools/canvasdebugger.properties => devtools/client/locales/en-US/canvasdebugger.properties
rename : browser/locales/en-US/chrome/browser/devtools/connection-screen.dtd => devtools/client/locales/en-US/connection-screen.dtd
rename : browser/locales/en-US/chrome/browser/devtools/connection-screen.properties => devtools/client/locales/en-US/connection-screen.properties
rename : browser/locales/en-US/chrome/browser/devtools/debugger.dtd => devtools/client/locales/en-US/debugger.dtd
rename : browser/locales/en-US/chrome/browser/devtools/debugger.properties => devtools/client/locales/en-US/debugger.properties
rename : browser/locales/en-US/chrome/browser/devtools/device.properties => devtools/client/locales/en-US/device.properties
rename : browser/locales/en-US/chrome/browser/devtools/eyedropper.properties => devtools/client/locales/en-US/eyedropper.properties
rename : browser/locales/en-US/chrome/browser/devtools/filterwidget.dtd => devtools/client/locales/en-US/filterwidget.dtd
rename : browser/locales/en-US/chrome/browser/devtools/filterwidget.properties => devtools/client/locales/en-US/filterwidget.properties
rename : browser/locales/en-US/chrome/browser/devtools/font-inspector.dtd => devtools/client/locales/en-US/font-inspector.dtd
rename : browser/locales/en-US/chrome/browser/devtools/graphs.properties => devtools/client/locales/en-US/graphs.properties
rename : browser/locales/en-US/chrome/browser/devtools/har.properties => devtools/client/locales/en-US/har.properties
rename : browser/locales/en-US/chrome/browser/devtools/inspector.dtd => devtools/client/locales/en-US/inspector.dtd
rename : browser/locales/en-US/chrome/browser/devtools/inspector.properties => devtools/client/locales/en-US/inspector.properties
rename : browser/locales/en-US/chrome/browser/devtools/jsonview.properties => devtools/client/locales/en-US/jsonview.properties
rename : browser/locales/en-US/chrome/browser/devtools/layoutview.dtd => devtools/client/locales/en-US/layoutview.dtd
rename : browser/locales/en-US/chrome/browser/devtools/markers.properties => devtools/client/locales/en-US/markers.properties
rename : browser/locales/en-US/chrome/browser/devtools/memory.properties => devtools/client/locales/en-US/memory.properties
rename : browser/locales/en-US/chrome/browser/devtools/netmonitor.dtd => devtools/client/locales/en-US/netmonitor.dtd
rename : browser/locales/en-US/chrome/browser/devtools/netmonitor.properties => devtools/client/locales/en-US/netmonitor.properties
rename : browser/locales/en-US/chrome/browser/devtools/performance.dtd => devtools/client/locales/en-US/performance.dtd
rename : browser/locales/en-US/chrome/browser/devtools/performance.properties => devtools/client/locales/en-US/performance.properties
rename : browser/locales/en-US/chrome/browser/devtools/projecteditor.properties => devtools/client/locales/en-US/projecteditor.properties
rename : browser/locales/en-US/chrome/browser/devtools/promisedebugger.dtd => devtools/client/locales/en-US/promisedebugger.dtd
rename : browser/locales/en-US/chrome/browser/devtools/promisedebugger.properties => devtools/client/locales/en-US/promisedebugger.properties
rename : browser/locales/en-US/chrome/browser/devtools/responsiveUI.properties => devtools/client/locales/en-US/responsiveUI.properties
rename : browser/locales/en-US/chrome/browser/devtools/scratchpad.dtd => devtools/client/locales/en-US/scratchpad.dtd
rename : browser/locales/en-US/chrome/browser/devtools/scratchpad.properties => devtools/client/locales/en-US/scratchpad.properties
rename : browser/locales/en-US/chrome/browser/devtools/shadereditor.dtd => devtools/client/locales/en-US/shadereditor.dtd
rename : browser/locales/en-US/chrome/browser/devtools/shadereditor.properties => devtools/client/locales/en-US/shadereditor.properties
rename : browser/locales/en-US/chrome/browser/devtools/shared.properties => devtools/client/locales/en-US/shared.properties
rename : browser/locales/en-US/chrome/browser/devtools/sourceeditor.dtd => devtools/client/locales/en-US/sourceeditor.dtd
rename : browser/locales/en-US/chrome/browser/devtools/sourceeditor.properties => devtools/client/locales/en-US/sourceeditor.properties
rename : browser/locales/en-US/chrome/browser/devtools/storage.properties => devtools/client/locales/en-US/storage.properties
rename : browser/locales/en-US/chrome/browser/devtools/styleeditor.dtd => devtools/client/locales/en-US/styleeditor.dtd
rename : browser/locales/en-US/chrome/browser/devtools/styleeditor.properties => devtools/client/locales/en-US/styleeditor.properties
rename : browser/locales/en-US/chrome/browser/devtools/styleinspector.dtd => devtools/client/locales/en-US/styleinspector.dtd
rename : browser/locales/en-US/chrome/browser/devtools/tilt.properties => devtools/client/locales/en-US/tilt.properties
rename : browser/locales/en-US/chrome/browser/devtools/toolbox.dtd => devtools/client/locales/en-US/toolbox.dtd
rename : browser/locales/en-US/chrome/browser/devtools/toolbox.properties => devtools/client/locales/en-US/toolbox.properties
rename : browser/locales/en-US/chrome/browser/devtools/webConsole.dtd => devtools/client/locales/en-US/webConsole.dtd
rename : browser/locales/en-US/chrome/browser/devtools/webaudioeditor.dtd => devtools/client/locales/en-US/webaudioeditor.dtd
rename : browser/locales/en-US/chrome/browser/devtools/webaudioeditor.properties => devtools/client/locales/en-US/webaudioeditor.properties
rename : browser/locales/en-US/chrome/browser/devtools/webconsole.properties => devtools/client/locales/en-US/webconsole.properties
rename : browser/locales/en-US/chrome/browser/devtools/webide.dtd => devtools/client/locales/en-US/webide.dtd
rename : browser/locales/en-US/chrome/browser/devtools/webide.properties => devtools/client/locales/en-US/webide.properties
rename : toolkit/locales/en-US/chrome/global/devtools/csscoverage.dtd => devtools/shared/locales/en-US/csscoverage.dtd
rename : toolkit/locales/en-US/chrome/global/devtools/csscoverage.properties => devtools/shared/locales/en-US/csscoverage.properties
rename : toolkit/locales/en-US/chrome/global/devtools/debugger.properties => devtools/shared/locales/en-US/debugger.properties
rename : toolkit/locales/en-US/chrome/global/devtools/gcli.properties => devtools/shared/locales/en-US/gcli.properties
rename : toolkit/locales/en-US/chrome/global/devtools/gclicommands.properties => devtools/shared/locales/en-US/gclicommands.properties
rename : toolkit/locales/en-US/chrome/global/devtools/styleinspector.properties => devtools/shared/locales/en-US/styleinspector.properties
extra : commitid : 8hcm3tr7AAi
2015-11-04 15:35:53 -06:00
Margaret Leibovic
f4b96d2bbe
Bug 1218858 - Update tracking protection language in about:privatebrowsing. r=mfinkle
...
--HG--
extra : commitid : 6bd6Dn2CFGH
extra : rebase_source : c8d66d2b97bda921340c7d8400600272ffd4cbee
2015-10-28 11:53:49 -04:00
Mike Hommey
9af046b5b4
Bug 1211765 - Remove remnants from --with-libxul-sdk. r=bsmedberg
...
The configure option has explicitly thrown an error for more than a year now,
and it happens that the remaining way to still forcefully use it has been
broken for more than 8 months.
2015-10-14 08:02:34 +09:00
Mark Finkle
1f09adcae3
Bug 1208203 - Display a 'Printing...' indicator toast when starting a print job r=sebastian
2015-09-30 09:40:09 -04:00
Jonathan Almeida [:jonalmeida]
d90d4c18d9
Bug 1170725 - Click-to-play images. r=mfinkle
...
--HG--
extra : transplant_source : %E7%19%F3%EF%A2%A4%09%D2%29G%C7Es%C4%16%CF%03%B0%84%A6
2015-08-15 23:36:37 -07:00
Nick Alexander
639bb353c8
Bug 1205334 - Part 2: Show an error message in about:accounts when restricted. r=antlam,sebastian
...
--HG--
extra : commitid : LCZoA2mldVz
extra : rebase_source : b69ab5bdf59320c3d3dea493c397b567e9bc0aad
2015-09-17 14:51:54 -04:00
Nick Alexander
cdb092fe66
Bug 1191067 - Add Fennec version of about:accounts. r=antlam,margaret
...
This is a Fennec version of about:accounts, cribbed largely from
Desktop's implementation. This implementation serves two purposes:
One, it allows all fxa-content-server pref handling to remain in
Gecko. Java-side consumers redirect to about:accounts?action=... and
have pref munging and parameter addition (like context=fx_fennec_v1,
etc) handled by about:accounts itself.
Two, it handles network connectivity display and error handling. When
a request is started, we display an animated spinner. We transition
smoothly from the spinner to the iframe display if we can, and if not
we hide any network error and offer to retry. This is more important
in Fennec than it is on Desktop. This approach agrees with Firefox
for iOS.
Some additional notes:
The spinner to iframe transition uses the WebChannel listener to send
LOADED messages to the appropriate XUL <browser> element. It's worth
remembering that Fennec's Gecko is single process, so the <browser> in
question is in the same process. None-the-less, we are close to e10s
safe.
There are four actions: signup/signin/force_reauth, and manage. The
first three try to produce a LOGIN message. The last uses the
fxa-content-server to manage the Account settings. *This is not how
this is arranged on Desktop: Desktop redirects to a new tab, not
wrapped in about:accounts.*
--HG--
extra : commitid : F2waTwe355B
extra : rebase_source : f63c96f676d1300c774d091968ec8d88bb7a86dc
2015-09-18 16:28:14 -04:00