Commit Graph

154 Commits

Author SHA1 Message Date
Andreas Pehrson
19b125b016 Bug 1537986 - Add facingMode to MediaEngineRemoteVideoSource's settings. r=jib
Differential Revision: https://phabricator.services.mozilla.com/D32965

--HG--
extra : moz-landing-system : lando
2019-06-03 10:40:02 +00:00
Dan Minor
522725a730 Bug 1497559 - Remove application capture support; r=ng
This removes all references to application capture except from MediaSourceEnum.
That was left in place so as to not change the enumerated values used
for WEBRTC_GET_USER_MEDIA_TYPE telemetry.

Differential Revision: https://phabricator.services.mozilla.com/D28089

--HG--
extra : moz-landing-system : lando
2019-04-26 16:35:39 +00:00
Sylvestre Ledru
03c8e8c2dd Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
2019-04-05 21:41:42 +00:00
Csoregi Natalia
ba58e936bd Backed out changeset 4ad80127f89f (bug 1519636) for bustage on MarkupMap.h and nsAccessibilityService.cpp. CLOSED TREE 2019-04-05 09:48:19 +03:00
Sylvestre Ledru
d1c1878603 Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
2019-04-04 21:36:16 +00:00
Narcis Beleuzu
24dbe577a5 Backed out changeset 389b6bbd76db (bug 1519636) for bustages on MarkupMap.h . CLOSED TREE 2019-04-05 00:27:56 +03:00
Sylvestre Ledru
399dbd28fe Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
2019-04-04 20:12:23 +00:00
Andreas Pehrson
45fe07077f Bug 1494675 - Remove AllocationHandle. r=padenot
The handle was used to keep separate allocations of the same source in a single
process apart. Sources no longer use sharing, so we no longer need allocations
or their handles even as a concept.

Differential Revision: https://phabricator.services.mozilla.com/D24901

--HG--
extra : moz-landing-system : lando
2019-03-27 14:10:24 +00:00
Andreas Pehrson
5797084794 Bug 1525323 - Remove SourceTrackListener from MediaManager. r=padenot
This moves the responsibility of forwarding NotifyPull() from the graph thread
to MediaEngineSources out of MediaManager and into the sources themselves. This
is better aligned with how the sources work, since not all sources need pulling.
This also clarifies lifetime management of these listeners in relation to when
pulling is enabled for a track, since the sources are already handling enabling
pulling themselves.

Differential Revision: https://phabricator.services.mozilla.com/D24896

--HG--
extra : moz-landing-system : lando
2019-03-27 18:05:56 +00:00
Andreas Pehrson
7f6e56584f Bug 1538113 - Fix dom/media/webrtc static-analysis warnings. r=jib
Initially indicated by: https://phabricator.services.mozilla.com/D22910#inline-142013
Rest found by: ./mach static-analysis check dom/media/webrtc

Differential Revision: https://phabricator.services.mozilla.com/D24511

--HG--
extra : moz-landing-system : lando
2019-03-25 18:52:57 +00:00
Andreas Pehrson
e57962eea8 Bug 1423253 - Remove durations from VideoSegment::AppendFrame. r=padenot
VideoSegments still have durations, and they are still needed by the
MediaStreamGraph as it shuffles MediaSegments around.
They do not have a say in the wall-clock duration of video frames however.
Removing this should prevent any producers starting to add video chunks with
durations in the future.

Differential Revision: https://phabricator.services.mozilla.com/D22914

--HG--
extra : moz-landing-system : lando
2019-03-22 11:43:40 +00:00
Andreas Pehrson
78c790ab2a Bug 1423253 - Change MediaEngineRemoteVideoSource to push instead of pull. r=padenot
Differential Revision: https://phabricator.services.mozilla.com/D22901

--HG--
extra : moz-landing-system : lando
2019-03-22 11:42:23 +00:00
Alex Chronopoulos
871823085b Bug 1213453 - Add getters/setters for group id in MediaEngineSource and the derived classes. r=pehrsons
Differential Revision: https://phabricator.services.mozilla.com/D20370

--HG--
extra : moz-landing-system : lando
2019-03-08 11:51:59 +00:00
Narcis Beleuzu
ccb04a4f95 Backed out 5 changesets (bug 1213453) for bustages on MediaEngineDefault.cpp . CLOSED TREE
Backed out changeset 118792523194 (bug 1213453)
Backed out changeset 6208d9e15f3d (bug 1213453)
Backed out changeset ec1da6bbf1a7 (bug 1213453)
Backed out changeset f78c357f2f5f (bug 1213453)
Backed out changeset 6903f0739e83 (bug 1213453)
2019-03-08 13:34:52 +02:00
Alex Chronopoulos
c00f4787e9 Bug 1213453 - Add getters/setters for group id in MediaEngineSource and the derived classes. r=pehrsons
Differential Revision: https://phabricator.services.mozilla.com/D20370

--HG--
extra : moz-landing-system : lando
2019-03-08 10:33:51 +00:00
Ryan Hunt
00e98538aa Bug 1523969 part 6 - Move method definition inline comments to new line in 'dom/'. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D21106

--HG--
extra : rebase_source : ea3f51c2c11247114deccbc86e90fb02b8a97257
2019-02-25 16:05:29 -06:00
Andreas Pehrson
d8bf65f800 Bug 1513973 - Make MediaEngineSource::SetTrack return void. r=jib
All subclasses are now returning NS_OK, so there's no point in keeping nsresult
as the return type.

Differential Revision: https://phabricator.services.mozilla.com/D15193

--HG--
extra : moz-landing-system : lando
2019-01-04 06:39:40 +00:00
Jan-Ivar Bruaroey
cbb94950ec Bug 1321221 - Delay getDisplayMedia() promise until first frame arrives, to pass wpt. r=ng
Differential Revision: https://phabricator.services.mozilla.com/D15283

--HG--
extra : moz-landing-system : lando
2018-12-28 03:13:11 +00:00
Jan-Ivar Bruaroey
ee3a9f9f4f Bug 1474376 - Merge window+screen sharing for content (list fullscreen as option in window-list), and get away from MediaSourceEnum. r=pehrsons,florian
Differential Revision: https://phabricator.services.mozilla.com/D14941

--HG--
extra : moz-landing-system : lando
2018-12-27 23:40:36 +00:00
Dorel Luca
12e4f91411 Backed out 5 changesets (bug 1513973) for browser-chrome failures in browser/base/content/test/webrtc/browser_devices_get_user_media_screen.js. CLOSED TREE
Backed out changeset 2ddf61b1db11 (bug 1513973)
Backed out changeset 6c839f548745 (bug 1513973)
Backed out changeset 5669b30f2265 (bug 1513973)
Backed out changeset 6781e633d62c (bug 1513973)
Backed out changeset f1892f178011 (bug 1513973)
2018-12-21 23:28:51 +02:00
Andreas Pehrson
4c26324fd2 Bug 1513973 - Make MediaEngineSource::SetTrack return void. r=jib
All subclasses are now returning NS_OK, so there's no point in keeping nsresult
as the return type.

Differential Revision: https://phabricator.services.mozilla.com/D15193

--HG--
extra : moz-landing-system : lando
2018-12-21 20:03:42 +00:00
Jan-Ivar Bruaroey
5a89bd8fda Bug 1512280 - Make LOG macros clang-format friendlier. r=padenot
Differential Revision: https://phabricator.services.mozilla.com/D13859

--HG--
extra : moz-landing-system : lando
2018-12-12 20:42:18 +00:00
Dorel Luca
d1d958a798 Backed out 4 changesets (bug 1512280) for bmsvc build bustage
Backed out changeset abe934612616 (bug 1512280)
Backed out changeset 9463a1a3d790 (bug 1512280)
Backed out changeset 9a68c5f1ca0d (bug 1512280)
Backed out changeset 616721cad893 (bug 1512280)
2018-12-12 07:22:49 +02:00
Jan-Ivar Bruaroey
b43cd8e1dd Bug 1512280 - Make LOG macros clang-format friendlier. r=padenot
Differential Revision: https://phabricator.services.mozilla.com/D13859

--HG--
extra : moz-landing-system : lando
2018-12-12 02:36:51 +00:00
Andreas Pehrson
80cde33d12 Bug 1423241 - Always add tracks at the stream's current time. r=padenot
Differential Revision: https://phabricator.services.mozilla.com/D12271

--HG--
extra : moz-landing-system : lando
2018-11-23 15:01:42 +00:00
Andreas Pehrson
193fd8f3eb Bug 1423241 - Move MediaManager from a stream listener to track listeners. r=padenot
Differential Revision: https://phabricator.services.mozilla.com/D12268

--HG--
extra : moz-landing-system : lando
2018-11-23 15:00:20 +00:00
Sylvestre Ledru
804b8b8883 Bug 1204606 - Reformat of dom/media r=jya
# skip-blame

Differential Revision: https://phabricator.services.mozilla.com/D12251

--HG--
extra : moz-landing-system : lando
2018-11-19 13:25:37 +00:00
Dan Minor
4967afba54 Bug 1376873 - Updates to dom/media/, dom/media/systemservices and dom/media/webrtc; r=pehrsons
Differential Revision: https://phabricator.services.mozilla.com/D7438

--HG--
extra : rebase_source : 940e0276f8881e4697771f49e85bca6e41fd7c47
2018-02-20 15:23:09 -05:00
Dan Minor
593c290d35 Bug 1376873 - Rollup conflict fixes for audio/video code; r=pehrsons
MozReview-Commit-ID: 1T8mgqdkzq3

Differential Revision: https://phabricator.services.mozilla.com/D7427

--HG--
extra : rebase_source : 2ca9a77c98b703f849073c92b6b2448de9b8e1f5
2018-01-22 15:04:26 -05:00
Jan-Ivar Bruaroey
6b5cb93598 Bug 1497351 - Remove dictionary null defaults from MediaTrackConstraintSet; handle absence in NormalizedConstraintSet. r=bzbarsky,pehrsons
Differential Revision: https://phabricator.services.mozilla.com/D8054

--HG--
extra : moz-landing-system : lando
2018-10-11 02:03:17 +00:00
Jan-Ivar Bruaroey
9e5c5ec071 Bug 1495478 - Move LogConstraints() to class MediaConstraintsHelper and add logging of missing constraints (rollup includes backed-out bug 1494498) r=pehrsons
Differential Revision: https://phabricator.services.mozilla.com/D7378

--HG--
extra : moz-landing-system : lando
2018-10-02 16:13:20 +00:00
Narcis Beleuzu
f12bd72768 Backed out changeset d0a586d4d64a (bug 1494498) for Windows MinGW bustages on MediaTrackConstraints.cpp 2018-10-02 04:43:30 +03:00
Jan-Ivar Bruaroey
69468683c7 Bug 1494498 - Some constraints were missing in MediaManager logs. r=pehrsons
Differential Revision: https://phabricator.services.mozilla.com/D7153

--HG--
extra : moz-landing-system : lando
2018-10-01 14:34:33 +00:00
Andreas Pehrson
529b7c66ea Bug 1488832 - Change init assert to runtime guard. r=jib
Differential Revision: https://phabricator.services.mozilla.com/D6144

--HG--
extra : moz-landing-system : lando
2018-09-20 12:29:50 +00:00
Andreas Pehrson
c66af482b6 Bug 1490700 - Cap capability values to avoid truncation. r=jib
Differential Revision: https://phabricator.services.mozilla.com/D5785

--HG--
extra : moz-landing-system : lando
2018-09-14 09:15:53 +00:00
Andreas Pehrson
bbcf773bf1 Bug 1490700 - Ignore scaling requests to a max dimension of 0. r=jib
Differential Revision: https://phabricator.services.mozilla.com/D5784

--HG--
extra : moz-landing-system : lando
2018-09-14 09:16:24 +00:00
Andreas Pehrson
ebd2cf6c8c Bug 1471588 - Trace all NotifyPull calls. r=padenot
MozReview-Commit-ID: XlYfZ0CVZM

--HG--
extra : rebase_source : 8c147419731942a35e27d0aab0e2c4a6a9747438
2018-06-27 17:59:19 +02:00
Emilio Cobos Álvarez
fffb25b74f Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
This was done automatically replacing:

  s/mozilla::Move/std::move/
  s/ Move(/ std::move(/
  s/(Move(/(std::move(/

Removing the 'using mozilla::Move;' lines.

And then with a few manual fixups, see the bug for the split series..

MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Dan Minor
50a3ab6cd4 Bug 1450658 - Should bring window to front when screen-sharing a window; r=pehrsons
This adds a FocusOnSelectedSource method to PCameras and uses it to focus the
selected window while window sharing. We can't just focus the window as soon as
it is shared because we have a live preview in the getUserMedia permissions
prompt which would cause the prompt to lose focus. Instead, this only focuses the
window when the sharing is not done from a chrome context.


MozReview-Commit-ID: 5jre75E3JLi

--HG--
extra : rebase_source : 5f5154fc9fc7590cc02eb25146e5bc20b2243fa3
2018-05-08 15:55:36 -04:00
Dorel Luca
8e1a0ee1c6 Backed out changeset c13ca75c9bcb (bug 1450658) for Browser-Chrome failures on browser/base/content/test/webrtc/browser_devices_get_user_media_screen.js 2018-05-23 17:07:33 +03:00
Dan Minor
40fcbf60d9 Bug 1450658 - Should bring window to front when screen-sharing a window; r=pehrsons
This adds a FocusOnSelectedSource method to PCameras and uses it to focus the
selected window while window sharing. We can't just focus the window as soon as
it is shared because we have a live preview in the getUserMedia permissions
prompt which would cause the prompt to lose focus. Instead, this only focuses the
window when the sharing is not done from a chrome context.


MozReview-Commit-ID: 5jre75E3JLi

--HG--
extra : rebase_source : 97f472f6ed1c5d6bed1af01fb7243a82b2629b03
2018-05-08 15:55:36 -04:00
Andreas Pehrson
1c41efddfa Bug 1454625 - Don't update settings from constraints if already updated from frame. r=padenot
MozReview-Commit-ID: KgiPUnXCWoM

--HG--
extra : rebase_source : 2f378128008ed8c95fb7f3cb3b6601c54ef4c88b
2018-04-17 17:09:11 +02:00
Andreas Pehrson
3be3fab400 Bug 1454625 - Schedule settings update before setting mImage. r=padenot
MozReview-Commit-ID: 9IasAgJImuI

--HG--
extra : rebase_source : 67fc9036b72c19f8fa73084053d617537e0cdaca
2018-04-17 11:14:19 +02:00
Nico Grunbaum
b5c0e1c02f Bug 1449832 - restore screen share scaling code to prevent cropping r=pehrsons
MozReview-Commit-ID: KctPLbF4PSa

--HG--
extra : rebase_source : 8a3a63a1df890e2343dec44f4cdfe1193d317a9a
2018-04-12 14:26:14 -07:00
Andreas Pehrson
c376bbc538 Bug 1450954 - Add back code to undo screenshare constraints hack. r=jib
MozReview-Commit-ID: 9rDRj7U8vQi

--HG--
extra : source : e2bd588aa90fe44fe38caed6bc7680111394b934
extra : histedit_source : 148034b0adc84941ae9c39716bb3da6d8258e3a4
2018-04-10 13:13:41 +02:00
Andreas Pehrson
1e2190d040 Bug 1451798 - Check the variable actually containing the string. r=jib
MozReview-Commit-ID: 2xizfHwVPiW

--HG--
extra : rebase_source : 345327a6721e84b64ba3b66cb308dbe1100391bb
2018-04-06 15:06:46 +02:00
Andreas Pehrson
4c95dc3099 Bug 1438134 - Make the return value of MediaEngineSource::Reconfigure well defined. r=jib
MozReview-Commit-ID: DR3sdtdZkob

--HG--
extra : rebase_source : 35d60c11c8bd50547062af708cb009f7835b5893
2018-02-22 15:35:16 +01:00
Andreas Pehrson
f88baf18ca Bug 1438134 - Apply new capability only after stopping capture. r=jib
MozReview-Commit-ID: 6rtcyFpwxmP

--HG--
extra : rebase_source : 8f8b510f7a0369e2f07a61dbdfcaa9272674b0ad
2018-02-14 12:24:25 +01:00
Andreas Pehrson
411e973fab Bug 1436694 - Clarify that MediaEngineSources can be double-stopped. r=padenot
This is already true for the audio sources. It should be for all.

Crashtests showed that shutting down amidst the async init can lead to
double-stops. It is impossible to completely protect yourself from them without
waiting for all queued operations to resolve (results to become known) before
taking action. Doing that would require a refactor in MediaManager and cause
higher latency for device operations so it seems like the wrong way to go.

MozReview-Commit-ID: 5Cci6whzTL7

--HG--
extra : rebase_source : f4dccbc5a56e33ecc54d63ddefbae43d90ee95d4
extra : source : f5cc71d38e4a7c0e4db830242c1d454fcbdb9e48
extra : histedit_source : 3cd8615054ce9935047e4168c3a472152792886b
2018-02-22 12:23:06 +01:00
Andreas Pehrson
c2cf44b1d5 Bug 1441145 - Swap width and height in target capability if the frame is rotated. r=jib
MozReview-Commit-ID: 3QO3W0J3b6G

--HG--
extra : rebase_source : 956fe446b34fb797e11a36ab21b9808c23ac8cc1
2018-02-26 15:42:57 +01:00