Alex Lopez
1ee8086c02
Bug 1696251 - Refactor constructors in MachCommandBase subclasses to remove them. r=mhentges,remote-protocol-reviewers
...
Another step towards avoiding the need for classes in mach commands;
here we are removing constructors either by changing them into helpers
or by simple refactorings.
Differential Revision: https://phabricator.services.mozilla.com/D112434
2021-05-28 18:30:03 +00:00
Butkovits Atila
6bb47ac424
Backed out changeset 4b889750da57 (bug 1696251) for causing lint failures. CLOSED TREE
2021-05-28 01:43:11 +03:00
Alex Lopez
2e8613720d
Bug 1696251 - Refactor constructors in MachCommandBase subclasses to remove them. r=mhentges,remote-protocol-reviewers
...
Another step towards avoiding the need for classes in mach commands;
here we are removing constructors either by changing them into helpers
or by simple refactorings.
Differential Revision: https://phabricator.services.mozilla.com/D112434
2021-05-27 21:03:46 +00:00
Alex Lopez
07cf832a8a
Bug 1696251 - Turn all properties in MachCommandBase subclasses into methods. r=mhentges,perftest-reviewers,sparky
...
As a step towards moving mach commands outside of classes, this converts all
properties into methods so that they can later become top-level helper functions.
Differential Revision: https://phabricator.services.mozilla.com/D112196
2021-05-26 18:08:02 +00:00
Alex Lopez
455d9a088b
Bug 1696251 - Pass MachCommandBase object as first argument for Mach Commands. r=mhentges,remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers
...
As an intermediate step to allow mach commands as standalone functions, the MachCommandBase
subclass instance that currently corresponds to self has to be made available as a separate
argument (named command_context).
Differential Revision: https://phabricator.services.mozilla.com/D109650
2021-05-17 16:15:58 +00:00
Butkovits Atila
2e34e363b9
Backed out 2 changesets (bug 1696251) for causing js-bench-sm failures. CLOSED TREE
...
Backed out changeset 1c84c9a34575 (bug 1696251)
Backed out changeset e169193b7423 (bug 1696251)
2021-04-23 02:53:36 +03:00
Alex Lopez
41687360e8
Bug 1696251 - Turn all properties in MachCommandBase subclasses into methods. r=mhentges,perftest-reviewers,sparky
...
As a step towards moving mach commands outside of classes, this converts all
properties into methods so that they can later become top-level helper functions.
Differential Revision: https://phabricator.services.mozilla.com/D112196
2021-04-22 19:44:52 +00:00
Alex Lopez
d1a82b8092
Bug 1696251 - Pass MachCommandBase object as first argument for Mach Commands. r=mhentges,remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers
...
As an intermediate step to allow mach commands as standalone functions, the MachCommandBase
subclass instance that currently corresponds to self has to be made available as a separate
argument (named command_context).
Differential Revision: https://phabricator.services.mozilla.com/D109650
2021-04-22 18:56:15 +00:00
Cosmin Sabou
785f9b8a87
Backed out changeset d4a5d8567977 (bug 1696251) for non-unified build bustages. CLOSED TREE
2021-04-19 19:43:31 +03:00
Alex Lopez
75dfe35468
Bug 1696251 - Pass MachCommandBase object as first argument for Mach Commands. r=mhentges,remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers
...
As an intermediate step to allow mach commands as standalone functions, the MachCommandBase
subclass instance that currently corresponds to self has to be made available as a separate
argument (named command_context).
Differential Revision: https://phabricator.services.mozilla.com/D109650
2021-04-19 16:15:11 +00:00
Mark Banner
dae9d6efad
Bug 1498604 - Make './mach doc' use jsdoc installed into node_modules rather than the system. r=mossop,ahal
...
Differential Revision: https://phabricator.services.mozilla.com/D111652
2021-04-14 13:35:20 +00:00
Alexandru Michis
a2ac402751
Backed out changeset 53d4fb9f562f (bug 1498604) for causing doc generate failures.
...
CLOSED TREE
2021-04-14 02:22:56 +03:00
Mark Banner
6bdee38462
Bug 1498604 - Make './mach doc' use jsdoc installed into node_modules rather than the system. r=mossop,ahal
...
Differential Revision: https://phabricator.services.mozilla.com/D111652
2021-04-13 19:59:37 +00:00
Mitchell Hentges
20b1f0de34
Bug 1694839: Use glean_parser from current python environment r=firefox-build-system-reviewers,glandium
...
Though the `mach` virtual environment is activated, it
hasn't been added to the `$PATH`. So, we can't use the
`$PATH` to find `glean_parser`.
Differential Revision: https://phabricator.services.mozilla.com/D106543
2021-03-12 16:07:10 +00:00
Mitchell Hentges
8e07ea1b2d
Bug 1694838: Show mach doc mach-telemetry
failure reasons r=firefox-build-system-reviewers,glandium
...
Don't capture `glean_parser` output: it has error details,
so should be shown to the user.
Differential Revision: https://phabricator.services.mozilla.com/D106542
2021-03-12 16:07:10 +00:00
Myeongjun Go
95e1fff568
Bug 1691739 - [perfdocs] Display each test description for raptor r=sparky,perftest-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D105643
2021-03-11 15:59:15 +00:00
championshuttler
3f7cb70543
Bug 1691327 - Update sphinxcontrib-mermaid to v0.6.3 DONTBUILD. r=ahal
...
Differential Revision: https://phabricator.services.mozilla.com/D107057
2021-03-04 07:07:58 +00:00
championshuttler
501ee430fa
Bug 1691327 - Update sphinxcontrib-mermaid to v0.6.2 by renovate DONTBUILD.r=sylvestre,firefox-source-docs-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D105660
2021-02-20 19:12:01 +00:00
championshuttler
2d8d6edee2
Bug 1693140 - Fix the mermaid rendering issue and remove post processing script.r=sylvestre DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D105674
2021-02-19 08:45:10 +00:00
championshuttler
4e4eb0a952
Bug 1693140 - Fix the mermaid rendering issue, downroll mermaid version.r=sylvestre DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D105351
2021-02-16 22:03:09 +00:00
Renovate Bot
bcf70ef6e9
Bug 1690989 - Update dependency Sphinx to v3.5.1 r=firefox-source-docs-reviewers,championshuttler DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D105331
2021-02-16 15:58:37 +00:00
Sylvestre Ledru
fcc9fd2a93
no bug - doc(import-mdn): Update the procedure as it didn't work archived pages r=firefox-source-docs-reviewers,championshuttler DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D104992
2021-02-12 14:28:12 +00:00
Sylvestre Ledru
7bc11534bc
no bug - doc(import-mdn): mention that distro packages for pandoc can be too old r=firefox-source-docs-reviewers,championshuttler DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D104830
2021-02-11 18:58:40 +00:00
championshuttler
55195c2881
Bug 1691327 - Update sphinxcontrib-mermaid to v0.6.0 by renovate, DONTBUILD. r=firefox-source-docs-reviewers,sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D104352
2021-02-08 08:34:03 +00:00
Renovate Bot
60ec5ad1db
Bug 1690989 Update dependency Sphinx to v3.4.3 r=firefox-source-docs-reviewers,championshuttler DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D104157
2021-02-08 05:14:43 +00:00
Sylvestre Ledru
9270e2e340
Bug 1690990 - lint: add some requirements.txt to the line check linter + fix them r=linter-reviewers,marco DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D104156
2021-02-05 17:19:40 +00:00
Molly Howell
497fb34bf3
Bug 1615223 - Fix multiple character mapping errors during documentation generation on Windows. r=firefox-source-docs-reviewers,championshuttler
...
Differential Revision: https://phabricator.services.mozilla.com/D102942
2021-01-25 17:52:25 +00:00
Molly Howell
14b6802978
Bug 1454551 - Regenerate requirements.txt so it includes colorama. r=firefox-source-docs-reviewers,sylvestre
...
This diff looks busy, but the only actual change is the addition of colorama to
the list; everything else is just formatting changes that the pip-compile tool
generated for me.
Differential Revision: https://phabricator.services.mozilla.com/D102869
2021-01-25 17:42:54 +00:00
Renovate Bot
c2ff53383e
Bug 1685147 - Update dependency sphinx-rtd-theme to v0.5.1 r=firefox-source-docs-reviewers,championshuttler DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D100812
2021-01-05 22:10:19 +00:00
Sylvestre Ledru
0ac5b07241
Bug 1684863 - Update to Sphinx 3.4.2 r=firefox-source-docs-reviewers,championshuttler DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D100672
2021-01-04 14:16:28 +00:00
Renovate Bot
07ec351c5b
Bug 1683628 - Update dependency Sphinx to v3.4.0 r=firefox-source-docs-reviewers,championshuttler DONTBUILD
...
Found by renovate bot: https://github.com/sylvestre/gecko-dev/pull/128/files
Differential Revision: https://phabricator.services.mozilla.com/D100228
2020-12-21 12:17:03 +00:00
Renovate Bot
88ba586595
Bug 1683628 - Update dependency recommonmark to v0.7.1 r=firefox-source-docs-reviewers,championshuttler DONTBUILD
...
reported https://github.com/sylvestre/gecko-dev/pull/346/files
Differential Revision: https://phabricator.services.mozilla.com/D100229
2020-12-21 12:14:19 +00:00
Julien Cristau
01b1e114d8
Bug 1681736 - Set character set when uploading docs. r=sylvestre DONTBUILD
...
Setting charset to utf-8 seems a safer bet than the default latin1 these
days.
Differential Revision: https://phabricator.services.mozilla.com/D99364
2020-12-10 16:38:38 +00:00
Zac Svoboda
afc3515f1c
Bug 1679631 - documentation: Upgrade the markdown dependency r=sylvestre DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D98107
2020-11-28 17:56:16 +00:00
Zac Svoboda
2c9c8170d3
Bug 1679396 - Upgrade Sphinx and update requirements r=sylvestre DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D97994
2020-11-27 08:54:33 +00:00
Renovate Bot
97196a2329
Bug 1679054 - Update dependency sphinx-copybutton to v0.3.1 r=firefox-source-docs-reviewers,championshuttler DONTBUILD
...
Reported here:
https://github.com/sylvestre/gecko-dev/pull/227
Differential Revision: https://phabricator.services.mozilla.com/D97893
2020-11-23 20:04:24 +00:00
Sylvestre Ledru
5c7636b11a
no bug - Fix more docs warnings (404) r=firefox-source-docs-reviewers,championshuttler DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D92765
2020-10-07 15:30:36 +00:00
Sylvestre Ledru
6f3f63970d
Bug 1667830 - Update of the various dependencies used by the doc r=firefox-source-docs-reviewers,ahal,championshuttler
...
Differential Revision: https://phabricator.services.mozilla.com/D91617
2020-09-28 20:42:52 +00:00
Mitchell Hentges
648ccad85b
Bug 1654074: Publish glean handle to mach commands r=firefox-build-system-reviewers,rstewart
...
Allows mach commands to define their own glean metrics with the `metrics_path` @CommandProvider parameter.
When `metrics_path` is defined:
* A `metrics` kwarg is provided to the decorated class. This `metrics` handle is a Glean instance, so Glean documentation should be consulted for usage information.
* When `mach doc telemetry` is run, metrics docs will be generated from all the registered metrics files.
Note: there was some consideration between making `metrics_path` a @CommandProvider or @Command parameter.
In the end, @CommandProvider seemed like a better fit because:
* Metrics seem to be more associated with the entire class than a specific command/method. This is because a class represents a "domain", and that domain may have different commands that have overlapping metrics. Accordingly, all the metrics should be defined once as available to the entire class.
* Currently, @Command methods only take parameters that map one-to-one with CLI arguments. It could seem inconsistent to have one exception: the metrics handle
Differential Revision: https://phabricator.services.mozilla.com/D85953
2020-09-15 21:15:20 +00:00
Andrew Halberstadt
78e5d41e3e
Bug 1664771 - [docs] Remove bogus 'Expires' header when uploading docs, r=firefox-source-docs-reviewers,championshuttler
...
As per:
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3.html
This header doesn't actually control when an object gets deleted. Rather it is when the object
expires in the browser cache (i.e, when the expiry is hit, the browser will reload the object).
Remove this as it's only causing confusion.
Differential Revision: https://phabricator.services.mozilla.com/D90162
2020-09-14 20:06:57 +00:00
Sylvestre Ledru
fb75df0e5c
Bug 1663916 - mdn to in-tree: Update of the mdn import doc r=dmajor
...
Differential Revision: https://phabricator.services.mozilla.com/D89594
2020-09-09 15:13:07 +00:00
Sylvestre Ledru
da34b6a58e
Bug 1661514 - Reformat some python files with black 20.8b1 r=rstewart
...
# ignore-this-changeset
Depends on D88711
Differential Revision: https://phabricator.services.mozilla.com/D88712
2020-09-07 14:05:10 +00:00
Cristina Coroiu
8eaafae8fd
Backed out 2 changesets (bug 1661514) for lint failure on a CLOSED TREE
...
Backed out changeset 8e58c88f756b (bug 1661514)
Backed out changeset aef89f9a8031 (bug 1661514)
2020-09-01 19:34:12 +03:00
Sylvestre Ledru
5ee2fbd7cb
Bug 1661514 - Reformat some python files with black 20.8b1 r=rstewart
...
# ignore-this-changeset
Depends on D88711
Differential Revision: https://phabricator.services.mozilla.com/D88712
2020-08-31 17:06:22 +00:00
Emil Farisan
76574f22bf
Bug 1657121 - exclude uuid from s3_delete_missing. r=ahal
...
Differential Revision: https://phabricator.services.mozilla.com/D88282
2020-08-27 20:02:59 +00:00
Sylvestre Ledru
18115d5efd
Bug 1660615 - Mach doc: sphinx: pass the -T option by default r=firefox-source-docs-reviewers,championshuttler DONTBUILD
...
It shows exceptions by default:
https://www.sphinx-doc.org/en/master/man/sphinx-build.html#cmdoption-sphinx-build-T
Differential Revision: https://phabricator.services.mozilla.com/D87969
2020-08-23 14:51:51 +00:00
Sylvestre Ledru
fee0487d60
Bug 1652286 - Firefox doc: Workaround the BlockingIOError error r=firefox-source-docs-reviewers,championshuttler
...
Seems the same issue as https://github.com/travis-ci/travis-ci/issues/8920
Differential Revision: https://phabricator.services.mozilla.com/D87952
2020-08-23 08:49:48 +00:00
Sylvestre Ledru
da495a5a28
Bug 1660615 - Add a verbose mode for "mach doc" r=firefox-source-docs-reviewers,championshuttler
...
And show the sphinx arguments
Differential Revision: https://phabricator.services.mozilla.com/D87951
2020-08-23 09:04:26 +00:00
Sylvestre Ledru
dcc2514c21
Bug 1660615 - ride along - reformat moztreedocs with black r=firefox-source-docs-reviewers,championshuttler
...
Differential Revision: https://phabricator.services.mozilla.com/D87950
2020-08-23 08:49:52 +00:00
Sylvestre Ledru
612c02c213
Bug 1658812 - sphinx/autodoc should also ignore tests directory r#?firefox-source-docs-reviewers r=firefox-source-docs-reviewers,ahal
...
Differential Revision: https://phabricator.services.mozilla.com/D86854
2020-08-22 14:23:47 +00:00