Commit Graph

182 Commits

Author SHA1 Message Date
Mike de Boer
799660b14d Bug 1548031 - Enable the QuantumBar on Nightly and early Beta. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D29538

--HG--
extra : moz-landing-system : lando
2019-05-01 17:46:23 +00:00
Dão Gottwald
42758455d8 Bug 1522440 - Finish porting browser_test_focus_urlbar.js to quantumbar. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D29119

--HG--
extra : moz-landing-system : lando
2019-04-29 20:00:28 +00:00
Drew Willcoxon
c1f323bbe7 Bug 1541929 - Don't autofill the first result in some cases. r=mak
We need to handle autofilling the first result separately from autofilling results in general (which happens in UrlbarInput.setValueFromResult), so add a new UrlbarInput.autofillFirstResult method. The controller calls it instead of setValueFromResult. I ported the logic from nsAutoCompleteController, as described in the bug.

Other changes are related to the new test for this.

As part of this work, I was interested in learning how awesomebar handles browser_autoFill_typed.js, so I added it to the legacy tests, with a small tweak in the test for awesomebar.

Differential Revision: https://phabricator.services.mozilla.com/D26852

--HG--
extra : moz-landing-system : lando
2019-04-15 13:15:30 +00:00
Mark Banner
53b3788bba Bug 1415265 - Implement a central configuration for setting ESLint environments for test directories. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D23849

--HG--
extra : moz-landing-system : lando
2019-03-28 09:38:02 +00:00
Mark Banner
2219bbd153 Bug 1536645 - Enable some ESLint rules in accessible/tests/browser where they are already enabled in the global configuration. r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D24105

--HG--
extra : moz-landing-system : lando
2019-03-21 08:51:28 +00:00
Mark Banner
4896af57f9 Bug 1536645 - Remove unnecessary rule definitions (obsolete, no need to override etc) in accessible/tests/browser/.eslintrc.js. r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D24104

--HG--
extra : moz-landing-system : lando
2019-03-21 08:51:08 +00:00
Dão Gottwald
4a910bb78f Bug 1536753 - browser_test_focus_urlbar.js: make waitForSearchFinish work with the quantumbar enabled. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D24144

--HG--
extra : moz-landing-system : lando
2019-03-20 10:29:26 +00:00
Ian Moody
167f623a3e Bug 1246594 - Enable ESLint rule no-throw-literal by default. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D24088

--HG--
extra : moz-landing-system : lando
2019-03-19 22:02:42 +00:00
Mark Banner
6ea18465bb Bug 1534661 - Fix the QuantumBar results view to have an accessible role of ROLE_COMBOBOX_LIST. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D23155

--HG--
extra : moz-landing-system : lando
2019-03-15 16:43:11 +00:00
Edwin Gao
a5bef7a7c7 Bug 1531590, 1531598, 1534811, 1336075, 1531571, 1531572, 1531572, 1531574, 1534855, 1534857, 1535082 - skip tests in mochitest-dev-tools and mochitest-browser-chrome suites for windows10-aarch64 r=jmaher
Bug 1531598 - disable browser_markup_copy_image_data.js
Bug 1531598 - disable browser_markup_links_04.js
Bug 1531598 - disable browser_inspector_menu-01-sensitivity.js
Bug 1534811 - disable accessible/tests/browser/general
Bug 1336075 - disable browser_largeAllocation_non_win32.js
Bug 1531571 - disable browser_jsterm_context_menu_labels.js
Bug 1531572 - disable browser_jsterm_helper_dollar_x.js
Bug 1531573 - disable browser_jsterm_no_input_and_tab_key_pressed.js
Bug 1531574 - disable browser_jsterm_syntax_highlight_output.js
Bug 1534855 - disable accessible/tests/browser/
Bug 1534857 - disable browser_ext_slow_script.js
Bug 1535082 - disable browser_jsterm_helper_dollar_dollar.js

Differential Revision: https://phabricator.services.mozilla.com/D23369

--HG--
extra : moz-landing-system : lando
2019-03-13 19:47:25 +00:00
Mark Banner
8fa4d25923 Bug 1532367 - Remove accessible/.eslintrc.js and use the global rules for accessible/ r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D21973

--HG--
extra : moz-landing-system : lando
2019-03-04 21:47:38 +00:00
Eitan Isaacson
773b9d611a Bug 1525980 - Make announcement events work over IPC. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D19061

--HG--
extra : moz-landing-system : lando
2019-02-14 17:42:47 +00:00
Myk Melez
25349d2601 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526

--HG--
extra : moz-landing-system : lando
2019-01-30 17:26:25 +00:00
Marco Zehe
61a4918bc9 Bug 646216 - Thin out the tree by only creating accessibles for relevant divs, r=Jamie,timdream
Relevant divs are:

* Those that have an ID attribute. This is important so anchors still work.
* Those whose first or last child is a text-only node.
* Those whose first or last child has an inline frame.

We now discard divs that are not display:block; or display:inline-block;. We also discard divs that are part of an anonymous subtree.

We stop creating divs from the eHyperTextType frame type alltogether.

Note that because of shadow DOM properties in the video controls, two additional divs with IDs require role="none" in the media controls widget code.

Differential Revision: https://phabricator.services.mozilla.com/D17348

--HG--
extra : moz-landing-system : lando
2019-01-29 04:17:20 +00:00
Jeff Walden
ed23151bd7 Bug 1492937 - Make the JS subscript loader load scripts exclusively as UTF-8, with no way to specify any other encoding, and adjust a bunch of existing tests to use UTF-8 directly, rather than Unicode escape sequences or similar. (This also changes the encoding of .sjs scripts and all mochitest-browser tests in the tree from Latin-1 to UTF-8.) r=yzen, r=MattN, r=jimb, r=kmag 2018-12-19 13:46:20 -08:00
Mark Banner
e2234d6da6 Bug 1415483 - Extend reject-importGlobalProperties to reject any priviliged items already in scope. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D13753

--HG--
extra : moz-landing-system : lando
2018-12-11 21:39:38 +00:00
Csoregi Natalia
9e970681f2 Backed out 2 changesets (bug 1415483) for multiple failures e.g. on test_message_manager_ipc.html. CLOSED TREE
Backed out changeset d00748de66fc (bug 1415483)
Backed out changeset 8dea94258f54 (bug 1415483)
2018-12-11 19:30:57 +02:00
Mark Banner
4d543888a6 Bug 1415483 - Extend reject-importGlobalProperties to reject any priviliged items already in scope. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D13753

--HG--
extra : moz-landing-system : lando
2018-12-11 14:09:24 +00:00
Cristina Coroiu
60654b0cda Bug 1503084 - disable browser_caching_name.js for frequent failures r=gbrown
--HG--
extra : histedit_source : 71daa8098bf1d42a05c479f9bb708925b1bbfced
2018-11-14 07:21:00 +02:00
rosston
8f54bcb47f Bug 1501904 - Fire accessibility focus events when using readline nav in url bar r=dao,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D10058

--HG--
extra : moz-landing-system : lando
2018-11-08 14:14:57 +00:00
Narcis Beleuzu
9b3f73e696 Merge mozilla-central to inbound. CLOSED TREE 2018-11-05 23:54:03 +02:00
Jonathan Kingston
4248b4c554 Bug 1490257 - Pass triggeringPrincipal to test code. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D10882

--HG--
extra : moz-landing-system : lando
2018-11-05 14:05:47 +00:00
Gurzau Raul
424b125b93 Backed out changeset 523ff2753dea (bug 1490257) for causing Bug 1503757 a=backout 2018-11-01 15:27:30 +02:00
Jonathan Kingston
873b26107e Bug 1490257 - Add asserts into loadURI where we imply SystemPrincipal. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D10221

--HG--
extra : moz-landing-system : lando
2018-10-31 18:00:40 +00:00
Narcis Beleuzu
8d8917f40b Bug 1462638 - Disable browser_treeupdate_canvas.js on Win10 opt/pgo for frequent failures. r=jmaher 2018-11-05 13:04:47 +02:00
Julian Descottes
f6a4b55fda Bug 1503169 - Remove missing layout.js loadScript calls;r=yzen
Depends on D10191
I would like to update browser-test.js to stop swallowing exceptions
when calling loadSubScript from head.js.

It looks like those head files are trying to load a layout.js helper
that I could not find in any revision. Can you check it can be
removed?

Differential Revision: https://phabricator.services.mozilla.com/D10193

--HG--
extra : moz-landing-system : lando
2018-10-30 14:13:25 +00:00
Dorel Luca
451e26f0c6 Backed out changeset 8d7987ea4fb1 (bug 1490257) for causing android failures. CLOSED TREE 2018-10-15 14:39:00 +03:00
Jonathan Kingston
8bcd10a7ab Bug 1490257 - Add asserts and remove implied system triggering principal code r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D8368

--HG--
extra : moz-landing-system : lando
2018-10-15 06:29:45 +00:00
Jonathan Kingston
038c8e8573 Bug 1485305 - accessible/ Ensure loadURI always passes a triggeringPrincipal() r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D4550

--HG--
extra : source : f33d4832f8a34681bc389792698d880ebe29d542
extra : intermediate-source : 609dab5dcf7b4545252f91213f562cc4d01622bf
2018-08-29 15:39:16 +01:00
Brindusan Cristian
1db0587c0e Backed out 10 changesets (bug 1485305) for browser-chrome failures on docshell/test/browser/browser_loadURI.js. CLOSED TREE
Backed out changeset 50439ec01661 (bug 1485305)
Backed out changeset a05e40ef7215 (bug 1485305)
Backed out changeset c99b97b4348b (bug 1485305)
Backed out changeset 75220b2f6669 (bug 1485305)
Backed out changeset e698f2fc1c1a (bug 1485305)
Backed out changeset acce14683c13 (bug 1485305)
Backed out changeset 323773a395cc (bug 1485305)
Backed out changeset 1b74152cabc1 (bug 1485305)
Backed out changeset 4b5c9d5929fc (bug 1485305)
Backed out changeset 238d92348159 (bug 1485305)
2018-09-19 18:47:27 +03:00
Jonathan Kingston
d67cb9e4a6 Bug 1485305 - accessible/ Ensure loadURI always passes a triggeringPrincipal() r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D4550

--HG--
extra : source : f33d4832f8a34681bc389792698d880ebe29d542
2018-08-29 15:39:16 +01:00
arthur.iakab
d2e647e133 Backed out 10 changesets (bug 1485305)for failing browser chrome tests on browser_loadDisallowInherit.js
Backed out changeset 138b8596a9cd (bug 1485305)
Backed out changeset d9f04aeeeef7 (bug 1485305)
Backed out changeset cd063d8afe4e (bug 1485305)
Backed out changeset 2f8a5a03ccb5 (bug 1485305)
Backed out changeset 8085d1eefd7c (bug 1485305)
Backed out changeset 3aaccb374a59 (bug 1485305)
Backed out changeset 3a111e9e5c9c (bug 1485305)
Backed out changeset 61aa1cfb0b01 (bug 1485305)
Backed out changeset bca973d90acc (bug 1485305)
Backed out changeset 4eb33bf25d6f (bug 1485305)
2018-09-18 20:30:07 +03:00
Jonathan Kingston
b81ad8c8ab Bug 1485305 - accessible/ Ensure loadURI always passes a triggeringPrincipal() r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D4550

--HG--
extra : source : 99a052d21ca0a7d7c1c224cfa1c65396e1d43bab
2018-08-29 15:39:16 +01:00
James Teh
6b89ed218b Bug 1331755: Refactor handling of accessibility focus in the URL bar so focus never moves to suggestions while the user is editing. r=Gijs,MarcoZ
When the user is editing the text in the URL bar (typing, backspace, etc.), the first suggestion is always selected.
Because accessibility clients require autocomplete items to be "focused", the code needs to differentiate between explicit selection (e.g. via down/up arrow) and auto selection (e.g. when typing).
Otherwise, the focus continually moves away from the text box while the user is typing, as was previously occurring.
This makes it very difficult for the user to edit text, particularly backspace/delete.

There was a previous attempt to handle this, but it was somewhat fragile and broke completely some time ago.
Now, rather than trying to handle this based on autocomplete events, it is handled in the input and key press events.
For input events, accessibility focus is forced back to the text box and further accessibility focus events are suppressed.
For down arrow, up arrow, etc. key presses, accessibility focus events for suggestions are enabled.
This makes it easier to understand and predict the user experience, rather than relying on underlying autocomplete implementation details.

This is tested using an accessibility browser test, which makes it easier to make assertions about accessibility focus.
This also means that if the underlying implementation details change (e.g. HTML + aria-activedescendant instead of XUL + DOMMenuItemActive events), this test should still be valid and allow us to catch regressions.

Differential Revision: https://phabricator.services.mozilla.com/D5987

--HG--
extra : moz-landing-system : lando
2018-09-18 05:10:35 +00:00
Cosmin Sabou
6294a344fe Merge mozilla-central to mozilla-inbound. a=merge 2018-09-11 13:17:29 +03:00
Cosmin Sabou
c56ce0a961 Bug 1445513 - Disable accessible/tests/browser/tree/browser_aria_owns.js on all platforms for frequent failures. r=jmaher
--HG--
extra : rebase_source : 91f1ecfdbeae97fe8846052e0418758b9aa200d0
2018-09-11 12:29:26 +03:00
Marco Zehe
812e2003df Bug 1489934 - accessible/tests/browser/events/browser_test_docload.js calls waitForEvents incorrectly, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D5400

--HG--
extra : moz-landing-system : lando
2018-09-10 22:50:31 +00:00
Eliza Balazs
500ab718cc Bug 1421307 - Disable browser_shutdown_acc_reference.js on linux64 debug for frequent failures. r=jmaher 2018-09-05 05:28:00 +03:00
Mark Banner
c6885f5391 Bug 1488445 - Remove and replace obsolete ESLint rules. r=mossop
This removes a number of references to rules that are now deprecated or removed from ESLint.

- no-native-reassign is replaced with no-global-assign
- no-spaced-func is replaced with func-call-spacing (where enabled)

Depends on D4944

Differential Revision: https://phabricator.services.mozilla.com/D4946

--HG--
extra : moz-landing-system : lando
2018-09-04 18:08:43 +00:00
Gijs Kruitbosch
ef7146a4be Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D4466

--HG--
extra : rebase_source : e51b66bb18d0e600814b48d5cd3ec9d5dea3028a
extra : source : 96b5a88ac0041a1bd382a731749e1fca9aa911ed
2018-09-03 14:43:38 +01:00
Dave Townsend
e63bb1c465 Bug 1487246: Enable the eslint no-sequences rule. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D4681

--HG--
extra : rebase_source : ae253571d7d47c4a113a98a8b7c29bf712a0d764
2018-08-29 16:15:33 -07:00
Margareta Eliza Balazs
5ddcd7b745 Backed out changeset 96b5a88ac004 (bug 1486824) for causing frequent failures e.g: browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js a=backout 2018-08-31 12:17:27 +03:00
Gijs Kruitbosch
9d70cb3843 Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D4466

--HG--
extra : moz-landing-system : lando
2018-08-30 15:07:36 +00:00
Narcis Beleuzu
a4ec006bb0 Backed out changeset 4e195f7b2d6b (bug 1486824) for clipboard failures on OSX browser_editcontrols_update. a=backout 2018-08-30 15:59:59 +03:00
Gijs Kruitbosch
a8e2b8e702 Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D4466

--HG--
extra : moz-landing-system : lando
2018-08-29 17:58:25 +00:00
Kris Maglione
3a5c05e76f Bug 1484496: Part 5e - Convert remaining nsISimpleEnumerator users to use JS iteration. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D3733

--HG--
extra : rebase_source : c0fac176d7b3d840c4dbb14f8d95ccfc7f83a5a8
extra : histedit_source : a92c40117d0808a3ad68c972f622a7a42c9ae8ba
2018-08-18 18:13:14 -07:00
Eitan Isaacson
8d5dad89ed Bug 1479591 - Introduced accessibility scrolling event and interface. r=surkov 2018-08-15 13:07:00 -04:00
Cosmin Sabou
c2b1fcd31c Backed out changeset dad95d849302 (bug 1479591) for causing linux debug leaks and security issues. 2018-08-15 04:39:43 +03:00
Eitan Isaacson
0f281891a2 Bug 1479591 - Introduced accessibility scrolling event and interface. r=surkov 2018-08-14 11:46:00 +03:00
Kris Maglione
637cac1ea7 Bug 1481024: Stop relying on lexical variables being available across frame scripts. r=yzen
The accessibility tests currently rely, in many places, on lexical variables
defined in global frame scripts being available to other non-global frame
scripts. While that is currently the case, it will stop being so soon.

And, while the simplest solution would be to define them as properties on the
frame message manager by using `var` rather than `let`, storing references to
the current content window in a frame script scope is unsafe at best, and
should be avoided at all costs.

MozReview-Commit-ID: 4FCGtLgcFzl

--HG--
extra : rebase_source : d21206c9f119ca0ce61f9956f84a2e2d11484bca
2018-08-02 20:19:50 -07:00