Commit Graph

421 Commits

Author SHA1 Message Date
Andrea Marchesini
6aa5b38d30 Bug 1641905 - ThirdPartyUtil::IsThirdPartyWindow for fission, r=dimi,necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D79307
2020-06-17 20:18:23 +00:00
Emilio Cobos Álvarez
abd87a6510 Bug 1646776 - Make sure to fire load rather than error events for preload links that hit the CSS cache. r=mayhemer
When we hit the stylesheet cache for an existing stylesheet in a
different document:

 * There's no existing preload in the PreloadService (because the sheet
   was loaded in another document).

 * We don't create a PreloaderBase (because we don't trigger a load at
   all).

 * And thus we believe the load has just errored, which is wrong...

Fix it by properly passing through the "already complete" status from
PreloadStyle.

Note that there's still another issue, which is that we'd still hit this
broken path if two stylesheets with the same URI are loading in
different documents and the CSS loader coalesces them.

For that, I think we'd have to make SheetLoadData the thing that
actually implements PreloaderBase. This is kind of an obscure case, and
SheetLoadData has a pretty complex lifetime already (keeps alive a whole
lot of stuff), so I'd prefer to do this in a separate bug.

Differential Revision: https://phabricator.services.mozilla.com/D80289
2020-06-22 14:18:19 +00:00
Razvan Maries
d653f63b03 Backed out changeset 1c9058277ddd (bug 1641905) for perma failures on test_ext_cookies_firstParty.js. CLOSED TREE 2020-06-16 22:16:58 +03:00
Andrea Marchesini
f7efe6a94c Bug 1641905 - ThirdPartyUtil::IsThirdPartyWindow for fission, r=dimi,necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D79307
2020-06-16 17:46:41 +00:00
Simon Giesecke
0735ecafd8 Bug 1645382 - Remove unnecessary arguments from NS_OBSERVER_ARRAY_NOTIFY_* macros. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D79485
2020-06-15 09:05:00 +00:00
Nika Layzell
35969e149c Bug 1644797 - Add a WindowContext getter to Document, r=farre
Differential Revision: https://phabricator.services.mozilla.com/D79160
2020-06-11 11:19:14 +00:00
Johann Hofmann
2121e27531 Bug 1515073 - Part 1 - Add nsISHEntry::hasUserInteraction. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D27585
2020-06-09 14:48:38 +00:00
Anny Gakhokidze
b0c4a70ea0 Bug 1631859 - Part 3: Remove ancestor principals and outer windowIDs from Document and nsDocShell, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D78408
2020-06-08 19:58:23 +00:00
Emilio Cobos Álvarez
9635f65354 Bug 1634602 - Minor follow-up cleanups.
Differential Revision: https://phabricator.services.mozilla.com/D78020
2020-06-03 09:44:41 +00:00
Andrea Marchesini
69818a4d17 Bug 1639833 - IntrisincStoragePrincipal should always be partitioned - part 4 - Renaming storage access permission methods, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D76917
2020-06-03 06:12:06 +00:00
Andrea Marchesini
f8f4d7b9c9 Bug 1639833 - IntrisincStoragePrincipal should always be partitioned - part 3 - Cleanup storage access methods, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D76916
2020-06-03 06:10:58 +00:00
Andrea Marchesini
22d905d24e Bug 1639833 - IntrisincStoragePrincipal should always be partitioned - part 2 - Expose PartitionedPrincipal, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D76915
2020-06-03 06:09:52 +00:00
Tom Ritter
fdd6915c4d Bug 1634602 - Exempt about:black from color scheme preference in RFP mode r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D77833
2020-06-02 20:42:31 +00:00
Csoregi Natalia
2d5cafc841 Backed out 5 changesets (bug 1639833) for failures on browser_blockingIndexedDbInWorkers.js. CLOSED TREE
Backed out changeset 6b4f76d65540 (bug 1639833)
Backed out changeset c77acba1aacb (bug 1639833)
Backed out changeset 30c97666919e (bug 1639833)
Backed out changeset d769b313441a (bug 1639833)
Backed out changeset ed41b41d1b03 (bug 1639833)
2020-06-02 15:02:31 +03:00
Andrea Marchesini
6f2eed62c8 Bug 1639833 - IntrisincStoragePrincipal should always be partitioned - part 4 - Renaming storage access permission methods, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D76917
2020-06-02 08:30:24 +00:00
Andrea Marchesini
2e5c69b85f Bug 1639833 - IntrisincStoragePrincipal should always be partitioned - part 3 - Cleanup storage access methods, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D76916
2020-06-02 08:29:15 +00:00
Andrea Marchesini
e31c7313ca Bug 1639833 - IntrisincStoragePrincipal should always be partitioned - part 2 - Expose PartitionedPrincipal, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D76915
2020-06-02 08:28:05 +00:00
Matt Woodrow
7adf95e964 Bug 1620679 - Don't fire load event from within Stop(). r=smaug
This matches what the spec says, and what blink does.

Differential Revision: https://phabricator.services.mozilla.com/D73994
2020-05-30 17:19:54 +00:00
Noemi Erli
f08b043cf6 Backed out 5 changesets (bug 1639833) for causing sessionstorage related failures CLOSED TREE
Backed out changeset b36af8d9db34 (bug 1639833)
Backed out changeset 712c11904dbe (bug 1639833)
Backed out changeset 14f1e4783582 (bug 1639833)
Backed out changeset b7f14c4cfe5d (bug 1639833)
Backed out changeset b4b25034dd83 (bug 1639833)
2020-06-01 19:31:50 +03:00
Andrea Marchesini
a997c1d626 Bug 1639833 - IntrisincStoragePrincipal should always be partitioned - part 4 - Renaming storage access permission methods, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D76917
2020-06-01 11:59:46 +00:00
Andrea Marchesini
6172ec2b3e Bug 1639833 - IntrisincStoragePrincipal should always be partitioned - part 3 - Cleanup storage access methods, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D76916
2020-06-01 11:07:36 +00:00
Andrea Marchesini
8c0df411d1 Bug 1639833 - IntrisincStoragePrincipal should always be partitioned - part 2 - Expose PartitionedPrincipal, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D76915
2020-06-01 11:57:46 +00:00
sefeng
727ca5589e Bug 1322947 - Add support of cancel dialog modal with escape key r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D74937
2020-05-27 14:37:19 +00:00
Matt Woodrow
e060a86c42 Bug 1631405 - Move nsISecureBrowserUI to be owned by the canonical browsing context instead of docshell. r=nika,ckerschb,Gijs,webcompat-reviewers,twisniewski
This removes all docshell nsISecureBrowserUI and mixed content properties, and moves them into CanonicalBrowsingContext/WindowGlobalParent. It makes the mixed content blocker just compute the state for the current load, and then send the results to the parent process, where we update the security state accordingly.

I think we could in the future remove onSecurityChange entirely, and instead just fire an event to the <browser> element notifying it of changes to the queryable securityUI.

Unfortunately we have a lot of existing code that depends on specific ordering between onSecurityChange and onLocationChange, so I had to hook into the RemoteWebProgress implementation in BrowserParent to mimic the same timings.

Differential Revision: https://phabricator.services.mozilla.com/D75447
2020-05-27 00:28:59 +00:00
Bogdan Tara
a54ec3073f Backed out 4 changesets (bug 1631405) for multiple mochitest failures CLOSED TREE
Backed out changeset 9963cc0b23cb (bug 1631405)
Backed out changeset 469ac933ed7c (bug 1631405)
Backed out changeset 0c5f55864268 (bug 1631405)
Backed out changeset 20dcbcc2f3b8 (bug 1631405)
2020-05-27 01:30:20 +03:00
Matt Woodrow
240d417eb6 Bug 1631405 - Move nsISecureBrowserUI to be owned by the canonical browsing context instead of docshell. r=nika,ckerschb,Gijs,webcompat-reviewers,twisniewski
This removes all docshell nsISecureBrowserUI and mixed content properties, and moves them into CanonicalBrowsingContext/WindowGlobalParent. It makes the mixed content blocker just compute the state for the current load, and then send the results to the parent process, where we update the security state accordingly.

I think we could in the future remove onSecurityChange entirely, and instead just fire an event to the <browser> element notifying it of changes to the queryable securityUI.

Unfortunately we have a lot of existing code that depends on specific ordering between onSecurityChange and onLocationChange, so I had to hook into the RemoteWebProgress implementation in BrowserParent to mimic the same timings.

Differential Revision: https://phabricator.services.mozilla.com/D75447
2020-05-26 21:17:01 +00:00
JulianWels
2cc2e49495 Bug 1625156 - Error page for HTTPS Only Mode. r=fluent-reviewers,ckerschb,nhnt11,flod,nika,johannh,mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D72129
2020-05-26 11:45:21 +00:00
Butkovits Atila
1d2238af48 Backed out 2 changesets (bug 1620679) for perma Reftest failure. CLOSED TREE
Backed out changeset 8190c67514cc (bug 1620679)
Backed out changeset 4ca2912d7421 (bug 1620679)
2020-05-26 10:58:42 +03:00
Matt Woodrow
d347ab0ef5 Bug 1620679 - Don't fire load event from within Stop(). r=smaug
This matches what the spec says, and what blink does.

Differential Revision: https://phabricator.services.mozilla.com/D73994
2020-05-26 03:08:40 +00:00
sefeng
f2affadce6 Bug 1324958 - Implement <dialog> focusing steps r=smaug
Spec: https://html.spec.whatwg.org/multipage/interactive-elements.html#dialog-focusing-steps

Differential Revision: https://phabricator.services.mozilla.com/D74923
2020-05-25 14:57:25 +00:00
Coroiu Cristina
a9c2a2b735 Backed out changeset bb7c330d407f (bug 1637307) for wpt failures at layout/generic/ViewportFrame.cpp on s CLOSED TREE 2020-05-20 00:01:55 +03:00
sefeng
ca6d5ba134 Bug 1637307 - Push/Pop dialog to top layer when needed r=smaug
This patch completes the top layer requirement for showModal()
Spec: https://html.spec.whatwg.org/multipage/interactive-elements.html#dom-dialog-showmodal

Differential Revision: https://phabricator.services.mozilla.com/D74922
2020-05-19 15:40:08 +00:00
Zibi Braniecki
749612612f Bug 1629291 - Don't set l10n as cached if there was any error during initial translation. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D74818
2020-05-14 16:56:57 +00:00
Matt Woodrow
98b902004c Bug 1637487 - Store mixed content security flags as a flags word on Document instead of bools. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D75026
2020-05-14 01:27:42 +00:00
Narcis Beleuzu
53167b2819 Backed out 9 changesets (bug 1637487) for bustages on nsMixedContentBlocker.cpp . CLOSED TREE
Backed out changeset 5633cc2aaa9b (bug 1637487)
Backed out changeset c4f0c757cae0 (bug 1637487)
Backed out changeset 65bb1114df87 (bug 1637487)
Backed out changeset 1a64ef10e773 (bug 1637487)
Backed out changeset d1709ebb7f46 (bug 1637487)
Backed out changeset 286e5ee6517f (bug 1637487)
Backed out changeset 83362625c297 (bug 1637487)
Backed out changeset ab9df2f2d11f (bug 1637487)
Backed out changeset b83f49bc11b0 (bug 1637487)
2020-05-14 02:41:40 +03:00
Matt Woodrow
4f25f45f1f Bug 1637487 - Store mixed content security flags as a flags word on Document instead of bools. r=ckerschb
Depends on D75025

Differential Revision: https://phabricator.services.mozilla.com/D75026
2020-05-13 17:50:34 +00:00
Csoregi Natalia
9f074fab9b Backed out changeset 4309266ff43d (bug 1629291) for frequent assertion failures on ErrorResult.h. CLOSED TREE 2020-05-13 10:23:18 +03:00
Zibi Braniecki
fabff274c8 Bug 1629291 - Don't set l10n as cached if there was any error during initial translation. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D74818
2020-05-12 23:22:03 +00:00
Valentin Gosu
db062a7e3b Bug 1572513 - Set the embedder policy when intializing the Document object r=nika
This patch persists the CrossOriginEmbedderPolicy on the Document and
WindowContext.
The WindowContext's embedder policy is set in
WindowGlobalActor::BaseInitializer by either adopting the policy of the HTTP
channel that loaded the document, or in WindowGlobalChild::OnNewDocument
by inheriting the one from the browsingContext's windowContext.

Differential Revision: https://phabricator.services.mozilla.com/D46903
2020-05-11 18:41:16 +00:00
Edgar Chen
3f250fba44 Bug 1618295 - Make imgRequestProxy implement and use PreloaderBase to support the preload as speculative load feature; r=tnikkel,smaug,mayhemer
Depends on D72083

Differential Revision: https://phabricator.services.mozilla.com/D69860
2020-05-11 14:43:05 +00:00
Honza Bambas
0f372316ea Bug 1618289 - Have PreloadService hanging off dom::Document, r=smaug
Depends on D67479

Differential Revision: https://phabricator.services.mozilla.com/D67480
2020-05-11 14:04:36 +00:00
Andrea Marchesini
871dd4ea6a Bug 1632187 - Introduce nsICookieService::setCookieStringFromDocument - part 2 - implementation, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D71974
2020-05-09 20:26:13 +00:00
Coroiu Cristina
b2935aef35 Backed out 5 changesets (bug 1632187) for xpcshell failures at netwerk/test/unit/test_proxyconnect.js
Backed out changeset c0e6dad41b74 (bug 1632187)
Backed out changeset 328ee0899987 (bug 1632187)
Backed out changeset cb775f75ff1f (bug 1632187)
Backed out changeset de6907618ac9 (bug 1632187)
Backed out changeset 1070e843071c (bug 1632187)
2020-05-09 23:22:06 +03:00
Andrea Marchesini
5dbb73b13c Bug 1632187 - Introduce nsICookieService::setCookieStringFromDocument - part 2 - implementation, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D71974
2020-05-09 19:02:44 +00:00
Tetsuharu Ohzeki
5f73b12af7 Bug 1585078 - part 1: Divide Document::RequestFullScreen() into seperate path to clarify the case in content process. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D71961
2020-05-02 12:01:44 +00:00
Zibi Braniecki
4084d5c48b Bug 1627809 - Move DocumentL10n construction earlier. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D70976
2020-04-30 17:56:41 +00:00
Zibi Braniecki
9a24b61c50 Bug 1627809 - Rename Document::TriggerInitialTranslation to Document::OnParsingCompleted. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D70974
2020-04-30 17:56:11 +00:00
Zibi Braniecki
30bcee56da Bug 1627809 - Rename *DocumentTranslation to *Translation. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D70971
2020-04-30 17:55:26 +00:00
Liang-Heng Chen
9d2d8bbeb9 Bug 1629707 - add IntrinsicStoragePrincipal to nsIScriptObjectPrincipal; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D73132
2020-04-30 05:24:10 +00:00
Dimi Lee
8d06cbe7df Bug 1612376 - P4. ShouldAllowAccessFor use ContentBlocking::HasStorageAccessGranted r=timhuang,baku
There are two places where we save storage permission:
1. LoadInfo hasStoragePermission attribute
2. mStorageAccessGranted in nsPIDOMWindowInner

For LoadInfo.hasStoragePermission, it is set during channel creation and
its value remains the same even when the storage permission is granted
afterward.

The updated storage permission for a window is saved in
mStorageAccessGranted, which has a different meaning for fission and
non-fission mode.
In non-fission mode, mStorageAccessGranted is saved in the top-level
window and it is an array containing all tracking subframes that
are allowed to access storage.

In fission mode, mStorageAccessGranted is set in individual tracking
windows that we have granted its storage permission. Although it works
like a boolean flag in fission, we still keep using an array to compatible
with the use case in non-fission mode.

Depends on D71984

Differential Revision: https://phabricator.services.mozilla.com/D71985
2020-04-29 14:48:35 +00:00