Commit Graph

7748 Commits

Author SHA1 Message Date
Valentin Gosu
0cf5f5e5ac Bug 1659132 - Make AddrInfo immutable r=dragana,necko-reviewers
Also adds constructors for NetAddr to avoid it being uninitialized.

Differential Revision: https://phabricator.services.mozilla.com/D87091
2020-09-01 07:22:14 +00:00
Byron Campen [:bwc]
0f69b6ebc5 Bug 1657394: When generating an answer, if the bundle transport is disabled, try to fall back to a suitable alternative when one is available. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D87956
2020-08-24 21:53:13 +00:00
Byron Campen [:bwc]
2f24591f91 Bug 1657394: Test for cases where we have a fallback bundle transport. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D87955
2020-08-24 22:01:23 +00:00
Byron Campen [:bwc]
b3d5a69b29 Bug 1657394: Make sure transports are set up in have-local-offer. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D86223
2020-08-24 21:37:18 +00:00
Byron Campen [:bwc]
54007f3897 Bug 1657394: Test-case for bug. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D86222
2020-08-22 17:50:05 +00:00
Nico Grunbaum
84b4e72464 Bug 1647537 - fix crash when re-enabling AEC logging;r=jib
Differential Revision: https://phabricator.services.mozilla.com/D88236
2020-08-26 18:17:13 +00:00
Jon Bauman
342f755dce Bug 1657200 - Update libdav1d to d0e50cac for Firefox 81. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D88182
2020-08-26 17:42:07 +00:00
Butkovits Atila
cdf1ae5211 Backed out 2 changesets (bug 1659132) for failures at browser_cleanFlow.js. CLOSED TREE
Backed out changeset 7952fd59f59b (bug 1659132)
Backed out changeset fa8ce4af10a0 (bug 1659132)
2020-08-25 13:02:33 +03:00
Valentin Gosu
b4b3279a00 Bug 1659132 - Make AddrInfo immutable r=dragana,necko-reviewers
Also adds constructors for NetAddr to avoid it being uninitialized.

Differential Revision: https://phabricator.services.mozilla.com/D87091
2020-08-25 08:02:22 +00:00
Butkovits Atila
73a14f1b36 Backed out 2 changesets (bug 1659132) for build bustage. CLOSED TREE
Backed out changeset 1caace74f89e (bug 1659132)
Backed out changeset 58fdbfbe05a1 (bug 1659132)
2020-08-25 09:43:01 +03:00
Valentin Gosu
ec0be3efef Bug 1659132 - Make AddrInfo immutable r=dragana,necko-reviewers
Also adds constructors for NetAddr to avoid it being uninitialized.

Differential Revision: https://phabricator.services.mozilla.com/D87091
2020-08-24 12:23:06 +00:00
Nico Grunbaum
04fb5eebc1 Bug 1660408 - enable rtcp-rsize in default offer;r=bwc
This adds rtcp-rsize to the default offer for video, a pref is included in case it needs to be turned off.

Differential Revision: https://phabricator.services.mozilla.com/D87835
2020-08-24 19:53:08 +00:00
John Lin
b7c5501eda Bug 1657321 - ffvpx: undo build error workarounds. r=jya
Revert bug 1412240. It was a workaround for a LLVM bug and only
relevant when icecc is involved. Since sccache-dist is preferred
now, it's no longer needed.

Differential Revision: https://phabricator.services.mozilla.com/D87891
2020-08-22 02:41:58 +00:00
Andreas Pehrson
71c232e8df Bug 1652884 - Make MediaPipelineTransmit listen for track enabled state changes from the graph. r=jib
Previously it listened for them on main thread, as notified by the
MediaStreamTrack it was transmitting directly. With this patch it
listens for them through the TrackListener in the graph, and will
get notified when any track prior to the MediaStreamTrack's main
track in the graph changes enabled state as well.

Depends on D86926.

Differential Revision: https://phabricator.services.mozilla.com/D86931
2020-08-19 22:18:37 +00:00
Bogdan Tara
30eb420e4a Backed out 14 changesets (bug 1652884) for test_peerConnection_trackDisabling.html failures CLOSED TREE
Backed out changeset f83951453e94 (bug 1652884)
Backed out changeset fc697986d538 (bug 1652884)
Backed out changeset 20a10128b5e1 (bug 1652884)
Backed out changeset c99c32323c76 (bug 1652884)
Backed out changeset 991e8975f03d (bug 1652884)
Backed out changeset 9e9511e32cdd (bug 1652884)
Backed out changeset 605c1ac3081a (bug 1652884)
Backed out changeset dd6edf636659 (bug 1652884)
Backed out changeset 74a2f5a9eea2 (bug 1652884)
Backed out changeset b9f419aed12d (bug 1652884)
Backed out changeset 84e82e25929f (bug 1652884)
Backed out changeset 876dbad27af5 (bug 1652884)
Backed out changeset 8f60e3af2a19 (bug 1652884)
Backed out changeset de7537bda499 (bug 1652884)
2020-08-20 01:13:29 +03:00
Andreas Pehrson
1fcd058234 Bug 1652884 - Make MediaPipelineTransmit listen for track enabled state changes from the graph. r=jib
Previously it listened for them on main thread, as notified by the
MediaStreamTrack it was transmitting directly. With this patch it
listens for them through the TrackListener in the graph, and will
get notified when any track prior to the MediaStreamTrack's main
track in the graph changes enabled state as well.

Depends on D86926.

Differential Revision: https://phabricator.services.mozilla.com/D86931
2020-08-19 19:30:56 +00:00
Bogdan Tara
fd6c09249f Backed out 14 changesets (bug 1652884) for VideoFrameConverter related failures CLOSED TREE
Backed out changeset 28c4e8c373f0 (bug 1652884)
Backed out changeset 658ba8f39abe (bug 1652884)
Backed out changeset 8e67fe040e4a (bug 1652884)
Backed out changeset 6f5833203763 (bug 1652884)
Backed out changeset 569ff85dfc2e (bug 1652884)
Backed out changeset eaa171643447 (bug 1652884)
Backed out changeset 6b37b60b6662 (bug 1652884)
Backed out changeset 438cce7456fb (bug 1652884)
Backed out changeset e6ed13952b67 (bug 1652884)
Backed out changeset e0b1266231bf (bug 1652884)
Backed out changeset 32f4aae2b5fe (bug 1652884)
Backed out changeset 76b4abccd61b (bug 1652884)
Backed out changeset 9010365ffa66 (bug 1652884)
Backed out changeset 763f39eb5c13 (bug 1652884)
2020-08-19 22:21:31 +03:00
Andreas Pehrson
262d04f090 Bug 1652884 - Make MediaPipelineTransmit listen for track enabled state changes from the graph. r=jib
Previously it listened for them on main thread, as notified by the
MediaStreamTrack it was transmitting directly. With this patch it
listens for them through the TrackListener in the graph, and will
get notified when any track prior to the MediaStreamTrack's main
track in the graph changes enabled state as well.

Depends on D86926.

Differential Revision: https://phabricator.services.mozilla.com/D86931
2020-08-19 02:40:10 +00:00
Jean-Yves Avenard
5be22726b0 Bug 1650696 - P4. Remove the expectation for a MediaDataDecoder to work on a specified TaskQueue. r=jolin
It will now be up to the caller to determine where the decoder is going to run. This allows to simplify the audio decoders so that they can run synchronously and be wrapped in a Wasm sandbox (which doesn't support multi-threading)

The structure guarantees that all MediaDataDecoder methods are called on the same thread it's been initialised.

To achieve this, wherever a MediaDataDecoder was created, we wrap it in a MediaDataDecoderProxy that ensures that all methods are running on the given thread.

We keep the behaviour of all methods in all MediaDataDecoder to assert that they are running on the expected thread for diagnostic purposes. It could go in the future.

Video decoders that could block excessingly the thread on which they are called are made to run on their own task queue.
The Apple decoder is mostly entirely asynchronous, with the exception of the drain method which could block.
We exclude the android and omx decoders are the framework they use is 100% asynchronous and already operate on another thread.

Differential Revision: https://phabricator.services.mozilla.com/D86929
2020-08-17 23:52:21 +00:00
Mike Hommey
a4a5d4e822 Bug 1658397 - Add gn configs for arm64 macOS for webrtc. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D86893
2020-08-13 13:20:04 +00:00
Mike Hommey
d736c1381f Bug 1658853 - Make GnMozbuildWriter output more deterministic. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D86887
2020-08-13 13:20:04 +00:00
Dan Minor
a6e858b6ff Bug 1657449 - Add "Show tab" button to about:webrtc; r=ng
This adds the current browserId to the internal stats report. The peer
connections are sorted by browserId, and a "Show tab" button is added that will
select the tab associated with the peer connection to make it easier to keep
track of which peerconnection is associated with a tab.

Differential Revision: https://phabricator.services.mozilla.com/D86699
2020-08-12 18:48:21 +00:00
Valentin Gosu
06b00d0bf4 Bug 1657582 - Add nsIDNSAddrRecord interface r=necko-reviewers,geckoview-reviewers,snorp,mixedpuppy,dragana
This interface extends nsIDNSRecord and makes the DNS code more extensible
by allowing us to support more record types.
This change does require the consumer to be aware of the type they requested
and to QueryInterface to either nsIDNSAddrRecord for regular IP lookups,
or to nsIDNSByTypeRecord for other kinds of lookups.

Differential Revision: https://phabricator.services.mozilla.com/D86177
2020-08-12 10:49:39 +00:00
Valentin Gosu
e1f98ce23a Bug 1657582 - Add nsIDNSResolverInfo interface r=necko-reviewers,geckoview-reviewers,snorp,mixedpuppy,extension-reviewers,dragana
This patch adds the nsIDNSResolverInfo interface which is used to hold
information about the resolver to be used in a DNS resolution.

We use this to merge all of the *WithTRRServer resolve functions into one.
Passing a resolver info will use that object when appropriate. No resolver
info means that we default to using the system resolver, or the default TRR
resolver.

This patch also converts the RESOLVE_TYPE_* flags into a cenum and adds
the resolveType as a parameter to asyncResolve thus removing the need
to have asyncResolveByType methods.

Differential Revision: https://phabricator.services.mozilla.com/D86176
2020-08-12 08:25:14 +00:00
Bogdan Tara
694b77183c Backed out 2 changesets (bug 1657582) for test_DNSLookup.js failures CLOSED TREE
Backed out changeset 784122a5f5ab (bug 1657582)
Backed out changeset 0f17312b01ad (bug 1657582)
2020-08-12 11:18:06 +03:00
Valentin Gosu
5eeaf52395 Bug 1657582 - Add nsIDNSAddrRecord interface r=necko-reviewers,geckoview-reviewers,snorp,mixedpuppy,dragana
This interface extends nsIDNSRecord and makes the DNS code more extensible
by allowing us to support more record types.
This change does require the consumer to be aware of the type they requested
and to QueryInterface to either nsIDNSAddrRecord for regular IP lookups,
or to nsIDNSByTypeRecord for other kinds of lookups.

Differential Revision: https://phabricator.services.mozilla.com/D86177
2020-08-12 01:35:10 +00:00
Valentin Gosu
fc1bf09e47 Bug 1657582 - Add nsIDNSResolverInfo interface r=necko-reviewers,geckoview-reviewers,snorp,mixedpuppy,extension-reviewers,dragana
This patch adds the nsIDNSResolverInfo interface which is used to hold
information about the resolver to be used in a DNS resolution.

We use this to merge all of the *WithTRRServer resolve functions into one.
Passing a resolver info will use that object when appropriate. No resolver
info means that we default to using the system resolver, or the default TRR
resolver.

This patch also converts the RESOLVE_TYPE_* flags into a cenum and adds
the resolveType as a parameter to asyncResolve thus removing the need
to have asyncResolveByType methods.

Differential Revision: https://phabricator.services.mozilla.com/D86176
2020-08-12 01:00:39 +00:00
Michael Froman
ee75b5312f Bug 1303867 - teardown Transports before NrIceCtx to allow close_notify alerts. r=bwc
If the NrIceCtx is torn down first there is not a valid media stream on which
to send the close_notify alert.

Differential Revision: https://phabricator.services.mozilla.com/D85657
2020-08-10 18:31:46 +00:00
Simon Giesecke
1e02318b49 Bug 1653335 - Replace MakeSpan uses by constructor calls. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D83817
2020-08-07 07:49:47 +00:00
Mike Hommey
de6265f978 Bug 1656141 - Remove dav1d.rc. r=achronop
RCFILE is only actually used when the moz.build that contains it defines
a binary, which is not the case for dav1d, which ends up in gkmedias.dll.
Which also means that moving the definition to gkmedias would also not
make sense, since all dav1d.rc does is add descriptors to the dll that it
contains dav1d and what version, but gkmedias.dll contains other things
too.

Differential Revision: https://phabricator.services.mozilla.com/D86152
2020-08-06 22:52:04 +00:00
Mihai Alexandru Michis
c4e805857f Backed out 9 changesets (bug 1656141) for causing multiple failures.
CLOSED TREE

Backed out changeset 9033b0400339 (bug 1656141)
Backed out changeset e43dd57dc61a (bug 1656141)
Backed out changeset eb450457a9b7 (bug 1656141)
Backed out changeset 194a994cf9c9 (bug 1656141)
Backed out changeset ce6831acb5e3 (bug 1656141)
Backed out changeset 29653ea85d49 (bug 1656141)
Backed out changeset 704f28486bda (bug 1656141)
Backed out changeset de8899453150 (bug 1656141)
Backed out changeset 4b133eda46aa (bug 1656141)
2020-08-07 01:48:45 +03:00
Mike Hommey
3c6fc9c9e1 Bug 1656141 - Remove dav1d.rc. r=achronop
RCFILE is only actually used when the moz.build that contains it defines
a binary, which is not the case for dav1d, which ends up in gkmedias.dll.
Which also means that moving the definition to gkmedias would also not
make sense, since all dav1d.rc does is add descriptors to the dll that it
contains dav1d and what version, but gkmedias.dll contains other things
too.

Differential Revision: https://phabricator.services.mozilla.com/D86152
2020-08-06 20:51:37 +00:00
Jan-Ivar Bruaroey
4a8b5ea5a8 Bug 1654248 - Fix missing telemetry reporting of WEBRTC_CALL_DURATION, and stop counting renegotiations in WEBRTC_CALL_COUNT_2. r=bwc
Differential Revision: https://phabricator.services.mozilla.com/D85042
2020-08-05 23:47:46 +00:00
Kershaw Chang
158c55ad89 Bug 1497249 - P2: ipdl for nsIWebSocketConnection r=michal
Differential Revision: https://phabricator.services.mozilla.com/D30624
2020-08-05 15:17:38 +00:00
Jon Bauman
93851d81e6 Bug 1652202 - Update libdav1d to 6cf58c8e for Firefox 80. r=dminor
See 6cf58c8e7d

Differential Revision: https://phabricator.services.mozilla.com/D85910
2020-08-05 15:11:26 +00:00
Dan Minor
b9cc2eb001 Bug 1653720 - Do not generate kFid ssrc-group if no msid is present; r=bwc
Chrome's SDP parser has problems with an ssrc-group being present if the media
section is inactive and does not have an msid.

Differential Revision: https://phabricator.services.mozilla.com/D85320
2020-08-04 14:45:12 +00:00
Simon Giesecke
96f3e7e019 Bug 1654992 - Use std::move instead of SwapElements where possible. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D84807
2020-08-04 11:27:07 +00:00
Noemi Erli
381fca9783 Backed out 4 changesets (bug 1654992, bug 1654991) for causing timeous in mask-opacity-1e.html
Backed out changeset 11f0f54c6e0a (bug 1654992)
Backed out changeset a353dd5b3f08 (bug 1654991)
Backed out changeset 6a7964ba549f (bug 1654991)
Backed out changeset cf3bfb91d98c (bug 1654991)
2020-08-03 22:09:36 +03:00
Byron Campen [:bwc]
ce79d0e256 Bug 1656065: Init r_log_env_verbose only once. r=mjf
Depends on D85295

Differential Revision: https://phabricator.services.mozilla.com/D85427
2020-07-30 17:22:40 +00:00
Byron Campen [:bwc]
4bfd2d2966 Bug 1653626: Lock here to prevent races. r=dminor
Differential Revision: https://phabricator.services.mozilla.com/D85295
2020-08-03 15:23:35 +00:00
Simon Giesecke
032d2ac9d3 Bug 1654992 - Use std::move instead of SwapElements where possible. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D84807
2020-08-03 14:54:18 +00:00
Sylvestre Ledru
843f943758 Bug 1519636 - Reformat recent changes to the Google coding style r=andi
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D85678
2020-08-02 15:29:15 +00:00
Andreea Pavel
7b5d8cd64c Backed out 1 changesets (bug 1654248) for failures at PeerConnectionImpl.cpp on a CLOSED TREE
Backed out changeset e51e334b08cd (bug 1654248)
2020-08-01 02:08:08 +03:00
Jan-Ivar Bruaroey
6507521605 Bug 1654248 - Fix missing telemetry reporting of WEBRTC_CALL_DURATION, and stop counting renegotiations in WEBRTC_CALL_COUNT_2. r=bwc
Differential Revision: https://phabricator.services.mozilla.com/D85042
2020-07-31 20:33:08 +00:00
Byron Campen [:bwc]
cc4ea1f325 Bug 1651601: Ignore remote trickle candidates for obsolete streams. r=mjf
Depends on D83545

Differential Revision: https://phabricator.services.mozilla.com/D85284
2020-07-31 15:48:18 +00:00
Nico Grunbaum
c116dd0bdb Bug 1655137 - add rtcp-rsize parsing to SIPCC parser;r=dminor
Differential Revision: https://phabricator.services.mozilla.com/D84857
2020-07-29 01:30:34 +00:00
Byron Campen [:bwc]
7f56bb6ec2 Bug 1651601: Only do the minimum processing for STUN messages on an obsolete stream. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D83545
2020-07-24 17:01:49 +00:00
Thomas Daede
28df0d954d Bug 1463915 - Update libvorbis to 1.3.7. r=jya
Differential Revision: https://phabricator.services.mozilla.com/D84565
2020-07-24 00:25:08 +00:00
Michael Froman
9a6d6691a0 Bug 1654611 - remove unnecessary mWindow in RTCDTMFSender. r=smaug
Found during a review of RTCDtlsTransport, mWindow is not needed here
because RTCDTMFSender inherits from DOMEventTargetHelper.

Differential Revision: https://phabricator.services.mozilla.com/D84571
2020-07-22 19:06:08 +00:00
Byron Campen [:bwc]
a54994480c Bug 1652426: Fix bug where ontrack was fired for all receivers if a previously processed receiver had a new track. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D84207
2020-07-22 13:17:02 +00:00