Commit Graph

2638 Commits

Author SHA1 Message Date
nelson%bolyard.com
7d6b311cd3 Don't call nssCKFWToken_Destroy with NULL. Bug 340018. r=alexei.volkov 2006-06-10 22:21:10 +00:00
nelson%bolyard.com
4f4902f94e Fix leak and OOM crash. Bug 338352 and 338356. Coverity.
r=rrelyea, alexei.volkov
2006-06-10 22:13:46 +00:00
kaie%kuix.de
969191a00e Bug 340183, Add the Netlock Class QA root certificate
Approval for adding CA cert granted by Frank Hecker in bug 313942
Patch by Wan-Teh Chang, r=me
2006-06-09 21:02:16 +00:00
nelson%bolyard.com
bae0b415d1 Fix leaks in CERT_DistNamesFromNicknames (bug 339916) and in
CERT_GetCertNicknames (bug 339919). Coverity bugs. r=alexei.volkov
2006-06-09 01:24:39 +00:00
nelson%bolyard.com
5498c37db3 Fix leak in NSS_CMSEncoder_Start error path. Bug 339914. r=alexei.volkov 2006-06-08 22:01:02 +00:00
nelson%bolyard.com
4c913b0390 Fix leak in sec_asn1d_add_to_subitems. Bug 339913. r=alexei.volkov 2006-06-08 21:40:31 +00:00
nelson%bolyard.com
5b368c8808 Remove dead code. Coverity 506. r=nelson,wtchang. Bug 337027.
Patch by Jon Smirl <jonsmirl@yahoo.com>
2006-06-07 18:36:26 +00:00
nelson%bolyard.com
995213d2df Fix bug 337104 and bug 337105. Don't crash if we run out of memory
in ssl2_ConstructCipherSpecs().  r=Alexei.Volkov  Coverity 442 & 443.
2006-06-07 17:53:19 +00:00
julien.pierre.bugs%sun.com
172c1bdf45 Fix for bug 326637 . Unnecessary request of PKCS11 device password. r=rrelyea 2006-06-07 02:30:27 +00:00
alexei.volkov.bugs%sun.com
e70d27d7ba [Bug 339908] 3 NULL ptr crashes when PK11_GetBestSlot returns NULL. r=nelson 2006-06-02 20:34:04 +00:00
wtchang%redhat.com
cdd64c7beb Bugzilla bug 338599: added new function SECKEY_SignatureLen and use it
instead of SECKEY_PublicKeyStrength to get ECDSA signature lengths.
Removed the 'type' member from the VFYContextStr structure because that
info is in the 'key->keyType' field.  Set error codes when functions
fail (return 0). r=nelsonb.
Modified Files:
	cryptohi/keyhi.h cryptohi/seckey.c cryptohi/secvfy.c
	nss/nss.def ssl/ssl3con.c
2006-05-31 23:54:52 +00:00
wtchang%redhat.com
a07f869b7a Bugzilla Bug 338552: added StartCom CA certificate to NSS. The patch is
contributed by  Eddy Nigg, StartCom Ltd. <eddy_nigg@startcom.org>. r=wtc.
a=hecker.
Modified Files: certdata.c certdata.txt nssckbi.h
2006-05-31 17:18:54 +00:00
julien.pierre.bugs%sun.com
ba7825ee28 Fix for bug 336477 . Fix for CERT_UncacheCRL error checking. r=nelson 2006-05-31 01:57:55 +00:00
alexei.volkov.bugs%sun.com
47817668ff [Bug 337014] OOM crash [@ PORT_ArenaAlloc - PK11_PQG_ParamGenSeedLen][@ PORT_ArenaAlloc - PK11_PQG_ParamGenSeedLen] Dereferencing possibly NULL "varena". r=nelson 2006-05-22 23:08:04 +00:00
alexei.volkov.bugs%sun.com
3aa52be061 [Bug 337495] Double free in CRMF_CertReqMsgSetSignaturePOP (security/nss/lib/crmf/crmfpop.c) [Attachment 222949]. r=nelson 2006-05-22 22:38:56 +00:00
wtchang%redhat.com
3533f0c590 Bugzilla Bug 320336: improved the comments for SECITEM_AllocItem in
secitem.h.  Made SECITEM_AllocItem fail (return NULL) if the allocation of
the buffer fails, as documented. r=nelsonb.
Modified files: secitem.c secitem.h
2006-05-22 22:24:34 +00:00
wtchang%redhat.com
68708d13f4 Bugzilla Bug 298520: moved the RSA maximum size macros from rsa.c to
blapit.h.  Removed an out-of-date comment from blapit.h. r=nelsonb.
Modified files: blapit.h rsa.c
2006-05-22 22:10:40 +00:00
wtchang%redhat.com
06496e21ff Bugzilla Bug 298520: added a comment explain the meaning of the MAX_KEY_LEN
macro. r=nelsonb.
2006-05-22 22:08:40 +00:00
alexei.volkov.bugs%sun.com
7cd142bd9c [Bug 337495] Double free in CRMF_CertReqMsgSetSignaturePOP (security/nss/lib/crmf/crmfpop.c). r=nelson 2006-05-22 21:46:14 +00:00
nelson%bolyard.com
43d0a92ac7 Promote the use of curve secp192r1 for client auth, since it is faster
than most.  Bug 332350.  r=rrelyea.
2006-05-19 03:59:06 +00:00
nelson%bolyard.com
505671ed77 Eliminate a crash and plug a leak in the error path for function
nssSMIMEProfile_Create. Coverity bug 337101. r=alexei.volkov.
2006-05-18 23:29:19 +00:00
nelson%bolyard.com
1eb10c802e Avoid crash if "item" pointer is NULL. Coverity bug 333555.
r=wtchang,alexei.volkov
2006-05-18 21:20:04 +00:00
alexei.volkov.bugs%sun.com
e05b17bc20 [Bug 337008] OOM crash [@ nssList_Add - STAN_InitTokenForSlotInfo - STAN_LoadDefaultNSS3TrustDomain][@ nssList_Clone - nssList_CreateIterator - STAN_LoadDefaultNSS3TrustDomain] Dereferencing possibly NULL "(td)->tokenList". r=nelson, sr=wtc 2006-05-18 21:00:58 +00:00
alexei.volkov.bugs%sun.com
b0a8ac4918 [Bug 337010] OOM crash [@ NSC_DigestKey] Dereferencing possibly NULL "att". r=ne
lson,wtc
2006-05-18 20:52:50 +00:00
nelson%bolyard.com
08e023d910 Plug leak. Free cache. Coverity bug 338201. r=alexei.volkov 2006-05-18 20:46:19 +00:00
nelson%bolyard.com
5c56ef5776 Fix several Coverity bugs. Bug 336982. NULL ptr check after ptr deref'ed.
Bug 337080.  Dead code.  r=alexei.volkov
2006-05-18 20:39:19 +00:00
nelson%bolyard.com
88c4f3a0b3 Remove dead old FORTEZZA KEA code. Coverity bug 337098. r=rrelyea,wtchang 2006-05-18 20:24:23 +00:00
alexei.volkov.bugs%sun.com
538630b067 [Bug 337154] Coverity 321, dead code in mozilla/security/nss/lib/pk11wrap/pk11cert.c. (second patch) r=nelson 2006-05-18 20:21:12 +00:00
nelson%bolyard.com
a1423c99e4 Don't dereference a NULL secmodprefix argument. Coverity Bug 336981.
r=alexei.volkov
2006-05-18 19:44:24 +00:00
nelson%bolyard.com
780c599d61 In SEC_PKCS12DecoderGetCerts, don't dereference p12dcx until AFTER it has
been checked for NULL. Coverity bug 336971. r=alexei.volkov
2006-05-18 19:38:59 +00:00
nelson%bolyard.com
0a6525e406 Add 3 assertions to satisfy coverity that tmpt is never NULL in these
places.  Bug 336995. r=akexei.volkov,wtchang
2006-05-18 19:32:44 +00:00
nelson%bolyard.com
68f51af5fe Plug leak. Free "info" in error path. Coverity bug 336475.
r=wtchang,alexei.volkov
2006-05-18 04:35:32 +00:00
nelson%bolyard.com
9dc19d4fe0 Correct the amount returned by ssl_Writev for short writes on non-blocking
sockets.  Bug 338325. patch by Chris Newman <chris.newman@sun.com>
r=nelson
2006-05-18 01:10:21 +00:00
wtchang%redhat.com
5e3f18a4c6 Bugzilla bug 338367: check that the array index params->name is within
bounds before taking an element from the ecCurve_map array.
r=doublas.stebila.
2006-05-17 23:58:18 +00:00
julien.pierre.bugs%sun.com
6f65f3a2dd Fix for bug 222300. r=nelson,wtchang 2006-05-17 22:20:08 +00:00
alexei.volkov.bugs%sun.com
e58e3e05ba [Bug 337011] OOM crash [@ sftk_handleKeyObject][@ sftk_handleKeyParameterObject] Dereferencing possibly NULL "attribute". r=nelson 2006-05-17 20:52:16 +00:00
alexei.volkov.bugs%sun.com
5713a8afaf [Bug 337326] Leak in nsslowcert_UpdateSubjectEmailAddr (security/nss/lib/softoken/pcertdb.c). r=nelson 2006-05-17 20:46:47 +00:00
alexei.volkov.bugs%sun.com
e1b759198c [Bug 337009] OOM crash [@ nssList_Count - nssTrustDomain_GetCertsFromCache] Dereferencing possibly NULL "certList". r=nelson 2006-05-17 20:38:59 +00:00
alexei.volkov.bugs%sun.com
ef6e49c6b2 [Bug 337332] Leak in OpenNewDB (security/nss/lib/softoken/keydb.c). r=nelson 2006-05-17 17:56:32 +00:00
alexei.volkov.bugs%sun.com
4fe8d81c2b [Bug 336485] coverity thinks that nssPKIObject_GetInstances could return null which would lead to a crash [@ listCertsCallback]. r=nelson 2006-05-16 23:47:43 +00:00
wtchang%redhat.com
844f45261e Bugzilla Bug 337025: removed more unused or trivially used variables.
r=alexei.volkov,nelson.bolyard.
2006-05-16 01:57:04 +00:00
wtchang%redhat.com
942eb77419 Bug 305835: Remove NSS_ENABLE_ECC ifdefs in libssl. r=wtc,nelsonb 2006-05-16 01:14:43 +00:00
wtchang%redhat.com
49a4fc689f Bugzilla Bug 298506: a first cut at Solaris auditing. The patch is
contributed by Glen Beasley of Sun. r=wtc.
Modified Files:
	cmd/platlibs.mk lib/softoken/config.mk lib/softoken/fipstokn.c
2006-05-16 01:04:05 +00:00
julien.pierre.bugs%sun.com
42f2f41bff Fix for bug 335036 . NSS_Shutdown() does not check that NSS is initialized. r=nelson, alexei 2006-05-16 00:10:04 +00:00
julien.pierre.bugs%sun.com
5ea61ffe76 Fix for bug 337789 . PK11_FindKeyByAnyCert doe snot work if softoken is in FIPS140-2 mode. r=wtchang, rrelyea, nelson 2006-05-15 23:51:01 +00:00
alexei.volkov.bugs%sun.com
6b1e6d3bf2 [Bug 336482] crash or hopefully deadcode [@ crmf_copy_poposigningkey]
because Pointer "destPopoSignKey" dereferenced before NULL check. r=nelson
2006-05-15 21:05:13 +00:00
alexei.volkov.bugs%sun.com
5940997e85 Patch contributed by jonsmirl@yahoo.com
[Bug 337154] Coverity 321, dead code in mozilla/security/nss/lib/pk11wrap/pk11cert.c. r=wtchang
2006-05-15 20:58:10 +00:00
alexei.volkov.bugs%sun.com
968bb1125f Patch contributed by jonsmirl@yahoo.com
[Bug 337086] Coverity 446, dead code in mozilla/security/nss/lib/certhigh/ocsp.c. r=wtchang
2006-05-15 20:52:01 +00:00
alexei.volkov.bugs%sun.com
7b49a9fc5a Patch contributed by jonsmirl@yahoo.com
[Bug 337085] Coverity 447, dead code in mozilla/security/nss/lib/certhigh/ocsp.c
. r=wtchang
2006-05-15 20:44:46 +00:00
alexei.volkov.bugs%sun.com
02307faea5 Patch contributed by timeless@bemail.org
[Bug 337025] Coverity 411, dead code in mozilla/security/nss/lib/certdb/stanpcertdb.c. r=nelson
2006-05-15 20:39:38 +00:00