Commit Graph

4135 Commits

Author SHA1 Message Date
Bogdan Tara
11a51e4c3d Merge inbound to mozilla-central. a=merge 2018-09-12 01:12:32 +03:00
Nathan Froyd
9a33a0eb00 Bug 1490054 - ensure that the {src,obj}dir share the same drive path in Windows; r=chmanchester
This change is necessary for constructing relative paths between the
objdir and srcdir to succeed, and has been (I believe) the implicit
requirement of builds since time immemorial.
2018-09-11 09:46:37 -04:00
Cosmin Sabou
de7676288a Merge mozilla-inbound to mozilla-central. a=merge 2018-09-11 13:06:37 +03:00
Tom Ritter
26dbd4d795 Bug 1481633 Resolve kPStaticModules undefined symbols in MinGW Clang r=glandium
clang can handle MSVC-like codepaths generally, so we want to use those
when building with clang for Windows. So we switch _MSC_VER over to _WIN32
to pick up those codepaths when compiling for Windows with clang.

Additionally, we relax the ordering of sections for the same scenario.

Note that we do need to tell clang to use -fms-extensions with the MSVC code,
we do that in the mingw clang build job patch.

Differential Revision: https://phabricator.services.mozilla.com/D3526

--HG--
extra : moz-landing-system : lando
2018-09-11 03:20:06 +00:00
Andreea Pavel
2b539c7b7e Merge autoland to mozilla-central. a=merge 2018-09-11 00:58:48 +03:00
Chris Manchester
e7c71ddca8 Bug 1487505 - Prompt user to run tup init in an appropriate location when building an objdir outside of the srcdir in tup. r=mshal
Differential Revision: https://phabricator.services.mozilla.com/D4808

--HG--
extra : moz-landing-system : lando
2018-09-10 18:40:42 +00:00
Robert Longson
63cb9a2572 Bug 1482196 - Increase minimum clang version to 3.9 r=froydnj 2018-09-10 18:59:07 +01:00
Mike Hommey
7fa84b1acd Bug 1489340 - Handle XPT files as blobs of data in packager. r=froydnj
We don't actually ship XPT files anymore, but it's still useful for the
packager code to handle old Firefox versions. But for that, we don't
really need the complexity of "linking" XPT files in a single unit per
directory. We can just as well keep the XPT files intact, as long as we
retain individual `interfaces` manifest entries for each.

And since those entries used to be all merged into one, we now instead
group them all together in manifests (which also happens to make it
easier on unit test changes).

Differential Revision: https://phabricator.services.mozilla.com/D5221

--HG--
extra : moz-landing-system : lando
2018-09-07 22:21:07 +00:00
Dorel Luca
37663bb870 Merge mozilla-inbound to mozilla-central. a=merge 2018-09-07 19:35:34 +03:00
Kartikaya Gupta
22d325deab Bug 1440879 - Ensure all the stl_wrappers end up in the generated-files tarball. r=froydnj 2018-09-07 09:34:40 -04:00
Kartikaya Gupta
840a45b700 Bug 1440879 - Emit source-like generated files into generated-sources.json. r=froydnj 2018-09-07 09:34:39 -04:00
Francesco Lodolo (:flod)
875666b584 Bug 1489480 - Remove migration recipes for Firefox 62 r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D5253

--HG--
extra : moz-landing-system : lando
2018-09-07 12:52:14 +00:00
Connor Sheehan
ef46abf75d Bug 1461992: only indent 2 spaces in export_telemetry_schema.py output r=ted
:mreid sent a review of my pull request and informed me that the
JSON schemas used in the data pipeline are all 2-space indented.
If we want to use this script to generate any future changes to
the build system schema, we should make sure it outputs data
correctly.

Differential Revision: https://phabricator.services.mozilla.com/D4149

--HG--
extra : moz-landing-system : lando
2018-08-28 18:15:34 +00:00
Masatoshi Kimura
30ed2d528b Bug 1414060 - give json.dump the correct encoding; r=mshal 2018-09-10 18:57:40 -04:00
Ted Mielczarek
a17cd1805a Bug 1489211 - invoke dumpbin.exe to check NSModule ordering in libxul; r=froydnj 2018-09-06 12:52:48 -04:00
Ted Mielczarek
702294b58e Bug 1446066 - handle HOST_OS_LIBS properly when the host and target compilers are different types; r=chmanchester 2018-09-06 12:21:54 -04:00
Narcis Beleuzu
b0827c4040 Backed out 2 changesets (bug 1440879) for build bustages on mozbuild\test\backend. CLOSED TREE
Backed out changeset 93892cfed015 (bug 1440879)
Backed out changeset 71d569322700 (bug 1440879)
2018-09-04 18:38:19 +03:00
Kartikaya Gupta
1a1ca59f9a Bug 1440879 - Ensure all the stl_wrappers end up in the generated-files tarball. r=froydnj 2018-09-04 10:40:45 -04:00
Kartikaya Gupta
b5f0a96fff Bug 1440879 - Emit source-like generated files into generated-sources.json. r=froydnj 2018-09-04 10:40:42 -04:00
Mike Shal
58e7879466 Bug 1487840 - Trim tup's display of rust build scripts; r=chmanchester
We already trim the display of output lists for GENERATED_FILES scripts
that produce many outputs, so we should do the same for rust build
scripts. This makes the terminal output of the build and the nodes from
'tup graph' more readable.

MozReview-Commit-ID: AftmrA4qJlr

Differential Revision: https://phabricator.services.mozilla.com/D4797

--HG--
extra : moz-landing-system : lando
2018-08-31 20:48:22 +00:00
Chris Manchester
1f2797495b Bug 1487180 - Upload the build graph report as a part of the tup build. r=mshal
Differential Revision: https://phabricator.services.mozilla.com/D4626

--HG--
extra : moz-landing-system : lando
2018-08-31 19:18:47 +00:00
Chris Manchester
89393b1268 Bug 1487180 - Default to mm:ss time format when generating human-readable formats from the build graph report. r=gps,firefox-build-system-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D4625

--HG--
extra : moz-landing-system : lando
2018-08-30 00:52:43 +00:00
Jim Chen
79c02971f8 Bug 1477259 - Use separate version codes for 64-bit builds; r=nalexander
Use the unused 'p' bit in the version code to denote 64-bit builds, so
we have different version codes for 64-bit builds on aarch64 and x86-64.

Differential Revision: https://phabricator.services.mozilla.com/D4260

--HG--
extra : moz-landing-system : lando
2018-08-30 21:51:18 +00:00
Andrew Halberstadt
921c895df2 Bug 1487425 - [mozlint] Fix regression where 'roll' returns dict instead of ResultSummary when no files linted, r=Gijs
This is a regression from bug 1460856.

Differential Revision: https://phabricator.services.mozilla.com/D4759

--HG--
extra : moz-landing-system : lando
2018-08-31 16:05:12 +00:00
Gurzau Raul
3107aff601 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-08-31 00:53:00 +03:00
Myk Melez
7978cd2fe4 Bug 1482810 - set COMPILE_FLAGS var to hide warnings for Rust crates r=chmanchester
In conjunction with the cc crate changes in https://github.com/alexcrichton/cc-rs/pull/342 (which I'll land in https://phabricator.services.mozilla.com/D4699), this hides warnings generated by C code in Rust crates (by removing warnings flags from CFLAGS when compiling Rust libraries).

MozReview-Commit-ID: 9CZgLGbWjbA

Differential Revision: https://phabricator.services.mozilla.com/D3939

--HG--
extra : moz-landing-system : lando
2018-08-30 17:29:54 +00:00
Nathan Froyd
992139e95b Bug 1487449 - stop macro redefinition warning spam for Windows macros; r=ted.mielczarek
This warning spam happens particularly with WebRTC, but I can see it
happening for any third-party software whose use of WINVER and friends
conflicts with our own.  Let's just change mozilla-config.h to avoid
defining these macros if they're already defined via the command line.
2018-08-30 16:09:23 -04:00
Preeti Mukherjee
bfa8d74f55 Bug 1471920 - [mozbuild] Use shutil.which in Python 3 instead of vendored third-party package r=davehunt
Use shutil.which in mozbuild for Python 3 instead of vendored third-party package, and enable mozversion tests that are fixed under Python 3 by this change.

Differential Revision: https://phabricator.services.mozilla.com/D4184

--HG--
extra : moz-landing-system : lando
2018-08-30 16:39:55 +00:00
arthur.iakab
32fbca3814 Merge inbound to mozilla-central a=merge 2018-08-30 00:56:06 +03:00
Andi-Bogdan Postelnicu
1811c9a2df Bug 1486452 - mach static analysis autotest - display the error if we encounter clang-diagnostic-error. r=janx
Differential Revision: https://phabricator.services.mozilla.com/D4425

--HG--
extra : moz-landing-system : lando
2018-08-29 12:11:07 +00:00
Jan Henning
7344cfce10 Bug 1486296 - Use the same temp profile as mach run for launching Firefox from Visual Studio. r=firefox-build-system-reviewers,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D4299

--HG--
extra : moz-landing-system : lando
2018-08-29 14:26:23 +00:00
Andrew Halberstadt
244690e1b9 Bug 1485454 - [mozlint] Fix stylish formatter, issues without a column aren't indented enough, r=sylvestre
After fixing the absolute path issue in codespell, I noticed that the stylish
formatter doesn't indent lint issues that don't have a column properly. This
was never noticed before since most other linters have a column attribute.

Depends on D4012

Differential Revision: https://phabricator.services.mozilla.com/D4013

--HG--
extra : moz-landing-system : lando
2018-08-27 13:40:34 +00:00
Andi-Bogdan Postelnicu
64682f8e84 Bug 1486729 - [Static-Analysis][Clang-Tidy] As default, a checker should be publish by default. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D4436

--HG--
extra : moz-landing-system : lando
2018-08-29 10:10:54 +00:00
Ciure Andrei
c7bd3f7ba5 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-08-29 01:06:58 +03:00
Ciure Andrei
d716a04e20 Merge inbound to mozilla-central. a=merge 2018-08-29 00:58:21 +03:00
Andrew Halberstadt
bbd3ba0a18 Bug 1460856 - [mozlint] Encapsulate all result state in a ResultSummary class r=sylvestre
Currently there are 3 things that can impact the result of a lint run:

1. The list of lint issues found
2. The set of failures that happened during the setup phase
3. The set of failures that happened during the execution phase

All three of these things are stored as instance variables on the LintRoller
object, and then passed into a formatter when it comes time to print the
results. I'd like to add even more things that can impact the result, and it
became clear that the current scenario does not scale well.

This patch moves all data that could impact the end result of a lint run off of
the LintRoller object and onto a new 'result.ResultSummary' class. To avoid
confusion, this patch also renames the 'result.ResultContainer' class to
'result.Issue'.

With this new nomenclature:

result  -> overall state of an entire lint run (can comprise multiple linters)
issue   -> one specific lint infraction (at either 'warning' or 'error' level)
failure -> a non-recoverable error in the linter implementation itself

A "result" is comprised of 0 or more "issues" and 0 or more "failures".

Differential Revision: https://phabricator.services.mozilla.com/D3819

--HG--
extra : moz-landing-system : lando
2018-08-28 13:51:04 +00:00
Andrew Halberstadt
c9cfb100eb Bug 1460856 - [mozlint] Display suppressed warnings count in the summary and stylish formatters r=Standard8
Depends on D3821

Differential Revision: https://phabricator.services.mozilla.com/D3992

--HG--
extra : moz-landing-system : lando
2018-08-27 13:37:28 +00:00
Andrew Halberstadt
787fff6a51 Bug 1460856 - [mozlint] Suppress warnings by default r=Standard8,sylvestre
As of this patch, any lint issue at the "warning" level will *only* be displayed
if --warnings is passed in. This gives us some flexibility to track issues that
are "recommended to fix" but that aren't required (aka don't cause a backout).
I think it would be ideal if the reviewbot ran with warnings enabled, and CI
ran without warnings. This way these issues will be surfaced to developers
(and hopefully get fixed prior to landing), but developers will always be able
to ignore them if the situation warrants it.

Since the last change converted everything to use errors, this patch should
be a no-op for now. However as we move forward (and potentially decide that
certain types of lint issues should result in a backout), this feature will
start seeing more and more use.

Depends on D3820

Differential Revision: https://phabricator.services.mozilla.com/D3821

--HG--
extra : moz-landing-system : lando
2018-08-27 13:39:46 +00:00
arthur.iakab
83d1441dfa Merge mozilla-central to autoland 2018-08-25 01:09:11 +03:00
arthur.iakab
5527acb8d8 Merge inbound to mozilla-central a=merge 2018-08-25 01:08:22 +03:00
Chris Manchester
986a8ae47f Bug 1485174 - Prevent using an objdir to build with tup that was previously used to build with make. r=firefox-build-system-reviewers,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D4154

--HG--
extra : moz-landing-system : lando
2018-08-24 18:13:20 +00:00
Chris Manchester
df7ed3aa22 Bug 1485168 - Provide a tier for the "tup" portion of the build to prevent confusion. r=gps,firefox-build-system-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D3927

--HG--
extra : moz-landing-system : lando
2018-08-24 16:12:31 +00:00
Tom Prince
695b12f9f2 No bug: Add a default retry setting for mach artifact toolchain; r=gps
Differential Revision: https://phabricator.services.mozilla.com/D4039

--HG--
extra : moz-landing-system : lando
2018-08-24 16:04:22 +00:00
Benjamin Bouvier
1948bdb6bc Bug 1485396: Handle non-unified builds for CompileDB too; r=froydnj
--HG--
extra : rebase_source : 98c4d0c6a4f6137ba05c7e13b7a69ba07bd30bf6
extra : amend_source : 863740c6e5e7e24d6ba77c1a107ac1281549ef47
2018-08-23 11:55:50 +02:00
Tom Prince
e60f19d241 Bug 1481121: [release] Build bz2 mar's on mozilla-esr60; r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D3811

--HG--
extra : rebase_source : 549ac804da6fbd01359bd15aaf928fd06ff22cab
extra : histedit_source : 3b3ef722261d4a7bce33d9215b288ba366f38dee
2018-08-17 12:23:42 -06:00
Lifan Zeng
5eecd79002 Bug 1446923 - Remove Some Old References to Chrome-Metro r=jlund
Differential Revision: https://phabricator.services.mozilla.com/D3223

--HG--
extra : moz-landing-system : lando
2018-08-23 23:24:44 +00:00
Bas Schouten
efa3734e21 Bug 1485485 - Followup: Fix which function definition in derrived classes. r=froydnj 2018-08-28 18:24:50 +02:00
Nathan Froyd
5ba4a13346 Bug 1485485 - make bootstrap accept rustc/cargo in known-good locations; r=chmanchester
moz.configure looks for rustc/cargo on PATH and in ~/.cargo/bin.
Bootstrap only looks on PATH and not in ~/.cargo/bin, though it is smart
enough to complain if rustc/cargo can't be found on PATH and you have
them in ~/.cargo/bin.  Bootstrap should look in both places by default,
and be content if it finds them wherever they are, so long as
moz.configure can find them.
2018-08-28 09:31:48 -04:00
Panos Astithas
312fdae0eb Bug 1484243 - Detect vcs automatically in |mach vcs-setup|. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D3942

--HG--
extra : moz-landing-system : lando
2018-08-22 17:26:58 +00:00
Emilio Cobos Álvarez
fd187833dd Bug 1484485: Create state dir and install node / stylo stuff in bootstrap's non-interactive mode. r=ted
The state directory is in $HOME by default, so should be fine to just create it
if we get --no-interactive I think.

Differential Revision: https://phabricator.services.mozilla.com/D3838
2018-08-22 11:17:51 +02:00