> IMPORTANT: this depends on https://phabricator.services.mozilla.com/D43050 to be on central. If it has not been merged already, run `arc patch D43050` before downloading this stack.
- Put style rules into their own components stylesheet.
- Used theme-related colors instead of the same ones for both dark and light themes.
- Made selectors to be class-specific (so they have low specificity)
- Removed some unused CSS in `base.css`
- Fix extra blank space when a section of the manifest is empty (made the hardcoded icons array empty so this can be seen)
NOTE: The CSS/markup for the warnings will be handled in https://bugzilla.mozilla.org/show_bug.cgi?id=1575872
Differential Revision: https://phabricator.services.mozilla.com/D43231
--HG--
rename : devtools/client/application/src/components/manifest/Manifest.css => devtools/client/application/src/components/manifest/ManifestSection.css
extra : moz-landing-system : lando
> IMPORTANT: this depends on https://phabricator.services.mozilla.com/D43050 to be on central. If it has not been merged already, run `arc patch D43050` before downloading this stack.
- Made each "chunk"/category of the Manifest a single component (`ManifestSection`)
- Removed the `ManifestItemIcon`, etc. to favor a single component that can used later on to provide the common layout for the different value types (strings, colors, images…) we might add in the future.
- Decoupled a bit more the props from the raw manifest object we get from platform, so it's more flexible and we don't do array transformations every time the component needs to render.
NOTE: `ManifestItemWarning` still presents some duplication. This will be handled in this other bug https://bugzilla.mozilla.org/show_bug.cgi?id=1575872
Differential Revision: https://phabricator.services.mozilla.com/D43230
--HG--
extra : moz-landing-system : lando
> IMPORTANT: this depends on https://phabricator.services.mozilla.com/D43050 to be on central. If it has not been merged already, run `arc patch D43050` before downloading this stack.
`*View` suffixes are sometimes used in JS frameworks context in the same sense we use our `*Page` suffix in here. To avoid confusion –and to have a shorter name– I renamed components to just `Manifest*`
Differential Revision: https://phabricator.services.mozilla.com/D43229
--HG--
rename : devtools/client/application/src/components/manifest/ManifestView.css => devtools/client/application/src/components/manifest/Manifest.css
rename : devtools/client/application/src/components/manifest/ManifestView.js => devtools/client/application/src/components/manifest/Manifest.js
rename : devtools/client/application/src/components/manifest/ManifestViewEmpty.js => devtools/client/application/src/components/manifest/ManifestEmpty.js
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestView.test.js.snap => devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-Manifest.test.js.snap
rename : devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestViewEmpty.test.js.snap => devtools/client/application/test/components/manifest/__snapshots__/components_application_panel-ManifestEmpty.test.js.snap
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestView.test.js => devtools/client/application/test/components/manifest/components_application_panel-Manifest.test.js
rename : devtools/client/application/test/components/manifest/components_application_panel-ManifestViewEmpty.test.js => devtools/client/application/test/components/manifest/components_application_panel-ManifestEmpty.test.js
extra : moz-landing-system : lando
- This creates a mock for fluent-l10n module, so we can use `l10n.getString()` in our code and test for it.
- This patch also removes unused files `test/fixtures/l10n.js` and `test/fixtures/PluralForm.js`
In order to double check the mock works, these two lines can be added to any test:
```
const { l10n } = require("devtools/client/application/src/modules/l10n");
expect(l10n.getString("foo")).toBe("foo");
```
Differential Revision: https://phabricator.services.mozilla.com/D43050
--HG--
rename : devtools/client/application/test/components/fixtures/l10n.js => devtools/client/application/test/components/fixtures/fluent-l10n.js
extra : moz-landing-system : lando
First part is renaming the layout folder to routing as discussed as well as the PageContainer component to PageSwitcher.
Differential Revision: https://phabricator.services.mozilla.com/D40976
--HG--
rename : devtools/client/application/src/components/layout/PageContainer.js => devtools/client/application/src/components/routing/PageSwitcher.js
rename : devtools/client/application/src/components/layout/moz.build => devtools/client/application/src/components/routing/moz.build
rename : devtools/client/application/test/components/layout/__snapshots__/components_application_panel-PageContainer.test.js.snap => devtools/client/application/test/components/routing/__snapshots__/components_application_panel-PageSwitcher.test.js.snap
rename : devtools/client/application/test/components/layout/components_application_panel-PageContainer.test.js => devtools/client/application/test/components/routing/components_application_panel-PageSwitcher.test.js
extra : moz-landing-system : lando
Add routing support for Manifest page with simple CSS and fluent string for `no manifest found`
Differential Revision: https://phabricator.services.mozilla.com/D40808
--HG--
extra : moz-landing-system : lando
Currently, TabGroups know to break their reference cycles only when the last
window leaves them. For TabGroups which have never had a window join (which
happens under Fission), this means they also never see a window leave, and
therefore never break their reference cycles, and leak.
This patch adds a check to break reference cycles if no windows have joined by
the time a BrowserChild they belong to is destroyed.
MANUAL PUSH: Lando fails to rebase.
Differential Revision: https://phabricator.services.mozilla.com/D40669
--HG--
extra : source : 03acb28ab60fb77fa06064385a62cc46cf4ad1bd
extra : amend_source : 0a71625d99951bebe45ee6f62570de491a714e97
This patch implements a page switcher component (`PageContainer`) and a new Redux substate (`UiState`) to handle which page is shown. At the moment, only service workers page is supported. The aim of this patch is to enable support to add new pages later on and be able to switch between them easily.
Differential Revision: https://phabricator.services.mozilla.com/D39897
--HG--
extra : moz-landing-system : lando
**NOTE: This depends on D35513, so if it has not landed yet, please `arc patch D35513` before patching this one on top.**
- `.devtools-button` styles in `common.css` are kinda broken , so I decided to roll out our own button component (`UIButton`) after consulting with Victoria colors, sizes, etc. The other downside to selectors in `common.css` is that they can have a high specificity :(
- Victoria said to use the "micro" style from Photon as the default style for buttons in the panels. So I created an even smaller "micro" styles (very similar to `.devtools-togglebutton`) for when we need smaller buttons.
- I created some light/dark variables in our stylesheets instead of on `variables.css` because `--theme-button-background` was already taken (only used in a single panel, but still…). Maybe after the buttons are fixed globally in the common folder, we could use the variables there. In the meantime, to avoid losing more time, I rolled out our own vars here.
Differential Revision: https://phabricator.services.mozilla.com/D37883
--HG--
extra : moz-landing-system : lando
**NOTE: This depends on D35513, so if it has not landed yet, please `arc patch D35513` before patching this one on top.**
- `.devtools-button` styles in `common.css` are kinda broken , so I decided to roll out our own button component (`UIButton`) after consulting with Victoria colors, sizes, etc. The other downside to selectors in `common.css` is that they can have a high specificity :(
- Victoria said to use the "micro" style from Photon as the default style for buttons in the panels. So I created an even smaller "micro" styles (very similar to `.devtools-togglebutton`) for when we need smaller buttons.
- I created some light/dark variables in our stylesheets instead of on `variables.css` because `--theme-button-background` was already taken (only used in a single panel, but still…). Maybe after the buttons are fixed globally in the common folder, we could use the variables there. In the meantime, to avoid losing more time, I rolled out our own vars here.
Differential Revision: https://phabricator.services.mozilla.com/D37883
--HG--
extra : moz-landing-system : lando
