Commit Graph

7129 Commits

Author SHA1 Message Date
Eitan Isaacson
6d59d60177 Bug 1471951 - Support expand selection with caret (2/2). r=yzen r=jchen 2018-07-16 10:53:27 -07:00
Eitan Isaacson
ffbf9af4d8 Bug 1471951 - Support set selection and clipboard actions (1/2). r=yzen r=jchen 2018-07-16 10:53:27 -07:00
James Teh
e5a1c32097 Bug 1475376: Support aria-valuetext for implicit ARIA roles. r=MarcoZ
For example, <input type="range"> maps to role="slider", so aria-valuetext should be supported.

MozReview-Commit-ID: IYBVTHP3ZLo

--HG--
extra : rebase_source : 906dfacf92d040abf97b46ff67bafbabc5c9a1ea
2018-07-12 20:22:09 -04:00
James Teh
0d1fdc7425 Bug 1474814: Invalidate the AccessibleHandler cache on focus events. r=MarcoZ
We don't fire a state change for the focused state, since that would be redundant given that we fire a focus event.
However, that also means the handler cache previously didn't get invalidated when there was a focus change without any other update.
That resulted in stale focused states, which could mean an object was exposed as focused when it wasn't.
Invalidating the cache for focus events ensures the focused state is always up to date.

MozReview-Commit-ID: DZTJMbiTwgt

--HG--
extra : rebase_source : 9977699999218432b07c4af2149cba6e0de466af
2018-07-11 16:26:19 +10:00
shindli
d7270e6100 Merge inbound to mozilla-central. a=merge 2018-07-11 12:42:27 +03:00
Eitan Isaacson
1f354f1604 Bug 1473998 - Use EditText entry in accessible's classNames and use the hint for the label. r=yzen r=jchen 2018-07-10 17:31:00 +03:00
Chris Peterson
16cc517cf9 Bug 1473453 - Part 1: a11y: assert hitregion property is always null or true. r=MarcoZ
Fix clang-tidy warning about bool pointers:

[misc-bool-pointer-implicit-conversion] accessible/generic/Accessible.cpp:644:9: warning: dubious check of 'bool *' against 'nullptr', did you mean to dereference it?

The `hitregion` property is always null or points to a true bool, set here:

https://searchfox.org/mozilla-central/rev/6ef785903fee6c0b16a1eab79d722373d940fd78/dom/canvas/CanvasRenderingContext2D.cpp#3936-3937

The `hitregion` property used to be an nsRect pointer:

https://searchfox.org/mozilla-central/diff/c797577640f306df87e8c32313c5b826d1e58a9b/accessible/src/generic/Accessible.cpp#928

MozReview-Commit-ID: HYlAnMyaitB

--HG--
extra : rebase_source : 2f8d9d151ebc382043c107517838ccdaa0ed7228
2018-07-04 14:39:57 -07:00
Cosmin Sabou
1519cc7aac Backed out changeset ae9049c5ac63 (bug 1473998) for gv-junit failures on test.AccessibilityTest.testTextEntryNode. a=backout 2018-07-11 02:06:05 +03:00
Eitan Isaacson
868533e1cb Bug 1473998 - Use EditText entry in accessible's classNames and use the hint for the label. r=yzen r=jchen 2018-07-10 12:40:00 +03:00
Eitan Isaacson
a17a08b748 Bug 1473730 - Don't speak entire subtree of document when it is focused. r=yzen
After page load the document is focused and the entire subtree is
spoken. It should only speak the name.

--HG--
extra : rebase_source : bfc5542969fa29c45b9617d873a3dba7bf1a47c2
2018-07-10 08:43:00 +03:00
Eitan Isaacson
6e015436cb Bug 1473605 - Don't clump labels and controls together. It messes with focus events. r=yzen 2018-07-05 15:06:00 +03:00
Margareta Eliza Balazs
fd5c37f1dd Merge inbound to mozila-central. a=merge 2018-07-06 12:47:20 +03:00
Eitan Isaacson
2cee1b8c81 Bug 1472274 - Alter selection direction according to the last change. r=surkov
nsIAccessibleText.setSelectionBounds should accept a start offset that is larger than an end offset. This is an indica tion that it is a reverse selection, and the caret should be at the start of the selection.

This should also be consistent with how multiple range selections work interactively - the caret should re
main at the last offset reached.
2018-07-05 15:19:00 +03:00
James Teh
14367430eb Bug 468497: Inform the accessibility FocusManager when a XUL tree's view changes. r=MarcoZ
Without this, accessibility clients don't get notified about the newly focused item.
For example, this meant that nothing was reported by screen readers when switching tabs in Thunderbird with control+tab.

MozReview-Commit-ID: F7vqvLXzeJR

--HG--
extra : rebase_source : debd649415cdc7417660c5846a923a5cc8edad79
2018-07-05 16:33:24 +10:00
Robert Bartlensky
9873588035 Bug 1472672 - Add null check for textAcc. r=davidb
MozReview-Commit-ID: AL7R1fdlcvN

--HG--
extra : amend_source : 653d47dd5b5aaf637e5f5796239b304f4f27ccc2
2018-07-04 14:09:32 +01:00
Alexander Surkov
32562a67f0 Bug 1349223 - cut aria-hidden tree, r=yzen 2018-07-04 10:20:49 -04:00
Aaron Klotz
902b049f4a Bug 1460022: Part 4 - Update a11y code to reflect new interface for DLL interceptor; r=Jamie 2018-06-27 11:49:17 -06:00
shindli
dd50d1646e Backed out 13 changesets (bug 1460022) for bustages in :/build/build/src/mozglue/tests/interceptor/TestDllInterceptor.cpp(113) on a CLOSED TREE
Backed out changeset b798c3689bbf (bug 1460022)
Backed out changeset c3b3b854affd (bug 1460022)
Backed out changeset ecb1b6fd3134 (bug 1460022)
Backed out changeset 91fed649dd5a (bug 1460022)
Backed out changeset be7032cddad2 (bug 1460022)
Backed out changeset d4a036b976e6 (bug 1460022)
Backed out changeset 5f3dfde41e38 (bug 1460022)
Backed out changeset a16486a6f685 (bug 1460022)
Backed out changeset 69eacc5c3ab8 (bug 1460022)
Backed out changeset 34aa7c29b31e (bug 1460022)
Backed out changeset 00b20c0a7637 (bug 1460022)
Backed out changeset b8e8aea4a01f (bug 1460022)
Backed out changeset 15822d9848d8 (bug 1460022)
2018-07-04 03:37:11 +03:00
Aaron Klotz
349c64cd00 Bug 1460022: Part 4 - Update a11y code to reflect new interface for DLL interceptor; r=Jamie 2018-06-27 11:49:17 -06:00
shindli
dcc88f33f9 Backed out 13 changesets (bug 1460022) for bustages in builds/worker/workspace/build/src/dom/plugins/ipc/FunctionHook.h💯24 on a CLOSED TREE
Backed out changeset 0734142a3f35 (bug 1460022)
Backed out changeset 18fbfa7ca685 (bug 1460022)
Backed out changeset 2df129bd5692 (bug 1460022)
Backed out changeset 02a7ed68933f (bug 1460022)
Backed out changeset 221137d1c2de (bug 1460022)
Backed out changeset 9cb0b7a15402 (bug 1460022)
Backed out changeset 18f8f85c0307 (bug 1460022)
Backed out changeset 867a1351efff (bug 1460022)
Backed out changeset 933e0b698f8e (bug 1460022)
Backed out changeset 09da660071e1 (bug 1460022)
Backed out changeset 8bb5142d3f53 (bug 1460022)
Backed out changeset 0ddf581bdaac (bug 1460022)
Backed out changeset 1cd5f9b4a6af (bug 1460022)
2018-07-04 02:49:24 +03:00
Aaron Klotz
63e70eee76 Bug 1460022: Part 4 - Update a11y code to reflect new interface for DLL interceptor; r=Jamie
--HG--
extra : rebase_source : ada28438a506edcd4a122ec2c99a742503baa945
2018-06-27 11:49:17 -06:00
James Teh
d4ef733244 Bug 1472137 - Prevent mutex reentry in mscom::Interceptor::Create if GetInitialInterceptorForIID fails. r=aklotz
If GetInitialInterceptorForIID fails, the live set lock is not released in most cases, but the newly created Interceptor will be destroyed.
The Interceptor's destructor tries to acquire the live set lock again, but that causes a deadlock, since reentry is no longer allowed for a mutex after bug 1364624.
GetInitialInterceptorForIID now ensures the live set lock is always released  on failure, thus preventing the deadlock.

MozReview-Commit-ID: z0Q7JLnJXQ

--HG--
extra : amend_source : 0b9837e5500754b5782e72337fc59b7904c5e29c
2018-07-02 15:17:12 +10:00
James Teh
2202cef9bf Bug 1471466: Don't fire a focus event for a remote accessible if focus has moved into the chrome since the event was sent. r=surkov
For example, this can happen when choosing File menu -> new Tab.
Focus briefly returns to the document in the original tab, so we ask that document to restore focus.
The remote document then sends a focus event to the parent.
However, before the parent can process that event, focus has already moved to the address bar for the new tab.
With this check, we discover that focus is now in the chrome and thus avoid firing the event for the remote accessible.

MozReview-Commit-ID: 7k58dzREqZD

--HG--
extra : rebase_source : 51303f54293957f562e8540c8bf98f821694be54
2018-06-27 15:33:08 +10:00
shindli
30d0a68a51 Backed out changeset f32174f44c65 (bug 1471466) for bc failures on Windows on a CLOSED TREE 2018-06-29 07:35:29 +03:00
James Teh
31b106cf3a Bug 1471466: Don't fire a focus event for a remote accessible if focus has moved into the chrome since the event was sent. r=surkov
For example, this can happen when choosing File menu -> new Tab.
Focus briefly returns to the document in the original tab, so we ask that document to restore focus.
The remote document then sends a focus event to the parent.
However, before the parent can process that event, focus has already moved to the address bar for the new tab.
With this check, we discover that focus is now in the chrome and thus avoid firing the event for the remote accessible.

MozReview-Commit-ID: 7k58dzREqZD

--HG--
extra : rebase_source : 070d3a6b5032bd6d4cd36fb054be04509bb0faae
2018-06-27 15:33:08 +10:00
Tim Nguyen
73ad4c957d Bug 1471542 - Remove support for tree[seltype=cell] and tree[seltype=text]. r=Paolo
MozReview-Commit-ID: BW9u3CvvP1p

--HG--
extra : rebase_source : bf0895ac41708fa62125109a480f6dd172a03798
2018-06-27 18:35:18 +01:00
Jeff Gilbert
5b753da289 Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
Paolo Amadini
372336c621 Bug 1448126 - Part 2 - Remove the "scale" binding and its supporting platform code. r=bgrins
MozReview-Commit-ID: ETmUuosYxeG

--HG--
extra : rebase_source : 1a39207887f2c55f5d2cd31990209809dbb97ba9
2018-06-24 17:19:25 +01:00
Paolo Amadini
3cb26f3bcd Bug 1448126 - Part 1 - Remove tests for the "scale" binding. r=bgrins
MozReview-Commit-ID: 9LxA3ERl89r

--HG--
extra : rebase_source : d71a398bf09d954ce6213f37bf276e2f13943191
2018-06-24 17:19:15 +01:00
Chris Peterson
2afd829d0f Bug 1469769 - Part 6: Replace non-failing NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE. r=froydnj
This patch is an automatic replacement of s/NS_NOTREACHED/MOZ_ASSERT_UNREACHABLE/. Reindenting long lines and whitespace fixups follow in patch 6b.

MozReview-Commit-ID: 5UQVHElSpCr

--HG--
extra : rebase_source : 4c1b2fc32b269342f07639266b64941e2270e9c4
extra : source : 907543f6eae716f23a6de52b1ffb1c82908d158a
2018-06-17 22:43:11 -07:00
Cosmin Sabou
aeb2ada3aa Backed out changeset b2df5de436bd (bug 1349223) for permafailling marionette harness on test_accessibility.py. CLOSED TREE 2018-06-25 22:50:58 +03:00
Alexander Surkov
3da9b86da8 Bug 1349223 - cut aria-hidden tree, r=yzen 2018-06-25 14:17:01 -04:00
Alexander Surkov
b81b775fc0 Bug 1349223 - do not assert if a document is unattached from tree when seding the events, r=jamie 2018-06-25 13:16:43 -04:00
Alexander Surkov
35b0e15ead Bug 1380199 - add a testcase for 'Event coalescence killed the accessible' assertion, r=yzen 2018-06-22 11:19:00 -04:00
Eitan Isaacson
09ec9609fb Bug 1465823 - Add new position and offsets to pivot change notifications and vc events. r=surkov 2018-06-21 14:47:00 +03:00
Tokio Kajitsuka
bb2dd00584 Bug 1469379 - let is missing from accessible/tests/mochitest/aom/test_general.html. r=surkov 2018-06-19 04:49:16 +09:00
Alexander Surkov
aee9020405 Bug 883712 - replace 'Text leaf parent is not hypertext' assertion to moz_assert 2018-06-18 18:19:09 -04:00
Alexander Surkov
9b16d6de3d Bug 759650 - turn 'Called on accessible unbound from tree' assertion into moz_assert 2018-06-18 14:04:08 -04:00
Alexander Surkov
3364a60bed Bug 886215 - trun 'Children of not selected deck panel are not accessible' into moz_assert 2018-06-18 14:02:27 -04:00
Mark Banner
b30ac6aacd Bug 1456762 - Remove now unnecessary import-globals-from statements in html files. r=mossop
Depends on D1643

MozReview-Commit-ID: 84M50HDg0wl

Differential Revision: https://phabricator.services.mozilla.com/D1644
2018-06-16 08:21:33 +00:00
Eliza Balazs
00974991a2 Bug 1468197 - remove remaining references in manifests to windows xp. r=jmaher 2018-06-14 05:25:00 +03:00
Noemi Erli
31fa4e1ccf Bug 1468200 - remove references to 'mulet' in manifest files. r=jmaher
--HG--
extra : rebase_source : d233138d248a4d3a826dc7666e13bd30ceafb496
2018-06-13 05:53:00 +03:00
Andreea Pavel
99c88126b6 Bug 1468199 - remove references to b2g in test manifests r=jmaher 2018-06-12 14:57:00 +03:00
Gurzau Raul
c0b733a2a3 Backed out changeset da4e49603752 (bug 1468197) for mochitest ParseError failures on a CLOSED TREE 2018-06-13 06:59:12 +03:00
Andreea Pavel
b4e4b15f2b Bug 1468197 - remove remaining references in manifests to windows xp r=jmaher 2018-06-12 12:34:00 +03:00
Joel Maher
50b91c0a14 Bug 1405428 - skip-if = verify on mochitests which do not pass test-verify. r=gbrown 2018-06-10 05:01:47 -04:00
Alexander Surkov
94ab51d46c Bug 687011 - aria-activedescendant change on inserted node doesn't fire focus change, r=jamie 2018-06-08 10:55:08 -04:00
Alex Gaynor
b174206e6f Bug 1451859 - Part 2: Add sanitizer coverage to a handful of places relevant to IPC. r=posidron 2018-04-05 15:48:11 -04:00
Tokio Kajitsuka
e1e329ad54 Bug 1462465 - Cache AccessibleNode in Node. r=surkov,smaug
Cache AccessibleNode and make it able to operate the same instance by nsINode::GetAccessibleNode

--HG--
extra : rebase_source : 063eec8658af020f5408260d7d581ee76a04bd37
2018-05-26 22:47:48 +09:00
Cosmin Sabou
18d0742c9b Backed out 3 changesets (bug 1451859) for causing Spidermonkey bustages on Linux x64 opt.
Backed out changeset 8f5a9e18e953 (bug 1451859)
Backed out changeset 950fa584ec8e (bug 1451859)
Backed out changeset f1f42726f1ec (bug 1451859)
2018-06-07 09:10:35 +03:00