Commit Graph

170 Commits

Author SHA1 Message Date
Mats Palmgren
3ffa9baecc Bug 1028460 - part 3, Change the return type for Get*SkipSides(). r=roc 2014-06-28 10:13:13 +00:00
Phil Ringnalda
811c3783d4 Back out 5 changesets (bug 1028460, bug 1031444) for somehow breaking asmjscache/test/test_cachingBasic.html on Android 2.2
Backed out changeset 0b5918ec6521 (bug 1031444)
Backed out changeset 663ff18cd4a1 (bug 1028460)
Backed out changeset ae01b3919c8c (bug 1028460)
Backed out changeset 316c8dfeca9b (bug 1028460)
Backed out changeset e237b2c61ea2 (bug 1028460)
2014-06-28 22:01:28 -07:00
Mats Palmgren
4e879335f7 Bug 1028460 - part 3, Change the return type for Get*SkipSides(). r=roc 2014-06-28 10:13:13 +00:00
Mats Palmgren
3e13115cf3 Bug 1025669 - part 0, Add BaseMargin::ApplySkipSides, remove nsIFrame::Apply*SkipSides, and change call sites to use the former. r=roc 2014-06-24 17:52:19 +00:00
Simon Montagu
82f2df73ba Bug 789096 patch 8: use logical coordinates in nsBlockReflowState. r=jfkthame 2014-06-20 02:55:35 -07:00
Simon Montagu
aaa4878ee5 Replace GetBaseline with GetLogicalBaseline and use logical coordinates in the line position and baseline getters in nsLayoutUtils. Bug 789096, r=jfkthame 2014-06-17 05:19:38 -07:00
Mats Palmgren
1d0b2b5072 Bug 1015844 - part 2, Add a call to ReflowOverflowContainerChildren() to reflow abs.pos. overflow containers. r=roc
nsColumnSetFrame puts true overflow containers on the principal child list
(which may then get pushed to the overflow list), but overflow containers
for abs.pos. children still go on the kOverflowContainersList and
kExcessOverflowContainersList lists as usual.
2014-06-03 14:17:14 +00:00
Mats Palmgren
b6577db002 Bug 1015781 - part 4, Make nsColumnSetFrame::SetInitialChildList/AppendFrames/InsertFrames/RemoveFrame DEBUG only and assert that the latter three are not called. r=roc 2014-05-28 19:36:58 +00:00
Mats Palmgren
f08f841973 Bug 1015781 - part 1+2, Make the SetInitialChildList/AppendFrames/InsertFrames/RemoveFrame methods return void (scripted change). Remove code handling the return values. r=roc 2014-05-28 19:36:58 +00:00
Mats Palmgren
2831fb8a6a Bug 508665 - part 4, Make nsCSSFrameConstructor use nsContainerFrame* for frames used as parent frames. r=roc 2014-05-24 22:20:40 +00:00
Mats Palmgren
9795aca511 Bug 1008917 - part 2,3,4, make Reflow() return type 'void', and make a few reflow related helper methods 'void' too. r=roc 2014-05-13 00:47:52 +00:00
Wes Kocher
42253715d7 Backed out 11 changesets (bug 1008917) for apparently introducing an intermittent failure of B2G Crashtest-2 on a CLOSED TREE
Backed out changeset e2ab653f688a (bug 1008917)
Backed out changeset b52154d8d900 (bug 1008917)
Backed out changeset 2ab5b01da4de (bug 1008917)
Backed out changeset f7a38df1d44f (bug 1008917)
Backed out changeset 80304bb9a572 (bug 1008917)
Backed out changeset 10ed89a302e9 (bug 1008917)
Backed out changeset 161c41991d46 (bug 1008917)
Backed out changeset 25b2475d2368 (bug 1008917)
Backed out changeset b8000b31277c (bug 1008917)
Backed out changeset 9afa5e7715e1 (bug 1008917)
Backed out changeset 5c380c21351f (bug 1008917)
2014-05-12 15:47:41 -07:00
Mats Palmgren
a722b491f1 Bug 1008917 - part 2,3,4, make Reflow() return type 'void', and make a few reflow related helper methods 'void' too. r=roc 2014-05-12 17:40:28 +00:00
Arnaud Sourioux
2d583fd28f Bug 919806: Get rid of NS_IMETHOD in nsIFrame.h and its implementations r=dholbert 2014-02-17 23:47:48 -08:00
Daniel Holbert
03c54ea5eb Bug 967287 part 1: Remove unnecessary nsPresContext* argument from functions defined in nsContainerFrame.h. r=mats 2014-02-06 14:07:47 -08:00
Cameron McCormack
15cc32b681 Bug 960848 - Part 1: Make nsFrameState an enum and consolidate all frame state bit definitions in a single preprocessed file. r=dbaron 2014-02-05 12:59:39 +11:00
Peiyong Lin
14bf63554d Bug 959874 - Reorder two parameters in nsContainerFrame::FinishReflowChild(), for consistency with nsContainerFrame::ReflowChild(). r=dholbert 2014-01-16 17:34:44 -08:00
Jonathan Kew
a7837e1ffa bug 735577 - pt 4.1 - use accessor functions for some physical-coordinate fields in nsHTMLReflowMetrics, in preparation for logicalization. r=smontagu 2013-12-27 17:59:52 +00:00
Jonathan Kew
954a119d07 bug 735577 - pt 3.2 - update the rest of layout code to use the new accessors on nsHTMLReflowState. r=smontagu 2013-12-27 17:59:21 +00:00
Ehsan Akhgari
325f736125 Bug 938849 - Build layout/generic in unified mode; r=roc 2013-11-15 08:19:02 -05:00
Cameron McCormack
c9626f8959 Bug 921716 - Don't paint column rules when element is visibility:hidden. r=sjohnson 2013-10-01 11:30:06 +10:00
Ehsan Akhgari
baf3a129ad Bug 907883 - Minimize #includes in layout/generic; r=roc
--HG--
extra : rebase_source : 5e87b764a12b05aff477c71547e2131be67ca93b
2013-08-22 14:32:52 -04:00
Scott Johnson
cca0d1756f Bug 746015: Add a nsDisplayGenericOverflow class that uses a frame's visual overflow rect as its bounds to correctly display column rules that lie outside of a column set frame's bounds. [r=dbaron] 2013-08-20 16:38:29 -05:00
Scott Johnson
781431d8a2 Bug 743402, Part 5: Utilize new computed height calculations in nsSplittableFrame to correctly compute the height of a column set frame in paginated context. [r=roc] 2013-07-25 10:34:31 -05:00
Ryan VanderMeulen
6e81109389 Backed out 6 changesets (bug 743402) for reftest failures on a CLOSED TREE.
Backed out changeset 19848fff857e (bug 743402)
Backed out changeset 049168537ae0 (bug 743402)
Backed out changeset 3098fea37f2d (bug 743402)
Backed out changeset ada93e976dca (bug 743402)
Backed out changeset c7907c54187f (bug 743402)
Backed out changeset 2edbbf6440c4 (bug 743402)
2013-07-24 15:14:04 -04:00
Scott Johnson
11823f14fd Bug 743402, Part 5: Utilize new computed height calculations in nsSplittableFrame to correctly compute the height of a column set frame in paginated context. [r=roc] 2013-07-24 12:47:21 -05:00
Scott Johnson
c62f49333b Bug 861184: Pull code providing binary search for valid column height into its own method. [r=roc] 2013-07-09 15:24:27 -05:00
Scott Johnson
72fa85e0c2 Bug 730559: Limit the number of columns during layout of column sets to prevent hang. [r=mats]
In nsRuleNode, when we parse a number of columns from a CSS style sheet, we enforce
a rule that the number of columns cannot exceed 1000. This patch simply enforces
the same rule when we decide that the column count will be generated based on
the available width (e.g. the column-count property has a value of 'auto').
2013-05-31 10:51:43 -05:00
Scott Johnson
42819ab4ee Bug 857324: Make column set reflow continue without balancing rather than restarting if computed height is exceeded. [r=mats] 2013-04-24 10:02:36 -05:00
Ryan VanderMeulen
7aa800d169 Backed out changeset f31e6ad99dfe (bug 857324) for Android reftest-3 failures.
CLOSED TREE
2013-04-23 21:10:48 -04:00
Scott Johnson
da4b69a221 Bug 857324: Make column set reflow continue without balancing rather than restarting if computed height is exceeded. [r=mats] 2013-04-23 15:46:08 -05:00
Scott Johnson
1c6de2e304 Bug 861182: Pull knownFeasibleHeight and knownInfeasibleHeight into ReflowConfig so they can be used outside of nsColumnSetFrame::Reflow(). [r=roc] 2013-04-16 07:52:51 -05:00
Scott Johnson
c2cef2b667 Bug 861181: Separate interface from implementation for nsColumnSetFrame. [r=roc] 2013-04-16 07:52:49 -05:00
Scott Johnson
8c1c3e2ad7 Bug 600100, Part 2: Force a vertical resize even if our available height hasn't changed in anonymous blocks of a column set so we don't crash. [r=mats] 2013-04-08 13:38:33 -05:00
Mats Palmgren
b3ddf199bb Bug 729519 - Allocate heap nsFrameLists from the shell arena. r=bzbarsky
"new nsFrameList()" becomes "new (shell) nsFrameList()".
"delete list" becomes "if (list) list->Delete(shell)" - note also that
an additional assertion was added that list is empty when deleted.

"nsAutoPtr<nsFrameList> list(StealSomeFrames())" becomes
"AutoFrameListPtr list(aPresContext, StealSomeFrames())"
2013-04-01 17:26:02 +02:00
Scott Johnson
c1883f3027 Bug 600100, Part 1: Return a status of NS_FRAME_NOT_COMPLETE during reflow of nsBlockFrame if we have a next continuation with pushed floats to prevent crashing in columns. [r=dbaron] 2013-03-19 09:05:05 -05:00
Scott Johnson
d51186d49f Backed out changeset 3b18c328b316 (bug 600100) to fix commit message DONTBUILD. 2013-03-19 09:43:27 -05:00
Scott Johnson
8cbce8236f Bug 600100, Part 1: Return a status of NS_FRAME_NOT_COMPLETE during reflow of nsBlockFrame if we have a next continuation with pushed floats to prevent crashing in columns. 2013-03-19 09:05:05 -05:00
Scott Johnson
a7fbe2c8c3 Bug 846575: Clean up nsColumnSetFrame by adding an isBalancing convenience member to ReflowConfig. [r=fantasai] 2013-03-08 09:43:46 -06:00
Scott Johnson
8dc4bcd444 Bug 810726: Simplify logic for handling too many columns to prevent crash. [r=roc] 2013-03-06 08:20:24 -06:00
Scott Johnson
a2535182f9 Backout ddb4df63c258 on a CLOSED TREE due to ARM v6 bustage. 2013-03-04 16:50:40 -06:00
Scott Johnson
946ae9ce3a Bug 810726: Simplify logic for handling too many columns to prevent crash. [r=roc] 2013-03-04 14:15:18 -06:00
Scott Johnson
aa7f8f28f4 Bug 724978: Make nsColumnSetFrame handle absolutely positioned children without crashing. [p=ehsan, r=fantasai] 2013-02-28 19:56:48 -08:00
L. David Baron
c5b9eee040 Bug 781360 patch 3: Rename {nsIFrame,nsStyleContext,nsComputedDOMStyle}::GetStyle* to Style*, since they can never return null. r=dholbert
Except for the changes in:
  layout/generic/nsIFrame.h (part)
  layout/style/nsComputedDOMStyle.h (all)
  layout/style/nsRuleNode.cpp (part)
  layout/style/nsStyleContext.cpp (part)
  layout/style/nsStyleContext.h (part)
(see patch 3b in the bug), this patch was written with the sed script:
s/\<GetStyle\(Font\|Color\|List\|Text\|Visibility\|Quotes\|UserInterface\|TableBorder\|SVG\|Background\|Position\|TextReset\|Display\|Content\|UIReset\|Table\|Margin\|Padding\|Border\|Outline\|XUL\|SVGReset\|Column\)\>/Style\1/g
2013-02-16 13:51:02 -08:00
Robert O'Callahan
42e294f8cb Bug 840902. Part 2: Remove nsresults from various display list methods. r=mattwoodrow
--HG--
extra : rebase_source : de498510bf8d85d9b0b2fab0137ef3be01c9adfa
2013-02-15 00:12:27 +13:00
Robert O'Callahan
5c77da3630 Bug 840902. Part 1: Stop checking the results of various display list methods. r=mattwoodrow
--HG--
extra : rebase_source : 50a3d6809ef76a25a3d02d91f2873d9ba11fdc56
2013-02-15 00:08:08 +13:00
L. David Baron
50d4e367af Bug 841789, patch 1: Rename nsIFrame::GetStyleContext() to nsIFrame::StyleContext() since it can never return null. r=dholbert
This makes it conform to our convention that getters returning pointers
that can never be null do not begin with "Get".
2013-02-15 21:38:33 -08:00
Daniel Holbert
9a11e7cf68 Bug 836957 part 2: Remove unnecessary nsIFrame::GetSkipSides() overrides whose implementations are in .cpp files. r=mats 2013-02-04 08:17:20 -08:00
Mats Palmgren
b7ae90666d Bug 786533 - Replace NS_MIN/NS_MAX with std::min/std::max and #include <algorithm> where needed. r=ehsan 2013-01-15 13:22:03 +01:00
Mats Palmgren
28a212ee67 Bug 822053 - Nested balancing column sets restriction shouldn't affect non-balancing column sets. r=roc 2012-12-27 22:24:08 +01:00