Commit Graph

3234 Commits

Author SHA1 Message Date
Daisuke Akatsuka
2575ca8e6e Bug 1590981: Introduce UserSettings object. r=mtigley
Depends on D70318

Differential Revision: https://phabricator.services.mozilla.com/D70319
2020-04-22 01:17:45 +00:00
Daisuke Akatsuka
0736ab52d2 Bug 1590981: Add a settings pane. r=mtigley
Depends on D70317

Differential Revision: https://phabricator.services.mozilla.com/D70318
2020-04-22 01:14:19 +00:00
Daisuke Akatsuka
fd3b574e9f Bug 1590981: Append settings button. r=mtigley
Depends on D70286

Differential Revision: https://phabricator.services.mozilla.com/D70317
2020-04-22 00:53:33 +00:00
Daisuke Akatsuka
43768a5a20 Bug 1625815: Add a node test for Footer component. r=mtigley,rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D70286
2020-04-21 15:34:31 +00:00
Daisuke Akatsuka
74dbb630d2 Bug 1625815: Add a feedback button. r=mtigley,rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D70285
2020-04-22 00:23:21 +00:00
Razvan Caliman
5041fb4bbd Bug 1628044 - Get CSSProperties directly from CSSPropertiesFront r=jdescottes
The `initCssProperties()` helper is used to augment the CSS database of properties received from the server with additional local data. The returned `CSSProperties` object is cached by DevToolsClient instance so it can be returned quickly on subsequent requests.

Requesting the database from the server and its augmentation can be done in the `CSSPropertiesFront`'s [Front.initialize()](https://searchfox.org/mozilla-central/rev/a707541ff423ade0d81cef6488e6ecfa09273886/devtools/shared/protocol/Front.js#115-117) which is already async. This ensures that by the time the `CSSPropertiesFront` is returned, the `CSSProperties` object is ready to use with data reconciled.

Fronts are already [cached per target](https://searchfox.org/mozilla-central/rev/a707541ff423ade0d81cef6488e6ecfa09273886/devtools/client/fronts/targets/target-mixin.js#185-192). A duplicate `target.getFront("cssProperties")` will return the previously instantiated `CSSPropertiesFront` with the augmented database.

Getting the `CSSProperties` object is something done only for the top-level target in the Inspector and the Style Editor. Thanks to the behavior of `target.getFront()`, this already acts as a cache, thus negating both tasks done by the `initCssProperties()` helper.

Differential Revision: https://phabricator.services.mozilla.com/D70071
2020-04-21 13:42:02 +00:00
Gijs Kruitbosch
11836f7641 Bug 1631358 - remove traces of CPOWs from devtools, r=jdescottes,loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D71509
2020-04-21 14:04:58 +00:00
Coroiu Cristina
43be71277d Backed out 2 changesets (bug 1625500) for multiple failures on a CLOSED TREE
Backed out changeset 7d80233bcfcd (bug 1625500)
Backed out changeset 0a35b13dfcde (bug 1625500)
2020-04-17 15:36:05 +03:00
Gijs Kruitbosch
cc39a339a0 Bug 1625500 - fix use of .then(x, x) in the tree, r=marionette-reviewers,Standard8,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D68614
2020-04-17 11:41:49 +00:00
Brindusan Cristian
8b3ca7fd70 Backed out changeset 05ccd03beb2f (bug 1528288) as requested by rcaliman on Bug 1629043 for failing with Beta configuration. CLOSED TREE 2020-04-16 18:57:51 +03:00
Razvan Caliman
af81e97e25 Bug 1627795 - Remove unused getCssProperties() helper r=gl
Differential Revision: https://phabricator.services.mozilla.com/D70048
2020-04-07 19:39:25 +00:00
Daisuke Akatsuka
9795757724 Bug 1625132: Add telemetry for MDN link. r=Honza,fscholz
Differential Revision: https://phabricator.services.mozilla.com/D70485

--HG--
extra : moz-landing-system : lando
2020-04-15 11:40:22 +00:00
Andreea Pavel
2cbcfa9385 Backed out changeset aa85314cbc0d (bug 1625132) for node devtools jest | compatibility failure on a CLOSED TREE 2020-04-15 14:03:34 +03:00
Daisuke Akatsuka
53459f4868 Bug 1625132: Add telemetry for MDN link. r=Honza,fscholz
Differential Revision: https://phabricator.services.mozilla.com/D70485

--HG--
extra : moz-landing-system : lando
2020-04-15 05:51:22 +00:00
Jacqueline
c6d7e0ebde Bug 1528288 - Introduce a tooltip when hovering over box-model values to show the rule where a value is coming from r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D68708

--HG--
rename : devtools/client/inspector/boxmodel/test/browser_boxmodel_jump-to-rule-on-hover.js => devtools/client/inspector/boxmodel/test/browser_boxmodel_jump-to-rule-on-click.js
extra : moz-landing-system : lando
2020-04-09 13:43:23 +00:00
Julian Descottes
85347793aa Bug 1628691 - Remove leftover usage of this._target in inspector.js r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D62616

--HG--
extra : moz-landing-system : lando
2020-04-09 13:07:29 +00:00
Razvan Caliman
da154ce911 Bug 1464876 - Load reducers on-demand in Inspector sidebar panels r=gl
The Inspector [loads all its panels' Redux reducers](https://searchfox.org/mozilla-central/source/devtools/client/inspector/reducers.js) up front, regardless if they're used or not.
Some of the reducers are quite hefty. It seems needless to load and parse code that's not needed.

In addition, the reducers are loaded in a different place than their corresponding actions. Actions are loaded and used in the panels, but the reducers are all loaded in the [Inpector when creating the store](https://searchfox.org/mozilla-central/rev/d69ec052bed8700af7a283e37b60b4af22734930/devtools/client/inspector/store.js#8,11). It helps reduce the cognitive load if actions and reducers are loaded together where they are used, in the sidebar panels.

This patch uses the approach described in the Redux docs to inject reducers on-demand: https://redux.js.org/recipes/code-splitting/#reducer-injection-approaches

There still are reducers which need to load immediately when the Inspector is initialized (mostly related to the Rules panel). But others, like the reducer for the Animations or Fonts panel, are loaded on-demand when the corresponding panels are visible.

For the most part, reducers are used in response to actions from their corresponding panels. However, the grid, flexbox and grid highlighter reducers are also [used  in HighlightersOverlay.js](https://searchfox.org/mozilla-central/rev/d69ec052bed8700af7a283e37b60b4af22734930/devtools/client/inspector/shared/highlighters-overlay.js#502) to provide highlighters with configuration or node context. In these cases, we load the reducers on-demand even if their corresponding panels haven't been opened yet. When the panels do get opened, the reducers are not re-loaded since they're already available.

Differential Revision: https://phabricator.services.mozilla.com/D67008

--HG--
extra : moz-landing-system : lando
2020-04-07 18:19:13 +00:00
Tim Nguyen
b2a1f8e4b5 Bug 1618243 - Use checked property instead of attribute for rules view checkbox. r=devtools-inspector-reviewers,gl
Differential Revision: https://phabricator.services.mozilla.com/D66866

--HG--
extra : moz-landing-system : lando
2020-04-06 14:18:42 +00:00
Bogdan Tara
cd329c7b65 Bug 1609313 - Disable browser_rules_cubicbezier-appears-on-swatch-click.js on windows 32 debug r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D69301

--HG--
extra : moz-landing-system : lando
2020-04-02 10:44:35 +00:00
Daisuke Akatsuka
3e41ac61f3 Bug 1625812: Move the compatibility tab into between Changes and Fonts. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D68743

--HG--
extra : moz-landing-system : lando
2020-03-30 12:35:39 +00:00
Julian Descottes
00fa44d86e Bug 1625209 - Remove keyboard shortcuts when destroying the DevTools MarkupView r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D68410

--HG--
extra : moz-landing-system : lando
2020-03-27 13:07:27 +00:00
Jason Laster
5a7b245dd7 Bug 1624630 - Simplify the selected thread logic. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D68095

--HG--
extra : moz-landing-system : lando
2020-03-26 12:50:46 +00:00
Jason Laster
069676f934 Bug 1605175 - Selecting an element in remote iframe should switch context and update selector. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D67083

--HG--
extra : moz-landing-system : lando
2020-03-24 15:28:52 +00:00
Julian Descottes
cfab47ff53 Bug 1604539 - Rename shared/fronts to client/fronts in the devtools codebase r=nchevobbe
Depends on D67603
This patch is an automated string replace of shared/fronts/ to client/fronts/ in devtools.

Differential Revision: https://phabricator.services.mozilla.com/D67604

--HG--
extra : moz-landing-system : lando
2020-03-20 13:58:56 +00:00
Bogdan Tara
b03ab7d69b Backed out 5 changesets (bug 1604539) for xpc failures complanining about test_encryption.js CLOSED TREE
Backed out changeset 8455e50002a9 (bug 1604539)
Backed out changeset fb410a1bf9aa (bug 1604539)
Backed out changeset da94f7d503a1 (bug 1604539)
Backed out changeset b4b54335ee2d (bug 1604539)
Backed out changeset 866d6794bbba (bug 1604539)

--HG--
rename : devtools/client/fronts/accessibility.js => devtools/shared/fronts/accessibility.js
rename : devtools/client/fronts/addon/addons.js => devtools/shared/fronts/addon/addons.js
rename : devtools/client/fronts/addon/moz.build => devtools/shared/fronts/addon/moz.build
rename : devtools/client/fronts/addon/webextension-inspected-window.js => devtools/shared/fronts/addon/webextension-inspected-window.js
rename : devtools/client/fronts/animation.js => devtools/shared/fronts/animation.js
rename : devtools/client/fronts/array-buffer.js => devtools/shared/fronts/array-buffer.js
rename : devtools/client/fronts/changes.js => devtools/shared/fronts/changes.js
rename : devtools/client/fronts/content-viewer.js => devtools/shared/fronts/content-viewer.js
rename : devtools/client/fronts/css-properties.js => devtools/shared/fronts/css-properties.js
rename : devtools/client/fronts/descriptors/frame.js => devtools/shared/fronts/descriptors/frame.js
rename : devtools/client/fronts/descriptors/moz.build => devtools/shared/fronts/descriptors/moz.build
rename : devtools/client/fronts/descriptors/process.js => devtools/shared/fronts/descriptors/process.js
rename : devtools/client/fronts/descriptors/tab.js => devtools/shared/fronts/descriptors/tab.js
rename : devtools/client/fronts/descriptors/webextension.js => devtools/shared/fronts/descriptors/webextension.js
rename : devtools/client/fronts/device.js => devtools/shared/fronts/device.js
rename : devtools/client/fronts/environment.js => devtools/shared/fronts/environment.js
rename : devtools/client/fronts/frame.js => devtools/shared/fronts/frame.js
rename : devtools/client/fronts/framerate.js => devtools/shared/fronts/framerate.js
rename : devtools/client/fronts/highlighters.js => devtools/shared/fronts/highlighters.js
rename : devtools/client/fronts/inspector.js => devtools/shared/fronts/inspector.js
rename : devtools/client/fronts/inspector/moz.build => devtools/shared/fronts/inspector/moz.build
rename : devtools/client/fronts/inspector/rule-rewriter.js => devtools/shared/fronts/inspector/rule-rewriter.js
rename : devtools/client/fronts/layout.js => devtools/shared/fronts/layout.js
rename : devtools/client/fronts/manifest.js => devtools/shared/fronts/manifest.js
rename : devtools/client/fronts/memory.js => devtools/shared/fronts/memory.js
rename : devtools/client/fronts/moz.build => devtools/shared/fronts/moz.build
rename : devtools/client/fronts/node.js => devtools/shared/fronts/node.js
rename : devtools/client/fronts/object.js => devtools/shared/fronts/object.js
rename : devtools/client/fronts/perf.js => devtools/shared/fronts/perf.js
rename : devtools/client/fronts/performance-recording.js => devtools/shared/fronts/performance-recording.js
rename : devtools/client/fronts/performance.js => devtools/shared/fronts/performance.js
rename : devtools/client/fronts/preference.js => devtools/shared/fronts/preference.js
rename : devtools/client/fronts/property-iterator.js => devtools/shared/fronts/property-iterator.js
rename : devtools/client/fronts/reflow.js => devtools/shared/fronts/reflow.js
rename : devtools/client/fronts/responsive.js => devtools/shared/fronts/responsive.js
rename : devtools/client/fronts/root.js => devtools/shared/fronts/root.js
rename : devtools/client/fronts/screenshot.js => devtools/shared/fronts/screenshot.js
rename : devtools/client/fronts/source.js => devtools/shared/fronts/source.js
rename : devtools/client/fronts/storage.js => devtools/shared/fronts/storage.js
rename : devtools/client/fronts/string.js => devtools/shared/fronts/string.js
rename : devtools/client/fronts/styles.js => devtools/shared/fronts/styles.js
rename : devtools/client/fronts/stylesheets.js => devtools/shared/fronts/stylesheets.js
rename : devtools/client/fronts/symbol-iterator.js => devtools/shared/fronts/symbol-iterator.js
rename : devtools/client/fronts/targets/browsing-context.js => devtools/shared/fronts/targets/browsing-context.js
rename : devtools/client/fronts/targets/content-process.js => devtools/shared/fronts/targets/content-process.js
rename : devtools/client/fronts/targets/local-tab.js => devtools/shared/fronts/targets/local-tab.js
rename : devtools/client/fronts/targets/moz.build => devtools/shared/fronts/targets/moz.build
rename : devtools/client/fronts/targets/target-mixin.js => devtools/shared/fronts/targets/target-mixin.js
rename : devtools/client/fronts/targets/worker.js => devtools/shared/fronts/targets/worker.js
rename : devtools/client/fronts/thread.js => devtools/shared/fronts/thread.js
rename : devtools/client/fronts/walker.js => devtools/shared/fronts/walker.js
rename : devtools/client/fronts/webconsole.js => devtools/shared/fronts/webconsole.js
rename : devtools/client/fronts/websocket.js => devtools/shared/fronts/websocket.js
rename : devtools/client/fronts/worker/moz.build => devtools/shared/fronts/worker/moz.build
rename : devtools/client/fronts/worker/push-subscription.js => devtools/shared/fronts/worker/push-subscription.js
rename : devtools/client/fronts/worker/service-worker-registration.js => devtools/shared/fronts/worker/service-worker-registration.js
rename : devtools/client/fronts/worker/service-worker.js => devtools/shared/fronts/worker/service-worker.js
2020-03-20 15:53:23 +02:00
Julian Descottes
ad4b5dfb37 Bug 1604539 - Rename shared/fronts to client/fronts in the devtools codebase r=nchevobbe
Depends on D67603
This patch is an automated string replace of shared/fronts/ to client/fronts/ in devtools.

Differential Revision: https://phabricator.services.mozilla.com/D67604

--HG--
extra : moz-landing-system : lando
2020-03-20 12:57:58 +00:00
Jason Laster
5f29a6d696 Bug 1622996 - Refactor devtools codebase to use optional chaining (automated changes). r=jdescottes
Depends on D67084

Differential Revision: https://phabricator.services.mozilla.com/D67537

--HG--
extra : moz-landing-system : lando
2020-03-19 21:13:38 +00:00
Sylvestre Ledru
be18fd4dba Bug 1622328 - add license info to all eslintrc files r=Standard8,webcompat-reviewers,miketaylr
Differential Revision: https://phabricator.services.mozilla.com/D67319

--HG--
extra : moz-landing-system : lando
2020-03-19 13:47:51 +00:00
Julian Descottes
0cf76f06a1 Bug 1620194 - Remove test-actor-registry and expose simplified helpers in shared-head.js r=ochameau
Depends on D65570

Differential Revision: https://phabricator.services.mozilla.com/D65575

--HG--
extra : moz-landing-system : lando
2020-03-18 09:29:58 +00:00
Julian Descottes
c230c0e21e Bug 1620194 - Stop registering test actor dynamically r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D65564

--HG--
extra : moz-landing-system : lando
2020-03-18 09:17:17 +00:00
Bogdan Tara
de7fb1bb56 Bug 1559315 - Disable browser_rules_authored_color.js on Mac && Linux opt r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D67016

--HG--
extra : moz-landing-system : lando
2020-03-17 14:06:59 +00:00
sankalp_sans
a3884579cc Bug 1424863 - Copying CSS Rules from the Devtools Inspector inserts empty lines between rules r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D66899

--HG--
extra : moz-landing-system : lando
2020-03-16 11:48:42 +00:00
Ed Lee
acb960676c Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-reviewers,webcompat-reviewers,perftest-reviewers,sparky,whimboo,denschub
Differential Revision: https://phabricator.services.mozilla.com/D66128

--HG--
extra : moz-landing-system : lando
2020-03-13 23:38:52 +00:00
Daisuke Akatsuka
525f812250 Bug 1615509: Add a test for the throbber. r=mtigley
Depends on D65284

Differential Revision: https://phabricator.services.mozilla.com/D65285

--HG--
extra : moz-landing-system : lando
2020-03-12 14:32:49 +00:00
Daisuke Akatsuka
a1aad12881 Bug 1615509: Show throbber while processing. r=mtigley,ladybenko
Depends on D64535

Differential Revision: https://phabricator.services.mozilla.com/D65284

--HG--
extra : moz-landing-system : lando
2020-03-12 14:42:44 +00:00
Daisuke Akatsuka
2dc58c8a4b Bug 1615509: Add a test for changing top level target. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D64535

--HG--
extra : moz-landing-system : lando
2020-03-12 14:32:52 +00:00
Daisuke Akatsuka
6e9d2d059d Bug 1615509: Add a test for issue node. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D64534

--HG--
extra : moz-landing-system : lando
2020-03-12 14:32:54 +00:00
Daisuke Akatsuka
6c995ea7dd Bug 1615509: Update test that changes style on rule view. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D64533

--HG--
extra : moz-landing-system : lando
2020-03-12 14:32:56 +00:00
Daisuke Akatsuka
50939a4320 Bug 1615509: Update test that checks issues after reloading. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D64319

--HG--
rename : devtools/client/inspector/compatibility/test/browser/browser_compatibility_event_new-node_without-connection.js => devtools/client/inspector/compatibility/test/browser/browser_compatibility_event_document-reload.js
extra : moz-landing-system : lando
2020-03-12 14:32:59 +00:00
Daisuke Akatsuka
f11a41dae9 Bug 1615509: Update test that changes selected node. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D64318

--HG--
rename : devtools/client/inspector/compatibility/test/browser/browser_compatibility_event_new-node.js => devtools/client/inspector/compatibility/test/browser/browser_compatibility_event_selected-node-change.js
extra : moz-landing-system : lando
2020-03-12 14:33:01 +00:00
Daisuke Akatsuka
0c8cc4b4b5 Bug 1615509: Update test that shows css-property issues. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D64317

--HG--
extra : moz-landing-system : lando
2020-03-12 14:33:03 +00:00
Daisuke Akatsuka
3388dbe881 Bug 1615509: Add an unit test for NodeItem. r=ladybenko
Differential Revision: https://phabricator.services.mozilla.com/D64316

--HG--
extra : moz-landing-system : lando
2020-03-12 14:33:05 +00:00
Daisuke Akatsuka
f6807f1842 Bug 1615509: Add an unit test for NodeList. r=ladybenko
Differential Revision: https://phabricator.services.mozilla.com/D64315

--HG--
extra : moz-landing-system : lando
2020-03-12 14:33:07 +00:00
Daisuke Akatsuka
73f2bb951a Bug 1615509: Add an unit test for NodePane. r=ladybenko
Differential Revision: https://phabricator.services.mozilla.com/D64314

--HG--
extra : moz-landing-system : lando
2020-03-12 14:33:10 +00:00
Daisuke Akatsuka
072baac43b Bug 1615509: Update a node test for IssueItem. r=ladybenko
Differential Revision: https://phabricator.services.mozilla.com/D64312

--HG--
extra : moz-landing-system : lando
2020-03-12 14:33:12 +00:00
Daisuke Akatsuka
03923edf20 Bug 1615509: Add styles. r=ladybenko
Differential Revision: https://phabricator.services.mozilla.com/D64311

--HG--
extra : moz-landing-system : lando
2020-03-12 14:32:33 +00:00
Daisuke Akatsuka
e13707578e Bug 1615509: Address rule view change event. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D64310

--HG--
extra : moz-landing-system : lando
2020-03-12 14:32:35 +00:00
Daisuke Akatsuka
cc074c7456 Bug 1615509: Add interaction feature to Rep component. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D64309

--HG--
extra : moz-landing-system : lando
2020-03-12 14:32:38 +00:00
Daisuke Akatsuka
b8f6af4bda Bug 1615509: Show nodes that caused the issue. r=rcaliman,ladybenko
Differential Revision: https://phabricator.services.mozilla.com/D64308

--HG--
extra : moz-landing-system : lando
2020-03-12 14:32:40 +00:00
Daisuke Akatsuka
662a53ad0d Bug 1615509: Show all issues. r=rcaliman,ladybenko
Differential Revision: https://phabricator.services.mozilla.com/D64307

--HG--
extra : moz-landing-system : lando
2020-03-12 14:32:42 +00:00
Daisuke Akatsuka
f1fcb8d1d8 Bug 1615509: Hold all issues in document into the store. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D64306

--HG--
extra : moz-landing-system : lando
2020-03-12 14:32:45 +00:00
Daisuke Akatsuka
bd3efea78d Bug 1615509: Move place where calculate the issues to the action. r=rcaliman
To avoid storing declarationBlocks in reducer.
The reason why I held the information is because had thought that want to update
as soon as possible when change the target browser.
However, as it seems that to update the target browser is not so frequently,
remove the information to reduce the memory.

Differential Revision: https://phabricator.services.mozilla.com/D64305

--HG--
extra : moz-landing-system : lando
2020-03-12 14:32:47 +00:00
Oana Pop Rus
cefdcd7719 Backed out 19 changesets (bug 1615509) for node failures. CLOSED TREE
Backed out changeset c74ae992992f (bug 1615509)
Backed out changeset c6fabe2143a4 (bug 1615509)
Backed out changeset 29b2f9ef4188 (bug 1615509)
Backed out changeset 2df6831aea1a (bug 1615509)
Backed out changeset 85bd4b410435 (bug 1615509)
Backed out changeset d669aefdfeba (bug 1615509)
Backed out changeset 24d5cb462667 (bug 1615509)
Backed out changeset da84734dca0c (bug 1615509)
Backed out changeset d4a3ac741275 (bug 1615509)
Backed out changeset 96be8d39bc09 (bug 1615509)
Backed out changeset 326ea09ed737 (bug 1615509)
Backed out changeset 146ee88fba20 (bug 1615509)
Backed out changeset 488e03cb9723 (bug 1615509)
Backed out changeset 8bb8d8146868 (bug 1615509)
Backed out changeset 8284770b42b4 (bug 1615509)
Backed out changeset b5bd9789553e (bug 1615509)
Backed out changeset 0527c1bd1b61 (bug 1615509)
Backed out changeset 984007b00335 (bug 1615509)
Backed out changeset ee220b50d171 (bug 1615509)

--HG--
rename : devtools/client/inspector/compatibility/test/browser/browser_compatibility_event_selected-node-change.js => devtools/client/inspector/compatibility/test/browser/browser_compatibility_event_new-node.js
rename : devtools/client/inspector/compatibility/test/browser/browser_compatibility_event_document-reload.js => devtools/client/inspector/compatibility/test/browser/browser_compatibility_event_new-node_without-connection.js
2020-03-12 16:27:38 +02:00
Daisuke Akatsuka
956aa760bd Bug 1615509: Add a test for the throbber. r=mtigley
Depends on D65284

Differential Revision: https://phabricator.services.mozilla.com/D65285

--HG--
extra : moz-landing-system : lando
2020-03-10 22:43:29 +00:00
Daisuke Akatsuka
c422dc3ca1 Bug 1615509: Show throbber while processing. r=mtigley,ladybenko
Depends on D64535

Differential Revision: https://phabricator.services.mozilla.com/D65284

--HG--
extra : moz-landing-system : lando
2020-03-12 13:54:03 +00:00
Daisuke Akatsuka
f2c64afaf1 Bug 1615509: Add a test for changing top level target. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D64535

--HG--
extra : moz-landing-system : lando
2020-03-04 07:05:48 +00:00
Daisuke Akatsuka
65af041a92 Bug 1615509: Add a test for issue node. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D64534

--HG--
extra : moz-landing-system : lando
2020-03-04 06:40:53 +00:00
Daisuke Akatsuka
b9f445db86 Bug 1615509: Update test that changes style on rule view. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D64533

--HG--
extra : moz-landing-system : lando
2020-03-10 01:20:45 +00:00
Daisuke Akatsuka
79eead36ec Bug 1615509: Update test that checks issues after reloading. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D64319

--HG--
rename : devtools/client/inspector/compatibility/test/browser/browser_compatibility_event_new-node_without-connection.js => devtools/client/inspector/compatibility/test/browser/browser_compatibility_event_document-reload.js
extra : moz-landing-system : lando
2020-03-04 06:39:04 +00:00
Daisuke Akatsuka
ef74e4acdc Bug 1615509: Update test that changes selected node. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D64318

--HG--
rename : devtools/client/inspector/compatibility/test/browser/browser_compatibility_event_new-node.js => devtools/client/inspector/compatibility/test/browser/browser_compatibility_event_selected-node-change.js
extra : moz-landing-system : lando
2020-03-04 06:38:26 +00:00
Daisuke Akatsuka
5756ed9483 Bug 1615509: Update test that shows css-property issues. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D64317

--HG--
extra : moz-landing-system : lando
2020-03-04 06:37:53 +00:00
Daisuke Akatsuka
3adcbdc6f1 Bug 1615509: Add an unit test for NodeItem. r=ladybenko
Differential Revision: https://phabricator.services.mozilla.com/D64316

--HG--
extra : moz-landing-system : lando
2020-03-04 06:37:22 +00:00
Daisuke Akatsuka
4754b6ad85 Bug 1615509: Add an unit test for NodeList. r=ladybenko
Differential Revision: https://phabricator.services.mozilla.com/D64315

--HG--
extra : moz-landing-system : lando
2020-03-04 06:36:52 +00:00
Daisuke Akatsuka
dc81c2f545 Bug 1615509: Add an unit test for NodePane. r=ladybenko
Differential Revision: https://phabricator.services.mozilla.com/D64314

--HG--
extra : moz-landing-system : lando
2020-03-04 06:36:19 +00:00
Daisuke Akatsuka
44ef723ee5 Bug 1615509: Update a node test for IssueItem. r=ladybenko
Differential Revision: https://phabricator.services.mozilla.com/D64312

--HG--
extra : moz-landing-system : lando
2020-03-04 06:35:51 +00:00
Daisuke Akatsuka
103c7aba04 Bug 1615509: Add styles. r=ladybenko
Differential Revision: https://phabricator.services.mozilla.com/D64311

--HG--
extra : moz-landing-system : lando
2020-03-04 06:35:19 +00:00
Daisuke Akatsuka
554765e34e Bug 1615509: Address rule view change event. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D64310

--HG--
extra : moz-landing-system : lando
2020-03-11 01:21:31 +00:00
Daisuke Akatsuka
c9b2923f04 Bug 1615509: Add interaction feature to Rep component. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D64309

--HG--
extra : moz-landing-system : lando
2020-03-04 06:34:38 +00:00
Daisuke Akatsuka
d1d3c34701 Bug 1615509: Show nodes that caused the issue. r=rcaliman,ladybenko
Differential Revision: https://phabricator.services.mozilla.com/D64308

--HG--
extra : moz-landing-system : lando
2020-03-04 06:34:36 +00:00
Daisuke Akatsuka
7df27373dc Bug 1615509: Show all issues. r=rcaliman,ladybenko
Differential Revision: https://phabricator.services.mozilla.com/D64307

--HG--
extra : moz-landing-system : lando
2020-03-04 06:32:30 +00:00
Daisuke Akatsuka
84f5316faa Bug 1615509: Hold all issues in document into the store. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D64306

--HG--
extra : moz-landing-system : lando
2020-03-04 06:31:39 +00:00
Daisuke Akatsuka
9505e4cdf7 Bug 1615509: Move place where calculate the issues to the action. r=rcaliman
To avoid storing declarationBlocks in reducer.
The reason why I held the information is because had thought that want to update
as soon as possible when change the target browser.
However, as it seems that to update the target browser is not so frequently,
remove the information to reduce the memory.

Differential Revision: https://phabricator.services.mozilla.com/D64305

--HG--
extra : moz-landing-system : lando
2020-03-04 06:31:01 +00:00
Micah Tigley
6f685c3a2a Bug 1606852 - Clean up backwards compatibility overhead from emulation actor refactor r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D66322

--HG--
extra : moz-landing-system : lando
2020-03-11 11:46:13 +00:00
Mark Banner
2c4e35b0a6 Bug 1620218 - Automatic code fixes for Prettier 1.18.2 upgrade. r=mossop,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D65509

--HG--
extra : moz-landing-system : lando
2020-03-08 21:45:16 +00:00
Mark Banner
15cfe23b88 Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D65703

--HG--
extra : moz-landing-system : lando
2020-03-07 10:09:44 +00:00
Sebastian Zartner
f2a579e171 Bug 963933 - Tests for searching for elements via XPath in Inspector. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D64860

--HG--
extra : moz-landing-system : lando
2020-03-04 19:54:48 +00:00
Arthur Iakab
86c980eba4 Backed out 2 changesets (bug 963933) for causing devtools failures on browser_inspector_search-03.js
CLOSED TREE

Backed out changeset d33b655d9fab (bug 963933)
Backed out changeset ed3f61f1c32c (bug 963933)

--HG--
extra : rebase_source : 4cf04bc52117beaf023151fb14601cd8cb3df35b
2020-03-04 13:32:09 +02:00
MahakBansal
cab16c7dde Bug 1596093 - Update tests for Rules view to use getTextProperty(). ?rcaliman r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D63001

--HG--
extra : moz-landing-system : lando
2020-03-04 10:45:32 +00:00
agamvrinos
19316f573e Bug 1596093 - Update tests for Rules view to use getTextProperty(). r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D63019

--HG--
extra : moz-landing-system : lando
2020-03-04 10:45:32 +00:00
Sebastian Zartner
288748ec6c Bug 963933 - Tests for searching for elements via XPath in Inspector. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D64860

--HG--
extra : moz-landing-system : lando
2020-03-04 10:14:42 +00:00
Julian Descottes
2d8df288cb Bug 1619621 - Check if reflowFront is destroyed in untrackReflowsInSelection r=ochameau,daisuke
Differential Revision: https://phabricator.services.mozilla.com/D65121

--HG--
extra : moz-landing-system : lando
2020-03-04 03:45:23 +00:00
Daisuke Akatsuka
547f305f40 Bug 1567800: Skip if debug or windows 7. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D65227

--HG--
extra : moz-landing-system : lando
2020-03-03 23:12:57 +00:00
Daisuke Akatsuka
91f6c02fcf Bug 1615473: Add a test case for animation on ::marker pseudo element. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D64700

--HG--
extra : moz-landing-system : lando
2020-03-02 00:03:42 +00:00
Andreea Pavel
d5172072d4 Bug 1557181 - disable browser_grids_grid-outline-updates-on-grid-change.js on linux and win asan. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D64703

--HG--
extra : moz-landing-system : lando
2020-02-29 23:15:03 +00:00
Sebastian Zartner
70f1b4f8ba Bug 1152321 - Added tests for measuring tool resizing via mouse. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D54433

--HG--
extra : moz-landing-system : lando
2020-02-23 19:49:39 +00:00
Gabriel Luong
83fce38774 Bug 1523049 - Implement the context menu for the new rules view. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D62530

--HG--
extra : moz-landing-system : lando
2020-02-18 11:27:18 +00:00
Alexandre Poirot
5c97fb16da Bug 1615283 - Redirect old inspector "navigateTo" to the new shared helper. r=nchevobbe
As for the console, we don't really have to pass a context as we always
navigate in the foremost tab. We would need to pass a context if the tab was in background.

Differential Revision: https://phabricator.services.mozilla.com/D62807

--HG--
extra : moz-landing-system : lando
2020-02-17 16:52:34 +00:00
Julian Descottes
1be39ce29f Bug 1613773 - Merge devtools.inspector.showUserAgentShadowRoots into devtools.inspector.showAllAnonymousContent r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D61940

--HG--
extra : moz-landing-system : lando
2020-02-14 09:35:55 +00:00
Daisuke Akatsuka
df9d8b1918 Bug 1568874: Add a test for target-switching. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D60479

--HG--
extra : moz-landing-system : lando
2020-02-13 09:03:45 +00:00
Daisuke Akatsuka
5ccabc8c83 Bug 1568874: Rename and refactor some functions. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D60478

--HG--
extra : moz-landing-system : lando
2020-02-13 08:59:30 +00:00
Daisuke Akatsuka
2470f4af77 Bug 1568874: Install target-switching mechanism. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D60477

--HG--
extra : moz-landing-system : lando
2020-02-13 10:16:40 +00:00
Julian Descottes
1d5a8ef5ba Bug 1614918 - Stop waiting for synchronous removeTab method in inspector init r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D62576

--HG--
extra : moz-landing-system : lando
2020-02-12 15:00:47 +00:00
Jason Laster
897b14485f Bug 1609815 - Remove Web Replay UI. r=loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D60679

--HG--
extra : source : cfe2388a674e024d1920245e867f9982087c8164
2020-02-10 21:03:28 +00:00
Noemi Erli
85558b46c4 Backed out changeset cfe2388a674e (bug 1609815) for causing TypeError in browserContext CLOSED TREE 2020-02-11 00:35:52 +02:00
Jason Laster
f5531f3716 Bug 1609815 - Remove Web Replay UI. r=loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D60679

--HG--
extra : moz-landing-system : lando
2020-02-10 21:03:28 +00:00
Lina Refai
c27b038505 Bug 1590196 - Remove unneeded backward compatibility check hasAccessibilityProperties; r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D62192

--HG--
extra : moz-landing-system : lando
2020-02-10 13:23:12 +00:00
Razvan Caliman
051fe82571 Bug 1613960 - Remove artificial text indent from CSS declarations in Changes panel. r=pbro
For people who want to copy the plain text CSS declarations in the Changes panel, we prevent including the +/- diff signs in the selection. We did preserve the text indent. This patch removes the text indent as well.

Differential Revision: https://phabricator.services.mozilla.com/D62052

--HG--
extra : moz-landing-system : lando
2020-02-10 09:31:32 +00:00
Julian Descottes
75202c5f34 Bug 1546534 - Hide viewport size infobar when disabling page rulers r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D61480

--HG--
extra : moz-landing-system : lando
2020-02-06 10:12:10 +00:00
Jonathan Kew
f5a68f1eab Bug 1613162 - Hook up the 'slnt' and 'ital' axis sliders in the font inspector to the 'font-style' property. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D61588

--HG--
extra : moz-landing-system : lando
2020-02-05 16:53:36 +00:00
Nicolas Chevobbe
d9ff4804c3 Bug 1611682 - Fix show DOM properties. r=rcaliman.
This patch work around the fact that the `inspect` command
is used for different purpose:
- open the evaluated element in the inspector/debugger
- expand a given object in the console

In order to do that, a second parameter is added to indicate
which usage we do want.
This is not pretty, but I can't see something as straightforward
to fix this issue.
Given that there's plan to have a properties sidebar in the
inspector, it might be enough for now.

The existing test is modified to check that the object is indeed
expanded in the console.

Differential Revision: https://phabricator.services.mozilla.com/D61662

--HG--
extra : moz-landing-system : lando
2020-02-05 15:23:10 +00:00