This changes both the spellchecker parent code that interfaces with the
InlineSpellCheckerParent actor, and the child code interfacing with the
ContextMenuChild actor, to ensure they get notified when either actor
goes away.
It maintains the "uninit" messages to clear out spellcheck data when the
context menu goes away (while the window / actors remain intact).
It also adds some belts-and-suspenders type checks that allow us to
recover if we ever get in a bad state again, instead of stubbornly
throwing exceptions and breaking the UI for users.
Differential Revision: https://phabricator.services.mozilla.com/D75228
This changes both the spellchecker parent code that interfaces with the
InlineSpellCheckerParent actor, and the child code interfacing with the
ContextMenuChild actor, to ensure they get notified when either actor
goes away.
It maintains the "uninit" messages to clear out spellcheck data when the
context menu goes away (while the window / actors remain intact).
It also adds some belts-and-suspenders type checks that allow us to
recover if we ever get in a bad state again, instead of stubbornly
throwing exceptions and breaking the UI for users.
Differential Revision: https://phabricator.services.mozilla.com/D75228
This is the same preference that will power the notification suppression
option in bug 1635257, hence the preference name.
Differential Revision: https://phabricator.services.mozilla.com/D74941
This is the same preference that will power the notification suppression
option in bug 1635257, hence the preference name.
Differential Revision: https://phabricator.services.mozilla.com/D74941
The cast in InitWithNode is wrong. AsElement() asserts instead of
checking the flag, so we always pass an element (and if we didn't we'd
have type confusion problems). I audited the callers and we're fine.
Anyhow, always require an element, and add two convenience constructors
for C++ code.
Differential Revision: https://phabricator.services.mozilla.com/D73636
The cast in InitWithNode is wrong. AsElement() asserts instead of
checking the flag, so we always pass an element (and if we didn't we'd
have type confusion problems). I audited the callers and we're fine.
Anyhow, always require an element, and add two convenience constructors
for C++ code.
Differential Revision: https://phabricator.services.mozilla.com/D73636
After the recent simplifications to the zoom code, they only take care
of forwarding the enlarge / decrease zoom messages.
We can do that via PBrowser instead, and get rid of the actors. We can
also remove ZoomChangeUsingMouseWheel. Zooming with the mouse wheel will
end up in a *ZoomChange event anyways, and the only consumer already
listened for them.
Differential Revision: https://phabricator.services.mozilla.com/D73175
This shifts the responsibility for ensuring that an about:home, about:welcome
or about:newtab page is where we inject the scripts to the JSWindowActor system,
rather than using the observer service on document creation and checking the
URL.
Differential Revision: https://phabricator.services.mozilla.com/D71773
Added an async method for every nsIPromptService prompt method.
These async methods return a Promise which resolves with an nsIPropertyBag
when the prompt is closed.
Differential Revision: https://phabricator.services.mozilla.com/D67505
Added an async method for every nsIPromptService prompt method.
These async methods return a Promise which resolves with an nsIPropertyBag
when the prompt is closed.
Differential Revision: https://phabricator.services.mozilla.com/D67505
This patch introduces a new tab modal system prompt type. It can be opened via the nsIPromptService
with a destination BrowsingContext. These tab system prompts overlap slightly with the upper
chrome UI to differentiate them from content prompts (previously called tab prompts).
- Extended nsIPromptService and nsIPrompt to accept 3 types of modal prompts:
- Window prompts
- Tab (system) prompts
- Content prompts (the old tab prompts)
- Removed prompt code from Prompter.jsm, always call PromptParent window actor instead
- Added PromptChild window actor to forward pagehide events to parent actor
- Created additional prompt methods in nsIPromptService to prompt by browsingContext and modalType
- Backwards compatibility is maintained, consumers can still open content prompts calling nsIPrompt with a content window
Differential Revision: https://phabricator.services.mozilla.com/D66446
This fixes the user-facing issue. This skips the "open in window" and "open in
tab" tests because they're broken due to bug 1626573.
Differential Revision: https://phabricator.services.mozilla.com/D70937
--HG--
rename : browser/base/content/test/contextMenu/browser_canvas_view_image.js => browser/base/content/test/contextMenu/browser_view_image.js
extra : moz-landing-system : lando
