Commit Graph

24465 Commits

Author SHA1 Message Date
Martin Stransky
ff201af524 Bug 1521630 [Linux/Gtk] Use GdkEventCoordsToDevicePixels() to get mouse coordinates for mDraggableRegion.Contains(), r=ntim,TYLin
Differential Revision: https://phabricator.services.mozilla.com/D17490

--HG--
extra : moz-landing-system : lando
2019-01-24 19:29:14 +00:00
Martin Stransky
4138f8ce3b Bug 1521310 - [Linux/Gtk] Use ':' separator to place titlebar buttons left/right, r=dao
Use only ':' separator instead of 'menu:' to place titlebar buttons as the menu may not be always present.

Differential Revision: https://phabricator.services.mozilla.com/D17480

--HG--
extra : moz-landing-system : lando
2019-01-24 10:54:28 +00:00
Martin Stransky
4452be5cba Bug 1519606 - [Linux/Gtk] Compute correct margin for left titlebar buttons placement, r=dao
Depends on D17347

Differential Revision: https://phabricator.services.mozilla.com/D17351

--HG--
extra : moz-landing-system : lando
2019-01-24 09:22:30 +00:00
Martin Stransky
c9db5cb4d3 Bug 1519606 - [Linux/Gtk] Don't add margin to icon position at titlebar buttons as it's already applied at drawing, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D17347

--HG--
extra : moz-landing-system : lando
2019-01-23 16:17:26 +00:00
Sylvestre Ledru
b61d90492b Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Depends on D17388

Differential Revision: https://phabricator.services.mozilla.com/D17389

--HG--
extra : moz-landing-system : lando
2019-01-24 08:11:00 +00:00
Martin Stransky
59a8114e76 Bug 1521012 - [Linux/GNOME] Use X shape mask to draw transparent corners when we draw to titlebar, r=lsalzman
To support rounded corners of Gtk+ titlebar themes (Adwaita, Radiance..) in GNOME we need to use X shape mask
as fully transparent toplevel window causes various issues (like Bug 1516224).

We draw mShell as transparent and mContainer as non-transparent with shape mask applied. The shape mask
is generated only when titlebar rendering is enabled and it's generated from GtkHeaderBar Widget
to match the exact look.

We use existing mTransparencyBitmap for the shape mask where mTransparencyBitmapForTitlebar controls
whether it's a general shape mask or our specialised shape for titlebar only.

This is already enabled for GNOME environment by default. So there's a new preference
widget.default-hidden-titlebar added to easily disable it if any issue appears
during testing.

Differential Revision: https://phabricator.services.mozilla.com/D17283

--HG--
extra : moz-landing-system : lando
2019-01-23 12:36:25 +00:00
Sebastian Hengst
3a9f3f2226 Fix off-by-one issue from merge conflict between bug 1313429 and bug 1521460. CLOSED TREE 2019-01-23 02:50:04 +02:00
Gurzau Raul
136dc5e8bc Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-01-23 02:05:32 +02:00
Sylvestre Ledru
49f8917074 Bug 1521460 - Ride along: remove conflict r=me CLOSED TREE 2019-01-22 22:07:00 +01:00
Sylvestre Ledru
0662df7a60 Bug 1521460 - Ride along: remove useless ';' r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D17140

--HG--
extra : histedit_source : 782210d18f2acd8134436afc70cecaf6c7d92bd2
2019-01-21 18:46:21 +01:00
Sylvestre Ledru
0b4021fcad Bug 1521460 - Also reformat objective-c files r=mstange,ehsan,spohl
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D17139

--HG--
extra : histedit_source : 084f340503d2e1a2d9e1753c38b2c4ee9c7819f3
2019-01-21 18:18:16 +01:00
Harry Twyford
70df5bbf20 Bug 1313429 - Add Touch Bar functionality to Firefox r=spohl,mikedeboer,flod
Adds Touch Bar functionality to Firefox across eight commits.

Differential Revision: https://phabricator.services.mozilla.com/D5496

--HG--
extra : moz-landing-system : lando
2019-01-22 17:13:33 +00:00
Masayuki Nakano
2604235be7 Bug 1521685 - Get rid of unused GetLastError() API call in nsDataObj::GetDib() r=aosmond
nsDataObj::GetDib() calls GetLastError() API immediately after calling
GlobalAlloc() and just return E_FAIL in such case.  So, we don't need to
call it.

Differential Revision: https://phabricator.services.mozilla.com/D17214

--HG--
extra : moz-landing-system : lando
2019-01-22 11:34:20 +00:00
Sylvestre Ledru
755a1a7c2f Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D17063

--HG--
extra : moz-landing-system : lando
2019-01-21 14:49:22 +00:00
Cosmin Sabou
7ccc9d8b0b Merge mozilla-inbound to mozilla-central. a=merge 2019-01-19 11:57:49 +02:00
Tim Nguyen
60a5143df0 Bug 1241885 - Implement support for -moz-window-dragging in GTK and remove toolkit toolbar-drag binding. r=dao,bzbarsky,stransky
The restriction preventing fullscreen windows from being dragged is removed.

Differential Revision: https://phabricator.services.mozilla.com/D15075

--HG--
extra : moz-landing-system : lando
2019-01-18 22:42:24 +00:00
Andreea Pavel
95431afe85 Backed out 1 changesets (bug 1241885) for build bustages on a CLOSED TREE
Backed out changeset 176be7000d33 (bug 1241885)
2019-01-18 23:49:55 +02:00
Tim Nguyen
495df7ddea Bug 1241885 - Implement support for -moz-window-dragging in GTK and remove toolkit toolbar-drag binding. r=dao,bzbarsky,stransky
The restriction preventing fullscreen windows from being dragged is removed.

Differential Revision: https://phabricator.services.mozilla.com/D15075

--HG--
extra : moz-landing-system : lando
2019-01-18 16:51:08 +00:00
Martin Stransky
8ddc948f81 Bug 1433667 - Honour system titlebar button left/right placement, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D16466

--HG--
extra : moz-landing-system : lando
2019-01-18 13:52:29 +00:00
Markus Stange
060f074a81 Bug 1515183 - Ignore calls to viewWillDraw and drawRect on non-main threads. r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D16909

--HG--
extra : moz-landing-system : lando
2019-01-17 23:25:34 +00:00
Makoto Kato
8a1050b327 Bug 1510527 - Active composition count may be mismatched when updating composition. r=esawin
To avoid FlushIMEChanges per updating IME composition, we calculate composition count in DoReplaceText. But when using GV+e10s, this calculation is sometimes invalid since NOTIFY_IME_OF_COMPOSITION_EVENT_HANDLED event isn't received per PendingComposition.  Because, IMEStateManager will merge this completed events due to optimization of IME event.

Also, DoUpdateComposition calls SetPendingComposition, but it doesn't touch mIMEActiveCompositionCount,

So when using some IME, this value is minus or forever non-zero on some IMEs.

So we shouldn't use atomic count. When receiving NOTIFY_IME_OF_COMPOSITION_EVENT_HANDLED, we should reset it and allow IMEFlushChanges since Gecko has already handled all IME composition events in event queues.

Differential Revision: https://phabricator.services.mozilla.com/D14668

--HG--
extra : moz-landing-system : lando
2019-01-18 03:18:24 +00:00
James Willcox
269f751ce7 Bug 1514253 - Create PanZoomController immediately in GeckoSession r=geckoview-reviewers,droeh#geckoview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D14562

--HG--
extra : moz-landing-system : lando
2019-01-17 14:17:50 +00:00
Martin Stransky
53be695239 Bug 1490344 - [Linux/Gtk] Enable hidden system titlebar by default on Gnome, r=dao
This patch implements -moz-gtk-csd-hide-titlebar-by-default media query
to check if the system titlebar should be disabled by default on Linux systems
(it's already disabled on Window/Mac).

It also removes explicit definition of browser.tabs.drawInTitlebar preference on Linux.
When browser.tabs.drawInTitlebar is missing the -moz-gtk-csd-hide-titlebar-by-default
is used to obtain the titlebar state. When browser.tabs.drawInTitlebar is set
in about:config or by Customize menu, the user peference is used instead of the default.

It also fixes a -moz-gtk-csd-available media query,
it was always true regardless the actual system setting.

Differential Revision: https://phabricator.services.mozilla.com/D16036

--HG--
extra : moz-landing-system : lando
2019-01-17 12:44:49 +00:00
arthur.iakab
48fa943d27 Merge inbound to mozilla-central a=merge 2019-01-17 06:21:08 +02:00
Sebastian Hengst
3dc0a3b83a Bug 1520470 - Update metadata for related Bugzilla product and component for geckoview. r=snorp DONTBUILD
Reviewers: snorp

Tags: #secure-revision

Bug #: 1520470

Differential Revision: https://phabricator.services.mozilla.com/D16699

--HG--
extra : rebase_source : 61edc61854b0c74f492e9ee97b075a74d6efe8dd
extra : amend_source : b31c3975770475dd835f97d2272b1028c0f3e23d
2019-01-16 16:18:45 +02:00
Dragana Damjanovic
fc155bc720 Bug 1513059 - Use the minimal XPCOM for the socket process.r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D15024

--HG--
extra : moz-landing-system : lando
2019-01-16 23:05:11 +00:00
Andreea Pavel
d0b4b569af Backed out changeset aa442da7cfd8 (bug 1490344) for failing bc at browser/components/customizableui/test/browser_970511_undo_restore_default.js on a CLOSED TREE 2019-01-16 13:33:24 +02:00
Martin Stransky
0e01fab619 Bug 1490344 - [Linux/Gtk] Enable hidden system titlebar by default on Gnome, r=dao
This patch implements -moz-gtk-csd-hide-titlebar-by-default media query
to check if the system titlebar should be disabled by default on Linux systems
(it's already disabled on Window/Mac).

It also removes explicit definition of browser.tabs.drawInTitlebar preference on Linux.
When browser.tabs.drawInTitlebar is missing the -moz-gtk-csd-hide-titlebar-by-default
is used to obtain the titlebar state. When browser.tabs.drawInTitlebar is set
in about:config or by Customize menu, the user peference is used instead of the default.

It also fixes a -moz-gtk-csd-available media query,
it was always true regardless the actual system setting.

Differential Revision: https://phabricator.services.mozilla.com/D16036

--HG--
extra : moz-landing-system : lando
2019-01-15 14:47:03 +00:00
Sylvestre Ledru
47a5dd1fb8 Bug 1519636 - Reformat everything to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D16388

--HG--
extra : moz-landing-system : lando
2019-01-16 08:50:07 +00:00
Aaron Klotz
99ef8003dd Bug 1511078: Add LauncherRegistryInfo as a temporary mechanism for runtime disabling of launcher process; r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D15756

--HG--
rename : browser/app/winlauncher/NativeNt.h => mozglue/misc/NativeNt.h
rename : browser/app/winlauncher/test/TestNativeNt.cpp => mozglue/tests/TestNativeNt.cpp
rename : browser/app/winlauncher/LauncherResult.h => toolkit/xre/LauncherResult.h
extra : moz-landing-system : lando
2019-01-15 23:10:00 +00:00
Mike Conley
7e920fe573 Bug 1519893 - Add alwaysOnTop chrome-only window feature for Windows. r=aklotz
Differential Revision: https://phabricator.services.mozilla.com/D16486

--HG--
extra : moz-landing-system : lando
2019-01-15 22:29:59 +00:00
Coroiu Cristina
d263400b1c Backed out 2 changesets (bug 1511078) for build bustages at Unified_cpp_toolkit_xre0.obj
Backed out changeset 61a47d6d5e26 (bug 1511078)
Backed out changeset 006df494925a (bug 1511078)

--HG--
rename : toolkit/xre/LauncherResult.h => browser/app/winlauncher/LauncherResult.h
rename : mozglue/misc/NativeNt.h => browser/app/winlauncher/NativeNt.h
rename : mozglue/tests/TestNativeNt.cpp => browser/app/winlauncher/test/TestNativeNt.cpp
2019-01-15 23:15:50 +02:00
Aaron Klotz
64310051e7 Bug 1511078: Add LauncherRegistryInfo as a temporary mechanism for runtime disabling of launcher process; r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D15756

--HG--
rename : browser/app/winlauncher/NativeNt.h => mozglue/misc/NativeNt.h
rename : browser/app/winlauncher/test/TestNativeNt.cpp => mozglue/tests/TestNativeNt.cpp
rename : browser/app/winlauncher/LauncherResult.h => toolkit/xre/LauncherResult.h
extra : moz-landing-system : lando
2019-01-15 20:19:46 +00:00
Martin Stransky
956e93c403 Bug 1516224 - [Linux/Gtk] Disable ARGB toplevel visual on X11 SW compositor due to visible graphics artifacts, r=lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D16561

--HG--
extra : moz-landing-system : lando
2019-01-15 17:45:35 +00:00
Margareta Eliza Balazs
9dda825205 Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-01-18 12:31:59 +02:00
Ehsan Akhgari
e5e885ae31 Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
# ignore-this-changeset

--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
Ehsan Akhgari
06c3d29113 Bug 1521000 - Part 1: Reformat the tree to ensure everything is formatted correctly with clang-format r=sylvestre
Summary: # ignore-this-changeset

Reviewers: sylvestre

Reviewed By: sylvestre

Subscribers: reviewbot, emilio, jandem, bbouvier, karlt, jya

Bug #: 1521000

Differential Revision: https://phabricator.services.mozilla.com/D16936

--HG--
extra : histedit_source : 4add583bfa729ccc1aef934629ed45ff095189b0
2019-01-18 10:12:56 +01:00
Emilio Cobos Álvarez
729263c3df Bug 1511563 - Don't make NAC editable by default. r=masayuki
I think this is a more consistent fix for the issue.

Differential Revision: https://phabricator.services.mozilla.com/D16521
2019-01-15 11:52:35 +01:00
Brindusan Cristian
338aeb2777 Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-01-15 06:41:22 +02:00
Brian Grinstead
7e9d440886 Bug 1519905 - Always return false in NodeAllowsClickThrough for browser elements;r=mstange
This prevents mouse events from firing on browsers in unfocused windows. It used to be done
with the [clickthrough=never] attribute set from XBL content.

Differential Revision: https://phabricator.services.mozilla.com/D16498

--HG--
extra : moz-landing-system : lando
2019-01-14 20:42:50 +00:00
Dave Townsend
41c1ffde91 Bug 1518938: Make it possible to hide items from the application menu. r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D16107

--HG--
extra : moz-landing-system : lando
2019-01-14 18:57:49 +00:00
Martin Stransky
d704841235 Bug 1519355 - [Wayland] Produce better error message when mozilla::widget::WaylandShmPool::CreateTemporaryFile() fails, r=jhorak
Differential Revision: https://phabricator.services.mozilla.com/D16297

--HG--
extra : moz-landing-system : lando
2019-01-11 15:15:10 +00:00
Razvan Maries
642dd2cc11 Merge mozilla-central to autoland. a=merge on a CLOSED TREE 2019-01-11 17:33:16 +02:00
Christoph Kerschbaumer
6756032512 Bug 1513241: Update frontend consumers of loadURI and pass loadURIOptions dictionary. r=gijs 2019-01-11 12:44:20 +01:00
Martin Stransky
c6900f5e79 Bug 1517074 - [Linux/Gtk] Enable native (xdg-desktop based) file dialog on KDE only due to Gtk+ regression, r=jhorak
Also add widget.allow-gtk-native-file-chooser preference value to force enable on all systems.

Differential Revision: https://phabricator.services.mozilla.com/D16184

--HG--
extra : moz-landing-system : lando
2019-01-11 11:21:27 +00:00
Martin Stransky
a9e92a6023 Bug 1497002 - [Linux/CSD] Position headerbar button icons according to the actual button, r=jhorak
Differential Revision: https://phabricator.services.mozilla.com/D16193

--HG--
extra : moz-landing-system : lando
2019-01-11 11:24:06 +00:00
Kestrel
14467a827a Bug 1514715 - Update color prefs for new color IDs including -moz-win-accentcolor r=jmathies
Differential Revision: https://phabricator.services.mozilla.com/D14723

--HG--
extra : moz-landing-system : lando
2019-01-09 16:37:34 +00:00
Thomas Nguyen
a03f43622d Bug 1482659 - Purge the last sound, free then start to play a sound r=m_kato,masayuki
Because we don't know when the PlaySound API stop/finish playing. So when starting to play a sound, we should call PlaySound(0,0,PURGE) to stop playing then free the last data sound.

Differential Revision: https://phabricator.services.mozilla.com/D14554

--HG--
extra : moz-landing-system : lando
2019-01-09 12:26:46 +00:00
Adam Gashlin
22936a258f Bug 1514501 - Fix screen selection and scaling for fullscreen r=jmathies
I needed to scale the layout device pixels coming from Windows before passing them to ScreenForRect(). Also, I'm using GetRect() directly instead of GetRectDisplayPix() * scale now, to avoid an unnecessary double scale & round which was making fullscreen windows off by one pixel in many cases.

Differential Revision: https://phabricator.services.mozilla.com/D15604

--HG--
extra : moz-landing-system : lando
2019-01-09 16:35:40 +00:00
Xidorn Quan
f058e5cdbd Bug 1516068 - Fix a wrong indentation in nsNativeThemeWin. r=jmathies
Differential Revision: https://phabricator.services.mozilla.com/D15246

--HG--
extra : moz-landing-system : lando
2019-01-09 16:37:02 +00:00