Commit Graph

12424 Commits

Author SHA1 Message Date
Logan Smyth
c2150bafe9 Bug 1534328 - Update breakpoint text snippets when files load. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D24827

--HG--
extra : moz-landing-system : lando
2019-03-26 19:28:15 +00:00
David Walsh
3a59aa6b79 Bug 1538164 - [release 130] Final updates to debugger CSS. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D24776

--HG--
extra : moz-landing-system : lando
2019-03-26 18:17:53 +00:00
Anthony X
4629d8c4dd Bug 1538164 - [release 130] [Log Point] Fix log point context menu accelerator (#8115).
Differential Revision: https://phabricator.services.mozilla.com/D24775

--HG--
extra : moz-landing-system : lando
2019-03-26 15:24:55 +00:00
Tyler Wendlandt
062fce54c0 Bug 1538164 - [release 130] 8118/fix quick open modal nan bug (#8136).
Differential Revision: https://phabricator.services.mozilla.com/D24774

--HG--
extra : moz-landing-system : lando
2019-03-26 15:24:35 +00:00
chujunlu
83fa0aa6cc Bug 1538164 - [release 130] Switch watch expression's delete button (#8114).
Differential Revision: https://phabricator.services.mozilla.com/D24773

--HG--
extra : moz-landing-system : lando
2019-03-26 19:05:09 +00:00
derek-li
b22dcf6663 Bug 1538164 - [release 130] Always render footer (#8039).
Differential Revision: https://phabricator.services.mozilla.com/D24770

--HG--
extra : moz-landing-system : lando
2019-03-26 19:05:11 +00:00
renovate[bot]
e5363fdf0a Bug 1538164 - [release 130] Update dependency eslint-plugin-mozilla to v1.1.2 (#8131).
Differential Revision: https://phabricator.services.mozilla.com/D24769

--HG--
extra : moz-landing-system : lando
2019-03-26 15:23:39 +00:00
harshlele
099167ff95 Bug 1538164 - [release 130] added no sources message in Sources Pane (#7978).
Differential Revision: https://phabricator.services.mozilla.com/D24768

--HG--
extra : moz-landing-system : lando
2019-03-26 15:23:30 +00:00
Florens Verschelde
ab017673bb Bug 1538164 - [release 130] Fix #8017 - Work around unsupported inset-inline-start|end in Chrome (#8083).
Differential Revision: https://phabricator.services.mozilla.com/D24767

--HG--
extra : moz-landing-system : lando
2019-03-26 15:23:15 +00:00
Florens Verschelde
6a79c0f523 Bug 1538164 - [release 130] Use stylelint-prettier instead of stylelint formatting rules (#8098).
Differential Revision: https://phabricator.services.mozilla.com/D24766

--HG--
extra : moz-landing-system : lando
2019-03-26 15:23:01 +00:00
Florens Verschelde
773f87acef Bug 1538164 - [release 130] Fix eslint warnings in XHRBreakpoints.spec.js (#8099).
Differential Revision: https://phabricator.services.mozilla.com/D24765

--HG--
extra : moz-landing-system : lando
2019-03-26 15:22:46 +00:00
wartmanm
fed7cdaa89 Bug 1538164 - [release 130] [Sources] Improve SourcesTreeItem.mapStateToProps performance by storing plain urls (#8024).
Differential Revision: https://phabricator.services.mozilla.com/D24763

--HG--
extra : moz-landing-system : lando
2019-03-26 19:02:04 +00:00
Jonas Allmann
1db9db7604 Bug 1529231, Remove all occurences of ondialogaccept and ondialogcancel, r=Gijs
Removed all occurences of ondialogaccept.
Removed all occurences of ondialogcancel.
Replaced all removed attributes with event handlers.

Differential Revision: https://phabricator.services.mozilla.com/D21227

--HG--
extra : moz-landing-system : lando
2019-03-26 18:34:02 +00:00
Julian Descottes
84e0af7fe4 Bug 1521752 - Create jest test for aboutdebugging-new Message component;r=ladybenko
Depends on D24146
Example of a try run with tests running:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cca3978c6e3eb042c59e62b25b1946219cf3d74a&selectedJob=235873038

Differential Revision: https://phabricator.services.mozilla.com/D24721

--HG--
rename : devtools/client/framework/test/jest/.eslintrc.js => devtools/client/aboutdebugging-new/test/jest/.eslintrc.js
rename : devtools/client/framework/test/jest/README.md => devtools/client/aboutdebugging-new/test/jest/README.md
rename : devtools/client/framework/test/jest/jest.config.js => devtools/client/aboutdebugging-new/test/jest/jest.config.js
rename : devtools/client/framework/test/jest/package.json => devtools/client/aboutdebugging-new/test/jest/package.json
extra : moz-landing-system : lando
2019-03-26 17:16:41 +00:00
Julian Descottes
344ba632d2 Bug 1521752 - Add jest test for framework component DebugTargetInfo;r=ladybenko
This is more of a feedback request, I have not really written component unit tests before.

Differential Revision: https://phabricator.services.mozilla.com/D24145

--HG--
extra : moz-landing-system : lando
2019-03-26 16:38:48 +00:00
Jason Laster
25d855c4ff Bug 1534368 - breakpoint positions should be filtered by source. r=loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D24289

--HG--
extra : moz-landing-system : lando
2019-03-26 15:12:22 +00:00
Mellina Yonashiro
2fbf0a347e Bug 1536005 - Merge Tabs.css and TabBar.css into Tabs.css r=fvsch
Differential Revision: https://phabricator.services.mozilla.com/D24663

--HG--
extra : moz-landing-system : lando
2019-03-26 13:19:35 +00:00
Belén Albeza
c3820a59f4 Bug 1505125 - UX implementation of the Sidebar. r=jdescottes,daisuke,Ola,flod
Differential Revision: https://phabricator.services.mozilla.com/D24419

--HG--
extra : moz-landing-system : lando
2019-03-26 12:38:48 +00:00
Dhruvi Butti
805db1b032 Bug 1512400 - Make console autocomplete optional. r=nchevobbe.
Add a preference to make the console input autocomplete automatic.
If set to false, the autocomplete popup will only appear on Ctrl+Space.
A test is added to ensure this works as expected.

Differential Revision: https://phabricator.services.mozilla.com/D24705

--HG--
extra : moz-landing-system : lando
2019-03-26 07:13:15 +00:00
Julian Descottes
aa6b2752d1 Bug 1528781 - Hide tabs for This Firefox behind a preference;r=Ola,daisuke
Differential Revision: https://phabricator.services.mozilla.com/D24378

--HG--
extra : moz-landing-system : lando
2019-03-25 16:09:57 +00:00
Brindusan Cristian
8d646b09cd Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-03-26 02:28:46 +02:00
Brindusan Cristian
c4f15a4dae Merge inbound to mozilla-central. a=merge 2019-03-26 02:26:12 +02:00
Noemi Erli
676cfa3d56 Backed out changeset d0b9b3883584 (bug 1534786) for failures in browser_dbg-old-breakpoint.js 2019-03-25 19:25:13 +02:00
Patrick Brosset
d6270ca25d Bug 1538676 - Hide the auto-expanded overridden longhands when value is empty; r=gl
Differential Revision: https://phabricator.services.mozilla.com/D24690

--HG--
extra : moz-landing-system : lando
2019-03-25 13:56:20 +00:00
Florens Verschelde
9d9c19e064 Bug 1537724 - Make text selection visible in TreeView inputs; r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D24375

--HG--
extra : moz-landing-system : lando
2019-03-25 12:24:54 +00:00
Julian Descottes
9fc4dd6f7a Bug 1528912 - Do not stop ADB when closing aboutdebugging or webide;r=daisuke
It looks like we don't need to stop ADB. Most of the logic can stay, in order to start and stop the devices polling.

Differential Revision: https://phabricator.services.mozilla.com/D24398

--HG--
extra : moz-landing-system : lando
2019-03-25 08:05:18 +00:00
Botond Ballo
c1ca1c7e5f Bug 1536755 - Fix eslint trailing-comma failures. r=apavel
Differential Revision: https://phabricator.services.mozilla.com/D24660

--HG--
extra : moz-landing-system : lando
2019-03-25 03:37:00 +00:00
Daisuke Akatsuka
aee3333051 Bug 1536682: Add a test for special CSS color. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D24127

--HG--
extra : moz-landing-system : lando
2019-03-25 03:03:34 +00:00
Daisuke Akatsuka
2d87871070 Bug 1536682: Handle special CSS color within animation inspector. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D24125

--HG--
extra : moz-landing-system : lando
2019-03-25 03:06:43 +00:00
Brad Werth
65d87a00fb Bug 1536755 Part 2: Add a test of meta viewport fixed width and zoom. r=botond
Differential Revision: https://phabricator.services.mozilla.com/D24456

--HG--
rename : devtools/client/responsive.html/test/browser/browser_viewport_resizing.js => devtools/client/responsive.html/test/browser/browser_viewport_resizing_fixed_width.js
extra : moz-landing-system : lando
2019-03-22 21:01:48 +00:00
sakshaat
d781937a67 Bug 1517483 - Get rid of nsIScriptSecurityManager::IsSystemPrincipal r=bzbarsky
Replaced instances of callers in both C++ and JS files to query the state from the principal directly.

Differential Revision: https://phabricator.services.mozilla.com/D22532

--HG--
extra : moz-landing-system : lando
2019-03-24 20:36:25 +00:00
Michael Ratcliffe
639bed7bb2 Bug 1509620 - Computed style inspector CSS cascade calculation is wrong r=ladybenko
### Try

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1bad5e5282812225da95c0ea9e2ef173640b5da

### Summary

!!Comparing numerous complex websites such as github, facebook, cnn etc. the cascade now matchers that of Chrome so we are in a much better place.!!

According to https://www.w3.org/TR/css-cascade-3/#cascading (which platform follows now) and https://www.w3.org/TR/css-cascade-4/#cascading we should now be doing this (descending order):

  - Transition declarations
  - User-Agent & !important
  - User & !important
  - Author & !important
  - CSS Animations, @keyframes
  - Author, normal weight
  - User, normal weight
  - User-Agent, normal weight
  - specificity
  - Sheet Index
  - Rule Line
  - Rule Column

We are only dealing with CSS selectors here so we can safely drop Transition declarations and CSS Animations because their presence here is irrelevant when it comes to the CSS cascade information we display in the computed view.

This leaves us with:

  - User-Agent & !important
  - User & !important
  - Author & !important
  - Author, normal weight
  - User, normal weight
  - User-Agent, normal weight
  - specificity
  - Sheet Index
  - Rule Line
  - Rule Column

### Changes

- References to content stylesheets have been changed to author stylesheet to closely match the technical terms author, user and agent stylesheets.
- Simplified and modernized a bunch of for loops to make the code easier to understand.
- Previous to these changes all matching parent rules were classed as equal e.g. color on the body tag was equal to color on a node's immediate container. We now use the `distance` variable to tell how close a rule is to the current node. This is the highest qualifier in our cascade calculation.
- The `_agentSheet`, `_authorSheet` and `_userSheet` properties are now used to obtain a sheets origin.
- `elementStyle` was renamed to `inlineStyle` in order to correctly identify the rule's origin.
- We used to sort the matchedSelectors to move rules with `STATUS.MATCHED` above `STATUS.PARENT_MATCH` but this is unnecessary now that we have the `distance` property so we no longer do this.
- The `compareTo()` method has been updated to match https://www.w3.org/TR/css-cascade-3/#cascading (which platform follows now) and https://www.w3.org/TR/css-cascade-4/#cascading. It has also been simplified and made far less prone to error.

Differential Revision: https://phabricator.services.mozilla.com/D23711

--HG--
extra : moz-landing-system : lando
2019-03-25 16:32:19 +00:00
arthur.iakab
1ab45e3251 Merge mozilla-central to mozilla-inbound 2019-03-25 17:57:57 +02:00
Philipp Kewisch
52aa5b978e Bug 1507709 - Move WebExtensions geckoProfiler API to toolkit. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D12100

--HG--
rename : browser/components/extensions/ProfilerGetSymbols-worker.js => toolkit/components/extensions/ProfilerGetSymbols-worker.js
rename : browser/components/extensions/ProfilerGetSymbols.jsm => toolkit/components/extensions/ProfilerGetSymbols.jsm
rename : browser/components/extensions/parent/ext-geckoProfiler.js => toolkit/components/extensions/parent/ext-geckoProfiler.js
rename : browser/components/extensions/profiler_get_symbols.js => toolkit/components/extensions/profiler_get_symbols.js
rename : browser/components/extensions/schemas/geckoProfiler.json => toolkit/components/extensions/schemas/geckoProfiler.json
rename : browser/components/extensions/test/xpcshell/test_ext_geckoProfiler_control.js => toolkit/components/extensions/test/xpcshell/test_ext_geckoProfiler_control.js
rename : browser/components/extensions/test/xpcshell/test_ext_geckoProfiler_schema.js => toolkit/components/extensions/test/xpcshell/test_ext_geckoProfiler_schema.js
extra : moz-landing-system : lando
2019-03-22 13:18:01 +00:00
Helena Moreno
0274f5667c Bug 1538153 - Fix RTL alignment in RequestList headers and align Storage table headers with Netmonitor r=fvsch
Differential Revision: https://phabricator.services.mozilla.com/D24508

--HG--
extra : moz-landing-system : lando
2019-03-22 18:55:02 +00:00
Cosmin Sabou
520c7a9423 Backed out 2 changesets (bug 1535246) for devtools failures on devtools/client/debugger/new/test/mochitest/browser_dbg-html-breakpoints.js. CLOSED TREE
Backed out changeset 5860aac31563 (bug 1535246)
Backed out changeset 5929d34ee923 (bug 1535246)

--HG--
extra : rebase_source : 3aac58ce35404488259bd778b4a9d78bca706ae8
2019-03-23 03:28:05 +02:00
Logan Smyth
505e03b918 Bug 1535246 - Part 2: Handle new actors appearing in HTML files. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D24444

--HG--
extra : moz-landing-system : lando
2019-03-22 21:04:47 +00:00
Logan Smyth
55e99d992a Bug 1535246 - Part 1: Ensure that changes to emptyLines are handled for both additions and removals. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D24443

--HG--
extra : moz-landing-system : lando
2019-03-22 18:49:09 +00:00
arthur.iakab
ca7277b3cc Backed out changeset 75634ae8f7c5 (bug 1537657) for causing debugger failures CLOSED TREE 2019-03-23 01:28:27 +02:00
David Walsh
dd65f15097 Bug 1537596 - Make shift-click toggle all breakpoint states per line r=loganfsmyth
Implements a function to enable or disable all breakpoints on a line based on shift-clicking. Uses the first breakpoint's state to decide whether to enable or disable all.

Differential Revision: https://phabricator.services.mozilla.com/D24524

--HG--
extra : moz-landing-system : lando
2019-03-22 19:43:41 +00:00
Brian Hackett
81e54c6f8e Bug 1537657 - Detach from workers when navigating, r=loganfsmyth.
Differential Revision: https://phabricator.services.mozilla.com/D24434

--HG--
extra : moz-landing-system : lando
2019-03-21 22:06:14 +00:00
Julian Descottes
fda43987c4 Bug 1537877 - Update getDocumentWalker to fallback to non-anonymous walker;r=pbro
Except for rawParentNode, all consumers of getDocumentWalker should be ok with this fallback.

Differential Revision: https://phabricator.services.mozilla.com/D24414

--HG--
extra : moz-landing-system : lando
2019-03-22 19:43:08 +00:00
Florens Verschelde
952b28e95a Bug 1537721 - Style Storage table inputs to take the same space as table cells; r=miker
Differential Revision: https://phabricator.services.mozilla.com/D24482

--HG--
extra : moz-landing-system : lando
2019-03-22 13:46:17 +00:00
fanny
d84598c487 Bug 1115363 - Implement copy text option on sidebar of storage. r=miker
Before this change, there was no option to copy text of an attribute in
sidebar of storage.You can now copy an attribute and it's text.

Differential Revision: https://phabricator.services.mozilla.com/D23977

--HG--
extra : moz-landing-system : lando
2019-03-22 13:26:42 +00:00
Michael Ratcliffe
3f627acfe1 Bug 1536819 - Fix node.offsetParent is null error in Rule View r=gl
The editing of selectors in the rule view is broken (see https://bugzil.la/1536867) but that is not related to this issue.

Differential Revision: https://phabricator.services.mozilla.com/D24210

--HG--
extra : moz-landing-system : lando
2019-03-22 12:28:09 +00:00
Patrick Brosset
c53da4bcc7 Bug 1535315 - Hide computed expander when computed properties are undefined; r=gl
Differential Revision: https://phabricator.services.mozilla.com/D24364

--HG--
extra : moz-landing-system : lando
2019-03-22 02:06:46 +00:00
Ciure Andrei
1c183ba62d Backed out changeset a1c5e97960d0 (bug 1537596) for causing debugger test perma failure CLOSED TREE 2019-03-22 10:49:49 +02:00
David Walsh
29407aeed7 Bug 1537596 - Make shift-click toggle all breakpoint states per line r=loganfsmyth
Implements a function to enable or disable all breakpoints on a line based on shift-clicking.  Uses the first breakpoint's state to decide whether to enable or disable all.

Differential Revision: https://phabricator.services.mozilla.com/D24440

--HG--
extra : moz-landing-system : lando
2019-03-21 22:16:13 +00:00
David Walsh
a871cb609e Bug 1537949 - Remove animation from threads list r=loganfsmyth
Normally this is a good first bug but since we're trying to move quickly before 67, I took it.

Differential Revision: https://phabricator.services.mozilla.com/D24402

--HG--
extra : moz-landing-system : lando
2019-03-21 20:13:23 +00:00
Mellina Yonashiro
6127d37dae Bug 1534499 - Wait for hiding both shortName and name when remove USB runtime in tests r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D23763

--HG--
extra : moz-landing-system : lando
2019-03-21 23:05:08 +00:00