Eitan Isaacson
6ac35e15fc
Bug 1714390 - P7: Add custom de/serializer for AccAttributes. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D116788
2021-06-10 23:07:07 +00:00
Eitan Isaacson
349592fb91
Bug 1714390 - P6: Make more attribute keys static atoms. r=Jamie
...
Keys should be static atoms whenever possible.
Differential Revision: https://phabricator.services.mozilla.com/D116787
2021-06-10 23:07:07 +00:00
Eitan Isaacson
4fc2c36ea8
Bug 1714390 - P5: Use static aria_* atoms for aria attributes. r=Jamie
...
ATK, Windows and XPCOM expect aria attribute keys to be stripped of
their aria- prefix. We should still store the item using the aria_ atom
and then strip the prefix when converting the key to a string.
Differential Revision: https://phabricator.services.mozilla.com/D116786
2021-06-10 23:07:07 +00:00
Eitan Isaacson
474a197205
Bug 1714390 - P4: Set non-string values in AccAttributes when possible. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D116785
2021-06-10 23:07:06 +00:00
Eitan Isaacson
62d0cdcad4
Bug 1714390 - P2: Use AccAttributes for accessible and text attributes. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D116783
2021-06-10 23:07:05 +00:00
Morgan Reschenberg
5e6ca85357
Bug 1710751: Create LINKS_TO relation to track anchors and their corresponding elements r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D115841
2021-05-26 21:31:42 +00:00
Noemi Erli
6401ad3ad0
Backed out changeset f8b8dd8a7814 (bug 1710751) for causing windows build bustages CLOSED TREE
2021-05-26 02:23:23 +03:00
Morgan Reschenberg
bef9fad1db
Bug 1710751: Create LINKS_TO relation to track anchors and their corresponding elements r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D115841
2021-05-25 23:06:42 +00:00
Morgan Reschenberg
7bc169515a
Bug 1710748: Return button menus when form controls are queried from rotor r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D115429
2021-05-24 17:02:46 +00:00
Morgan Reschenberg
288a4006cf
Bug 1710742: Modify VO checkbox search key to work with quick nav r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D115430
2021-05-24 17:02:31 +00:00
Eitan Isaacson
564dc6d059
Bug 1710867 - P2: Don't leak MOXSearchInfo. r=morgan
...
Also need to have MOXSearchInfo have an owning reference of mSearchKeys.
Depends on D115273
Differential Revision: https://phabricator.services.mozilla.com/D115274
2021-05-17 22:35:39 +00:00
Eitan Isaacson
9293cb7fee
Bug 1710867 - P1: Add returned containers to autorelease pool. r=morgan
...
When we return a container, like an NSArray of MOXAccessible children the container needs
to be added to the autorelease pool so that it is released and so are its members.
Differential Revision: https://phabricator.services.mozilla.com/D115273
2021-05-17 22:35:39 +00:00
Eitan Isaacson
c4d0e38f83
Bug 1706910 - Don't expose MOXAccessible with represented view to AppKit. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D114797
2021-05-13 15:59:18 +00:00
Morgan Reschenberg
7c9fb4df94
Bug 1710493: Implement AXFrame for VoiceOver r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D113585
2021-05-10 21:32:19 +00:00
Morgan Reschenberg
80ccd5b8b1
Bug 1708522: Remove MOZ_CRASHREPORTER from windows, log AccClient on mac. r=Jamie
...
This commit adds crash logging for AccessibilityClient on MacOS and
enables that logging on windows by removing the defunct MOZ_CRASHREPORTER
defines. On MacOS, we also introduce logging for SwitchControl and
unknown clients.
Differential Revision: https://phabricator.services.mozilla.com/D114167
2021-05-10 20:22:32 +00:00
Noemi Erli
a2bfb965fd
Backed out changeset 362b8272eab4 (bug 1708522) for causing build bustage in Platform.mm CLOSED TREE
2021-05-10 22:55:44 +03:00
Morgan Reschenberg
de405c1e9c
Bug 1708522: Remove MOZ_CRASHREPORTER from windows, log AccClient on mac. r=Jamie
...
This commit adds crash logging for AccessibilityClient on MacOS and
enables that logging on windows by removing the defunct MOZ_CRASHREPORTER
defines. On MacOS, we also introduce logging for SwitchControl and
unknown clients.
Differential Revision: https://phabricator.services.mozilla.com/D114167
2021-05-10 19:07:10 +00:00
Iulian Moraru
1e02685f75
Backed out 2 changesets (bug 1706910) for accessibility crashes. CLOSED TREE
...
Backed out changeset e0769fe4d6fd (bug 1706910)
Backed out changeset 67c05979577e (bug 1706910)
2021-05-05 18:50:58 +03:00
Morgan Reschenberg
ab5a074a02
Bug 1706910: Implement AXFrame, accessibilityFrame for VoiceOver r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D113585
2021-05-03 23:21:31 +00:00
Simon Giesecke
485ec92560
Bug 708901 - Migrate to nsTHashSet in accessible. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D108589
2021-03-23 10:36:32 +00:00
Christian M. Macy
a0adf7ccba
Bug 1633570 - Add setter for AXValue (incrementables only) r=morgan
...
This commit adds an AXValue setter to incremental accessibles, as well
as tests to validate that setter on both a range and number input.
Differential Revision: https://phabricator.services.mozilla.com/D106333
2021-03-16 16:17:53 +00:00
Simon Giesecke
ad01a10a3b
Bug 1634281
- Use nsTHashMap instead of nsDataHashtable. r=xpcom-reviewers,necko-reviewers,jgilbert,nika,valentin
...
Note that this patch only transforms the use of the nsDataHashtable type alias
to a directly equivalent use of nsTHashMap. It does not change the specification
of the hash key type to make use of the key class deduction that nsTHashMap
allows for in some cases. That can be done in a separate step, but requires more
attention.
Differential Revision: https://phabricator.services.mozilla.com/D106008
2021-03-10 10:47:47 +00:00
Eitan Isaacson
d6fb8b1903
Bug 1694566 - P2: Make EWhichChildAtPoint an enum class and put it in Accessible. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D106678
2021-03-03 06:10:01 +00:00
Eitan Isaacson
bafd5e712b
Bug 1694203
- P9: Have RemoteAccessible inherit from Accessible. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D104915
2021-03-02 16:32:24 +00:00
Simon Giesecke
9af107a839
Bug 1691913 - Rename nsBaseHashtable::Put to InsertOrUpdate. r=xpcom-reviewers,necko-reviewers,jgilbert,dragana,nika
...
This makes the naming more consistent with other functions called
Insert and/or Update. Also, it removes the ambiguity whether
Put expects that an entry already exists or not, in particular because
it differed from nsTHashtable::PutEntry in that regard.
Differential Revision: https://phabricator.services.mozilla.com/D105473
2021-02-26 09:11:46 +00:00
Masayuki Nakano
ef2253b4a1
Bug 1691622 - part 9: Make nsIWidget::SynthesizeNativeMouseEvent
take an XP button ID and abstract message value r=smaug,geckoview-reviewers,agi,m_kato
...
Currently, it takes a raw native message value, but it makes JS content too
complicated. And on Linux, it cannot synthesize non-primary button events
because GDK has only button press and release messages which dont' include
mouse button information.
For solving these problems, this patch creates a new abstract native message
as `nsIWidget::NativeMouseMessage` and makes each widget converts it to
a platform native message.
Additionally, this patch adds an argument to make it possible its callers
to specify pressing or releasing mouse button with a DOM mouse button value.
Note that the following patch adds new argument to
`synthesizeNativeEventMouse*` for mochitests and which will be tested by
new tests.
Differential Revision: https://phabricator.services.mozilla.com/D105763
2021-02-24 01:27:10 +00:00
Masayuki Nakano
b63882dde8
Bug 1691622 - part 4: Make synthesizeNativeMouseClick*()
aware of modifiers r=smaug,geckoview-reviewers,m_kato
...
Surprisingly, they don't take modifiers, and
`nsIWidget::SynthesizeNativeMouseEvent()` which are implementations of
`nsIDOMWindowUtils::SendNativeMouseEvent()` treat given modifier flags
are native's ones, and handle modifiers only on macOS. Therefore, this
patch makes them handle native modifiers of Gecko.
Unfortunately, I'm not so familiar with Android API, and in the short
term, I don't need the support on Android. Therefore, this patch just
adds a TODO comment on Android widget.
Additionally, we don't have a simple way to set modifier only while
posting a mouse input on Windows too. It requires complicated code.
Therefore, I don't add the support for it on Windows too.
Differential Revision: https://phabricator.services.mozilla.com/D105758
2021-02-24 01:27:07 +00:00
Eitan Isaacson
6e8749d0da
Bug 1693597 - P2: Rename ProxyAccessible to RemoteAccessible. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D105671
2021-02-19 23:14:33 +00:00
Eitan Isaacson
6e49732365
Bug 1693597 - P1: Rename Accessible to LocalAccessible. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D105670
2021-02-19 23:14:32 +00:00
Markus Stange
355baf5b39
Bug 1692391 - Rename NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK macros, replacing ABORT with IGNORE. These macros just log the exception and move on, without aborting. r=haik
...
This patch was generated automatically, using the following commands:
```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK/NS_OBJC_BEGIN_TRY_IGNORE_BLOCK/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK/NS_OBJC_END_TRY_IGNORE_BLOCK/g'
```
Differential Revision: https://phabricator.services.mozilla.com/D104960
2021-02-16 22:55:21 +00:00
Markus Stange
9bc888af4a
Bug 1692391 - Replace NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NIL with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(nil). r=haik
...
This patch was generated automatically, using the following commands:
```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NIL' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NIL/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_NIL' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_NIL/NS_OBJC_END_TRY_BLOCK_RETURN(nil)/g'
```
Differential Revision: https://phabricator.services.mozilla.com/D104959
2021-02-16 22:55:21 +00:00
Markus Stange
56051da2d0
Bug 1692391 - Replace the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NSRESULT macros with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE). r=haik
...
This patch was generated with the commands:
```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_NSRESULT' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_NSRESULT/NS_OBJC_END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE)/g'
```
Differential Revision: https://phabricator.services.mozilla.com/D104957
2021-02-16 22:55:20 +00:00
Markus Stange
5257db6695
Bug 1692391 - Remove the word ABORT from the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_RETURN macros, because these macros don't abort. r=haik,necko-reviewers
...
This patch was generated automatically with the commands below:
```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_RETURN' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_RETURN/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_RETURN' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_RETURN/NS_OBJC_END_TRY_BLOCK_RETURN/g'
```
Differential Revision: https://phabricator.services.mozilla.com/D104955
2021-02-16 22:55:20 +00:00
Sylvestre Ledru
4fe9680965
no bug - Remove a pylint warning - variable 'text' is unused r=mstange DONTBUILD
...
Depends on D105299
Differential Revision: https://phabricator.services.mozilla.com/D105300
2021-02-16 21:10:33 +00:00
Eitan Isaacson
ff59e176e4
Bug 1692523 - P2: Prefix remote heirarchy functions with 'Remote'. r=Jamie
...
Parent -> RemoteParent
ChildAt -> RemoteChildAt
FirstChild -> RemoteFirstChild
LastChild -> RemoteLastChild
NextSibling -> RemoteNextSibling
PrevSibling -> RemotePrevSibling
Differential Revision: https://phabricator.services.mozilla.com/D105035
2021-02-16 20:05:11 +00:00
Eitan Isaacson
8c842a59e3
Bug 1692523 - P1: Prefix local heirarchy functions with 'Local'. r=Jamie
...
Parent -> LocalParent
GetChildAt -> LocalChildAt
FirstChild -> LocalFirstChild
LastChild -> LocalLastChild
NextSibling -> LocalNextSibling
PrevSibling -> LocalPrevSibling
Differential Revision: https://phabricator.services.mozilla.com/D105034
2021-02-16 20:05:10 +00:00
Morgan Reschenberg
1fe81c2358
Bug 1691502: Don't attempt to invalidate table cache on outlines r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D104432
2021-02-10 18:29:36 +00:00
Eitan Isaacson
49dfc2e434
Bug 1691831 - Clamp offsets to character count in HyperTextIterator. r=morgan
...
I tried to come up with a good test for this, that reproduces the issue in a demonstratable way, but couldn't.
Differential Revision: https://phabricator.services.mozilla.com/D104586
2021-02-10 06:58:40 +00:00
Eitan Isaacson
0a92b9e380
Bug 1690342 - P5: Use AXTextArea for multiline aria text boxes. r=morgan DONTBUILD
...
Now that we have attribtued text we don't need to advertise rich text editables as AXTextField.
Differential Revision: https://phabricator.services.mozilla.com/D103803
2021-02-08 23:26:49 +00:00
Eitan Isaacson
cb03a1923c
Bug 1690342 - P4: Implement IPC attributed text getter. r=morgan DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D103802
2021-02-08 23:26:47 +00:00
Eitan Isaacson
e6912635e0
Bug 1690342 - P2: Populate NSAttributedText attributes with attributes. r=morgan DONTBUILD
...
A followup patch will make this work in e10s. This current implementation is non-ipc.
Differential Revision: https://phabricator.services.mozilla.com/D103800
2021-02-08 23:26:31 +00:00
Eitan Isaacson
84896a7a88
Bug 1690342 - P1: Introduce moxAncestorSearch for finding ancestors. r=morgan DONTBUILD
...
It looks like we need to do this often. Adding it to the protocol/base class allows
us to not have to worry each time about typing and traversing past MOX accessibles.
Differential Revision: https://phabricator.services.mozilla.com/D103799
2021-02-08 23:26:24 +00:00
Morgan Reschenberg
b6cdc22e2b
Bug 1680840: Introduce table style changed event to mac platform, update caching r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D103698
2021-02-04 20:50:12 +00:00
Morgan Reschenberg
ced0045bea
Bug 1688490: Make GetNativeFromGeckoAccessible null-safe r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D103813
2021-02-04 19:41:30 +00:00
Morgan Reschenberg
6b8df6efbe
Bug 1686744
: Fire AXMenuItemSelected notification when menu item is pressed r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D103954
2021-02-04 19:41:37 +00:00
Morgan Reschenberg
62aed9ef20
Bug 1688730: Cache table layout status on mac, invalidate on reorder, attr changed r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D102994
2021-02-02 21:30:58 +00:00
Butkovits Atila
2af3edc6b9
Backed out 2 changesets (bug 1688730) for causing mochitest failures. CLOSED TREE
...
Backed out changeset 677c17ec48ea (bug 1688730)
Backed out changeset a7d0770117c8 (bug 1688730)
2021-02-02 02:04:28 +02:00
Morgan Reschenberg
876affb062
Bug 1688730: Cache table layout status on mac, invalidate on reorder, attr changed r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D102994
2021-02-01 20:23:23 +00:00
Butkovits Atila
e13215fdec
Backed out 2 changesets (bug 1688730) for causing build bustage on mozTableAccessible.mm. CLOSED TREE
...
Backed out changeset bd6d78d36cee (bug 1688730)
Backed out changeset dd03939b850e (bug 1688730)
2021-02-01 21:44:02 +02:00
Morgan Reschenberg
3b5f7255b1
Bug 1688730: Cache table layout status on mac, invalidate on reorder, attr changed r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D102994
2021-02-01 17:54:13 +00:00