Commit Graph

19630 Commits

Author SHA1 Message Date
Christoph Kerschbaumer
0df81cd9f4 Bug 1490874: Log Principal based Security Errors to the Security pane in the console. r=smaug 2018-09-24 09:34:04 +02:00
Rob Wu
f8161bc611 Bug 1393570 - Set allowInheritPrincipal=false by default r=Gijs,glandium
This change prevents javascript:-URLs from being passed at the command
line. This restriction was already applied to every URL but the first.
Even the first URL did not result in any visible effect when Firefox is
started. Yet somehow the PGO profiler script managed to rely on it.

This commit ensures that "javascript:" URLs are not activated regardless of
position in the command line, and switches to a data:-URL for the PGO script to
achieve the (previously) desired effect of quitting the browser on startup.

Depends on D4929

Differential Revision: https://phabricator.services.mozilla.com/D5958

--HG--
extra : moz-landing-system : lando
2018-09-18 11:54:44 +00:00
Rob Wu
6a8bd50325 Bug 1393570 - Support cookieStoreId in windows.create extension API r=Gijs,rpl
Other (internal API) changes besides extension API changes:

- This also introduces support for opening a window with multiple tabs
  in a non-default container tab.

- This also adds LOAD_FLAGS_DISALLOW_INHERIT_PRINCIPAL to the
  gBrowser.loadTabs call, unless allowInheritPrincipal is set.
  For backwards-compatibility, this flag defaults to true.

Depends on D4928

Differential Revision: https://phabricator.services.mozilla.com/D4929

--HG--
extra : moz-landing-system : lando
2018-09-19 10:57:48 +00:00
Dao Gottwald
ab68e55ad5 Bug 1493412 - "Remove warning-64.png on Windows" r=ntim 2018-09-22 06:29:00 +03:00
Dragana Damjanovic
9cadc84486 Bug 1473736 - Implement necko part of ESNI r=mak,kmag,mcmanus
--HG--
extra : rebase_source : be79870960953ef9535ccb6a440515ec4a8232d5
extra : histedit_source : 8096ab2eaf246cbbeb97bace0531b86b8c69ff66
2018-09-22 23:54:11 +03:00
matthias
4b4c66672d Bug 1461010 - Changed second sentence of Safe Mode dialogue. r=paolo,flod
--HG--
extra : rebase_source : e4cd59d1e100c505add67cacbbfd33d9fe73f5b0
2018-09-22 16:58:05 +01:00
Preeti Mukherjee
86d9e6106e Bug 1492419 - Remove BrowserGoHome in favor of BrowserHome; r=dao
Differential Revision: https://phabricator.services.mozilla.com/D6484

--HG--
extra : moz-landing-system : lando
2018-09-21 12:31:45 +00:00
Johann Hofmann
9dff99cb01 Bug 1492576 - If no protection is enabled, don't offer the user the ability to disable protection or report a problem. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D6408

--HG--
extra : moz-landing-system : lando
2018-09-21 01:45:19 +00:00
Gurzau Raul
07d30b811f Backed out changeset dc225279994a (bug 1473736) for web platform leaks 2018-09-21 04:30:10 +03:00
Dana Keeler
984d5aecee bug 1492424 - check if the TLS handshake failed in nsSecureBrowserUIImpl r=Gijs
The site identity security indicator machinery treats connections where the TLS
handshake failed as insecure (also referred to as "unknown identity"). Before
bug 1468222, such cases were easily detectable as the SSLStatus field of the
relevant nsITransportSecurityInfo would be null. When we merged nsISSLStatus
into nsITransportSecurityInfo, we didn't take this differentiation into account.
This patch brings back the prior behavior by checking if the securityInfo's
securityState indicates that the handshake failed (i.e. it is
STATE_IS_INSECURE).

Differential Revision: https://phabricator.services.mozilla.com/D6316

--HG--
extra : moz-landing-system : lando
2018-09-21 00:17:47 +00:00
Drew Willcoxon
99c3aedb47 Bug 1485987 - Make urlbar.search() fire an input event. r=mak
`urlbar.search` needs to simulate the user's typing. Fire an input event, as we do elsewhere to simulate it.

Differential Revision: https://phabricator.services.mozilla.com/D6215

--HG--
extra : moz-landing-system : lando
2018-09-20 23:05:33 +00:00
Dragana Damjanovic
70e0646d75 Bug 1473736 - Implement necko part of ESNI r=mak,kmag,mcmanus
Implement necko part of ESNI

Differential Revision: https://phabricator.services.mozilla.com/D2716

--HG--
extra : moz-landing-system : lando
2018-09-20 20:53:28 +00:00
Gurzau Raul
f399af546d Backed out changeset e7665879a630 (bug 1492424) for failing at siteIdentity/browser_tls_handshake_failure.js on a CLOSED TREE 2018-09-21 00:55:16 +03:00
Dana Keeler
109a4a35aa bug 1492424 - check if the TLS handshake failed in nsSecureBrowserUIImpl r=Gijs
The site identity security indicator machinery treats connections where the TLS
handshake failed as insecure (also referred to as "unknown identity"). Before
bug 1468222, such cases were easily detectable as the SSLStatus field of the
relevant nsITransportSecurityInfo would be null. When we merged nsISSLStatus
into nsITransportSecurityInfo, we didn't take this differentiation into account.
This patch brings back the prior behavior by checking if the securityInfo's
securityState indicates that the handshake failed (i.e. it is
STATE_IS_INSECURE).

Differential Revision: https://phabricator.services.mozilla.com/D6316

--HG--
extra : moz-landing-system : lando
2018-09-20 20:57:38 +00:00
Mike Conley
eb269e3d6e Bug 1491906 - Add async mode to tabpanels binding. r=NeilDeakin
We need this because the AsyncTabSwitcher is responsible for switching between the
remote browser tab panels asynchronously. Asynchronous mode for the tabpanels
binding delegates the responsibility of actually changing the index of the
underlying deck to someone else (AsyncTabSwitcher, in this case).

Differential Revision: https://phabricator.services.mozilla.com/D6184

--HG--
extra : moz-landing-system : lando
2018-09-20 15:57:33 +00:00
Gijs Kruitbosch
ae7f88b657 Bug 1492782 - modernize a few tests and reduce CPOW usage in browser/base/content/test/general/, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D6375

--HG--
extra : moz-landing-system : lando
2018-09-20 14:17:32 +00:00
Gijs Kruitbosch
38496797c8 Bug 1492186 - make browser_pageinfo_images.js more reliable, r=florian
Differential Revision: https://phabricator.services.mozilla.com/D6323

--HG--
extra : moz-landing-system : lando
2018-09-20 13:51:56 +00:00
Mark Banner
b890fde6ec Bug 1491253 - Link the UrlbarController with the input and the view. r=dao
This links together the controller with the input and view. It moves the fake results generation to the controller. As a result, there is now an input -> controller -> view round-trip in place.

Also hooks up the input with determining if we're in private browsing mode or not.

Differential Revision: https://phabricator.services.mozilla.com/D6261

--HG--
extra : moz-landing-system : lando
2018-09-20 13:07:18 +00:00
Coroiu Cristina
2e3f6d7d15 Backed out changeset 261d22d6d396 (bug 1491253) for browser-chrome failures at browser/base/content/test/static/browser_all_files_referenced.js on a CLOSED TREE 2018-09-20 14:22:58 +03:00
Mark Banner
c562a56e7d Bug 1491253 - Link the UrlbarController with the input and the view. r=dao
This links together the controller with the input and view. It moves the fake results generation to the controller. As a result, there is now an input -> controller -> view round-trip in place.

Also hooks up the input with determining if we're in private browsing mode or not.

Differential Revision: https://phabricator.services.mozilla.com/D6261

--HG--
extra : moz-landing-system : lando
2018-09-20 10:11:47 +00:00
Luca Greco
e834e90cb2 Bug 1433335 - Send telemetry events for each AddonManager action on an extension. r=aswan
- Added definitions for the new telemetry events
- Send telemetry events for each AddonManager action on an extension.
- Ensure that telemetry events are sent also for the extension prompts.

Differential Revision: https://phabricator.services.mozilla.com/D4448

--HG--
extra : moz-landing-system : lando
2018-09-19 16:43:11 +00:00
Markus Staab
4f43e01fbb Bug 1491786 - Access selectedItem only once in _notifyBackgroundTab. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D6321

--HG--
extra : moz-landing-system : lando
2018-09-20 08:39:48 +00:00
Johann Hofmann
b74353b1a7 Bug 1492175 - Add a pref for hiding the global content blocking toggle. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D6157

--HG--
extra : moz-landing-system : lando
2018-09-20 05:54:39 +00:00
Bogdan Tara
86023d88c4 Merge inbound to mozilla-central. a=merge 2018-09-20 07:13:05 +03:00
Bogdan Tara
9f17cab93a Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-09-20 01:03:35 +03:00
Bogdan Tara
e7c653959c Merge inbound to mozilla-central. a=merge 2018-09-20 00:58:18 +03:00
Markus Staab
974dcd94f6 Bug 1491784 - Access selectedItem only once in _handleTabSelect. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D6287

--HG--
extra : moz-landing-system : lando
2018-09-19 18:19:33 +00:00
Dão Gottwald
7f4690bc57 Bug 1492417 - Remove Browser:Home command. r=paolo 2018-09-19 12:47:29 +02:00
Dana Keeler
d13840ed4c bug 1490982 - filter out OnLocationChange events that aren't top-level in nsSecureBrowserUIImpl r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D5920

--HG--
extra : moz-landing-system : lando
2018-09-19 19:57:37 +00:00
Jonathan Kingston
555f89c8d7 Bug 1485305 - browser/ tests Ensure loadURI always passes a triggeringPrincipal() r=Mossop
Differential Revision: https://phabricator.services.mozilla.com/D4552

--HG--
extra : source : 2cf17e4974823d09d0fdd1aef64e69e840b288a1
extra : intermediate-source : 4771e6948a78507aa95a56e5b324d87dc82e9009
2018-08-29 15:44:56 +01:00
Jonathan Kingston
82cf4833c8 Bug 1485305 - browser/ Ensure loadURI always passes a triggeringPrincipal() r=Mossop
Differential Revision: https://phabricator.services.mozilla.com/D4551

--HG--
extra : source : 2b7baed037199f16100d13e0057a5d1054fca14c
extra : intermediate-source : 091677bcef226cc780c0d60f34754e1cd8de8974
2018-08-29 15:43:27 +01:00
Brindusan Cristian
1db0587c0e Backed out 10 changesets (bug 1485305) for browser-chrome failures on docshell/test/browser/browser_loadURI.js. CLOSED TREE
Backed out changeset 50439ec01661 (bug 1485305)
Backed out changeset a05e40ef7215 (bug 1485305)
Backed out changeset c99b97b4348b (bug 1485305)
Backed out changeset 75220b2f6669 (bug 1485305)
Backed out changeset e698f2fc1c1a (bug 1485305)
Backed out changeset acce14683c13 (bug 1485305)
Backed out changeset 323773a395cc (bug 1485305)
Backed out changeset 1b74152cabc1 (bug 1485305)
Backed out changeset 4b5c9d5929fc (bug 1485305)
Backed out changeset 238d92348159 (bug 1485305)
2018-09-19 18:47:27 +03:00
Jonathan Kingston
f57a3dbfb5 Bug 1485305 - browser/ tests Ensure loadURI always passes a triggeringPrincipal() r=Mossop
Differential Revision: https://phabricator.services.mozilla.com/D4552

--HG--
extra : source : 2cf17e4974823d09d0fdd1aef64e69e840b288a1
2018-08-29 15:44:56 +01:00
Jonathan Kingston
10c02f08ca Bug 1485305 - browser/ Ensure loadURI always passes a triggeringPrincipal() r=Mossop
Differential Revision: https://phabricator.services.mozilla.com/D4551

--HG--
extra : source : 2b7baed037199f16100d13e0057a5d1054fca14c
2018-08-29 15:43:27 +01:00
Kris Maglione
1c20e8cbbb Bug 1486147: Part 2 - Update JS string enumerator callers to use JS iteration. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D4270

--HG--
extra : rebase_source : 2adadcc8e51a7bce1da02f4bee1333b77bfa9944
extra : histedit_source : 9df920fd186f8c96a5d8b9cbff53ea9529f26ee0
2018-08-24 16:22:40 -07:00
Emma Malysz
696ceb303f Bug 1465219, use XULMenuElement, a subclass of nsXULElement, instead of MenuBoxObject for menu and menulist elements, r=paolo,bz
MozReview-Commit-ID: 5253hAlxbhw

--HG--
rename : dom/webidl/MenuBoxObject.webidl => dom/chrome-webidl/XULMenuElement.webidl
rename : layout/xul/MenuBoxObject.cpp => dom/xul/XULMenuElement.cpp
rename : layout/xul/MenuBoxObject.h => dom/xul/XULMenuElement.h
2018-07-31 12:30:17 -07:00
Gijs Kruitbosch
a7981b4051 Bug 1492179 - make browser_bug767836_perwindowpb.js not use CPOWs, and use modern async test tools instead of callbacks, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D6160

--HG--
extra : moz-landing-system : lando
2018-09-18 17:29:13 +00:00
Margareta Eliza Balazs
1b004c7ba6 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-09-18 17:37:08 +03:00
Margareta Eliza Balazs
fdb780335d Merge inbound to mozilla-central. a=merge 2018-09-18 17:33:09 +03:00
Tim Nguyen
25e0092647 Bug 1485830 - Set custom odd tree row colors in common.css on all platforms. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D5963

--HG--
extra : moz-landing-system : lando
2018-09-18 13:22:49 +00:00
Dão Gottwald
7f7823a6d9 Bug 1485629 - Disable the early blank window when using a non-default theme. r=florian 2018-09-18 10:29:37 +02:00
Gijs Kruitbosch
6b518d3722 Bug 1491243 - remove subscribe button, menu items and subscription section out of feed previews, r=florian
This removes subscribe UI and functionality from the main browser window,
the page info window, and from feed previews. It may leave some stray strings
in subscribe.properties/dtd, which will be removed in bug 1477669 when the
preview code goes away completely.

Differential Revision: https://phabricator.services.mozilla.com/D5982

--HG--
extra : moz-landing-system : lando
2018-09-18 06:06:27 +00:00
James Teh
6b89ed218b Bug 1331755: Refactor handling of accessibility focus in the URL bar so focus never moves to suggestions while the user is editing. r=Gijs,MarcoZ
When the user is editing the text in the URL bar (typing, backspace, etc.), the first suggestion is always selected.
Because accessibility clients require autocomplete items to be "focused", the code needs to differentiate between explicit selection (e.g. via down/up arrow) and auto selection (e.g. when typing).
Otherwise, the focus continually moves away from the text box while the user is typing, as was previously occurring.
This makes it very difficult for the user to edit text, particularly backspace/delete.

There was a previous attempt to handle this, but it was somewhat fragile and broke completely some time ago.
Now, rather than trying to handle this based on autocomplete events, it is handled in the input and key press events.
For input events, accessibility focus is forced back to the text box and further accessibility focus events are suppressed.
For down arrow, up arrow, etc. key presses, accessibility focus events for suggestions are enabled.
This makes it easier to understand and predict the user experience, rather than relying on underlying autocomplete implementation details.

This is tested using an accessibility browser test, which makes it easier to make assertions about accessibility focus.
This also means that if the underlying implementation details change (e.g. HTML + aria-activedescendant instead of XUL + DOMMenuItemActive events), this test should still be valid and allow us to catch regressions.

Differential Revision: https://phabricator.services.mozilla.com/D5987

--HG--
extra : moz-landing-system : lando
2018-09-18 05:10:35 +00:00
Coroiu Cristina
9a2b88d99e Backed out changeset d61965849528 (bug 1491243) for en-US failures at testing\firefox-ui\tests\puppeteer\test_page_info_window.py 2018-09-17 22:23:58 +03:00
Gijs Kruitbosch
1b1f1b759d Bug 1491243 - remove subscribe button, menu items and subscription section out of feed previews, r=florian
This removes subscribe UI and functionality from the main browser window,
the page info window, and from feed previews. It may leave some stray strings
in subscribe.properties/dtd, which will be removed in bug 1477669 when the
preview code goes away completely.

Differential Revision: https://phabricator.services.mozilla.com/D5982

--HG--
extra : moz-landing-system : lando
2018-09-17 18:06:05 +00:00
Robert Strong
b406194e75 Bug 1358342 - Remove the aushelper system add-on. r=florian
The aushelper add-on is being removed and this test needs the minimum number of values in extensions.getAddons.cache.enabled lowered so it passes

Differential Revision: https://phabricator.services.mozilla.com/D5892

--HG--
extra : moz-landing-system : lando
2018-09-14 23:44:37 +00:00
Arshad Kazmi
79c60b26c5 Bug 1457784 - Replace warning-16.png with warning.svg. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D5973

--HG--
extra : moz-landing-system : lando
2018-09-17 09:55:12 +00:00
Tim Nguyen
cd0933861f Bug 1441837 - Remove unused --in-content-category-text-active variable. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D5966

--HG--
extra : moz-landing-system : lando
2018-09-16 05:23:03 +00:00
championshuttler
4f987e0e84 Bug 1491536 - Remove obsolete footer image CSS. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D5960

--HG--
extra : moz-landing-system : lando
2018-09-15 20:52:02 +00:00
Dorel Luca
e3d505cb98 Merge mozilla-central to autoland 2018-09-15 12:48:28 +03:00