Commit Graph

119 Commits

Author SHA1 Message Date
Daniel Holbert
1ac2adcf94 bug 522779: use nsTArray::Contains() instead of checking nsTArray::IndexOf() against various sentinel values, in three places in layout. r=dbaron 2009-10-16 15:49:30 -07:00
Bobby Holley
86dd317584 Bug 435296 - Decode-On-Draw. r=joe,roc,bz,dolske,peterw sr=vlad 2009-09-12 16:44:18 -06:00
Zack Weinberg
d47e0f433b Bug 497495 part 3: Add methods to every nsFrame subclass that expose the as-allocated identity of every frame object. Also some cleanups to the QueryFrame implementation. r=dbaron sr=roc 2009-09-12 17:49:24 +01:00
Bobby Holley
4275f152b5 Bug 507902 - nsImageFrame static Icon Loads should not use the mListener of the first instantiated nsImageFrame.r=bz,joe 2009-08-12 16:23:38 +02:00
Joe Drew
2aa59235f2 Bug 753 - Remove nsIImage, gfxIImageFrame, and their implementations, and expose an equivalent api on imgIContainer. r=roc,josh,bz,longsonr,vlad,karlt,jimm,bsmedberg,mfinkle,peterw,peterv sr=vlad,roc
--HG--
rename : gfx/src/shared/gfxImageFrame.cpp => modules/libpr0n/src/imgFrame.cpp
rename : gfx/src/shared/gfxImageFrame.h => modules/libpr0n/src/imgFrame.h
2009-07-20 18:50:15 -07:00
L. David Baron
b3135c89bc Remove some unused AddRef/Release methods on frame classes. (Bug 488774) r+sr=roc 2009-04-22 10:13:48 -07:00
L. David Baron
63217d7258 Invalidate the correct area when loading an image for which we've displayed the loading-image icon. (Bug 409870) r+sr=bzbarsky r=roc 2009-02-06 08:52:13 -08:00
Jeremy Lea
ce80f69254 Bug 448830. Make nsIntRect/nsIntMargin/nsIntSize/nsIntPoint different types from nsRect/nsMargin/nsSize/nsPoint different types for better compile-type unit checking. r+sr=roc
--HG--
extra : rebase_source : a331a9e49fbc5931f546919281fcca7f008ab615
2009-01-15 16:27:09 +13:00
Benjamin Smedberg
3498a5f86e Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.

--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
73a6fab34b Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
802d1a10c7 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
Joe Drew
b6eec2ca8e Bug 393936 - nsIRequest::cancel() must not notify anything sync. Make removal from the loadgroup async, and add another call cancelAndForgetObserver() that removes the listener immediately (since some callsites expect that). Note, however, that this new method shouldn't be used in any new code; it exists only to support code that relied on the broken behaviour prior to this checkin. r=bzbarsky sr=vlad 2008-12-19 17:35:50 -05:00
Robert Sayre
665787ada2 Backout JOEDREW! patches for bug 89419 and bug 393936. Looks like they make mochitest leak. 2008-12-11 01:27:58 -08:00
Joe Drew
75a9cd7d92 Bug 393936 - nsIRequest::cancel() must not notify anything sync. Make removal from the loadgroup async, and add another call cancelAndForgetObserver() that removes the listener immediately (since some callsites expect that). Note, however, that this new method shouldn't be used in any new code; it exists only to support code that relied on the broken behaviour prior to this checkin. r=bzbarsky sr=vlad 2008-12-10 16:25:34 -08:00
reed@reedloden.com
0a89edbe84 Bug 368554 - "[quirks] Image inside table inside table-cell with small width is wrapped" [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r+sr=roc a=blocking1.9+] 2007-12-03 01:24:49 -08:00
peterv@propagandism.org
f7ff5666a6 Fix for bug 386496 (Clicking on link in designMode document does follow that link now). r/sr=bz. 2007-07-11 06:05:05 -07:00
dbaron@dbaron.org
0235059d11 Implement correct intrinsic width calculation (for container) for elements with specified height properties and an intrinsic ratio. b=364066 r+sr=bzbarsky 2007-06-12 11:27:09 -07:00
dbaron%dbaron.org
405d600298 When drawing images, track full source and dest regions (unclipped) or use floats, to avoid rounding problems with advanced image resizing algorithms. b=371434 r=vlad r+sr=roc 2007-03-20 00:58:20 +00:00
dbaron%dbaron.org
9d7f938b99 Clean up IsFrameOfType methods to call their base class IsFrameOfType methods reliably. b=341326 r+sr=roc 2007-02-24 18:33:33 +00:00
asqueella%gmail.com
e70812ddff bug 370371 - remove nsIImageControlFrame, have the frame set the last clicked point as a property on its mContent instead.
r+sr=roc
2007-02-18 16:49:54 +00:00
dbaron%dbaron.org
31f1898810 Bug 300030: Move intrinsic width computation out of nsIFrame::Reflow and into its own methods on nsIFrame. Replace reflow reasons, types, and commands with dirty bits/notifications. Thanks to bzbarsky for almost all of the HTML form controls (mozilla/layout/forms) changes, and many others for help testing and patching. For detailed commit logs, see REFLOW_YYYYMMDD_BRANCH, where YYYYMMDD is one of 20061031, 20060830, 20060603, 20060302, 20060119, 20051011, 20050804, 20050429, 20050315, 20050111, and 20041213. 2006-12-08 05:38:33 +00:00
roc+%cs.cmu.edu
899128e82a Bug 343445. Change inline reflow strategy to avoid looking ahead through words while measuring text. r+sr=dbaron 2006-10-19 01:47:47 +00:00
smontagu%smontagu.org
6330067fc1 Bidi support for alternate text: reorder the text correctly, align text and icon to the right when direction is right-to-left, and create a bidi embedding when the alternate text is displayed inline. Bug 345954, r=uriber, sr=bzbarsky 2006-07-31 07:08:45 +00:00
dbaron%dbaron.org
8ade31392b Implement a stub imgIDecoderObserver to save code size in content and layout. b=339612 r+sr=sicking 2006-06-16 21:07:47 +00:00
roc+%cs.cmu.edu
a7f03736a9 Bug 328926. Remove aPresContext parameter from nsIFrame::Destroy, nsIFrame::SetInitialChildList and nsIFrame::RemovedAsPrimaryFrame. patch by Marc Liddell, r+sr=roc 2006-04-10 00:16:29 +00:00
dbaron%dbaron.org
0e88f73bc6 Single line comments to describe files (helpful in LXR) 2006-03-29 18:29:03 +00:00
roc+%cs.cmu.edu
0a10a79f62 Bug 330934. Set a nsIFrame's stylecontext in its constructor, to ensure that there's always one available for GetPresContext() to use even if Init hasn't been called. Patch by Marc Liddell, r+sr=roc 2006-03-26 21:30:36 +00:00
pavlov%pavlov.net
131e8794e2 backing out roc's patch for bug 328926 due to crash running tests on vc8 machines. 2006-03-15 06:43:36 +00:00
roc+%cs.cmu.edu
557b089a47 Bug 328926. Remove aPresContext parameter from Destroy and SetInitialChildList. patch by Marc Liddell, r+sr=roc 2006-03-15 03:14:02 +00:00
roc+%cs.cmu.edu
c2801ebbd7 Bug 328926. Remove aPresContext from nsIFrame::Init and nsIFrame::DidSetStyleContext. r+sr=roc, patch by Marc Liddell 2006-03-09 18:55:21 +00:00
bzbarsky%mit.edu
263cf7dc11 Push up GetPrincipal to nsINode (as GetNodePrincipal). This way all nsINodes
(content, documents, attr nodes) can return their principal as needed.
Eliminate lazy allocation of principals in nsDocument.  Bug 324600, r=sicking, sr=jst
2006-02-02 20:02:34 +00:00
roc+%cs.cmu.edu
77bca74243 Bug 317375. Reorganize frame painting and mouse event targeting around frame display lists. Some review from dbaron, lots of testing help from Martijn, Julien and others 2006-01-26 02:29:17 +00:00
bzbarsky%mit.edu
608088a431 Implement :-moz-broken, :-moz-user-disabled, and :-moz-suppressed
pseudo-classes to allow styling of broken/blocked/disabled images, applets,
objects, embeds.  Bug 11011, r=biesi and roc, sr=dbaron
2005-09-18 18:05:40 +00:00
bzbarsky%mit.edu
cf64715ae5 Remove the pointless nsIContent arg of nsIFrame::AttributeChanged. Bug 281390,
patch by Vidar Braut Haarr <vhaarr+bmo@gmail.com>, r+sr=bzbarsky
2005-09-07 16:49:21 +00:00
roc+%cs.cmu.edu
f246fa2bbd Bug 280987. Remove aPresContext from nsIFrameDebug::List. r+sr=roc, patch by Vidar Braut Harr. 2005-09-06 21:34:50 +00:00
cbiesinger%web.de
87c0b991cd 293384 implement nsImageFrame::GetFrameName for easier debugging
r+sr=bz a=asa
2005-05-09 17:46:06 +00:00
bzbarsky%mit.edu
e3aebd9c61 Use the content policy REJECT reason as a basis for our "whether to show alt
text" decision instead of reading prefs ourselves.  Bug 202906, r=mvl, sr=jst
2005-03-02 04:05:12 +00:00
bugzilla%arlen.demon.co.uk
3d7261604c Bug 270708 remove nsPresContext variable from AttributeChanged and cleaned up comment in nsIFrame.h
p=bugmail@q1n.org r=pkwarren sr=bzbarsky
2004-12-31 01:13:27 +00:00
cbiesinger%web.de
b71e2a3790 38447 layout,content,dom and xpwidget part: Implement Handling of URI Values on
CSS "cursor" Properties
for dom,layout,content: r+sr=bz
for widget: r+sr=roc
2004-12-30 21:56:11 +00:00
bmlk%gmx.de
d3197a9276 remove unused prescontext argument from GetOffsetFromView bug 276015 r/sr=dbaron 2004-12-26 19:48:54 +00:00
bryner%brianryner.com
2f0f78bbcb Extend invalidated region by one source row in each direction so that we fully cover the rows in a scaled image which may be drawn using a given source row. This fixes the "white lines" problem with scaled images (bug 222901). r=pavlov, sr=tor. 2004-08-28 23:59:15 +00:00
bryner%brianryner.com
5c02a6978c Change nsIPresContext to nsPresContext globally, follow-up to bug 253470. rs=roc 2004-07-31 23:15:21 +00:00
jst%mozilla.jstenback.com
77c4322ab2 Fixing bug 240543. Hiding some nsIPref* API bloatyness in nsContentUtils. r=caillon@aillon.org, sr=peterv@propagandism.org 2004-04-29 23:34:19 +00:00
gerv%gerv.net
708b56cff4 Bug 236613: change to MPL/LGPL/GPL tri-license. 2004-04-18 14:30:37 +00:00
dbaron%dbaron.org
5b6ae6e571 Rename {nsIDocument,nsIDocumentObserver,nsIFrame}::ContentChanged to CharacterDataChanged, since that's the only thing it's used for. Replace its nsISupports* parameter with a PRBool, since we don't need to allocate an object to pass a boolean parameter. Remove some (but probably not all) unneeded implementations on frames whose content is never a text node. b=234960 r+sr=jst 2004-02-20 21:38:31 +00:00
cbiesinger%web.de
f0051dc721 Bug 233587 small nsImageFrame cleanup - use nsILink to get a link href.
r+sr=bzbarsky
2004-02-10 16:57:00 +00:00
dbaron%dbaron.org
e04ab52cda Clean up code related to broken / loading image icons and make it observe pref changes. b=180620 r+sr=bzbarsky 2004-02-03 20:30:02 +00:00
bryner%brianryner.com
ef5c330583 Continuing nsIPresContext deCOMtamination (bug 229371). Remove GetImageLoadFlags (unused). Make failure to fetch the LookAndFeel service cause Init() to fail, don't null check it after that, and inlined the getter. Move IOService caching to nsImageFrame, the only user of it. r+sr=bzbarsky. 2004-01-21 09:35:59 +00:00
uid502
d81619b4fa Bug 190735. DeCOMtaminate nsIFrame::GetFrameType. r+sr=bzbarsky 2003-10-31 20:19:18 +00:00
dbaron%dbaron.org
d85698fd40 Remove hint parameter from AttributeChanged methods and simplify style hint mechanism. b=211308 r+sr=bzbarsky 2003-07-11 21:16:12 +00:00