Commit Graph

1035 Commits

Author SHA1 Message Date
Andrew Halberstadt
f72360bce1 Bug 1580280 - [lint] Support Python 3 in the eslint integration r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45438

--HG--
extra : moz-landing-system : lando
2019-09-11 19:52:08 +00:00
Andrew Halberstadt
5b5dc5542a Bug 1580280 - [lint] Support Python 3 in the flake8 integration r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D45436

--HG--
extra : moz-landing-system : lando
2019-09-11 10:00:58 +00:00
Tarek Ziadé
5dd9d5bcd0 Bug 1562870 - generate conditioned profiles r=gbrown,bc,aerickson
Generates "conditioned" profiles.

Differential Revision: https://phabricator.services.mozilla.com/D38211

--HG--
extra : moz-landing-system : lando
2019-09-16 19:44:35 +00:00
Cosmin Sabou
d0f1b2cacf Backed out changeset d8091d350d7c (bug 1579845) for linting opt failures on foobar.js. CLOSED TREE 2019-09-16 19:56:01 +03:00
Sylvestre Ledru
601dddbceb Bug 1579845 - Add a test to the mozlint check: license r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D45873

--HG--
extra : moz-landing-system : lando
2019-09-16 16:19:55 +00:00
arthur.iakab
5b17baab22 Backed out changeset f698c4b34515 (bug 1579845) for causing lint failure on foobar.js CLOSED TREE 2019-09-16 18:16:35 +03:00
Sylvestre Ledru
31eae04236 Bug 1579845 - Add a test to the mozlint check: license r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D45873

--HG--
extra : moz-landing-system : lando
2019-09-16 14:06:21 +00:00
Sylvestre Ledru
d55c5ff35a Bug 1581065 - Update to codespell 1.16 r=andi
Depends on D45818

Differential Revision: https://phabricator.services.mozilla.com/D45819

--HG--
extra : moz-landing-system : lando
2019-09-13 11:31:49 +00:00
Edwin Takahashi
c481d253a3 Bug 1559975 - remove tools/profiler from python2 and python3 linter exclusion list r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D36435

--HG--
extra : moz-landing-system : lando
2019-09-13 09:04:26 +00:00
Sylvestre Ledru
6963a42813 Bug 1579845 - ride along: Strip codespell results r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D45449

--HG--
extra : moz-landing-system : lando
2019-09-12 07:01:46 +00:00
Sylvestre Ledru
e613c24777 Bug 1579845 - Ride along: Add the line number in the file whitespace lint r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D45447

--HG--
extra : moz-landing-system : lando
2019-09-12 07:01:50 +00:00
Sylvestre Ledru
d20870ad98 Bug 1579845 - Add a test to the mozlint check: file-whitespace r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D45445

--HG--
extra : moz-landing-system : lando
2019-09-11 20:59:32 +00:00
Sylvestre Ledru
e3b92571a9 Bug 1579845 - Add a test to the mozlint check: file-perm r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D45444

--HG--
extra : moz-landing-system : lando
2019-09-11 20:58:07 +00:00
Edwin Takahashi
485156be18 Bug 1559975 - fix python2 and python3 linter errors for client.py r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D40523

--HG--
extra : moz-landing-system : lando
2019-09-11 21:06:34 +00:00
Sylvestre Ledru
4675edcd33 Bug 1577726 - Reorder tools/rewriting/ThirdPartyPaths.txt r=andi
Depends on D45158

Differential Revision: https://phabricator.services.mozilla.com/D45160

--HG--
extra : moz-landing-system : lando
2019-09-09 08:33:43 +00:00
Sylvestre Ledru
20b343675a Bug 1577726 - Move generated directories into a dedicated file (Generated.txt) from ThirdPartyPaths.txt r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D44147

--HG--
extra : moz-landing-system : lando
2019-09-05 14:24:21 +00:00
Andrew Halberstadt
7945602d9f Bug 1577826 - [eslint] Ensure setup runs subprocess with byte strings in env r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D44482

--HG--
extra : moz-landing-system : lando
2019-09-04 23:50:26 +00:00
Kershaw Chang
64b7f325a6 Bug 1577428 - Not allow nsICertOverrideService to be implemented in js r=keeler,ato
Differential Revision: https://phabricator.services.mozilla.com/D43931

--HG--
rename : security/manager/ssl/tests/unit/test_js_cert_override_service.js => security/manager/ssl/tests/unit/test_allow_all_cert_errors.js
extra : moz-landing-system : lando
2019-09-04 17:17:44 +00:00
Barret Rennie
1ab6ec337d Bug 1563090 - Add a visual metrics treeherder task r=nalexander,tomprince
This new task fetches the visualmetrics.py script from the
github.com/mozilla/browsertime repository and runs it in parallel for the
specified jobs. Jobs are specified in a JSON blob passed through to the task in
an environment variable. A follow up patch specifies a command line argument to
make this configuration available to `./mach try {fuzzy|chooser}`

Differential Revision: https://phabricator.services.mozilla.com/D41052

--HG--
extra : moz-landing-system : lando
2019-09-04 16:42:31 +00:00
Narcis Beleuzu
3fca079bae Backed out 2 changesets (bug 1563090) for Linting failure on run-visual-metrics.py . CLOSED TREE
Backed out changeset 1b2389663474 (bug 1563090)
Backed out changeset 9071c90b2e84 (bug 1563090)
2019-09-04 19:03:58 +03:00
Barret Rennie
df8c6f79f1 Bug 1563090 - Add a visual metrics treeherder task r=nalexander,tomprince
This new task fetches the visualmetrics.py script from the
github.com/mozilla/browsertime repository and runs it in parallel for the
specified jobs. Jobs are specified in a JSON blob passed through to the task in
an environment variable. A follow up patch specifies a command line argument to
make this configuration available to `./mach try {fuzzy|chooser}`

Differential Revision: https://phabricator.services.mozilla.com/D41052

--HG--
extra : moz-landing-system : lando
2019-09-03 22:05:26 +00:00
Sylvestre Ledru
4203206dd6 Bug 1578673 - [mozlint] Skip the file-perm linter on Windows r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D44635

--HG--
extra : moz-landing-system : lando
2019-09-04 13:06:29 +00:00
monikamaheshwari
836c33084c Bug 1578190 - Add a rule to ensure 'if(foo.length)' instead of 'foo.length>0'. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D33011

--HG--
extra : moz-landing-system : lando
2019-09-02 11:09:44 +00:00
Andrew Halberstadt
6e07bc64e5 Bug 1570772 - [lint.license] Exclude pre-existing license errors r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D41822

--HG--
extra : moz-landing-system : lando
2019-08-30 15:44:31 +00:00
Andrew Halberstadt
5729dfad82 Bug 1570772 - [lint.license] Exclude errors under /devtools r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D41821

--HG--
extra : moz-landing-system : lando
2019-08-30 15:44:22 +00:00
Andrew Halberstadt
f43a6e3051 Bug 1570772 - [lint.license] Fix or exclude errors under /build r=firefox-build-system-reviewers,mshal
Differential Revision: https://phabricator.services.mozilla.com/D41820

--HG--
extra : moz-landing-system : lando
2019-08-30 15:44:08 +00:00
Andrew Halberstadt
5ce2bf9eab Bug 1576988 - [docs] Remove 'Indices and tables' section from doc trees, r=Standard8
The main motivation here is to get these subsections out of the main index.
While changing the heading to an 'h2' or lower would suffice, I opted to remove
them entirely. I did this because the links in this section is for the overall
global documentation. E.g, the "Indices and tables" section under /tools/lint,
has nothing to do with linting.

It is still possible to access the index and search page from the root:
https://firefox-source-docs.mozilla.org/#indices-and-tables

Differential Revision: https://phabricator.services.mozilla.com/D43653

--HG--
extra : moz-landing-system : lando
2019-08-28 12:38:49 +00:00
Sylvestre Ledru
71f8303be7 Bug 1575250 - Add a lint to check for trailing white spaces and windows line return r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D42675

--HG--
extra : moz-landing-system : lando
2019-08-27 21:42:18 +00:00
Sylvestre Ledru
dd6d6fa34e Bug 1575249 - Add a lint to check for source file permissions r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D42672

--HG--
extra : moz-landing-system : lando
2019-08-27 21:07:08 +00:00
Mark Banner
676f82a489 Bug 1540982 - Upgrade to ESLint 6.2.2 and switch to ECMA version 11 (BigInt support, Dynamic imports). r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D43590

--HG--
extra : moz-landing-system : lando
2019-08-27 14:51:29 +00:00
Andrew Swan
d697e6aa9a Bug 1567258 - Convert fxmonitor to a built-in component r=nhnt11,flod
Differential Revision: https://phabricator.services.mozilla.com/D40666

--HG--
rename : browser/extensions/fxmonitor/privileged/api.js => browser/components/fxmonitor/FirefoxMonitor.jsm
rename : browser/extensions/fxmonitor/privileged/FirefoxMonitor.css => browser/components/fxmonitor/content/FirefoxMonitor.css
rename : browser/extensions/fxmonitor/assets/monitor32.svg => browser/components/fxmonitor/content/monitor32.svg
rename : browser/extensions/fxmonitor/moz.build => browser/components/fxmonitor/moz.build
rename : browser/extensions/fxmonitor/test/browser/browser.ini => browser/components/fxmonitor/test/browser/browser.ini
rename : browser/extensions/fxmonitor/test/browser/browser_fxmonitor_doorhanger.js => browser/components/fxmonitor/test/browser/browser_fxmonitor_doorhanger.js
rename : browser/extensions/fxmonitor/locales/en-US/fxmonitor.properties => browser/locales/en-US/chrome/browser/fxmonitor.properties
extra : moz-landing-system : lando
2019-08-23 14:27:55 +00:00
Mark Banner
b3bdf13476 Bug 1551829 - Limit exectution scope of the spidermonkey-js processor to only the directories where it is required. r=mossop
This helps ensure that when running `--fix` across the entire tree, all places that can be are fixed correctly.

Differential Revision: https://phabricator.services.mozilla.com/D37272

--HG--
extra : moz-landing-system : lando
2019-08-21 19:09:27 +00:00
Mark Banner
a05a7163d5 Bug 1551829 - Upgrade to ESLint 6.1.0. r=mossop
This picks up various improvements, especially to how configurations are handled and some new rules.

Differential Revision: https://phabricator.services.mozilla.com/D37271

--HG--
extra : moz-landing-system : lando
2019-08-21 19:08:44 +00:00
Mark Banner
f11175d51e Bug 1551829 - Make eslint-plugin-mozilla compatible with ESLint 6. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D37270

--HG--
extra : moz-landing-system : lando
2019-08-21 19:10:16 +00:00
championshuttler
9316d7c7ca Bug 1569472 - Enable RST linter for browser/docs/ and tools/tryselect/docs/. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D41991

--HG--
extra : moz-landing-system : lando
2019-08-16 20:05:58 +00:00
Henrik Skupin
0529daadd3 Bug 1573406 - Remove every trace of Firefox UI update tests. r=webdriver-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D41834

--HG--
extra : moz-landing-system : lando
2019-08-14 11:08:45 +00:00
Andrew Halberstadt
773c593e22 Bug 1570772 - [lint] Add the root 'node_modules' to the GLOBAL_EXCLUDES list, r=sylvestre
Depends on D41755

Differential Revision: https://phabricator.services.mozilla.com/D41756

--HG--
extra : moz-landing-system : lando
2019-08-13 13:45:46 +00:00
Andrew Halberstadt
64fa3bdb48 Bug 1570772 - [lint] Don't enforce licenses in empty files, r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D41755

--HG--
extra : moz-landing-system : lando
2019-08-13 13:45:06 +00:00
Nick Alexander
8e0d872e6e Bug 1542004 - Add android-javadoc lint. r=agi
This also applies the error listener just to the Javadoc tasks
(previously, it applied to the `apiGenerate*` tasks as well, 'cuz they
inherit from `Javadoc`).

Differential Revision: https://phabricator.services.mozilla.com/D41634

--HG--
extra : moz-landing-system : lando
2019-08-13 01:45:03 +00:00
Brendan Dahl
b474db77c6 Bug 1551344 - Part 1: Remove XULDocument code. r=smaug,Jamie
All .xul files have been loading as HTMLDocuments for a few weeks now, so
it should be safe to remove the XULDocument implementation.

Differential Revision: https://phabricator.services.mozilla.com/D41238

--HG--
extra : moz-landing-system : lando
2019-08-09 19:57:50 +00:00
Axel Hecht
d3cf6d2c83 Bug 1571671 - Enable RST linting on fluent docs in intl/l10n/docs. r=championshuttler
Differential Revision: https://phabricator.services.mozilla.com/D40831

--HG--
extra : moz-landing-system : lando
2019-08-09 19:20:59 +00:00
Erica Wright
cafcffa6a9 Bug 1557050 - Add basic telemetry to protection report. r=mtigley,johannh
Differential Revision: https://phabricator.services.mozilla.com/D39750

--HG--
extra : moz-landing-system : lando
2019-08-08 18:53:41 +00:00
Agi Sferro
d5d199cc40 Bug 1571492 - Add apiLint command in api_changes lint errors. r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D41140

--HG--
extra : moz-landing-system : lando
2019-08-08 04:05:10 +00:00
Jared Wein
7ddc91c1db Bug 1571567 - Enable the no-fallthrough eslint rule. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D40744

--HG--
extra : moz-landing-system : lando
2019-08-08 15:18:51 +00:00
Bogdan Tara
844afcfb06 Backed out 10 changesets (bug 1571567) complementary backout after es lint failure on the patch CLOSED TREE
Backed out changeset ce83fa75ae32 (bug 1571567)
Backed out changeset 7aa97ba7cce9 (bug 1571567)
Backed out changeset 777d79076e99 (bug 1571567)
Backed out changeset fbdf6b75a484 (bug 1571567)
Backed out changeset e2ed4620f232 (bug 1571567)
Backed out changeset 2c67015f12c6 (bug 1571567)
Backed out changeset 7ec086bb5bd5 (bug 1571567)
Backed out changeset 42df735c8556 (bug 1571567)
Backed out changeset 7d5fc57b2809 (bug 1571567)
Backed out changeset 606bafb8211c (bug 1571567)
2019-08-08 18:13:54 +03:00
Alexander Surkov
002fc892ce Bug 1539651 - Convert places-popup-base and places-popup-arrow bindings to Custom Elements r=mak
Differential Revision: https://phabricator.services.mozilla.com/D33821

--HG--
rename : browser/components/places/content/menu.xml => browser/components/places/content/places-menupopup.js
extra : moz-landing-system : lando
2019-08-08 14:28:36 +00:00
Jared Wein
1b77b801de Bug 1571567 - Enable the no-fallthrough eslint rule. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D40744

--HG--
extra : moz-landing-system : lando
2019-08-08 12:45:00 +00:00
rdalal
43acd674ea Bug 1569330 - Disable telemetry check in Normandy recipe runner r=mythmon,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D39576

--HG--
extra : moz-landing-system : lando
2019-08-06 23:54:34 +00:00
Agi Sferro
41549d2c74 Bug 1571308 - Use error code from apilint. r=nalexander
Failures in apilint have a rule code so include that in the information from
the lint.

Differential Revision: https://phabricator.services.mozilla.com/D40578

--HG--
extra : moz-landing-system : lando
2019-08-06 17:26:31 +00:00
Agi Sferro
6c32deae47 Bug 1571308 - Don't include |detail| in apilint output. r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D40575

--HG--
extra : moz-landing-system : lando
2019-08-05 16:33:30 +00:00