The methods have been improved and now live in telemetry.js again.
We use these methods for tools that at least require timing.
MozReview-Commit-ID: 2CqBCA9j3XU
--HG--
extra : rebase_source : faa489ea4790db55648301be842f55cea308ce29
Changes and notes:
- Created `devtools/client/shared/test/telemetry-test-helpers.js`, which
contains test helpers to aid in creating and running telemetry tests.
- Removed any telemetry monkeypatching as it is not dependable and no longer
needed (there is some left in GCLI but the test is now disabled because
we are removing GCLI soon anyhow).
- Because `telemetry-test-helpers.js` is imported by `shared-head.js` I
have had to make it available everywhere that shared-head.js is used.
- All telemetry tests have been rewritten to use the new helper.
- shared-head.js cannot be imported by tests inside
`devtools/client/performance/test/` because perf have custom `once` and
`waitFor` implementations that act differently from the ones inside
`shared-head.js`. This means I had to import the telemetry helpers into
`devtools/client/performance/test/head.js`
- Created `devtools/client/shared/test/browser_telemetry_misc.js` to be sure
to catch `DEVTOOLS_SCREEN_RESOLUTION_ENUMERATED_PER_USER` (we catch a few
others to be thorough).
- Disabled `browser_inspector_menu-02-copy-items.js`, which was failing to
test some expired scalars. I also corrected the way the scalars are logged
because it was completely wrong.
MozReview-Commit-ID: JjQEGM6hT61
--HG--
extra : rebase_source : cd1214d01bd11908f69167839975cd93ecb83421
- Refactor the logic for getting the grid highlighter settings into HighlightersOverlay.js
- Refactor the grid area and cell highlight into a single function in grid-inspector.js
- Change the order of the parameters for onHighlighterChange in grid-inspector.js
- Get the last highlighted state from the Redux store instead of storing them in a variable
Extract loading the grid highlighter setting into HighlightersOverlay. This
allows the grid highlighter toggle in the rule view to also show the grid
highlighter with the currently set highlight settings if the grid inspector
has not been initiated yet.
- Refactor the logic for getting the grid highlighter settings into HighlightersOverlay.js
- Refactor the grid area and cell highlight into a single function in grid-inspector.js
- Change the order of the parameters for onHighlighterChange in grid-inspector.js
- Get the last highlighted state from the Redux store instead of storing them in a variable
Extract loading the grid highlighter setting into HighlightersOverlay. This
allows the grid highlighter toggle in the rule view to also show the grid
highlighter with the currently set highlight settings if the grid inspector
has not been initiated yet.
When the inspector is in landscape mode, it will first try to toggle on the 3 pane mode by
creating a middle/bottom-left panel with the same sidebar width, but if doubling the
original sidebar width will be bigger than half of the toolbox's width, we will instead
toggle on the 3 pane mode with all panels being of equal widths.
When the inspector is in portrait mode, it will just toggle on its T shape pane such that
the 2 bottom panes are equal widths.
We also increased the breakpoint width of the toolbox's side view to 1000px so that it
will keep its T shape in portrait mode until the toolbox's width is bigger than 1000px.
Both reason and isSlotted arguments of setNodeFront are optional, switching to an
object argument avoids weird calls such as setNodeFront(front, null, true) in favor
of a more explicit setNodeFront(front, { isSlotted: true });
MozReview-Commit-ID: A6nziH3QQYe
--HG--
extra : rebase_source : e5bde9e74369e1b0fb2e1d1a0a2b31a0131caacd
As well as flipping the pref on, this also moves the pref to the common all.js
prefs file because the pref is used by DevTools server code.
MozReview-Commit-ID: GfkLfXg1EiR
--HG--
extra : rebase_source : 952dcc4bce3f9f2ae598a98be3b63a70ba4068b2
Adjust the grid outline in the Inspector's Layout panel as needed to match the
writing mode and text direction of the grid container.
MozReview-Commit-ID: Ggcp1e4ZipE
--HG--
extra : rebase_source : e9acadc8837ad3c05c038a2156272c9eff8c7330
The transforms that can be applied to the grid outline to adjust for writing
mode may include translation and reflection based on the outline's width or
height. To achieve the expected result, we need to start drawing the outline at
(0, 0) instead of (1, 1).
MozReview-Commit-ID: HjbREuyNpvH
--HG--
extra : rebase_source : c8dadf60f7d4d4ee9763e29fb6d1ab878beb5afd
This patch was autogenerated by my decomponents.py
It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.
It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <