Previously we passed a potentially NULL pointer to
CrashReporterHost::FinalizeOrphanedMinidump() which always assumed it to be
non-NULL. This patch solves the issue but preventing the pointer from being
NULL and making CrashReporterHost::GenerateCrashReport() infallible. In the
case we fail to take a minidump the only visible effect will be that the
minidump ID will be empty, and existing code already expects and handles this
scenario correctly.
Differential Revision: https://phabricator.services.mozilla.com/D63179
--HG--
extra : moz-landing-system : lando
takeWindowSnapshot() could take long time with WebRender native compositor. Then skip takeWindowSnapshot() with WebRender. It was fall out from D63125.
Differential Revision: https://phabricator.services.mozilla.com/D63431
--HG--
extra : moz-landing-system : lando
2020-02-20 09:10:51 +00:00
Marco Bonardo ext:(%20%3Cmbonardo%40mozilla.com%3E)
Opening modal dialogs seems to cause focus misbehavior on Linux, run tests in new tabs to better isolate them.
Differential Revision: https://phabricator.services.mozilla.com/D63347
--HG--
extra : moz-landing-system : lando
The render backend's frame builder config is kept only in order to send updates to the scene builder's frame builder config which will update the scene's in the next transaction. If need be the scene configs can be updated right away by looping over the documents. This avoids confusing bugs where only updating the backend's config affects the visibility pass but not the rest.
Differential Revision: https://phabricator.services.mozilla.com/D63337
--HG--
extra : moz-landing-system : lando
For now this is Nightly-only so that IsTypeInferenceEnabled() shouldn't
impact performance for our non-Nightly users.
Depends on D63143
Differential Revision: https://phabricator.services.mozilla.com/D63145
--HG--
extra : moz-landing-system : lando
Also fix the getWaitForAllPromise testing function to not use IsPackedArray
because that depends on type information and caused test failures.
Differential Revision: https://phabricator.services.mozilla.com/D63143
--HG--
extra : moz-landing-system : lando
Unlike stack type monitoring, heap TI is much harder to disable completely
because it's intertwined with a lot of other things. This patch does the
following:
* Don't track type information for any ObjectGroups (in ObjectGroupRealm::makeGroup).
* Turn off heuristics for singletons, allocation-site groups, function groups.
* Turn off type update ICs in Baseline.
* Add early returns to some hot functions.
Depends on D63140
Differential Revision: https://phabricator.services.mozilla.com/D63141
--HG--
extra : moz-landing-system : lando
If TI is disabled we don't allocate any StackTypeSets in JitScript and we don't
allocate/use type monitor ICs.
Differential Revision: https://phabricator.services.mozilla.com/D63140
--HG--
extra : moz-landing-system : lando
As currently written (before this patch), the test improperly assumes that its
horizontal scrollbars will be opaque. Specifically: the testcase has a red
background behind two horizontal scrollbars, whereas the reference case has a
green background behind one of the scrollbars and no background behind the
other. This would all be fine if the scrollbars were guaranteed to be opaque,
but we don't have any such guarantee. On browsers where scrollbars are
transparent, this horizontal-scrollbar-area will end up red in the testcase
vs. green/white in the reference case.
This patch amends the files to address this, by adjusting the testcase like so:
- It changes the outer elements' background from red to tan, to avoid the
"something's definitely wrong" implication of red coloring.
- It adjusts the prose to account for the fact that this color might shine
through a transparent scrollbar, and it's fine if it does.
- It reorders the declarations for #inner and #inner2 to list width before
height (just for consistency - this one's a non-functional change).
...and similarly, this patch adjusts the reference case like so:
- It adds a tan background-color on both "outer" elements (instead of
green & default-transparent backgrounds).
- It adds a green background to #inner, and gives that element 100% height to
make it fill the scrollable area with green (since #outer is no longer doing
that).
- It makes the same adjustment to the prose as in the testcase.
Note that the testcase is mostly unchanged, so the same conditions are being
tested here, before vs. after the patch.
Aside from the prose change, this patch doesn't affect either file's rendering
in Chrome, and it only affects the rendering in Firefox insomuch as it converts
the red scrollbar-background to tan.
Differential Revision: https://phabricator.services.mozilla.com/D61654
--HG--
extra : moz-landing-system : lando
We remove the old behaviour that if webm was disabled it would be overridden under some circumstances.
Instead we replace if with a new specialised preference (media.mediasource.vp9.enabled) that is only disabled on Android.
If this pref is disabled, vp9 will only be enabled under some conditions:
- h264 HW decoding is not supported
- mp4 is not enabled
- Device was deemed fast enough to decode VP9 via the P9Benchmark utility
- On Android, A VP9 HW decoder is present.
The primary observable result is that YouTube will serve H264 content on devices with no hardware VP9 decoder
Differential Revision: https://phabricator.services.mozilla.com/D63042
--HG--
extra : moz-landing-system : lando
Bug 1604412 enabled "remote backbuffer" compositing when using non-accelerated
layers. However, due to my misunderstanding of how nWindow and compositing
handles layered windows, I broke the usecase where a child window is
transparent.
In this case, it is the top-level anscestor window that has the
WS_EX_LAYERED attribute and not the child window. The ancestor is the one
that needs to be repainted when a present is requested.
Differential Revision: https://phabricator.services.mozilla.com/D63377
--HG--
extra : moz-landing-system : lando
We test this only in wpt, and test_interfaces.js should treat
it as a disabled interface because its preference is default off on all
channels.
Differential Revision: https://phabricator.services.mozilla.com/D63364
--HG--
extra : moz-landing-system : lando
