I think this is slightly better fix given the amount of offenders we have that
don't make sure this is the case.
Generally we get through the flush just fine, but there's code that relies on
nsIDocument::GetShell to return something meaningful, like the styleset code
that gets a pres context.
Differential Revision: https://phabricator.services.mozilla.com/D14689
Flushing just the shell is not quite sound, since it doesn't flush parent
documents, and also doesn't have the side effect of ensuring the shell is not
destroying and the document is not in the bfcache.
Differential Revision: https://phabricator.services.mozilla.com/D14687
They were incorrectly pointed at the non-partner configs in 2e27f3f1ebc6f38d98ddd42b6955083f637e2b1b.
Differential Revision: https://phabricator.services.mozilla.com/D17716
--HG--
extra : moz-landing-system : lando
DisplaySystemMenu() does not handle nsSizeMode_Invalid that causes warning of
clang. This patch makes it treat nsSizeMode_Invalid. When it receives the
value, it will call NS_ASSERTION() to be detectable on debug builds during
automated tests.
Additionally, this adds default case into the switch statement with
MOZ_ASSERT_UNREACHABLE(). Then, when somebody adds new nsSizeMode, they
can detect it with crash in debug build if they forget to change this method.
Differential Revision: https://phabricator.services.mozilla.com/D17217
--HG--
extra : moz-landing-system : lando
The method was added by bug 506926, but not sure when this becomes an orphan.
Differential Revision: https://phabricator.services.mozilla.com/D17215
--HG--
extra : moz-landing-system : lando
We can always pull this back from history should we need it, but given
how broken the texture caching of pictures was (see the recent text shadow
story) I suspect we won't.
Differential Revision: https://phabricator.services.mozilla.com/D17524
Added "space-in-parens": ["error"] to eslint for passwordmgr, and fixed the 5 errors found.
Differential Revision: https://phabricator.services.mozilla.com/D17697
--HG--
extra : moz-landing-system : lando
NSS 3.42 added a new build flag, enable_sslkeylogfile, to toggle the
availability of the SSLKEYLOGFILE variable (see Bug 1515236 and Bug 1519209).
Differential Revision: https://phabricator.services.mozilla.com/D17588
--HG--
extra : moz-landing-system : lando
The changes were made in Github to have proper markup for the
SmartTrace component. In the console, we change how the "Copy Message"
and "Export visible messages" context menu actions work so they use
the Selection API instead of `element.textContent`.
The Selection API reflects what would happen if a user do a text
selection, so having our actions to do the same ensure that we keep
our markup suitable for the clipboard.
Differential Revision: https://phabricator.services.mozilla.com/D17378
--HG--
extra : moz-landing-system : lando
Having the element displayed as a block cause some new lines
to be added the clipboard when doing a selection and copying.
This would also break the changes we are doing in the "Copy message"
context menu entry.
Differential Revision: https://phabricator.services.mozilla.com/D17377
--HG--
extra : moz-landing-system : lando
The Frames component changed significantly on Github, which means
we need to do some adjustments in the SmartTrace component (pass
the `selectable` prop, change CSS rules, …).
For now, we also hide the Framework icons as we need to find a way
to properly share the underlying CSS from the debugger (See
https://github.com/devtools-html/debugger.html/issues/7782).
Differential Revision: https://phabricator.services.mozilla.com/D17376
--HG--
extra : moz-landing-system : lando
These builds aren't ready for general availability, so we don't want to publish
them. But we want to start building them now.
Differential Revision: https://phabricator.services.mozilla.com/D17453
--HG--
extra : moz-landing-system : lando
The current document of a window can change in between the time when a
PaymentRequest registers as an activity observer and when it attempts
to unregister, so keep a strong reference to the document. This is the
same issue as bug 1317805.
Differential Revision: https://phabricator.services.mozilla.com/D17540
--HG--
extra : moz-landing-system : lando
The GeckoView test app doesn't handle visited link history, so disable
a couple tests that rely on that.
Differential Revision: https://phabricator.services.mozilla.com/D17698
--HG--
extra : moz-landing-system : lando
I am bit surprised myself, but just removing the getPropertyDescriptor trap seems to mostly work.
The only real special case here is the XPC Sandbox, which I changed to keep using its getPropertyDescriptorImpl.
testSetPropertyIgnoringNamedGetter.cpp didn't even really need its getPropertyDescriptor implementation.
Differential Revision: https://phabricator.services.mozilla.com/D17386
--HG--
extra : moz-landing-system : lando
