Commit Graph

59 Commits

Author SHA1 Message Date
Collin Wing
8672c0fbe8 Bug 1501900 Convert about:devtools to use Fluent r=flod,jaws,zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D9816

--HG--
extra : rebase_source : 6947aca11c49f9c914b9888fa55cab05a0162509
2018-11-05 18:52:42 +00:00
Mark Banner
ceaeb93550 Bug 1486741 - Enable ESLint rule comma-dangle for all of mozilla-central (automatic fixes). r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D8389

--HG--
extra : moz-landing-system : lando
2018-10-19 12:55:39 +00:00
Michael Ratcliffe
4e3c6d2b5f Bug 1491879 - Fix telemetry support for multiple tabs / windows r=nchevobbe
- Various telemetry methods now need an object to be passed in in order to keep them seperate e.g. if the inspector is opened in tab 1 a timer is started. If an inspector is opened in tab 2 the same timer is restarted. Closing tab 2 would then erase the timing event invalidating the timer in tab 1.
- We no longer need to preface telemetry calls with category "devtools.main" because this is the only category we will be using.
- There are some changes to `devtools/client/debugger/new/dist/vendors.js` and `devtools/client/debugger/new/src/utils/telemetry.js` that need to be ported to the debugger at the same time as landing this.

Differential Revision: https://phabricator.services.mozilla.com/D6137

--HG--
extra : moz-landing-system : lando
2018-09-25 12:57:13 +00:00
Alexandre Poirot
d31ef570b8 Bug 1485676 - Adapt gDevTools API to new async forTab and also adapt its callsites. r=yulia
Summary:
When switching to async, it is important to catch exception or register a rejection handler
so that errors keep being logged.
So in this patch I'm catching exception in a couple of important codepath.

Depends On D4541

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4542

MozReview-Commit-ID: IDPJVkAPbTs
2018-09-24 09:52:54 -07:00
Alexandre Poirot
dc5f0efff6 Bug 1485676 - Refactor gDevTools.getTargetForTab callsites to assume getTargetForTab is async. r=yulia
Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4535

MozReview-Commit-ID: FyERWaYipZo
2018-09-24 09:52:47 -07:00
shindli
51a3c01ced Backed out 9 changesets (bug 1485676) for failures in browser/tools/mozscreenshots/devtools/browser_devtools.js CLOSED TREE
Backed out changeset d358feec4ca1 (bug 1485676)
Backed out changeset ed554dbb062f (bug 1485676)
Backed out changeset 6e78058df94d (bug 1485676)
Backed out changeset 3a6f1b0e71f4 (bug 1485676)
Backed out changeset 16d2403aa787 (bug 1485676)
Backed out changeset 454eddf52157 (bug 1485676)
Backed out changeset 926f725f2183 (bug 1485676)
Backed out changeset fb03f174bd5f (bug 1485676)
Backed out changeset ceb93dd1799a (bug 1485676)
2018-09-24 15:27:27 +03:00
Alexandre Poirot
fe30914ea1 Bug 1485676 - Adapt gDevTools API to new async forTab and also adapt its callsites. r=yulia
Summary:
When switching to async, it is important to catch exception or register a rejection handler
so that errors keep being logged.
So in this patch I'm catching exception in a couple of important codepath.

Depends On D4541

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4542

MozReview-Commit-ID: IDPJVkAPbTs
2018-09-24 01:25:00 -07:00
Alexandre Poirot
35bc2e7546 Bug 1485676 - Refactor gDevTools.getTargetForTab callsites to assume getTargetForTab is async. r=yulia
Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4535

MozReview-Commit-ID: FyERWaYipZo
2018-09-24 01:24:58 -07:00
Gurzau Raul
ad28ad0169 Backed out 9 changesets (bug 1485676) for failing at damp inspector/cold-open.js on a CLOSED TREE
Backed out changeset 4de2e71debfe (bug 1485676)
Backed out changeset e63025150c7a (bug 1485676)
Backed out changeset f9ef30ae3f7f (bug 1485676)
Backed out changeset a83636fab16a (bug 1485676)
Backed out changeset b1fd24929e09 (bug 1485676)
Backed out changeset acb27b915742 (bug 1485676)
Backed out changeset ba2157632772 (bug 1485676)
Backed out changeset d1d6b9bc2372 (bug 1485676)
Backed out changeset d7646ea8640b (bug 1485676)
2018-09-22 19:42:04 +03:00
Alexandre Poirot
b553b3b567 Bug 1485676 - Adapt gDevTools API to new async forTab and also adapt its callsites. r=yulia
Summary:
When switching to async, it is important to catch exception or register a rejection handler
so that errors keep being logged.
So in this patch I'm catching exception in a couple of important codepath.

Depends On D4541

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4542

MozReview-Commit-ID: IDPJVkAPbTs
2018-09-22 08:34:20 -07:00
Alexandre Poirot
e2590d206d Bug 1485676 - Refactor gDevTools.getTargetForTab callsites to assume getTargetForTab is async. r=yulia
Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D4535

MozReview-Commit-ID: FyERWaYipZo
2018-09-22 08:34:18 -07:00
arthur.iakab
6877b6a75c Backed out 9 changesets (bug 1485676)for perma failures in devtools/client/canvasdebugger/test/browser_canvas-actor-test-01.js CLOSED TREE
Backed out changeset 9f5ec2aa7109 (bug 1485676)
Backed out changeset 0d530c1316a4 (bug 1485676)
Backed out changeset 03278e6fe685 (bug 1485676)
Backed out changeset 275463260056 (bug 1485676)
Backed out changeset 4c5a956b33f7 (bug 1485676)
Backed out changeset d8fe80bb0e3c (bug 1485676)
Backed out changeset 56240996921f (bug 1485676)
Backed out changeset ec0a322f5cc9 (bug 1485676)
Backed out changeset f0f4f9407970 (bug 1485676)
2018-09-21 12:48:48 +03:00
Alexandre Poirot
71f3e5e9f8 Bug 1485676 - Adapt gDevTools API to new async forTab and also adapt its callsites. r=yulia
When switching to async, it is important to catch exception or register a rejection handler
so that errors keep being logged.
So in this patch I'm catching exception in a couple of important codepath.

Depends On D4541

Differential Revision: https://phabricator.services.mozilla.com/D4542

--HG--
extra : moz-landing-system : lando
2018-09-21 08:07:25 +00:00
Alexandre Poirot
3d286eae18 Bug 1485676 - Refactor gDevTools.getTargetForTab callsites to assume getTargetForTab is async. r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D4535

--HG--
extra : moz-landing-system : lando
2018-09-21 08:06:16 +00:00
Michael Ratcliffe
f99d1fce0e Bug 1435429 - Android 'mach mochitest' fails: 'A cross-directory support file path noted in a test manifest does not appear in any other manifest.' r=bc,chmanchester
Differential Revision: https://phabricator.services.mozilla.com/D4214

--HG--
extra : moz-landing-system : lando
2018-08-28 20:29:58 +00:00
Kris Maglione
9a8a840c9d Bug 1484496: Part 5d - Convert devtools/ nsISimpleEnumerator users to use JS iteration. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D3732

--HG--
extra : rebase_source : 0154c72286ce0ca3ade84c5c360122861a36c7b0
extra : histedit_source : 83a8b267becbf86db5f8789d3673bd529da35286
2018-08-18 19:28:37 -07:00
Jonathan Kingston
9b7fb2f20c Bug 1362034 - Have addTab() provide the correct triggering principal. r=ckerschb r=Gijs
Reviewers: ckerschb!, Gijs!

Tags: #secure-revision

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2046

--HG--
extra : source : 44b25dea67d2ed079e17057ab619d827e9983400
extra : amend_source : 5742820277e0269b6f5d42b1abd98fd9b228ac4a
extra : histedit_source : 790bd2490333e4d8fea7774d036eafbc2fc329b9
2018-07-06 15:14:54 +01:00
Jonathan Kingston
2f0987a202 Bug 1362034 - Tests for addTab() to provide the correct triggering principal. r=ckerschb r?=gijs
Summary: Depends on D2046

Reviewers: ckerschb!, Gijs!

Tags: #secure-revision

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2047

--HG--
extra : source : 33884d05cc94463950b31fab1fd2f37ada9becef
extra : intermediate-source : 72471adb75d5ec3dc2b0c8f972a6f1f26bfd3ae2
extra : histedit_source : f384cbab58401575afc3443c9a431b73cff806d4
2018-07-06 21:16:29 +01:00
dvarga
12f19b94e9 Backed out 2 changesets (bug 1362034) for failure at browser/tools/mozscreenshots/primaryUI/browser_primaryUI.js on a CLOSED TREE
Backed out changeset 1c3329958b8a (bug 1362034)
Backed out changeset f68b1b76af36 (bug 1362034)

--HG--
extra : histedit_source : 6169c5ffe856266d3bc8b2ca32f4b67054c71bbe
2018-08-08 22:11:56 +03:00
Jonathan Kingston
c15f69d427 Bug 1362034 - Tests for addTab() to provide the correct triggering principal. r=ckerschb,Gijs
Summary: Depends on D2046

Reviewers: ckerschb, Gijs

Reviewed By: ckerschb, Gijs

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2047

--HG--
extra : rebase_source : ccded0f06a0dc4567b827f42ee29f4b8954154fe
extra : amend_source : 94da8ecc053e56958fa4137d7e497362fa2c11f1
2018-08-08 20:05:30 +03:00
Jonathan Kingston
f389570122 Bug 1362034 - Have addTab() provide the correct triggering principal. r=ckerschb,Gijs
Reviewers: ckerschb, Gijs

Reviewed By: ckerschb, Gijs

Subscribers: mixedpuppy, reviewbot

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2046

--HG--
extra : rebase_source : ea688b35744f970e74de3039da3973f1177d8577
extra : amend_source : 89efdb8ccec2c334a83155eec6b30f08fa0f7074
2018-08-08 20:03:55 +03:00
Andreea Pavel
f5c1119983 Backed out 2 changesets (bug 1362034) for failing damp | inspector/cold-open.js on a CLOSED TREE
Backed out changeset 8c8925b75aa2 (bug 1362034)
Backed out changeset ff6b05c96094 (bug 1362034)
2018-08-06 20:42:44 +03:00
Jonathan Kingston
4ca581ffed Bug 1362034 - Tests for addTab() to provide the correct triggering principal. r=ckerschb,Gijs
Summary: Depends on D2046

Reviewers: ckerschb, Gijs

Reviewed By: ckerschb, Gijs

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2047

--HG--
extra : rebase_source : 4bb9e7feb0704239756e6e38623c0fea81669f7b
extra : amend_source : 9417f96547735fbdc55ea23666327a5cb86ac92f
2018-08-06 19:56:37 +03:00
Jonathan Kingston
9be2ebdb53 Bug 1362034 - Have addTab() provide the correct triggering principal. r=ckerschb,Gijs
Reviewers: ckerschb, Gijs

Reviewed By: ckerschb, Gijs

Subscribers: reviewbot

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2046

--HG--
extra : rebase_source : 57c6bda461781ec20f0ceba8d1dd9c48778bf568
extra : amend_source : 2eebbf1e7df91697ce984d2845dbae41f9dcbcbd
2018-08-06 19:54:47 +03:00
Dave Townsend
389a969138 Bug 1479050: Migrate a number of call-sites to use document.createXULElement. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D2489

--HG--
extra : moz-landing-system : lando
2018-07-31 19:13:38 +00:00
Michael Ratcliffe
b56813230a Bug 1466881 - Missing open events for some users r=nchevobbe
Changes:

- All files
  - Generally shuffled around telemetry events to fix issues with properties not been sent or being sent in the wrong order.
- devtools/client/framework/browser-menus.js
  - Added telemetry open event to missed codepath.
- devtools/startup/DevToolsShim.jsm
  - Added missing telemetry "shortcut" property.
- devtools/startup/devtools-startup.js
  - Added comment to sendEntryPointTelemetry().

MozReview-Commit-ID: ELldeyF32rG

--HG--
extra : rebase_source : bbe9a9bf279e6a6c1324a162885cc35b04cf27ce
2018-07-16 21:16:50 +01:00
Daisuke Akatsuka
6db8153aa8 Bug 1471795 - Part 1: Implement basis of 'This Firefox' page. r=jdescottes,ladybenko
In this patch, implement following basic things of 'ThisFirefox' page for new
about:debugging.

* Add a pref devtools.aboutdebbugging.enabled-new to enable new about:debbugging.
* Add a function which switches new/old about:debugging page by the pref.
* Add devtools/client/aboutdebugging-new directory for new about:debugging.
* Add basic html, css, JavaScript and React component.

MozReview-Commit-ID: 5DtV7rRcS0S

--HG--
extra : rebase_source : 26496ef8273c03b78a7b8d00f44beac5f18d09ef
2018-07-26 17:52:10 +09:00
Gijs Kruitbosch
09a107bc24 Bug 1469916, r=ckerschb,jkt
--HG--
extra : rebase_source : 180442deeef92f0e9202d76c5e4e46b630072d99
extra : source : be11a32900298eb6fd4d18ad21b9a699995254c3
2018-06-22 15:41:39 +01:00
Joel Maher
50b91c0a14 Bug 1405428 - skip-if = verify on mochitests which do not pass test-verify. r=gbrown 2018-06-10 05:01:47 -04:00
Julian Descottes
7fdc2c153f Bug 1454696 - Fix leftover issues for prefer-const;r=yulia
MozReview-Commit-ID: JwOXoqw2mks

--HG--
extra : rebase_source : a3f07665a42c2779a85b7901a07206266a9d1616
extra : source : ae946f375e0d0f4f0f0fc859c54040fef42cbc2c
2018-06-01 12:19:35 +02:00
Julian Descottes
640fe52298 Bug 1454696 - Run eslint --fix for prefer-const;r=yulia
MozReview-Commit-ID: F6xUXCgdRE4

--HG--
extra : rebase_source : 65de1b0aba412d9044b5196115f74276caa058f2
2018-06-01 12:36:09 +02:00
Michael Ratcliffe
9b4265bed3 Bug 1456984 - Instrument inspection of shortcut combination used for toolbox opening with event telemetry r=yulia
MozReview-Commit-ID: HA6Tasq2iZu

--HG--
extra : rebase_source : c5d7ef7f574148d38a75ca14dfbf5ee82821134e
2018-05-23 13:14:25 +01:00
Chris Adams
e51dd34b2e Bug 1014090 - Toggle inspector on mac with extra cmd+shift+C shortcut; r=pbro
MozReview-Commit-ID: KSdkGmVqVFd

--HG--
extra : rebase_source : 86575e369b0c6846d65ce6f4966c491a7536d19e
2018-05-23 08:06:14 +02:00
Csoregi Natalia
1f27cbd511 Backed out changeset 123010192259 (bug 1014090) for failing on browser_duplicateIDs.js. CLOSED TREE 2018-05-25 13:11:29 +03:00
Chris Adams
94864a6c91 Bug 1014090 - Toggle inspector on mac with extra cmd+shift+C shortcut; r=pbro
MozReview-Commit-ID: KSdkGmVqVFd

--HG--
extra : rebase_source : d964254d0daeea2b02aa6573c904cfbc59965583
2018-05-23 08:06:14 +02:00
Michael Ratcliffe
13a006d57e Bug 1458208 - telemetry.js: DevTools code should always go through telemetry.js r=jdescottes
MozReview-Commit-ID: 9cUGY2CjjZG

--HG--
extra : rebase_source : 1818f742cc89c25146f23d42c68a6b53ae9cdc21
2018-05-10 15:14:01 +01:00
Alexandre Poirot
ad79b6e365 Bug 1461970 - Remove gcli references from startup folder. r=jryans
MozReview-Commit-ID: I4Osp8qFvwv

--HG--
extra : rebase_source : 81e23a5fbf928eb26fa5cacdcf87eb7f82d5eceb
2018-03-21 10:10:50 -07:00
Michael Ratcliffe
30e6b8b177 Bug 1458203 - telemetry.js: Rename all log* methods r=jdescottes
MozReview-Commit-ID: 9QcRGkXCq71

--HG--
extra : rebase_source : a2dcf7c3b8c58aba0afccd83377ffe2855862b02
2018-05-09 09:53:49 +01:00
Kris Maglione
01c298aca6 Bug 1460092: Add ESLint rule to enforce use of ChromeUtils.generateQI. r=Gijs
Also fixes existing code which fails the rule.

MozReview-Commit-ID: CkLFgsspGMU

--HG--
extra : rebase_source : 86a43837659aa2ad83a87eab53b7aa8d39ccf55b
2018-05-08 18:36:22 -07:00
Julian Descottes
711c760354 Bug 1441507 - Fix window focus issue for intermittent browser_shim_disable_devtools;r=pbro
MozReview-Commit-ID: 1e4NmJNdP3G

--HG--
extra : rebase_source : 96208fbdd2564dfcd5b276c186e1cbe8a7abda82
2018-05-04 19:40:23 +02:00
Alexandre Poirot
4924ab84b0 Bug 1456194 - Fix toolbox startup telemetry measurement when using more than one top level window. r=jryans
MozReview-Commit-ID: Ic1qw8amjki

--HG--
extra : rebase_source : fa0f8010985d6f9c912305c87297fcc0f6915635
2018-04-25 03:01:13 -07:00
Kris Maglione
a259026c9d Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY

--HG--
extra : rebase_source : a29c07530586dc18ba040f19215475ac20fcfb3b
2018-04-22 20:55:06 -07:00
Kris Maglione
a7b308c3a2 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW

--HG--
extra : rebase_source : cffb1c9762191c579d1397c8169e6e7635d229da
extra : histedit_source : dea59ddd2daaae52069c5faceae9149a4f08dd73
2018-04-24 20:18:09 -07:00
Gurzau Raul
4aeb9af849 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-04-10 19:58:05 +03:00
Yura Zenevich
442d872d5b Bug 1428427 - add 'Inspect Accessibility Properties' context menu item when right clicking on content element. r=jdescottes, mixedpuppy
MozReview-Commit-ID: 4aav1f6eslQ
2018-04-10 10:52:58 -04:00
Julian Descottes
aa51f2b0c0 Bug 1448077 - Move devtools-startup preferences file to dedicated /preferences folder;r=jryans
Changing the name for consistency purposes (see RFC
https://github.com/devtools-html/rfcs/issues/43)

MozReview-Commit-ID: EahEwoR9eBF

--HG--
rename : devtools/startup/devtools-startup-prefs.js => devtools/startup/preferences/devtools-startup.js
extra : rebase_source : eddc92413f69a80884d9dc26a6b603af2ce04b41
2018-04-06 12:10:10 +02:00
Coroiu Cristina
586aed9d72 Backed out 4 changesets (bug 1448077) for xpcshell failures at toolkit/components/osfile/tests/xpcshell/test_creationDate.js on a CLOSED TREE
Backed out changeset 456166433c71 (bug 1448077)
Backed out changeset a826e8871e9f (bug 1448077)
Backed out changeset 42b4ccfcb9c4 (bug 1448077)
Backed out changeset c61caf7df6c7 (bug 1448077)

--HG--
rename : devtools/client/preferences/devtools-client.js => devtools/client/preferences/devtools.js
rename : devtools/client/webide/preferences/webide.js => devtools/client/webide/webide-prefs.js
rename : devtools/startup/preferences/devtools-startup.js => devtools/startup/devtools-startup-prefs.js
2018-04-09 18:58:40 +03:00
Julian Descottes
1563ca8769 Bug 1448077 - Move devtools-startup preferences file to dedicated /preferences folder;r=jryans
Changing the name for consistency purposes (see RFC
https://github.com/devtools-html/rfcs/issues/43)

MozReview-Commit-ID: EahEwoR9eBF

--HG--
rename : devtools/startup/devtools-startup-prefs.js => devtools/startup/preferences/devtools-startup.js
extra : rebase_source : 5aeb6fa4d1264de91097bf29f9aace844e84ee04
2018-04-06 12:10:10 +02:00
arthur.iakab
a63676a8df Merge mozilla-central to autoland 2018-04-06 01:14:00 +03:00
Yura Zenevich
6b478aa9d3 Bug 1451357 - removing accessibility commandkey that overlaps with some add-ons and a console on Windows. r=pbro
MozReview-Commit-ID: 97lEdUJqjJD
2018-04-05 09:11:51 -04:00