Commit Graph

3200 Commits

Author SHA1 Message Date
Daisuke Akatsuka
876007c921 Bug 1628635: Update MDN compatibility data. r=rcaliman
Depends on D72606

Differential Revision: https://phabricator.services.mozilla.com/D72607
2020-04-29 13:58:28 +00:00
Julian Descottes
a97d7642d9 Bug 1594402 - Support setting the data-color attribute on the swatch directly r=ladybenko,rcaliman
Depends on D68849

Differential Revision: https://phabricator.services.mozilla.com/D68971
2020-04-29 10:05:37 +00:00
Julian Descottes
816f890d48 Bug 1594402 - Test that switching color format in DevTools works with the color picker r=ladybenko,rcaliman
Depends on D61063

I broke this feature while working experimenting for this patch and it was not caught by any test.

Adding a test to avoid regressions.

Differential Revision: https://phabricator.services.mozilla.com/D68849
2020-04-29 10:03:40 +00:00
Julian Descottes
d13658bff7 Bug 1594402 - Display a color swatch for CSS variables in CSS autocomplete r=ladybenko,rcaliman
Depends on D68963

Differential Revision: https://phabricator.services.mozilla.com/D61063
2020-04-29 10:03:31 +00:00
Julian Descottes
ef20d9d88f Bug 1594402 - Store the swatchcolorpicker color in a data attribute instead of textcontent r=ladybenko,rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D68963
2020-04-29 10:03:24 +00:00
Andreea Pavel
26c02e4ad0 Backed out 7 changesets (bug 1602075, bug 1551574) for failing multiple dt e.g. browser_accessibility_context_menu_inspector.js on a CLOSED TREE
Backed out changeset d878be5e1884 (bug 1551574)
Backed out changeset 2b11feb2473d (bug 1602075)
Backed out changeset 1406b19b25e9 (bug 1602075)
Backed out changeset 0aa8307788b6 (bug 1602075)
Backed out changeset 418dbded9752 (bug 1602075)
Backed out changeset 2c19213df4d7 (bug 1602075)
Backed out changeset 98a4b4e8fda3 (bug 1602075)
2020-04-27 20:23:42 +03:00
Yura Zenevich
8657f0c3ac Bug 1602075 - display enabled Inspect Accessibility Properties menu item in inspector if devtools.accessibility.auto-init.enabled pref is set to true. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D71587
2020-04-27 14:16:03 +00:00
Andreea Pavel
6bebdc0ae6 Bug 1559033 - disable browser_computed_getNodeInfo.js on mac shippable opt r=egao
Differential Revision: https://phabricator.services.mozilla.com/D72071
2020-04-25 05:43:37 +00:00
Csoregi Natalia
230cef6455 Backed out 6 changesets (bug 1602075) for devtools failures caused by markup-context-menu.js. CLOSED TREE
Backed out changeset cf06e30be068 (bug 1602075)
Backed out changeset 51f01135d82f (bug 1602075)
Backed out changeset fbb30bd09d66 (bug 1602075)
Backed out changeset e1e570497527 (bug 1602075)
Backed out changeset 3aa7f4f31934 (bug 1602075)
Backed out changeset 7d568f0fa1e4 (bug 1602075)
2020-04-23 19:03:05 +03:00
Yura Zenevich
218ec835e5 Bug 1602075 - display Inspect Accessibility Properties menu item in inspector if devtools.accessibility.auto-init.enabled pref is set to true. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D71587
2020-04-23 14:40:25 +00:00
Daisuke Akatsuka
7be5632750 Bug 1590981: Add a browser test for settings. r=mtigley
Depends on D70324

Differential Revision: https://phabricator.services.mozilla.com/D70482
2020-04-21 20:09:17 +00:00
Daisuke Akatsuka
1b3262dd31 Bug 1590981: Add a node test for Settings component. r=mtigley
Depends on D70323

Differential Revision: https://phabricator.services.mozilla.com/D70324
2020-04-22 01:53:37 +00:00
Daisuke Akatsuka
daa1629a9a Bug 1590981: Update a node test for Settings component. r=mtigley
Depends on D70322

Differential Revision: https://phabricator.services.mozilla.com/D70323
2020-04-22 01:53:04 +00:00
Daisuke Akatsuka
5865a049cd Bug 1590981: Make target browsers persistent. r=mtigley
Depends on D70321

Differential Revision: https://phabricator.services.mozilla.com/D70322
2020-04-22 01:50:57 +00:00
Daisuke Akatsuka
573ddb6669 Bug 1590981: Make target browsers selectable. r=mtigley
Depends on D70320

Differential Revision: https://phabricator.services.mozilla.com/D70321
2020-04-21 20:06:28 +00:00
Daisuke Akatsuka
a99dc11e53 Bug 1590981: Show all default target browsers in settings page. r=mtigley
Depends on D70319

Differential Revision: https://phabricator.services.mozilla.com/D70320
2020-04-22 01:32:34 +00:00
Daisuke Akatsuka
2575ca8e6e Bug 1590981: Introduce UserSettings object. r=mtigley
Depends on D70318

Differential Revision: https://phabricator.services.mozilla.com/D70319
2020-04-22 01:17:45 +00:00
Daisuke Akatsuka
0736ab52d2 Bug 1590981: Add a settings pane. r=mtigley
Depends on D70317

Differential Revision: https://phabricator.services.mozilla.com/D70318
2020-04-22 01:14:19 +00:00
Daisuke Akatsuka
fd3b574e9f Bug 1590981: Append settings button. r=mtigley
Depends on D70286

Differential Revision: https://phabricator.services.mozilla.com/D70317
2020-04-22 00:53:33 +00:00
Daisuke Akatsuka
43768a5a20 Bug 1625815: Add a node test for Footer component. r=mtigley,rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D70286
2020-04-21 15:34:31 +00:00
Daisuke Akatsuka
74dbb630d2 Bug 1625815: Add a feedback button. r=mtigley,rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D70285
2020-04-22 00:23:21 +00:00
Razvan Caliman
5041fb4bbd Bug 1628044 - Get CSSProperties directly from CSSPropertiesFront r=jdescottes
The `initCssProperties()` helper is used to augment the CSS database of properties received from the server with additional local data. The returned `CSSProperties` object is cached by DevToolsClient instance so it can be returned quickly on subsequent requests.

Requesting the database from the server and its augmentation can be done in the `CSSPropertiesFront`'s [Front.initialize()](https://searchfox.org/mozilla-central/rev/a707541ff423ade0d81cef6488e6ecfa09273886/devtools/shared/protocol/Front.js#115-117) which is already async. This ensures that by the time the `CSSPropertiesFront` is returned, the `CSSProperties` object is ready to use with data reconciled.

Fronts are already [cached per target](https://searchfox.org/mozilla-central/rev/a707541ff423ade0d81cef6488e6ecfa09273886/devtools/client/fronts/targets/target-mixin.js#185-192). A duplicate `target.getFront("cssProperties")` will return the previously instantiated `CSSPropertiesFront` with the augmented database.

Getting the `CSSProperties` object is something done only for the top-level target in the Inspector and the Style Editor. Thanks to the behavior of `target.getFront()`, this already acts as a cache, thus negating both tasks done by the `initCssProperties()` helper.

Differential Revision: https://phabricator.services.mozilla.com/D70071
2020-04-21 13:42:02 +00:00
Gijs Kruitbosch
11836f7641 Bug 1631358 - remove traces of CPOWs from devtools, r=jdescottes,loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D71509
2020-04-21 14:04:58 +00:00
Coroiu Cristina
43be71277d Backed out 2 changesets (bug 1625500) for multiple failures on a CLOSED TREE
Backed out changeset 7d80233bcfcd (bug 1625500)
Backed out changeset 0a35b13dfcde (bug 1625500)
2020-04-17 15:36:05 +03:00
Gijs Kruitbosch
cc39a339a0 Bug 1625500 - fix use of .then(x, x) in the tree, r=marionette-reviewers,Standard8,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D68614
2020-04-17 11:41:49 +00:00
Brindusan Cristian
8b3ca7fd70 Backed out changeset 05ccd03beb2f (bug 1528288) as requested by rcaliman on Bug 1629043 for failing with Beta configuration. CLOSED TREE 2020-04-16 18:57:51 +03:00
Razvan Caliman
af81e97e25 Bug 1627795 - Remove unused getCssProperties() helper r=gl
Differential Revision: https://phabricator.services.mozilla.com/D70048
2020-04-07 19:39:25 +00:00
Daisuke Akatsuka
9795757724 Bug 1625132: Add telemetry for MDN link. r=Honza,fscholz
Differential Revision: https://phabricator.services.mozilla.com/D70485

--HG--
extra : moz-landing-system : lando
2020-04-15 11:40:22 +00:00
Andreea Pavel
2cbcfa9385 Backed out changeset aa85314cbc0d (bug 1625132) for node devtools jest | compatibility failure on a CLOSED TREE 2020-04-15 14:03:34 +03:00
Daisuke Akatsuka
53459f4868 Bug 1625132: Add telemetry for MDN link. r=Honza,fscholz
Differential Revision: https://phabricator.services.mozilla.com/D70485

--HG--
extra : moz-landing-system : lando
2020-04-15 05:51:22 +00:00
Jacqueline
c6d7e0ebde Bug 1528288 - Introduce a tooltip when hovering over box-model values to show the rule where a value is coming from r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D68708

--HG--
rename : devtools/client/inspector/boxmodel/test/browser_boxmodel_jump-to-rule-on-hover.js => devtools/client/inspector/boxmodel/test/browser_boxmodel_jump-to-rule-on-click.js
extra : moz-landing-system : lando
2020-04-09 13:43:23 +00:00
Julian Descottes
85347793aa Bug 1628691 - Remove leftover usage of this._target in inspector.js r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D62616

--HG--
extra : moz-landing-system : lando
2020-04-09 13:07:29 +00:00
Razvan Caliman
da154ce911 Bug 1464876 - Load reducers on-demand in Inspector sidebar panels r=gl
The Inspector [loads all its panels' Redux reducers](https://searchfox.org/mozilla-central/source/devtools/client/inspector/reducers.js) up front, regardless if they're used or not.
Some of the reducers are quite hefty. It seems needless to load and parse code that's not needed.

In addition, the reducers are loaded in a different place than their corresponding actions. Actions are loaded and used in the panels, but the reducers are all loaded in the [Inpector when creating the store](https://searchfox.org/mozilla-central/rev/d69ec052bed8700af7a283e37b60b4af22734930/devtools/client/inspector/store.js#8,11). It helps reduce the cognitive load if actions and reducers are loaded together where they are used, in the sidebar panels.

This patch uses the approach described in the Redux docs to inject reducers on-demand: https://redux.js.org/recipes/code-splitting/#reducer-injection-approaches

There still are reducers which need to load immediately when the Inspector is initialized (mostly related to the Rules panel). But others, like the reducer for the Animations or Fonts panel, are loaded on-demand when the corresponding panels are visible.

For the most part, reducers are used in response to actions from their corresponding panels. However, the grid, flexbox and grid highlighter reducers are also [used  in HighlightersOverlay.js](https://searchfox.org/mozilla-central/rev/d69ec052bed8700af7a283e37b60b4af22734930/devtools/client/inspector/shared/highlighters-overlay.js#502) to provide highlighters with configuration or node context. In these cases, we load the reducers on-demand even if their corresponding panels haven't been opened yet. When the panels do get opened, the reducers are not re-loaded since they're already available.

Differential Revision: https://phabricator.services.mozilla.com/D67008

--HG--
extra : moz-landing-system : lando
2020-04-07 18:19:13 +00:00
Tim Nguyen
b2a1f8e4b5 Bug 1618243 - Use checked property instead of attribute for rules view checkbox. r=devtools-inspector-reviewers,gl
Differential Revision: https://phabricator.services.mozilla.com/D66866

--HG--
extra : moz-landing-system : lando
2020-04-06 14:18:42 +00:00
Bogdan Tara
cd329c7b65 Bug 1609313 - Disable browser_rules_cubicbezier-appears-on-swatch-click.js on windows 32 debug r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D69301

--HG--
extra : moz-landing-system : lando
2020-04-02 10:44:35 +00:00
Daisuke Akatsuka
3e41ac61f3 Bug 1625812: Move the compatibility tab into between Changes and Fonts. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D68743

--HG--
extra : moz-landing-system : lando
2020-03-30 12:35:39 +00:00
Julian Descottes
00fa44d86e Bug 1625209 - Remove keyboard shortcuts when destroying the DevTools MarkupView r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D68410

--HG--
extra : moz-landing-system : lando
2020-03-27 13:07:27 +00:00
Jason Laster
5a7b245dd7 Bug 1624630 - Simplify the selected thread logic. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D68095

--HG--
extra : moz-landing-system : lando
2020-03-26 12:50:46 +00:00
Jason Laster
069676f934 Bug 1605175 - Selecting an element in remote iframe should switch context and update selector. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D67083

--HG--
extra : moz-landing-system : lando
2020-03-24 15:28:52 +00:00
Julian Descottes
cfab47ff53 Bug 1604539 - Rename shared/fronts to client/fronts in the devtools codebase r=nchevobbe
Depends on D67603
This patch is an automated string replace of shared/fronts/ to client/fronts/ in devtools.

Differential Revision: https://phabricator.services.mozilla.com/D67604

--HG--
extra : moz-landing-system : lando
2020-03-20 13:58:56 +00:00
Bogdan Tara
b03ab7d69b Backed out 5 changesets (bug 1604539) for xpc failures complanining about test_encryption.js CLOSED TREE
Backed out changeset 8455e50002a9 (bug 1604539)
Backed out changeset fb410a1bf9aa (bug 1604539)
Backed out changeset da94f7d503a1 (bug 1604539)
Backed out changeset b4b54335ee2d (bug 1604539)
Backed out changeset 866d6794bbba (bug 1604539)

--HG--
rename : devtools/client/fronts/accessibility.js => devtools/shared/fronts/accessibility.js
rename : devtools/client/fronts/addon/addons.js => devtools/shared/fronts/addon/addons.js
rename : devtools/client/fronts/addon/moz.build => devtools/shared/fronts/addon/moz.build
rename : devtools/client/fronts/addon/webextension-inspected-window.js => devtools/shared/fronts/addon/webextension-inspected-window.js
rename : devtools/client/fronts/animation.js => devtools/shared/fronts/animation.js
rename : devtools/client/fronts/array-buffer.js => devtools/shared/fronts/array-buffer.js
rename : devtools/client/fronts/changes.js => devtools/shared/fronts/changes.js
rename : devtools/client/fronts/content-viewer.js => devtools/shared/fronts/content-viewer.js
rename : devtools/client/fronts/css-properties.js => devtools/shared/fronts/css-properties.js
rename : devtools/client/fronts/descriptors/frame.js => devtools/shared/fronts/descriptors/frame.js
rename : devtools/client/fronts/descriptors/moz.build => devtools/shared/fronts/descriptors/moz.build
rename : devtools/client/fronts/descriptors/process.js => devtools/shared/fronts/descriptors/process.js
rename : devtools/client/fronts/descriptors/tab.js => devtools/shared/fronts/descriptors/tab.js
rename : devtools/client/fronts/descriptors/webextension.js => devtools/shared/fronts/descriptors/webextension.js
rename : devtools/client/fronts/device.js => devtools/shared/fronts/device.js
rename : devtools/client/fronts/environment.js => devtools/shared/fronts/environment.js
rename : devtools/client/fronts/frame.js => devtools/shared/fronts/frame.js
rename : devtools/client/fronts/framerate.js => devtools/shared/fronts/framerate.js
rename : devtools/client/fronts/highlighters.js => devtools/shared/fronts/highlighters.js
rename : devtools/client/fronts/inspector.js => devtools/shared/fronts/inspector.js
rename : devtools/client/fronts/inspector/moz.build => devtools/shared/fronts/inspector/moz.build
rename : devtools/client/fronts/inspector/rule-rewriter.js => devtools/shared/fronts/inspector/rule-rewriter.js
rename : devtools/client/fronts/layout.js => devtools/shared/fronts/layout.js
rename : devtools/client/fronts/manifest.js => devtools/shared/fronts/manifest.js
rename : devtools/client/fronts/memory.js => devtools/shared/fronts/memory.js
rename : devtools/client/fronts/moz.build => devtools/shared/fronts/moz.build
rename : devtools/client/fronts/node.js => devtools/shared/fronts/node.js
rename : devtools/client/fronts/object.js => devtools/shared/fronts/object.js
rename : devtools/client/fronts/perf.js => devtools/shared/fronts/perf.js
rename : devtools/client/fronts/performance-recording.js => devtools/shared/fronts/performance-recording.js
rename : devtools/client/fronts/performance.js => devtools/shared/fronts/performance.js
rename : devtools/client/fronts/preference.js => devtools/shared/fronts/preference.js
rename : devtools/client/fronts/property-iterator.js => devtools/shared/fronts/property-iterator.js
rename : devtools/client/fronts/reflow.js => devtools/shared/fronts/reflow.js
rename : devtools/client/fronts/responsive.js => devtools/shared/fronts/responsive.js
rename : devtools/client/fronts/root.js => devtools/shared/fronts/root.js
rename : devtools/client/fronts/screenshot.js => devtools/shared/fronts/screenshot.js
rename : devtools/client/fronts/source.js => devtools/shared/fronts/source.js
rename : devtools/client/fronts/storage.js => devtools/shared/fronts/storage.js
rename : devtools/client/fronts/string.js => devtools/shared/fronts/string.js
rename : devtools/client/fronts/styles.js => devtools/shared/fronts/styles.js
rename : devtools/client/fronts/stylesheets.js => devtools/shared/fronts/stylesheets.js
rename : devtools/client/fronts/symbol-iterator.js => devtools/shared/fronts/symbol-iterator.js
rename : devtools/client/fronts/targets/browsing-context.js => devtools/shared/fronts/targets/browsing-context.js
rename : devtools/client/fronts/targets/content-process.js => devtools/shared/fronts/targets/content-process.js
rename : devtools/client/fronts/targets/local-tab.js => devtools/shared/fronts/targets/local-tab.js
rename : devtools/client/fronts/targets/moz.build => devtools/shared/fronts/targets/moz.build
rename : devtools/client/fronts/targets/target-mixin.js => devtools/shared/fronts/targets/target-mixin.js
rename : devtools/client/fronts/targets/worker.js => devtools/shared/fronts/targets/worker.js
rename : devtools/client/fronts/thread.js => devtools/shared/fronts/thread.js
rename : devtools/client/fronts/walker.js => devtools/shared/fronts/walker.js
rename : devtools/client/fronts/webconsole.js => devtools/shared/fronts/webconsole.js
rename : devtools/client/fronts/websocket.js => devtools/shared/fronts/websocket.js
rename : devtools/client/fronts/worker/moz.build => devtools/shared/fronts/worker/moz.build
rename : devtools/client/fronts/worker/push-subscription.js => devtools/shared/fronts/worker/push-subscription.js
rename : devtools/client/fronts/worker/service-worker-registration.js => devtools/shared/fronts/worker/service-worker-registration.js
rename : devtools/client/fronts/worker/service-worker.js => devtools/shared/fronts/worker/service-worker.js
2020-03-20 15:53:23 +02:00
Julian Descottes
ad4b5dfb37 Bug 1604539 - Rename shared/fronts to client/fronts in the devtools codebase r=nchevobbe
Depends on D67603
This patch is an automated string replace of shared/fronts/ to client/fronts/ in devtools.

Differential Revision: https://phabricator.services.mozilla.com/D67604

--HG--
extra : moz-landing-system : lando
2020-03-20 12:57:58 +00:00
Jason Laster
5f29a6d696 Bug 1622996 - Refactor devtools codebase to use optional chaining (automated changes). r=jdescottes
Depends on D67084

Differential Revision: https://phabricator.services.mozilla.com/D67537

--HG--
extra : moz-landing-system : lando
2020-03-19 21:13:38 +00:00
Sylvestre Ledru
be18fd4dba Bug 1622328 - add license info to all eslintrc files r=Standard8,webcompat-reviewers,miketaylr
Differential Revision: https://phabricator.services.mozilla.com/D67319

--HG--
extra : moz-landing-system : lando
2020-03-19 13:47:51 +00:00
Julian Descottes
0cf76f06a1 Bug 1620194 - Remove test-actor-registry and expose simplified helpers in shared-head.js r=ochameau
Depends on D65570

Differential Revision: https://phabricator.services.mozilla.com/D65575

--HG--
extra : moz-landing-system : lando
2020-03-18 09:29:58 +00:00
Julian Descottes
c230c0e21e Bug 1620194 - Stop registering test actor dynamically r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D65564

--HG--
extra : moz-landing-system : lando
2020-03-18 09:17:17 +00:00
Bogdan Tara
de7fb1bb56 Bug 1559315 - Disable browser_rules_authored_color.js on Mac && Linux opt r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D67016

--HG--
extra : moz-landing-system : lando
2020-03-17 14:06:59 +00:00
sankalp_sans
a3884579cc Bug 1424863 - Copying CSS Rules from the Devtools Inspector inserts empty lines between rules r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D66899

--HG--
extra : moz-landing-system : lando
2020-03-16 11:48:42 +00:00
Ed Lee
acb960676c Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-reviewers,webcompat-reviewers,perftest-reviewers,sparky,whimboo,denschub
Differential Revision: https://phabricator.services.mozilla.com/D66128

--HG--
extra : moz-landing-system : lando
2020-03-13 23:38:52 +00:00
Daisuke Akatsuka
525f812250 Bug 1615509: Add a test for the throbber. r=mtigley
Depends on D65284

Differential Revision: https://phabricator.services.mozilla.com/D65285

--HG--
extra : moz-landing-system : lando
2020-03-12 14:32:49 +00:00