Commit Graph

318 Commits

Author SHA1 Message Date
Jonathan Kew
4e6c40d7ea Bug 1131451 part 1 - Replace containerWidth with containerSize in logical-coordinate classes and APIs, frame classes, etc. r=dholbert 2015-07-16 10:07:57 +01:00
Mats Palmgren
ea742f35e6 Bug 1148833 part 4 - Fix indentation of some Reflow params (white-space changes only). 2015-03-29 22:38:40 +00:00
Mats Palmgren
ed9ed2d61a Bug 1148833 part 3 - Remove nsIFrame::WillReflow and add a non-virtual MarkInReflow method instead that sets NS_FRAME_IN_REFLOW. Call it at the start of Reflow(). r=roc 2015-03-29 22:38:40 +00:00
Jonathan Kew
65d058f1da Bug 1138356 - Correct the alignment of button contents in vertical-rl writing mode. r=smontagu 2015-03-12 13:09:30 +00:00
L. David Baron
b64dc1a002 Bug 1010675 - Stop allowing button contents to overflow into the CSS padding and border (although still allow them to overflow into our internal focuspadding when the min-content width says the contents don't fit). r=dholbert
Note that this replaces the code that allows eroding the space with new
code that reduces the focusPadding value.

(Also, we previously didn't count the focusPadding towards what could be
eroded, which meant we wouldn't quite get to the edge of the padding and
border, because we weren't counting the extra for the focusPadding.)

The existing reftests that I'm changing from == to != are ones that were
specifically testing issues related to erosion of padding.

The change to 491180-{1,2}-ref.html is because we now *do* erode the
focusPadding, which is 3px in the horizontal dimensions (see the
button::-moz-focus-inner styles in forms.css), and that was the only
nonzero style on the button in 491180-{1,2}.html.

CLOSED TREE (per RyanVM)
2015-03-20 10:27:09 -07:00
Ryan VanderMeulen
00a19ca0b0 Backed out changesets f33123f726b6 and c2724e2f9de9 (bug 1010675) for B2G reftest failures.
CLOSED TREE
2015-03-20 12:25:49 -04:00
L. David Baron
ee83e8e2bc Bug 1010675 - Stop allowing button contents to overflow into the CSS padding and border (although still allow them to overflow into our internal focuspadding when the min-content width says the contents don't fit). r=dholbert
Note that this replaces the code that allows eroding the space with new
code that reduces the focusPadding value.

(Also, we previously didn't count the focusPadding towards what could be
eroded, which meant we wouldn't quite get to the edge of the padding and
border, because we weren't counting the extra for the focusPadding.)

The existing reftests that I'm changing from == to != are ones that were
specifically testing issues related to erosion of padding.

The change to 491180-{1,2}-ref.html is because we now *do* erode the
focusPadding, which is 3px in the horizontal dimensions (see the
button::-moz-focus-inner styles in forms.css), and that was the only
nonzero style on the button in 491180-{1,2}.html.
2015-03-20 06:47:29 -07:00
Phil Ringnalda
0b8d3e9eb3 Back out ceaac3da2eff (bug 1010675) for Android reftest failures
CLOSED TREE
2015-03-19 22:49:45 -07:00
L. David Baron
f913231fd1 Bug 1010675 - Stop allowing button contents to overflow into the CSS padding and border (although still allow them to overflow into our internal focuspadding when the min-content width says the contents don't fit). r=dholbert
Note that this replaces the code that allows eroding the space with new
code that reduces the focusPadding value.

(Also, we previously didn't count the focusPadding towards what could be
eroded, which meant we wouldn't quite get to the edge of the padding and
border, because we weren't counting the extra for the focusPadding.)

The existing reftests that I'm changing from == to != are ones that were
specifically testing issues related to erosion of padding.

The change to 491180-{1,2}-ref.html is because we now *do* erode the
focusPadding, which is 3px in the horizontal dimensions (see the
button::-moz-focus-inner styles in forms.css), and that was the only
nonzero style on the button in 491180-{1,2}.html.
2015-03-19 21:10:00 -07:00
Jonathan Kew
52542b250f Bug 1130231 - Properly logicalize the implementation of padding on button contents. r=smontagu 2015-02-09 14:40:23 +00:00
Mats Palmgren
28750ad79a Bug 1111995 - Clip buttons to their border area for event hit testing. r=roc 2014-12-20 20:19:12 +00:00
Jonathan Kew
a65c19199c Bug 1106667 - Vertical writing-mode support for HTML button elements. r=smontagu 2014-12-04 00:57:17 -08:00
Mats Palmgren
98fa65732a Bug 1102791 - Always return NS_FRAME_COMPLETE status from nsHTMLButtonControlFrame::Reflow. Don't create overflow container continuations unless the delegating frame has eCanContainOverflowContainers. r=roc 2014-11-24 16:42:31 +00:00
Jonathan Kew
1e0d48aa2d bug 1046950 pt 1 - additional/modified APIs on LogicalSize. r=smontagu 2014-08-24 15:34:21 +01:00
Jonathan Kew
76bdb9472c bug 1031241 pt 4 - Rename the {MIN,PREF}_WIDTH constants used to identify the type of intrinsic inline-size. r=smontagu 2014-07-24 18:03:26 +01:00
Jonathan Kew
ce9cbe4216 bug 1031241 pt 1 - Rename Get{Min,Pref}Width to Get{Min,Pref}ISize throughout layout. r=dbaron,smontagu 2014-07-24 18:03:25 +01:00
Simon Montagu
c3b44c4dad Bug 789096 patch 9: use logical coordinates in nsHTMLReflowState available size. r=jfkthame 2014-07-24 01:28:46 -07:00
Simon Montagu
aaa4878ee5 Replace GetBaseline with GetLogicalBaseline and use logical coordinates in the line position and baseline getters in nsLayoutUtils. Bug 789096, r=jfkthame 2014-06-17 05:19:38 -07:00
Simon Montagu
ca20e365ef Replace Get/SetTopAscent with Get/SetBlockStartAscent. Bug 789096, r=jfkthame 2014-06-11 02:45:31 -07:00
Mats Palmgren
4205141894 Bug 1015781 - part 10, Make nsHTMLButtonControlFrame::AppendFrames/InsertFrames/RemoveFrame DEBUG only. r=roc 2014-05-28 19:36:59 +00:00
Mats Palmgren
f08f841973 Bug 1015781 - part 1+2, Make the SetInitialChildList/AppendFrames/InsertFrames/RemoveFrame methods return void (scripted change). Remove code handling the return values. r=roc 2014-05-28 19:36:58 +00:00
Mats Palmgren
399be41768 Bug 508665 - part 5, Make nsIFrame::Init require a nsContainerFrame* for the parent frame param. r=roc 2014-05-24 22:20:40 +00:00
Mats Palmgren
2831fb8a6a Bug 508665 - part 4, Make nsCSSFrameConstructor use nsContainerFrame* for frames used as parent frames. r=roc 2014-05-24 22:20:40 +00:00
Mats Palmgren
9795aca511 Bug 1008917 - part 2,3,4, make Reflow() return type 'void', and make a few reflow related helper methods 'void' too. r=roc 2014-05-13 00:47:52 +00:00
Wes Kocher
42253715d7 Backed out 11 changesets (bug 1008917) for apparently introducing an intermittent failure of B2G Crashtest-2 on a CLOSED TREE
Backed out changeset e2ab653f688a (bug 1008917)
Backed out changeset b52154d8d900 (bug 1008917)
Backed out changeset 2ab5b01da4de (bug 1008917)
Backed out changeset f7a38df1d44f (bug 1008917)
Backed out changeset 80304bb9a572 (bug 1008917)
Backed out changeset 10ed89a302e9 (bug 1008917)
Backed out changeset 161c41991d46 (bug 1008917)
Backed out changeset 25b2475d2368 (bug 1008917)
Backed out changeset b8000b31277c (bug 1008917)
Backed out changeset 9afa5e7715e1 (bug 1008917)
Backed out changeset 5c380c21351f (bug 1008917)
2014-05-12 15:47:41 -07:00
Mats Palmgren
a722b491f1 Bug 1008917 - part 2,3,4, make Reflow() return type 'void', and make a few reflow related helper methods 'void' too. r=roc 2014-05-12 17:40:28 +00:00
Jonathan Kew
c2c11aa0a5 bug 735577 - followup 1 (v2) - allow reflow-state to be passed to the reflow-metrics constructor to get the writing mode. r=roc 2013-12-31 13:50:31 +00:00
Reuben Morais
bde629dd63 Bug 458300 - Rename nsINameSpaceManager.h to nsNameSpaceManager.h. r=jst r=hsivonen
--HG--
rename : content/base/public/nsINameSpaceManager.h => content/base/public/nsNameSpaceManager.h
2014-02-27 20:04:46 -03:00
Arnaud Sourioux
2d583fd28f Bug 919806: Get rid of NS_IMETHOD in nsIFrame.h and its implementations r=dholbert 2014-02-17 23:47:48 -08:00
Peiyong Lin
14bf63554d Bug 959874 - Reorder two parameters in nsContainerFrame::FinishReflowChild(), for consistency with nsContainerFrame::ReflowChild(). r=dholbert 2014-01-16 17:34:44 -08:00
Jonathan Kew
9067ab3480 backout changeset 8b6f20bda157 (bug 735577 followup 1) for build failure 2013-12-29 22:48:13 +00:00
Jonathan Kew
9d097b2e05 bug 735577 - followup 1 - allow reflow-state to be passed to the reflow-metrics constructor to get the writing mode. r=roc 2013-12-29 22:04:02 +00:00
Jonathan Kew
a7837e1ffa bug 735577 - pt 4.1 - use accessor functions for some physical-coordinate fields in nsHTMLReflowMetrics, in preparation for logicalization. r=smontagu 2013-12-27 17:59:52 +00:00
Jonathan Kew
954a119d07 bug 735577 - pt 3.2 - update the rest of layout code to use the new accessors on nsHTMLReflowState. r=smontagu 2013-12-27 17:59:21 +00:00
Masayuki Nakano
a4221a463f Bug 920377 part.30 Get rid of nsGUIEvent r=roc 2013-10-02 12:46:03 +09:00
Daniel Holbert
a4f533376a Bug 913759 part 1: Treat buttonContent frames as block wrappers, so percent heights inside a button can resolve against button's height (minus focus border/padding). r=bz 2013-09-28 10:24:00 -07:00
Daniel Holbert
fcc50874b4 Bug 921174 part 5: Assert that nsHTMLButtonControlFrame has exactly one child, and it's the button-content frame. r=bz 2013-09-26 23:43:16 -07:00
Daniel Holbert
aabdb63f6a Bug 921174 part 4: Move focusPadding into ReflowButtonContents, the only place it's used now. r=bz 2013-09-26 23:43:16 -07:00
Daniel Holbert
7e58b440e0 Bug 921174 part 3: Make ReflowButtonContents() use a dedicated nsHTMLReflowMetrics instance, and give it full responsibility for populating parent's metrics. r=bz 2013-09-26 23:43:16 -07:00
Daniel Holbert
0a0d58f016 Bug 921174 part 2: Use a separate nsReflowStatus for button frame's reflow vs. button contents frame's reflow. r=bz 2013-09-26 23:43:16 -07:00
Daniel Holbert
543b6d213d Bug 921174 part 1: Rename reflow state variables in nsHTMLButtonFrame, for clarity. r=bz 2013-09-26 23:43:15 -07:00
Ehsan Akhgari
886cf493e5 Bug 909927 - Minimize the #includes in layout/forms; r=mats
--HG--
extra : rebase_source : 92eb9ca6672e754a32dbfe3cd3494309671902d3
2013-08-28 10:30:02 -04:00
Bear Travis
a03478bd24 Bug 893298 - Correctly calculate button and button child's desired height to vertically center the child. r=bz 2013-07-18 14:21:47 -07:00
Ryan VanderMeulen
22667a6005 Backed out changeset 4504582d908c (bug 843003) for Marionette failures. 2013-07-11 11:46:04 -04:00
Mounir Lamouri
15bdf50023 Bug 843003 - Send events and allow :hover to apply on <button>'s children. r=bz 2013-07-11 10:30:23 -04:00
Bear Travis
9a1e760e9a Bug 835873 - Include minHeight calculation before vertically centering a button's children. r=bz 2013-07-10 10:02:47 -04:00
Robert O'Callahan
a949bd58de Bug 841192. Part 15: Move DisplayListClipState clipping methods to AutoSaveRestore and AutoClipMultiple helper classes for safer usage. r=mattwoodrow
--HG--
extra : rebase_source : aa674d4fa93f1b7c2b4dd84ba8d888cc9f289265
2013-04-05 00:36:45 +13:00
Robert O'Callahan
613ea8adbd Bug 841192. Part 14: Convert all usage of nsDisplayClip(RoundedRect) to use DisplayListClipState/DisplayItemClip. r=mattwoodrow
This patch does several things. Sorry.

In BuildDisplayList implementations, instead of wrapping display items in nsDisplayClip, we
push clip state onto the nsDisplayListBuilder and give the display items an
explicit clip when they're created.

In FrameLayerBuilder, we use the explicit clips we find on display items instead of
computing our own.

We remove nsDisplayClip and everything that depends on it.

We remove ExplodeAnonymousChildLists. With nsDisplayClip gone, and
nsDisplayOptionEventGrabber removed in a previous patch, there are no
anonymous child lists.

nsDisplayItem::TryMerge implementations need to make sure they have the same
clip before being merged.

I ripped out the part of PruneDisplayListForExtraPage that adjusts clip rects.
As far as I can tell, it isn't actually necessary.

--HG--
extra : rebase_source : 6f3988b385d0ac54ab26fad10b12173884441f48
2013-03-04 22:56:02 +13:00
Mounir Lamouri
5a5a41fbc8 Bug 839834 - Remove nsIFormControlFrame::GetFormProperty. r=bz 2013-02-18 18:21:32 +00:00
Boris Zbarsky
7f102d7f2d Bug 852428 part 2. Make nsIFrame::Init infallible. r=dholbert 2013-03-19 21:47:48 -04:00