Commit Graph

239 Commits

Author SHA1 Message Date
Brendan Dahl
133e16ecf4 Bug 1449791 - Remove platform support of overlays. r=bz
The following was removed:
- the main meat of the overlays and interface in XULDocument
- all overlay observers and forward references
- the notion of a master document
- XUL overlay provider
- manifest parsing of overlay attribute
- references to "overlay" atom
- restrictions on persistence (only need because of overlays)
- unused code that the above referenced

I also attempted to update comments that referenced overlays, but there is still
some work to be done here.


MozReview-Commit-ID: 8lrirzcgSuJ

--HG--
extra : rebase_source : 25b4e1d3fb2af6f02d894887271fd345c9c2083b
2018-03-28 18:20:04 -07:00
Jeff Gilbert
5b753da289 Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
Emilio Cobos Álvarez
c7d35aa526 Bug 1470930: Use enums for passing arguments for event dispatch. r=smaug
MozReview-Commit-ID: DsNuF7GAflJ
2018-06-26 18:22:06 +02:00
Chris Peterson
2afd829d0f Bug 1469769 - Part 6: Replace non-failing NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE. r=froydnj
This patch is an automatic replacement of s/NS_NOTREACHED/MOZ_ASSERT_UNREACHABLE/. Reindenting long lines and whitespace fixups follow in patch 6b.

MozReview-Commit-ID: 5UQVHElSpCr

--HG--
extra : rebase_source : 4c1b2fc32b269342f07639266b64941e2270e9c4
extra : source : 907543f6eae716f23a6de52b1ffb1c82908d158a
2018-06-17 22:43:11 -07:00
Brendan Dahl
7c6e7fdabc Bug 1450753 - Remove XUL style overlays. r=Nika
Style overlays are no longer used outside of tests.

MozReview-Commit-ID: 798Id5JITAm

--HG--
extra : rebase_source : edfbfc973f865d72bbc019a26519436157476793
2018-06-06 15:15:25 -07:00
Emilio Cobos Álvarez
fe09ffd3af Bug 1465478: Introduce Element::FromNode. r=smaug
And use it in a couple places I noticed.

MozReview-Commit-ID: 8baSMrbdEbF
2018-05-31 02:46:10 +02:00
Boris Zbarsky
bea3100e53 Bug 1455676 part 14. Remove most use of nsIDOMNode in dom/. r=qdot 2018-05-29 22:58:49 -04:00
Brendan Dahl
0bb125f382 Bug 1460639 - Apply persisted window settings before layout. r=smaug
Previously, with early first paint enabled, nsXULWindow incorrectly loaded the
persisted window settings from about:blank and would only load them once.
Instead, load the settings before starting layout.

MozReview-Commit-ID: 6K4ofkbmHHb

--HG--
extra : rebase_source : 7bcd804cfabbd47ee5a747800a2ef81852213889
2018-05-16 18:13:59 -07:00
Jan de Mooij
80e44e8003 Bug 1461292 part 1 - Rename JSAutoCompartment to JSAutoRealm. r=bz,luke 2018-05-16 10:53:16 +02:00
Emilio Cobos Álvarez
11794a944d Bug 1461701: Remove nsUpdateType and UPDATE_CONTENT_MODEL. r=smaug
MozReview-Commit-ID: 33iBMZqnkAc
2018-05-15 18:47:16 +02:00
Emilio Cobos Álvarez
cb56e2c9f3 Bug 1459529: Remove UPDATE_STYLE. r=heycam
Now that BeginUpdate is useless for the UPDATE_STYLE case, we don't need the
update mechanism at all. Just ensure that ApplicableStylesChanged is called on
the pres shell via the relevant RuleChanged, etc. notifications.

There's a big hidden gotcha here. nsIDocument::BeginUpdate does put a script
blocker on the stack for these updates. However it's not needed, since no script
can run during these notifications (only the stylesheet events we post for
devtools, but those use AsyncEventDispatcher and PostDOMEvents, so they don't
try to run immediately).

nsIDocument::BeginUpdate also does XBL binding attached queue stuff, but we
can't change bindings during these notifications anyway, so it also doesn't
matter.

MozReview-Commit-ID: HJvK6zQfloh
2018-05-15 18:44:29 +02:00
Adrian Wielgosik
c501e3beb0 Bug 1460940 - Clean up most remaining C++-side uses of nsIDOMDocument. r=bz
MozReview-Commit-ID: LKRnyDPNlle

--HG--
extra : rebase_source : a48b7c72a0f7ede38c91149a04d5de53987736f1
2018-05-11 19:46:15 +02:00
Brendan Dahl
295e2f4aca Bug 1453788 - Allow top level HTML windows to have persistent window state. r=smaug
Move tracking of persistent window state into nsXULWindow. Also, move
special handling of the width/height of the window into nsXULWindow.

MozReview-Commit-ID: LOmHGyYeNSU

--HG--
extra : rebase_source : bcea16eb6209ff789948644a64968a7325cea4ef
2018-04-26 17:53:54 -07:00
Chris Peterson
71422dcaa9 Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj
s/NS_PRECONDITION/MOZ_ASSERT/ and reindent

MozReview-Commit-ID: KuUsnVe2h8L

--HG--
extra : source : c14655ab3df2c9b1465dd8102b9d25683359a37b
2018-04-28 12:50:58 -07:00
Neil Deakin
e25f02a7f3 Bug 1446961, restructuring to allow nsXULElement to be subclassed. Rename nsXULElement::Create to make it clearer it creates from the prototype element, r=bz 2018-04-27 11:04:37 -04:00
Boris Zbarsky
914f11a6d2 Bug 1455674 part 10. Remove nsIDOMElement use from remaining dom/ xpidl files. r=qdot 2018-04-26 23:36:10 -04:00
Emilio Cobos Álvarez
8239c1300e Bug 1386840: Defer loading and don't block rendering for non-matching stylesheets. r=bz,heycam
MozReview-Commit-ID: 24UJZDooGmn
2018-04-26 16:44:03 +02:00
Emilio Cobos Álvarez
a00f507b72 Bug 1456435: Make UpdateStyleSheet less bool-happy. r=heycam
MozReview-Commit-ID: FlTD390lMhg
2018-04-26 16:43:52 +02:00
Brian Grinstead
37febf2987 Bug 1455680 - Notify document-element-inserted in XUL documents;r=bz
We'll want to use this event to inject scripts before other scripts run
in XUL documents. It already fires in HTML documents.

MozReview-Commit-ID: 7FW0R8r9o9G

--HG--
extra : rebase_source : 28fe9b6a4bcbb6ecf8966a0c059d867bf66285bf
2018-04-20 13:55:51 -07:00
Brendan Dahl
fae2220724 Bug 1451625 - Error on overlay load instead of crash. r=mystor
MozReview-Commit-ID: 4OHBlsTmqik

--HG--
extra : rebase_source : e9dd4af841ee5659575b74671ccee7e6a6edcbb9
2018-04-12 11:56:55 -07:00
Ciure Andrei
873d562bc3 Backed out 8 changesets (bug 1451169) on request from njn a=backout
Backed out changeset b92f856e15a8 (bug 1451169)
Backed out changeset 348e825756fa (bug 1451169)
Backed out changeset 624d82428726 (bug 1451169)
Backed out changeset 4d51610ca08e (bug 1451169)
Backed out changeset bb76a9589717 (bug 1451169)
Backed out changeset c145fbd03947 (bug 1451169)
Backed out changeset 6d36289e0f54 (bug 1451169)
Backed out changeset 914fb7cd9fc3 (bug 1451169)

--HG--
extra : histedit_source : 94de6631919f895dec422bc0e564f5baf885ba4a%2C18f52c6c11d3064d3137a6847575effb7d407894
2018-04-11 11:22:05 +03:00
Boris Zbarsky
f2f3fe42ff Bug 1452185 part 3. Remove unnecessary nsIDOMXULElement includes. r=qdot
MozReview-Commit-ID: Ft5MnbFtyB9
2018-04-09 16:30:32 -04:00
Nicholas Nethercote
a560608963 Bug 1451169 - Use nsStaticAtom* instead of nsStaticAtom** in Element.h. r=baku
And then fix up everything else that needs to change as well.

MozReview-Commit-ID: GDMfERqdQAc

--HG--
extra : rebase_source : 01fe06c3182245a409099a53383d92bf4fa0155c
2018-04-03 13:21:06 +10:00
Brendan Dahl
28b0e77359 Bug 1448162 - Crash in the presence of a XUL overlay. r=mystor
MozReview-Commit-ID: 1docjuCTBpE

--HG--
extra : rebase_source : f7794f9b9e1d39acf3f30be4463c8d3ed58780b9
2018-03-23 10:11:09 -07:00
Jim Chen
debcdf257b Bug 1441971 - Restart aborted script load for waiting XULDocument loads; r=bz
When a particular XULDocument load is aborted, its pending script loads
are aborted as well. However, there may be additional XULDocuments
waiting for the same scripts to load. If we continue with the abort, all
the waiting docs will end up with aborted script loads as well.

This patch makes us load the script again for the waiting docs, so that
one aborted doc load does not affect other docs that just happen to be
waiting on the same scripts to load.

MozReview-Commit-ID: FFGBjOLXCDt

--HG--
extra : rebase_source : 945c83eb804c2b8f9901897a23e3e0c6f202aedb
2018-02-28 14:46:06 -05:00
Emilio Cobos Álvarez
bf7f4428f8 Bug 1444525: Persist XUL window size attributes as the outer size, not inner size. r=bz
MozReview-Commit-ID: 7U5tWxTaxGi
2018-03-17 15:55:24 +01:00
Emilio Cobos Álvarez
e2b6db2af5 Bug 1444525: Extract the logic to see if we're a top-level chrome window. r=bz
MozReview-Commit-ID: C9x7AwYR99n
2018-03-17 15:55:24 +01:00
Gurzau Raul
3057041352 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-03-16 19:58:27 +02:00
Sylvestre Ledru
fa45a3c670 Bug 1443080 - Use the static call for static methods (not instance) r=Ehsan
MozReview-Commit-ID: JwHh4bzxuTR

--HG--
extra : rebase_source : 5f5e37517aa80c2e7b5933962178d761074886e7
2018-03-16 14:29:15 +01:00
Emilio Cobos Álvarez
98d261390a Bug 1439875: Fire MozBeforeInitialXULLayout before sizing the window. r=florian,smaug
This gives the chance to code that relies on setting the XUL window attributes
to run before we actually size the window.

This should prevent the resizing on OSX and fix some other untested stuff that
the first commit probably broke...

MozReview-Commit-ID: DhCWgmCppek
2018-03-16 17:26:49 +01:00
Emilio Cobos Álvarez
bcbf022f11 Bug 1439875: Size the XUL window before doing layout. r=smaug
The only subtle thing is the mCenterAfterLoad stuff, which is gated after a
mChromeLoaded.

Other than that it follows the same pattern as bug 345560.

MozReview-Commit-ID: 8qDiA2yn9DB
2018-03-16 17:26:48 +01:00
Gurzau Raul
540992331b Backed out 6 changesets (bug 1439875) for massive breakage for nightly users a=backout
Backed out changeset 990a8eb972cd (bug 1439875)
Backed out changeset 187aef60922c (bug 1439875)
Backed out changeset 9c764daa1234 (bug 1439875)
Backed out changeset f8e091577d2a (bug 1439875)
Backed out changeset 1ee5a2d21901 (bug 1439875)
Backed out changeset 610ba5dfaae1 (bug 1439875)
2018-03-16 11:26:31 +02:00
Emilio Cobos Álvarez
3beb2dc514 Bug 1439875: Fire MozBeforeInitialXULLayout before sizing the window. r=florian,smaug
This gives the chance to code that relies on setting the XUL window attributes
to run before we actually size the window.

This should prevent the resizing on OSX and fix some other untested stuff that
the first commit probably broke...

MozReview-Commit-ID: DhCWgmCppek

--HG--
extra : rebase_source : 253bea4c4e90727c0e8cce4726bf7a695ca26d9d
extra : source : 4d6f855ea529f6043b3ca886f53901e16a3d6405
extra : histedit_source : b0aa76063dca7a85e43b3bf670aab8f185a57915%2C760885a660c4fd92e7ae777614ad3cdc84dc9b31
2018-03-15 21:19:50 +11:00
Emilio Cobos Álvarez
c41e281661 Bug 1439875: Size the XUL window before doing layout. r=smaug
The only subtle thing is the mCenterAfterLoad stuff, which is gated after a
mChromeLoaded.

Other than that it follows the same pattern as bug 345560.

MozReview-Commit-ID: 8qDiA2yn9DB

--HG--
extra : rebase_source : 8ad309e3f449cea1536bfbff8e8b1585fefbc186
extra : source : f582644f846cee16b554d694d24b4eb8ca3c5106
2018-03-15 21:19:50 +11:00
Kris Maglione
83371fe0b5 Bug 1445551: Part 4 - Remove compartment-per-addon. r=mccr8
The compartment-per-addon code was added so that we could segregate at least
some of the code from system-privileged add-ons into tagged compartments, even
when it ran in browser windows. That allowed us to apply certain special
behavior to them, such as enabling e10s shims, and to track some performance
characteristics.

The only remaining chrome-privileged add-ons now are system add-ons controlled
by us, and the shim system and per-compartment performance metrics are gone,
it no longer serves a purpose.

MozReview-Commit-ID: Ap186bWAaqP

--HG--
extra : rebase_source : c5bf81b44dd42b7cebce2784b7dd98480b41b593
2018-03-13 19:43:30 -07:00
Andreea Pavel
efd81bd597 Backed out 6 changesets (bug 1439875) for browser chrome failures at browser/base/content/test/general/browser_private_browsing_window.js on a CLOSED TREE
Backed out changeset 1ee033e0061a (bug 1439875)
Backed out changeset 7f25473e9b29 (bug 1439875)
Backed out changeset 69550dec0534 (bug 1439875)
Backed out changeset f3b96ce3490b (bug 1439875)
Backed out changeset 9ded55072903 (bug 1439875)
Backed out changeset 7b33ad14ce8c (bug 1439875)
2018-03-14 23:54:24 +02:00
Emilio Cobos Álvarez
e60d31cc60 Bug 1439875: Fire MozBeforeInitialXULLayout before sizing the window. r=florian,smaug
This gives the chance to code that relies on setting the XUL window attributes
to run before we actually size the window.

This should prevent the resizing on OSX and fix some other untested stuff that
the first commit probably broke...

MozReview-Commit-ID: DhCWgmCppek
2018-03-14 20:47:39 +01:00
Emilio Cobos Álvarez
7ca346f1b8 Bug 1439875: Size the XUL window before doing layout. r=smaug
The only subtle thing is the mCenterAfterLoad stuff, which is gated after a
mChromeLoaded.

Other than that it follows the same pattern as bug 345560.

MozReview-Commit-ID: 8qDiA2yn9DB
2018-03-14 20:47:37 +01:00
Andreea Pavel
e74f76b184 Backed out 6 changesets (bug 1439875) for failing mochitest clipboard at browser/components/customizableui/test/browser_editcontrols_update.js and mochitest headless at dom/events/test/pointerevents/test_bug1414336.html on a CLOSED TREE
Backed out changeset f21bdb9b67e8 (bug 1439875)
Backed out changeset bd81fafecd95 (bug 1439875)
Backed out changeset 3296aef96276 (bug 1439875)
Backed out changeset a1237d0711a2 (bug 1439875)
Backed out changeset fc25cbe8e22e (bug 1439875)
Backed out changeset 25e681a47121 (bug 1439875)
2018-03-13 18:37:16 +02:00
Emilio Cobos Álvarez
6c15a62ef4 Bug 1439875: Fire MozBeforeInitialXULLayout before sizing the window. r=florian,smaug
This gives the chance to code that relies on setting the XUL window attributes
to run before we actually size the window.

This should prevent the resizing on OSX and fix some other untested stuff that
the first commit probably broke...

MozReview-Commit-ID: DhCWgmCppek
2018-03-13 15:36:15 +01:00
Emilio Cobos Álvarez
184558072c Bug 1439875: Size the XUL window before doing layout. r=smaug
The only subtle thing is the mCenterAfterLoad stuff, which is gated after a
mChromeLoaded.

Other than that it follows the same pattern as bug 345560.

MozReview-Commit-ID: 8qDiA2yn9DB
2018-03-13 15:36:12 +01:00
Jean-Luc Bonnafoux
eeae6bad17 Bug 374021 - Loading an overlay using loadOverlay into an uninitialized XULDocument r=mystor
MozReview-Commit-ID: 8fMuzfF5JnT

--HG--
extra : rebase_source : fed304d1889dfc50821bc45a953a9541d2bb5fb4
2018-03-03 20:39:13 +01:00
Emilio Cobos Álvarez
2988d4e66d Bug 1442207: Remove unneeded arguments to nsIMutationObserver. r=smaug
aDocument is always content->OwnerDoc().
aContainer is always content->GetParent().

Differential Revision: https://phabricator.services.mozilla.com/D664

MozReview-Commit-ID: 4xwPCOnhyIL
2018-03-01 22:45:17 +01:00
Jean-Luc Bonnafoux
def3549f1a Bug 1428860 - XULDocument::GetElementsByAttributeNS may leak memory r=peterv
MozReview-Commit-ID: 5NjViIoivG1

--HG--
extra : rebase_source : 84d73b3df33c07dbf1b0d8edbf6db5580c7aef52
2018-02-25 12:07:52 +01:00
Emilio Cobos Álvarez
432d45b460 Bug 1439027: Simplify PresShell::Initialize. r=bz
Most of the callers pass the already-existing pres-context visible area. The few
that don't can set it themselves.

MozReview-Commit-ID: KRi4ShrgOrE
2018-02-21 12:42:17 +01:00
Hiroyuki Ikezoe
1b0cba9367 Bug 1417354 - Introduce nsIDocument::GetPresContext(). r=smaug
It would be convenient to get nsPresContext from nsIDocument.

MozReview-Commit-ID: Ei6V3UE8XGr

--HG--
extra : rebase_source : 8d2a917eb62cf341e4e1810451fd01c01dbc3bad
2018-02-21 07:00:10 +09:00
Dorel Luca
f41b03eca9 Backed out changeset 38577c007450 (bug 1424371) for Marionett test failure on testing/marionette/harness/marionette_harness/tests/unit/test_window_maximize.py. CLOSED TREE 2018-02-19 22:15:23 +02:00
Milan Sreckovic
7571df7e7c Bug 1424371: Use BaseRect access methods instead of member variables in dom/ r=qdot
MozReview-Commit-ID: HXWhggOMIEK

--HG--
extra : rebase_source : 9c9eacf80d2b7f78faa82a1549170b98d12cdaa8
2018-02-19 12:56:10 -05:00
Boris Zbarsky
65bf16222e Bug 1434399 part 19. Remove nsIXULDocument. r=mystor
MozReview-Commit-ID: 9jQu4sjOhb2
2018-01-31 14:49:29 -05:00
Boris Zbarsky
0bff2380b3 Bug 1434399 part 15. Remove nsIXULDocument::OnPrototypeLoadDone. r=mystor
MozReview-Commit-ID: 9LDh2QByUNV
2018-01-31 14:49:28 -05:00