Commit Graph

9743 Commits

Author SHA1 Message Date
Nathan Froyd
8a2948e596 Bug 1225923 - part 1 - convert all needs-to-copy instances of AppendElement(nsDependentString(...)); r=erahm
When people write:

  array.AppendElement(nsDependentString(...));

(resp. nsDependentCString), it's not clear whether they expect the newly
constructed dependent string to live in the array, or whether they're
just making a nsString-like holder whose contents can be freely copied
into the array's newly-created nsString.  Sometimes the latter is what
you prefer, and sometimes the former.  In all cases, however, the latter
behavior is what you get.

Let's try to make that behavior more explicit by pre-constructing
nsString elements and then using Assign to show that copying is taking
place.  This patch involves no functional change in behavior (it ought
to be epsilon faster due to using AppendElements, rather than repeatedly
calling AppendElement).
2015-11-18 10:25:19 -05:00
Ekanan Ketunuti
c2dbe5f747 Bug 1228174 - Add validator to the en-US dictionary. r=ehsan
--HG--
extra : rebase_source : 86834b669a3ae11b3a894d8e08504938401a552d
2015-11-26 07:13:03 +07:00
Carsten "Tomcat" Book
4478aaa8da Merge mozilla-central to b2g-inbound 2015-11-25 14:00:32 +01:00
Yoshi Huang
4b500464f5 Bug 1209162 - Create OriginAttributes subtypes. IGNORE IDL r=sicking. 2015-11-03 09:50:54 +08:00
Birunthan Mohanathas
9985829ecc Bug 1219392 - Capitalize mozilla::unused to avoid conflicts. r=froydnj 2015-11-02 07:53:26 +02:00
Christoph Kerschbaumer
b0f3027a6c Bug 1119386 - Part 3: Use document's principal for favicons in browser (r=billm) 2015-11-24 13:32:10 -08:00
Ethan Tseng
692c621f8c Bug 1165267 - Fix downgrading issue by restoring appId and inBrowserElement columns v3. r=honzab 2015-11-01 11:13:12 -05:00
Nicholas Nethercote
8375973fa2 Bug 1186814 - Replace nsBaseHashtable::EnumerateRead() calls in extensions/spellcheck/ with iterators. r=ehsan.
--HG--
extra : rebase_source : 92029fc4ed0d9fe4511cfefc21f1c4087ff4d37d
2015-10-19 22:31:53 -07:00
Nicholas Nethercote
5b34a25af2 Bug 1216020 - Comment all ALLOW_COMPILER_WARNINGS lines. r=glandium.
DONTBUILD because it only changes comments.

This will hopefully prevent confusion like that in bug 1215903.

--HG--
extra : rebase_source : f0a601d77b5f42b4fbe090693234f934e3becc42
2015-10-19 18:05:20 -07:00
Chris Peterson
9169f6d9ef Bug 1215902 - Fix clang's -Wimplicit-fallthrough warnings in extensions/cookie. r=jdm
extensions/cookie/nsCookiePermission.cpp:207:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/cookie/nsPermissionManager.cpp:933:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/cookie/nsPermissionManager.cpp:952:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/cookie/nsPermissionManager.cpp:979:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/cookie/nsPermissionManager.cpp:1061:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/cookie/nsPermissionManager.cpp:1255:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/cookie/nsPermissionManager.cpp:1353:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
extensions/cookie/nsPermissionManager.cpp:1377:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
2015-10-17 22:12:38 -07:00
Nathan Froyd
01583602a9 Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout.  The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.

CLOSED TREE makes big refactorings like this a piece of cake.

 # The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
    xargs perl -p -i -e '
 s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
 s/nsRefPtr ?</RefPtr</g;   # handle declarations and variables
'

 # Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h

 # Handle nsRefPtr.h itself, a couple places that define constructors
 # from nsRefPtr, and code generators specially.  We do this here, rather
 # than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
 # things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
     mfbt/nsRefPtr.h \
     xpcom/glue/nsCOMPtr.h \
     xpcom/base/OwningNonNull.h \
     ipc/ipdl/ipdl/lower.py \
     ipc/ipdl/ipdl/builtin.py \
     dom/bindings/Codegen.py \
     python/lldbutils/lldbutils/utils.py

 # In our indiscriminate substitution above, we renamed
 # nsRefPtrGetterAddRefs, the class behind getter_AddRefs.  Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
    xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'

if [ -d .git ]; then
    git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
    hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi

--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
2015-10-18 01:24:48 -04:00
Yoshi Huang
fb57af4ae6 Bug 1191653 - Listen to clear-origin-data in nsPermissionManager. r=bholley 2015-10-13 10:27:42 +08:00
Carsten "Tomcat" Book
6ffd4fc09b Merge m-c to mozilla-inbound 2015-10-14 12:47:31 +02:00
Carsten "Tomcat" Book
0ecf764867 merge mozilla-inbound to mozilla-central a=merge 2015-10-14 12:46:09 +02:00
Daniel Holbert
225fa78d5c Bug 1181313: Remove some unnecessary logging statements for success conditions, in nsPermissionManager.cpp. r=bsmedberg 2015-10-13 17:19:06 -07:00
Ekanan Ketunuti
d30806ea5e Bug 1213765 - Add preliminarily to the en-US dictionary. r=ehsan
--HG--
extra : amend_source : 0cef2913097daad80cdc55b45ba0554dbac73334
2015-10-12 15:21:51 +07:00
M Hamdy
67d215f8de Bug 606655 - delete cookies UI option AskMeEveryTime and its related comments and tests. r=mak
--HG--
extra : rebase_source : 242a074db54395e4b285110286e7692f26b57daa
2015-10-08 09:13:00 +02:00
Michael Layzell
430ced132c Bug 1211591 - Part 2: Tests for nsPermissionManager::RemovePermissionsForApp, r=jdm 2015-10-08 08:42:40 -04:00
Michael Layzell
4e925c38c8 Bug 1211591 - Part 1: Remove incorrect sql statement from nsPermissionManager::RemovePermissionsForApp, r=jdm
This initial query to clear the database was initially removed because of the removal of the appId column, and replaced with the following logic which parses the origin strings to obtain the appId property, and then removes those entries using `AddInternal`. Unfortunately, during a rebase, it appears as though the code crept back into the codebase.

I'm not sure why this codepath wasn't ever tested before bkelly noticed it, but we should probably add a test of some form which actually runs the RemovePermissionsForApp codepath, to ensure that it actually works.
2015-10-08 08:42:38 -04:00
Carsten "Tomcat" Book
08997000eb Backed out 2 changesets (bug 1202902) to recking bug 1202902 to be able to reopen inbound on a CLOSED TREE
Backed out changeset 647025383676 (bug 1202902)
Backed out changeset d70c7fe532c6 (bug 1202902)
2015-10-07 14:03:21 +02:00
Carsten "Tomcat" Book
e7ef778c9d Backed out 1 changesets (bug 1202902) for causing merge conflicts to mozilla-central
Backed out changeset cfc1820361f5 (bug 1202902)

--HG--
extra : rebase_source : 5d3db72337754bc7ab0ed0c30b2896100411ff92
2015-10-07 12:13:45 +02:00
Shu-yu Guo
d06b6030f6 Bug 1202902 - Scripted fix the world. 2015-10-06 14:00:31 -07:00
Ethan Tseng
bb095c04f4 Bug 1165267 - Part 1: Replace appId and inBrowser by originAttributes v2. r=honzab 2015-09-03 18:22:51 +08:00
Michael Layzell
2070870d99 Bug 1195492 - Remove the backup moz_hosts table and the moz_hosts_is_backup marker table, r=ehsan 2015-10-03 14:30:52 -04:00
Yoshi Huang
836f7732eb Bug 1210459: Add originAttributes for tests that implement nsILoadContext. r=bholley 2015-09-30 18:14:12 -07:00
Jorg K
367c572f4b Bug 1205983 - Remove all observer code from nsEditor (tests). r=ehsan 2015-09-29 08:25:00 +02:00
Jorg K
1e378ea69e Bug 1205983 - Remove all observer code from nsEditor. r=ehsan 2015-09-28 23:53:00 +02:00
Mike Hommey
d72ba2a81c Bug 1209391 - Remove build/unix/uniq.py. r=mshal 2015-09-30 11:51:46 +09:00
Carsten "Tomcat" Book
3b7a3c96c4 Backed out 2 changesets (bug 1205983) for memory leaks on a CLOSED TREE
Backed out changeset f2c49c0ab84f (bug 1205983)
Backed out changeset a81630dba992 (bug 1205983)
2015-09-29 13:58:35 +02:00
Jorg K
41a777b2d2 Bug 1205983 - Remove all observer code from nsEditor. r=ehsan
--HG--
extra : rebase_source : 3a3375a44d16d1a4a93c670c5ed44adefe6dbb9e
2015-09-28 23:53:00 +02:00
Jorg K
92731da747 Bug 1205983 - Remove all observer code from nsEditor (tests). r=ehsan
--HG--
extra : rebase_source : 71701166ea470c001fba64241545b03361df8a44
2015-09-28 13:28:00 +02:00
Ehsan Akhgari
a07e70aab0 Bug 1208885 - Remove mozGenericWordUtils; r=smaug
Found by Viva64.  In the future we need to add support for more
langauges, but right now mozGenericWordUtils doesn't provide any value.
2015-09-28 09:08:40 -04:00
Mike Kaply
e7b959b233 Bug 1193625 - Fallback to ASCII if AutoConfig UTF-8 conversion fails. r=Mossop, mrbkap 2015-09-28 08:04:47 -05:00
Chris Peterson
71920a9550 Bug 1207030 - Enable -Wshadow flag in more directories that have no -Wshadow warnings. r=glandium 2015-09-22 21:39:03 -07:00
Ehsan Akhgari
59c135c176 Bug 1198078 - Add support for TYPE_INTERNAL_SERVICE_WORKER; r=ckerschb,tanvi 2015-09-16 19:15:30 -04:00
Christoph Kerschbaumer
11958f19c8 Bug 1205151 - Use channel->Open2() in extensions/cookie/nsPermissionManager.cpp (r=sicking) 2015-09-15 19:47:27 -07:00
Shu-yu Guo
64db2267cf Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
sajitk
2b31623cab Bug 1200065 - Split Mozilla specific code from extensions/spellcheck/hunspell directory to glue directory and adjusted moz.build files. r=glandium
--HG--
rename : extensions/spellcheck/hunspell/src/PRemoteSpellcheckEngine.ipdl => extensions/spellcheck/hunspell/glue/PRemoteSpellcheckEngine.ipdl
rename : extensions/spellcheck/hunspell/src/RemoteSpellCheckEngineChild.cpp => extensions/spellcheck/hunspell/glue/RemoteSpellCheckEngineChild.cpp
rename : extensions/spellcheck/hunspell/src/RemoteSpellCheckEngineChild.h => extensions/spellcheck/hunspell/glue/RemoteSpellCheckEngineChild.h
rename : extensions/spellcheck/hunspell/src/RemoteSpellCheckEngineParent.cpp => extensions/spellcheck/hunspell/glue/RemoteSpellCheckEngineParent.cpp
rename : extensions/spellcheck/hunspell/src/RemoteSpellCheckEngineParent.h => extensions/spellcheck/hunspell/glue/RemoteSpellCheckEngineParent.h
rename : extensions/spellcheck/hunspell/src/hunspell_alloc_hooks.h => extensions/spellcheck/hunspell/glue/hunspell_alloc_hooks.h
rename : extensions/spellcheck/hunspell/src/hunspell_fopen_hooks.h => extensions/spellcheck/hunspell/glue/hunspell_fopen_hooks.h
rename : extensions/spellcheck/hunspell/src/moz.build => extensions/spellcheck/hunspell/glue/moz.build
rename : extensions/spellcheck/hunspell/src/mozHunspell.cpp => extensions/spellcheck/hunspell/glue/mozHunspell.cpp
rename : extensions/spellcheck/hunspell/src/mozHunspell.h => extensions/spellcheck/hunspell/glue/mozHunspell.h
rename : extensions/spellcheck/hunspell/src/mozHunspellAllocator.h => extensions/spellcheck/hunspell/glue/mozHunspellAllocator.h
rename : extensions/spellcheck/hunspell/src/mozHunspellDirProvider.cpp => extensions/spellcheck/hunspell/glue/mozHunspellDirProvider.cpp
rename : extensions/spellcheck/hunspell/src/mozHunspellDirProvider.h => extensions/spellcheck/hunspell/glue/mozHunspellDirProvider.h
2015-09-11 07:44:00 +02:00
Jorg K
dd4cd7d08c Bug 697981 - Prevent reloading of spelling dictionary on unfocused editors; r=roc 2015-09-15 11:35:10 +05:30
Michael Layzell
fe31896607 Bug 571294 - Part 1: Implement selection events behind the dom.select_events.enabled pref, r=smaug 2015-09-12 17:56:44 -04:00
Kaustabh Datta Choudhury
2a080acfd0 Bug 1162003 - Enable run-by-dir mode on Fx desktop debug & ASAN builds. r=jmaher 2015-09-10 09:52:00 +02:00
Joel Maher
af2cf10bce backout 06bb0c1766f1 for more frequent bc failures 2015-09-09 07:55:37 -04:00
Kaustabh Datta Choudhury
eeaa15095f Bug 1162003 - Enable run-by-dir mode on Fx desktop debug & ASAN builds. r=jmaher 2015-09-09 05:42:04 -04:00
Ekanan Ketunuti
beb0ebaae0 Bug 1202600 - Add Fukushima to the en-US dictionary. r=ehsan
--HG--
extra : transplant_source : H%06%F8T%A5%93%3AV%CAy%E2E%B1%23%B4%5B%9B%A2M%C7
2015-09-08 16:24:47 +07:00
Christoph Kerschbaumer
109257c376 Bug 1195168 - Use channel->ascynOpen2 src/nsAutoConfig.cpp (r=sicking) 2015-09-03 13:31:56 -07:00
Christoph Kerschbaumer
6eac97dd9e Bug 1197926 - Use channel->Open2() in extensions/pref/autoconfig/src/nsReadConfig.cpp (r=sicking) 2015-09-02 11:38:28 -07:00
Ekanan Ketunuti
cdcd4cc89c Bug 1200508 - Add dialogs to the en-US dictionary. r=ehsan 2015-09-01 11:51:54 +07:00
Nicholas Nethercote
f44287005f Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.

--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
2015-08-27 20:44:53 -07:00
Ehsan Akhgari
bf2e647675 Bug 1199540 - Update the en-US dictionary to SCOWL 2015.08.24 2015-08-27 23:06:54 -04:00
Ekanan Ketunuti
35859eed5f Bug 1199532 - Add disassembly, disassembler to the en-US dictionary. r=ehsan 2015-08-28 08:34:02 +07:00