Commit Graph

4882 Commits

Author SHA1 Message Date
Olli Pettay
b737ae32be Bug 1862311 - Clean up the comments in nsHtml5AtomTable.h and increase the cache size a tiny bit, r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D192392
2023-10-31 23:05:59 +00:00
Randell Jesup
da20da46fa Bug 1857615: Add Telemetry for OnStopRequest/OnDataFinished/etc r=necko-reviewers,kershaw
Also add OnStartRequest telemetry back

Differential Revision: https://phabricator.services.mozilla.com/D190470
2023-10-30 03:03:42 +00:00
Iulian Moraru
0bb848f472 Backed out 2 changesets (bug 1857615, bug 1857926) for causing build bustages on HttpChannelChild.cpp. CLOSED TREE
Backed out changeset b29044126de6 (bug 1857615)
Backed out changeset 8dcb0b3fc1f3 (bug 1857926)
2023-10-28 09:39:18 +03:00
Randell Jesup
3c97fb9428 Bug 1857615: Add Telemetry for OnStopRequest/OnDataFinished/etc r=necko-reviewers,kershaw
Also add OnStartRequest telemetry back

Differential Revision: https://phabricator.services.mozilla.com/D190470
2023-10-28 06:03:48 +00:00
sunil mayya
9a6ec90e93 Bug 1851992 - send onDataFinished notifications from nsInputStreamPump. r=necko-reviewers,jesup
Differential Revision: https://phabricator.services.mozilla.com/D188757
2023-10-27 13:30:12 +00:00
edgul
827cd75825 Bug 1851992 - moving html5 stream parser's OnStopRequest off main thread. r=necko-reviewers,edgul,jesup,valentin,hsivonen
Depends on D187668

Differential Revision: https://phabricator.services.mozilla.com/D187689
2023-10-27 13:30:11 +00:00
Daniel Holbert
aec74c3a0c Bug 1861332: Add a body element to crashtest 1747514.html so that its document.body.appendChild invocation can succeed instead of throwing a JS TypeError. r=bholley
Differential Revision: https://phabricator.services.mozilla.com/D191929
2023-10-26 16:55:41 +00:00
Markus Stange
f304926168 Bug 1861232 - Remove unused interner argument from elementNameByBuffer. r=dom-core,jjaschke,CanadaHonk
Differential Revision: https://phabricator.services.mozilla.com/D191970
2023-10-26 12:17:44 +00:00
Emilio Cobos Álvarez
d3377338b3 Bug 1861068 - Make nsHTML5AttributeName constructors allocate less. r=hsivonen
This removes a bunch of allocations on startup.

Java changes: https://github.com/validator/htmlparser/pull/90

Differential Revision: https://phabricator.services.mozilla.com/D191870
2023-10-25 18:26:49 +00:00
Emilio Cobos Álvarez
555a298c84 Bug 1861010 - Avoid leaking on the nsHtml5AttributeName constructor. rpending=hsivonen CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D191865
2023-10-25 14:04:40 +00:00
Emilio Cobos Álvarez
aec37b313e Bug 1861010 - Improve nsHtml5AttributeName. r=hsivonen
In particular:

 * Store local names, namespaces, etc inline.
 * Avoid taking unnecessary atom references for non-interned atoms.

As a follow-up, we can look into making the input data truly static,
which would be nice.

Depends on D191853

Differential Revision: https://phabricator.services.mozilla.com/D191854
2023-10-25 12:37:26 +00:00
Emilio Cobos Álvarez
d03c3ae7d8 Bug 1861010 - Avoid some duplicated string hashing in the html parser. r=smaug
I need to check whether we can remove the recently used atom stuff, but this
should be uncontroversial.

Differential Revision: https://phabricator.services.mozilla.com/D191853
2023-10-25 11:50:59 +00:00
Narcis Beleuzu
722f6a1679 Backed out 6 changesets (bug 1851992) for DT failure on browser_net_image_cache.js . CLOSED TREE
Backed out changeset 3ceaf46f8f55 (bug 1851992)
Backed out changeset c9d322362e22 (bug 1851992)
Backed out changeset 673df3f83249 (bug 1851992)
Backed out changeset 46e18c56dd39 (bug 1851992)
Backed out changeset f9f9143ac713 (bug 1851992)
Backed out changeset 38c40d735ab7 (bug 1851992)
2023-10-24 13:16:40 +03:00
Mark Banner
31a45737c0 Bug 1858673 - Remove now unnecessary disabling of ESLint no-unsanitized/* rules from test files. r=freddyb,media-playback-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,places-reviewers,aosmond,sgalich,dao,padenot
Differential Revision: https://phabricator.services.mozilla.com/D190985
2023-10-24 08:48:41 +00:00
sunil mayya
d2b6e6de8b Bug 1851992 - send onDataFinished notifications from nsInputStreamPump. r=necko-reviewers,jesup
Differential Revision: https://phabricator.services.mozilla.com/D188757
2023-10-24 01:48:10 +00:00
edgul
e14d121155 Bug 1851992 - moving html5 stream parser's OnStopRequest off main thread. r=necko-reviewers,edgul,jesup,valentin,hsivonen
Depends on D187668

Differential Revision: https://phabricator.services.mozilla.com/D187689
2023-10-24 01:48:09 +00:00
Henri Sivonen
fef29849ec Bug 1857221 - Avoid tracking the line and column number when parsing innerHTML. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D191270
2023-10-23 09:07:22 +00:00
Henri Sivonen
d1d1ba1d91 Bug 1859527 - Update the generated includes in the HTML parser. r=edgar
Differential Revision: https://phabricator.services.mozilla.com/D191186
2023-10-18 08:40:49 +00:00
Edgar Chen
8e9d770444 Bug 1686012 - Make Headless clipboard support the HTML type; r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D191195
2023-10-18 08:15:27 +00:00
Cristina Horotan
ea9336a2ca Backed out 5 changesets (bug 1851992) for causing multiple failures
Backed out changeset d28399b3d947 (bug 1851992)
Backed out changeset 95e4df69007a (bug 1851992)
Backed out changeset fa61d4e76827 (bug 1851992)
Backed out changeset 79969d9eb5cd (bug 1851992)
Backed out changeset 03c17255f1af (bug 1851992)
2023-10-17 14:48:23 +03:00
sunil mayya
b0059a0212 Bug 1851992 - send onDataFinished notifications from nsInputStreamPump. r=necko-reviewers,jesup
Differential Revision: https://phabricator.services.mozilla.com/D188757
2023-10-17 08:27:49 +00:00
edgul
b324bd24fe Bug 1851992 - moving html5 stream parser's OnStopRequest off main thread. r=necko-reviewers,edgul,jesup,valentin,hsivonen
Depends on D187668

Differential Revision: https://phabricator.services.mozilla.com/D187689
2023-10-17 08:27:48 +00:00
Tom Marble
0cb91fe33e Bug 1855300 - convert .ini manifests to .toml: batch 11 remaining **/mochitest.ini r=jmaher,geckoview-reviewers,extension-reviewers,valentin,credential-management-reviewers,cookie-reviewers,sgalich,m_kato,robwu
Differential Revision: https://phabricator.services.mozilla.com/D190515
2023-10-13 02:32:24 +00:00
CanadaHonk
cb607c267a Bug 1856934 - Remove duplicated function in Java HTML parser r=hsivonen
It was duplicated in the patch for Bug 1824121 without being caught.

Differential Revision: https://phabricator.services.mozilla.com/D190486
2023-10-12 09:21:13 +00:00
Emilio Cobos Álvarez
25c0d10932 Bug 1624819 - Remove TaskCategory and other quantum dom remnants. r=smaug,media-playback-reviewers,credential-management-reviewers,cookie-reviewers,places-reviewers,win-reviewers,valentin,mhowell,sgalich,alwu
Sorry this is not a particularly easy patch to review. But it should be
mostly straight-forward.

I kept Document::Dispatch mostly for convenience, but could be
cleaned-up too / changed by SchedulerGroup::Dispatch. Similarly maybe
that can just be NS_DispatchToMainThread if we add an NS_IsMainThread
check there or something (to preserve shutdown semantics).

Differential Revision: https://phabricator.services.mozilla.com/D190450
2023-10-10 08:51:12 +00:00
Henri Sivonen
b936fb1c03 Bug 1854907 - Make document.write-related operations on the creator parser no-ops on scripts whose type does not allow document.write. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D189110
2023-09-28 12:21:39 +00:00
Mirko Brodesser
5a4df671a9 Bug 1855158: replace DEBUG_NS_HTML5_TREE_OP_EXECUTOR_FLUSH with DEBUG and enclosed printf statements with using a LazyLogModule. r=hsivonen
Simplifies debugging.

Differential Revision: https://phabricator.services.mozilla.com/D189203
2023-09-27 14:28:30 +00:00
Cosmin Sabou
6e9a1347fe Backed out changeset 25742a510944 (bug 1855158) for causing non-unified build bustages on nsHtml5TreeOpExecutor.cpp. CLOSED TREE 2023-09-27 15:41:56 +03:00
Mirko Brodesser
eae266f0f2 Bug 1855158: replace DEBUG_NS_HTML5_TREE_OP_EXECUTOR_FLUSH with DEBUG and enclosed printf statements with using a LazyLogModule. r=hsivonen
Simplifies debugging.

Differential Revision: https://phabricator.services.mozilla.com/D189203
2023-09-27 12:07:26 +00:00
Emilio Cobos Álvarez
9e6751a082 Bug 1854446 - Make dynamic atoms store an nsStringBuffer. r=smaug,xpcom-reviewers,nika
Performance results pending, but this shouldn't hurt utf-8 atomization
at all, and it should also make utf-16 atomization potentially cheaper.

So sending for review under the assumption that perf numbers will look
good.

Differential Revision: https://phabricator.services.mozilla.com/D189021
2023-09-27 09:06:06 +00:00
Natalia Csoregi
a6437d542f Backed out changeset 65f49a810f52 (bug 1854446) for causing multiple failures e.g. 368504-4.html. CLOSED TREE 2023-09-27 03:26:28 +03:00
Emilio Cobos Álvarez
128ee32ee2 Bug 1854446 - Make dynamic atoms store an nsStringBuffer. r=smaug,xpcom-reviewers,nika
Performance results pending, but this shouldn't hurt utf-8 atomization
at all, and it should also make utf-16 atomization potentially cheaper.

So sending for review under the assumption that perf numbers will look
good.

Differential Revision: https://phabricator.services.mozilla.com/D189021
2023-09-26 23:14:14 +00:00
Joel Maher
99abb50b8d Bug 1853245 - Migrate .ini manifests to .toml (Batch 7.25). r=aryx,webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D189221
2023-09-26 17:40:01 +00:00
Henri Sivonen
2ea4ba1cf2 Bug 1846178 - Use the async/defer (non-blocking) HTML parser code path for module scripts. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D185797
2023-09-15 07:53:16 +00:00
Mathew Hodson
66ffe4b27e Bug 582361 - Align scrolling to a fragment with HTML spec. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D187362
2023-09-14 09:29:27 +00:00
Cosmin Sabou
e3ddb212bd Backed out changeset ce9c917d3e22 (bug 582361) for causing wpt failures on scroll-frag-percent-encoded.html. CLOSED TREE 2023-09-13 20:52:47 +03:00
Mathew Hodson
9b4650bb45 Bug 582361 - Align scrolling to a fragment with HTML spec. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D187362
2023-09-13 16:04:59 +00:00
Mike Hommey
36d0f4e00d Bug 1851729 - Stop building the parts of expat we don't need when wasm-sandboxing it. r=bholley
While in the vicinity, add a missing define for IS_LITTLE_ENDIAN in
wasm, which in practice has no consequence because the code that depends
on it is not actually used in the wasm sandbox. And since that code is
not used, we also strip it.

Differential Revision: https://phabricator.services.mozilla.com/D187524
2023-09-06 02:55:21 +00:00
Markus Stange
fe7358f6c8 Bug 1843949 - Preallocate attribute array with the known size from parsing. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D183809
2023-09-02 18:46:30 +00:00
Andrew Creskey
baa6cd2868 Bug 1850892 - Remove expiring probe HTTP_PRELOAD_IMAGE_STARTREQUEST_DELAY r=necko-reviewers,valentin
We are working on an alternative approach to improving OnStart/OnStop request timing, and so will remove this probe because it's no longer as relevant and the implementation touchs many classes and methods.

Differential Revision: https://phabricator.services.mozilla.com/D187233
2023-09-01 14:45:06 +00:00
Mirko Brodesser
2966a909e7 Bug 1839316: part 4) Add RequestPriority to ScriptFetchOptions and ScriptLoadRequest. r=smaug
The request priority isn't propagated from `ScriptFetchOptions`, so
setting it has no effect for end-users. That will be implemented in a
following part.

Differential Revision: https://phabricator.services.mozilla.com/D183483
2023-08-28 11:56:34 +00:00
renevietnam29@gmail.com
2a0eb51c7e Bug 1842984 Remove dom.image-lazy-loading.enabled r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D184883
2023-08-23 13:26:36 +00:00
Norisz Fay
c5e74dfe84 Backed out changeset 4a4d5e64aec5 (bug 1846178) for causing mochitest failures on test_script_loader_js_cache.html/cache_module.html CLOSED TREE 2023-08-23 11:19:39 +03:00
Henri Sivonen
acc51e7036 Bug 1846178 - Use the async/defer (non-blocking) HTML parser code path for module scripts. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D185797
2023-08-23 07:11:47 +00:00
Emilio Cobos Álvarez
95707c96bb Bug 1849204 - Add generic atom hash keys that use the better distributed atom hash, and use it across the tree. r=mstange,xpcom-reviewers,credential-management-reviewers,sgalich,nika
Differential Revision: https://phabricator.services.mozilla.com/D186496
2023-08-18 18:43:27 +00:00
Markus Stange
943e3c05a7 Bug 1843946 - Use an atom for the full class attribute value, to reduce string hash key cost during the AtomArrayCache lookup. r=emilio
This generalizes the previous "set single class from parser" fast-path to
also apply when there are multiple classes in the class attribute.

The main benefit is the cheaper cache lookup.
Another benefit is that this avoids a string copy (the same copy that the original
"set single class from parser" optimization avoided).

We now always atomize the full class attribute value before parsing it,
e.g. when somebody uses setAttribute. In the common case of a single class,
this atomization cost would have been paid anyway.

Before: https://share.firefox.dev/4576ulw
After: https://share.firefox.dev/3rNGBsH (though this is not the full story
because the atomization work is moved outside of nsHtml5TreeOperation::SetHTMLElementAttributes)

Differential Revision: https://phabricator.services.mozilla.com/D183813
2023-08-17 19:02:40 +00:00
Sean Feng
aa9228e6a7 Bug 1840191 - Fix a crash where nsContentSink::DidBuildModelImpl gets called with incorrect state r=hsivonen,dom-core
The autofocus algorithm made this noticeable because we now can run
scripts at an earlier time.

Differential Revision: https://phabricator.services.mozilla.com/D182734
2023-08-17 18:22:57 +00:00
Olli Pettay
3d32582619 Bug 1848714 - Use unsafe methods in hot code paths to access and remove elements from nsTArray when it is guaranteed to be safe, r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D186191
2023-08-15 14:24:19 +00:00
Emilio Cobos Álvarez
ea11c5c0b4 Bug 1847811 - Remove network.preload pref. r=necko-reviewers,anti-tracking-reviewers,pbz,kershaw
Having it disabled is not web compatible, and there's no strong reason
to keep it, IMO.

If we want another pref to determine whether preloads are actually
triggered we can add it in the future.

Differential Revision: https://phabricator.services.mozilla.com/D186014
2023-08-14 10:46:03 +00:00
Cosmin Sabou
c406bcf318 Backed out 5 changesets (bug 1839316) for causing bustages on ScriptLoader.cpp. CLOSED TREE
Backed out changeset 85f107e082ee (bug 1839316)
Backed out changeset 8c1e22518c3a (bug 1839316)
Backed out changeset a4c3dec0f34c (bug 1839316)
Backed out changeset 313ff15742dd (bug 1839316)
Backed out changeset fa200e26bbb1 (bug 1839316)
2023-08-09 20:16:06 +03:00