Commit Graph

1721 Commits

Author SHA1 Message Date
Julian Descottes
525aa4d10f Bug 1844133 - [remote] WebSocketConnection logs should be truncated for huge objects r=webdriver-reviewers,Sasha
Puppeteer happens to send huge payloads as part of their test suite when using their $$eval API.
This is because they pass back and forth nodeLists for which all children are serialized by default.
This could be avoided by changing the serialization options (see https://github.com/puppeteer/puppeteer/issues/10582)

But without such a fix, we need to cap the size of the websocket logs, otherwise the logparser is unable to handle the
logs from the bidi puppeteer job.

Differential Revision: https://phabricator.services.mozilla.com/D184108
2023-07-25 07:10:08 +00:00
Julian Descottes
6ced98c5db Bug 1844581 - [remote] NavigationListener should not attempt to serialize browsing context during navigation r=webdriver-reviewers,Sasha
Differential Revision: https://phabricator.services.mozilla.com/D184201
2023-07-24 13:56:10 +00:00
Julian Descottes
1139066cb7 Bug 1844582 - [remote] Stop using setTimeout for browser_NavigationManager_no_navigation.js r=webdriver-reviewers,Sasha
Differential Revision: https://phabricator.services.mozilla.com/D184175
2023-07-21 09:43:02 +00:00
Alexandra Borovova
7d42b11c48 Bug 1841039 - [bidi] Implement "browsingContext.fragmentNavigated" event. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D184099
2023-07-21 07:37:56 +00:00
Julian Descottes
dd0a10cdbe Bug 1805405 - [bidi] Add navigation id to network events for document requests r=webdriver-reviewers,jgraham
Depends on D183770

Differential Revision: https://phabricator.services.mozilla.com/D181131
2023-07-20 11:33:19 +00:00
Julian Descottes
149e2c8e46 Bug 1789484 - [bidi] Add navigation id to existing browsingContext events r=webdriver-reviewers,jgraham
Depends on D183769

Differential Revision: https://phabricator.services.mozilla.com/D181130
2023-07-20 11:33:19 +00:00
Julian Descottes
919322dddd Bug 1763122 - [bidi] Add navigation id to browsingContext.navigate result r=webdriver-reviewers,jgraham
Depends on D183768

Differential Revision: https://phabricator.services.mozilla.com/D181129
2023-07-20 11:33:18 +00:00
Julian Descottes
6be485cf4e Bug 1841010 - [remote] Expose a NavigationManager instance on the RootMessageHandler r=webdriver-reviewers,jgraham
Depends on D180440

Differential Revision: https://phabricator.services.mozilla.com/D183768
2023-07-20 11:33:18 +00:00
Julian Descottes
032421146e Bug 1841010 - [remote] Add a NavigationManager to monitor navigations using JSWindowActors r=webdriver-reviewers,Sasha
Differential Revision: https://phabricator.services.mozilla.com/D180440
2023-07-20 11:33:18 +00:00
Julian Descottes
86f23e52ba Bug 1842619 - [bidi] Serialize header and cookies values as network.BytesValue r=webdriver-reviewers,jgraham
Differential Revision: https://phabricator.services.mozilla.com/D183867
2023-07-19 14:34:09 +00:00
Alexandra Borovova
cf04272d83 Bug 1840998 - [bidi] Add support for "clip" argument to "browsingContext.captureScreenshot" command. r=webdriver-reviewers,jgraham,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D183398
2023-07-18 14:24:19 +00:00
Henrik Skupin
647dfb12ef Bug 1838664 - [webdriver-bidi] Implement "browsingContext.setViewport" command. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D181905
2023-07-13 12:08:56 +00:00
Mark Banner
b63f2ba7f9 Bug 1837176 - Converting httpd.js to an ES module. r=necko-reviewers,webdriver-reviewers,valentin,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D181158
2023-07-12 13:38:34 +00:00
Alexandra Borovova
d1f9427a62 Bug 1842322 - Use "in" operator instead "hasOwnProperty" with "Ci.nsIAppStartup". r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D183152
2023-07-11 08:28:10 +00:00
Makoto Kato
9c6893e72e Bug 1841492 - Convert GeckoViewTestUtils.jsm to ESM. r=webdriver-reviewers,geckoview-reviewers,whimboo,calu
Differential Revision: https://phabricator.services.mozilla.com/D182655
2023-07-09 16:11:39 +00:00
Noemi Erli
e631ff3d66 Backed out changeset 790939d4314e (bug 1836204) for causing wd leak failures 2023-07-07 19:30:37 +03:00
Greg Tatum
36e99c64ea Bug 1836204 - Re-enable translations in automation; r=nordzilla,webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D182926
2023-07-07 10:57:39 +00:00
Alexandra Borovova
c0dfb80659 Bug 1829334 - [bidi] Implement "browser.close" command. r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D181775
2023-07-07 10:50:06 +00:00
Alexandra Borovova
86a079c36f Bug 1829334 - [marionette] Move browser quit logic into shared module. r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D181774
2023-07-07 10:50:06 +00:00
Henrik Skupin
7ebedfced8 Bug 1792529 - [marionette] Remove "Marionette:SingleTap" and legacy actions module. r=webdriver-reviewers,jgraham
Differential Revision: https://phabricator.services.mozilla.com/D158191
2023-06-29 10:10:39 +00:00
Micky
8c897e7756 Bug 1838149 - [remote] Use ".sys.mjs" to reference other ESM modules in ModuleCache.sys.mjs r=webdriver-reviewers,whimboo DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D182224
2023-06-28 07:19:54 +00:00
Henrik Skupin
6ddf5c0b09 Bug 1836514 - [webdriver-bidi] Unwaive Xrays once during Node serialization. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D181906
2023-06-27 12:17:58 +00:00
Peter Van der Beken
b52a207bb0 Bug 1522052 - remove nsIDOMChromeWindow. r=dom-core,webdriver-reviewers,devtools-reviewers,whimboo,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D34310
2023-06-23 14:21:05 +00:00
Alexandra Borovova
5208b45436 Bug 1829337 - [bidi] Implement the "session.end" command. r=webdriver-reviewers,whimboo
Depends on D178621

Differential Revision: https://phabricator.services.mozilla.com/D179671
2023-06-22 14:32:35 +00:00
Henrik Skupin
1f4f920af8 Bug 1490258 - [marionette] Remove moz:useNonSpecCompliantPointerOrigin capability. r=webdriver-reviewers,jgraham
Differential Revision: https://phabricator.services.mozilla.com/D181280
2023-06-21 16:24:08 +00:00
Henrik Skupin
8bbb6cadee Bug 1838381 - Extend waitForInitialPageLoaded for "WebDriver:NewSession" for desktop builds. r=webdriver-reviewers,Sasha
Differential Revision: https://phabricator.services.mozilla.com/D181361
2023-06-19 09:49:28 +00:00
CanadaHonk
3f20822bb0 Bug 1810357 - [cdp] Add HTTP target routes r=webdriver-reviewers,whimboo
Added support for /json/new, /json/activate/{targetId},
/json/close/{targetId}. Rewrote JSONHandler internals to be async
and support different routes by HTTP method, and prefixed routes which
are required by activate and close due to inlining the targetId into the
request url. Also added new tests specific to each, and updated existing.

Should also allow more info to be given via HTTP endpoints in future due
to now being async.

Differential Revision: https://phabricator.services.mozilla.com/D166884
2023-06-16 09:36:47 +00:00
Julian Descottes
91bda90b8a Bug 1838238 - [bidi] Fix responseCompleted for redirects with browsing context swaps r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D180854
2023-06-15 20:57:24 +00:00
Gregory Pappas
03112fe0e9 Bug 1837770 - Remove unused browser.tabs.* prefs r=webdriver-reviewers,geckoview-reviewers,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D180559
2023-06-15 15:45:25 +00:00
Henrik Skupin
28158a3cc4 Bug 1830884 - [webdriver-bidi] Update Navigable's seen nodes map for known nodes. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D177496
2023-06-12 08:53:05 +00:00
Henrik Skupin
a63e4441fd Bug 1830884 - [webdriver-bidi] Add serialization / deserialization helpers to WindowGlobalBiDiModule. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D177495
2023-06-12 08:53:05 +00:00
Henrik Skupin
c8ac684a9b Bug 1830884 - [remote] Make element.sys.mjs a shared module for remote and separate out Marionette specific code. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D177493
2023-06-12 08:53:05 +00:00
Henrik Skupin
e3d5881ac5 Bug 1822466 - [marionette] Check Navigable's seen nodes map for known nodes. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D177492
2023-06-12 08:53:04 +00:00
Henrik Skupin
bf9656d456 Bug 1822466 - [marionette] Add global WebDriverSession map as singleton and allow access for Marionette command parent actor. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D177490
2023-06-12 08:53:04 +00:00
Alexandra Borovova
ca52b8145b Bug 1731730 - [bidi] Implement capability matching for features for the session.new command. r=webdriver-reviewers,jdescottes,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D178619
2023-06-09 17:34:48 +00:00
Narcis Beleuzu
0ec8e1f530 Backed out 3 changesets (bug 1731730) for Btime failures . CLOSED TREE
Backed out changeset 7d1262df9498 (bug 1731730)
Backed out changeset b7ccdf57f5aa (bug 1731730)
Backed out changeset a4e5f80c6793 (bug 1731730)
2023-06-08 21:23:28 +03:00
Alexandra Borovova
e031c9e914 Bug 1731730 - [bidi] Implement capability matching for features for the session.new command. r=webdriver-reviewers,jdescottes,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D178619
2023-06-08 11:47:39 +00:00
Mark Banner
6725448902 Bug 1834176 - Convert consumers of NetUtil.jsm to import the ES module directly. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D178589
2023-06-07 08:42:36 +00:00
Julian Descottes
46373aef81 Bug 1832891 - [remote] Set timeout to 5s for waitForInitialNavigation for new contexts r=webdriver-reviewers,whimboo
Extending the timeout only when we explicitly create a new window or tab should be safe.
On the other hand, initial windows from the browser or new tabs created by the browser UI can remain on the initial document forever, for instance on Android.
So for those cases we keep the current unloadTimeout value.

Differential Revision: https://phabricator.services.mozilla.com/D179710
2023-06-06 13:55:39 +00:00
Julian Descottes
00717ee390 Bug 1836926 - [bidi] Rename originTime to timeOrigin in network events fetchTimingInfo r=webdriver-reviewers,whimboo
We misnamed this field in the initial implementation, so this makes it consistent with the spec at
https://w3c.github.io/webdriver-bidi/#type-network-FetchTimingInfo

Differential Revision: https://phabricator.services.mozilla.com/D180064
2023-06-06 10:19:35 +00:00
Rob Wu
3c0c3a2676 Bug 1836482 - Replace AddonManager.jsm imports with AddonManager.sys.mjs r=Standard8,webcompat-reviewers,twisniewski
This patch was generated as follows:

Run:
`./mach esmify --imports . --prefix=toolkit/mozapps/extensions/AddonManager`
In the output there are linter/prettifier errors due to unused
XPCOMUtils or separate importESModule calls. These have been fixed
manually and verified with `./mach lint --outgoing`.

The `esmify` script also inserts many unwanted newlines around imports
that are broken on two lines due to length. Due to the number of these,
I fixed them programatically.

1. Create patch from the changes so far.
2. From the patch, delete all lines that consist of "+" (i.e. added blank line).
3. Reset the working dir and apply the revised patch.
4. Verify that the diff between step 1 and 3 looks reasonable.
5. Verify that this patch as a whole looks reasonable.

Commands:

```
git diff > rename.diff
:%g/^+$/d
git commit -va -m WIP-rename
git revert HEAD
git apply --recount rename.diff
git diff HEAD^  # and verify that the removed lines are ok.
git commit -va  # one last review to verify correctness of whole patch.
git rebase -i HEAD~3  # drop the WIP + reverted commit, pick only the last.
```

`git apply` has the `--recount` option to force it to ignore mismatches
in line counts, which happens because we deleted added lines (^+$)
without fixing up the line counts in the file headers.

Differential Revision: https://phabricator.services.mozilla.com/D179874
2023-06-04 13:44:45 +00:00
Julian Descottes
97a4425c18 Bug 1836093 - [remote] Disable browser.translations.enable in automation r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D179581
2023-06-01 06:21:23 +00:00
Norisz Fay
b8281d9d60 Backed out changeset 23a3b1b5a2b7 (bug 1816538) for causing Bug 1835822, Bug 1835819, Bug 1835796 CLOSED TREE 2023-05-30 16:00:14 +03:00
Julian Descottes
209bd1b851 Bug 1791715 - [bidi] Enable unlimited stack trace capturing for BiDi realms r=webdriver-reviewers,Sasha
Differential Revision: https://phabricator.services.mozilla.com/D179244
2023-05-30 09:52:28 +00:00
Julian Descottes
ae292ebba6 Bug 1816538 - [remote] WaitForInitialNavigation should use a longer unloadTimeout r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D179411
2023-05-30 06:54:13 +00:00
Henrik Skupin
dfacfcca83 Bug 1834971 - [remote] Add optional data field to WebDriver error classes. r=webdriver-reviewers,Sasha
Differential Revision: https://phabricator.services.mozilla.com/D179133
2023-05-26 16:54:18 +00:00
scottlynotlie
2f9be35cb4 Bug 1788013 - changed hasModule to hasModuleClass r=jdescottes,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D179128
2023-05-26 21:47:28 +00:00
Sandor Molnar
b99f663cd9 Backed out changeset 8ef568d7513d (bug 1834971) for causing leakcheck failures. CLOSED TREE 2023-05-26 21:30:29 +03:00
Henrik Skupin
111acc75c1 Bug 1834971 - [remote] Add optional data field to WebDriver error classes. r=webdriver-reviewers,Sasha
Differential Revision: https://phabricator.services.mozilla.com/D179133
2023-05-26 16:54:18 +00:00
michaelshum321
20e77a0edd Bug 1787997 - Refactor remote UUID Usage to a Shared UUID Module r=jdescottes,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D178727
2023-05-25 07:36:22 +00:00
Victoria Ajala
759eec6a96 Bug 1788050 - [remote] Use timer from Timer.sys.mjs to prevent throttling in background tabs r=whimboo,webdriver-reviewers
Using "window.setTimeout()" in content processes will throttle the code if the related window is in a background window. This could cause unexpected race conditions. By using the Timer module this behavior can be avoided.

Differential Revision: https://phabricator.services.mozilla.com/D177034
2023-05-24 12:41:50 +00:00
Natalia Csoregi
e87ecf485e Backed out 3 changesets (bug 1834222, bug 1834176) for causing RemoteProcessMonitor failures. CLOSED TREE
Backed out changeset 346d3a1568dd (bug 1834222)
Backed out changeset ea1d8b634bfc (bug 1834176)
Backed out changeset 74d1880272d3 (bug 1834176)
2023-05-24 04:29:45 +03:00
Mark Banner
fbc15bdb60 Bug 1834176 - Convert NetUtil.jsm to be an ES system module. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D178589
2023-05-23 19:09:29 +00:00
Katherine Patenio
75bab3bab8 Bug 1830809 - Convert JS modules in browser/components/syncedtabs to ES module r=webdriver-reviewers,Standard8,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D178368
2023-05-23 17:48:42 +00:00
Noemi Erli
aa2f146d78 Backed out 2 changesets (bug 1834176) for causing xpc failures in test_unload.js CLOSED TREE
Backed out changeset 57876d77a652 (bug 1834176)
Backed out changeset ae2f0837b528 (bug 1834176)
2023-05-23 12:14:37 +03:00
Mark Banner
e3e9a991b8 Bug 1834176 - Convert NetUtil.jsm to be an ES system module. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D178589
2023-05-23 08:13:08 +00:00
Dan Robertson
e5b4659701 Bug 1821733 - End the current wheel event group on perform action. r=webdriver-reviewers,whimboo
Ensure that a wheel event group does not live longer than the action
chain, by calling EndTransaction on performActions().

Depends on D177923

Differential Revision: https://phabricator.services.mozilla.com/D177924
2023-05-22 19:50:10 +00:00
Julian Descottes
548bf8633f Bug 1832028 - [bidi] Throw NoSuchElement if ElementOrigin's node is not an element r=webdriver-reviewers,whimboo
At the moment the actions module would already throw an InvalidArgument error, but for BiDi we want explicitly to throw NoSuchElement in this case.

Differential Revision: https://phabricator.services.mozilla.com/D178185
2023-05-22 14:05:27 +00:00
Mark Banner
2a53076d43 Bug 1826063 - Automatic fixes for enabling Prettier on production xhtml and html files. r=mossop,webdriver-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,fxview-reviewers,sgalich,nalexander,devtools-reviewers,sclements,denschub,robwu,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177938
2023-05-20 12:26:56 +00:00
Mark Banner
730da94f3a Bug 1826062 - Manual fixes for Prettier 2.8.8 upgrade. r=mossop,webdriver-reviewers,extension-reviewers,devtools-reviewers,robwu
Differential Revision: https://phabricator.services.mozilla.com/D177908
2023-05-20 12:26:55 +00:00
Mark Banner
130a655906 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
8219a5c503 Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Natalia Csoregi
4ab7fd28a6 Merge mozilla-central to autoland. a=merge CLOSED TREE 2023-05-16 15:37:05 +03:00
Natalia Csoregi
2d404ebada Backed out 8 changesets (bug 1830884, bug 1822466) for causing regressions in the upstream wpt tests. a=backout
Backed out changeset 7f4052a38bc6 (bug 1830884)
Backed out changeset 67d5d6a5f321 (bug 1830884)
Backed out changeset 77f0334c7976 (bug 1830884)
Backed out changeset 31607d74ee69 (bug 1830884)
Backed out changeset 256239106623 (bug 1822466)
Backed out changeset d94b6d6cd713 (bug 1822466)
Backed out changeset 2c6d325cb248 (bug 1822466)
Backed out changeset b89608b3c46a (bug 1822466)
2023-05-16 15:33:54 +03:00
Henrik Skupin
4a00fc9777 Bug 1832380 - [webdriver-bidi] Remove experimental flag for "input.performActions" and "input.releaseActions". r=webdriver-reviewers,jgraham
Differential Revision: https://phabricator.services.mozilla.com/D178091
2023-05-16 06:03:56 +00:00
Alexandra Borovova
a064092ce2 Bug 1790185 - [marionette] Use PollPromise when trying to connect to marionette server. r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D177134
2023-05-15 08:04:02 +00:00
James Teh
f2ba08adbd Bug 1828816: Marionette accessibility.getAccessible: If the requested Accessible doesn't exist, force refresh driver ticks and retry. r=whimboo,webdriver-reviewers
Some tests dynamically add elements to the DOM.
Since accessibility updates occur in refresh driver ticks, the Accessible often wasn't created yet when WebDriver requested it, causing intermittent WPT failures.
Now, we force refresh driver ticks to give accessibility a chance to update.

Differential Revision: https://phabricator.services.mozilla.com/D177851
2023-05-12 21:31:24 +00:00
Henrik Skupin
5afb9b7667 Bug 1830884 - [webdriver-bidi] Update Navigable's seen nodes map for known nodes. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D177496
2023-05-12 19:15:56 +00:00
Henrik Skupin
caf750491b Bug 1830884 - [webdriver-bidi] Add serialization / deserialization helpers to WindowGlobalBiDiModule. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D177495
2023-05-12 19:15:56 +00:00
Henrik Skupin
ae48ea1fd1 Bug 1830884 - [webdriver-bidi] Added WebDriver BiDi base module for root destination. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D177494
2023-05-12 19:15:56 +00:00
Henrik Skupin
e7c0624686 Bug 1830884 - [remote] Make element.sys.mjs a shared module and separate out WebReference for Marionette only.. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D177493
2023-05-12 19:15:56 +00:00
Henrik Skupin
377ff8fb69 Bug 1822466 - [marionette] Check Navigable's seen nodes map for known nodes. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D177492
2023-05-12 19:15:56 +00:00
Henrik Skupin
cb7c4b36b3 Bug 1822466 - [marionette] Move WebElement and ShadowRoot serialization/deserialization helpers to Marionette command client actor. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D177491
2023-05-12 19:15:55 +00:00
Henrik Skupin
7d0e610e9a Bug 1822466 - [marionette] Add global WebDriverSession map as singleton and allow access for Marionette command parent actor. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D177490
2023-05-12 19:15:55 +00:00
James Teh
60fc6f7553 Bug 1832750: Marionette sync.waitForObserverTopic: Support a timeout option. r=whimboo,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D175990
2023-05-12 06:51:41 +00:00
Natalia Csoregi
75454ab16e Backed out 2 changesets (bug 1828816) for frequent failures on /html-aam/roles.html CLOSED TREE
Backed out changeset f3f51a672d70 (bug 1828816)
Backed out changeset 190da2ededf7 (bug 1828816)
2023-05-11 18:18:37 +03:00
Iulian Moraru
226e06a38e Merge mozilla-central to autoland on a CLOSED TREE 2023-05-11 16:18:52 +03:00
Iulian Moraru
5b0f4d5adf Backed out changeset 05208f2e0785 (bug 1790185) for causing local failures for Marinoette tests. a=backout 2023-05-11 16:07:55 +03:00
James Teh
b3e806a187 Bug 1828816 part 2: Marionette accessibility.getAccessible: If the requested Accessible doesn't exist, wait for it to be created. r=jdescottes,webdriver-reviewers,whimboo
Some tests dynamically add elements to the DOM.
Since accessibility updates occur in refresh driver ticks, the Accessible often wasn't created yet when WebDriver requested it, causing intermittent WPT failures.
See the code comments for an explanation of how this works.

Differential Revision: https://phabricator.services.mozilla.com/D175972
2023-05-11 10:29:30 +00:00
James Teh
f5b5c7c806 Bug 1828816 part 1: Marionette sync.waitForObserverTopic: Support a timeout option. r=whimboo,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D175990
2023-05-11 10:29:30 +00:00
Alexandra Borovova
759ef2eb66 Bug 1790185 - [marionette] Use PollPromise when trying to connect to marionette server. r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D177134
2023-05-09 15:57:53 +00:00
Julian Descottes
e1061170bb Bug 1832031 - [bidi] Deserialize action element origins early in input module r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D177467
2023-05-09 15:05:50 +00:00
Alexandra Borovova
3d6db0dae7 Bug 1824908 - [puppeteer] Sync vendored puppeteer to v20.1.0. r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D177247
2023-05-09 12:51:05 +00:00
Cristian Tuns
b123f91b9c Backed out 2 changesets (bug 1828816) for causing wpt failures in roles.html CLOSED TREE
Backed out changeset a84313d70b9f (bug 1828816)
Backed out changeset f01409331e4b (bug 1828816)
2023-05-08 04:04:50 -04:00
James Teh
8da53261a2 Bug 1828816 part 2: Marionette accessibility.getAccessible: If the requested Accessible doesn't exist, wait for it to be created. r=jdescottes,webdriver-reviewers,whimboo
Some tests dynamically add elements to the DOM.
Since accessibility updates occur in refresh driver ticks, the Accessible often wasn't created yet when WebDriver requested it, causing intermittent WPT failures.
See the code comments for an explanation of how this works.

Differential Revision: https://phabricator.services.mozilla.com/D175972
2023-05-08 03:38:50 +00:00
James Teh
d507939b50 Bug 1828816 part 1: Marionette sync.waitForObserverTopic: Support a timeout option. r=whimboo,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D175990
2023-05-08 03:38:50 +00:00
Julian Descottes
23354acf57 Bug 1806788 - [remote] Support actions using an element origin r=webdriver-reviewers,jgraham
Depends on D177080

Differential Revision: https://phabricator.services.mozilla.com/D177078
2023-05-05 16:32:21 +00:00
Julian Descottes
e1574164ba Bug 1831411 - [remote] Commands send to root modules from windowglobal should run in the parent r=webdriver-reviewers,Sasha
Depends on D177181

Quick summary:

Handling a command is mostly done in 2 steps
- first check if there is a module in the current layer which matches the command
- if yes: send the command to this module, if no: try to forward the command (using forwardCommand which has different implementations for each message handler)

The initial patch to allow windowglobal -> root communication was flawed, because it updated the ModuleCache to return "root" modules when the destination was of type ROOT. However that's not how MessageHandler modules are supposed to work. The ModuleCache should only ever return modules which can be loaded in the current "layer". So if we are in a windowglobal ModuleCache, we should never return a "root" module.

Instead the ModuleCache should return (and store) `null` for this load attempt, so that the MessageHandler can go to the `forwardCommand` step.
So here I slightly changed the ModuleCache implementation to have a single `#getModuleClass` private helper, which can quickly check if we are in a "not root" -> "root" scenario and just return null early.

Follow up: I think some of the logic currently kept in the module cache should move to the MessageHandler, and the ModuleCache should only care about caching module classes/instances. All the destination-to-folder logic is really tied to handling commands, so that should be done by the base MessageHandler class. Or at least it should be closer to the `handleCommand` implementation.

Differential Revision: https://phabricator.services.mozilla.com/D177202
2023-05-05 13:38:21 +00:00
Julian Descottes
69e1106abb Bug 1831373 - [remote] Remove all logic from ModuleRegistry classes r=webdriver-reviewers,whimboo
Depends on D177180

Differential Revision: https://phabricator.services.mozilla.com/D177181
2023-05-05 13:38:21 +00:00
Julian Descottes
ebaa1d12fb Bug 1831373 - [remote] Use a regular ModuleRegistry for MessageHandler browser mochitests r=webdriver-reviewers,whimboo
Depends on D177179

Differential Revision: https://phabricator.services.mozilla.com/D177180
2023-05-05 13:38:20 +00:00
Julian Descottes
d74e496f4b Bug 1831373 - [remote] Fix sendRootCommand trying to reach root-in-windowglobal layer r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D177179
2023-05-05 13:38:20 +00:00
Alexandra Borovova
d6cc667590 Bug 1731589 - [bidi] Use default realm from message handler in log module. r=webdriver-reviewers,jdescottes
Depends on D176393

Differential Revision: https://phabricator.services.mozilla.com/D176662
2023-05-04 06:47:09 +00:00
Mathew Hodson
5ee28fedd1 Bug 1830460 - Convert ComponentUtils.jsm to ESM. r=arai,webdriver-reviewers,webcompat-reviewers,credential-management-reviewers,devtools-reviewers,twisniewski,sgalich,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D176782
2023-05-03 15:18:46 +00:00
Julian Descottes
fea56ca2b2 Bug 1830404 - [remote] Support sending message handler commands from windowglobal to root r=webdriver-reviewers,whimboo
Depends on D176713

Differential Revision: https://phabricator.services.mozilla.com/D176714
2023-05-02 20:11:50 +00:00
Julian Descottes
9fa2ad7bd9 Bug 1830404 - [remote] Rename transport helpers referring to frame r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D176713
2023-05-02 20:11:50 +00:00
Julian Descottes
111dd3a198 Bug 1829630 - [bidi] Throw explicit error for missing stacks in script module r=webdriver-reviewers,Sasha
Depends on D176353

Differential Revision: https://phabricator.services.mozilla.com/D176354
2023-04-27 16:53:29 +00:00
Julian Descottes
93f5685ca6 Bug 1829630 - [bidi] Use promiseAllocationSite as fallback to fetch rejected promise stacktrace r=webdriver-reviewers,Sasha
Differential Revision: https://phabricator.services.mozilla.com/D176353
2023-04-27 16:53:29 +00:00
Alexandra Borovova
e170405d8b Bug 1788894 - Move Realm related logic from script module to the WindowGlobal message manager. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D176393
2023-04-27 14:04:39 +00:00
Narcis Beleuzu
1a51e46de2 Backed out 2 changesets (bug 1828816) for wpt failures on roles.html . CLOSED TREE
Backed out changeset a7c266597175 (bug 1828816)
Backed out changeset 5802edc7adc3 (bug 1828816)
2023-04-27 12:25:19 +03:00
James Teh
2bb008703c Bug 1828816 part 2: Marionette accessibility.getAccessible: If the requested Accessible doesn't exist, wait for it to be created. r=jdescottes,webdriver-reviewers,whimboo
Some tests dynamically add elements to the DOM.
Since accessibility updates occur in refresh driver ticks, the Accessible often wasn't created yet when WebDriver requested it, causing intermittent WPT failures.
See the code comments for an explanation of how this works.

Differential Revision: https://phabricator.services.mozilla.com/D175972
2023-04-27 04:50:34 +00:00
James Teh
ae8b2a6eb0 Bug 1828816 part 1: Marionette sync.waitForObserverTopic: Support a timeout option. r=whimboo,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D175990
2023-04-27 04:50:34 +00:00
Natalia Csoregi
547c9f911f Backed out changeset a24a3cdae60f (bug 1788894) for causing wd failures on script.sys.mjs. CLOSED TREE 2023-04-26 13:14:39 +03:00
Alexandra Borovova
ba00cf8dda Bug 1788894 - Move Realm related logic from script module to the WindowGlobal message manager. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D176393
2023-04-26 08:20:09 +00:00
James Teh
bd5b6f3d3f Bug 1822112: Make Marionette/WebDriver getComputedRole return standardized ARIA role names. r=jdescottes,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D175586
2023-04-26 00:22:27 +00:00
Victoria Ajala
92a0bfa276 Bug 1617549 - [CDP] Added unwritable margin print settings. r=whimboo,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176305
2023-04-25 15:11:11 +00:00
Stanca Serban
041c4044bd Backed out 8 changesets (bug 1828816, bug 1822112, bug 1572512, bug 1824935) for causing multiple failures. CLOSED TREE
Backed out changeset 8886f7011919 (bug 1822112)
Backed out changeset df566bce405d (bug 1828816)
Backed out changeset 5857e8ef63e1 (bug 1828816)
Backed out changeset 50324d39e9c1 (bug 1822112)
Backed out changeset 7f6bee1959fb (bug 1572512)
Backed out changeset 4effd0bdc4db (bug 1824935)
Backed out changeset a8faf17fcce8 (bug 1824935)
Backed out changeset 0370b0032eb6 (bug 1824935)
2023-04-25 07:45:58 +03:00
James Teh
61719252cf Bug 1828816 part 2: Marionette accessibility.getAccessible: If the requested Accessible doesn't exist, wait for it to be created. r=jdescottes,webdriver-reviewers,whimboo
Some tests dynamically add elements to the DOM.
Since accessibility updates occur in refresh driver ticks, the Accessible often wasn't created yet when WebDriver requested it, causing intermittent WPT failures.
See the code comments for an explanation of how this works.

Differential Revision: https://phabricator.services.mozilla.com/D175972
2023-04-24 23:35:51 +00:00
James Teh
bbe1cab088 Bug 1828816 part 1: Marionette sync.waitForObserverTopic: Support a timeout option. r=whimboo,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D175990
2023-04-24 23:35:51 +00:00
James Teh
70c4863c34 Bug 1822112: Make Marionette/WebDriver getComputedRole return standardized ARIA role names. r=jdescottes,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D175586
2023-04-24 23:35:51 +00:00
anwar
acb6cab567 Bug 1826705 - Make destroy method of MessageHandler modules optional. r=jdescottes,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176294
2023-04-24 14:00:41 +00:00
Alexandra Borovova
131420d6e4 Bug 1824187 - [bidi] Add support for channels to script.callFunction and script.addPreloadScript commands. r=webdriver-reviewers,jdescottes,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D175882
2023-04-21 16:03:08 +00:00
Victoria Ajala
df57e6b178 Bug 1820738 - Used a custom Module base class for WebDriver BiDi. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D175232
2023-04-18 21:05:49 +00:00
Emily McDonough
6170eb43cc Bug 1828543 - Only log PDF load failure in WPT print-tests when a failure actually occurs r=webdriver-reviewers,jgraham
Differential Revision: https://phabricator.services.mozilla.com/D175718
2023-04-18 21:00:12 +00:00
Peter Van der Beken
635046af85 Bug 1804140 - Enable SHIP by default on desktop, whether or not Fission is disabled. r=smaug,jgraham,webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D172278
2023-04-18 07:07:05 +00:00
Nicholas Rishel
c7338fc8c0 Bug 1827713 - Move marionette/Building.md shell commands into code blocks so they render on firefox-source-docs.mozilla.org r=whimboo
Bonus: Move mozbuild configs into code blocks too.

Differential Revision: https://phabricator.services.mozilla.com/D175280
2023-04-17 18:29:26 +00:00
Julian Descottes
00c6191e69 Bug 1828392 - [remote] Fix Log helpers isTrace/DebugLevelOrAbove r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D175606
2023-04-17 11:46:54 +00:00
Alexandra Borovova
70d5109248 Bug 1824953 - [bidi] Update serialization to use serializationOptions. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D175359
2023-04-17 08:35:55 +00:00
Cosmin Sabou
60f701f2e5 Backed out 2 changesets (bug 1804140) for causing webdriver failures. CLOSED TREE
Backed out changeset 974558fd2790 (bug 1804140)
Backed out changeset dbe9d2f66fcc (bug 1804140)
2023-04-14 13:28:44 +03:00
Peter Van der Beken
e0b98d564b Bug 1804140 - Enable SHIP by default on desktop, whether or not Fission is disabled. r=smaug,jgraham,webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D172278
2023-04-14 08:09:50 +00:00
CanadaHonk
6bfc78e060 Bug 1811130 - [cdp] Fix Target.setDiscoverTargets emitting targetCreated events with discover false r=webdriver-reviewers,whimboo
Target.setDiscoverTargets should only emit targetCreated events when ran
with discover as true. Also added tests for discover false.

Differential Revision: https://phabricator.services.mozilla.com/D167210
2023-04-13 16:42:37 +00:00
Henrik Skupin
377c5eb43a Bug 1776190 - [marionette] Allow a modifier key to be reset when sending it again within the same command. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D175242
2023-04-13 16:18:24 +00:00
Julian Descottes
ac919d7e3d Bug 1827726 - [remote] Skip WebSocketConnection _log if debug logs are disabled r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D175324
2023-04-13 11:56:03 +00:00
Julian Descottes
9f314d6913 Bug 1825634 - [bidi] Use document URL for load and domContentLoaded events r=webdriver-reviewers,Sasha
Differential Revision: https://phabricator.services.mozilla.com/D174173
2023-04-12 13:35:26 +00:00
Henrik Skupin
41a9ed7fb3 Bug 1826048 - [marionette] Don't mention TimedPromise in navigation timeout error message. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D174911
2023-04-06 20:41:32 +00:00
Henrik Skupin
0d417463d4 Bug 1821039 - [webdriver-bidi] Fix broken object handle tests in browser_RemoteValue.js. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D174903
2023-04-06 15:43:08 +00:00
CanadaHonk
5cf1dabcc0 Bug 1811049 - [cdp] Implement filter option for Target.setDiscoverTargets r=webdriver-reviewers,whimboo
Implement the filter option for Target.setDiscoverTargets, using
internal function created previously.

Also rewrote tests for Target.setDiscoverTargets, and some internal test
helpers.

Tweaked Puppeteer to accommodate for these changes, now using a
filter for Target.setDiscoverTargets like Chrome.
Upstream: https://github.com/puppeteer/puppeteer/pull/9693

Differential Revision: https://phabricator.services.mozilla.com/D167209
2023-04-06 15:25:08 +00:00
Julian Descottes
e0156aba7c Bug 1826706 - [bidi] Add missing destroy in windowglobal input module r=webdriver-reviewers,whimboo
Depends on D174847

Bug 1826705 was filed to discuss about the issue around missing destroy implementations.

Differential Revision: https://phabricator.services.mozilla.com/D174849
2023-04-06 14:49:50 +00:00
Julian Descottes
bbe0a46e89 Bug 1826706 - [bidi] Throw a NoSuchFrameError in input.performActions if no context is found r=webdriver-reviewers,whimboo
Per spec, we should throw if the provided context is not found.

Differential Revision: https://phabricator.services.mozilla.com/D174847
2023-04-06 14:49:49 +00:00
Saira Abdulla
a4517586e4 Bug 1821039 - 'script.callFunction' has to fail with 'no such handle' error if the handle of an object as passed as argument is unknown. r=whimboo,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D174343
2023-04-06 13:30:48 +00:00
Henrik Skupin
f90e86c710 Bug 1826709 - [CDP] Prevent "/json/*" pages from being loaded within an iframe. r=webdriver-reviewers,freddyb,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D174860
2023-04-06 11:42:16 +00:00
Henrik Skupin
073ee7078b Bug 1586503 - [cdp] Fix test eventsWhenNavigatingFrameSet for expected event order. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D174771
2023-04-05 20:54:38 +00:00
Julian Descottes
c0f871815e Bug 1826366 - [remote] Manual fixes for valid-jsdoc in remote r=webdriver-reviewers,whimboo
Depends on D174738

Differential Revision: https://phabricator.services.mozilla.com/D174739
2023-04-05 16:25:48 +00:00
Julian Descottes
7ccbffb9f7 Bug 1826366 - [remote] Apply lint --fix for valid-jsdoc in remote r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D174738
2023-04-05 16:25:47 +00:00
Victoria Ajala
aebcad9703 Bug 1819174 Update test suite default tags for remote protocol component. r=whimboo,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D174239
2023-04-05 15:36:28 +00:00
Alexandra Borovova
d127a21247 Bug 1806792 - [bidi] Implement "input.releaseActions" command. r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D174246
2023-04-04 12:05:08 +00:00
Mark Banner
d3b304539a Bug 1825739 - Replace generic ESLint disable statements with specific and prettier ones in remote/. r=webdriver-reviewers,whimboo
Depends on D174226

Differential Revision: https://phabricator.services.mozilla.com/D174227
2023-04-03 10:23:52 +00:00
Henrik Skupin
9d12970ac8 Bug 1818080 - [remote] Add profile markers for CDP, Marionette and WebDriver BiDi commands and events. r=webdriver-reviewers,canaltinova,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D174211
2023-03-31 12:42:44 +00:00
James Graham
2313f21853 Bug 1792090 - Add input module support to WebDriver BiDi r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D157972
2023-03-30 15:23:17 +00:00
James Graham
5562f02a7c Bug 1792090 - Move action module to remote/shared/webdriver r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D157970
2023-03-30 15:23:17 +00:00
Alexandra Borovova
b050900241 Bug 1802137 - [bidi] Enhance support for serialization and deserialization of platform objects of type Node for ShadowRoot. r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D173297
2023-03-30 08:17:36 +00:00
ogiorgis
f59f695642 Bug 1621950 - fix some myst ref warnings r=firefox-source-docs-reviewers,devtools-reviewers,sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D173843
2023-03-30 08:01:22 +00:00
Lata
5528bda290 Bug 1823612 - Remove usage of marionette.log.level from Log.sys.mjs. r=whimboo,webdriver-reviewers,perftest-reviewers,sparky
Differential Revision: https://phabricator.services.mozilla.com/D173207
2023-03-29 15:21:16 +00:00
Julian Descottes
4bbf1c5698 Bug 1815460 - [devtools] Merge addRequestPostData, addResponseHeaders, addResponseCookies into addResponseStart r=webdriver-reviewers,ochameau,bomsy,devtools-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D168538
2023-03-25 20:29:59 +00:00
Csoregi Natalia
a04681d292 Backed out 2 changesets (bug 1815460) for causing netmonitor devtools failures. CLOSED TREE
Backed out changeset 14ac0e2bcccb (bug 1815460)
Backed out changeset 7765cf9b63f5 (bug 1815460)
2023-03-24 22:20:30 +02:00
Julian Descottes
cbe400b445 Bug 1815460 - [devtools] Merge addRequestPostData, addResponseHeaders, addResponseCookies into addResponseStart r=webdriver-reviewers,ochameau,bomsy,devtools-reviewers,whimboo
Depends on D169361

Differential Revision: https://phabricator.services.mozilla.com/D168538
2023-03-24 16:14:44 +00:00
Frazier Odhiambo
8ab1f55f02 Bug 1610317 - [cdp] Use SpecialPowers.spawn instead of ContentTask.spawn in browser chrome tests. r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D172399
2023-03-23 13:45:53 +00:00
Alexandra Borovova
6d1ad5f6f8 Bug 1791819 - [marionette] Add support for the orientation parameter in WebDriver:Print. r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D173413
2023-03-23 13:08:29 +00:00
CanadaHonk
2165378ccd Bug 1823089 - [cdp] Request longer timeout for consoleAPICalled tests r=webdriver-reviewers,whimboo
Fixes perma test fails due to more tests added previously triggering
timeouts.

Differential Revision: https://phabricator.services.mozilla.com/D173255
2023-03-22 16:02:31 +00:00
Julian Descottes
37482a46bd Bug 1822772 - [bidi] Use windowRoot to monitor load events r=webdriver-reviewers,whimboo
Depends on D173132

Event listeners are removed when using document.open, so we should use windowRoot instead

Differential Revision: https://phabricator.services.mozilla.com/D173020
2023-03-22 13:18:22 +00:00
Julian Descottes
0232a50aa5 Bug 1823670 - [messagehandler] Destroy MessageHandlers when pages move to BFCache r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D173132
2023-03-22 13:18:22 +00:00
Henrik Skupin
43234ab776 Bug 1823464 - [marionette] Handle DOMTokenList instances as collection. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D173068
2023-03-21 18:28:36 +00:00
Frazier Odhiambo
9ac5475c8f Bug 1816664 Rename addSessionData/removeSessionData methods of RootMessageHandler to addSessionDataItem/removeSessionDataItem r=webdriver-reviewers,Sasha
Differential Revision: https://phabricator.services.mozilla.com/D172513
2023-03-21 07:57:31 +00:00
Julian Descottes
0b454f39f1 Bug 1585622 - [marionette] Add support for getComputedRole and getComputedLabel r=webdriver-reviewers,whimboo
A base getAccessible helper is extracted from the accessibility.Checks module to avoid issues related to the "strict" flag, which do not make sense here.

Differential Revision: https://phabricator.services.mozilla.com/D172146
2023-03-20 21:46:01 +00:00
Dan Robertson
126bc64c16 Bug 1168182 - Update webdriver recommended prefs. r=whimboo,webdriver-reviewers,jdescottes
Update the webdriver recommended preferences to include
dom.events.wheel-event-groups.enabled=false

Differential Revision: https://phabricator.services.mozilla.com/D172025
2023-03-20 12:19:36 +00:00
CanadaHonk
3dc5d98c1a Bug 1679887 - [cdp] Emit past console messages on Runtime.enable r=jdescottes
Emit past console messages with Runtime.consoleAPICalled as
Runtime.enable is ran. Also added new test.

Depends on D170131

Differential Revision: https://phabricator.services.mozilla.com/D170136
2023-03-16 20:25:31 +00:00
CanadaHonk
366960831d Bug 1679981 - [cdp] Implement stackTrace for Runtime.consoleAPICalled r=webdriver-reviewers,whimboo
Implemented stackTrace for Runtime.consoleAPICalled. Added new tests
covering it as well. Tweaked internals for Runtime to have separate
functions for creating stack traces for console and exception types,
as they differ unfortunately.

Differential Revision: https://phabricator.services.mozilla.com/D170131
2023-03-16 20:25:30 +00:00
Alexandra Borovova
fda4583388 Bug 1700095 - [marionette] Add support for finding elements from shadow roots. r=webdriver-reviewers,jdescottes,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D172212
2023-03-16 19:19:40 +00:00
Alexandra Borovova
8ecbf74a4f Bug 1700095 - [marionette] Move fromUUID helper from WebReference to WebElement class. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D172687
2023-03-16 19:19:40 +00:00
Julian Descottes
ab3931ad56 Bug 1806794 - Support "network.response" events for cached responses r=webdriver-reviewers,whimboo,devtools-reviewers,ochameau
This fixes two issues:
- the transferred size was missing from cached responseStarted events
- the fromCache flag needs to be read on the initial network event payload from devtools, because relying on the isFromCache logic used to build the addResponseStart payload does not properly detect all cached responses (eg for a cached 301)

Differential Revision: https://phabricator.services.mozilla.com/D171508
2023-03-16 14:01:03 +00:00
Alexandra Borovova
8f8a400ed5 Bug 1783086 - [marionette] Rename printBackground to background for WebDriver compatibility. r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D171693
2023-03-13 16:20:18 +00:00
CanadaHonk
e617726b87 Bug 1820459 - [cdp] Split-off Promise tests for evaluate and callFunctionOn r=webdriver-reviewers,whimboo
Split-off (await)Promise tests for evaluate and callFunctionOn into
their own separate test files to avoid timeouts whilst testing.

Differential Revision: https://phabricator.services.mozilla.com/D172053
2023-03-09 11:45:33 +00:00
Henrik Skupin
14f639087f Bug 1770733 - [bidi] Serialize and deserialize objects of type Node with sharedId field. r=webdriver-reviewers,Sasha,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D169490
2023-03-08 22:30:05 +00:00
Julian Descottes
b5e9114eb4 Bug 1815459 - [devtools] Remove NetworkUtils.createNetworkEvent r=ochameau,bomsy,devtools-reviewers
Depends on D168537

Differential Revision: https://phabricator.services.mozilla.com/D168791
2023-03-07 21:36:06 +00:00
Julian Descottes
2396effc3f Bug 1815459 - [devtools] Remove addRequestHeaders and addRequestCookies r=webdriver-reviewers,ochameau,bomsy,whimboo,devtools-reviewers
Depends on D168536

Differential Revision: https://phabricator.services.mozilla.com/D168537
2023-03-07 21:36:06 +00:00
Henrik Skupin
6c0d552a19 Bug 1818159 - [webdriver-bidi] When serializing platform objects of type Node only include "children" field if those were collected. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D171865
2023-03-07 21:06:29 +00:00
Julian Descottes
ee0ed5a948 Bug 1819875 - [bidi] Remove isRedirect from the network events base parameters r=webdriver-reviewers,Sasha
Differential Revision: https://phabricator.services.mozilla.com/D171840
2023-03-07 13:59:15 +00:00
Henrik Skupin
41ba80361e Bug 1819965 - [cdp] Re-load framescript when browsing context gets replaced due to a navigation. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D171498
2023-03-06 22:09:16 +00:00
Henrik Skupin
be600672dc Bug 1820487 - [remote] RemoteAgent fails to stop the httpd.js listener if CDP and/or BiDi fail to stop. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D171727
2023-03-06 22:09:16 +00:00
Mark Banner
80cc721b82 Bug 1820498 - Convert PerTestCoverageUtils to an ES module. r=marco,webdriver-reviewers,perftest-reviewers,sparky,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D171689
2023-03-06 19:13:58 +00:00
CanadaHonk
6805974fcc Bug 1702860 - [cdp] Fix ProtocolError on returning a rejected Error with awaitPromise r=webdriver-reviewers,whimboo
Fixed an internal error causing a ProtocolError when a Promise ran using
Runtime.evaluate/Runtime.callFunctionOn and rejects with an Error(),
while using the awaitPromise option. Also added tests for such cases.

With Promises, rejections should be also made into debuggee values, not
just successful resolutions.

Differential Revision: https://phabricator.services.mozilla.com/D167496
2023-03-03 08:46:23 +00:00
Julian Descottes
f57b9920af Bug 1819320 - [cdp] Use waitForNewTab to monitor the load of invalid URLs in browser_createTarget.js r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D171316
2023-03-01 11:05:57 +00:00
Alexandra Borovova
8d4f57a4d7 Bug 1806810 - [bidi] Implement "browsingContext.print" as PDF command. r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D170353
2023-03-01 08:18:54 +00:00
Henrik Skupin
db752eaf4c Bug 1819029 - [marionette] Fix returning response wrapped in "value" field. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D171084
2023-02-28 20:55:55 +00:00
Julian Descottes
621bd2b0a3 Bug 1819120 - [bidi] Migrate test_RemoteValue.js to a browser mochitest r=webdriver-reviewers,whimboo
Depends on D170809
Migrate the test to a browser mochitest and start testing deserialization in WindowRealm

Differential Revision: https://phabricator.services.mozilla.com/D171107
2023-02-28 13:24:18 +00:00
CanadaHonk
3236c91a7b Bug 1817258 - [cdp] Support url option for Target.createTarget r=webdriver-reviewers,whimboo
Added support for url option for Target.createTarget (required).
Also added new tests for Target.createTarget as full dedicated tests
did not exist beforehand, and tweaked some internal usage without url.

Differential Revision: https://phabricator.services.mozilla.com/D171079
2023-02-28 10:47:32 +00:00
Mark Banner
55bba8e918 Bug 1819019 - Update consumers of services/common to import ES modules directly. r=markh,webdriver-reviewers,extension-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D171055
2023-02-28 10:11:55 +00:00
Frazier Odhiambo
cad57921d1 Bug 1810101 - [remote] Use add_task() instead of add_test() for xpcshell tests. r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D170809
2023-02-28 07:32:29 +00:00
CanadaHonk
22ee5824f9 Bug 1625417 - [cdp] Use number as nodeId for DOM methods r=webdriver-reviewers,jdescottes
Use a number as nodeId instead of a UUID string as per CDP spec.
Also fixed tests expecting number to be an invalid type and string to be
valid instead.

Differential Revision: https://phabricator.services.mozilla.com/D167316
2023-02-28 06:37:24 +00:00
CanadaHonk
62060b7fed Bug 1744925 - [marionette] Fix extra change event with WebDriver:ElementClear for content editables r=webdriver-reviewers,whimboo
Fixed extra change event being emitted when WebDriver:ElementClear is
called for content editable elements.

Differential Revision: https://phabricator.services.mozilla.com/D170282
2023-02-27 08:30:52 +00:00
Henrik Skupin
7eddaf2fd1 Bug 1817934 - [puppeteer] Update test expection data. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D170800
2023-02-25 10:14:26 +00:00
Henrik Skupin
33c84b1801 Bug 1817934 - [puppeteer] Vendor Puppeteer v19.7.2. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D170799
2023-02-25 10:14:26 +00:00
Henrik Skupin
13840898bb Bug 1817934 - [puppeteer] Update Puppeteer vendoring documentation. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D170798
2023-02-25 10:14:25 +00:00
CanadaHonk
ff90131cd0 Bug 1808688 - [bidi] Remove before request sent map spec assert r=jdescottes,webdriver-reviewers
Removed the "before request sent map" spec assert which is now unneeded
as to document invariants in the implementation.

Also updated WPT test expectations.

Differential Revision: https://phabricator.services.mozilla.com/D170335
2023-02-21 21:25:35 +00:00
Alexandra Borovova
a93f88bfa8 Bug 1803392 - Remove usage of temporary file when printing to PDF. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D169795
2023-02-17 13:54:07 +00:00
Marian-Vasile Laza
8c0dd89bbe Backed out changeset b92093717dcd (bug 1803392) for wp failures on block-page-break-inside-avoid-1-print.html. 2023-02-16 18:20:19 +02:00
Alexandra Borovova
689922e0fa Bug 1803392 - Remove usage of temporary file when printing to PDF. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D169795
2023-02-16 14:04:23 +00:00
Alexandra Borovova
c98bd43a44 Bug 1806465 - [bidi] Implement "script.removePreloadScript" command. r=webdriver-reviewers,jdescottes
Depends on D169420

Differential Revision: https://phabricator.services.mozilla.com/D169421
2023-02-16 12:45:33 +00:00
Alexandra Borovova
9c89992359 Bug 1806420 - [bidi] Implement "script.addPreloadScript" command. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D169420
2023-02-16 12:45:32 +00:00
Gijs Kruitbosch
9d7452a247 Bug 1810141 - update consumers of CanonicalBrowsingContext.loadURI to use fixup or pass a URI object if they have it, r=mak,webdriver-reviewers,whimboo
Depends on D168389

Differential Revision: https://phabricator.services.mozilla.com/D168390
2023-02-13 23:50:38 +00:00
Cristina Horotan
5f4356e527 Backed out 9 changesets (bug 1810141) for several test failures on a CLOSED TREE
Backed out changeset 8781a0d1254d (bug 1810141)
Backed out changeset 131037295784 (bug 1810141)
Backed out changeset 3852fbe290f4 (bug 1810141)
Backed out changeset 118f131a524a (bug 1810141)
Backed out changeset ab5d76846e10 (bug 1810141)
Backed out changeset dce3aa683445 (bug 1810141)
Backed out changeset 4dc41d90dbb3 (bug 1810141)
Backed out changeset 50b57ba1a061 (bug 1810141)
Backed out changeset 569de94781e4 (bug 1810141)
2023-02-13 16:05:30 +02:00
Gijs Kruitbosch
e460aa10f3 Bug 1810141 - update consumers of CanonicalBrowsingContext.loadURI to use fixup or pass a URI object if they have it, r=mak,webdriver-reviewers,whimboo
Depends on D168389

Differential Revision: https://phabricator.services.mozilla.com/D168390
2023-02-13 12:55:22 +00:00
CanadaHonk
e8cfba51b6 Bug 1680780 - [cdp] Set correct attached status in TargetInfo r=webdriver-reviewers,whimboo
Now checks if the target is attached by going through all sessions in
the CDP connection. Also updated and added tests.

Differential Revision: https://phabricator.services.mozilla.com/D167322
2023-02-10 19:25:00 +00:00
Alexandra Borovova
231b3e98e0 Bug 1810687 - [messagehandler] Group SessionData initial updates by moduleName and category. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D169312
2023-02-10 08:12:07 +00:00
Henrik Skupin
e503a97720 Bug 1815838 - [cdp] Split-off return by value tests from browser_evaluate.js into a new file. r=webdriver-reviewers,Sasha,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D169291
2023-02-10 08:03:24 +00:00
CanadaHonk
2899a87902 Bug 1815221 - [cdp] Implement SystemInfo.getProcessInfo r=webdriver-reviewers,whimboo
Implement SystemInfo.getProcessInfo and start SystemInfo domain.
Also added new tests.

Differential Revision: https://phabricator.services.mozilla.com/D168950
2023-02-09 20:22:47 +00:00
Henrik Skupin
eac20afa3f Bug 1794552 - [marionette] Fix Bugzilla components for Marionette related files. r=webdriver-reviewers,Sasha,jgraham DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D169201
2023-02-09 19:38:39 +00:00
CanadaHonk
f82840d705 Bug 1810812 - [cdp] Implement filter option for Target.getTargets r=webdriver-reviewers,whimboo
Implement the filter option for Target.getTargets, by creating an
internal function for handling TargetFilters generally so support can be
added for other methods easier later. Also added relevant tests.

Differential Revision: https://phabricator.services.mozilla.com/D167172
2023-02-09 12:11:06 +00:00
Henrik Skupin
eaf8dde117 Bug 1786299 - [cdp] Values including a Symbol should not be serialized. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D169056
2023-02-08 13:39:52 +00:00
Henrik Skupin
e91a39e2be Bug 1786299 - [cdp] Use custom error message unknown contexts and cyclic objects for serialization by value. r=webdriver-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D169055
2023-02-08 13:39:52 +00:00
Alexandra Borovova
96f643b327 Bug 1806413 - [bidi] Add scheduling of preloaded scripts for execution. r=webdriver-reviewers,whimboo,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D168543
2023-02-03 18:43:26 +00:00