Commit Graph

89 Commits

Author SHA1 Message Date
Nicholas Nethercote
6e6ae2ea9b Bug 1382099 - Remove MOZ_WIDGET_GONK from several dom/ subdirectories. r=mccr8,jdm.
As well as the obvious #ifdef stuff, the patch removes
TCPSocket::SetAppIdAndBrowser(), which means
{TCPSocketParent,TCPServerSocketParent}::{GetAppId,GetInIsolatedMozBrowser}()
can also be removed.
2017-07-21 10:52:44 +10:00
Tim Huang
1ec953e612 Bug 1372069 - Part 1: Disable Geolocation when 'privacy.resistFingerprinting' is true. r=arthuredelstein,smaug
This patch disables Geolocation API when fingerprinting resistance is enabled.
The way we disable it is the same as how we disable this API for non-secure
origins that we will reject the request from this API and still keep this API
around.

MozReview-Commit-ID: 5D7Bf6Rplm8

--HG--
extra : rebase_source : b28f33f70a59dc670089dcbbb82f2720a059c341
2017-07-13 14:11:08 +08:00
Bill McCloskey
f115503a0b Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Carsten "Tomcat" Book
8a1350b5a6 Backed out changeset 4f6302a98ae4 (bug 1372405)
--HG--
extra : rebase_source : 41632f3158e88e692809731394a683d065a73dfb
2017-06-21 13:59:26 +02:00
Bill McCloskey
6b3e84ed5f Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book
ea1b86680c Backed out changeset 9846de3bd954 (bug 1372405)
--HG--
extra : rebase_source : 5d4a48e8ec394c329994689d938d2a6e9b2752b0
2017-06-20 08:27:02 +02:00
Bill McCloskey
4592152411 Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
Michelangelo De Simone
22a7c10b2c Bug 1072859 - Disable Geolocation on non-secure origins. r=jdm
MozReview-Commit-ID: KnHOb0aN4nE

--HG--
extra : source : 07ead25d0bdae2e62c116da16f70f5599513d00f
extra : histedit_source : 19e33405ac6e7b228179e397a80bd39a44651f4a%2C04a0bb8d5aaa06b8780f1937cc836b404bd8d1f7
2017-03-08 16:45:44 -08:00
Sebastian Hengst
dd5376d924 Backed out changeset 8b1c50cdb50c (bug 1072859) for failing devtools/client/responsive.html/test/browser/browser_permission_doorhanger.js. r=backout a=merge
MozReview-Commit-ID: LaknhYl9fEw

--HG--
extra : source : 6263649f857f55b11a6060d4a8735bdc8dbb0971
2017-03-09 00:46:17 +01:00
Michelangelo De Simone
1cd6de26c9 Bug 1072859 - Disable Geolocation on non-secure origins. r=jdm
MozReview-Commit-ID: KnHOb0aN4nE

--HG--
extra : rebase_source : a04cb5f52614889e83d8bcf5d8345f2559878b94
2017-03-06 14:10:13 -08:00
Michelangelo De Simone
bdc7703a03 Bug 1341897 - Harmonize Geolocation providers. r=jdm
MozReview-Commit-ID: DZbFDsklbq0

--HG--
extra : rebase_source : 94dbf472c9201baba9c78f01c9fbe0443a24992b
2017-02-22 15:09:02 -08:00
deepsrijit1105
c71314494e Bug 1334794 - nsGeolocation.cpp: redundant return statement at the end of a function with a void return type. r=jdm
--HG--
extra : rebase_source : 5c971470c7c9d74d67f64f7606057867a1e000bc
2017-02-01 22:22:51 +05:30
Michelangelo De Simone
702751e556 Bug 1335291 - Change the console flag for insecure geo requests from warning to error. r=jdm
MozReview-Commit-ID: 4gLN8jVDyPm

--HG--
extra : rebase_source : 28220ae0e204cef9f2ba2c17a5d1acbbc36571b9
2017-01-30 18:23:14 -08:00
Michelangelo De Simone
a011917b2b Bug 1269531 - Make the Geolocation test suite secure-context aware. r=jdm
MozReview-Commit-ID: 4WPUsGAO7xF

--HG--
extra : rebase_source : a0616dff53d547ab6c5b5d9f9b4e965e60b862b5
2017-01-26 15:38:16 -07:00
Carsten "Tomcat" Book
e7ca75286b Merge mozilla-central to inbound 2016-11-16 14:53:15 +01:00
Andi-Bogdan Postelnicu
aaf2063029 Bug 1317241 - Replace default bodies of special member functions with = default in dom/. r=baku
MozReview-Commit-ID: 12AHOhrpaNO

--HG--
extra : rebase_source : 7881277a13fe7389b95635ee9b94f1686f56d142
2016-11-14 11:40:37 +02:00
Boris Zbarsky
f4760a6a1b Bug 1317596. Stop using LegacyIsCallerChromeOrNativeCode in geolocation code. r=jdm 2016-11-15 12:46:32 -05:00
Kan-Ru Chen
1f00a5d169 Bug 1300474 - Replace nsAutoPtr usages in geolocation with UniquePtr. r=jdm
MozReview-Commit-ID: KcJj8VKjLpj

--HG--
extra : rebase_source : 11205452dd23a99b7f555c5069e22997d750739d
2016-10-24 14:40:18 +08:00
Adam Velebil
13e0da5f08 Bug 1308600 - Remove unused ServiceReady method from Geolocation. r=jdm 2016-10-10 23:15:45 +02:00
Michelangelo De Simone
01caec7221 Bug 1278716 - Remove wakelocks from geo. r=jdm
MozReview-Commit-ID: 2Uu1W34r3g8

--HG--
extra : rebase_source : 3fe68bb861ce60da3b6b42819c90df02c58a8e70
2016-10-04 15:12:16 -07:00
Kan-Ru Chen
6ca2f575d0 Bug 1283563 - Don't reset timeout for oneshot geolocation request. r=jdm
MozReview-Commit-ID: 4EkPD54Xu7f
2016-09-29 17:13:59 +08:00
Michelangelo De Simone
51d093d40f Bug 1218627 - Remove MozSettings API from Geo (and fix randomly failing tests). r=dougt
MozReview-Commit-ID: J74XihIkeHH

--HG--
extra : rebase_source : b88d74cb37f4cce2c892ea4790ee3de10d2747e5
2016-09-27 13:54:15 -07:00
Ninad Bhat[:ninad101]
15dca34ea9 Bug 1301628 - Corrects misc-argument-comment. r=dzbarsky 2016-09-09 10:45:00 +02:00
Boris Zbarsky
058c0dac3f Bug 1300005. Make sure that our PositionOptions structs are always owned by someone in geolocation code. r=kanru 2016-09-02 17:55:37 -04:00
Kan-Ru Chen
b6d880aca1 Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj
The patch is generated from following command:

  rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,

MozReview-Commit-ID: AtLcWApZfES


--HG--
rename : mfbt/unused.h => mfbt/Unused.h
2016-08-24 14:47:04 +08:00
Jan de Mooij
c33bac8363 Bug 1292892 part 5 - Replace most nsContentUtils::RootingCx calls with dom::RootingCx. r=bz,terrence 2016-08-11 14:39:23 +02:00
Nicholas Nethercote
e7f10a07fd Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm.
This patch makes most Run() declarations in subclasses of nsIRunnable have the
same form: |NS_IMETHOD Run() override|.

As a result of these changes, I had to add |override| to a couple of other
functions to satisfy clang's -Winconsistent-missing-override warning.

--HG--
extra : rebase_source : 815d0018b0b13329bb5698c410f500dddcc3ee12
2016-08-08 12:18:10 +10:00
Xidorn Quan
31f5ebf083 Bug 1287706 part 1 - Make CallbackObjectHolder movable (and actually move-only). r=smaug
So that we can avoid unnecessary refcount changes.

MozReview-Commit-ID: 4Mk9SJTj6AS

--HG--
extra : source : c35643f76ef33b6cdce115c8de0dfae8abccd644
2016-07-28 12:00:06 +10:00
Thomas Zimmermann
6c1b3c2bc2 Bug 1250922: Use gpsd for Geolocation, r=jdm,glandium
This patch adds the gpsd location provider to |nsGeolocationService|.

On release builds, the new provider is *not* used by default, as GPS
is slow to start and unreliable indoors. To enable gpsd, users with a
supported GPS receiver must set the preference 'geo.location.use_gpsd'
to 'true'.

On non-release builds, the gpsd location provider is enabled by default
to give it some testing.

MozReview-Commit-ID: I0tj1GmmFNP
2016-07-22 11:52:09 +02:00
Chris Peterson
b175c9fdd5 Bug 1277106 - Part 2: Expand MOZ_UTF16() strings to u"" string literals. r=Waldo 2016-07-20 22:03:25 -07:00
Jinank Jain
d244954843 Bug 1238801 - Don't set a timer for the default geolocation timeout. r=jdm, r=smaug 2016-06-26 10:24:54 -04:00
Fabrice Desré
d9ec9e3a4a Bug 1218627 - backout ef8fcd144a50 2016-07-12 14:00:34 -07:00
Benjamin Smedberg
bf05496a83 Bug 1282866 - remove widget/qt and other supporting QT code, r=dougt. This patch does not remove all of the checks for MOZ_WIDGET_QT (which are dead code), but that will be a followup mentored bug.
MozReview-Commit-ID: EGqHHhCD7vD

--HG--
extra : rebase_source : a4b9593959dd3ba80189db47eabb056ea207490f
extra : amend_source : a744d833693f0fe7adbea961c00bb5fb55a91580
2016-07-07 12:14:25 -04:00
Michelangelo De Simone
9508c6dd0b Bug 1218627 - Fixing randomly failing test(s) in Geo. r=dougt
MozReview-Commit-ID: LyZVmPBQT84

--HG--
extra : transplant_source : L%0D%F2%BA_%84%8E%B9%B9%7F%E7J%DB%86%8E%B6%83%9B%05%87
2016-07-05 14:46:58 -07:00
Jonathan Watt
b15368cfcb Bug 1279451 - Remove a lot of unnecessary includes of nsAutoPtr.h. rs=sparky 2016-06-07 21:10:18 +01:00
Michelangelo De Simone
b094f2be2a Bug 1278410 - The Geolocation fuzzing implementation has been removed. r=dougt
MozReview-Commit-ID: 6x4Z4IayvCt

--HG--
extra : transplant_source : M%E0%3E%12%84%D7%0DQBT%91%08%7B%D7%8D%7Cyfc%9B
2016-06-06 15:50:12 -07:00
Kyle Huey
c73656947b Bug 1265927: Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::CancelableRunnable. r=froydnj 2016-04-25 17:23:21 -07:00
Andrew McCreight
f417b18c2b Bug 1263001 - Don't Notify() an unlinked nsGeolocationRequest. r=jdm
If an unlinked nsGeolocationRequest somehow stays alive, then calling
Notify() on it will likely cause a null-deref crash.
2016-04-22 14:15:36 -07:00
Michelangelo De Simone
a3019e2338 Bug 1255198 - [Telemetry] Add geolocation Telemetry probes to record fulfilled requests according to document.isVisible. r=jdm, data-review=bsmedberg
MozReview-Commit-ID: 85bsEWEWa3w
2016-03-21 15:42:18 -07:00
Andrew McCreight
1bf6681a43 Bug 1256061 - Hold a strong reference to a request when we call a method on it. r=jdm
I think it is possible for the TimerCallbackHolder to fire off a
Notify() while the geolocation object and the nsGeolocationRequest are
only holding each other alive, so they would be freed by the cycle
collector the next time it runs, but we haven't run the cycle
collector yet. If that happens, then Geolocation::RemoveRequest()
would break the cycle, causing stuff to unravel and bad things to
happen. To fix this, we just hold the request alive in
TimerCallbackHolder::Notify(), which will also ensure that the
geolocation object is alive, hopefully preventing crashes.

This will make the Notify() behavior similar to what it was before bug
1238427, when the nsITimer object would hold a strong reference to the
request when the Notify() was being run.
2016-03-23 12:59:14 -07:00
Andrew McCreight
4e6a34a3d5 Bug 1256061 - Revert patch that didn't do anything. 2016-03-23 12:59:14 -07:00
Andrew McCreight
836b0f5ba3 Bug 1256061 - Actually check if the underlying referent still exists in nsGeolocationRequest::TimerCallbackHolder::Notify(). r=jdm
--HG--
extra : rebase_source : 52973fb4b629156a53b8f071dfbfbbd4b7e163d9
2016-03-16 11:48:00 +01:00
Doug Turner
1a1dd4f3c7 Bug 1253159 - Remove locationUpdatePending and restore request timeout. r=jdm 2016-03-02 21:48:00 -05:00
ywu
5413221998 Bug 1238873 - Handle the bug that if we take cached data, we might not get any update later. r=kchen. r=jdm. 2016-02-15 17:56:00 +01:00
Andrew McCreight
6256f3a859 Bug 1240906 - Shut down geolocation service at xpcom-shutdown instead of quit-application. r=dougt
Also, remove trailing spaces from network_geolocation.sjs.
2016-01-19 14:07:00 +01:00
ywu
c155d8d975 Bug 1240664 - Only enable bug 1216148's behavior when there is a wakelock support. r=kanru 2016-02-01 16:40:21 +08:00
Kyle Huey
91efc5a86c Bug 1241764: Replace nsPIDOMWindow with nsPIDOMWindowInner/Outer. r=mrbkap,smaug 2016-01-30 09:05:36 -08:00
ywu
1859d04f33 Bug 1240666 - Follow-up to bug 1216148. r=kchen.
Add a comment to where we resume gps requests from invisible state.
2016-01-26 18:10:00 +01:00
Alphan Chen
c5396e386f Bug 858827 - [Geolocation] Add a handling for getCurrentLocation when timeout is zero. r=jdm
Follow W3C spec, Error callback should be called when timeout is zero and
  there's no cached position for getCurrentLocation.
2016-01-26 17:11:54 +08:00
Andrew McCreight
9f632b6e53 Bug 1238427 - Avoid a strong reference from the timeout timer to nsGeolocationRequest. r=jdm
The timeout timer of a geolocation request holds a strong reference to
the request. This can cause the window to leak if the request is not
completed before the tab containing the window is closed.

To fix this, I made the timer instead hold a strong reference to a
wrapper class that has only a weak reference to the request. The
request destructor must now cancel the timeout timer.

I also outlined a call to StopTimeoutTimer() in
nsGeolocationRequest::Shutdown().
2016-01-21 09:57:30 -08:00