Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-13 21:35:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
228,080 Commits 615 Branches 98 Tags 5.8 GiB
8b767d3905
Commit Graph

362 Commits

Author SHA1 Message Date
Shawn Wilsher
74f617d3a6 Bug 483152 - Stop giving the ability to get the native sqlite3_stmt pointer 
We don't really want to give this pointer out to consumers since we track some
state, and if they call SQLite functions on it, can cause our internal state to
be inaccurate.
r=asuth
 2009-03-20 18:41:01 -04:00
Shawn Wilsher
78f0a0ec2e Bug 483154 - mozStorageStatementParams should use mozIStorageStatement API 
This makes us use the public API on mozIStorageStatement, which centralizes some
of our logic.
r=asuth
r=bent
 2009-03-20 18:41:01 -04:00
Shawn Wilsher
3e20da65a1 Bug 483157 - mozStorageStatementRow needs to use mozIStorageStatement API 
This makes our language helper use public API instead of calling SQLite
directly, which centralizes some of our logic.
r=asuth
r=bent
 2009-03-20 18:41:01 -04:00
Shawn Wilsher
311505dbc1 Bug 483880 - Pull out implementation of mozStorageVariant_base so we can include it in more than one file 
The current implementation means it can only be #included once, which makes it
not terribly useful for other consumers.
r=asuth
 2009-03-20 16:28:16 -04:00
Shawn Wilsher
c1f550d335 Bug 482159 - Add support for nsCString in mozStorageVariant 
r=asuth
r=bent
 2009-03-20 16:28:16 -04:00
Shawn Wilsher
cb4b068b6d Bug 481261 - Expose when queries are being inefficient in debug builds 
Follow-up change to support suppressing the warning for a certain query, and
reducing the verbosity of the message.
r=asuth
 2009-03-20 16:28:16 -04:00
Shawn Wilsher
d56775d13f Bug 483739 - Establish style guidelines for storage 
This adds style.txt to storage/ that indicates how new code should be styled.
Reviewers are expected to enforce this!
r=asuth
 2009-03-20 16:28:16 -04:00
Shawn Wilsher
ad80aba6ea Bug 479728 - Rename AsyncExecute. 
This renames the class to AsyncExecuteStatement to be a bit more clear as to
what it does.
r=asuth
 2009-03-13 16:32:19 -07:00
Shawn Wilsher
fda0936e59 Bug 481261 - Expose when queries are being inefficient in debug builds. 
This adds a warning in debug builds about queries that do not use an index to
sort, which tend to be much much slower.
r=asuth
 2009-03-12 14:30:15 -04:00
Ben Turner
2b3e5b31d7 Bug 482614 - mozStorageVariant leaks its internal data due to non-virtual destructor 
Most commonly seen when using executeAsync and having the results return a
string or blob.
r=sdwilsh
 2009-03-10 18:54:24 -04:00
Ryan VanderMeulen
2d37f4bff0 Bug 479543 - mozStorageConnection::Close should use NS_ERROR instead of NS_WARNING to complain about unfinalized statements; r=sdwilsh 2009-03-01 18:23:26 +01:00
Shawn Wilsher
924eedb602 Bug 479729 - Unable to shutdown using async statements. 
This changeset finalizes statements before we try to rollback a transaction with
the async storage API.  This problem only came up when you canceled a statement.
r=asuth
 2009-02-26 12:55:47 -05:00
Shawn Wilsher
f09ed272e1 merge for backout 2009-02-23 17:35:19 -05:00
Shawn Wilsher
84f5752621 Backed out changeset f8926cd4a7b2 (bug 479543) since it breaks unit tests in 
debug builds.
 2009-02-23 17:34:46 -05:00
Alex Gartrell
bb0410d426 Bug 453781 - Merge TableExists and IndexExists, and replace nsCString with nsCAutoString 
r=sdwilsh
 2009-02-23 13:05:24 -05:00
Ryan VanderMeulen
c17c781352 Bug 479543 - mozStorageConnection::Close should use NS_ERROR instead of NS_WARNING to complain about unfinalized statements 
r=sdwilsh
 2009-02-22 00:11:57 -05:00
Nilay Vaish
0103bf3664 Bug 473268 - We should use forget instead of swap in mozStorageService.cpp; r=sdwilsh 2009-02-03 15:42:28 +01:00
Andrew Sutherland
35d80445c3 Bug 463907 - mozStorageConnection::ExecuteAsync does not check that provided statements have not been finalized; r=sdwilsh 2009-02-03 15:42:22 +01:00
Fred Jendrzejewski
424883d380 Bug 466622. Replace nsCStringArray with nsTArray<nsCString> for more consistent code and fewer heap allocations. r+sr=roc,r=bsmedberg 
--HG--
extra : rebase_source : b963bf5de9d9c445b14620479691482512e0faf2
 2009-01-22 17:15:34 +13:00
Blake Kaplan
d2ad3e3850 Add missing return (from bug 473845). 2009-01-21 17:12:41 -08:00
Shawn Wilsher
e68b436153 Bug 473845 - Break a potential cycle with XPConnect and mozStroageService 
This changeset removes a cycle that gets created between XPConnect and the
storage service.  This accomplishes this by releasing the cached reference to
XPConnect during xpcom-shutdown.

This was the last remaining leak of the browser-chrome test harness, so this
also sets the leak threshold to zero for that test.

r=bent
 2009-01-21 16:52:16 -05:00
Drew Willcoxon
b984a21254 Bug 384954 - Get xpcshell tests for wrapped statements 
r=sdwilsh
 2009-01-21 14:26:07 -05:00
Robert Sesek
ada018a429 Bug 431473. Kill unused mozIStorageDataSet. r=sdwilsh 2009-01-19 21:44:31 +13:00
Fred Jendrzejewski
d8f1bff747 Bug 461047 - Replace nsStringArray with nsTArray<nsString>. r+sr=roc 2009-01-18 21:14:14 +01:00
Robert O'Callahan
804cc7ee91 Backed out changeset 8019a959aade 2009-01-16 22:20:33 +13:00
Fred Jendrzejewski
065bde22f3 Bug 461047. Replace nsStringArray with nsTArray<nsString>. r+sr=roc 
--HG--
extra : rebase_source : 7a20af24c97867efbb28dafa6a70ea1b4cf00e58
 2009-01-16 20:51:04 +13:00
Andrew Sutherland
a3688651e0 Bug 445525 - set SQLITE_CONFIG_MEMSTATUS to 0. v1.1 turn off SQLITE_CONFIG_MEMSTATUS at init-time. r=sdwilsh 2008-12-13 22:38:18 -08:00
Andrew Sutherland
ede141e1ac Bug 463988 - Gloda: mozStorageConnection holds lock while calling outside its module leading to PR_ASSERT(lock->owner != me) on shutting down while indexing is active. v1 add flag that indicates async thread is shutting down, don't call nsIThread::Shutdown with a lock held. r=sdwilsh. 2008-12-13 18:59:17 -08:00
Marco Bonardo
07b93ae9d5 Bug 467856 - Expose SQLITE_IOERR, r=sdwilsh 2008-12-09 21:39:32 +01:00
Shawn Wilsher
187f70f12f fix for windows bustage 2008-12-08 17:36:20 -05:00
Shawn Wilsher
456c8b7594 Bug 462173 - We treat transaction errors as fatal when we should not 
r=asuth
 2008-12-08 17:14:14 -05:00
Shawn Wilsher
50794c8ae6 Bug 448114 - Notify about non-finalized statements in debug builds 
r=asuth
 2008-12-08 17:14:14 -05:00
Andrew Sutherland
adac41015b Bug 462432 - Leak mAsyncExecutionMutex 
r=sdwilsh
 2008-11-27 12:34:40 -08:00
Shawn Wilsher
287ddd5ebc Addressing review nit for bug 464202 that was improperly addressed in changeset 59d84ac24da2 
original patch r=mrbkap, a=beltzner
 2008-11-20 14:11:03 -05:00
Jeff Walden
26fa978b71 Address followup nit for bug 464202. 2008-11-19 11:54:29 -08:00
Shawn Wilsher
6017aa4aa8 Bug 457743 - Automatic wrapper creates cycles, and thus leaks. r=dcamp, r=asuth, a=beltzner for 1.9.1b2 2008-11-19 11:33:00 -08:00
Shawn Wilsher
14720845a3 Bug 464202 - nsGlobalWindow leak running browser-chrome Mochitests. r=mrbkap a=beltzner 2008-11-19 01:11:30 -05:00
Shawn Wilsher
deb7217ab3 Bug 461344 - abort if the version of sqlite we are using is not new enough 
This adds a runtime check to ensure that the version of SQLite that is running
is the same as the one that we were compiled with.  If the check fails, we will
display a prompt to the user, and abort.
r=bsmedberg
 2008-10-31 20:38:58 -04:00
Shawn Wilsher
f653780142 Bug 451815 - Need a more reliable way to indicate SQLITE_BUSY 
This changeset adds a new error result for storage (NS_ERROR_STORAGE_BUSY) that
maps directly to when SQLite would return SQLITE_BUSY.
r=asuth

--HG--
rename : storage/src/mozStorage.h => storage/src/mozStoragePrivateHelpers.h
 2008-10-30 18:50:00 -04:00
Shawn Wilsher
801290a84c Bug 462434 - Transaction semantics are bad 
This propagates errors in starting and ending transactions.
r=asuth
 2008-10-30 18:46:25 -04:00
Shawn Wilsher
da47747760 Bug 454740 - Asynchronous storage should batch/chunk results 
This changeset batches results obtained by the async storage API so we are not
flooding the calling thread with so many events.
r=asuth
 2008-10-29 13:13:32 -04:00
Serge Gautherie
0430a4d084 Bustage fix (= missed additional change) for 
Bug 460635 - There should be one async execution thread per mozStorageConnection connection; v1.2; r=(bugmail + sdwilsh)
 2008-10-29 05:09:23 +01:00
Andrew Sutherland
2bb839d2b7 Bug 460635 - There should be one async execution thread per mozStorageConnection connection; v1.2; r=(bugmail + sdwilsh) 2008-10-29 04:53:19 +01:00
Shawn Wilsher
dd6c7ee933 Bug 458998 - AsyncExecute helper classes can complete() before they are added to mPendingEvents 
This changeset also fixes a few issues where we were holding a lock while and
kills off a few other race conditions that were noticed in the course of fixing
this bug.
r=bent
 2008-10-24 18:30:07 -04:00
Shawn Wilsher
18700696dc Bug 461263 - Race condition exists with mozStorageTransaction 
While the race was technically "safe", we could have possibly wrongly tried to
commit or rollback.  This changeset makes us operate sanely in all conditions.
r=bent
 2008-10-24 16:50:01 -04:00
Shawn Wilsher
d28587dd1d Bug 458811 - Allow for multiple statements to be executed at in a transaction asynchronously 
This changeset allows consumers to execute a series of statements, in order,
asynchronously in a transaction.
r=dcamp
sr=sicking
 2008-10-13 18:45:40 -04:00
Shawn Wilsher
af33d57a63 Bug 458756 - Use raw sqlite3_stmt pointers instead of the mozStorageStatement object for async statements 
This ends up saving us a bunch of work when we execute a statement
asynchronously, and makes bug 458811 easier to do.
r=dcamp
 2008-10-10 17:41:31 -04:00
Shawn Wilsher
17a0817cd9 comment change to kick off new builds 
rs=me
 2008-10-09 20:29:14 -04:00
Shawn Wilsher
d29d8419b3 Bug 453722 - Do not need to safeguard more than one call to Init for storage service 
Bug 449822 made it so services can not be initialized more than once when being
called from multiple threads.  Storage used to protect against this, but no
longer needs to do this (which this changeset makes us do).
r=bent
 2008-09-25 14:28:29 -04:00
Doug Turner
1234432adf Bug 456489 - WinCE Compiler keyword interface used in mozStorageRow.cpp. patch by wolfe, r=sdwilsh 2008-09-23 11:03:48 -07:00
Doug Turner
7216b611ec Bug 456471 - mozIStorageError IDL file needs ERROR undefined for WinCE / WinMobile. patch by wolfe, r=sdwilsh 2008-09-23 11:02:55 -07:00
Andrew Sutherland
65b3bb8092 Bug 455202 - executeAsync without listener/callback results in segfault when error encountered; test part; r=sdwilsh 2008-09-15 18:50:21 +02:00
Andrew Sutherland
8d86adfc37 Bug 455202 - executeAsync without listener/callback results in segfault when error encountered; fix part; r=sdwilsh 2008-09-15 18:49:18 +02:00
Shawn Wilsher
3d079626e8 Bustage fix - double semi-colon. 2008-09-12 17:40:55 -04:00
Shawn Wilsher
78e4ede55b Bug 452897 - Automatically provide the wrapper for JavaScript 
This changeset adds a language helper to mozStorageStatement so it gets the
attributes and methods that mozIStorageStatementWrapper has.  We can now mark
the wrapper as depreciated.
r=vlad
r=mrbkap

--HG--
rename : storage/test/unit/test_storage_statement_wrapper.js => storage/test/unit/test_statement_wrapper_automatically.js
 2008-09-12 17:30:41 -04:00
Shawn Wilsher
3e49f59cca Bug 452897 - Automatically provide the wrapper for JS 
This changeset has no code changes - it just separates three classes that were
all contained in one file into three files (with appropriate headers).  This is
being done to make the actual code changes for the bug simpler.
rs=me
 2008-09-12 17:30:37 -04:00
Shawn Wilsher
4c52e158c3 Bug 452836 - Optimize calls to sqlite3_prepare_v2 
This changeset makes all calls pass -1 for length which indicates that the
string is null terminated.
r=Neil
 2008-09-03 12:20:10 -04:00
Jason Orendorff
6b5d53f655 Bug 407216 - DOM quick stubs - faster paths for top N DOM methods (r+sr=jst, security r=mrbkap, build r=bsmedberg) 
* * *
* * *
* * *
 2008-08-19 21:38:24 -05:00
Shawn Wilsher
6dea9a020c Bug 452836 - Optimize calls to sqlite3_prepare_v2 
This makes sqlite not copy the sql string when preparing it, saving us a string
copy every time.
r=bholley
 2008-08-29 17:19:23 -04:00
Shawn Wilsher
cfba414480 Bug 452833 - Do not loop if we get SQLITE_SCHEMA 
We used to have to try again if we got SQLITE_SCHEMA back from sqlite when we
prepare a statement.  However, this isn't needed with the new v2 interface,
which we now use.
r=bholley
 2008-08-29 17:17:01 -04:00
Shawn Wilsher
7132ee9652 Bug 451058 - Address post-review comments. 
This addresses some comments that were brought up after the code had already
landed.
r=Neil
 2008-08-29 16:46:14 -04:00
Shawn Wilsher
9b3a321600 Bug 452841 - Remove hack in mozStorageStatement::Initialize 
This removes some code that was at one time needed to work around a sqlite but
that no longer exists.
r=vlad
 2008-08-29 16:42:12 -04:00
Shawn Wilsher
97a796274f Bug 451463 - mozStorageStatement needs threadsafe refcounting 
This changeset makes mozStoageStatement use threadsafe refcounting.  The class
is still not threadsafe, but JS consumers cannot create a statement off of the
main thread since it would be garbage collected on the main thread.
r=bent
 2008-08-27 13:11:02 -04:00
Shawn Wilsher
d0e6e8b795 Bug 448607 - Includes and comments are not accurate in mozStorageBackground.* 
This fixes some comments that are wrong and removes unneeded includes.
rs=me; there's really no change here.
 2008-08-27 13:05:03 -04:00
Jason Orendorff
abf12d8076 Backing out changeset cf6c811e1272 (bug 407216) due to debug assertions. 2008-08-19 22:28:26 -05:00
Jason Orendorff
09f9ac1d0a Bug 407216 - DOM quick stubs - faster paths for top N DOM methods (r+sr=jst, security r=mrbkap, build r=bsmedberg) 
* * *
* * *
 2008-08-19 21:38:24 -05:00
Lukas Blakk
b4c01f2f50 Bug 450665: test_bug-365166.js creates file in /tmp instead of in build directory. r=sdwilsh 2008-08-16 16:17:47 +01:00
Shawn Wilsher
78b08dae0c Make mozIStorageConnection threadsafe - bug 448476 r=robarnold 2008-08-12 17:50:25 -07:00
Blake Kaplan
9a06360391 Avoid returning false without setting an exception. bug 429521, r=sdwilsh 2008-08-04 10:04:27 -07:00
Blake Kaplan
31a2fea1d6 Test that the object has the right class, even when called from native code. bug 444233, r=shaver 2008-07-16 19:29:06 +02:00
Shawn Wilsher
9b3bae8da4 Bug 444821 - Re-enable test_storage_statement_executeAsync.js 
This fixes the test to run properly on slower running systems (like the
tinderbox machines).
r=vlad
 2008-07-15 11:04:52 -04:00
Shawn Wilsher
56be74f21c Disable stupid test (stupidity is my own fault). Bug 444821 to fix it properly 
and re-enable it.
 2008-07-11 17:29:45 -04:00
Shawn Wilsher
a583d673c5 Bug 429986 - Provide an option for database to be asynchronous 
This adds unit tests for the async storage work.
r=vlad
 2008-07-11 15:47:38 -04:00
Shawn Wilsher
35ba2ed351 Bug 429986 - Provide an option for database access to be asynchronous. 
This adds a method to mozIStorageStatement to allow for a statement to execute
asynchronously and report to a callback.  For writes, this can move fsyncs,
which can be painful, off of the main thread.
r=vlad
sr=shaver
 2008-07-11 15:47:33 -04:00
Shawn Wilsher
3da654e7c2 Bug 435994 - Implement ResultSet and Row for mozIStorageStatement::executeAsync 
These creates the result set and row objects to be used with the async storage
API added in bug 429986.
r=vlad
sr=shaver
 2008-07-11 15:47:28 -04:00
Shawn Wilsher
fb401724a9 Bug 435995 - Implement an nsIVariant object storage can use. 
This creates a templated C++ class for storage to map SQLite data types to the
correct nsIVariant.
r=robarnold
r=vlad
 2008-07-11 15:47:21 -04:00
Shawn Wilsher
3436da9283 Bug 444347 - Make NSPR logging a bit more useful 
This adds additional NSPR logging to storage.  Logging is now done when a sql
statement is prepared, a connection is opened, and a connection is closed.
Additionally, when sqlite3_trace is called, we also log the address of the
connection so you know what queries are running on which database.  The address
is also logged at connection open so you can perform the mapping.
r=vlad
 2008-07-11 15:00:58 -04:00
Arpad Borsos
140f31f75e Bug 434838 - mozStorageConnection uses nsDataHashtable when it should use nsInterfaceHashtable 
This makes mozStorageConnection no longer manually AddRef and Release user
defined functions.
r=sdwilsh
r=bent
 2008-07-08 18:38:25 -04:00
Benjamin Smedberg
bad1189195 Bug 442762 - Annotate mozStorageStatementScoper with NS_STACK_CLASS, r=sdwilsh 2008-06-30 21:03:29 -04:00
Shawn Wilsher
faddef0df3 Bug 434796 
Remove mozIStorageStatement::initialize
r=vlad
sr=shaver
 2008-06-11 11:00:09 -04:00
Shawn Wilsher
13420bfff8 Bug 434247 
Remove mozStorageStatement's mStatementString
r=vlad
 2008-06-11 10:25:20 -04:00
Shawn Wilsher
6691f61f94 Backed out changeset 5ccc3423220f 2008-06-04 12:55:44 -04:00
Shawn Wilsher
25797ff194 Bug 434247 
Remove mozStorageStatement's mStatementString
r=vlad
 2008-06-04 11:59:43 -04:00
Shawn Wilsher
194d5b36cf Bug 434244 
Remove mozStorageStatement::Recreate
r=shaver
 2008-06-04 11:42:15 -04:00
sdwilsh@shawnwilsher.com
b110525ed2 Bug 421482 - Firefox 3 uses fsync excessively. r=shaver, a=schrep 2008-05-23 07:56:10 -07:00
gavin@gavinsharp.com
01e42dc4e8 Bug 424402: Test a combination of shared and unshared database connections, patch by Ondrej Brablc <ondrej@allpeers.com>, r=shaver 2008-04-22 13:39:38 -07:00
sdwilsh@shawnwilsher.com
a950b3f8c1 Bug 423273 - Fix storage API to not break old behavior. r=shaver, sr=shaver, a=shaver 2008-03-24 15:14:38 -07:00
edward.lee@engineering.uiuc.edu
a17f899193 Bug 420505 - mozStorageService isn't as threadsafe as it claims to be. p=sdwilsh, r=brendan, r=bsmedberg, b1.9=sayrer 2008-03-19 18:37:04 -07:00
dveditz@cruzio.com
58158c049e bug 423964 uninitialized variable, r=sdwilsh, a=beltzner 2008-03-19 15:55:34 -07:00
timeless@mozdev.org
c33bc2d732 Bug 422687 encfs makes Firefox crash at start [@ libsqlite3.so@0x30fad][@ sqlite3_exec] changing test to accept ERROR_FAILURE 2008-03-17 14:41:13 -07:00
timeless@mozdev.org
0d7a5053f8 Bug 422687 encfs makes Firefox crash at start [@ libsqlite3.so@0x30fad][@ sqlite3_exec] r=sdwilsh a=beltzner 2008-03-17 14:01:16 -07:00
reed@reedloden.com
6a0a2e5e89 Bug 395974 - "our storage unit tests cause "WARNING: Unsafe use of LIKE detected!" warnings" (Bind the value to avoid WARNING) [p=ondrej@allpeers.com (Ondrej Brablc) r=sdwilsh] 2008-03-08 03:25:41 -08:00
sayrer@gmail.com
205fa1087a Bug 419905. turn off pgo in places, mozstorage, sqlite. r=ted.mielczarek, a=beltzner 2008-02-27 12:25:45 -08:00
reed@reedloden.com
36fb40a626 Bug 263381 - "support --with-system-sqlite3 in storage builds" [p=mh+mozilla@glandium.org (Mike Hommey) r=bsmedberg a1.9=beltzner] 2008-02-22 03:25:59 -08:00
jag@tty.nl
05cdb6aefe Bug 73353: Clean up our MODULE/REQUIRES story. rs=dbaron, a=brendan 2008-02-18 00:50:04 -08:00
sdwilsh@shawnwilsher.com
e6bd117ec3 Bug 416173 - BackupDB is completely useless. r=vlad, a=damons 2008-02-09 11:05:49 -08:00
myk@mozilla.org
1f26f9ec43 bug 413589: enable fts3 (full text index) sqlite module; r=sdwilsh, a=damons 2008-01-29 15:34:19 -08:00
sdwilsh@shawnwilsher.com
1777cc37e8 Bug 411976 - Update the comment in mozIStorageService.idl to reflect recent SQLite changes. This is a comment change only - NPOTDB. 2008-01-25 10:18:15 -08:00
sdwilsh@shawnwilsher.com
c741cddc02 Bug 408914 - Disable sqlite async IO. r=vlad 2008-01-09 19:21:56 -08:00
reed@reedloden.com
21018b4c31 Bug 408914 - "Disable sqlite async IO" [p=vladimir@pobox.com (Vladimir Vukicevic [vlad]) r=sdwilsh a1.9=beltzner] 2008-01-07 00:27:25 -08:00
reed@reedloden.com
9a18e05925 Bug 409386 - "mozStorageArgvValueArray::GetString returns wrong length" [p=ondrej@allpeers.com (Ondrej Brablc) r=sdwilsh a1.9=schrep] 2007-12-21 22:09:25 -08:00
reed@reedloden.com
d342defa35 Bug 385066 - "Remove preloading from mozStorage" [p=comrade693+bmo@gmail.com (Shawn Wilsher [sdwilsh]) r=gavin a=blocking1.9+] 2007-12-17 21:34:50 -08:00
reed@reedloden.com
9e2384777a Bug 403068 - "Need a wrapper function for SQLite function sqlite3_column_decltype" [p=jzhang@aptana.com (john Zhang) r=sdwilsh a1.9=damons] 2007-11-13 00:26:45 -08:00
sdwilsh@shawnwilsher.com
10c4211388 Bug 395526 - Change assertions to real errors in mozStorageStatement.cpp. r=sspitzer, a=bzbarsky 2007-09-21 11:13:47 -07:00
sdwilsh@shawnwilsher.com
ce9577407a Bug 394789 - Add a finalize() method to mozStorageStatement. r=neil, r=sspitzer, a=bzbarsky 2007-09-18 20:26:51 -07:00
dtownsend@oxymoronical.com
aa6f173086 Comment correction, no bug. 2007-09-03 07:30:45 -07:00
dtownsend@oxymoronical.com
fc448804e6 Clarification comments for parameters, no bug. r=sdwilsh 2007-08-30 16:46:56 -07:00
sdwilsh@shawnwilsher.com
e5e8ad570e Bug 394241 - Add a closeDatabase() method to mozStorage. r=sspitzer 2007-08-30 06:43:17 -07:00
sdwilsh@shawnwilsher.com
6644708484 Bug 393082 - Warn on unsafe usage of LIKE. r=sspitzer 2007-08-29 18:56:14 -07:00
sspitzer@mozilla.org
2f756de966 unit test for bug #393952: crash when I try to VACUUM (StorageUnicodeFunctions::likeFunction() should handle null aArgv[0] and aArgv[1]) r=sdwilsh 2007-08-28 09:39:07 -07:00
sdwilsh@shawnwilsher.com
6248136103 Bug 383673 - mozStorageValueArray only asserts on out of bounds (and other cleanup). r=sspitzer 2007-08-28 08:29:49 -07:00
sspitzer@mozilla.org
5b0f9d75c4 fix for bug #393952: crash when I try to VACUUM (StorageUnicodeFunctions::likeFunction() should handle null aArgv[0] and aArgv[1]) r=sdwilsh 2007-08-27 21:43:10 -07:00
sspitzer@mozilla.org
4d9cc10ceb fix for bug #391697: add escapeStringForLIKE to mozIStorageStatement r=sdwilsh 2007-08-10 15:57:02 -07:00
sdwilsh@shawnwilsher.com
e725c9f1a5 Bug 391156 - mozStorage doesn't handle unicode in LIKE, UPPER, or LOWER functions (string nit follow-up patch). r=sspitzer 2007-08-10 11:33:14 -07:00
sspitzer@mozilla.org
782a2d3513 fix for bug: mozStorage doesn't handle unicode in LIKE, UPPER, or LOWER functions patch=Shawn Wilsher <sdwilsh@mozilla.com> r=sspitzer 2007-08-10 09:19:57 -07:00
sspitzer@mozilla.org
332939b510 fix for bug #385067: upgrade to latest version of sqlite (3.4.0) 
patch=sdwilsh, rs=sspitzer

fix for bug #387609:  Add check for lastError in test_storage_progresshandler.js

patch=sdwish, r=sspitzer
 2007-08-02 08:24:50 -07:00
flamingice@sourmilk.net
d27e310053 Bug 386179, Stop using sqlite3ApiExit, r=sdwilsh 2007-07-24 19:18:54 -07:00
sdwilsh@shawnwilsher.com
fba73878f4 Bug 388059 - Add a getColumnIndex method to mozIStorageStatement. r=sspitzer 2007-07-19 09:30:17 -07:00
sdwilsh@shawnwilsher.com
37a18305d8 Bug 306907 - Build libsqlite as a standard name separate shared library. Patch by Michael Wu <michael.wu@mozilla.com>, Robert Relyea <rrelyea@redhat.com>, Ryan VanderMeulen <ryanvm@gmail.com>, and Shawn Wilsher <me@shawnwilsher.com>. r=benjamin 2007-07-18 09:20:12 -07:00
sdwilsh@shawnwilsher.com
289d7b6399 Backout of Bug 306907 2007-07-16 14:32:03 -07:00
sdwilsh@shawnwilsher.com
f7d59f8730 Bug 306907 - Build libsqlite as a standard name separate shared library. Patch by Michael Wu <michael.wu@mozilla.com>, Robert Relyea <rrelyea@redhat.com>, Ryan VanderMeulen <ryanvm@gmail.com>, and Shawn Wilsher <me@shawnwilsher.com>. r=benjamin 2007-07-16 14:23:29 -07:00
sdwilsh@shawnwilsher.com
fe1aace69e Bug 388048 - mozIStorageStatement::getParameterIndexes is useless. r=sspitzer 2007-07-15 11:03:20 -07:00
sdwilsh@shawnwilsher.com
b1e2d17d25 Bug 384526 - Use sqlite3_prepare_v2 instead of sqlite3_prepare. r=sspitzer 2007-07-11 15:20:39 -07:00
sdwilsh@shawnwilsher.com
577bc46266 Backout of Bug 384526 (causes orange) 2007-07-10 10:23:36 -07:00
sdwilsh@shawnwilsher.com
f0ad954a38 Bug 384526 - Use sqlite3_prepare_v2 instead of sqlite3_prepare. r=sspitzer 2007-07-10 09:58:17 -07:00
jwalden@mit.edu
6d7584839a Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros. 2007-07-08 00:08:04 -07:00
sdwilsh@shawnwilsher.com
ae472131bb Bug 333848 - add full-featured user-defined functions and progress handlers to storage. Patch by Lev Serebryakov <blacklion@gmail.com>. r=sdwilsh 2007-07-07 14:14:51 -07:00
sdwilsh@shawnwilsher.com
48b5d9c4c7 Orange fix. rs=gavin.sharp 2007-07-03 15:49:42 -07:00
sdwilsh@shawnwilsher.com
c85a71828e Fix orange. r=gavin.sharp 2007-07-03 15:33:46 -07:00
sdwilsh@shawnwilsher.com
f7a000c5ad Bug 386394 - Add a BackupDB method to mozIStorageConnection. r=mano 2007-07-03 13:54:36 -07:00
sdwilsh@shawnwilsher.com
45f62da930 Bug 365166 - crash [@ strlen] calling mozIStorageStatement::getColumnName of a statement created with "PRAGMA user_version" or "PRAGMA schema_version". Patch by Nickolay Ponomarev <asqueella@gmail.com>. r=sdwilsh 2007-07-02 15:36:41 -07:00
sdwilsh@shawnwilsher.com
85aaf21905 Bug 386179 - Stop using private sqlite functions. r=sspitzer 2007-07-02 10:25:36 -07:00
philringnalda@gmail.com
6e71e3b302 Bug 386366 - Add convenience method for getting the database schema version, patch by Shawn Wilsher <sdwilsh@mozilla.com>, r=sspitzer 2007-06-29 20:32:09 -07:00
sdwilsh@shawnwilsher.com
96595fe1ec Bug 385396 - Go back to vanilla sqlite files. r=mconnor 2007-06-22 14:34:14 -07:00
sdwilsh@shawnwilsher.com
b81af09a35 Bug 385431 - mozStorageAsyncIO.cpp:559: warning: unused variable 'message'. Patch by Ryan Jones <sciguyryan@gmail.com>. r=sdwilsh 2007-06-22 13:24:43 -07:00
sdwilsh@shawnwilsher.com
4b9b00f4de Bug 385262 - NOTREACHED called before logging. Patch by Ryan Jones <sciguyryan@gmail.com>. r=sdwilsh 2007-06-21 16:52:18 -07:00
sdwilsh@shawnwilsher.com
f216036065 Bug 341137 - Upgrade to latest version of sqlite (take 2). r=vladimir 2007-06-20 20:17:26 -07:00
sdwilsh@shawnwilsher.com
f9cbdb055e Backout of Bug 341137 2007-06-19 16:47:38 -07:00
sdwilsh@shawnwilsher.com
1028df0814 Bug 341137 - Upgrade to latest version of sqlite. r=vladimir 2007-06-19 12:54:01 -07:00
sdwilsh@shawnwilsher.com
0495f06ad9 Bug 363024 - Calling createInstance() on mozIStorageService crashes. r=sspitzer 2007-06-18 19:22:01 -07:00
sdwilsh@shawnwilsher.com
d96db35e43 Bug 384454 - Remove sqlite3_bind_parameter_indexes. r=sspitzer 2007-06-18 16:42:23 -07:00
dwitte@stanford.edu
07b2c9ca5f check for non-null connection in mozStorageTransaction helper. b=384224, r=sspitzer 2007-06-13 21:58:52 -07:00
sdwilsh@shawnwilsher.com
71a99118bc Bug 383543 - mozStorageService cleanup. r=sspitzer 2007-06-12 16:31:59 -07:00
sdwilsh@shawnwilsher.com
f92f905f8e Bug 383534 - mozStorageConnection ignores return values (and other cleanup). r=sspitzer 2007-06-12 16:19:34 -07:00
sdwilsh@shawnwilsher.com
2f3c92b111 Bug 381549 - mozStorageStatement ignores return values from SQLite. r=sspitzer 2007-06-12 15:01:05 -07:00
sdwilsh@shawnwilsher.com
37e6ed019e Bug 383619 - Get xpcshell tests for mozStorage (windows orange fix). r=rcampbell 2007-06-12 09:28:27 -07:00
sdwilsh@shawnwilsher.com
19f75e9c18 Disabling tests from Bug Bug 383619 because windows doesn't like them :( 2007-06-11 21:33:25 -07:00
sdwilsh@shawnwilsher.com
23d6cb6f49 Bug 383619 - Get xpcshell tests for mozStorage. r=vladimir 2007-06-11 20:59:26 -07:00
igor@mir2.org
b65d41cc03 Bug 377751: Switching JSClass.mark in XPConnect to the tracing semantics. r=jst, sr=brendan 2007-05-02 13:20:21 -07:00
igor@mir2.org
4411f6fc39 Bug 377751: removal of the commit. 2007-05-01 14:54:29 -07:00
igor@mir2.org
95a992af95 Bug 377751: JSClass instances in xpconnect use the tracing API. r=brendan, sr=jst 2007-05-01 14:06:07 -07:00
vladimir%pobox.com
31c8e763e7 b=334174, corrupted db files are not handled correctly, r=brettw 2006-07-26 18:54:12 +00:00
brettw%gmail.com
0653b5c604 Bug 334675 r=darin a=mconnor Notify users on async IO errors 2006-07-25 17:04:48 +00:00
timeless%mozdev.org
52a93bff56 Bug 337917 Make consumers stop using cids from other modules 
r=brettw@gmail.com sr=neil
 2006-06-03 23:41:19 +00:00
brettw%gmail.com
50798069cc Bug 333306 r+a=vladimir Crash with pragma statements that return values 2006-05-22 19:18:00 +00:00
brettw%gmail.com
fb620b8cec Bug 336230 r+a=vlad Bug in ASYNC_SYNC 2006-05-19 16:25:40 +00:00
darin%meer.net
0318b8c707 landing patch for bug 326273 "Implement nsIThreadManager" (Mac portions by Mark Mentovai) with reviews from bienvenu, bsmedberg, bzbarsky, josh, roc, and ssieb 2006-05-10 17:30:15 +00:00
brettw%gmail.com
34c03fdee2 Bug 336314 r=darin Make storage threadsafe 2006-05-03 23:29:12 +00:00
brettw%gmail.com
924d2bfb01 Bug 335836 r=vladimir Add warnings to comments on usage of storage service 2006-05-02 17:35:48 +00:00
gavin%gavinsharp.com
7661351919 Bug 334186: AsyncOpenExclusive returns freed value, patch by Ryan Flint <rflint@dslr.net>, r=brettw 2006-04-21 16:53:48 +00:00
benjamin%smedbergs.us
70a0f2207b Freeze nsIArray (requires separating nsIMutableArray into another .idl file); also removes NS_NewArray and moves do_QueryElementAt into the glue, r=darin 2006-04-12 15:43:32 +00:00
brettw%gmail.com
38955688fc Bug 331158 r=vladimir Add preload capability to storage service for sqlite pager cache. 2006-04-11 17:06:55 +00:00
bent.mozilla%gmail.com
e523eab05b Bug 328790 - Removing an extra NS_ADDREF that somehow crept into the other checkin. r=brettw, a=darin. 2006-04-07 18:09:12 +00:00
bent.mozilla%gmail.com
c3bf5cdde7 Bug 328790 - "main thread never joins with async-io thread". r=brettw. 2006-04-06 17:22:30 +00:00
benjamin%smedbergs.us
463a240463 Bug 78081 - don't export intermediate libraries - initial makefile changes to switch from $(DIST)/lib to in-tree library locations - blanket-r=mento 2006-04-06 14:45:37 +00:00
benjamin%smedbergs.us
ad93adc654 Bug 331476 - Make storage test use the XPCOM glue, r=vlad 2006-03-27 19:43:09 +00:00
benjamin%smedbergs.us
d4c2839bfc Don't build storage tests until libxul is available 2006-03-23 15:52:20 +00:00
dmose%mozilla.org
1b6b95ac60 Fix regression (bug 329518) which made databases created by mozStorage be UTF-16 encoded and caused other havoc. Caused by the landing of the first patch in bug 324311; fixup patch posted to that bug also. r=bryner, a181=bryner 2006-03-07 03:48:34 +00:00
dmose%mozilla.org
11b16050d0 Fix profile startup failure when non-ASCII characters are in the profile path name (bug 324311). Thanks to Nickolay Ponomarev <asqueella@gmail.com> for the patch; r=bryner, a181=bryner. 2006-03-06 05:40:32 +00:00
brettw%gmail.com
160ca2a46c Bug 327317 r=vladimir Create IndexExists function 2006-02-28 20:57:39 +00:00
brettw%gmail.com
51c96d792d Bug 327907 r=bryner Fix DB corruption problem. Truncate was using the wrong 
value.
 2006-02-24 22:26:56 +00:00
brettw%gmail.com
64ead40c90 Bug 327740 r=vladimir Replaces REINTERPRET_CASTs with STATIC_CASTs in 
mozStorageAsyncIO.cpp
 2006-02-23 19:25:40 +00:00
timeless%mozdev.org
1ce5986f6b Bug 106386 Correct misspellings in source code 
r=bernd rs=brendan
 2006-02-23 09:36:43 +00:00
brettw%gmail.com
6b621d1972 Bug 328212 r=vladimir Update AsyncIO with fixed bugs in sqlite tree. 2006-02-22 21:14:42 +00:00
brettw%gmail.com
d25d558be1 Bug 327567, r=darin. Storage connections should not outlive service (crasher). 2006-02-17 21:28:51 +00:00
benjamin%smedbergs.us
54c4672ea7 Bug 327638 - PRInt64 and sqlite_int64 are not automatically compatible types, r=vlad 2006-02-17 21:23:15 +00:00
brettw%gmail.com
e9d7114677 Bug 327557, r=darin. Storage service keeps references to main thread. 2006-02-17 00:36:24 +00:00
brettw%gmail.com
fc00d8e51b Bug 326334 r=vladimir, darin Multithreaded commit for storage. 2006-02-16 02:59:42 +00:00
benjamin%smedbergs.us
c028f45f24 Bug 327188 - enable places by default, r=bryner 2006-02-15 18:46:10 +00:00
brettw%gmail.com
a602db42c7 Bug 324994 forgotten interface documentation. 2006-02-08 02:18:12 +00:00
brettw%gmail.com
ef9bc3d6af Bug 324994 r=bryner sr=vladimir GetString should set IsVoid when column is 
null.
 2006-02-07 23:10:16 +00:00
brettw%gmail.com
7c77c3a347 Bug 319453, r=vladimir: Bounds check GetBlob, return NULL if 0 size. 2005-12-07 20:52:33 +00:00
vladimir%pobox.com
50ab924987 b=273050, bump interface UUIDs and fix test compilation 2005-11-15 19:35:39 +00:00
vladimir%pobox.com
f2232124e1 b=273050, storage module interface review, r=darin 2005-11-15 00:35:50 +00:00
brettw%gmail.com
199733fca5 Helper class for C++ users to manage transaction scope. 
bug 310636
r=bryner
 2005-11-08 02:16:15 +00:00
brettw%gmail.com
c9d2ed39ae Added helper classes for C++ users to deal with transaction and statement 
scope. Exposes sqlite's in-memory database capability.

bug 310636
r=bryner
 2005-11-08 02:15:01 +00:00
mrbkap%gmail.com
ac604da132 bug 311024: Make sure eval grabs the right scope object. r=brendan sr=jst 2005-10-08 00:28:45 +00:00
dmose%mozilla.org
b593e1f71a Fixing build bustage by adding stub methods for the two new methods that were added to nsIXPCScriptable 2005-07-31 21:12:49 +00:00
vladimir%pobox.com
1afea82710 b=293183, implement exception support for recurrence, r=shaver 2005-06-10 01:31:48 +00:00
vladimir%pobox.com
ef962212a7 Make mozStorageStatement::Execute() use ExecuteStep(), to get the right SQLITE_SCHEMA handling, r=me 2005-05-27 20:14:09 +00:00
vladimir%pobox.com
02b491c5e1 b=293707, update storage calendar, partial (mozStorage-only) commit, r=shaver 2005-05-12 01:09:04 +00:00
vladimir%pobox.com
49d2dc81b4 b=291991, fix sqlite_schema stuff in mozStorageStatement, again r=shaver 2005-04-26 22:28:06 +00:00
vladimir%pobox.com
4205a6ed9e fix for SQLITE_SCHEMA error, as well as using multiple-named-statement binding functions 2005-04-17 21:00:50 +00:00
bsmedberg%covad.net
844ef87b25 Adding MOZILLA_INTERNAL_API to internal makefiles, bug 288626, rs=darin 2005-04-05 14:50:16 +00:00
vladimir%pobox.com
94b11d5317 Boolean logic is hard, r=me 2005-03-24 22:58:30 +00:00
vladimir%pobox.com
e5e6c1dae3 Handle SQLITE_SCHEMA correctly be retrying the statement, r=me 2005-03-24 19:59:59 +00:00
shaver%mozilla.org
d71ce074e5 fix DIRS = vs DIRS += error; thanks to Nick Thomas for catching it; r=vlad 2005-03-22 17:33:00 +00:00
shaver%mozilla.org
02535c350c Bug 283057: Fold sqlite build into storage build, honour ENABLE_TESTS. 
r=bsmedberg
 2005-03-21 17:01:57 +00:00
mattwillis%gmail.com
446a80de3d Fixed compile on Windows with gcc 
r=shaver
 2005-01-07 20:52:04 +00:00
gerv%gerv.net
81ac4dc799 iBug 236613: change to MPL/LGPL/GPL tri-license. 2004-12-27 18:45:32 +00:00