Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-19 08:15:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
629,349 Commits 615 Branches 98 Tags 5.9 GiB
8bcc495ca2
Commit Graph

267 Commits

Author SHA1 Message Date
Birunthan Mohanathas
c9fb2c0d48 Bug 1022456 - Fix modelines in xpcom/{base,glue,io,string,threads}/. r=froydnj 2014-06-30 08:39:45 -07:00
Nathan Froyd
c3ea6db0ae Bug 728600 - define TARGET_XPCOM_ABI in mozilla-config.h; r=glandium 2014-06-23 15:06:48 -04:00
Ehsan Akhgari
17f4a32d8b Bug 976896 - Port STL_FLAGS to moz.build; r=mshal 2014-03-04 19:39:06 -05:00
L. David Baron
7d750b2a18 Bug 975295 patch 2: Remove the nsITraceRefcnt interface and any instantiation of the nsTraceRefcntImpl object. r=bsmedberg 2014-02-24 15:27:53 -08:00
Ehsan Akhgari
b7b6d52aef Bug 970745 - Move USE_STATIC_LIBS to moz.build; r=glandium 2014-02-11 09:12:33 -05:00
Ehsan Akhgari
d91d200572 Bug 969757 - Remove the dead code in our tree which pretends to support OS/2; r=roc,mcmanus,gps,jorendorf,bsmedberg sr=bsmedberg 2014-02-10 17:57:01 -05:00
Ehsan Akhgari
1b83407ce9 Bug 927728 - Part 1: Replace PRUnichar with char16_t; r=roc 
This patch was automatically generated by the following script:

#!/bin/bash
# Command to convert PRUnichar to char16_t

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*modules/libmar*" \
       ! -wholename "*/.hg*" \
       ! -wholename "obj-ff-dbg*" \
       ! -name prtypes.h \
       ! -name Char16.h \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert PRUnichar char16_t
 2014-01-04 10:02:17 -05:00
Ms2ger
561cae4a0e Bug 950130 - Move more INCLUDES / LOCAL_INCLUDES to moz.build; r=mshal 2013-12-31 10:06:11 +01:00
Mike Hommey
8fd06cf41b Bug 874266 - Move all DEFINES that can be moved to moz.build. r=mshal 2013-11-27 22:55:07 +09:00
Mike Hommey
b32a4ed166 Backout changeset 3fd4b546eed4 (bug 874266) and changeset a35d2e3a872f (bug 942043) for ASAN build bustage and Windows test bustage 
--HG--
extra : amend_source : f20d09aeff1c8b5cbd0f1d24c7ce04e86f3aed1d
 2013-11-28 14:24:05 +09:00
Mike Hommey
682364d535 Bug 874266 - Move all DEFINES that can be moved to moz.build. r=mshal 2013-11-28 13:08:16 +09:00
Mike Hommey
e80e877ab7 Bug 939044 - Remove most definitions of MODULE. r=mshal 2013-11-19 11:47:39 +09:00
Cykesiopka
d2f6b7333c Bug 914270 - Part 1: Simple/Automated moves. r=joey 2013-10-24 18:51:00 +01:00
Mike Hommey
b000a846c2 Bug 929905 - Consolidate sources in moz.build. r=gps 2013-10-25 08:23:05 +09:00
Joey Armstrong
dad034f5cd bug 882907: move SDK_LIBRARY to mozbuild. r=mshal 2013-09-20 18:00:48 -04:00
Brian O'Keefe
916782e929 Bug 865673 - Convert objs.mk to objs.mozbuild. r=gps 2013-08-30 09:09:06 -04:00
Mike Hommey
f8bc7fa754 Bug 912293 - Remove now redundant boilerplate from Makefile.in. r=gps 2013-09-05 09:01:46 +09:00
Ms2ger
a4e67abf5e Bug 897921 - Remove some dead assignments in makefiles; r=mshal 2013-08-02 09:03:55 +02:00
Olli Pettay
b002b30b2a bug 789919, (snow-white) make addref/release of CCable objects faster by removing indirect refcnt increase/decrease, r=mccr8, test changes r=ehsan 
--HG--
extra : rebase_source : 2a3b22425c14d6daedc91d62a652c34431acd2fb
 2013-07-09 13:30:58 -04:00
Joey Armstrong
250777fa49 bug 883350: move SDK_HEADERS to mozbuild (file batch #1) r=mshal 2013-07-01 17:24:53 -04:00
Brian O'Keefe
11bcc1cd9e Bug 875934 - Move LIBRARY_NAME to moz.build (batch #1); r=mshal 
--HG--
extra : rebase_source : 385d3fd65475ffc18ee44ae088753649470e214b
 2013-06-17 15:21:01 -04:00
Mike Shal
7fd6f5b4f1 Bug 882738 - Remove SRCS_IN_OBJDIR from Makefile.in; r=joey 
From a071ba8cffdd4584b3cd31eae207e5b76b9e9c95 Mon Sep 17 00:00:00 2001
 2013-06-13 13:49:01 -04:00
Benoit Girard
0d44f34246 Bug 844288 - Dual link libxul.so and libxul-unit.so and replace enable-gtest by enable-test r=ted,glandium 
- Remove enable GTest
- Add a general target to create gtestxul
- Update mach target
- Run GTest from make check

--HG--
rename : gfx/2d/unittest/GTestMain.cpp => gfx/tests/gtest/TestMoz2D.cpp
rename : gfx/layers/TestTiledLayerBuffer.cpp => gfx/tests/gtest/TestTiledLayerBuffer.cpp
extra : rebase_source : 862c39b9145328c8e9f85ae9d1963af374af76f1
 2013-03-11 14:47:40 -04:00
Phil Ringnalda
4aec020413 Back out dc76402b8471 (bug 844288) on suspicion of breaking dep builds 
CLOSED TREE
 2013-05-31 07:39:56 -07:00
Benoit Girard
908b9e495b Bug 844288 - Dual link libxul.so and libxul-unit.so and replace enable-gtest by enable-test r=ted,glandium 
- Remove enable GTest
- Add a general target to create gtestxul
- Update mach target
- Run GTest from make check

--HG--
rename : gfx/2d/unittest/GTestMain.cpp => gfx/tests/gtest/TestMoz2D.cpp
rename : gfx/layers/TestTiledLayerBuffer.cpp => gfx/tests/gtest/TestTiledLayerBuffer.cpp
extra : rebase_source : 5b9be0892323195d4e24f11ae785f0663ff38fd0
 2013-03-11 14:47:40 -04:00
Phil Ringnalda
ad4c150cb3 Back out 816311e43409 (bug 844288) on suspicion of causing dep OS X universal builds to fail in packaging 
CLOSED TREE
 2013-05-29 23:42:20 -07:00
Benoit Girard
397d220ef5 Bug 844288 - Dual link libxul.so and libxul-unit.so and replace enable-gtest by enable-test r=ted,glandium 
- Remove enable GTest
- Add a general target to create gtestxul
- Update mach target
- Run GTest from make check

--HG--
rename : gfx/2d/unittest/GTestMain.cpp => gfx/tests/gtest/TestMoz2D.cpp
rename : gfx/layers/TestTiledLayerBuffer.cpp => gfx/tests/gtest/TestTiledLayerBuffer.cpp
extra : rebase_source : 04c9c2efbc7db1c04c121cf3022612b488f83eb4
 2013-03-11 14:47:40 -04:00
Mike Shal
5169c0a913 Bug 864774 - Part 2: Move CPPSRCS to moz.build as CPP_SOURCES; r=joey CLOSED TREE 
From 9e0ba7f425143f545eb6c4b26a9a96b5ade4d8e9 Mon Sep 17 00:00:00 2001
 2013-04-23 17:54:15 -04:00
Kyle Machulis
72a717a860 Bug 855465 - Add emacs python mode comments to moz.build files; r=gps 2013-04-01 11:36:59 -07:00
Kyle Machulis
43628a7867 Backout for changeset 03452b187c14 (Bug 855465) due to bustage on a CLOSED TREE; r=qdot 2013-03-29 15:12:58 -07:00
Kyle Machulis
334c0800cf Bug 855465 - Add emacs python mode comments to moz.build files; r=gps 
--HG--
extra : rebase_source : 004a756492323e1a049586e85b3be5037159df20
 2013-03-29 13:56:18 -07:00
Mike Hommey
347a7c2d09 Bug 852950 - Kill libxpcom. r=bsmedberg 
Also refactored the xpcom standalone glue to reside in a single file and
removed its use of realpath().

--HG--
rename : xpcom/stub/dependentlibs.py => toolkit/library/dependentlibs.py
rename : xpcom/stub/nsXPComStub.cpp => xpcom/build/FrozenFunctions.cpp
 2013-03-20 14:56:41 +01:00
Mike Shal
7ecea60097 Bug 844654 - Part 2: Move MODULE to moz.build; rs=gps 2013-03-19 11:47:00 -07:00
Aaron Klotz
04680280aa Bug 845907: Adds generic ReadAhead functions r=glandium 2013-03-03 18:56:03 -07:00
Aaron Klotz
f698145c72 Backed out a40244b87c7a (bug 845907) 2013-03-02 17:08:05 -07:00
Aaron Klotz
87b5759171 Bug 845907: Adds generic ReadAhead functions r=glandium 2013-03-02 16:13:38 -07:00
Gregory Szorc
8958bacc6e Bug 784841 - Part 18ν: Convert /xpcom; f=Ms2ger rs=ted 2013-02-25 13:20:02 -08:00
Trevor Saunders
0f94b545d6 bug 829288 - fix a bunch of mingw warnings in xpcom/ r=ehsan 2013-01-10 03:39:40 -05:00
Benoit Girard
cd64937ac7 Bug 761135 - Remove XPCOMGlueShutdown. r=benjamin 2013-01-07 16:19:39 -05:00
Andrew McCreight
d5b4c64064 Bug 750570, part 2 - Add purple buffer support for non-nsISupports classes. r=smaug 
We add a new field to purple buffer entries, to store the participant for
non-nsISupports classes. For nsISupports, we store NULL instead. The participant
has to be passed into Suspect2.

In the cycle collector itself, we generalize canonicalization to handle the
possibility that we can just grab the participant directly from a field,
rather than needing to QI something.

Most of the patch is just routing around this extra pointer.
 2012-08-24 09:50:06 -07:00
Ehsan Akhgari
e368dc9c85 Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg 
This patch was generated by a script.  Here's the source of the script for
future reference:

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*/.hg*" \
       ! -wholename "obj-ff-dbg*" \
       ! -name nsXPCOMCID.h \
       ! -name prtypes.h \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t

convert PRIntn int
convert PRUintn unsigned

convert PRSize size_t

convert PROffset32 int32_t
convert PROffset64 int64_t

convert PRPtrdiff ptrdiff_t

convert PRFloat64 double
 2012-08-22 11:56:38 -04:00
Ms2ger
5f4593aa2e Bug 780387 - Part e: Stop using PRSize; r=bsmedberg 2012-08-09 09:10:11 +02:00
Mike Hommey
70d7c821af Bug 774032 bonus - Use @DEPTH@ and @relativesrcdir@ in Makefile.in. r=ted 2012-08-04 20:26:44 +02:00
Nathan Froyd
4328d1be09 Bug 778220 - remove $(wildcard *.$(OBJ_SUFFIX)) calls from xpcom Makefiles; r=glandium 2012-07-27 14:15:01 -04:00
Aryeh Gregor
d0ad5a7d0c Bug 777292 part 2 - Change all nsnull to nullptr 2012-07-30 17:20:58 +03:00
Joshua Cranmer
a1186c1020 Bug 773637 - Kill NS_SCRIPTABLE annotations, Part 1: Remove NS_*PARAM annotations. r=ehsan 
--HG--
extra : rebase_source : a0b4bc50fece36d9a90fed61431635948bfa33b5
 2012-07-06 15:14:07 -05:00
Geoff Lankow
5cefea8480 Bug 749930 - Replace uses of nsILocalFile with nsIFile (compiled code only); r=bsmedberg 2012-06-06 14:08:30 +12:00
Jim Mathies
025f49633e Bug 732124 - Fix for crt link errors with VC11 - build glue using both the static and the dynamic runtime lib, and link accordingly for various components. r=ted 2012-05-21 16:31:03 -05:00
Gervase Markham
82ff7027aa Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Mike Hommey
4221a257f2 Bug 686805 part 7 - Display linker stats on each Startup Timeline event. r=tglek,r=khuey 2012-02-22 08:12:15 +01:00
Mike Hommey
0587da37fd Bug 683127 part 6 - Use wrapped dl* functions in the XPCOM standalone glue when building with MOZ_LINKER on Linux. r=bsmedberg 2012-01-20 09:48:44 +01:00
Gregory Szorc
1a1f7b30ae Bug 698248 - Remove unused FORCE_USE_PIC variable; r=khuey 2011-11-01 15:45:23 -07:00
Ehsan Akhgari
92064e6d3f Bug 690892 - Replace PR_TRUE/PR_FALSE with true/false on mozilla-central; rs=dbaron 
Landing on a CLOSED TREE
 2011-10-17 10:59:28 -04:00
Michael Wu
d2b70213ac Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones 
--HG--
rename : tools/trace-malloc/bloatblame.c => tools/trace-malloc/bloatblame.cpp
 2011-09-28 23:19:26 -07:00
Ted Mielczarek
9bebef958d bug 681716 - use dlopen linking glue on iOS. r=bsmedberg 2010-11-05 09:11:57 -04:00
Mike Hommey
0cf5a8c697 Bug 675618 - Compile pldhash as C++. r=bsmedberg 
--HG--
rename : xpcom/glue/pldhash.c => xpcom/glue/pldhash.cpp
 2011-08-09 09:06:37 +02:00
Rafael Ávila de Espíndola
0896eb7fb6 Bug 674446 - Add a bit of logging to nsGlueLinkingOSX.cpp; r=glandium 2011-08-08 23:16:23 -04:00
Makoto Kato
39f6103e29 Bug 665816 - nsGlueLinkingDlopen.cpp:161: error: expected unqualified-id before numeric constant with NDKr5 after landing bug 632404. r=glandium 2011-06-21 16:52:18 +09:00
Mike Hommey
f3a01a3041 Bug 632404 - Preload dependent libraries at startup. r=tglek,r=bsmedberg 2011-05-16 10:25:05 +02:00
Mike Hommey
fe1fe23762 Bug 658995 part 1 - Properly divert memory allocation functions for trace malloc with standalone glue on Linux. r=dbaron 2011-06-15 07:30:44 +02:00
Matt Brubeck
e3a9a86a79 Back out 6b23b52e68d6 - e92f98e8a335 (bug 632404, 552864, 658995) because of Tp4 regression. 2011-06-15 09:00:28 -07:00
Mike Hommey
93063fa6d0 Bug 632404 - Preload dependent libraries at startup. r=tglek,r=bsmedberg 2011-05-16 10:25:05 +02:00
Mike Hommey
c0abf2504a Bug 658995 part 1 - Properly divert memory allocation functions for trace malloc with standalone glue on Linux. r=dbaron 2011-06-15 07:30:44 +02:00
Ed Morley
33aac194a8 Bug 652506 - Remove WinCE code from xpcom; r=bsmedberg 2011-05-01 20:59:24 +02:00
Benjamin Smedberg
8489c6e6df Bug 642795 - Remove support for registering and finding "system XULRunner" via config files or the registry. r=glandium 
--HG--
extra : rebase_source : d42aa76683b6bb7de5df1b49b47f422a469201f4
 2011-04-01 13:28:33 -04:00
Mike Hommey
e0ba81d2eb Bug 584474 part 9 - Replace fakelibs with a more sophisticated library expansion system. r=ted 2011-02-25 15:05:08 +01:00
Mitchell Field
a6788f0842 Bug 627277 - Remove (broken) BeOS support. r=biesi,dwitte,gavin,joe,jorendorff,josh,khuey,mfinkle,neil,Pike,roc,shaver,smontagu,taras 2011-02-20 06:10:24 +11:00
Kyle Huey
aacb9b6fdb Whitespace change to trigger another set of builds on a CLOSED TREE 2010-08-01 04:48:13 -07:00
Kyle Huey
ef8a1429c9 Bug 522770: Link directly to object files instead of intermediate static libs. Patch originally written by Ted Mielczarek. Checking into a CLOSED TREE as a bustage fix. reviews pending. 
--HG--
extra : rebase_source : 54a506a5815dcdedaf3f61ad7d6bdd0529d7f5f7
 2010-08-01 01:48:21 -07:00
Benjamin Smedberg
c611ebcd81 Bug 568691 part A - register static and binary components using data tables rather than programmatic nsIComponentRegistrar methods. This part contains the important needs-review bits of the change: part B contains the mechanical changes to each module in order to actually get a working build. Part C will contain changes necessary to register JS components from .manifest files 2010-06-10 14:11:11 -04:00
Chris Jones
ce99d8226f Bug 557060: Interpose _Throw() on MSVC and centralize pseudo-throw code in mozalloc. r=ehsan sr=bsmedberg 2010-04-20 15:12:02 -05:00
Mike Hommey
0c2b28a6f9 Bug 555901 - Support for GNU/Hurd [r=benjamin] 
--HG--
extra : rebase_source : 2a455d93f9daaf7760285ea10046cc978ac9f9ad
 2010-04-19 10:39:58 +02:00
Benjamin Smedberg
ba372f3a4c Followup to bug 398573 - remove REQUIRES from the tree since it is no longer used... automatically generated patch, rs=ted 2009-08-25 08:59:31 -07:00
Hiroyuki Ikezoe
13b4c00db7 Bug 494412 – Make error message more clear when we can't load xpcom due to lack of memory; (XPCOM part); r=benjamin 2009-06-26 09:46:09 +09:00
Hiroyuki Ikezoe
21cff4e6ad Bug 490275 - Memory leak in xpcom/glue/standalone/nsGlueLinkingWin.cpp; r=benjamin 2009-05-14 16:17:53 +02:00
Hiroyuki Ikezoe
61cc6728cf Bug 488157. Use UTF8 instead of native codepages during startup. r=bsmedberg 
--HG--
extra : rebase_source : 22bea59e453f953f3efd43d6d945d9d9fee70ce5
 2009-05-13 22:16:45 +12:00
L. David Baron
368b7f1ed8 Make cycle collector's purple buffer consist of entries that the objects in the purple buffer can point to, and remove the notion of scan delay (which was previously set to 0). (Bug 490695) r+sr=peterv r=bsmedberg 2009-05-06 13:46:04 -07:00
Hiroyuki Ikezoe
059019827b bug 487174 - Modify nsXULStub to launch from GRE folder on WinCE r=bsmedberg 2009-04-13 22:49:06 -04:00
Daniel Holbert
4301671b45 Bug 473236 - Remove executable bit from files that don't need it. (Only changes file mode -- no code changes.) r=bsmedberg 2009-01-21 22:55:08 -08:00
Brad Lassey
dff03b246f Bug 461859 - windows mobile minor cleanup of xpcom r=bsmedberg 2008-12-03 08:42:03 -05:00
Brad Lassey
418f5366f7 Bug 455381 - WinCE XPCOM Explicit Unicode API Calls, Wide Char CheckVersion Function r=bsmedberg 2008-12-03 08:41:12 -05:00
reed@reedloden.com
811d778582 Bug 420373 - "need a way to distinguish GREs based on architecture in nsGREGlue" [p=mozilla@rosenauer.org (Wolfgang Rosenauer) r=bsmedberg a1.9b5=schrep] 2008-03-21 21:25:34 -07:00
dougt@meer.net
a1ca1ae26e Fixes for Windows CE. b=418662, r=bsmedberg, a=damons 2008-02-22 16:22:47 -08:00
reed@reedloden.com
a2aaecca91 Bug 333308 - "make clean and make distclean miss various files" [p=mh+mozilla@glandium.org (Mike Hommey) r=bsmedberg a1.9=schrep] 2008-02-13 03:33:38 -08:00
philringnalda@gmail.com
3432251d59 Bug 380783 - nsStringAPI.h: no equivalent of IsVoid (tell if string is null), patch by Mook <mook.moz+mozbz@gmail.com>, r=bsmedberg/dbaron, sr=dbaron, a1.9=bz 2007-08-17 20:48:16 -07:00
benjamin@smedbergs.us
5fb457dd7e Bug 386025 - Expose cycle-collection symbols, r=graydon 2007-08-06 07:34:02 -07:00
benjamin@smedbergs.us
cc074e3032 Bug 386445 - mac build stops with "multiple definitions of symbol nsINIParser::GetSrings", also changes to building mac dylibs with -single_module, r=luser,jag 2007-07-11 10:26:11 -07:00
benjamin@smedbergs.us
f1593a410c Bug 383167 try #3 - need buildid in an external file, r=luser sr=jst with additional parts r=biesi 2007-07-02 11:20:24 -07:00
benjamin@smedbergs.us
b21f7b3a04 Reverting bug 383167 again for linux test bustage :-( 2007-06-26 12:22:51 -07:00
benjamin@smedbergs.us
c93d1d5be6 Bug 383167 trying again, reviews by luser and biesi, sr=jst 2007-06-26 09:35:01 -07:00
benjamin@smedbergs.us
d782232066 Revert all of bug 383167 changes because they're not enough... going to try again later. 2007-06-25 11:40:57 -07:00
benjamin@smedbergs.us
7b42bb19aa Bug 383167 - Need buildid in an external file, r=luser sr=jst 2007-06-25 08:25:59 -07:00
benjamin@smedbergs.us
2111848195 Bug 375449 - NS_InvokeByIndex not exported from xpcom, only from xpcom_core, r=dbaron 2007-04-24 10:02:51 -07:00
hg@mozilla.com
05e5d33a57 Free the (distributed) Lizard! Automatic merge from CVS: Module mozilla: tag HG_REPO_INITIAL_IMPORT at 22 Mar 2007 10:30 PDT, 2007-03-22 10:30:00 -07:00
mozilla%weilbacher.org
7112ab4748 [OS/2] Bug 355077: fix xulrunner-stub to work on OS/2, p=abwillis1+me, r=mkaply 2007-01-10 08:43:08 +00:00
gerv%gerv.net
caae487a24 Bug 236613: change to MPL/LGPL/GPL tri-license. 2006-12-11 09:45:41 +00:00
benjamin%smedbergs.us
279fbbf5a4 Bug 334528 - xulrunner-stub requires the MSVC runtimes to be present; this also fixes embedders and component authors who want to link to the XPCOM glue libraries with various CRTs, r=darin 2006-08-30 15:57:03 +00:00
sergei_d%fi.tartu.ee
b66d351891 [BeOS]Fixing XPCOM Glue-standalone bustage, p=sergei_d, r=benjamin, affects only BeOS-port 2006-07-24 20:33:19 +00:00
benjamin%smedbergs.us
ec18f62436 Bug 333308 - make clean/distclean misses various files, patch by Mike Hommey <mh+mozilla@glandium.org>, r=me 2006-04-28 14:54:54 +00:00
benjamin%smedbergs.us
7ac1e0c149 Bug 335309 - Filehandle leak in XPCOMGlueLoadDependentLibs (found by coverity) - patch by Ryan Flint <rflint@dslr.net>, r=me+darin 2006-04-25 19:04:51 +00:00