Commit Graph

509 Commits

Author SHA1 Message Date
Sylvestre Ledru
f8b1d9ab46 Bug 1278282 - update of the moz.build files to remove gtk2 references r=lsalzman
MozReview-Commit-ID: FO1wEHzOkuN

--HG--
extra : rebase_source : ac7e61cf47d013de882048740c889735a0a7cad8
2018-01-10 10:04:59 +01:00
Lee Salzman
aa391ccc3e Bug 1424015: Build SkJumper_generated_win.obj with -SAFESEH. r=dmajor
MozReview-Commit-ID: 1mXCipgtjes
2017-12-19 14:21:06 -05:00
Lee Salzman
6ac81c37ea Bug 1418447 - Limit Skia edge builder allocations. r=milan
MozReview-Commit-ID: 1SnxwtoYJJm
2017-11-21 16:55:20 -05:00
Sylvestre Ledru
a9961096c0 Bug 1394734 - Simplify various corner cases r=glandium
MozReview-Commit-ID: 4s4JdXZPvmv

--HG--
extra : rebase_source : c8f663c99442d41db5f81ac5fe1aa1f47fd5ed82
2017-12-07 22:10:19 +01:00
Sylvestre Ledru
4591d82b23 Bug 1394734 - Replace CONFIG['CLANG*'] by CONFIG['CC_TYPE'] r=glandium
MozReview-Commit-ID: HbF5oT5HW6f

--HG--
extra : rebase_source : eca479b6ae4bff7f600d1cdb39e11ac2057e4e79
2017-12-07 22:09:38 +01:00
Sylvestre Ledru
5de63ef061 Bug 1394734 - Replace CONFIG['MSVC'] by CONFIG['CC_TYPE'] r=glandium
MozReview-Commit-ID: 5orfnoude7h

--HG--
extra : rebase_source : 1ed9a6b56e1d27221a07624767a7fb0e6147117f
2017-12-08 13:46:13 +01:00
Sylvestre Ledru
9bfe27d903 Bug 1394734 - Replace CONFIG['GNU_C*'] by CONFIG['CC_TYPE'] r=glandium
MozReview-Commit-ID: 7duJk2gSd4m

--HG--
extra : rebase_source : 7312fe276e561e8c034a5f6749774ae812727f9c
2017-12-07 22:09:15 +01:00
Lee Salzman
894f5cc99e Bug 1224396 - Skia path allocation cleanups. r=msreckovic
MozReview-Commit-ID: GAf2vC1Fucv
2017-11-22 12:19:29 -05:00
Chris Manchester
c86173526a Bug 1403346 - Replace all uses of ALLOW_COMPILER_WARNINGS with a template, remove ALLOW_COMPILER_WARNINGS. r=glandium
MozReview-Commit-ID: 1G2o4fy74cf
2017-10-25 15:12:09 -07:00
Lee Salzman
834a656e93 Bug 1387079 - only use SkRasterPipeline when SkJumper is accelerated. r=jrmuizel
MozReview-Commit-ID: 13dd2Ap4sob
2017-10-10 15:49:13 -04:00
Yoshi Huang
71dc552750 Bug 1404839 - fix linking error for TSAN build. r=froydnj, lsalzman 2017-10-09 10:40:41 +08:00
Tom Ritter
fd8f66ae19 Bug 1364560 Fix detection of Windows in Skia for MinGW build r=lsalzman
Windows detection was broken for the MinGW build. This pulls
in the upstream patch from
https://bugs.chromium.org/p/skia/issues/detail?id=6635

MozReview-Commit-ID: D0ZRIDaPmim

--HG--
extra : rebase_source : d20b6bd4bb1b2a93996775d36fe1c8484d0b0f85
2017-09-22 01:19:27 -05:00
Tom Ritter
6499172d8e Bug 1364560 Add support for disabling Skia Jumper assembly code r=lsalzman
The assembly code is not working in the MinGW build, so we
rebase and pull in the upstream commit that adds support for
not using the optimized jumper assembly code.

https://skia.googlesource.com/skia/+/6492afa7971cf295a3c3cb92a85218917c02bb4a

MozReview-Commit-ID: CARHRTHmQ0i

--HG--
extra : rebase_source : c6d9f19f8742a337e6ab3342d34118f37da71ae7
2017-09-25 23:02:35 -05:00
Jonathan Kew
7866196811 Bug 1402862 - Remove ENABLE_INTL_API conditional from gfx build files. r=milan 2017-09-25 17:32:47 +01:00
Lee Salzman
a20c1a8d1c Bug 1400721 - fix Skia's glyph LCD filter padding for FreeType 2.8.1. r=jrmuizel
MozReview-Commit-ID: JFvnANsTS0r
2017-09-18 15:28:37 -04:00
Lee Salzman
0edfbc2d51 Bug 1395127 - fix Skia's AAA to work with even rounding. r=jrmuizel
MozReview-Commit-ID: FCzINJvD1Md
2017-09-05 13:38:49 -04:00
Lee Salzman
e1d3260ea9 Bug 1393467 - clip FreeType glyph bitmap to mask in Skia. r=jrmuizel
MozReview-Commit-ID: 9NqLj9SkHFo
2017-08-31 11:09:31 -04:00
Lee Salzman
362b1401a4 Bug 1378130 - backport of fix for bounds violation in Skia's AAA path rendering. r=jrmuizel
MozReview-Commit-ID: 5NeeQpGYsoZ
2017-08-14 16:44:14 -04:00
Wes Kocher
e3d2d72438 Backed out changeset a0249586bdc1 (bug 1378130) for quantumrender reftest failures a=backout
MozReview-Commit-ID: 8wg7GtbR9Y3
2017-08-14 13:33:17 -07:00
Lee Salzman
74d36db919 Bug 1378130 - backport of fix for bounds violation in Skia's AAA path rendering. r=jrmuizel
MozReview-Commit-ID: 5NeeQpGYsoZ
2017-08-14 12:21:47 -04:00
Carsten "Tomcat" Book
3b7b01d32d Merge mozilla-central to inbound 2017-07-27 11:27:45 +02:00
Lee Salzman
f3254dc7ef Bug 1383767 - guarantee FreeType thread-safety by holding Cairo per-face lock and locking down rasterization. r=jrmuizel
MozReview-Commit-ID: DuPRIUBgw4W
2017-07-26 23:24:44 -04:00
Carsten "Tomcat" Book
efd795174c Backed out changeset 22947e9aa292 (bug 1383767) for bustage 2017-07-27 08:20:41 +02:00
Lee Salzman
58dcb7ef01 Bug 1383767 - guarantee FreeType thread-safety by holding Cairo per-face lock and locking down rasterization. r=jrmuizel
MozReview-Commit-ID: DuPRIUBgw4W
2017-07-26 23:24:44 -04:00
Kartikaya Gupta
ba4b3b9101 Bug 1384233 - Remove SizePrintfMacros.h. r=froydnj
We have a minimum requirement of VS 2015 for Windows builds, which supports
the z length modifier for format specifiers. So we don't need SizePrintfMacros.h
any more, and can just use %zu and friends directly everywhere.

MozReview-Commit-ID: 6s78RvPFMzv

--HG--
extra : rebase_source : 009ea39eb4dac1c927aa03e4f97d8ab673de8a0e
2017-07-26 16:03:57 -04:00
Lee Salzman
2d696d5c34 Bug 1376026 - fix plumbing of DWrite parameters for Skia fonts to not depend on gfxPlatform. r=jrmuizel
MozReview-Commit-ID: 5K9201eCSv
2017-06-30 14:09:05 -04:00
Sebastian Hengst
522fc18c93 Backed out changeset 24421d72ba08 (bug 1376026) 2017-07-07 21:42:09 +02:00
Lee Salzman
ab6885d706 Bug 1376026 - fix plumbing of DWrite parameters for Skia fonts to not depend on gfxPlatform. r=jrmuizel
MozReview-Commit-ID: 5K9201eCSv
2017-06-30 14:09:05 -04:00
Carsten "Tomcat" Book
fbc9f302f1 Backed out changeset d09fb3a5cedf (bug 1376026) 2017-07-06 08:11:48 +02:00
Lee Salzman
edc6db4195 Bug 1376026 - fix plumbing of DWrite parameters for Skia fonts to not depend on gfxPlatform. r=jrmuizel 2017-06-30 14:09:05 -04:00
Farmer Tseng
fda77ae953 Bug 1369302 - Set the font name to "Unknown" while fDWriteFontFamily is null. r=mchang
MozReview-Commit-ID: 4TED3Gh56IW

--HG--
extra : rebase_source : 463ff52865c09b6ead15eb401b80083188b2ab9a
2017-06-22 16:10:12 +08:00
Lee Salzman
29a9c9d166 Bug 1305085 - don't let SkScalerContext::computeMatrices generate zero scales. r=mchang
MozReview-Commit-ID: 4guj6XPWB47
2017-06-14 21:43:27 -04:00
Lee Salzman
c3de804e39 Bug 1364691 - don't use walk_convex_edges in Skia path rendering unless edge count is at least 2. r=mchang
MozReview-Commit-ID: 8lN0tpqZIEh
2017-05-26 12:59:29 -04:00
Lee Salzman
4dfbb20ffb Bug 1364691 - add assertions to help figure out why Skia's AAA is crashing. r=jrmuizel
MozReview-Commit-ID: 4J8ztujEe1I
2017-05-25 11:52:49 -04:00
Lee Salzman
8ffb6649bf Bug 1364774 - fix premultiplied color output from linear gradients in Skia. r=mchang
MozReview-Commit-ID: Ay3ftFJz6a3
2017-05-24 15:52:56 -04:00
Makoto Kato
516badc0be Bug 1364840 - Part 2. Generate aarch64 build rule to add CRC32 feature on aarch64. r=lsalzman
SkOpts.cpp will call Init_crc32() on aarch64 build.  So we should add SkOpts_crc32.cpp to aarch64 sources.

MozReview-Commit-ID: BInjMXYA1jH

--HG--
extra : rebase_source : e6f0236df1cd9035255689fff9683f86ed967f59
2017-05-15 18:30:19 +09:00
Lee Salzman
a2e8d3b7b9 Bug 1340627 - part 2 - update moz.build for Skia m59. r=jrmuizel
MozReview-Commit-ID: KdPvBio96Cw
2017-05-09 22:31:06 -04:00
Lee Salzman
008caf60cd Bug 1340627 - part 1 - update Skia source to m59. r=mchang
--HG--
rename : gfx/skia/skia/src/gpu/glsl/GrGLSL_impl.h => gfx/skia/skia/include/private/GrGLSL_impl.h
rename : gfx/skia/skia/src/core/SkMessageBus.h => gfx/skia/skia/include/private/SkMessageBus.h
rename : gfx/skia/skia/include/core/SkBlitRow.h => gfx/skia/skia/src/core/SkBlitRow.h
rename : gfx/skia/skia/include/effects/SkGaussianEdgeShader.h => gfx/skia/skia/src/effects/SkGaussianEdgeShader.h
rename : gfx/skia/skia/src/gpu/batches/GrAAConvexPathRenderer.h => gfx/skia/skia/src/gpu/ops/GrAAConvexPathRenderer.h
rename : gfx/skia/skia/src/gpu/batches/GrAAConvexTessellator.h => gfx/skia/skia/src/gpu/ops/GrAAConvexTessellator.h
rename : gfx/skia/skia/src/gpu/batches/GrAAHairLinePathRenderer.h => gfx/skia/skia/src/gpu/ops/GrAAHairLinePathRenderer.h
rename : gfx/skia/skia/src/gpu/batches/GrAALinearizingConvexPathRenderer.h => gfx/skia/skia/src/gpu/ops/GrAALinearizingConvexPathRenderer.h
rename : gfx/skia/skia/src/gpu/batches/GrPathStencilSettings.h => gfx/skia/skia/src/gpu/ops/GrPathStencilSettings.h
rename : gfx/skia/skia/src/gpu/batches/GrStencilAndCoverPathRenderer.h => gfx/skia/skia/src/gpu/ops/GrStencilAndCoverPathRenderer.h
rename : gfx/skia/skia/include/xml/SkXMLParser.h => gfx/skia/skia/src/xml/SkXMLParser.h
2017-05-09 22:30:58 -04:00
Carsten "Tomcat" Book
2e978e4438 Backed out changeset 0ded74baeaf2 (bug 1340627) for blocking m-i to m-c merge
--HG--
rename : gfx/skia/skia/src/core/SkBlitRow.h => gfx/skia/skia/include/core/SkBlitRow.h
rename : gfx/skia/skia/src/effects/SkGaussianEdgeShader.h => gfx/skia/skia/include/effects/SkGaussianEdgeShader.h
rename : gfx/skia/skia/src/xml/SkXMLParser.h => gfx/skia/skia/include/xml/SkXMLParser.h
rename : gfx/skia/skia/include/private/SkMessageBus.h => gfx/skia/skia/src/core/SkMessageBus.h
rename : gfx/skia/skia/src/gpu/ops/GrAAConvexPathRenderer.h => gfx/skia/skia/src/gpu/batches/GrAAConvexPathRenderer.h
rename : gfx/skia/skia/src/gpu/ops/GrAAConvexTessellator.h => gfx/skia/skia/src/gpu/batches/GrAAConvexTessellator.h
rename : gfx/skia/skia/src/gpu/ops/GrAAHairLinePathRenderer.h => gfx/skia/skia/src/gpu/batches/GrAAHairLinePathRenderer.h
rename : gfx/skia/skia/src/gpu/ops/GrAALinearizingConvexPathRenderer.h => gfx/skia/skia/src/gpu/batches/GrAALinearizingConvexPathRenderer.h
rename : gfx/skia/skia/src/gpu/ops/GrPathStencilSettings.h => gfx/skia/skia/src/gpu/batches/GrPathStencilSettings.h
rename : gfx/skia/skia/src/gpu/ops/GrStencilAndCoverPathRenderer.h => gfx/skia/skia/src/gpu/batches/GrStencilAndCoverPathRenderer.h
rename : gfx/skia/skia/include/private/GrGLSL_impl.h => gfx/skia/skia/src/gpu/glsl/GrGLSL_impl.h
2017-05-11 12:52:25 +02:00
Carsten "Tomcat" Book
d6dc2abb78 Backed out changeset 1b2683a840f3 (bug 1340627) 2017-05-11 12:51:59 +02:00
Lee Salzman
4107093832 Bug 1340627 - part 2 - update moz.build for Skia m59. r=jrmuizel
MozReview-Commit-ID: KdPvBio96Cw
2017-05-09 22:31:06 -04:00
Lee Salzman
e83e20fa0f Bug 1340627 - part 1 - update Skia source to m59. r=mchang
--HG--
rename : gfx/skia/skia/src/gpu/glsl/GrGLSL_impl.h => gfx/skia/skia/include/private/GrGLSL_impl.h
rename : gfx/skia/skia/src/core/SkMessageBus.h => gfx/skia/skia/include/private/SkMessageBus.h
rename : gfx/skia/skia/include/core/SkBlitRow.h => gfx/skia/skia/src/core/SkBlitRow.h
rename : gfx/skia/skia/include/effects/SkGaussianEdgeShader.h => gfx/skia/skia/src/effects/SkGaussianEdgeShader.h
rename : gfx/skia/skia/src/gpu/batches/GrAAConvexPathRenderer.h => gfx/skia/skia/src/gpu/ops/GrAAConvexPathRenderer.h
rename : gfx/skia/skia/src/gpu/batches/GrAAConvexTessellator.h => gfx/skia/skia/src/gpu/ops/GrAAConvexTessellator.h
rename : gfx/skia/skia/src/gpu/batches/GrAAHairLinePathRenderer.h => gfx/skia/skia/src/gpu/ops/GrAAHairLinePathRenderer.h
rename : gfx/skia/skia/src/gpu/batches/GrAALinearizingConvexPathRenderer.h => gfx/skia/skia/src/gpu/ops/GrAALinearizingConvexPathRenderer.h
rename : gfx/skia/skia/src/gpu/batches/GrPathStencilSettings.h => gfx/skia/skia/src/gpu/ops/GrPathStencilSettings.h
rename : gfx/skia/skia/src/gpu/batches/GrStencilAndCoverPathRenderer.h => gfx/skia/skia/src/gpu/ops/GrStencilAndCoverPathRenderer.h
rename : gfx/skia/skia/include/xml/SkXMLParser.h => gfx/skia/skia/src/xml/SkXMLParser.h
2017-05-09 22:30:58 -04:00
Wes Kocher
24a327994e Backed out 9 changesets (bug 1340627) for graphical glitches a=backout
Backed out changeset 0b1371055c7f (bug 1340627)
Backed out changeset f152be1fadb7 (bug 1340627)
Backed out changeset c691e2ab6a0c (bug 1340627)
Backed out changeset 3cb4bceb8d79 (bug 1340627)
Backed out changeset 026aadd76d06 (bug 1340627)
Backed out changeset fdbd5d281287 (bug 1340627)
Backed out changeset 75fb0d9858a9 (bug 1340627)
Backed out changeset 0d4ec7d38a00 (bug 1340627)
Backed out changeset af6f19870b2a (bug 1340627)

MozReview-Commit-ID: 9dHr7xMZezY

--HG--
rename : gfx/skia/skia/src/core/SkBlitRow.h => gfx/skia/skia/include/core/SkBlitRow.h
rename : gfx/skia/skia/src/effects/SkGaussianEdgeShader.h => gfx/skia/skia/include/effects/SkGaussianEdgeShader.h
rename : gfx/skia/skia/src/xml/SkXMLParser.h => gfx/skia/skia/include/xml/SkXMLParser.h
rename : gfx/skia/skia/include/private/SkMessageBus.h => gfx/skia/skia/src/core/SkMessageBus.h
rename : gfx/skia/skia/src/gpu/ops/GrAAConvexPathRenderer.h => gfx/skia/skia/src/gpu/batches/GrAAConvexPathRenderer.h
rename : gfx/skia/skia/src/gpu/ops/GrAAConvexTessellator.h => gfx/skia/skia/src/gpu/batches/GrAAConvexTessellator.h
rename : gfx/skia/skia/src/gpu/ops/GrAAHairLinePathRenderer.h => gfx/skia/skia/src/gpu/batches/GrAAHairLinePathRenderer.h
rename : gfx/skia/skia/src/gpu/ops/GrAALinearizingConvexPathRenderer.h => gfx/skia/skia/src/gpu/batches/GrAALinearizingConvexPathRenderer.h
rename : gfx/skia/skia/src/gpu/ops/GrPathStencilSettings.h => gfx/skia/skia/src/gpu/batches/GrPathStencilSettings.h
rename : gfx/skia/skia/src/gpu/ops/GrStencilAndCoverPathRenderer.h => gfx/skia/skia/src/gpu/batches/GrStencilAndCoverPathRenderer.h
rename : gfx/skia/skia/include/private/GrGLSL_impl.h => gfx/skia/skia/src/gpu/glsl/GrGLSL_impl.h
2017-05-10 10:01:18 -07:00
Lee Salzman
3bbca77ed4 Bug 1340627 - part 2 - update moz.build for Skia m59. r=jrmuizel
MozReview-Commit-ID: KdPvBio96Cw
2017-05-09 22:31:06 -04:00
Lee Salzman
b4227baa51 Bug 1340627 - part 1 - update Skia source to m59. r=mchang
--HG--
rename : gfx/skia/skia/src/gpu/glsl/GrGLSL_impl.h => gfx/skia/skia/include/private/GrGLSL_impl.h
rename : gfx/skia/skia/src/core/SkMessageBus.h => gfx/skia/skia/include/private/SkMessageBus.h
rename : gfx/skia/skia/include/core/SkBlitRow.h => gfx/skia/skia/src/core/SkBlitRow.h
rename : gfx/skia/skia/include/effects/SkGaussianEdgeShader.h => gfx/skia/skia/src/effects/SkGaussianEdgeShader.h
rename : gfx/skia/skia/src/gpu/batches/GrAAConvexPathRenderer.h => gfx/skia/skia/src/gpu/ops/GrAAConvexPathRenderer.h
rename : gfx/skia/skia/src/gpu/batches/GrAAConvexTessellator.h => gfx/skia/skia/src/gpu/ops/GrAAConvexTessellator.h
rename : gfx/skia/skia/src/gpu/batches/GrAAHairLinePathRenderer.h => gfx/skia/skia/src/gpu/ops/GrAAHairLinePathRenderer.h
rename : gfx/skia/skia/src/gpu/batches/GrAALinearizingConvexPathRenderer.h => gfx/skia/skia/src/gpu/ops/GrAALinearizingConvexPathRenderer.h
rename : gfx/skia/skia/src/gpu/batches/GrPathStencilSettings.h => gfx/skia/skia/src/gpu/ops/GrPathStencilSettings.h
rename : gfx/skia/skia/src/gpu/batches/GrStencilAndCoverPathRenderer.h => gfx/skia/skia/src/gpu/ops/GrStencilAndCoverPathRenderer.h
rename : gfx/skia/skia/include/xml/SkXMLParser.h => gfx/skia/skia/src/xml/SkXMLParser.h
2017-05-09 22:30:58 -04:00
Lee Salzman
ce86d53eec Bug 1358776 - fix building of SkBitmapProcState on ARM NEON. r=jrmuizel 2017-05-01 13:36:19 -04:00
Lee Salzman
a10fddc8eb Bug 1350783 - support bitmaps fonts in gfxFcPlatformFontList. r=jfkthame
MozReview-Commit-ID: 4VQkyhx4IJE
2017-03-29 13:47:46 -04:00
Lee Salzman
aa429c08b7 Bug 1347262 - fix Skia's round_asymmetric_to_int to bias all sides. r=jrmuizel
MozReview-Commit-ID: AMDi6YF0zn
2017-03-22 15:03:03 -04:00
Lee Salzman
3ea6ffc414 Bug 1347094 - fix SkiaGL canvas drawing of large images. r=mchang
MozReview-Commit-ID: Cw5EkXQj06t
2017-03-15 13:57:18 -04:00
Mike Hommey
318137c0da Bug 1342707 - Don't use Init_neon if runtime detection of neon is not enabled. r=lsalzman
--HG--
extra : rebase_source : 7f15d77c902a923d4dcc384c4fc10e877ce0bdf1
2017-02-26 08:12:18 +09:00
Lee Salzman
13b36b3f35 Bug 1339637 - fix overflow in SkClampRange::init(). r=jrmuizel
MozReview-Commit-ID: 7NtQP5QPsFk
2017-02-21 14:32:39 -05:00
Jonathan Kew
36f52391d9 Bug 1331683 - Don't attempt to use any Core Text and Core Graphics variation-font APIs on pre-Sierra systems. r=jrmuizel,lsalzman 2017-02-09 21:37:24 +00:00
Mason Chang
189cf8b6db Bug 1322897. Use only the G channel for grayscale AA Dwrite fonts and Skia. r=lsalzman 2017-02-01 15:47:33 -08:00
Lee Salzman
bf02f8d486 Bug 1334366 - verify that glyph position rect is non-empty in GrAtlasTextBlob::appendGlyph. r=mchang
MozReview-Commit-ID: JcPZSGfitmH
2017-01-27 16:14:18 -05:00
Lee Salzman
f899d6e6ff Bug 1325259 - fix A8_RowProc_Opaque to not use legacy broken lerp. r=vliu
MozReview-Commit-ID: FU7WxzQ3n7T
2017-01-18 10:15:09 -05:00
Lee Salzman
a25a4562c0 Bug 1322337 - load color bitmaps in SkFontHost_cairo when building with FreeType before 2.5.0. r=mchang
MozReview-Commit-ID: Ay7hJi7RK4T
2017-01-17 12:27:16 -05:00
Lee Salzman
9c04aa009c Bug 1330166 - ensure path bounds after rounding contain path edges when using SK_RASTERIZE_EVEN_ROUNDING. r=jrmuizel
MozReview-Commit-ID: Jb48BkbHEPs
2017-01-13 12:10:40 -05:00
Jonathan Kew
3d478b5e48 Bug 1324739 - patch 2 - Enable use of sfntly in Skia-PDF to subset fonts. r=lsalzman,glandium 2017-01-07 22:20:25 +00:00
Lee Salzman
b8debd5aca Bug 1325518 - make SkPath::conservativelyContainsRect consume degenerate segments. r=mchang
MozReview-Commit-ID: 78rE2oNc3IU
2017-01-11 12:40:46 -05:00
Jonathan Kew
c021e933d7 Bug 1321031 pt 3 - Preserve variations settings when creating a new CTFont in SkFontHost_mac. r=lsalzman 2017-01-06 16:35:12 +00:00
Ryan VanderMeulen
e897fba434 Backed out 6 changesets (bug 1321031) for bustage.
Backed out changeset e0be4f5390fb (bug 1321031)
Backed out changeset ba071046f8ab (bug 1321031)
Backed out changeset 7cb4242dc636 (bug 1321031)
Backed out changeset bc58e479eb58 (bug 1321031)
Backed out changeset c551913ae892 (bug 1321031)
Backed out changeset f4ae57d5358f (bug 1321031)

CLOSED TREE
2017-01-06 12:46:27 -05:00
Jonathan Kew
4c288caa59 Bug 1321031 pt 3 - Preserve variations settings when creating a new CTFont in SkFontHost_mac. r=lsalzman 2017-01-06 16:35:12 +00:00
Lee Salzman
9efc50d84e Bug 1318769 - make SkFontHost_cairo match cairo-ft's handling of FcPattern embeddedbitmap option. r=jfkthame
MozReview-Commit-ID: BSDuwZfKi1a
2017-01-01 09:25:15 -05:00
Nathan Froyd
0c4b96a65e Bug 1029245 - part 0 - tweak Skia's SkOnce.h header to work around issues with std::atomic::compare_exchange_strong; r=lsalzman
Building Skia inside of mozilla-central with GCC 4.9.4 causes problems:

[...]c++/4.9.4/bits/atomic_base.h:581:70: error: failure memory model cannot be stronger than success memory model for '__atomic_compare_exchange'

The error stack accompanying this message points at SkEventTracer::GetInstance:

SkEventTracer* SkEventTracer::GetInstance() {
    if (SkEventTracer* tracer = sk_atomic_load(&gUserTracer, sk_memory_order_acquire)) {
        return tracer;
    }
    static SkOnce once;
    static SkDefaultEventTracer* defaultTracer;
    once([] { defaultTracer = new SkDefaultEventTracer; });
    return defaultTracer;
}

The only place that compare_exchange_strong could be called here is from SkOnce::operator():

    template <typename Fn, typename... Args>
    void operator()(Fn&& fn, Args&&... args) {
        auto state = fState.load(std::memory_order_acquire);

        if (state == Done) {
            return;
        }

        // If it looks like no one has started calling fn(), try to claim that job.
        if (state == NotStarted && fState.compare_exchange_strong(state, Claimed,
                                                                  std::memory_order_relaxed)) {
            // Great!  We'll run fn() then notify the other threads by releasing Done into fState.
            fn(std::forward<Args>(args)...);
            return fState.store(Done, std::memory_order_release);
        }
        [...code elided...]

where |fState| is an atomic<uint8_t>.

The three-argument form of atomic<uint8_t>::compare_exchange_strong is defined as:

      _GLIBCXX_ALWAYS_INLINE bool
      compare_exchange_strong(__int_type& __i1, __int_type __i2,
			      memory_order __m = memory_order_seq_cst) noexcept
      {
	return compare_exchange_strong(__i1, __i2, __m,
				       __cmpexch_failure_order(__m));
      }

__cmpexch_failure_order relaxes the given memory_order:

  // Drop release ordering as per [atomics.types.operations.req]/21
  constexpr memory_order
  __cmpexch_failure_order2(memory_order __m) noexcept
  {
    return __m == memory_order_acq_rel ? memory_order_acquire
      : __m == memory_order_release ? memory_order_relaxed : __m;
  }

  constexpr memory_order
  __cmpexch_failure_order(memory_order __m) noexcept
  {
    return memory_order(__cmpexch_failure_order2(__m & __memory_order_mask)
      | (__m & __memory_order_modifier_mask));
  }

which then gets us to the four-argument version of compare_exchange_strong:

      _GLIBCXX_ALWAYS_INLINE bool
      compare_exchange_strong(__int_type& __i1, __int_type __i2,
			      memory_order __m1, memory_order __m2) noexcept
      {
        memory_order __b2 = __m2 & __memory_order_mask;
        memory_order __b1 = __m1 & __memory_order_mask;
	__glibcxx_assert(__b2 != memory_order_release);
	__glibcxx_assert(__b2 != memory_order_acq_rel);
	__glibcxx_assert(__b2 <= __b1);

	return __atomic_compare_exchange_n(&_M_i, &__i1, __i2, 0, __m1, __m2);
      }

Despite the constexpr annotation on __cmpexch_failure_order and friends,
which ought to imply that they get constant-folded, I think what is
happening is that GCC doesn't see |memory_order_relaxed| when it
examines __m2.  Instead, it seems some internal tree representation for
the call to __cmpexch_failure_order.  Since this is not an integer
constant, GCC treats __m2 as being equivalent to memory_order_seq_cst
(see gcc/builtins.c:get_memmodel).  And since memory_order_seq_cst is
stronger than memory_order_relaxed, we get the above error.

In any event, the easiest fix is to simply use the four-argument form of
compare_exchange_strong directly, explicitly specifying the failure
memory order.
2016-12-21 04:28:08 -05:00
Mason Chang
5902ea8a82 Bug 1323587 Part 1: Use correct gamma and contrast for dwrite fonts. r=lsalzman 2016-12-16 08:04:45 -08:00
Mason Chang
49715dce65 Bug 1321901 - Use IDWriteFontFace::GetRecommendedRenderingMode for font rendering mode in Skia. r=lsalzman 2016-12-15 08:33:43 -08:00
Lee Salzman
36bd8ec521 Bug 1320644 - don't use __stdcall with SkiaGLGlue. r=mchang
MozReview-Commit-ID: 5pljJkGSN8R
2016-11-30 15:12:40 -05:00
Lee Salzman
03322ca26d Bug 1315848 - Skia clamped gradient fix r=mchang
MozReview-Commit-ID: GUHZC7VRrlC

--HG--
extra : source : f51d3ab82dc60c54403cc6f64f4e0a5a87a5f5ff
2016-11-21 14:10:05 -05:00
Mason Chang
793727bf2c Bug 1315568 Use Force GDI information from SkTypeface for GDI rendering modes in skia. r=lsalzman 2016-11-29 08:03:33 -08:00
Mike Hommey
b4a7c9cf1c Bug 1319389 - Generically set SK_CPU_[BL]ENDIAN based on __BYTE_ORDER__ when available. r=lsalzman
--HG--
extra : rebase_source : 895f2166b36df699d542bd39e22bdddd0b423594
2016-11-22 20:09:02 +09:00
Lee Salzman
0e267ba5b2 Bug 1306628 - Handle large sizes in GrResourceProvider::createBuffer. r=mchang
MozReview-Commit-ID: 3ZGDmIum5OU

--HG--
extra : rebase_source : 01be35ac1a6b192c4a7e30e022b3d692ad82138d
2016-10-25 00:31:43 -04:00
Kevin Chen
ed05291591 Bug 1313135 - Make an early return if the clip rect can be ignored. r=mchang
--HG--
extra : rebase_source : 3e1b5c15398a2536528c5b8799d2272ee4d07c66
2016-11-21 18:55:00 -05:00
Jonathan Watt
7b894d6da6 Bug 1309272, part 1 - Add an --enable-skia-pdf configuration option. r=lsalzman
--HG--
extra : rebase_source : 2edd8282c26e8772caea3db0a3d9204a4838e8db
2016-10-26 19:23:07 +01:00
Jonathan Watt
f17619fa58 Bug 1313549 - Fix gfx/skia/generate_mozbuild.py to not generate gonk configurations. r=lsalzman
--HG--
extra : rebase_source : 97800251c8c099fd13e8ea41ce33eb5238f11b48
2016-10-25 13:59:42 +01:00
Matt Woodrow
4d0b10822d Bug 1308363 - Remove GONK specific code from gfx/. r=jrmuizel,sotaro 2016-10-27 13:17:10 +13:00
Lee Salzman
a7e455026a Bug 1299435 - part 4 - update Skia source to m55. r=mchang
MozReview-Commit-ID: 8TA6Lovdc28

--HG--
rename : gfx/skia/skia/src/animator/SkCondensedDebug.cpp => gfx/skia/skia/src/animator/SkCondensedDebug.inc
rename : gfx/skia/skia/src/animator/SkCondensedRelease.cpp => gfx/skia/skia/src/animator/SkCondensedRelease.inc
2016-10-24 22:41:34 -04:00
Lee Salzman
5baede4297 Bug 1299435 - part 1 - fix Skia moz.build for Skia m55 update. r=mchang
MozReview-Commit-ID: IFyQJUElomB
2016-10-24 22:40:40 -04:00
Wes Kocher
951194ee45 Backed out 6 changesets (bug 1299435) for windows reftest failures a=backout
Backed out changeset 0d587a1cab8f (bug 1299435)
Backed out changeset 3ab9d3cb13aa (bug 1299435)
Backed out changeset 1ed742f88f49 (bug 1299435)
Backed out changeset 51ad497c7ac2 (bug 1299435)
Backed out changeset 06ca6acef0a2 (bug 1299435)
Backed out changeset ebd4625e101a (bug 1299435)

--HG--
rename : gfx/skia/skia/src/animator/SkCondensedDebug.inc => gfx/skia/skia/src/animator/SkCondensedDebug.cpp
rename : gfx/skia/skia/src/animator/SkCondensedRelease.inc => gfx/skia/skia/src/animator/SkCondensedRelease.cpp
2016-10-24 16:45:46 -07:00
Lee Salzman
97e509997e Bug 1299435 - part 4 - update Skia source to m55. r=mchang
MozReview-Commit-ID: 8TA6Lovdc28

--HG--
rename : gfx/skia/skia/src/animator/SkCondensedDebug.cpp => gfx/skia/skia/src/animator/SkCondensedDebug.inc
rename : gfx/skia/skia/src/animator/SkCondensedRelease.cpp => gfx/skia/skia/src/animator/SkCondensedRelease.inc
2016-10-24 15:22:26 -04:00
Lee Salzman
d3d6a89296 Bug 1299435 - part 1 - fix Skia moz.build for Skia m55 update. r=mchang
MozReview-Commit-ID: IFyQJUElomB
2016-10-24 15:22:16 -04:00
Lee Salzman
23d29e987a Bug 1308316 - ensure Skia disables hinting if Fontconfig disables it. r=jrmuizel
MozReview-Commit-ID: KGQfXQ82qfJ
2016-10-21 22:26:20 -04:00
Mason Chang
b844183f9d Bug 1309917 - Stop defaulting to system wide default fonts if no IDWriteFont exists. r=jfkthame 2016-10-12 15:53:04 -07:00
Phil Ringnalda
fd7b7476c2 Merge m-i to m-c, a=merge
MozReview-Commit-ID: 93ZdJbK1x05
2016-10-06 19:58:18 -07:00
Daniel Holbert
1b1a0c7bad Bug 1308025: Disable -Wunreachable-code compile warning for skia (which includes some intentionally disabled code). r=gw280
MozReview-Commit-ID: FRLbZR4anWI

--HG--
extra : rebase_source : 6a5dbace62ac7d9687bac52670711014a3d744dc
2016-10-06 09:40:54 -07:00
Makoto Kato
ef0d953d9e Bug 1142056 - Add aarch64 configuration on Skia's moz.build. r=gw280
MozReview-Commit-ID: 60iAZjFg6W6

--HG--
extra : histedit_source : b3bb5a3e556393ba49f43dc4ab8bdaa9be40fb0c
2016-08-23 16:54:06 +09:00
Lee Salzman
fa14fbbbf5 Bug 1305151 - allow disabling Skia debug assertions via MOZ_SKIA_DISABLE_ASSERTS env-var. r=milan
MozReview-Commit-ID: DlBiKILV5Jm
2016-09-26 11:26:42 -04:00
Jonathan Watt
995ce8d997 Update gfx/skia/README_MOZILLA to point to SkMilestone.h for the milestone number. No bug. r=me DONTBUILD 2016-10-06 10:22:26 +01:00
Lee Salzman
1e0c767fd6 Bug 1304114 - fix invalid Sk4f store to SkColor in SkPixmap::erase. r=jrmuizel
MozReview-Commit-ID: 840x1nXgYns
2016-09-21 16:40:44 -04:00
Alexandre Lissy
18acbedbf0 Bug 1303522 - Include Skia libc++ workaround (https://codereview.chromium.org/2134693002) r=lsalzman
MozReview-Commit-ID: KYRuKaaH2Iu

--HG--
extra : rebase_source : a0738dcfe863bedd3361fb60e1d10f03cfcd8eb2
2016-09-17 14:25:55 +02:00
Makoto Kato
1ab5272de6 Bug 1298569 - Part 2. Replace -fpu=neon with CONFIG['NEON_FLAGS']. r=glandium
Use CONFIG['NEON_FLAGS'] on moz.build instead.

MozReview-Commit-ID: F6R532Hi5mg

--HG--
extra : rebase_source : 7243f316de3138c702f09b336f6d430e6c9c15b5
2016-09-14 18:34:19 +09:00
Lee Salzman
7cd3c97c52 Bug 1298833 - disable gamma correction in SkFontHost_cairo to match cairo-ft. r=mchang
MozReview-Commit-ID: Ee70HBUJxou
2016-08-29 16:36:09 -04:00
Mats Palmgren
13d9155235 Bug 1298112 - Remove always-true null-check to fix compile warning. r=gwright
warning: reference cannot be bound to dereferenced null pointer in
well-defined C++ code; pointer may be assumed to always convert to
true [-Wundefined-bool-conversion]

--HG--
extra : rebase_source : 2de925356078f191b953cc8f6eec546686940c63
2016-08-25 11:27:00 -04:00
Lee Salzman
37f7205455 Bug 1298691 - silence debug warning in SkScalerContext_CairoFT::generateFontMetrics. r=mchang
MozReview-Commit-ID: KB6ihxdFfbG
2016-08-29 11:13:25 -04:00
Lee Salzman
5a843ae70c Bug 1294337 - prefer default shader procs over special-cases in SkBitmapProcState. r=mchang
MozReview-Commit-ID: FlaGXKyYvDX
2016-08-23 13:37:44 -04:00
vincentliu
6b56ae4268 Bug 1286458 - Check SkScalarIsFinite for SkVector::DotProduct(). r=lsalzman
---
 gfx/skia/skia/src/core/SkGeometry.cpp | 3 +++
 1 file changed, 3 insertions(+)
2016-08-15 16:00:31 +08:00
Lee Salzman
1d7feaf99c Bug 1294455 - disable slow debug validation in Skia. r=mchang
MozReview-Commit-ID: 2vbnbuJARh3
2016-08-11 11:34:44 -04:00
Lee Salzman
a695c40d38 Bug 1294207 - detect if FreeType supports lcd filtering in SkFontHost_cairo. r=gw280
MozReview-Commit-ID: AZkcZG4PegJ
2016-08-10 18:23:34 -04:00
Lee Salzman
ca87957544 Bug 1200684 - revise Skia row blits to preserve color when blended against itself. r=mchang
MozReview-Commit-ID: Enz05s8vGuI
2016-08-05 19:50:49 -04:00
Ethan Lin
41b10604fb Bug 1290628 - Change the assertion rule to prevent assert with large number. r=lsalzman 2016-08-02 19:47:00 +02:00
Lee Salzman
1e8ad08b0b Bug 1287552 - only set FC_PIXEL_SIZE in pattern if not already supplied. r=me
MozReview-Commit-ID: 9IVzZA4oohZ
2016-07-25 15:00:06 -04:00