To avoid a clang-10 failure with `error: mixture of designated and non-designated initializers in the same initializer list is a C99 extension [-Werror,-Wc99-designator]`
Differential Revision: https://phabricator.services.mozilla.com/D61133
--HG--
extra : moz-landing-system : lando
Rule for Beta and Release on Android must be declared before general Android
one because first matching rule gets applied.
Differential Revision: https://phabricator.services.mozilla.com/D61099
--HG--
extra : moz-landing-system : lando
The following methods are removed:
1. notifyChannelClassifierProtectionDisabled
2. notifyCookieAllowed
3. notifyCookieBlocked
Depends on D56875
Differential Revision: https://phabricator.services.mozilla.com/D57630
--HG--
extra : moz-landing-system : lando
This patch does the followings:
1. Remove NotifyOnContentBlocking in WindowOuter and all the call sites.
This is because all the content blocking event handling is moved to the parent.
2. Replace UrlClassifierCommon::NotifyChannelBlocked with AntiTrackingCommon:::NotifyContentBlockingEventInParent.
This is because we don't need to pass the request to the child anymore, which was implemented in NotifyChannelBlocked previously.
3. Add NotifyContentBlockingEvent* utility functions to AntiTrackingCommon.cpp.
4. Update AntiTrackingCommon::NotifyBlockingDecision, when it is called in the parent,
do not send requests to the child, notify the parent directly
Depends on D56874
Differential Revision: https://phabricator.services.mozilla.com/D56875
--HG--
extra : moz-landing-system : lando
At this point, there is no consumer that uses ContentBlockingLog stored
in the child. This patch removes the following code:
1. Removing nsGlobalWindowOuter::NotifyContentBlockingEvent
2. Removing nsDocLoader::OnContentBlockingEvent
3. Removing contentBlockingEvent in nsISecureBrowserUI.idl
4. Removing mContentBlockingLog from Document.cpp and APIs related to it.
Differential Revision: https://phabricator.services.mozilla.com/D56874
--HG--
extra : moz-landing-system : lando
This patch uses the favicons as actually served by the sites. I tried to get 32x32 versions where possible, but a few are smaller and larger. There's also a mix of .ico and .png. I think the inconsistency is acceptable, and even desirable, seeing as these are the actual icons that would appear in the UrlbarView should they appear in the user's frecency results.
Differential Revision: https://phabricator.services.mozilla.com/D60421
--HG--
extra : moz-landing-system : lando
Automatic update from web-platform-tests
Replace some assert_throws('Something', stuff) calls with assert_throws_dom. (#21392)
This diff was generated by running:
find . -type f -print0 | xargs -0 perl -pi -e "BEGIN { \$/ = undef; } s/assert_throws\(([ \n]*'[A-Za-z_]*') *(, *.)/assert_throws_dom(\1\2/gs"
in bash (doesn't work in tcsh, due to the $ inside "").
This does affect indentation poorly in cases when the first arg was on the same
line as the assert_throws, there was a newline after the ',' after the first
arg, and the following args were lined up with the first arg. Fixing that,
especially when there are multiple lines after the first arg, is not trivial
with a regexp.
Co-authored-by: Boris Zbarsky <bzbarsky@mit.edu>
--
wpt-commits: d5103044974ae41deb6e099649d7520c374aa36b
wpt-pr: 21392
Automatic update from web-platform-tests
Replace some more "assert_throws(new FooError(), stuff)" calls with assert_throws_js or assert_throws_dom. (#21380)
This diff was generated by running:
find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*)new ([A-Za-z]*Error) *\(\) *(, *.)/assert_throws_js(\1\2\3/gs'
on the relevant files and then:
1) Manually fixing up "assert_throws_js(SyntaxError, ...)" to be 'assert_throws_dom("SyntaxError", ...).
2) Changing kv-storage/interface.https.html to get TypeError from the same global as the object it's testing.
Note: these are the files which had changes to them reverted as part
of landing <https://github.com/web-platform-tests/wpt/pull/21354>.
The two manual fixups there address the issues that led to the revert.
--
wpt-commits: 9940584f86638e9e558928d0a5fc7266f1848cec
wpt-pr: 21380
Automatic update from web-platform-tests
Replace some assert_throws("Something", stuff) calls with assert_throws_dom. (#21377)
This diff was generated by running:
find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*"[A-Za-z_]*") *(, *.)/assert_throws_dom(\1\2/gs'
followed by a fix to
xhr/resources/send-after-setting-document-domain-window-helper.js to make
xhr/send-after-setting-document-domain.htm pass.
This does affect indentation poorly in cases when the first arg was on the same
line as the assert_throws, there was a newline after the ',' after the first
arg, and the following args were lined up with the first arg. Fixing that,
especially when there are multiple lines after the first arg, is not trivial
with a regexp.
Co-authored-by: Boris Zbarsky <bzbarsky@mit.edu>
--
wpt-commits: 3696f2233a37437896505b7187968aa605be9255
wpt-pr: 21377
Automatic update from web-platform-tests
Replace some "assert_throws({'name': 'domerror'}, stuff)" with assert_throws_dom. (#21390)
This diff was generated by running:
find . -type f -print0 | xargs -0 perl -pi -e "BEGIN { \$/ = undef; } s/assert_throws\(([ \n]*)\{ *[\"']?name[\"']? *: *(['\"](?:InvalidStateError|SyntaxError|NotSupportedError|DataError|SecurityError)[\"']) *\} *(, *.)/assert_throws_dom(\1\2\3/gs"
in bash (doesn't work in tcsh, due to the $ inside "").
Co-authored-by: Boris Zbarsky <bzbarsky@mit.edu>
--
wpt-commits: a20f9f34f30dea66683c656b9a6561a8d4b474a0
wpt-pr: 21390
Automatic update from web-platform-tests
Add nsatragno to webauthn reviewers list
--
wpt-commits: bf9b18d3a7de81ce0308af1c74c47d811083ca29
wpt-pr: 20619
Automatic update from web-platform-tests
Remove assert_throws use in html tests. (#21385)
--
wpt-commits: 93ee31309acd4081e5da8f4f020664f9cecb90f3
wpt-pr: 21385
Automatic update from web-platform-tests
Remove assert_throws use in custom elements tests (#21382)
--
wpt-commits: a2175cc3a07e1de1e9d09df99a09ab60e954d9dc
wpt-pr: 21382
Automatic update from web-platform-tests
Replace some "assert_throws(FooError(), stuff)" calls with assert_throws_js. (#21378)
This diff was generated by running:
find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*)([A-Za-z]*Error) *\(\) *(, *.)/assert_throws_js(\1\2\3/gs'
and then:
1) Manually editing dom/nodes/Element-matches.js to get the TypeError
constructor from the element's global.
2) Manually editing dom/nodes/ParentNode-querySelector-All.js to get the
TypeError constructor from root's global, whether "root" is a Document or some
other kind of node.
Co-authored-by: Boris Zbarsky <bzbarsky@mit.edu>
--
wpt-commits: f06523527a0735d23879f4e687d6efc095f780b7
wpt-pr: 21378
Automatic update from web-platform-tests
Use assert_precondition in ElementTiming/LargestContentfulPaint
This CL replaces assert_unreached for assert_precondition for the API
existence checks in the ElementTiming and LargestContentfulPaint WPTs.
Change-Id: Icd2ff3e045835cf4c46a370a384455143a717308
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013863
Reviewed-by: Tom McKee <tommckee@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734494}
--
wpt-commits: bd2c0495a860571b7467989e89dd51ebad4f9562
wpt-pr: 21326
Automatic update from web-platform-tests
Add tests of the recalculation of 'ch' in pseudo elements
Length unit 'ch' should be recalculated after loading a web font. This
patch is a followup of crrev.com/c/1972815 to ensure that it's also
recalculated in pseudo elements.
Bug: 441925
Change-Id: Ie62dba854aa9d1beb6b9a734f31760abf1acd040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016198
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734495}
--
wpt-commits: 025c749a21b0fd0c9bd758cc33c7ff3e122073de
wpt-pr: 21362
Automatic update from web-platform-tests
Replace some "assert_throws({'name': 'jserror'}, stuff)" with assert_throws_js. (#21379)
This diff was generated by running:
find . -type f -print0 | xargs -0 perl -pi -e "BEGIN { \$/ = undef; } s/assert_throws\(([ \n]*)\{ *[\"']?name[\"']? *: *['\"](TypeError|Error)[\"'] *\} *(, *.)/assert_throws_js(\1\2\3/gs"
in bash (doesn't work in tcsh, due to the $ inside "") and then manually
changing service-workers/service-worker/ServiceWorkerGlobalScope/resources/extendable-message-event-constructor-worker.js
to use assert_throws_exactly in a few places where we want to verify that
specific exception values are propagated out.
Co-authored-by: Boris Zbarsky <bzbarsky@mit.edu>
--
wpt-commits: b0daaa6b86c3dc2f9c16aa362136655c0db7308b
wpt-pr: 21379
Automatic update from web-platform-tests
SharedWorker: Add meta.url WPT for SharedWorker with type 'module' (#21333)
This CL adds a web platform test for checking the behavior of
|import.meta.url| in SharedWorker when the script type is set to module.
Bug: 824646
Change-Id: Ifaa34e238fe0a432137c5e8213e81610249b7e79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014355
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734387}
--
wpt-commits: 380eb46722a1945770c4df9bd00ea0ea77868d0b
wpt-pr: 21333
Automatic update from web-platform-tests
Replace some "assert_throws(new FooError(), stuff)" calls with assert_throws_js. (#21354)
This diff was generated by running:
find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*)new ([A-Za-z]*Error) *\(\) *(, *.)/assert_throws_js(\1\2\3/gs'
and then:
1) Manually adjusting fullscreen/rendering/fullscreen-pseudo-class-support.html
to test for the right sort of exceptions ("SyntaxError" DOMException, not a JS
SyntaxError).
2) Manually adjusting performance-timeline/po-observe-type.any.js to test for
the right sort of exceptions ("SyntaxError" DOMException, not a JS
SyntaxError).
3) Manually adjusting performance-timeline/po-observe.any.js to test for
the right sort of exceptions ("SyntaxError" DOMException, not a JS
SyntaxError).
4) Manually adjusting user-timing/mark_exceptions.html to test for the right
sort of exceptions ("SyntaxError" DOMException, not a JS SyntaxError).
5) Manually adjusting user-timing/measure_syntax_err.any.js to test for the right
sort of exceptions ("SyntaxError" DOMException, not a JS SyntaxError).
6) Manually adjusting domxpath/lexical-structure.html to test for a
"SyntaxError" DOMException, since that's what all browsers throw and there is no
clear spec for this.
7) Manually adjusting workers/constructors/Worker/Worker-constructor.html to
test for the right sort of exceptions ("SyntaxError" DOMException, not a JS
SyntaxError).
8) Backing out the changes to resources/idlharness.js because some tests pass
objects from a different window to it, and we end up with the wrong TypeError
constructor in those cases.
This does affect indentation poorly in cases when the first arg was on the same
line as the assert_throws, there was a newline after the ',' after the first
arg, and the following args were lined up with the first arg. Fixing that,
especially when there are multiple lines after the first arg, is not trivial
with a regexp.
Co-authored-by: Boris Zbarsky <bzbarsky@mit.edu>
Co-authored-by: Stephen McGruer <smcgruer@chromium.org>
--
wpt-commits: 2c5c3c4c27d27a419c1fdba3e9879c2d22037074
wpt-pr: 21354
Automatic update from web-platform-tests
Change COEP tests relying on onload events for network errors to use a timeout instead (#21344)
--
wpt-commits: 2f39e90ef46a0aeaf2ac7e769f0478bb5882dfed
wpt-pr: 21344
Automatic update from web-platform-tests
[FlexNG] Use previous constraint space for layout roots.
Devtools had an issue where elements were sized at 0px height.
This was caused by the relayout boundary logic not working correctly.
In Devtools these elements had layout and size containment triggering
ObjectIsRelayoutBoundary() to return true.
The call to NGConstraintSpace::CreateFromLayoutObject for this flex-item
was incorrect as it wasn't using the stretched size (as we don't
set HasOverrideLogicalWidth(), etc).
This refactors the various callers of
NGConstraintSpace::CreateFromLayoutObject and create a new method
UpdateInFlowBlockLayout which contains the previously (duplicated)
logic.
This new method will try and use the previous constraint space (if
it is a layout root), instead of creating it.
Bug: 845235
Change-Id: I52ddb9d58ae010305b980657bb434a30d5b7fbbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010983
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734420}
--
wpt-commits: fb09ccb613400a3a0327967063cb1117cea96468
wpt-pr: 21308
Automatic update from web-platform-tests
Add more reviewers to tools/META.yml (#21346)
--
wpt-commits: 3eef88a45f57eac659b9f4ea8c1b56031cae8842
wpt-pr: 21346
Automatic update from web-platform-tests
SharedWorker: Fix the wrong WPT undefined-arguments.html (#21365)
The worker's name must be |''| in this test.
According to the spec, the default value of WorkerOptions (which is the
second argument of SharedWorker) is set as follows:
dictionary WorkerOptions {
WorkerType type = "classic";
RequestCredentials credentials = "same-origin";
DOMString name = "";
};
spec:https://html.spec.whatwg.org/multipage/workers.html#workeroptions
Here, name property is set to an empty string.
Therefore, the worker's name must be an empty string when the second
argument is |undefined|.
Bug:907749
Change-Id: I5bc9c5afcf76beae1e3924661b2ea65fad5efe1d
--
wpt-commits: 49cf4238f4f963392a17d5b9a81e347a1bfd3aa9
wpt-pr: 21365
