Commit Graph

5692 Commits

Author SHA1 Message Date
David Major
8c86c42e0f Bug 1619461 - Enable the new pass manager in clang builds. r=rstewart,glandium
LLVM's new pass manager has been in the works for several years and has better optimization (sometimes much better) than the legacy pass manager. I think it's in good enough shape for us to try at this point.

While we only really need the new pass manager for shippable builds, as a general principle I'd like to use it as much as possible, to help catch bugs for upstream. Therefore this patch enables the new pass manager by default for all clang builds, with the only exceptions being compilers older than version 9, and xcode clang where we can't trust the version number. There isn't a specific problem with older versions; I just don't want to sign up for the support cost of debugging people's local builds that may be fixed already.

I don't expect it to be necessary, but just in case, an opt-out is available via `ac_add_options --disable-new-pass-manager`.

Differential Revision: https://phabricator.services.mozilla.com/D66109

--HG--
extra : rebase_source : 91df800146700e4958b8e645ebbd3cf7b11a2f1e
extra : source : 2f5aba2e2c099a1df26e3444ccec2be0b4ff4613
2020-03-11 02:08:37 +00:00
Andreea Pavel
bfc7043d13 Backed out changeset 2f5aba2e2c09 (bug 1619461) for build bustages at testBug1117235.js on a CLOSED TREE 2020-03-11 16:42:42 +02:00
David Major
21170f3a10 Bug 1619461 - Enable the new pass manager in clang builds. r=rstewart,glandium
LLVM's new pass manager has been in the works for several years and has better optimization (sometimes much better) than the legacy pass manager. I think it's in good enough shape for us to try at this point.

While we only really need the new pass manager for shippable builds, as a general principle I'd like to use it as much as possible, to help catch bugs for upstream. Therefore this patch enables the new pass manager by default for all clang builds, with the only exceptions being compilers older than version 9, and xcode clang where we can't trust the version number. There isn't a specific problem with older versions; I just don't want to sign up for the support cost of debugging people's local builds that may be fixed already.

I don't expect it to be necessary, but just in case, an opt-out is available via `ac_add_options --disable-new-pass-manager`.

Differential Revision: https://phabricator.services.mozilla.com/D66109

--HG--
extra : moz-landing-system : lando
2020-03-11 02:08:37 +00:00
shindli
8a8793039d Backed out 12 changesets (bug 1612941) for webrender linting bustage CLOSED TREE
Backed out changeset bbb8ec38f354 (bug 1612941)
Backed out changeset cd798d2a0433 (bug 1612941)
Backed out changeset c02c4c5bf7f7 (bug 1612941)
Backed out changeset 2e0c9b9bd507 (bug 1612941)
Backed out changeset ec0fffd12dec (bug 1612941)
Backed out changeset 2d6f65fe6ec0 (bug 1612941)
Backed out changeset dd1a92041bb4 (bug 1612941)
Backed out changeset 3cae17a5ec80 (bug 1612941)
Backed out changeset edfca5676513 (bug 1612941)
Backed out changeset f94d5c7cee41 (bug 1612941)
Backed out changeset 67bba000daba (bug 1612941)
Backed out changeset 60151122db4d (bug 1612941)
2020-03-11 14:28:55 +02:00
Lee Salzman
d2ae8dbd06 Bug 1612941 - vendor SWGL's rust dependencies. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D65617

--HG--
extra : moz-landing-system : lando
2020-03-11 12:16:26 +00:00
shindli
0830b5e7f8 Backed out 12 changesets (bug 1612941) for causing bustages CLOSED TREE
Backed out changeset 29f9f745ff65 (bug 1612941)
Backed out changeset d92e03315f8d (bug 1612941)
Backed out changeset 9b1360daa75a (bug 1612941)
Backed out changeset ad7f43d72b08 (bug 1612941)
Backed out changeset 30b28118362a (bug 1612941)
Backed out changeset 76f80dce8875 (bug 1612941)
Backed out changeset 375896f494ae (bug 1612941)
Backed out changeset bd8ba66dc2ac (bug 1612941)
Backed out changeset 54ec5a6e8e45 (bug 1612941)
Backed out changeset 419105739e53 (bug 1612941)
Backed out changeset c198dedeaa1b (bug 1612941)
Backed out changeset 87ddcdfc5fcf (bug 1612941)
2020-03-11 14:01:26 +02:00
Lee Salzman
9bf1ae5b21 Bug 1612941 - vendor SWGL's rust dependencies. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D65617

--HG--
extra : moz-landing-system : lando
2020-03-11 11:13:40 +00:00
Mike Shal
2626cb441d Bug 1620744 - Convert jar_maker action to py3; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65857

--HG--
extra : moz-landing-system : lando
2020-03-10 20:19:47 +00:00
Mike Shal
c2e3a05aa3 Bug 1620744 - Convert dumpsymbols.py to py3; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65856

--HG--
extra : moz-landing-system : lando
2020-03-10 20:19:44 +00:00
Mike Shal
b5ef4a8d81 Bug 1620744 - Convert check_binary.py to py3; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65855

--HG--
extra : moz-landing-system : lando
2020-03-10 20:19:42 +00:00
Mike Shal
091526302b Bug 1620744 - Convert generate_mapfile.py to py3; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65854

--HG--
extra : moz-landing-system : lando
2020-03-10 20:19:34 +00:00
Mike Shal
419f244300 Bug 1620744 - Convert generated_sources.py to py3; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65853

--HG--
extra : moz-landing-system : lando
2020-03-10 20:19:32 +00:00
Mike Shal
2723002de4 Bug 1620744 - Convert fat_aar.py to py3; r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D65849

--HG--
extra : moz-landing-system : lando
2020-03-10 20:19:22 +00:00
Mike Shal
81d78a3ca0 Bug 1620744 - Convert generate_symbols_file.py to py3; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65848

--HG--
extra : moz-landing-system : lando
2020-03-10 20:19:17 +00:00
Mike Shal
2b42b650a2 Bug 1620744 - Convert process_define_files.py to py3; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65847

--HG--
extra : moz-landing-system : lando
2020-03-10 20:19:15 +00:00
Mike Shal
4017368b2f Bug 1620744 - Use py3_action for cases that already support it; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65846

--HG--
extra : moz-landing-system : lando
2020-03-10 20:19:13 +00:00
Ben Hearsum
c0a501bb63 No bug: Update vendored copy of tooltool client r=rail
Differential Revision: https://phabricator.services.mozilla.com/D66287

--HG--
extra : moz-landing-system : lando
2020-03-10 19:04:11 +00:00
Daniel Varga
09acd57d19 Backed out 13 changesets (bug 1620744) for causing diffoscope failures firefox/browser/chrome/browser/content/browser/built_in_addons.json
CLOSED TREE

Backed out changeset 6beda54bcb9b (bug 1620744)
Backed out changeset a1e97f0b91ef (bug 1620744)
Backed out changeset b8faa0184d4f (bug 1620744)
Backed out changeset 3bc8fda68107 (bug 1620744)
Backed out changeset 8e95b21b2ae3 (bug 1620744)
Backed out changeset 1de09de1a802 (bug 1620744)
Backed out changeset 622a2f7414fa (bug 1620744)
Backed out changeset 3372c9ab721c (bug 1620744)
Backed out changeset 0997313a9f99 (bug 1620744)
Backed out changeset 2fa34749bbfa (bug 1620744)
Backed out changeset 6d597d2eb792 (bug 1620744)
Backed out changeset 78e78f7c7b26 (bug 1620744)
Backed out changeset 6e4d85b19f88 (bug 1620744)
2020-03-10 21:13:18 +02:00
Adam Gashlin
068828be61 Bug 1621070 - Skip BaseRustProgram init when COMPILE_ENVIRONMENT is missing. r=froydnj
Based on the bug 1336153 patch which protected Rust libraries.

Differential Revision: https://phabricator.services.mozilla.com/D66155

--HG--
extra : moz-landing-system : lando
2020-03-10 17:51:47 +00:00
Mike Shal
45ba77d509 Bug 1620744 - Convert jar_maker action to py3; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65857

--HG--
extra : moz-landing-system : lando
2020-03-09 22:02:48 +00:00
Mike Shal
a6b38f31ae Bug 1620744 - Convert dumpsymbols.py to py3; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65856

--HG--
extra : moz-landing-system : lando
2020-03-10 17:38:05 +00:00
Mike Shal
7e2ee7cfd9 Bug 1620744 - Convert check_binary.py to py3; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65855

--HG--
extra : moz-landing-system : lando
2020-03-09 22:02:43 +00:00
Mike Shal
ed1692cfb3 Bug 1620744 - Convert generate_mapfile.py to py3; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65854

--HG--
extra : moz-landing-system : lando
2020-03-09 22:02:41 +00:00
Mike Shal
d58365f0ce Bug 1620744 - Convert generated_sources.py to py3; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65853

--HG--
extra : moz-landing-system : lando
2020-03-09 22:02:39 +00:00
Mike Shal
fd97dcb49c Bug 1620744 - Convert fat_aar.py to py3; r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D65849

--HG--
extra : moz-landing-system : lando
2020-03-09 22:02:29 +00:00
Mike Shal
a55b51c1bf Bug 1620744 - Convert generate_symbols_file.py to py3; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65848

--HG--
extra : moz-landing-system : lando
2020-03-09 22:02:26 +00:00
Mike Shal
3c283ac575 Bug 1620744 - Convert process_define_files.py to py3; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65847

--HG--
extra : moz-landing-system : lando
2020-03-09 22:02:24 +00:00
Mike Shal
a1ea58eb94 Bug 1620744 - Use py3_action for cases that already support it; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65846

--HG--
extra : moz-landing-system : lando
2020-03-09 22:02:22 +00:00
Ricky Stewart
5a39034089 Bug 1619460 - ensure subsequent runs of ./mach build-backend under Python 3 produce consistent results r=dmajor
Dictionary iteration under Python 3 is in an inherently unpredictable order, and while we try to keep DEFINES ordered through the use of OrderedDicts, if at any point we populate DEFINES directly or indirectly while iterating through the contents of a non-ordered dictionary, the order of the DEFINES (and therefore the contents of the output Makefile) will be nondeterministic as well. This patch makes a number of changes to ensure that we only ever populate DEFINES in a deterministic fashion. (Note that in Python 3.7 and later, the built-in dict class actually has deterministic ordering, so these changes are technically only necessary until our minimum Python version becomes 3.7.)

Differential Revision: https://phabricator.services.mozilla.com/D66089

--HG--
extra : moz-landing-system : lando
2020-03-09 22:34:19 +00:00
nemesisBR
257e8f570e Bug 1619956 : Added link to documentation without adding a new command. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D65934

--HG--
extra : moz-landing-system : lando
2020-03-10 10:26:18 +00:00
Andrew Halberstadt
829a13e276 Bug 1601140 - Support line comments in third_party/python/requirements.in, r=rstewart
Differential Revision: https://phabricator.services.mozilla.com/D64756

--HG--
extra : moz-landing-system : lando
2020-03-09 13:23:31 +00:00
Makoto Kato
070a000dd4 Bug 1620511 - Make ensure_mobile_android_packages Python3 compatible. r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D65683

--HG--
extra : moz-landing-system : lando
2020-03-06 17:30:27 +00:00
Mike Hommey
7ef39a5fd8 Bug 1617043 - Track the time spent in fetch-content and mach artifact toolchain. r=rstewart
Note: while we can use time.monotonic in fetch-content, we can't in
mach artifact toolchain yet because it's still python2.

Differential Revision: https://phabricator.services.mozilla.com/D65690

--HG--
extra : moz-landing-system : lando
2020-03-07 10:46:14 +00:00
Ricky Stewart
bd01350f97 Bug 1619788 - Ensure files generated by ./mach configure don't have CRLF line endings, even under Python 3 r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D65354

--HG--
extra : moz-landing-system : lando
2020-03-06 02:19:21 +00:00
Mike Hommey
5da778f6e4 Bug 1617147 - Stop setting check_prog result to : for missing programs. r=nalexander,rstewart
This was cargo culted from the autoconf equivalent, and while it makes a
command that does "$(PROG) foo" work because it becomes ": foo", that
may or may not actually be a desirable outcome.

OTOH, we do have some places where there are some "ifdef PROG" that are
just plain wrong when PROG is always actually set.

One place I do know that does check if the value is not ":" is for
OBJCOPY, which is still set from autoconf.

All in all, looking at all the check_prog(allow_missing=True) we have in
python configure, it doesn't seem anything is checking for ":", and that
doesn't seem like the right status quo.

Differential Revision: https://phabricator.services.mozilla.com/D65276

--HG--
extra : moz-landing-system : lando
2020-03-05 21:52:10 +00:00
Simon Fraser
c15cc3a5c0 Bug 1619930 Update python-safety dependencies r=mtabara
Differential Revision: https://phabricator.services.mozilla.com/D65328

--HG--
extra : moz-landing-system : lando
2020-03-05 13:48:16 +00:00
Nicholas Nethercote
c22c891c55 Bug 1604095 - Add fix_stacks.py, which uses fix-stacks, and use it in DMD. r=gsvelto
On Linux and Mac, this makes `dmd.py` *much* faster when it is first run on a
DMD data file.

On Windows, this makes DMD actually usable locally. Previously the stacks
weren't fixed and so were rubbish.

Differential Revision: https://phabricator.services.mozilla.com/D57271

--HG--
extra : moz-landing-system : lando
2020-03-05 00:24:23 +00:00
Nicholas Nethercote
62a87c4bd1 Bug 1604095 - Install fix-stacks in mach bootstrap. r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D64529

--HG--
extra : moz-landing-system : lando
2020-03-05 00:23:40 +00:00
Geoff Brown
dc64cf08e6 Bug 1619586 - Major version bump for mozlog and mozcrash; r=bc,marionette-reviewers,perftest-reviewers,jgraham,whimboo
Major version number bump for both mozlog and mozcrash + requirements update.
This is very much like the previous mozlog major bump - see bug 1591384.
This patch does not update testing/web-platform/tests/tools/wptrunner/requirements.txt;
I expect that will be automatically updated by the pyup.io bot once mozlog is re-released.

Differential Revision: https://phabricator.services.mozilla.com/D65135

--HG--
extra : moz-landing-system : lando
2020-03-04 00:32:38 +00:00
Divya Rani
427ae6c5f6 Bug 1619280 - Port warnings-summary [mach] to Python 3.r=championshuttler,firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D64951

--HG--
extra : moz-landing-system : lando
2020-03-03 19:18:52 +00:00
Ben Hearsum
81dd219ee4 No bug: Update tooltool client to latest upstream version. r=rail
Differential Revision: https://phabricator.services.mozilla.com/D65139

--HG--
extra : moz-landing-system : lando
2020-03-03 16:42:10 +00:00
Ricky Stewart
f99df6b4fe Bug 1619408 - Make remaining tweaks to build system code to allow running ./mach build with Python 3 r=firefox-build-system-reviewers,mshal
Differential Revision: https://phabricator.services.mozilla.com/D65017

--HG--
extra : moz-landing-system : lando
2020-03-02 21:33:48 +00:00
Mark Banner
58ef4b8178 Bug 1612077 - Use parallel directory processing for Lint when no path is specified or a support file is touched. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D61219

--HG--
extra : moz-landing-system : lando
2020-03-02 21:51:58 +00:00
Narcis Beleuzu
0543d20741 Backed out changeset 8b2c3a0fa051 (bug 1612077) lint failures on test_support_files.py. CLOSED TREE 2020-03-02 19:38:08 +02:00
Mark Banner
02ccafc74c Bug 1612077 - Use parallel directory processing for Lint when no path is specified or a support file is touched. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D61219

--HG--
extra : moz-landing-system : lando
2020-03-02 15:02:23 +00:00
Tarek Ziadé
71814e3255 Bug 1618390 - Use mozlog in condprof r=whimboo
This patch refactors the condprof logging so it uses mozlog

Differential Revision: https://phabricator.services.mozilla.com/D64720

--HG--
extra : moz-landing-system : lando
2020-02-28 16:27:40 +00:00
Mike Hommey
6fdc4fe0c3 Bug 1618775 - Uniformize preprocessor-inserted paths between platforms. r=froydnj
The preprocessor adds line markers in preprocessed files with line
numbers and file they came from. Bug 1528892 changed those markers
to be independent of the topobjdir and topsrcdir, by replacing them
with $OBJDIR and $SRCDIR, respectively.

This goes further, making these paths always use forward-slash, and
never backwards-slash, making the preprocessed files identical whether
the build occurred on Windows or Unix. (well, except when building
for different targets for target-specific sections)

Differential Revision: https://phabricator.services.mozilla.com/D64714

--HG--
extra : moz-landing-system : lando
2020-02-28 12:31:49 +00:00
Mike Shal
5701a85794 Bug 1611006 - Convert python/mozbuild/mozbuild/test/action to python3; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D60769

--HG--
extra : moz-landing-system : lando
2020-02-28 20:56:31 +00:00
Mihai Alexandru Michis
45d339f5d6 Backed out changeset 9b60a11f4550 (bug 1612077) for causing failures in mozlint/test/test_roller.py 2020-02-28 16:18:12 +02:00
Mark Banner
4948a30dbf Bug 1612077 - Use parallel directory processing for Lint when no path is specified or a support file is touched. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D61219

--HG--
extra : moz-landing-system : lando
2020-01-31 12:45:12 +00:00