Commit Graph

15483 Commits

Author SHA1 Message Date
Jason Laster
4db5929b5d Bug 1544436 - The secondary pane should not open when paused.
Differential Revision: https://phabricator.services.mozilla.com/D27552

--HG--
extra : moz-landing-system : lando
2019-04-15 18:59:43 +00:00
Jason Laster
d07bf74946 Bug 1544474 - Remove unnecessary projectRoot field.
Differential Revision: https://phabricator.services.mozilla.com/D27548

--HG--
extra : moz-landing-system : lando
2019-04-15 18:37:50 +00:00
Cosmin Sabou
c433060f20 Backed out changeset f057b78337e7 (bug 1544436) for debugger failures on addToTree.js CLOSED TREE 2019-04-15 20:46:25 +03:00
Jason Laster
4a5f55d216 Bug 1544436 - The secondary pane should not open when paused. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D27518

--HG--
extra : moz-landing-system : lando
2019-04-15 16:47:39 +00:00
Michael Ratcliffe
04b89bc9c8 Bug 1544483 - Add missing .../context.js file to .../browser.ini r=loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D27533

--HG--
extra : moz-landing-system : lando
2019-04-15 16:50:44 +00:00
Julian Descottes
7435518894 Bug 1544040 - Skip aboutdebugging performance test on linux asan/debug;r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D27333

--HG--
extra : moz-landing-system : lando
2019-04-15 11:51:40 +00:00
Patrick Brosset
818e92e5a8 Bug 1541938 - Apply the hover effect to all font names; r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D26878

--HG--
extra : moz-landing-system : lando
2019-04-12 15:29:30 +00:00
Julian Descottes
28d488a209 Bug 1543907 - showToolbox should wait for tool to be loaded;r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D27241

--HG--
extra : moz-landing-system : lando
2019-04-13 13:55:45 +00:00
Logan Smyth
46fb1ab6f9 Bug 1543754 - Part 7: Allow each source actor to have a unique index. r=jlast
Right now we can end up with Source objects with multiple source actors that
share the same ID, since nothing tries to make them unique. This patch
makes sources created in Jest tests each get an incrementing actor ID.

Differential Revision: https://phabricator.services.mozilla.com/D27134

--HG--
extra : moz-landing-system : lando
2019-04-12 19:06:23 +00:00
Logan Smyth
94937c6fcc Bug 1543754 - Part 6: Remove newSources action and rely entirely on newGenerated/newOriginalSources. r=jlast
With the previous commits done, the 'newSources' actions expose implementation details that we want
to keep private within the file. Nothing outside of these actions should be instantiating Source
objects anymore.

Differential Revision: https://phabricator.services.mozilla.com/D27133

--HG--
extra : moz-landing-system : lando
2019-04-12 18:56:07 +00:00
Logan Smyth
595ea2ea81 Bug 1543754 - Part 5: Move generated source creation into the newSources after debouncing. r=jlast
We move source creation into the action itself so that the action can inspect the current
state of the store in order to decide how to create the source, where previously we were
forced to insert the source and have the reducer itself handle cases where the source
already existed.

Differential Revision: https://phabricator.services.mozilla.com/D27132

--HG--
extra : moz-landing-system : lando
2019-04-12 18:55:41 +00:00
Logan Smyth
2bb523c30c Bug 1543754 - Part 4: Move creation of original source actors into a separate phase after debouncing. r=jlast
We want the source actions to be responsible for creating the Source objects rather than creating
them ahead of time. This means that the action itself can make decisions about how to handle new
sources appearing, where right now that decision is made too early by the logic queueing the items.

Differential Revision: https://phabricator.services.mozilla.com/D27131

--HG--
extra : moz-landing-system : lando
2019-04-12 18:55:16 +00:00
Logan Smyth
ff8c4164ce Bug 1543754 - Part 3: Distinguish original and generated source data in the source queue. r=jlast
We want the two types of queue items to have different datatypes, so we clearly distinguish the
two types of sources that are queued.

Differential Revision: https://phabricator.services.mozilla.com/D27130

--HG--
extra : moz-landing-system : lando
2019-04-12 19:06:15 +00:00
Logan Smyth
1e67481a7c Bug 1543754 - Part 2: Split the SET_WORKERS action into INSERT/REMOVE actions. r=jlast
Reducers should be able to use actions to tell what is happening to the workers, and
by combining them into one action they are unable to know what is being added and
what is being removed. Splitting them up means reducers have more information.

Differential Revision: https://phabricator.services.mozilla.com/D27128

--HG--
extra : moz-landing-system : lando
2019-04-12 19:06:19 +00:00
Logan Smyth
d074c1744a Bug 1543754 - Part 1: Update SourcePayload type to match response. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D27127

--HG--
extra : moz-landing-system : lando
2019-04-12 18:53:57 +00:00
Logan Smyth
d8d6b2e0b1 Bug 1544073 - Upgrade eslint-plugin-import to version 2.16.0. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D27356

--HG--
extra : moz-landing-system : lando
2019-04-12 18:35:29 +00:00
Jason Laster
2149f0c9b6 Bug 1543731 - When map scopes is disabled we should not compute mappings. r=loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D27154

--HG--
extra : moz-landing-system : lando
2019-04-12 17:52:26 +00:00
Brian Hackett
ac964a170e Bug 1542560 - Watch for missing symbols, r=loganfsmyth.
Differential Revision: https://phabricator.services.mozilla.com/D27111

--HG--
extra : moz-landing-system : lando
2019-04-12 17:33:58 +00:00
Brian Hackett
7615275cf6 Bug 1542502 - Wait for breakpoint to appear after pretty printing, r=loganfsmyth.
Differential Revision: https://phabricator.services.mozilla.com/D27113

--HG--
extra : moz-landing-system : lando
2019-04-12 17:34:02 +00:00
Jason Laster
5e3effc808 Bug 1543821 - Mochitests should use dbg helper (eslint fix).
Differential Revision: https://phabricator.services.mozilla.com/D27323

--HG--
extra : moz-landing-system : lando
2019-04-12 15:43:28 +00:00
Jason Laster
37f00546fc Bug 1543821 - Mochitests should use dbg helper. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D27168

--HG--
extra : moz-landing-system : lando
2019-04-12 15:00:02 +00:00
Jan Odvarko
6f7945508b Bug 1540741 - Warning: Each child in an array or iterator should have a unique "key" prop. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D25743

--HG--
extra : moz-landing-system : lando
2019-04-12 12:02:45 +00:00
Razvan Caliman
da3aba33df Bug 1543045 - Break strings for long CSS property names and values. r=gl
Introduce `overflow-wrap: break-word` to CSS declarations in Rules view and Changes panel to prevent long strings from causing unwanted horizontal scroll

Differential Revision: https://phabricator.services.mozilla.com/D27120

--HG--
extra : moz-landing-system : lando
2019-04-12 08:58:09 +00:00
Julian Descottes
cc0dfb6948 Bug 1532993 - Accept extra renders of WaterfallView in old perf panel test;r=julienw
Depends on D26920

See Bug 1532993#c12 for the analysis. The extra rendering is due to a window resize that
seems to always happen on ASAN but not on other platforms.

Differential Revision: https://phabricator.services.mozilla.com/D27143

--HG--
extra : moz-landing-system : lando
2019-04-12 07:35:02 +00:00
Julian Descottes
6540f8411f Bug 1532993 - Add test for perfomance panel when devtools are in frame type=content r=ochameau
Depends on D26919

This test also needs the fixes from Bug 1538731

Differential Revision: https://phabricator.services.mozilla.com/D26920

--HG--
extra : moz-landing-system : lando
2019-04-12 07:34:13 +00:00
Julian Descottes
b57cba3581 Bug 1532993 - Use DOMHelpers to wait for iframe load in widgets/Graphs.js;r=ochameau
Depends on D26900
Fixes the blank chart and load issues for the old perf panel in about:devtools-toolbox (or type=content)

Differential Revision: https://phabricator.services.mozilla.com/D26919

--HG--
extra : moz-landing-system : lando
2019-04-12 07:33:48 +00:00
Florens Verschelde
e248e2626b Bug 1543348 - Create generic button background variables; r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D26880

--HG--
extra : moz-landing-system : lando
2019-04-11 16:23:47 +00:00
Brendan Dahl
3a89c21f7f Bug 1518005 - Fix intermittent devotools test. r=bgrins
Wait for devtools panel to be ready before attempting to use it.

Differential Revision: https://phabricator.services.mozilla.com/D27160

--HG--
extra : moz-landing-system : lando
2019-04-11 21:08:04 +00:00
Jason Laster
6cc5611a86 Bug 1543519 - Add a build watcher. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D26998

--HG--
extra : moz-landing-system : lando
2019-04-11 19:37:29 +00:00
Jason Laster
325188a605 Bug 1534818 - Test worker functionality.
Differential Revision: https://phabricator.services.mozilla.com/D27156

--HG--
extra : moz-landing-system : lando
2019-04-11 20:59:43 +00:00
Julian Descottes
2416e24e10 Bug 1538731 - Add test for panel reloading with about:devtools-toolbox;r=daisuke
Depends on D26899
This test would timeout with the fix in the previous patch

Differential Revision: https://phabricator.services.mozilla.com/D26900

--HG--
extra : moz-landing-system : lando
2019-04-11 14:50:04 +00:00
Julian Descottes
375ef75753 Bug 1538731 - Stop using async methods in performance panel initializer.js;r=daisuke
Follow up to 1524982. We started using the browserloader to load almost all perf panel files.
However we kept two async methods in the js file loaded by performance/index.xul, which defeated the purpose.

Differential Revision: https://phabricator.services.mozilla.com/D26899

--HG--
extra : moz-landing-system : lando
2019-04-11 14:46:55 +00:00
David Walsh
03940b7837 Bug 1543453 - Show log value in tooltip when hovering on column breakpoint r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D26948

--HG--
extra : moz-landing-system : lando
2019-04-11 14:52:52 +00:00
nagpalm7
962d76ab96 Bug 1543581 - Align threads list with UI specs r=fvsch
Fixes [[ https://github.com/firefox-devtools/debugger/issues/8149 | Bug 8149 ]]
Threads list after the changes look like.
{F1255266}

Differential Revision: https://phabricator.services.mozilla.com/D26419

--HG--
extra : moz-landing-system : lando
2019-04-11 13:23:55 +00:00
Brian Grinstead
e1abf1b768 Bug 1542843 - Don't special case XUL documents in webExtensionTargetPrototype._shouldAddNewGlobalAsDebuggee;r=rpl
As we convert more chrome documents away from XUL we end up running
through two different paths in this function. These are going to be
filtered out in later checks anyway, so this change removes the early return.

Differential Revision: https://phabricator.services.mozilla.com/D26574

--HG--
extra : moz-landing-system : lando
2019-04-08 19:26:23 +00:00
Andreea Pavel
4840f1b635 Backed out changeset 7899601d5d70 (bug 1534818) for eslint failure on a CLOSED TREE 2019-04-11 16:57:48 +03:00
Jason Laster
b7e242eead Bug 1534818 - Test worker functionality. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D26808

--HG--
extra : moz-landing-system : lando
2019-04-11 13:45:28 +00:00
Jason Laster
2bcc64bcd9 Bug 1543406 - Upgrade flow to 0.96. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D26918

--HG--
extra : moz-landing-system : lando
2019-04-10 14:58:07 +00:00
Andreea Pavel
770584d8f9 Backed out 4 changesets (bug 1532993, bug 1538731) for failing dt on a CLOSED TREE
Backed out changeset f7050f15a28d (bug 1532993)
Backed out changeset f1615630af59 (bug 1532993)
Backed out changeset ff05581f5fe0 (bug 1538731)
Backed out changeset 769d9b3bdd4e (bug 1538731)

--HG--
extra : histedit_source : 3aecad787c4b55f12dc7e6384f0a8722e2a60bbd
2019-04-11 16:06:27 +03:00
Daisuke Akatsuka
c2af90eef6 Bug 1497454: Add a test for focusing existing tab. r=jdescottes
Depends on D26652

Differential Revision: https://phabricator.services.mozilla.com/D26653

--HG--
extra : moz-landing-system : lando
2019-04-11 11:39:57 +00:00
Daisuke Akatsuka
c7f59d9619 Bug 1497454: Focus a tab which is inspecting for the debug target. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D26652

--HG--
extra : moz-landing-system : lando
2019-04-11 02:06:41 +00:00
Julian Descottes
4fd5e7af5e Bug 1532993 - Add test for perfomance panel when devtools are in frame type=content r=ochameau
Depends on D26919

This test also needs the fixes from Bug 1538731

Differential Revision: https://phabricator.services.mozilla.com/D26920

--HG--
extra : moz-landing-system : lando
2019-04-11 10:06:57 +00:00
Julian Descottes
862fa42f20 Bug 1532993 - Use DOMHelpers to wait for iframe load in widgets/Graphs.js;r=ochameau
Depends on D26900
Fixes the blank chart and load issues for the old perf panel in about:devtools-toolbox (or type=content)

Differential Revision: https://phabricator.services.mozilla.com/D26919

--HG--
extra : moz-landing-system : lando
2019-04-11 09:03:41 +00:00
Julian Descottes
bf0b866ca5 Bug 1538731 - Add test for panel reloading with about:devtools-toolbox;r=daisuke
Depends on D26899
This test would timeout with the fix in the previous patch

Differential Revision: https://phabricator.services.mozilla.com/D26900

--HG--
extra : moz-landing-system : lando
2019-04-11 09:52:47 +00:00
Julian Descottes
fecd3641a7 Bug 1538731 - Stop using async methods in performance panel initializer.js;r=daisuke
Follow up to 1524982. We started using the browserloader to load almost all perf panel files.
However we kept two async methods in the js file loaded by performance/index.xul, which defeated the purpose.

Differential Revision: https://phabricator.services.mozilla.com/D26899

--HG--
extra : moz-landing-system : lando
2019-04-11 09:36:14 +00:00
Hiroyuki Ikezoe
f7645a5770 Bug 1531228 - Enable the new scroll snap and disable the old scroll snap on nightly. r=botond
Differential Revision: https://phabricator.services.mozilla.com/D22804

--HG--
extra : moz-landing-system : lando
2019-04-11 06:22:01 +00:00
Hiroyuki Ikezoe
eab764a7ae Bug 1312163 - Switch to the new scroll-snap-type syntax for the old scroll snap implementation and drop the scroll-snap-type-{x,y} longhands. r=emilio
Now scroll-snap-type is a longhand property.

Depends on D21621

Differential Revision: https://phabricator.services.mozilla.com/D21622

--HG--
extra : moz-landing-system : lando
2019-04-11 06:19:31 +00:00
Micah Tigley
fb733b5704 Bug 1536808 - Add ability to edit devices r=gl
Differential Revision: https://phabricator.services.mozilla.com/D22180

--HG--
extra : moz-landing-system : lando
2019-04-10 17:37:33 +00:00
Yura Zenevich
4bd5cad7e1 Bug 1541666 - ensure that actors are alive when calling async API to the server. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D26459

--HG--
extra : moz-landing-system : lando
2019-04-10 18:36:04 +00:00
Yura Zenevich
4c0b4af80b Bug 1540904 - added full page API for accessibility walker actor. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D26458

--HG--
extra : moz-landing-system : lando
2019-04-10 18:36:02 +00:00