Commit Graph

281 Commits

Author SHA1 Message Date
edburns%acm.org
c593d6f998 Added comment in nativeDestroyInitContext about bug http://bugzilla.mozilla.org/show_bug.cgi?id=38271 2000-05-05 14:02:12 +00:00
rpallath%eng.sun.com
e6fe7452fe modified README 2000-04-24 21:28:42 +00:00
rpallath%eng.sun.com
59eca4c85a New Tests for getAlignment 2000-04-24 19:02:42 +00:00
rpallath%eng.sun.com
c3291b195e getAlignment tests for API -> LEFT 2000-04-24 18:58:18 +00:00
rpallath%eng.sun.com
1adee25c28 GetAlignment API tests 2000-04-24 18:55:25 +00:00
rpallath%eng.sun.com
171e857827 New files for Killer app on Win32 2000-04-24 18:52:40 +00:00
rpallath%eng.sun.com
b381bf0be3 Added README and BWTest.lst
Updated some test cases
2000-04-24 18:25:27 +00:00
edburns%acm.org
78325dd028 a=edburns
bug: pressing BACK hangs webclient

Files touched

File: DocumentLoadEvent.java	Status: Locally Modified

Made the constants final so they can be used in a
switch statement

File: EMWindow.java    	Status: Locally Modified

Modified eventDispatched() so it doesn't call any webclient
events.  This was causing the hang.  Took advantage of
the newly implemented ability to pass a string from the
mozilla event handler into java.


File: DocumentLoaderObserverImpl.cpp	Status: Locally Modified

Create a jstring from the url in the OnStartDocumentLoad event.
Pass it on to java.

File: jni_util.cpp	Status: Locally Modified

Wrapped JNU_GetEnv in BAL stuff so it works from Star.

File: WebclinetEventListener.java	Status: Locally Modified

Added comment to eventDispatched.
2000-04-22 02:01:20 +00:00
edburns%acm.org
2cc92f89bd bug 33099
r=shaver
a=edburns

Native code changes: This fix eradicates all
occurrences of the following symbols
 nsComponentManager nsServiceManeger
And replaces them with their nsI counterparts.
The following ns* classes still are used in
webclient, and no plans exist to replace them
with nsI counterparts: nsresult nsCOMPtr
nsCRT nsnull * nsServiceManager occurrences
were replaced with do_GetService(), using a
PROGID. * nsComponentManager occurrences were replaced with a call on the global class gComponentManager, declared in the new file ns_globals.h, and defined in WrapperFactoryImpl.cpp. ns_globals.h is included in jni_util.h. See the attachment to bug 33099 for ns_globals.h * Added deallocation code to WindowControlImpl.cpp nativeTerminate. I know it doesn't do much, but it's correct. Java code changes: * Added static method BrowserControlFactory.appTerminate(). This method simply calls the existing BrowserControlImpl.appTerminate(), which calls WrapperFactoryImpl.cpp nativeTerminate(). BrowserControlFactory.appTerminate() is called from EmbeddedMozilla's WindowListener, which gets fired when the user signals she wants the app to terminate.
2000-04-20 18:16:05 +00:00
ashuk%eng.sun.com
a9347be2bf fixed small bug with call to getSourceBytes
_Ashu
2000-04-20 03:16:15 +00:00
ashuk%eng.sun.com
5397f1dd36 new signature for getSourceBytes
_Ashu
2000-04-20 02:59:53 +00:00
edburns%acm.org
1586c56e2c bug 32011
r=ashuk
a=edburns

Add an "eventData" argument to WebclientEvent and subclasses.
This argument is sub-event specific.  For example, when a user
gets a DocumentLoadEvent, with an event type of
STATUS_URL_LOAD, the eventData is a String containing
the status string from the browser.

Added support for doing this in a BAL context.
2000-04-18 21:58:29 +00:00
edburns%acm.org
410da80665 bug 32011
r=ashuk
a=edburns

Add an "eventData" argument to WebclientEvent and subclasses.
This argument is sub-event specific.  For example, when a user
gets a DocumentLoadEvent, with an event type of
STATUS_URL_LOAD, the eventData is a String containing
the status string from the browser.
2000-04-18 21:57:42 +00:00
idk%eng.sun.com
75394f5e7f (36174) Added null checking
a = idk@eng.sun.com
2000-04-18 18:38:01 +00:00
edburns%acm.org
98ee9417b4 bug=http://bugzilla.mozilla.org/show_bug.cgi?id=32011
Added ability to allow Native webclient client to populate
the listener class hash table and provide an InstanceOf function.

This enables listeners to work for the future.
2000-04-15 00:27:35 +00:00
rpallath%eng.sun.com
c3d03bbc8b Added sort routine in autorun.pl
and setUnsupported method add in ElementImpl_hasAttrib*.java
2000-04-14 18:41:37 +00:00
edburns%acm.org
1176c0f8b4 bug: http://bugzilla.mozilla.org/show_bug.cgi?id=32011
Add first function pointer integration to webclient for StarOffice.
This is necessary to allow events to be sent from mozilla to
StarOffice.
2000-04-13 00:12:50 +00:00
ashuk%eng.sun.com
1c1397b664 Made fix for Find Dialog closing correctly on Solaris
a=ashuk
r=geetha.vaidyanaathan@sun.com
Bug=35514

_Ashu
2000-04-12 18:06:21 +00:00
ashuk%eng.sun.com
fc66e176ec Made changes for accomodating new CurrentPage Find features into
webclient

a=ashuk
r=edburns
Bug=20659

Ashu
2000-04-06 17:45:27 +00:00
ashuk%eng.sun.com
589efd82a7 changed signatures of functions in CurrentPage interface
a=ashuk
r=edburns
Bug=20659

Ashu
2000-04-06 17:42:46 +00:00
ashuk%eng.sun.com
7e45b0883a Added stuff to implement Find features in CurrentPage interface
a=ashuk
r=edburns
Bug=20659

_Ashu
2000-04-06 17:39:01 +00:00
ashuk%eng.sun.com
308b05817c Added AWT code to create a generic Dialog box. Used this to create a
Find Dialog Box for the Find features in the CurrentPage interface

a=ashuk
r=edburns
Bug=20659

Ashu
2000-04-06 17:36:57 +00:00
ashuk%eng.sun.com
b10d328efa Made changes in EMWIndow.java and EmbeddedMozilla.java to create a better
GUI with menus for creating and closing new windows and for Find features.

Ashu

a=ashuk
r=edburns
Bug=20659
2000-04-06 17:33:49 +00:00
edburns%acm.org
383322dfbb bug: http://bugzilla.mozilla.org/show_bug.cgi?id=34665
This change replaces all printfs in src_moz with calls to PR_LOG.  No
printfs should appear in src_moz anymore.

You won't see any console output from native code unless you define

NSPR_LOG_MODULES=webclient:3

in your environment.  Furthermore, if you want PR_LOG statements in
webclient to go to a file instead, define

WEBCLIENT_LOG_FILE=C:\VALIDDIR\filename.txt

in your environment.  This file will get created fresh each time, since
PR_LOG uses fopen(filename, "w").

New Files:

I've created ns_globals.h, included from jni_util.h.  ns_globals.h holds
an extern * to a struct used in the PR_LOG calls.

Significant changes:

WrapperFactoryImpl.cpp

nativeAppInitialize(){

Added:

#if DEBUG_RAPTOR_CANVAS
    prLogModuleInfo = PR_NewLogModule("webclient");
    const char *webclientLogFile = PR_GetEnv("WEBCLIENT_LOG_FILE");
    if (nsnull != webclientLogFile) {
        PR_SetLogFile(webclientLogFile);
        // If this fails, it just goes to stdout/stderr
    }
#endif
}

All the other files in this checkin follow the this pattern:

Before checkin:

       printf("InitMozillaStuff(%lx): Create the Event Queue for the UI thread...\n",
               initContext);

After checkin:

    if (prLogModuleInfo) {
        PR_LOG(prLogModuleInfo, 3,
               ("InitMozillaStuff(%lx): Create the Event Queue for the UI thread...\n",
               initContext));
    }

See http://lxr.mozilla.org/mozilla/source/nsprpub/pr/include/prlog.h#190

for the definition of PR_LOG
2000-04-05 21:38:27 +00:00
rpallath%eng.sun.com
f6188063e7 Added entries for ElementImpl_hasAttribute and
ElementImpl_hasAttributeNS
2000-04-04 22:25:19 +00:00
rpallath%eng.sun.com
d7ae9316a4 Updated with entries for ElementImpl_hasAttribute/ElementImpl_hasAttributeNS 2000-04-04 22:21:50 +00:00
rpallath%eng.sun.com
72017803f1 Added new unsupported methods 2000-04-04 22:18:53 +00:00
sdv%sparc.spb.su
0207ef429d implemented some w3c event interfaces methods 2000-04-04 17:55:34 +00:00
rpallath%eng.sun.com
5a86a50a69 Added Bug information for Bug Id 15118 2000-04-03 23:36:09 +00:00
rpallath%eng.sun.com
514a515586 Added redirectxml.html and changes the scripts
accordingly to reflect the new file.
2000-04-03 18:31:39 +00:00
edburns%acm.org
d9cd53fece The problem was in the way the
NativeEventThread's run() method's infinite loop was implemented.  The
  loop looks like this:

    while (null != this.browserControlCanvas) {
        synchronized (this.browserControlCanvas.getTreeLock()) {
            nativeProcessEvents(nativeWebShell);

            if (null != listenersToAdd && !listenersToAdd.isEmpty()) {
                tempEnum = listenersToAdd.elements();
                while (tempEnum.hasMoreElements()) {
                    nativeAddListener(nativeWebShell,
                                          (WebclientEventListener)
                                      tempEnum.nextElement());
                }
                listenersToAdd.clear();
            }
        }
    }

  The problem I was observing was that
  nativeProcessEvents(nativeWebShell) would crash due to the fact that
  the nativeWebShell, which is actually an WebShellInitContext instance,
  had been de-allocated.  This de-allocation happens as a result of the
  WindowControlImpl.delete() method, which looks like this:

public void delete()
{
    Assert.assert(null != eventThread, "eventThread shouldn't be null at delete time");
    eventThread.delete();
    eventThread = null;
    nativeDestroyInitContext(nativeWebShell);
    nativeWebShell = -1;
}

  nativeDestroyInitContext de-allocates the WebShellInitContextInstance.
  You can see that the first thing done is to delete the eventThread().
  NativeEventThread.delete() looks like this:

public void delete()
{
    // setting this to null causes the run thread to exit
    synchronized(this.browserControlCanvas.getTreeLock()) {
        browserControlCanvas = null;
    }
...
}

  If you compare NativeEventThread.delete() with the infinite loop in
  NativeEventThread.run(), you'll see that the fact that they both
  synchronize on the same object doesn't protect us from the following
  case:

    NativeEventThread: The infinite loop checks to see if the
    browserControlCanvas is null, then does synchronize on
    browserControlCanvas.getTreeLock(), then calls processNativeEvents().

meanwhile

    WindowControlImpl thread: delete() calls NativeEventThread.delete(),
    which does synchronize on browserControlCanvas.getTreeLock().
    During NativeEventThread.delete(), synchronized section,
    browserControlCanvas is set to null.

    NativeEventThread: because the check for null browserControlCanvas
    occurrs outside of the synchronized block, it's not recheked, and
    thus, the event loop continues to process when it shouldn't.

  The fix is to change the event loop to look like this:

    while (true) {
        synchronized (this.browserControlCanvas.getTreeLock()) {
            // this has to be inside the synchronized block!
            if (null == this.browserControlCanvas) {
                return;
            }
            nativeProcessEvents(nativeWebShell);

            if (null != listenersToAdd && !listenersToAdd.isEmpty()) {
                tempEnum = listenersToAdd.elements();
                while (tempEnum.hasMoreElements()) {
                    nativeAddListener(nativeWebShell,
                                          (WebclientEventListener)
                                      tempEnum.nextElement());
                }
                listenersToAdd.clear();
            }
        }
    }
2000-04-03 04:32:27 +00:00
rpallath%eng.sun.com
b7d91147d9 changed == to != 2000-04-01 01:29:59 +00:00
edburns%acm.org
9f827678b5 Adding this line to the top of the run() method in
NativeEventThread seems to fix the hanging problem.

    this.setPriority(Thread.MIN_PRIORITY);


Looks like it was starvation.
2000-04-01 01:17:33 +00:00
rpallath%eng.sun.com
652e342dd1 Updated classPATH in mozilla.bat nad mozilla.csh 2000-04-01 00:34:48 +00:00
rpallath%eng.sun.com
cb69af2c93 Removing DOMAccessorImpl as it is no longer valid. 2000-04-01 00:07:02 +00:00
rpallath%eng.sun.com
a9b57a5ba1 Added DOMAccessor.java (insted of DOMAccessorImpl)
Added redirect.html
2000-04-01 00:04:15 +00:00
sdv%sparc.spb.su
814dcc76c5 removed org/mozilla/dom/tests from JDIR 2000-03-31 19:22:48 +00:00
edburns%acm.org
98536e5bea Thanks to Andi Eades, and Steffen Grarup for finding and fixing this.
Basically, we were storing a local jobject ref and using it on
 another thread without calling NewGlobalRef.

The fix is below:

cvs diff WindowControlImpl.cpp NativeEventThread.cpp (in directory D:\Projects\mozilla\java\webclient\src_moz\)
Index: WindowControlImpl.cpp
===================================================================
RCS file: /cvsroot/mozilla/java/webclient/src_moz/WindowControlImpl.cpp,v
retrieving revision 1.5
diff -r1.5 WindowControlImpl.cpp
131c131,134
<     initContext->nativeEventThread = nsnull;
---
>     if (nsnull != initContext->nativeEventThread) {
>         ::util_DeleteGlobalRef(env, initContext->nativeEventThread);
>         initContext->nativeEventThread = nsnull;
>     }
Index: NativeEventThread.cpp
===================================================================
RCS file: /cvsroot/mozilla/java/webclient/src_moz/NativeEventThread.cpp,v
retrieving revision 1.7
diff -r1.7 NativeEventThread.cpp
213c213,215
<         initContext->nativeEventThread = obj; // VERY IMPORTANT!!
---
>         initContext->nativeEventThread =
>             ::util_NewGlobalRef(env, obj); // VERY IMPORTANT!!
>

*****CVS exited normally with code 1*****
2000-03-31 17:09:00 +00:00
sdv%sparc.spb.su
fe663d8006 moved applet tests to tests/src/applets 2000-03-31 01:42:34 +00:00
sdv%sparc.spb.su
11a9d1af25 keeping track with Java DOM changes
r=idk@eng.sun.com
2000-03-31 01:22:00 +00:00
sdv%sparc.spb.su
18acde14ee added DOMAccessor.java patch 2000-03-31 00:11:36 +00:00
sdv%sparc.spb.su
26937e21bf A major update:
- reduces a number of c++<--> java calls
- added NULL checks
- made DOMAccessor to be secure
- added util and tests packages
- wrote test applets
- updated README
2000-03-30 23:52:19 +00:00
sdv%sparc.spb.su
f783e6228f removed java files which were placed
to classes dir
2000-03-29 01:07:03 +00:00
sdv%sparc.spb.su
8c2aa12cf4 put module sources to a single dir
updated makefiles
2000-03-29 00:43:54 +00:00
sdv%sparc.spb.su
43a0aedd4e put classes to a single dir
updated makefiles
2000-03-29 00:41:22 +00:00
ashuk%eng.sun.com
2c6c864e3c a=ashuk
Made changes to the solaris makefile to include jni_util_export - for webclient-uno stuff

_Ashu
2000-03-28 21:36:04 +00:00
sdv%sparc.spb.su
6015d910d0 updated makefiles 2000-03-28 05:11:02 +00:00
sdv%sparc.spb.su
7b1271aded keeping track with mozilla interface changes 2000-03-28 04:55:38 +00:00
sdv%sparc.spb.su
56a2016ca3 added new methods from the recent w3c
java binding
2000-03-28 02:11:13 +00:00
edburns%acm.org
6f94ba590d I really meant to check in this one. 2000-03-27 20:28:21 +00:00