In /devtools/client/storage/ui.js, handleChangedItems and handleDeletedItems should only JSON.parse string keys related to the indexedDB and Cache actors.
The string keys used by all the other storage actors are expected to be a simple string keys, and their valid values include strings that can be successfully parsed as JSON (e.g. "123" or "null" are both valid keys for the storage items related to the localStorage, extensionStorage etc.).
Differential Revision: https://phabricator.services.mozilla.com/D45197
--HG--
extra : moz-landing-system : lando
Otherwise, what happens in documents like the webconsole is the theme file gets loaded before
global.css, which isn't the intended behavior and makes overriding the styles from global.css
more difficult. As an example, some buttons in the webconsole became stretched after Bug 1581914
changed some default styling in global.css. This patch restores the correct behavior by loading
the theme afer global.css.
global.css is currently loaded in devtools in docs that explicitly use XUL elements (such as storage inspector
and style editor), and in docs that need to be supported as top level windows (webconsole, toolbox, and
browser toolbox). Unless if we change how things like panels and context menus are styled, the latter
group will continue to need to load global.css even as XUL/XBL usage goes away (since they are styled
with global.css).
Differential Revision: https://phabricator.services.mozilla.com/D46530
--HG--
extra : moz-landing-system : lando
Currently, TabGroups know to break their reference cycles only when the last
window leaves them. For TabGroups which have never had a window join (which
happens under Fission), this means they also never see a window leave, and
therefore never break their reference cycles, and leak.
This patch adds a check to break reference cycles if no windows have joined by
the time a BrowserChild they belong to is destroyed.
MANUAL PUSH: Lando fails to rebase.
Differential Revision: https://phabricator.services.mozilla.com/D40669
--HG--
extra : source : 03acb28ab60fb77fa06064385a62cc46cf4ad1bd
extra : amend_source : 0a71625d99951bebe45ee6f62570de491a714e97
Depends on D38620
json5 is a much bigger library than JSOL but it doesn't rely on any eval-like code.
It should provide similar features, and testing locally it seems to work as expected.
Differential Revision: https://phabricator.services.mozilla.com/D38515
--HG--
extra : moz-landing-system : lando
When a test crashes, the harness skips all of the remaining tests in the
directory. That means that with crashes skipped, we now try to run a whole lot
more tests than we did before, and a lot of them fail under Fission.
This patch adds annotations to the new failures that show up after part 1.
Differential Revision: https://phabricator.services.mozilla.com/D38726
--HG--
extra : rebase_source : 292157039c88fc615f5de41679e96e72766ac4db
My preference was to annotate most of the failing tests with `fail-if` so that
if they start passing, the `fail-if` needs to be removed and they need to keep
passing. That doesn't work for tests that timeout, or which trigger failures
from their cleanup functions, however, so those tests need skip-if. And tests
with fail in their cleanup functions likely leave the browser in an
inconsistent state for subsequent tests, anyway, so really should be skipped
regardless.
There are some remaining tests which still fail because of crashes. I chose
not to skip them here, but to fix the crashes in separate bugs instead.
Differential Revision: https://phabricator.services.mozilla.com/D38247
--HG--
extra : rebase_source : 39ba8fec2e882cfe577c5f2b58ab7e4b461f1178
### Changes
#### Set 1 - Match cookie creation strings, remove "on" and capitalize.
- Expires on {icon long-arrow-right} Expires
- Last accessed on {icon long-arrow-right} Last accessed
- Created on {icon long-arrow-right} Created
- sameSite {icon long-arrow-right} SameSite
#### Set 2 - Re-add missing strings
- table.headers.cookies.isHttpOnly=HttpOnly
- table.headers.cookies.isSecure=Secure
- table.headers.cookies.hostOnly=HostOnly
Differential Revision: https://phabricator.services.mozilla.com/D33041
--HG--
extra : moz-landing-system : lando
Before this change, there was no option to copy text of an attribute in
sidebar of storage.You can now copy an attribute and it's text.
Differential Revision: https://phabricator.services.mozilla.com/D23977
--HG--
extra : moz-landing-system : lando
This allows us to drop preprocessing and makes it simpler to add edit menu functionality to any type of document.
Differential Revision: https://phabricator.services.mozilla.com/D21446
--HG--
extra : moz-landing-system : lando
Before this change clicking on Storage Type use to show table headers from previous selection. Now clicking on Storage Type will reset table headers also in case empty table headers will get cleared.
Differential Revision: https://phabricator.services.mozilla.com/D22327
--HG--
extra : moz-landing-system : lando
