Commit Graph

1405 Commits

Author SHA1 Message Date
Kris Maglione
8ec2442bf5 Bug 1647519: Reject javascript: requests targeting other content processes. r=nika
Loads targeting cross-process BrowsingContexts are by definition cross-origin,
which should preclude any javascript: loads. While those loads are currently
prevented by principal checks in the final target process, sending IPC
messages for the attempts is unnecessary, and potentially opens a door to
privilege escalation exploits by a compromised content process.

This patch prevents any cross-process load requests from being sent by content
processes, and adds checks in the parent process to kill any (potentially
compromised) content process which attempts to send them.

Differential Revision: https://phabricator.services.mozilla.com/D103529
2021-02-02 22:24:47 +00:00
Brindusan Cristian
e87cc6c9b1 Backed out changeset e4cefba9f87e (bug 1647519) for build bustages in BrowsingContext.cpp. CLOSED TREE 2021-02-03 00:08:53 +02:00
Kris Maglione
dc41c70e24 Bug 1647519: Reject javascript: requests targeting other content processes. r=nika
Loads targeting cross-process BrowsingContexts are by definition cross-origin,
which should preclude any javascript: loads. While those loads are currently
prevented by principal checks in the final target process, sending IPC
messages for the attempts is unnecessary, and potentially opens a door to
privilege escalation exploits by a compromised content process.

This patch prevents any cross-process load requests from being sent by content
processes, and adds checks in the parent process to kill any (potentially
compromised) content process which attempts to send them.

Differential Revision: https://phabricator.services.mozilla.com/D103529
2021-02-02 21:46:53 +00:00
Mihai Alexandru Michis
f2070ec731 Backed out changeset c0ecccf36d56 (bug 1647519) for causing bustages in BrowsingContext.cpp
CLOSED TREE
2021-02-02 22:47:01 +02:00
Kris Maglione
e2e8e3c012 Bug 1647519: Reject javascript: requests targeting other content processes. r=nika
Loads targeting cross-process BrowsingContexts are by definition cross-origin,
which should preclude any javascript: loads. While those loads are currently
prevented by principal checks in the final target process, sending IPC
messages for the attempts is unnecessary, and potentially opens a door to
privilege escalation exploits by a compromised content process.

This patch prevents any cross-process load requests from being sent by content
processes, and adds checks in the parent process to kill any (potentially
compromised) content process which attempts to send them.

Differential Revision: https://phabricator.services.mozilla.com/D103529
2021-02-02 20:32:04 +00:00
Brindusan Cristian
1f923f4895 Backed out changeset 0395717ea76d (bug 1647519) for build bustages at BrowsingContext.cpp. CLOSED TREE 2021-02-02 22:07:10 +02:00
Brindusan Cristian
cbdb020883 Backed out 11 changesets (bug 1681529) for mochitest failures at test_reload_large_postdata.html. CLOSED TREE
Backed out changeset f1f988155c82 (bug 1681529)
Backed out changeset f0ba367de05e (bug 1681529)
Backed out changeset dbea9952ec79 (bug 1681529)
Backed out changeset 6e185ec2c4a4 (bug 1681529)
Backed out changeset d0b11c08666a (bug 1681529)
Backed out changeset f2515096b378 (bug 1681529)
Backed out changeset ecd8c3b8fdb4 (bug 1681529)
Backed out changeset 7ea2e9cc8bad (bug 1681529)
Backed out changeset dbc85d0bffaf (bug 1681529)
Backed out changeset f0893f544219 (bug 1681529)
Backed out changeset 91979e21aa8e (bug 1681529)
2021-02-02 22:02:59 +02:00
Kris Maglione
403125cd23 Bug 1647519: Reject javascript: requests targeting other content processes. r=nika
Loads targeting cross-process BrowsingContexts are by definition cross-origin,
which should preclude any javascript: loads. While those loads are currently
prevented by principal checks in the final target process, sending IPC
messages for the attempts is unnecessary, and potentially opens a door to
privilege escalation exploits by a compromised content process.

This patch prevents any cross-process load requests from being sent by content
processes, and adds checks in the parent process to kill any (potentially
compromised) content process which attempts to send them.

Differential Revision: https://phabricator.services.mozilla.com/D103529
2021-02-02 19:47:12 +00:00
Nika Layzell
b3fac57b0f Bug 1681529 - Part 1: Add a test for reloading a page with a large postdata payload, r=peterv
Without the other patches in this series, this test fails with both with and
without Fission enabled, for two different reasons.

With Fission disabled, the second reload request appears as empty, due to us
being unable to rewind the postData nsIInputStream. With Fission enabled, the
second reload request causes crashes due to the nsMIMEInputStream's invariant of
requiring a seekable stream is invalidated, causing the nsICloneableInputStream
implementation to misbehave.

Differential Revision: https://phabricator.services.mozilla.com/D101800
2021-01-28 19:40:22 +00:00
Gijs Kruitbosch
1f7304567e Bug 1643789 - fix use of alternate URI fixup for middle clicks, context menu clicks, etc., r=nika
Differential Revision: https://phabricator.services.mozilla.com/D103410
2021-02-02 00:27:42 +00:00
Andreea Pavel
dd3abe2b67 Bug 1607713 - disable browser_backforward_userinteraction.js on linux64 opt to reduce failure rate r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D103541
2021-02-01 19:10:37 +00:00
Kris Maglione
f440a0cc36 Bug 1685801: Part 2 - Move site origin telemetry to separate module. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D101482
2021-01-28 20:58:26 +00:00
Mihai Alexandru Michis
040e2ea5d0 Backed out 12 changesets (bug 1685801) for causing bc failures in browser_ctrlTab.js
CLOSED TREE

Backed out changeset 021924b62f13 (bug 1685801)
Backed out changeset 38cc10101c1f (bug 1685801)
Backed out changeset 9ab9574ac72a (bug 1685801)
Backed out changeset 1a7f259cc2ec (bug 1685801)
Backed out changeset b267b19a7f6e (bug 1685801)
Backed out changeset 7dfcf0257487 (bug 1685801)
Backed out changeset ee0d0169b079 (bug 1685801)
Backed out changeset 0c358ee51951 (bug 1685801)
Backed out changeset 338ab91af557 (bug 1685801)
Backed out changeset a49415007aaf (bug 1685801)
Backed out changeset b91098299143 (bug 1685801)
Backed out changeset edf6209861a8 (bug 1685801)
2021-01-28 22:55:11 +02:00
Kris Maglione
59963809cd Bug 1685801: Part 2 - Move site origin telemetry to separate module. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D101482
2021-01-28 18:48:25 +00:00
Henri Sivonen
0ddb192035 Bug 1688368 - Check mFeedChardet before feeding the detector. r=emk
Differential Revision: https://phabricator.services.mozilla.com/D102905
2021-01-27 10:36:39 +00:00
Peter Van der Beken
8853d16553 Bug 1674464 - Stop adding entries for about:tabcrashed when SHIP is enabled. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D96383
2021-01-26 12:41:22 +00:00
Csoregi Natalia
d97e4efd8e Backed out 9 changesets (bug 1681529) for causing bustage on TestSeekableStreamWrapper.cpp. CLOSED TREE
Backed out changeset 99d1c9682dc2 (bug 1681529)
Backed out changeset b562b6038855 (bug 1681529)
Backed out changeset 5a5f514a6cfe (bug 1681529)
Backed out changeset ceb55436928a (bug 1681529)
Backed out changeset 9852de883959 (bug 1681529)
Backed out changeset 1a33ea8b533d (bug 1681529)
Backed out changeset 3385635e9521 (bug 1681529)
Backed out changeset 49c28bfc4da4 (bug 1681529)
Backed out changeset 43cc14af229d (bug 1681529)
2021-01-25 23:40:44 +02:00
Nika Layzell
1aa0c7b19d Bug 1681529 - Part 1: Add a test for reloading a page with a large postdata payload, r=peterv
Without the other patches in this series, this test fails with both with and
without Fission enabled, for two different reasons.

With Fission disabled, the second reload request appears as empty, due to us
being unable to rewind the postData nsIInputStream. With Fission enabled, the
second reload request causes crashes due to the nsMIMEInputStream's invariant of
requiring a seekable stream is invalidated, causing the nsICloneableInputStream
implementation to misbehave.

Differential Revision: https://phabricator.services.mozilla.com/D101800
2021-01-20 16:17:15 +00:00
Dimi Lee
560eb57c78 Bug 1589074 - Fix docshell mochitest failures after changing default referrer policy to strict-origin-when-cross-origin. r=smaug CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D98436
2021-01-25 14:12:56 +00:00
Dimi Lee
09d83a6839 Bug 1589074 - Fix dom mochitest failures after changing default referrer policy to strict-origin-when-cross-origin. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D88552
2021-01-25 13:26:55 +00:00
Butkovits Atila
f6b5550998 Merge mozilla-central to autoland. CLOSED TREE 2021-01-25 19:37:13 +02:00
Butkovits Atila
69babd862d Backed out 11 changesets (bug 1589074) for causing failures on test_DownloadCore.js.
Backed out changeset 10e37ec238ee (bug 1589074)
Backed out changeset a306f2483d73 (bug 1589074)
Backed out changeset b7a0d73a2885 (bug 1589074)
Backed out changeset da996dc79d5d (bug 1589074)
Backed out changeset 3cffd4570c8e (bug 1589074)
Backed out changeset 9fe67741eb5a (bug 1589074)
Backed out changeset e8e6d9a6b90d (bug 1589074)
Backed out changeset 78df7f0ccb31 (bug 1589074)
Backed out changeset 712f147c5a41 (bug 1589074)
Backed out changeset f093f3c48807 (bug 1589074)
Backed out changeset 454beae0f635 (bug 1589074)
2021-01-25 14:57:00 +02:00
Dimi Lee
5e7e561b22 Bug 1589074 - Fix docshell mochitest failures after changing default referrer policy to strict-origin-when-cross-origin. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D98436
2021-01-25 14:12:56 +00:00
Dimi Lee
bb3515bdb9 Bug 1589074 - Fix dom mochitest failures after changing default referrer policy to strict-origin-when-cross-origin. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D88552
2021-01-25 13:26:55 +00:00
Peter Van der Beken
32e97bcced Bug 1679418 - Fix test_bug1300461.html failure for Fission. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D99711
2021-01-25 12:59:26 +00:00
Butkovits Atila
9ac3c18562 Backed out 11 changesets (bug 1589074) for causing failures on test_DownloadCore.js.
Backed out changeset 10e37ec238ee (bug 1589074)
Backed out changeset a306f2483d73 (bug 1589074)
Backed out changeset b7a0d73a2885 (bug 1589074)
Backed out changeset da996dc79d5d (bug 1589074)
Backed out changeset 3cffd4570c8e (bug 1589074)
Backed out changeset 9fe67741eb5a (bug 1589074)
Backed out changeset e8e6d9a6b90d (bug 1589074)
Backed out changeset 78df7f0ccb31 (bug 1589074)
Backed out changeset 712f147c5a41 (bug 1589074)
Backed out changeset f093f3c48807 (bug 1589074)
Backed out changeset 454beae0f635 (bug 1589074)
2021-01-25 14:57:00 +02:00
Dimi Lee
a348d55db1 Bug 1589074 - Fix docshell mochitest failures after changing default referrer policy to strict-origin-when-cross-origin. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D98436
2021-01-22 08:48:36 +00:00
Dimi Lee
6940624a72 Bug 1589074 - Fix dom mochitest failures after changing default referrer policy to strict-origin-when-cross-origin. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D88552
2021-01-22 08:48:00 +00:00
Olli Pettay
991f9a986e Bug 1688109 - BroadcastChannel doesn't reliably remove the page from BFCache when a message is received, r=annyG
Differential Revision: https://phabricator.services.mozilla.com/D102657
2021-01-22 10:57:42 +00:00
Olli Pettay
8c3701e76e Bug 1684310 - Selecting a specific history entry from the dropdown may not cause a navigation, r=jesup
Differential Revision: https://phabricator.services.mozilla.com/D102503
2021-01-21 17:26:57 +00:00
Yura Zenevich
a6e8d4aaa9 Bug 1667998 - converted calls to EventUtils.sendMouseEvent to be async. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D97323
2021-01-15 18:20:44 +00:00
Anny Gakhokidze
7e4c4d4c54 Bug 1687340 - Change test_bfcache_plus_hash.html to use BroadcastChannel, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D102236
2021-01-18 23:49:24 +00:00
Noemi Erli
8ad2a18a79 Backed out 5 changesets (bug 1667998) for breaking a11y checks CLOSED TREE
Backed out changeset 633dda979b22 (bug 1667998)
Backed out changeset c9838cdb1303 (bug 1667998)
Backed out changeset 501c54cf59be (bug 1667998)
Backed out changeset 615b74c822ec (bug 1667998)
Backed out changeset 6d187c01fcb3 (bug 1667998)
2021-01-15 20:16:06 +02:00
Yura Zenevich
33ccace61e Bug 1667998 - converted calls to EventUtils.sendMouseEvent to be async. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D97323
2021-01-15 16:53:43 +00:00
Henri Sivonen
058e02104c Bug 1648464 - Add an Autodetect item to the Text Encoding menu. r=emk,chutten,Gijs
Take a step towards replacing the encoding menu with a single menu item that
triggers the autodetection manually. However, don't remove anything for now.

* Add an autodetect item.
* Add telemetry for autodetect used in session.
* Add telemetry for non-autodetect used in session.
* Restore and revise telemetry for how the encoding that is being overridden
  was discovered.

Differential Revision: https://phabricator.services.mozilla.com/D81132
2021-01-14 07:06:53 +00:00
Anny Gakhokidze
55fdb21001 Bug 1686784 - Change test_bug1379762.html to use BroadcastChannel, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D101816
2021-01-14 23:56:19 +00:00
Anny Gakhokidze
6686db8685 Bug 1686812 - Change test_performance_navigation.html to use BroadcastChannel, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D101833
2021-01-14 23:56:34 +00:00
Micah Tigley
1b5b46ec79 Bug 1680637 - Update tests using the old dialog UI to only use the old UI. r=jaws,Gijs,marionette-reviewers,whimboo,remote-protocol-reviewers
Depends on D100172

Differential Revision: https://phabricator.services.mozilla.com/D101388
2021-01-14 21:45:14 +00:00
Butkovits Atila
7742c03714 Backed out 4 changesets (bug 1680637, bug 1682395) for causing Marionette failures. CLOSED TREE
Backed out changeset 073e0be7db95 (bug 1680637)
Backed out changeset 552b91b31b0f (bug 1682395)
Backed out changeset c80de6c72779 (bug 1680637)
Backed out changeset d513e228b0ad (bug 1680637)
2021-01-13 02:13:06 +02:00
Micah Tigley
06e7942185 Bug 1680637 - Update tests using the old dialog UI to only use the old UI. r=jaws,Gijs
Depends on D100172

Differential Revision: https://phabricator.services.mozilla.com/D101388
2021-01-12 22:32:24 +00:00
Kris Maglione
57e9b6e56c Bug 1674214: Add preference to disqualify users from Fission experiment based on loaded origin count. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D99568
2021-01-08 20:12:07 +00:00
Alexis Beingessner
b1d3b28ef7 Bug 1683730 - disabled tests failing with tsan full shutdown. r=decoder
Seems like all timeouts at various levels.

Differential Revision: https://phabricator.services.mozilla.com/D100269
2021-01-08 20:08:29 +00:00
Noemi Erli
0fab52422c Backed out 2 changesets (bug 1674214) for causing failures in browser_fission_maxOrigins.js CLOSED TREE
Backed out changeset 19fbaf9cd86f (bug 1674214)
Backed out changeset 7ef22fe8f73a (bug 1674214)
2021-01-06 01:35:37 +02:00
Kris Maglione
ddca497df5 Bug 1674214: Add preference to disqualify users from Fission experiment based on loaded origin count. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D99568
2021-01-05 21:58:05 +00:00
Noemi Erli
24fa247850 Backed out changeset 47f0d542db39 (bug 1674214) for causing fission related failures CLOSED TREE 2021-01-05 22:28:56 +02:00
Kris Maglione
e47b5afa5e Bug 1674214: Add preference to disqualify users from Fission experiment based on loaded origin count. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D99568
2020-12-16 21:57:14 +00:00
Daniel Holbert
f86b6c2086 Bug 1052471: Adjust test_bug453650.xhtml to perform its reflow-causing restyle a bit later, *after* the reflow observer is registered. r=jfkthame
I'm hoping this fixes (or at least helps with) this intermittent test failure
(an intermittent test-timeout).

Before this patch, the test did the following: it made a layout-impacting
restyle, and then it registered a reflow observer, and then it waited for the
previously-performed restyle to be flushed, which it then expects to cause a
reflow and trigger the reflow observer.

When the test times out and intermittently fails, it seems that the reflow
observer is successfully registered but never fires. I'm guessing that's
because the reflow is getting flushed eagerly for some reason, and happens
*before* the reflow observer is registered.  We can avoid this problem by
holding off on the restyle until after the reflow observer has been registered;
that's the approach that this patch takes.

(Note that this reflow-observer API isn't web-exposed; it's an internal API that
we use to report reflows in our devtools.)

Differential Revision: https://phabricator.services.mozilla.com/D100517
2021-01-04 19:04:40 +00:00
Jonathan Kew
809ac36608 Bug 1676966 - Don't block layout on global font fallback; load character maps asynchronously, and then reflow when available. r=lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D98904
2020-12-31 00:33:48 +00:00
Cosmin Sabou
74039caf3c Backed out changeset 345d6be71db1 (bug 1676966) for mochitest without e10s failures. CLOSED TREE 2020-12-30 15:36:10 +02:00
Jonathan Kew
c19e845492 Bug 1676966 - Don't block layout on global font fallback; load character maps asynchronously, and then reflow when available. r=lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D98904
2020-12-30 12:34:49 +00:00