Commit Graph

5166 Commits

Author SHA1 Message Date
Gregory Szorc
8f958c2424 Bug 1400429 - Advertise use of mach try in commit message; r=ahal
This will allow us to inspect Try pushes to see how many are using
`mach try`.

The commit message for `mach try fuzzy` already advertised its usage.
We tweak the syntax a little so it isn't redundant.

MozReview-Commit-ID: 6kmYRKp0ffF

--HG--
extra : rebase_source : 9dd7caa5404ba235e6a4071802000b8bb740a6b7
2017-09-15 16:17:37 -07:00
Sebastian Hengst
48545a66e9 Backed out changeset f4c33a37fe6d (bug 1395890) for failing browser-chrome's browser/components/extensions/test/browser/browser_ext_find.js. r=backout on a CLOSED TREE 2017-09-19 16:35:31 +02:00
Dan Banner
d9bd75f0cc Bug 1395890 - Change all ESLint rules that are warnings to errors. r=standard8
MozReview-Commit-ID: LJS6m1GppiS

--HG--
extra : rebase_source : 0428c961831f079a63f345c8d6684b869fbcdecd
2017-09-18 19:07:17 +01:00
Wes Kocher
44fefedf8c Bug 1391123 - Add a newline to the end of try_task_config.json r=gps
MozReview-Commit-ID: BtQntIHOo2G

--HG--
extra : rebase_source : b8e6d6a32ea728590bf4aec85c7605a8829d47c1
2017-09-15 19:02:13 -07:00
Steve Armand
d11ffd18db Bug 1399989 - Add python/mach to flake8 linter. r=gps
MozReview-Commit-ID: KKnBgYFwpfT

--HG--
extra : rebase_source : 4e4b3453a91970366dba0073853ad3ab62738c81
2017-09-17 22:41:17 -04:00
Mark Banner
5c31c8a30b Bug 1399946 - Bump version number of eslint-plugin-mozilla for releasing the dependency fixes from bug 1395879. r=ahal
MozReview-Commit-ID: 79nDcgcvm0c

--HG--
extra : rebase_source : 78d2dd8eaec5d36c8611effe96f93949b76929e9
2017-09-18 09:15:57 +01:00
Axel Hecht
4383c6ecf6 Backout revision e95f8bd7b519 and 84091f931dff (bug 1385227) for breaking Beta release automation.
--HG--
extra : rebase_source : 512c7603f1c600d9cd4ba4b17007ee9a9480e365
extra : histedit_source : be31be1ade27d0df5a25badc2def1a59f2a9c2fd%2Ca0db2bfd6e59dab72fb8c58063ea7592cfeb430e
2017-09-16 11:04:13 +02:00
Edouard Oger
dc3b62bea0 Bug 1383663 part 3 - Update FxA local state on profile email change. r=markh
MozReview-Commit-ID: 5epKjoT4TF3

--HG--
extra : rebase_source : 3c9737d304d2a4a4448e43c1f4a13e738716453e
2017-08-21 17:01:57 -04:00
Phil Ringnalda
e6c038d6ee Backed out 3 changesets (bug 1383663) for timeouts in browser_aboutAccounts.js and failures in test_web_channel.js
Backed out changeset f384a524cac6 (bug 1383663)
Backed out changeset 9d26a627e2f8 (bug 1383663)
Backed out changeset c7d46e2e8ddc (bug 1383663)

MozReview-Commit-ID: 88xbdeVJtK2
2017-09-16 10:40:00 -07:00
Edouard Oger
3d91da7159 Bug 1383663 part 3 - Update FxA local state on profile email change. r=markh
MozReview-Commit-ID: 5epKjoT4TF3

--HG--
extra : rebase_source : 437b8d56d48898b347ecaf3d9ca0f6cc3176d2e2
2017-08-21 17:01:57 -04:00
Mark Banner
2c7467dd71 Bug 1395879 - Remove espree/escope etc from the direct dependencies of eslint-plugin-mozilla since they are really peerDependencies supplied by the existing eslint peer. r=mossop
MozReview-Commit-ID: 2FEfFaEoomU

--HG--
extra : rebase_source : f284707bb792443de11c57524f0bd296fdc675cf
2017-09-01 11:27:33 +01:00
Steve Armand
5d8117b9de Bug 1397852 - Enable flake8 linter on testing/xpcshell. r=ahal
MozReview-Commit-ID: CvZVXQPx8jF

--HG--
extra : rebase_source : 359f148397ef5584028e343080c6774407f74db6
2017-09-14 09:51:27 -04:00
ruby
af79c59e2a Bug 1397427 - Enable py2 linter on tools/tryselect, r=ahal
MozReview-Commit-ID: K12XisbVQGq

--HG--
extra : rebase_source : 6a97dda2be81fa45601c2f09486c4a187f177cf5
2017-09-13 11:57:47 +05:30
Alexandre Poirot
f2bfc94341 Bug 1399449 - Convert devtools/client/responsivedesign/responsivedesign.jsm to a commonjs module. r=jryans
MozReview-Commit-ID: Jl6OGUWnbHN

--HG--
rename : devtools/client/responsivedesign/responsivedesign.jsm => devtools/client/responsivedesign/responsivedesign.js
extra : rebase_source : 329c364fc4c256273b0d02a8119637aed428134c
2017-09-13 14:33:58 +02:00
Steve Armand
5934392346 Bug 1397855 - Enable py2 and py3 linter on testing/xpcshell. r=ahal
MozReview-Commit-ID: CsfIcI1ma7J

--HG--
extra : rebase_source : 53658c33432927f72ddce0999f18c2b7df261f6d
2017-09-07 21:15:35 -04:00
Sebastian Hengst
be553422dd merge mozilla-central to autoland. r=merge a=merge 2017-09-13 11:30:55 +02:00
Sebastian Hengst
1fbe7771e8 merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: GUc4LEY8qp4
2017-09-13 11:27:47 +02:00
Andi-Bogdan Postelnicu
e0cb8d320b Bug 1398785 - Kill structurally dead code in NS_IMPL_CYCLE_COLLECTION_CAN_SKIP_THIS_BEGIN generated by Coverity. r=sylvestre
MozReview-Commit-ID: AB3DLFft5aw

--HG--
extra : rebase_source : 6d51c98df43e750d8b21aa8d5de62ab1632afaba
2017-09-12 10:30:17 +03:00
Andrew Halberstadt
a5c7e81ae6 Bug 1398765 - Fix directory exclusion bug in py-compat linters, r=gps
The excluded directories aren't being properly handled in the py2/py3 compat
linters. In order for FileFinder to apply the exclusions properly they need
to either be relative to or contained by the base.

This means that currently the following will work:
./mach lint -l py2 <topsrcdir>
./mach lint -l py2 testing/mochitest

But this is broken:
./mach lint -l py2 testing

This change fixes the compat linters so exclude paths will be made relative
to the FileFinder base before passing them in. Any exclude not contained by
the base is simply discarded as it won't be relevant to that FileFinder
instance anyway.

MozReview-Commit-ID: LJx97TvKlSa

--HG--
extra : rebase_source : b8f0cb20ec5a88a33c26ace699ed9216b070f443
2017-09-11 09:03:53 -04:00
Sebastian Hengst
69de1aac47 Backed out changeset ec61b7a902c2 (bug 1397855) for XPCshell bustage, at least on Android. r=backout on a CLOSED TREE 2017-09-12 21:42:12 +02:00
Steve Armand
d4bfc7402c Bug 1397855 - Enable py2 and py3 linter on testing/xpcshell. r=ahal
MozReview-Commit-ID: CsfIcI1ma7J

--HG--
extra : rebase_source : 1cdb7a848813a4a4872005095550b74c13ebecdf
2017-09-07 21:15:35 -04:00
Wes Kocher
05c4aba599 Merge m-c to autoland, a=merge CLOSED TREE
MozReview-Commit-ID: 2dRRh6JLTIL
2017-09-11 15:21:36 -07:00
Wes Kocher
e376f14721 Merge inbound to central, a=merge
MozReview-Commit-ID: GDeX9aPb7Fn
2017-09-11 14:41:45 -07:00
Andi-Bogdan Postelnicu
7c7699bdeb Bug 1398767 - Reformat modelling file according to Mozilla coding style. r=sylvestre
MozReview-Commit-ID: DBaSlW9kVsS

--HG--
extra : rebase_source : b2c76bec93c69e3f321e2cc9e4e5dac7f9e5171a
2017-09-11 16:48:25 +03:00
Andi-Bogdan Postelnicu
0adcdd620d Bug 1398781 - Add sanitisation for taint data in the modelling file. r=sylvestre
MozReview-Commit-ID: 9Ssqi3JNXCw

--HG--
extra : rebase_source : 0e0e7857f66a726c0f2dbe0436819fa5ca225fbd
2017-09-12 10:31:48 +03:00
Andi-Bogdan Postelnicu
1b0275dddd Bug 1398712 - update Coverity modelling file in order to support NS_PRECONDITION. r=sylvestre
MozReview-Commit-ID: 3CzHJkjrikI

--HG--
extra : rebase_source : d475beed1b2859110a23c01fced78a2a20493e48
2017-09-11 14:55:37 +03:00
Sylvestre Ledru
10aea37400 Bug 1397457 - Update mach to download clang-format 5.0 - Remove the deprecated comment r=trivial DONTBUILD 2017-09-11 10:07:50 +02:00
Kris Maglione
e99cced382 Bug 1371065: Part 1 - Remove external references to the add-on SDK. r=Mossop,glandium
MozReview-Commit-ID: D5KyHcg8Ujk

--HG--
extra : rebase_source : 1a74ccb2963f2946a49c8bf720af595151b48fd1
2017-09-12 11:54:47 -07:00
Ionut Goldan
f3028165fe Bug 1396217 - resolve py2 and py3 lint errors r=jmaher
MozReview-Commit-ID: LG332HzJKcw

--HG--
extra : rebase_source : b82da0cceac18f310cadf945578464c2fb4704c4
2017-09-08 11:27:26 +03:00
Chris Manchester
c0a229d4c3 Bug 1386876 - Replace all uses of DISABLE_STL_WRAPPING with a template, remove DISABLE_STL_WRAPPING. r=glandium
MozReview-Commit-ID: FMEtb5PY7iP

--HG--
extra : rebase_source : 3cdee7528846462c758e623d6bcd2e6e17dbabff
2017-09-11 11:33:26 -07:00
Sylvestre Ledru
5c735fdea1 Bug 1397457 - Update mach to download clang-format 5.0 r=andi
MozReview-Commit-ID: EF3thvpxg6G

--HG--
extra : rebase_source : e5db9ed4ff526973eea091e3af79cd8aff2fc427
2017-09-06 23:56:34 +02:00
Sebastian Hengst
ec5336561d merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: 3DvwIgw2ORU
2017-09-07 23:59:58 +02:00
Steve Armand
08d5fcd935 Bug 1397423 - Enable py2 linter on python/mozlint. r=ahal
MozReview-Commit-ID: 6QX7YCmfjdJ

--HG--
extra : rebase_source : 0610d67f376c462b0f103a6510f21459fc39f940
2017-09-06 22:52:46 -04:00
Sebastian Hengst
8eb249afcc merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: JSRVc5yW6Kx
2017-09-07 12:39:12 +02:00
Dustin J. Mitchell
d7b6f0148a Bug 1397318: mozlint -l py2 for taskcluster/; r=ahal
MozReview-Commit-ID: 1ZUOrIfxQef

--HG--
extra : rebase_source : c398af2faa83812a70213679d5cb4ad0024d8f7d
2017-09-06 17:29:32 +00:00
Sebastian Hengst
9c8a09d458 merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: KLssMPhSQ0O
2017-09-06 11:26:13 +02:00
Sebastian Hengst
b278f15c7f merge mozilla-central to mozilla-inbound. r=merge a=merge 2017-09-06 00:00:04 +02:00
Cosm
917335fa1c Bug 1395956 - Update gecko.readthedocs links to the new firefox-source-docs.mozilla.org location. r=chutten 2017-09-02 22:11:02 +05:30
Mark Hammond
27afdd11e1 Bug 1396544 - don't schedule syncs when Sync isn't configured. r=rnewman
MozReview-Commit-ID: AM0G43vFyty

--HG--
extra : rebase_source : 9888cfd079f4761debb710d1bbe064956aec1093
2017-09-05 12:40:53 +10:00
Steve Armand
e46ff00709 Bug 1368967 - Enable the ESLint generator-star-spacing rule across mozilla-central. r=standard8
MozReview-Commit-ID: 5do3eoCEAMR

--HG--
extra : rebase_source : 5f692e474e1d7d173fcb4c9c08617f0fe489e443
2017-09-04 00:49:32 -04:00
Ralph Giles
4fa6c9dd7a Bug 1396158 - Remove pocketsphinx references from the build system. r=chmanchester
These were used by b2g and are no longer needed.

MozReview-Commit-ID: DQontDwwlJ5
2017-09-06 08:37:00 -07:00
Marco Castelluccio
ebceaf00d0 Bug 1397505 - Only support dumping/resetting coverage counters with GCC builds. r=froydnj
--HG--
extra : rebase_source : c6f8662eaac48a5d6941db5e582686ce5c6b8a47
2017-09-07 00:31:03 +02:00
Markus Stange
a394514101 Bug 1395524 - Use AppendFloat when converting the float interval to the env var string. r=njn
MozReview-Commit-ID: GsW9W3aJZTg

--HG--
extra : rebase_source : b283e496453f60721570a39c614b61bdeba20e79
2017-08-31 13:36:44 +02:00
Markus Stange
42a2e8caed Bug 1395524 - Add profiler log messages for invalid startup profiling env vars. r=njn
MozReview-Commit-ID: ipWVT6Jh3j

--HG--
extra : rebase_source : 6d8a32ec6770c730a11086ac4701618850c450d7
2017-08-31 13:34:51 +02:00
Mark Hammond
2dad858a21 Bug 1375635 - Add telemetry for how often and long users are in bad authentication states. r=Dexter,rweiss+418169,tcsc
MozReview-Commit-ID: BW8ixM3wmxJ

--HG--
extra : rebase_source : 6872e86fbd6ff00c4ab65ef4bf8c6195e06de54b
2017-07-27 11:59:24 +10:00
Andrew Halberstadt
3411e8b3d4 Bug 1391019 - Add py2 and py3 compatability linters, r=gps
check_compat.py was adapted from gps' check-py3-compat.py in mercurial:
https://www.mercurial-scm.org/repo/hg/file/tip/contrib/check-py3-compat.py

The py3 linter simply runs ast.parse(f) for each file being linted. Any syntax errors
are formatted as mozlint results and dumped to stdout as json. I looked into also
importing the file (using 3.5+'s importlib.util.spec_from_file_location), but there
were too many problems:

1. Lots of false positives (e.g module not found)
2. Some files seemed to run indefinitely on import

I decided to punt on importing for now, we can always investigate in a follow-up.

The py2 linter runs ast.parse(f), and also checks that the file has:
from __future__ import absolute_import, print_function

Initially every python file in the tree is excluded from the py2 check, though
at least this makes it easy to find+fix, and new files in un-excluded
directories will automatically be linted.

MozReview-Commit-ID: ABtq9dnPo9T

--HG--
extra : rebase_source : 60762937284d498514cd020b90cbfd2ba23f0b70
2017-08-31 10:12:02 -04:00
Andrew Halberstadt
3c2a0965ed Bug 1391019 - Move tools/lint/flake_/__init__.py to tools/lint/python/flake8.py, r=gps
This will allow us keep python related linting files in the same place.

MozReview-Commit-ID: ABtq9dnPo9T

--HG--
rename : tools/lint/flake8_/__init__.py => tools/lint/python/__init__.py
rename : tools/lint/flake8_/__init__.py => tools/lint/python/flake8.py
rename : tools/lint/flake8_/flake8_requirements.txt => tools/lint/python/flake8_requirements.txt
extra : rebase_source : 2568bc0bf8f4adbf8e0be73a54d5da068a8d81b0
2017-08-31 10:06:08 -04:00
Andrew Halberstadt
74afe80557 Bug 1339178 - Add python/mach_commands.py and config/mozunit.py to flake8 linter, r=davehunt
MozReview-Commit-ID: Gcsz6z8MeOi

--HG--
extra : rebase_source : 121c9007d336cecbd068075dc54d66cc06e8334e
2017-08-29 14:41:38 -04:00
Markus Stange
b603ba75ee Bug 1393046 - Enable JS sampling on the main thread as soon as possible after the profiler has started. r=njn
MozReview-Commit-ID: CIj3GGI3TQo

--HG--
extra : rebase_source : 5fe72df1f0433313aefa5870a63423656005cbe8
2017-08-29 19:13:57 +02:00
Andrew Halberstadt
c451dcfe84 Bug 1391075 - Add template to modify task env from |mach try fuzzy|, r=dustin
This adds a new morph template for modifying a task's env and the corresponding glue
to specify it from |mach try fuzzy|. It can be used like:

./mach try fuzzy --env FOO=1 --env BAR=baz

This will simply set those environment variables in *all* tasks. We could add the
ability to only specify it for a subset of tasks in the future, but that seems like
a hard problem that probably isn't worth it.

MozReview-Commit-ID: C4sokv886PU

--HG--
extra : rebase_source : 64c9105848e6becd33fae63aeabc3423cfda3bdf
2017-08-25 15:24:22 -04:00