We were being overly cautious, and returning NS_ERROR_FAILURE if the printer name passed
up from the content process didn't map to an existing system printer.
The problem with that is that sometimes there are no registered printers. In that case,
we just need to not set the printer in the NSPrintInfo.
So in the event that we cannot find a printer with the name that the child sent up, we
just leave the printer and printer name fields on the NSPrintInfo blank.
--HG--
extra : commitid : 6N6PJq4K50q
extra : rebase_source : 733c9fac76747bc2a0b177d7b1688e4b673b0e4d
extra : amend_source : 3acf505a51930a5ab951028edeadb12352d024cb
We assume that when an NSURL has been serialized to PrintData, that it has already
been percent encoded. This means that we don't need to re-percent encode it when
we deserialize.
--HG--
extra : commitid : 7Xx00BDxmFk
extra : rebase_source : 03a016ea5f40484c6e357cf940577d4d975d3d3b
extra : amend_source : 2d276f22c295fca2a1a60ce5085f1d71d24ba13a
The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
This patch implements the code which is shared by all platforms for
fullscreen transition.
It adds two prefs for the duration of fullscreen transition. They can
also be used to completely suppress the transition.
In addition, this patch uses the newly added prefs to suppress the
transition in all tests which use the DOM fullscreen.
--HG--
extra : source : 54a8b3b7351af89049825598891fd3a1f98d18af
The old code was just flat-out wrong. The IPDL for getting the LookAndFeel
cache from the parent during child process initialization was passing an
array it wanted to be populated as an argument, rather than using a return
value.
--HG--
extra : commitid : 2baQu56XHdn
extra : rebase_source : 7c45ecafa2ef6adb05bc753e87e354b136030958
extra : amend_source : 7b72c17d964e8b60c7c75a09ae38a28f60985583
This patch implements the code which is shared by all platforms for
fullscreen transition.
It adds two prefs for the duration of fullscreen transition. They can
also be used to completely suppress the transition.
In addition, this patch uses the newly added prefs to suppress the
transition in all tests which use the DOM fullscreen.
--HG--
extra : source : a64f71ea9ceb37acbbfc4e4023880fb244daa738
This conversion was done with the script:
find . -name '*.cpp' -o -name '*.h' -o -name '*.mm' -o -name '*.idl' | \
egrep -v 'cairo-win32-refptr.h|RefPtr.h|TestRefPtr.cpp' | \
xargs sed -i -e 's/mozilla::TemporaryRef</already_AddRefed</g' \
-e 's/TemporaryRef</already_AddRefed</g'
Manual fixups were performed in the following instances:
- We handled mfbt/RefPtr.h manually so as to not convert TemporaryRef itself
into already_AddRefed.
- The following files had explicit Move() calls added to make up for the lack
of a copy constructor on already_AddRefed:
dom/base/ImageEncoder.cpp
dom/media/MediaTaskQueue.{h,cpp}
dom/media/webaudio/PannerNode.cpp
- A redundant overload for MediaTaskQueue::Dispatch was deleted.
- A few manual fixups were required in mfbt/tests/TestRefPtr.cpp.
- Comments, using declarations, and forward declarations relating to
TemporaryRef in dom/canvas/ and gfx/layers/ were changed to refer to
already_AddRefed.
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
PR_LOG_ERROR -> LogLevel::Error
PR_LOG_WARNING -> LogLevel::Warning
PR_LOG_WARN -> LogLevel::Warning
PR_LOG_INFO -> LogLevel::Info
PR_LOG_DEBUG -> LogLevel::Debug
PR_LOG_NOTICE -> LogLevel::Debug
PR_LOG_VERBOSE -> LogLevel::Verbose
Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.
Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
