Commit Graph

179 Commits

Author SHA1 Message Date
Johann Hofmann
ed9da495e6 Bug 1456899 - Consider the page URI when checking WebRTC permissions in webrtcUI.jsm. r=nhnt11
While we already do a permission check in native webrtc code, the one
in webrtcUI is needed to provide extra protection against permission spam
by checking if there's a temporarily denied permission on the tab.

Since we introduced custom default permission values it is necessary to
also pass the URI to make sure we catch exceptions added by the user.

MozReview-Commit-ID: C8r6ymbKE3a

--HG--
extra : rebase_source : 8f0b3486f2f33bee75536ae2cf7dd091c5a9c568
2018-05-08 15:31:49 +02:00
Narcis Beleuzu
2b99556758 Backed out changeset 0c5a4939300c (bug 1454889) for causing frequent Leaks (Bug 1378025). a=backout 2018-05-07 12:06:25 +03:00
Andrea Marchesini
3abafd2746 Bug 1454889 - Remove createObjectURL()'s MediaStream overload, r=valentin 2018-04-24 16:19:51 +02:00
Boris Zbarsky
bf1ef0641d Bug 1444143 part 10. Remove unnecessary QIs to Ci.nsIFrameLoader in JS. r=mystor
nsFrameLoader is on WebIDL bindings, so those QIs are no-ops anyway, unless the given object is no a frameloader to start with.

MozReview-Commit-ID: IPiW70H5NPc
2018-03-21 22:43:17 -04:00
Prathiksha
b360ee3691 Bug 1435160 - Format notification popup description message in a helper function. r=johannh
MozReview-Commit-ID: Bwy2WrbXjUf

--HG--
extra : rebase_source : 7560c426f8e3fbfb102cfcba1ef7f15fc112ec38
2018-02-28 02:01:55 +05:30
Florian Quèze
682b1ec3b2 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Mark Banner
b9f306bb12 Bug 1434449 - Removed some unused code in jsm files in browser/base and browser/modules. r=florian
MozReview-Commit-ID: 9VhKxnpdzCD

--HG--
extra : rebase_source : ecc1f9196a5fb22cf78c51ead89f84e154c5198f
2018-01-30 22:09:02 +00:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Kris Maglione
fc5153a0b5 Bug 1433708: Part 1 - Fix WebRTC innerHTML sanitization. r=mconley
MozReview-Commit-ID: JOkIXajO13O

--HG--
extra : rebase_source : 52f526f8c8eab86c8ff818f32b27aa5fd9172fc3
2018-01-26 10:57:47 -08:00
Johann Hofmann
33cdb5ab49 Bug 1345077 - Part 2 - Add telemetry on permission requests from third party origins, handling user input and insecure contexts. r=florian,liuche
MozReview-Commit-ID: 4ARIxa6gwCg

--HG--
extra : rebase_source : 52935b560f771214a3e47aa9d27ca90d25077718
2018-01-10 21:07:59 +01:00
Prathiksha
213a61bd9b Bug 1369482 - Make hostnames in permission prompts much more prominent. r=johannh
MozReview-Commit-ID: 89m2QVzj8DG

--HG--
extra : rebase_source : 008b55bdc41feddd312f41d0e63bb86262ccd658
2017-12-14 21:00:28 +05:30
Johann Hofmann
15353262e8 Bug 1366357 - Use origin instead of documentURI for WebRTC permission requests. r=florian
MozReview-Commit-ID: IkccA65Ma3a

--HG--
extra : rebase_source : 9c1f2c895949b1dae617b0c2a1039a5494cd8b2a
2017-06-13 12:10:39 +02:00
Brindusan Cristian
2a280abe08 Backed out changeset c6d592ebf8cd (bug 1366357) for browser-chrome failure in browser_displayURI.js on Windows 7 debug non-e10s a=backout r=backout on a CLOSED TREE 2017-12-05 23:50:31 +02:00
Johann Hofmann
807339d354 Bug 1366357 - Use origin instead of documentURI for WebRTC permission requests. r=florian
MozReview-Commit-ID: IkccA65Ma3a

--HG--
extra : rebase_source : 9fbf622f5e3428f9fbfda6f986fcdca814caa181
2017-06-13 12:10:39 +02:00
Mark Banner
f99ae4c2a9 Bug 1421376 - Change various instances of manually calling getService to use Services.jsm in browser/. r=mossop
MozReview-Commit-ID: FW3X2fkOwK2

--HG--
extra : rebase_source : f71e053e18017d675d4ea4d758e2552adcf5adc6
2017-11-28 19:21:33 +00:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Jonathan Kingston
9914e60252 Bug 1272304 - Add disabled state to screen sharing permission r=florian
MozReview-Commit-ID: LsZmQD5fWzW

--HG--
extra : rebase_source : 8bb8a901290ec651c23fbc8a69b323c501587920
2017-08-12 18:54:24 +01:00
Munro Mengjue Chiang
8937814170 Bug 1374640 - always prompt for screen sharing. r=florian,jib
MozReview-Commit-ID: FJvuf2XVZXJ

--HG--
extra : rebase_source : 4c4b00c1128448da6c0d73b032d8629b80ff01c3
2017-06-29 15:50:30 -07:00
Frederik Braun
56838ddb04 Bug 1351608 - Disable warnings for existing violations to no-unsanitize rule r=Standard8.
MozReview-Commit-ID: 7cTNL5jMtRw
2017-07-03 20:07:02 +01:00
Munro Mengjue Chiang
372ce9ac15 Bug 861716 - catch exception thrown from gIndicatorWindow.updateIndicatorState(). r=florian
MozReview-Commit-ID: IUe0iSAOa7h

--HG--
extra : rebase_source : 3b29267b1841d949e3087b10c9c7b304cf5fcb50
2017-06-08 16:05:34 +08:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Kris Maglione
f62862f632 Bug 1358921: Lazily load webrtcUI.jsm when first needed. r=florian
MozReview-Commit-ID: LRtpyBaRCMA

--HG--
extra : rebase_source : 698e702af3893bbbcf544eeb2ef1622072a0b67c
2017-05-02 19:50:20 -07:00
Florian Queze
4c6a68d1c9 Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Florian Queze
37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
159215e6f4 Backed out changeset 18d45aa984d6 (bug 1355161) 2017-04-14 23:39:23 +02:00
Sebastian Hengst
a07223d699 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
95d4d20c17 Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Florian Queze
a363fb8c8b Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Johann Hofmann
141c4f866b Bug 1348257 - Hide the "always remember" checkbox for webrtc prompts in PBM. r=Nihanth
It's important to not remember any user choices made in private mode
(except the ones we specifically mention in the private browsing landing
page). The original idea was to change the checkbox behavior to store
the permission for session duration if in PBM, but this would actually be
inconsistent with the other permission prompts which hide it completely.

MozReview-Commit-ID: 8ioVmE4XefE

--HG--
extra : rebase_source : bddb6fcd9644ba4275b1da8428518285da387c2b
2017-03-20 19:49:59 +01:00
Carsten "Tomcat" Book
468f7d8e9f merge mozilla-inbound to mozilla-central a=merge 2017-03-16 15:35:50 +01:00
Florian Quèze
f55f3ce4a0 Bug 1325049 - Fix the global webrtc sharing indicator to work with multiple content processes, r=felipe. 2017-03-15 22:47:06 +01:00
Nihanth Subramanya
bdfa7e2a7c Bug 1339848 - Simplify the string used to indicate that permanent access to the screen cannot be granted. r=florian
MozReview-Commit-ID: I5CqUq6QNl7

--HG--
extra : rebase_source : e849a1e5205525d65bc9d50555402fda8b8dafe2
2017-03-13 19:33:41 +05:30
Nihanth Subramanya
21315d8d98 Bug 1345079 - Allowing screensharing with no screen selected should not block the camera. r=johannh
MozReview-Commit-ID: JKYaDGyL5t

--HG--
extra : rebase_source : 30d5db11a09d41b0bbffc6acd0a7edda4eb6448b
2017-03-14 01:19:14 +05:30
Johann Hofmann
eda5a50a7f Bug 1331579 - Explicitly update the identity block on re-requesting expired permissions. r=Paolo
MozReview-Commit-ID: CxvHSp1NjFg

--HG--
extra : rebase_source : 58e6f5b8020c01fad8da2b29e78a0c69bb78cb63
2017-01-23 11:44:03 +01:00
Florian Quèze
0e0865f4fc Bug 1331599 - script-generated patch to replace removeEventListener calls with the once option when possible, r=jaws. 2017-01-25 07:01:52 +01:00
Munro Mengjue Chiang
e880c00d03 Bug 1332608 - Fix JavaScript error in webrtcUI.jsm: nsIMessageListenerManager.removeMessageListener: Not enough arguments; r=florian
MozReview-Commit-ID: LHzfrUpFGVy

--HG--
extra : rebase_source : 146b7cc5d7281a7b0c8c0531cd73ccd8e525f0a0
2017-01-23 15:22:30 +08:00
Nihanth Subramanya
7e904b701f Bug 1323420 - Add a pref to control the close button on web permission prompts. r=past
MozReview-Commit-ID: JHEY478q3C

--HG--
extra : rebase_source : 402b02863e95f0cae9f6aaacc5f0645f31ca02b1
2017-01-16 18:08:07 +05:30
Florian Quèze
003354e62f Bug 1329976 - make the microphone prompt select the same device by default all the time by clearing the leftover value from previous prompts, r=johannh. 2017-01-20 12:50:14 +01:00
Munro Mengjue Chiang
f0be461749 Bug 1270572 - allow un-prompted gUM access if the page has a live track connected to the same device; r=florian,gcp,smaug
MozReview-Commit-ID: EvATqR4NNTH

--HG--
extra : rebase_source : cf3b08d7f47e8239bdb6ed27a2eaacb491200d48
2017-01-19 12:24:59 +08:00
Phil Ringnalda
5a78aec0aa Merge m-i to m-c, a=merge 2017-01-16 13:18:17 -08:00
Paolo Amadini
e33311d3f7 Bug 1319112 - Adjust strings for the WebRTC permission notifications. r=florian
MozReview-Commit-ID: 98jRli5Cqxy

--HG--
extra : rebase_source : b3dc18f98c2749c75ccac910693033993e267e2f
2017-01-16 14:31:23 +01:00
Johann Hofmann
95370d69a3 Bug 1206232 - Add temporary permission states to SitePermissions.jsm. r=jdm,Paolo
MozReview-Commit-ID: zQVeEHhIax

--HG--
extra : rebase_source : bebcd31cfbd638c51ff21c7e2b62bcc536b026da
2016-09-22 23:09:30 +02:00
Florian Quèze
028a82f682 Bug 1329182 - remove trailing newURI null parameters in browser/, r=jaws. 2017-01-09 20:27:25 +01:00
Jared Wein
9141469edf Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe

--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
2016-12-30 21:47:25 -05:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00