Commit Graph

712 Commits

Author SHA1 Message Date
John Dai
3a77b15ccb Bug 1589027 - Fix object.tabIndex should return 0 by default; r=smaug
The spec change HTMLObjectElement tabIndex default to 0, but `test_object_plugin_nav.html` will fail due to HTMLObjectElement’s sequence focus and .focus() rely on default tabIndex. In this patch I separate the logic to not rely on default tabIndex for HTMLObjectElement's plugin type and align the spec.

Differential Revision: https://phabricator.services.mozilla.com/D50801

--HG--
extra : moz-landing-system : lando
2019-10-28 15:50:59 +00:00
Matthew Noorenberghe
19fc89710d Bug 1583957 - Indicate support for autocomplete=(username|new-password|current-password). r=farre
Bug 917325 started using the `username` token.
Bug 1119063 started using the `new-password` token. This patch also adds support for `current-password` since it's the counterpart to `new-password` and we plan to use it as a signal eventually so want to encourage its use.

Differential Revision: https://phabricator.services.mozilla.com/D50351

--HG--
extra : moz-landing-system : lando
2019-10-24 12:45:24 +00:00
Geoff Brown
32490358c2 Bug 1585119 - Re-enable many more mochitests on Android; r=geckoview-reviewers,snorp
Most of these tests have been disabled for a long time; they run well
in the current test environment.
I intend to enable still more mochitests in a future patch.

Differential Revision: https://phabricator.services.mozilla.com/D49524

--HG--
extra : moz-landing-system : lando
2019-10-18 14:35:20 +00:00
Geoff Brown
c906073cd5 Bug 1585119 - Re-enable many mochitests on android; r=geckoview-reviewers,snorp
Most of these tests have been disabled for a long time; they run well
in the current test environment.
With the additional tests running, task times increase; I have added one
more test chunk for android mochitest-plain.
These tests were identified from a random sampling of mochitest manifests;
I intend to enable more mochitests in future patches.

Differential Revision: https://phabricator.services.mozilla.com/D48912

--HG--
extra : moz-landing-system : lando
2019-10-15 15:07:09 +00:00
Andreea Pavel
c45f72ed14 Bug 1533759 - update test_window_open_close.html disable condition for windows64 debug. r=bc
Differential Revision: https://phabricator.services.mozilla.com/D48925

--HG--
extra : moz-landing-system : lando
2019-10-11 13:45:19 +00:00
Ehsan Akhgari
ff268df84b Bug 1546112 - Remove the code for XMLDocument.load/async; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D48877

--HG--
extra : moz-landing-system : lando
2019-10-10 18:20:34 +00:00
Edgar Chen
534d501cf9 Bug 1129227 - Part 3: Add test for requesting fullscreen in async callback; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D47152

--HG--
extra : moz-landing-system : lando
2019-10-07 08:54:40 +00:00
Edgar Chen
37dc0de88e Bug 1129227 - Part 2: Switch Fullscreen to use transient-user-activation API; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D47151

--HG--
extra : moz-landing-system : lando
2019-09-30 13:42:40 +00:00
Cosmin Sabou
cb6b4f7b5b Bug 1533759 - Disable test_window_open_close.html on windows64 debug. r=bc
Differential Revision: https://phabricator.services.mozilla.com/D47570

--HG--
extra : moz-landing-system : lando
2019-09-30 13:10:06 +00:00
Anny Gakhokidze
f1c694e18f Bug 1582531 - Update fission annotations for skipped tests that are now passing succesfully, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D47347

--HG--
extra : moz-landing-system : lando
2019-09-27 14:25:10 +00:00
Brindusan Cristian
1991bac5a6 Backed out 3 changesets (bug 1129227) for wpt failures at active-lock.html. CLOSED TREE
Backed out changeset 44219f4bafb0 (bug 1129227)
Backed out changeset 69f7db4e75bf (bug 1129227)
Backed out changeset 3edc8921609b (bug 1129227)
2019-09-27 03:53:36 +03:00
Edgar Chen
5925e241a9 Bug 1129227 - Part 3: Add test for requesting fullscreen in async callback; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D47152

--HG--
extra : moz-landing-system : lando
2019-09-26 21:15:47 +00:00
Edgar Chen
7bf4c68bf5 Bug 1129227 - Part 2: Switch Fullscreen to use transient-user-activation API; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D47151

--HG--
extra : moz-landing-system : lando
2019-09-26 21:15:43 +00:00
Henri Sivonen
b5140cd3ca Bug 1583169 - Enable test_bug871161.html in Fission. r=farre
Differential Revision: https://phabricator.services.mozilla.com/D46770

--HG--
extra : moz-landing-system : lando
2019-09-23 12:05:02 +00:00
Valentin Gosu
9be69aefcb Bug 1580750 - Enable more fission tests r=JuniorHsu
Differential Revision: https://phabricator.services.mozilla.com/D46175

--HG--
extra : moz-landing-system : lando
2019-09-17 19:35:00 +00:00
Mats Palmgren
616c110e54 Bug 400258 - Use the padding edge as the origin for offsetLeft/offsetTop also for box-sizing:border-box boxes. r=emilio
This is what the spec says and is compatible with other UAs.
https://drafts.csswg.org/cssom-view/#dom-htmlelement-offsetleft

Differential Revision: https://phabricator.services.mozilla.com/D45621

--HG--
extra : moz-landing-system : lando
2019-09-12 07:35:43 +00:00
Kris Maglione
165096efe5 Bug 1579820 - Handle window.open() from remote subframes. r=nika
The CommonCreateWindow code requires having a BrowserHost for the tab that's
creating the window, which it tries to get from the requestor's BrowserParent.
For remote BrowserParents, though, there is no BrowserHost, so we need to get
it from the top-level embedder instead.

Differential Revision: https://phabricator.services.mozilla.com/D45172

--HG--
extra : moz-landing-system : lando
2019-09-10 09:04:17 +00:00
Geoff Brown
56ca134785 Bug 1579272 - Cleanup obviously fennec-centric test annotations; r=bc
Remove test manifest annotations that specifically target fennec,
or likely target the android 4.3 emulator.

Differential Revision: https://phabricator.services.mozilla.com/D45018

--HG--
extra : moz-landing-system : lando
2019-09-06 16:51:10 +00:00
Gijs Kruitbosch
9f3a3e9669 Bug 1578709 - Only set flash only pref for those tests that need it, r=mconley,ahal
Differential Revision: https://phabricator.services.mozilla.com/D44648

--HG--
extra : moz-landing-system : lando
2019-09-04 22:12:39 +00:00
Gurzau Raul
f96e9cd73f Backed out changeset 887d125d7f59 (bug 1578709) for failing at test_bug427744.html on a CLOSED TREE. 2019-09-04 21:34:11 +03:00
Gijs Kruitbosch
bb899238e7 Bug 1578709 - Only set flash only pref for those tests that need it, r=mconley,ahal
Differential Revision: https://phabricator.services.mozilla.com/D44648

--HG--
extra : moz-landing-system : lando
2019-09-04 17:28:02 +00:00
Andreea Pavel
340bdf15cf Bug 1533759 - disabled test_window_open_close.html on linux64 qr r=intermittent-reviewers,gbrown
Differential Revision: https://phabricator.services.mozilla.com/D44305

--HG--
extra : moz-landing-system : lando
2019-09-03 15:34:45 +00:00
Mark Banner
709c7ccf0c Bug 1577746 - Automatically enable more ESLint rules for dom/. r=baku
This enables:
- mozilla/no-useless-parameters
- mozilla/no-useless-run-test
- no-extra-boolean-cast
- no-unneeded-ternary

Depends on D44150

Differential Revision: https://phabricator.services.mozilla.com/D44151

--HG--
extra : moz-landing-system : lando
2019-09-02 11:23:26 +00:00
Mark Banner
acd70816c6 Bug 1577746 - Enable ESLint rule dot-notation for dom/. r=baku
Depends on D44149

Differential Revision: https://phabricator.services.mozilla.com/D44150

--HG--
extra : moz-landing-system : lando
2019-09-02 11:23:05 +00:00
Mark Banner
351d147e2f Bug 1577746 - Enable ESLint rule object-shorthand for dom/. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D44149

--HG--
extra : moz-landing-system : lando
2019-09-02 11:22:27 +00:00
Kris Maglione
f93c2909dd Bug 1573254: Part 2 - Update tests to await snapshotWindow when necessary. r=mccr8
This fixes several tests which snapshot remote windows under Fission. It also
changes some other arbitrary tests that don't use remote windows, which I
changed before I gave up on having an always-async API.

Differential Revision: https://phabricator.services.mozilla.com/D41630

--HG--
extra : rebase_source : 6203b7065f7651e6ed4a2695ff2bd92daec70634
2019-08-12 12:56:25 -07:00
Emilio Cobos Álvarez
da047c3d7f Bug 1567191 - Move datetime input widget attribute handling code to HTMLInputElement. r=smaug
It's the only sound place now that we use Shadow DOM, since the widget exists
when we have no frames.

Differential Revision: https://phabricator.services.mozilla.com/D40509
2019-08-05 22:11:57 +02:00
Emilio Cobos Álvarez
84e7522250 Bug 1561787 - Make readonly date / time input clear button disabled. r=smaug
The time input widget was missing a call to updateEditAttributes which was
caught by the test, which can be seen without this patch by going to:

data:text/html,<input type="time" disabled value="20:40">

Toggling the 'disabled' attribute back and forth fixes the rendering.

Differential Revision: https://phabricator.services.mozilla.com/D40503
2019-08-05 22:11:56 +02:00
Emilio Cobos Álvarez
aef0223323 Bug 1461509 - Don't allow clearing fields in date / time inputs when using backspace if disabled or readonly. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D40485
2019-08-05 22:11:55 +02:00
Hiroyuki Ikezoe
2feab69a17 Bug 1498729 - Store each viewport meta data by the viewport meta tag and use the last one. r=smaug,botond
This is what Chrome and Safari do.
See https://webcompat.com/issues/20701#issuecomment-436054739


So for exmaple, if there are two viewport meta tags like this;

 <meta name="viewport" content="width=980">
 <meta name="viewport" content="initial-scale=1,maximum-scale=1">

We will use "initial-scale=1,maximum-scale=1".  Before this change we used to
use merged "width=980,initial-scale=1,maximum-scale=1".

Another example is to replace the content of a single viewport meta tag like this;

 <meta id="viewport" name="viewport" content="width=device-width, initial-scale=1">

what will happen when this tag is replaced by below;

 <meta id="viewport" name="viewport" content="width=1080">

We will use the replacing one (i.e. "width=1080"), before this change, we used
to use merged "width=1080,initial-scale=1".

As of this commit, we don't properly remove corresponding viewport meta data
when a) viewport meta tag is detached from document and b) `name` attribute is
changed from 'viewport'.  These cases will be handled in subsequent commits.

Note that we no longer store invididual viewport meta data in Document::mHeaderData
so that nsIDOMWindowUtils.getDocumentMetadata doesn't work any more for the
invididual viewport meta data, but there is no use cases for them other than
two test cases which are removed in this commit.

Differential Revision: https://phabricator.services.mozilla.com/D38922

--HG--
extra : moz-landing-system : lando
2019-07-25 20:51:23 +00:00
François Freitag
b81795066d Bug 1479708 - Hide required date time input reset button. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D39315

--HG--
extra : moz-landing-system : lando
2019-07-25 10:28:52 +00:00
Andreea Pavel
442c23063f Backed out changeset a506f9517ba2 (bug 1479708) for failing test_input_datetime_reset_button.html on a CLOSED TREE 2019-07-25 12:44:04 +03:00
François Freitag
e66c63b690 Bug 1479708 - Hide required date time input reset button. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D38624

--HG--
extra : moz-landing-system : lando
2019-07-25 07:26:13 +00:00
Kris Maglione
4bd4d680d4 Bug 1566952: Part 1 - Annotate mochitests that crash with Fission enabled. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D38725

--HG--
extra : rebase_source : 3e8b32b86b12b22d038baa770070a5c8095043c9
2019-07-17 13:37:48 -07:00
Kris Maglione
0962c2b731 Bug 1566182: Annotate mochitests that fail with Fission enabled. r=mccr8
My preference was to annotate most of the failing tests with `fail-if` so that
if they start passing, the `fail-if` needs to be removed and they need to keep
passing. That doesn't work for tests that timeout, or which trigger failures
from their cleanup functions, however, so those tests need skip-if. And tests
with fail in their cleanup functions likely leave the browser in an
inconsistent state for subsequent tests, anyway, so really should be skipped
regardless.

There are some remaining tests which still fail because of crashes. I chose
not to skip them here, but to fix the crashes in separate bugs instead.

Differential Revision: https://phabricator.services.mozilla.com/D38247

--HG--
extra : rebase_source : 39ba8fec2e882cfe577c5f2b58ab7e4b461f1178
2019-07-15 16:19:32 -07:00
Emilio Cobos Álvarez
3edc8a6c5f Bug 1218456 - Remove now-unneeded workarounds in cross-origin navigation tests. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D37425
2019-07-09 23:10:01 +02:00
Oana Pop Rus
be31b693a5 Backed out changeset 60e865d21df5 (bug 1218456)for Crashtest failures on dom/l10n/tests/mochitest/dom_localization/test_overlay.html. CLOSED TREE 2019-07-09 23:46:04 +03:00
Emilio Cobos Álvarez
0881efe1c6 Bug 1218456 - Remove now-unneeded workarounds in cross-origin navigation tests. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D37425

--HG--
extra : moz-landing-system : lando
2019-07-09 16:18:54 +00:00
Victor Porof
0a8ff0ad85 Bug 1561435 - Format dom/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35951

--HG--
extra : source : 62f3501af4bc1c0bd1ee1977a28aee04706a6663
2019-07-05 10:44:55 +02:00
Kris Maglione
b459f53a11 Bug 1561061: Move SpecialPowers pref env code to parent and make sane-ish. r=aswan
Differential Revision: https://phabricator.services.mozilla.com/D35706

--HG--
extra : rebase_source : ec33af8c17048c3828d4ca4643e2e17bd2a854c0
extra : source : c2d0956f41d82e76c682f829807e818863cd802a
2019-06-24 13:47:53 -07:00
Kris Maglione
fd61f8b9d4 Bug 1541557: Part 7 - Convert SpecialPowers to use JSWindowActors rather than framescripts. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D35057

--HG--
rename : testing/specialpowers/content/SpecialPowersObserverAPI.jsm => testing/specialpowers/content/SpecialPowersAPIParent.jsm
rename : testing/specialpowers/content/SpecialPowers.jsm => testing/specialpowers/content/SpecialPowersChild.jsm
rename : testing/specialpowers/content/SpecialPowersObserver.jsm => testing/specialpowers/content/SpecialPowersParent.jsm
extra : rebase_source : f3edaf8edc918bb4291b66cb50f4de117f57b2bd
extra : source : 46ff845a7b0cdabf640bb2e3c783735ab68b7cd1
2019-06-12 10:48:29 -07:00
Kris Maglione
f70e67ad2d Bug 1541557: Part 4 - Stop relying on synchronous preference getters/setters. r=nika
The SpecialPowers set*Pref/get*Pref APIs currently use synchronous messaging
to set and get preference values from the parent process. Aside from directly
affecting callers of those APIs, it also affects callers of `pushPrefEnv`,
which is meant to be asynchronous, but is in practice usually synchronous due
to the synchronous messaging it uses.

This patch updates the getPref APIs to use the in-process preference service
(which most callers are expecting anyway), and also updates the callers of
the setPref and pushPrefEnv APIs to await the result if they're relying on it
taking effect immediately.

Unfortunately, there are some corner cases in tests that appear to only work
because of the quirks of the current sync messaging approach. The synchronous
setPref APIs, for instance, trigger preference changes in the parent
instantly, but don't update the values in the child until we've returned to
the event loop and had a chance to process the notifications from the parent.
The differnce in timing leads some tests to fail in strange ways, which this
patch works around by just adding timeouts.

There should be follow-ups for test owners to fix the flakiness.

Differential Revision: https://phabricator.services.mozilla.com/D35054

--HG--
extra : rebase_source : 941298157e7c82f420cf50ce057154ce9b85301c
extra : source : 189dc8a359815e059a4a217f788d183260bb2bfe
2019-06-13 09:34:39 -07:00
Mark Banner
201255ab84 Bug 1558485 - Turn on ESLint for all of dom/ disabling most of the failing rules. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D34761

--HG--
extra : moz-landing-system : lando
2019-06-13 20:21:46 +00:00
Jonathan Kingston
a5ba216f93 Bug 1315460 - Removal of keygen element r=keeler,baku,jld,hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D22810

--HG--
extra : moz-landing-system : lando
2019-06-13 08:58:07 +00:00
Olli Pettay
05d684ebd3 Bug 1558546, ensure range element has a frame before starting drag operation, r=hsivonen
This should be the minimal patch to fix the issue (should be safe for branches too).

Reusing an existing mouse/touch test for the crash testing.

Differential Revision: https://phabricator.services.mozilla.com/D34717

--HG--
extra : moz-landing-system : lando
2019-06-12 15:53:48 +00:00
Mark Banner
ea1728721a Bug 1558527 - Fix various issues related to shadowing of variables in dom/ code. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D34588

--HG--
extra : moz-landing-system : lando
2019-06-12 08:29:58 +00:00
Nika Layzell
b5b7f6b728 Bug 1451455 - Fire the 'load' event on out-of-process iframes, r=rhunt
This is done by sending a message over PBrowser and PBrowserBridge when the
event would fire to fire it in the correct process.

Differential Revision: https://phabricator.services.mozilla.com/D33083

--HG--
extra : moz-landing-system : lando
2019-06-06 14:57:17 +00:00
Emilio Cobos Álvarez
1e7b303431 Bug 1539469 - Make all input elements display: inline-block, for compat with other UAs. r=mats
See https://github.com/whatwg/html/issues/4082 for the data and some comments
from Boris and David.

I didn't look into fixing the font-inflation reftests, see bug 1540176 for that.

Differential Revision: https://phabricator.services.mozilla.com/D25566

--HG--
extra : moz-landing-system : lando
2019-06-04 15:39:47 +00:00
Andrea Marchesini
176b3f8e39 Bug 1556419 - cookie path should not contain the last '/', r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D33500

--HG--
extra : moz-landing-system : lando
2019-06-04 02:42:57 +00:00
Makoto Kato
10d8e97c57 Bug 1556330 - Turn on test_input_number_l10n.html and test_input_number_validation.html on Android. r=smaug
This tests are passed since ICU is already turned on Android.

Differential Revision: https://phabricator.services.mozilla.com/D33463

--HG--
extra : moz-landing-system : lando
2019-06-03 09:53:57 +00:00