221 Commits

Author SHA1 Message Date
Julian Descottes
d049bb7498 Bug 1609100 - [devtools] Remove unused about:devtools page r=devtools-reviewers,fluent-reviewers,flod,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D141464
2022-03-28 11:12:06 +00:00
Norisz Fay
66797d7700 Backed out 5 changesets (bug 1609100) for causing mochitest failures on browser_check_identity_state.js CLOSED TREE
Backed out changeset 521cbbae0914 (bug 1609100)
Backed out changeset e22daee724f0 (bug 1609100)
Backed out changeset e5c4afe5dd66 (bug 1609100)
Backed out changeset e6ae2c01908e (bug 1609100)
Backed out changeset 3e59351660ab (bug 1609100)
2022-03-28 13:11:58 +03:00
Julian Descottes
db5d601b00 Bug 1609100 - [devtools] Remove unused about:devtools page r=devtools-reviewers,fluent-reviewers,flod,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D141464
2022-03-28 08:57:36 +00:00
Nick Alexander
d917365044 Bug 1686344 - Support --backgroundtask --jsdebugger (and --wait-for-jsdebugger). r=mossop,jdescottes
Background task mode is roughly equivalent to `xpcshell`, but inside
the regular browser startup flow.  There is no browser window (no
`Window` at all) and there should be no content processes.  It's
sufficient to treat it like `xpcshell`, with its own stripped-down
actor and a few tweaks to the integration points.

The structural changes in this commit keep `--backgroundtask` mode
slim in the regular case when the Devtools are *not* requested.  This
is reflected in the small changes needed to the
`browser_xpcom_graph_wait.js` test: loading the Devtools
unconditionally causes a huge amount of code to be loaded.  In order
to load the Devtools framework conditionally, we check for
Devtools-specific command line flags and delegate to Devtools when
appropriate.  In order to check the command line flags, we turn the
`BackgroundTasksManager` into an XPCOM service, which allows it to be
instantiated by XPCOM in order to handle the command line.

One final note: this leaves two XPCOM components, "backgroundtasks"
and "backgroundtasksmanager".  Why not combine them?  This is
technically possible but not attractive: we really do want a natural
place for native/C++ code ("backgroundtasks") and JavaScript code
("backgroundtasksmanager").

Differential Revision: https://phabricator.services.mozilla.com/D129771
2022-03-03 03:38:39 +00:00
Nick Alexander
b415214de0 Bug 1741978 - Clean up at shutdown after --start-debugger-server. r=devtools-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D139152
2022-03-03 03:38:39 +00:00
Jan Odvarko
6da05abb10 Bug 1753426 - [devtools] Fix documentation links in the source code r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D137748
2022-02-07 13:08:10 +00:00
Norisz Fay
f20c5c07db Backed out changeset 3e8efb4985f7 (bug 1753426) for causing multiple devtools failures 2022-02-04 16:17:25 +02:00
Jan Odvarko
0d6fafe87e Bug 1753426 - [devtools] Fix documentation links in the source code r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D137748
2022-02-04 11:40:50 +00:00
Neil Deakin
5f1ff58926 Bug 371900, remove more now-unneeded empty oncommand attributes, r=bgrins,preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D135243
2022-01-11 20:02:30 +00:00
criss
e2948093fb Backed out 2 changesets (bug 371900) for causing bug 1749182 . CLOSED TREE
Backed out changeset e59035c65af3 (bug 371900)
Backed out changeset 6434bce9c7d4 (bug 371900)
2022-01-09 16:26:02 +02:00
Neil Deakin
64a4726936 Bug 371900, remove more now-unneeded empty oncommand attributes, r=bgrins,preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D135243
2022-01-08 18:07:21 +00:00
Patrick
ab5ce94360 Bug 1743102 Added color-scheme meta tag to remaining about: pages r=Gijs,necko-reviewers,robwu
Differential Revision: https://phabricator.services.mozilla.com/D133743
2021-12-17 00:42:23 +00:00
Butkovits Atila
c408716df0 Backed out changeset f2f23757c34f (bug 1743102) for causing node failures. CLOSED TREE 2021-12-16 19:23:43 +02:00
Patrick
7aeecb4714 Bug 1743102 Added color-scheme meta tag to remaining about: pages r=Gijs,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D133743
2021-12-16 16:30:30 +00:00
Eemeli Aro
453a3f26f0 Bug 1733496 - Migrate key-shortcuts.properties to Fluent. r=jdescottes,fluent-reviewers
This adds `Localization` to `builtin-modules.js` to make it accessible from
`definitions.js`. It's likely that the abstractions used in `definitions.js`
will need to be revisited when `startup.properties` is also migrated to Fluent.

Differential Revision: https://phabricator.services.mozilla.com/D131219
2021-11-18 16:40:03 +00:00
Julian Descottes
212faeb0c3 Bug 1741369 - [devtools] Update paths to loader files in devtools/ r=ochameau
Depends on D131216

Differential Revision: https://phabricator.services.mozilla.com/D131217
2021-11-17 12:43:26 +00:00
Hannah Peuckmann
09b6c3a033 Bug 1567443 - Added flag for indicating secure Chrome UI in nsIAboutModule. r=pbz,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D128188
2021-10-26 13:32:31 +00:00
Cristian Tuns
0b4f04d43f Backed out changeset 177e6f28d348 (bug 1567443) for causing mochitest failures on browser_check_identity_state.js. CLOSED TREE 2021-10-25 06:45:43 -04:00
Hannah Peuckmann
06382f1212 Bug 1567443 - Using nsIAboutModule flag instead of regex to indicate secure about page. r=pbz,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D128188
2021-10-25 09:34:06 +00:00
pestanoah
43b771187b Bug 1724284 - Renamed Browser Tools id to browserToolsMenu. r=mhowell,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D125331
2021-10-13 14:19:02 +00:00
Julian Descottes
28ed5009f5 Bug 1721692 - [devtools] Wait for presShell in browser_aboutdevtools tests r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D122726
2021-08-18 08:17:59 +00:00
Sam Foster
ba9f1e0d39 Bug 1719463 - Part 10: Remove the devtools button from the pre-proton appMenu view. r=jdescottes,Gijs,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D121810
2021-08-10 05:29:33 +00:00
danfragoso
b231099850 Bug 1703167 - [devtools] Replaces aboutdevtools footer-link display to inline. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D118996
2021-07-09 09:43:53 +00:00
Emma Malysz
47957a154b Bug 1703150, ensure dev tools subview is shown when opening developer tools panel r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D118773
2021-06-25 18:50:47 +00:00
Gijs Kruitbosch
cd50b177a7 Bug 1711523 - remove private proton tracking flags in frontend modules, r=mak,emalysz,desktop-theme-reviewers,harry
Differential Revision: https://phabricator.services.mozilla.com/D116009
2021-05-28 19:33:38 +00:00
Csoregi Natalia
a76b78d543 Backed out changeset e01ec8694924 (bug 1700957) as requested. CLOSED TREE 2021-04-28 18:09:01 +03:00
Vaidehi
58837e6f66 Bug 1703154 - Reduce the height of rectangular white background of mobile-device-image. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D113424
2021-04-28 05:53:29 +00:00
Emma Malysz
ce84c86379 Bug 1700957, graduate browser.proton.doorhangers.enabled pref to main proton pref r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D110135
2021-04-28 03:17:56 +00:00
Butkovits Atila
9597a30fbb Backed out changeset 1c362512f27b (bug 1700957) for causing failures at test_chrome_only_media_queries.html. CLOSED TREE 2021-04-28 05:55:14 +03:00
Emma Malysz
a344c0fa4c Bug 1700957, graduate browser.proton.doorhangers.enabled pref to main proton pref r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D110135
2021-04-28 00:29:45 +00:00
vishal
c522064a08 Bug 1702124 - [devtools] Fix the checkbox cut by the image near it issue. r=Honza
Depends on D110659

Differential Revision: https://phabricator.services.mozilla.com/D111055
2021-04-07 11:42:38 +00:00
Tim Nguyen
8a016c64aa Bug 1701448 - Tweak in-content page styling further for Proton. r=desktop-theme-reviewers,dao
* Update green color used for success
* Fix actions menulist alignment
* Make various elements use new accent colors
* Fix lack of border on HTML checkboxes
* Update various colors to proton colors
* Update input border-radius to 4px
* Update border colors

Differential Revision: https://phabricator.services.mozilla.com/D110033
2021-04-05 19:42:47 +00:00
Csoregi Natalia
a359b4f2f6 Backed out 2 changesets (bug 1701448, bug 1699917) for failures on browser_parsable_css.js. CLOSED TREE
Backed out changeset 3693f90f395d (bug 1701448)
Backed out changeset 99ce41916bb2 (bug 1699917)
2021-04-05 22:08:42 +03:00
Tim Nguyen
7772ba544e Bug 1701448 - Tweak in-content page styling further for Proton. r=desktop-theme-reviewers,dao
* Update green color used for success
* Fix actions menulist alignment
* Make various elements use new accent colors
* Fix lack of border on HTML checkboxes
* Update various colors to proton colors
* Update input border-radius to 2px
* Update border colors

Differential Revision: https://phabricator.services.mozilla.com/D110033
2021-04-05 16:29:18 +00:00
Alexandre Poirot
c8f91a99da Bug 1699493 - [devtools] Migrate WebExtInspectedWindow front to a command. r=nchevobbe,rpl
- implement the new "inspected-window" command
- move WebExtensionInspectedWindowFront implement to the command, making the front empty
- migrate tests to use the commands instead of front
- stop maintaining the current top level target in ExtensionParent.jsm, no longer have to use watchTargets
- stop creating a new descriptor on each new target
- instead only pull one new dedicated "commands" for WebExt (still in ExtensionParent.jsm)
- remove TabDescriptor isDevToolsExtensionContext as we no longer need anything special in the descriptor
- remove now unused methods on DevToolsShims (createWebExtensionInspectedWindowFront, createDescriptorForTabForWebExtension)
- remove the now unused TabDescriptorFactory.createDescriptorForTab's "forceCreationForWebextension" option, as CommandsFactory.forTab always instantiate a brand new commands
- migrate webext to use the command instead of front

Differential Revision: https://phabricator.services.mozilla.com/D108994
2021-04-01 10:31:43 +00:00
ankur
32bf182577 Bug 1695253 - Replaced DTD/xhtml1-strict.dtd which lead to broken network loads. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D109379
2021-03-24 16:52:06 +00:00
Alexandre Poirot
ded026f627 Bug 1700106 - [devtools] Remove now-useless eslint files related to mochitests. r=jdescottes,Standard8
I kept a few having some overrides. But they may be irrelevant.
And I kept some eslint files for all folder that aren't matching the pattern matching "**/test*/**/browser*/".
Ideally we would rename these folder to match.

Last but not least, I identified one case where we were using mochitest file for xpcshell tests!

Differential Revision: https://phabricator.services.mozilla.com/D109481
2021-03-23 15:51:18 +00:00
Alexandre Poirot
d43cb93f72 Bug 1700106 - [devtools] Remove the balanced-observers eslint disabling from DevTools mochitests. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D109476
2021-03-23 15:51:17 +00:00
Micah Tigley
0b398068bf Bug 1694277 - DevTools button should show the "More Tools" panel view. r=jdescottes,mconley
Differential Revision: https://phabricator.services.mozilla.com/D106558
2021-03-22 21:23:40 +00:00
Julian Descottes
4d4fd23226 Bug 1694906 - [devtools] Add new option to createDescriptorForTab to support devtools webextensions r=rpl,ochameau
Depends on D106426

Without this patch queue, `createDescriptorForTab` was not caching its descriptors, so each call to it would yield a new descriptor.
Since the webextension codebase really needs to use a different target from the one used by the DevTools toolbox, suddenly sharing the Toolbox's descriptor was an issue.

Addressing it with an explicit parameter to make this expectation from the webextension codebase a bit clearer for us.

Differential Revision: https://phabricator.services.mozilla.com/D107052
2021-03-10 18:22:03 +00:00
Narcis Beleuzu
e783ef6d6e Backed out 5 changesets (bug 1694906) for dt failures on browser_target_list_frames.js . CLOSED TREE
Backed out changeset bd5cb6f8b41f (bug 1694906)
Backed out changeset c23343373584 (bug 1694906)
Backed out changeset 02428006de51 (bug 1694906)
Backed out changeset 284e000deded (bug 1694906)
Backed out changeset 3b5269fe0113 (bug 1694906)
2021-03-10 04:52:56 +02:00
Julian Descottes
7d14461043 Bug 1694906 - [devtools] Add new option to createDescriptorForTab to support devtools webextensions r=rpl,ochameau
Depends on D106426

Without this patch queue, `createDescriptorForTab` was not caching its descriptors, so each call to it would yield a new descriptor.
Since the webextension codebase really needs to use a different target from the one used by the DevTools toolbox, suddenly sharing the Toolbox's descriptor was an issue.

Addressing it with an explicit parameter to make this expectation from the webextension codebase a bit clearer for us.

Differential Revision: https://phabricator.services.mozilla.com/D107052
2021-03-09 20:50:42 +00:00
Mattias de los Rios Rogers
feb953fcf9 Bug 1695255 - Fixed capitalization of DevtoolsStartup. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D106969
2021-03-03 09:29:07 +00:00
Jens Stutte
05581ddca4 Bug 1678330: Ensure nested SpinEventLoopUntil(OrShutdown) calls are traceable to the originating source in case of crash. r=nika,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D106839
2021-03-02 22:11:58 +00:00
Cosmin Sabou
b2eb620ed0 Backed out changeset 03cae7800b41 (bug 1678330) for mochitest plain failures on test_window_open_discarded_bc.html. CLOSED TREE 2021-03-02 20:18:21 +02:00
Jens Stutte
a0af9ea0a4 Bug 1678330: Ensure nested SpinEventLoopUntil(OrShutdown) calls are traceable to the originating source in case of crash. r=nika,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D106839
2021-03-02 15:15:20 +00:00
Gijs Kruitbosch
109ba19200 Bug 1686929 - only show the inspect a11y properties menuitem for devtools users, r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D105086
2021-03-01 10:28:01 +00:00
Julian Descottes
6ead96bb08 Bug 1694140 - [devtools] Remove unused getTargetForTab helper on gDevTools r=ochameau
Depends on D106001

This is only used internally: https://searchfox.org/mozilla-central/search?path=&q=getTargetForTab
Can be inlined and removed from DevToolsShim

Differential Revision: https://phabricator.services.mozilla.com/D106002
2021-02-25 18:02:53 +00:00
Julian Descottes
d0f4645a76 Bug 1694140 - [devtools] Stop using TargetFactory.forTab in devtools code r=perftest-reviewers,ochameau
Depends on D105998

Differential Revision: https://phabricator.services.mozilla.com/D105999
2021-02-25 18:02:51 +00:00
Julian Descottes
12c3715f97 Bug 1688688 - [devtools] Add a simple helper to start devtools for wptrunner r=ladybenko
The webplatform test runner recently added an option to open devtools during their tests.
The current implementation relies on TargetFactory::forTab and gDevTools::showToolbox.
Those methods will most likely change as we move away from targets and start using descriptors.

See previous WPT PR at https://github.com/web-platform-tests/wpt/pull/27309

Differential Revision: https://phabricator.services.mozilla.com/D105740
2021-02-25 18:02:50 +00:00